[linux-linus test] 170737: regressions - FAIL

2022-05-25 Thread osstest service owner
flight 170737 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170737/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-do

[linux-5.4 test] 170736: tolerable FAIL - PUSHED

2022-05-25 Thread osstest service owner
flight 170736 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/170736/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 170724 pass in 170736 test-armhf-armhf-xl-cred

[qemu-mainline test] 170732: tolerable FAIL - PUSHED

2022-05-25 Thread osstest service owner
flight 170732 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170732/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 170721 test-armhf-armhf-libvirt 16 sav

Re: [PATCH 1/2] docs/misra: introduce rules.rst

2022-05-25 Thread Stefano Stabellini
On Wed, 25 May 2022, Andrew Cooper wrote: > On 25/05/2022 01:35, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > Introduce a list of MISRA C rules that apply to the Xen hypervisor. The > > list is in RST format. > > > > Add a mention of the new list to CODING_STYLE. > > > > Signed-o

Re: [PATCH 2/2] docs/misra: add Rule 5.1

2022-05-25 Thread Stefano Stabellini
On Wed, 25 May 2022, Jan Beulich wrote: > On 25.05.2022 02:35, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > Add Rule 5.1, with the additional note that the character limit for Xen > > is 63 characters. > > > > The max length identifiers found by ECLAIR are: > > > > __mitigate_

Re: [PATCH 1/2] docs/misra: introduce rules.rst

2022-05-25 Thread Stefano Stabellini
On Wed, 25 May 2022, Jan Beulich wrote: > On 25.05.2022 02:35, Stefano Stabellini wrote: > > --- a/CODING_STYLE > > +++ b/CODING_STYLE > > @@ -235,3 +235,9 @@ callstack between the initial function call and the > > failure, no error > > is returned. Using domain_crash() requires careful inspecti

Re: [PATCH 1/2] docs/misra: introduce rules.rst

2022-05-25 Thread Stefano Stabellini
On Wed, 25 May 2022, Julien Grall wrote: > Hi Stefano, > > On 25/05/2022 01:35, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > Introduce a list of MISRA C rules that apply to the Xen hypervisor. The > > list is in RST format. > > > > Add a mention of the new list to CODING_STYLE

[xen-unstable test] 170726: tolerable FAIL - PUSHED

2022-05-25 Thread osstest service owner
flight 170726 xen-unstable real [real] flight 170738 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170726/ http://logs.test-lab.xenproject.org/osstest/logs/170738/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

[ovmf test] 170733: all pass - PUSHED

2022-05-25 Thread osstest service owner
flight 170733 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170733/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 07c0c2eb0a5970db614ebce1060fc79d6904bdfd baseline version: ovmf 9c733f0b90b31a7e3711f

Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability

2022-05-25 Thread Chuck Zmudzinski
On 5/25/2022 3:45 AM, Thorsten Leemhuis wrote: On 24.05.22 20:32, Chuck Zmudzinski wrote: On 5/21/22 6:47 AM, Thorsten Leemhuis wrote: On 20.05.22 16:48, Chuck Zmudzinski wrote: On 5/20/2022 10:06 AM, Jan Beulich wrote: On 20.05.2022 15:33, Chuck Zmudzinski wrote: On 5/20/2022 5:41 AM, Jan B

[linux-linus test] 170723: regressions - FAIL

2022-05-25 Thread osstest service owner
flight 170723 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170723/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-do

[PATCH v2] xen/gntdev: Avoid blocking in unmap_grant_pages()

2022-05-25 Thread Demi Marie Obenour
unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was waiting for i915 to free its pages. I also believe this is re

[linux-5.4 test] 170724: regressions - FAIL

2022-05-25 Thread osstest service owner
flight 170724 linux-5.4 real [real] flight 170734 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170724/ http://logs.test-lab.xenproject.org/osstest/logs/170734/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: t

Re: [PATCH] xen/gntdev: Avoid blocking in unmap_grant_pages()

2022-05-25 Thread Demi Marie Obenour
On Wed, May 25, 2022 at 11:17:39AM +0200, Juergen Gross wrote: > On 24.05.22 18:45, Demi Marie Obenour wrote: > > unmap_grant_pages() currently waits for the pages to no longer be used. > > In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a > > deadlock against i915: i915 was wa

[xen-unstable-smoke test] 170730: tolerable all pass - PUSHED

2022-05-25 Thread osstest service owner
flight 170730 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170730/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 170728: all pass - PUSHED

2022-05-25 Thread osstest service owner
flight 170728 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170728/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9c733f0b90b31a7e3711f60da314f2a5cfe5fe8a baseline version: ovmf a21a3438f795deecb24e1

Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops

2022-05-25 Thread Oleksandr
On 24.05.22 21:34, Saravana Kannan wrote: Hello all " On Tue, May 24, 2022 at 9:01 AM Rob Herring wrote: +Saravana On Mon, May 23, 2022 at 06:58:13PM -0700, Stefano Stabellini wrote: On Mon, 23 May 2022, Oleksandr wrote: On Thu, 19 May 2022, Oleksandr wrote: On Wed, May 18, 2022 at 5:0

Re: [PATCH] xsm: refactor and optimize policy loading

2022-05-25 Thread Jan Beulich
On 25.05.2022 16:11, Daniel P. Smith wrote: > On 5/25/22 02:37, Jan Beulich wrote: >> On 24.05.2022 19:42, Daniel P. Smith wrote: >>> On 5/24/22 11:50, Jan Beulich wrote: On 23.05.2022 17:40, Daniel P. Smith wrote: > @@ -36,10 +36,17 @@ int __init xsm_multiboot_policy_init( > { >

Re: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST

2022-05-25 Thread Jan Beulich
On 25.05.2022 16:33, Andrew Cooper wrote: > On 25/05/2022 12:14, Jan Beulich wrote: >> On 25.05.2022 12:52, Andrew Cooper wrote: >>> On 25/05/2022 09:13, Roger Pau Monne wrote: Rename the flag to better note that it's not actually forcing any IPIs to be issued if none is required, but mer

Re: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST

2022-05-25 Thread Roger Pau Monné
On Wed, May 25, 2022 at 10:52:48AM +, Andrew Cooper wrote: > On 25/05/2022 09:13, Roger Pau Monne wrote: > > Rename the flag to better note that it's not actually forcing any IPIs > > to be issued if none is required, but merely avoiding the usage of TLB > > flush assistance (which itself can a

Re: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST

2022-05-25 Thread Andrew Cooper
On 25/05/2022 12:14, Jan Beulich wrote: > On 25.05.2022 12:52, Andrew Cooper wrote: >> On 25/05/2022 09:13, Roger Pau Monne wrote: >>> Rename the flag to better note that it's not actually forcing any IPIs >>> to be issued if none is required, but merely avoiding the usage of TLB >>> flush assistan

Re: [PATCH] xsm: refactor and optimize policy loading

2022-05-25 Thread Daniel P. Smith
On 5/25/22 02:37, Jan Beulich wrote: > On 24.05.2022 19:42, Daniel P. Smith wrote: >> On 5/24/22 11:50, Jan Beulich wrote: >>> On 23.05.2022 17:40, Daniel P. Smith wrote: @@ -36,10 +36,17 @@ int __init xsm_multiboot_policy_init( { int i; module_t *mod = (module_t *)__

[xen-unstable-smoke test] 170725: regressions - FAIL

2022-05-25 Thread osstest service owner
flight 170725 xen-unstable-smoke real [real] flight 170727 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170725/ http://logs.test-lab.xenproject.org/osstest/logs/170727/ Regressions :-( Tests which did not succeed and are blocking, including tests which co

[libvirt test] 170722: regressions - FAIL

2022-05-25 Thread osstest service owner
flight 170722 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170722/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH v2] SUPPORT.md: extend security support for x86 hosts to 12 TiB of memory

2022-05-25 Thread Julien Grall
Hi Jan, On 25/05/2022 12:11, Jan Beulich wrote: On 25.05.2022 12:58, Julien Grall wrote: On 25/05/2022 10:21, Jan Beulich wrote: --- a/SUPPORT.md +++ b/SUPPORT.md @@ -50,7 +50,7 @@ For the Cortex A57 r0p0 - r1p1, see Erra ### Physical Memory -Status, x86: Supported up to 8 TiB.

[qemu-mainline test] 170721: tolerable FAIL - PUSHED

2022-05-25 Thread osstest service owner
flight 170721 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170721/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 170635 test-armhf-armhf-libvirt 16 sav

Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops

2022-05-25 Thread Oleksandr
On 24.05.22 20:59, Stefano Stabellini wrote: Hello Stefano On Tue, 24 May 2022, Oleksandr wrote: On Mon, 23 May 2022, Oleksandr wrote: On Thu, 19 May 2022, Oleksandr wrote: On Wed, May 18, 2022 at 5:06 PM Oleksandr wrote: On 18.05.22 17:32, Arnd Bergmann wrote: On Sat, May 7, 2022 at 7:

Re: [PATCH] tools/xenstore: fix event sending in introduce_domain()

2022-05-25 Thread Julien Grall
Hi Andrew, On 25/05/2022 11:59, Andrew Cooper wrote: On 25/05/2022 11:55, Juergen Gross wrote: Commit fc2b57c9af46 ("xenstored: send an evtchn notification on introduce_domain") introduced a potential NULL dereference in case of Xenstore live update. Fix that by adding an appropriate check. C

Re: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST

2022-05-25 Thread Jan Beulich
On 25.05.2022 12:52, Andrew Cooper wrote: > On 25/05/2022 09:13, Roger Pau Monne wrote: >> Rename the flag to better note that it's not actually forcing any IPIs >> to be issued if none is required, but merely avoiding the usage of TLB >> flush assistance (which itself can avoid the sending of IPIs

Re: [PATCH v2] SUPPORT.md: extend security support for x86 hosts to 12 TiB of memory

2022-05-25 Thread Jan Beulich
On 25.05.2022 12:58, Julien Grall wrote: > On 25/05/2022 10:21, Jan Beulich wrote: >> --- a/SUPPORT.md >> +++ b/SUPPORT.md >> @@ -50,7 +50,7 @@ For the Cortex A57 r0p0 - r1p1, see Erra >> >> ### Physical Memory >> >> -Status, x86: Supported up to 8 TiB. Hosts with more memory are >> su

Re: [PATCH] tools/xenstore: fix event sending in introduce_domain()

2022-05-25 Thread Andrew Cooper
On 25/05/2022 11:55, Juergen Gross wrote: > Commit fc2b57c9af46 ("xenstored: send an evtchn notification on > introduce_domain") introduced a potential NULL dereference in case of > Xenstore live update. > > Fix that by adding an appropriate check. > > Coverity-Id: 1504572 > Fixes: fc2b57c9af46 ("x

Re: [PATCH v2] SUPPORT.md: extend security support for x86 hosts to 12 TiB of memory

2022-05-25 Thread Julien Grall
Hi Jan, On 25/05/2022 10:21, Jan Beulich wrote: c49ee0329ff3 ("SUPPORT.md: limit security support for hosts with very much memory"), as a result of XSA-385, restricted security support to 8 TiB of host memory. While subsequently further restricted for Arm, extend this to 12 TiB on x86, putting i

[PATCH] tools/xenstore: fix event sending in introduce_domain()

2022-05-25 Thread Juergen Gross
Commit fc2b57c9af46 ("xenstored: send an evtchn notification on introduce_domain") introduced a potential NULL dereference in case of Xenstore live update. Fix that by adding an appropriate check. Coverity-Id: 1504572 Fixes: fc2b57c9af46 ("xenstored: send an evtchn notification on introduce_doma

Re: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST

2022-05-25 Thread Andrew Cooper
On 25/05/2022 09:13, Roger Pau Monne wrote: > Rename the flag to better note that it's not actually forcing any IPIs > to be issued if none is required, but merely avoiding the usage of TLB > flush assistance (which itself can avoid the sending of IPIs to remote > processors). > > No functional cha

Re: [PATCH v2] SUPPORT.md: extend security support for x86 hosts to 12 TiB of memory

2022-05-25 Thread George Dunlap
> On May 25, 2022, at 10:21 AM, Jan Beulich wrote: > > c49ee0329ff3 ("SUPPORT.md: limit security support for hosts with very > much memory"), as a result of XSA-385, restricted security support to > 8 TiB of host memory. While subsequently further restricted for Arm, > extend this to 12 TiB on

Re: [PATCH v3 2/2] x86/flushtlb: remove flush_area check on system state

2022-05-25 Thread Roger Pau Monné
On Wed, May 25, 2022 at 10:41:51AM +0200, Jan Beulich wrote: > On 25.05.2022 10:13, Roger Pau Monne wrote: > > Booting with Shadow Stacks leads to the following assert on a debug > > hypervisor: > > > > Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 > > [ Xen-4.17.0-10.24-d x

[PATCH v2] SUPPORT.md: extend security support for x86 hosts to 12 TiB of memory

2022-05-25 Thread Jan Beulich
c49ee0329ff3 ("SUPPORT.md: limit security support for hosts with very much memory"), as a result of XSA-385, restricted security support to 8 TiB of host memory. While subsequently further restricted for Arm, extend this to 12 TiB on x86, putting in place a guest restriction to 8 TiB (or yet less f

Re: [PATCH] xen/gntdev: Avoid blocking in unmap_grant_pages()

2022-05-25 Thread Juergen Gross
On 24.05.22 18:45, Demi Marie Obenour wrote: unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was waiting for i91

[xen-unstable test] 170720: tolerable FAIL

2022-05-25 Thread osstest service owner
flight 170720 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170720/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-installfail pass in 170712 test-amd64-i386-xl-qemuu-debianh

Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen

2022-05-25 Thread Jan Beulich
On 28.04.2022 16:50, Jan Beulich wrote: > The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT > with pat_enabled()") pat_enabled() returning false (because of PAT > initialization being suppressed in the absence of MTRRs being announced > to be available) has become a problem: T

Re: [PATCH] xen/iommu: dt: Check the return value of xsm_deassign_dtdevice()

2022-05-25 Thread Julien Grall
On 24/05/2022 08:54, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 22 May 2022, at 17:59, Julien Grall wrote: From: Julien Grall xsm_deasign_dtdevice() will indicate whether the caller is allowed to issue the operation. So the return value has to be checked. Spotted by clang stat

Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability

2022-05-25 Thread Thorsten Leemhuis
On 25.05.22 10:37, Jan Beulich wrote: > On 25.05.2022 09:45, Thorsten Leemhuis wrote: >> On 24.05.22 20:32, Chuck Zmudzinski wrote: >>> On 5/21/22 6:47 AM, Thorsten Leemhuis wrote: I'm not a developer and I'm don't known the details of this thread and the backstory of the regression, but

Re: [PATCH v3 2/2] x86/flushtlb: remove flush_area check on system state

2022-05-25 Thread Jan Beulich
On 25.05.2022 10:13, Roger Pau Monne wrote: > Booting with Shadow Stacks leads to the following assert on a debug > hypervisor: > > Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 > [ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted ] > CPU:0 > RIP:e008:[] flush_are

Re: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST

2022-05-25 Thread Jan Beulich
On 25.05.2022 10:13, Roger Pau Monne wrote: > Rename the flag to better note that it's not actually forcing any IPIs > to be issued if none is required, but merely avoiding the usage of TLB > flush assistance (which itself can avoid the sending of IPIs to remote > processors). > > No functional ch

Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability

2022-05-25 Thread Jan Beulich
On 25.05.2022 09:45, Thorsten Leemhuis wrote: > On 24.05.22 20:32, Chuck Zmudzinski wrote: >> On 5/21/22 6:47 AM, Thorsten Leemhuis wrote: >>> I'm not a developer and I'm don't known the details of this thread and >>> the backstory of the regression, but it sounds like that's the approach >>> that

Re: [PATCH 1/2] docs/misra: introduce rules.rst

2022-05-25 Thread Jan Beulich
On 25.05.2022 02:35, Stefano Stabellini wrote: > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -235,3 +235,9 @@ callstack between the initial function call and the > failure, no error > is returned. Using domain_crash() requires careful inspection and > documentation of the code to make sure all

[PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST

2022-05-25 Thread Roger Pau Monne
Rename the flag to better note that it's not actually forcing any IPIs to be issued if none is required, but merely avoiding the usage of TLB flush assistance (which itself can avoid the sending of IPIs to remote processors). No functional change expected. Requested-by: Jan Beulich Signed-off-by

[PATCH v3 0/2] x86/mm: fix regression when booting with CET-SS

2022-05-25 Thread Roger Pau Monne
Hello, Following series aim to fix a regression when booting with CET shadow stacks enabled. First patch is a pre-req non-functional change, second patch is the actual fix. Thanks, Roger. Roger Pau Monne (2): x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST x86/flushtlb: remove flush_area

[PATCH v3 2/2] x86/flushtlb: remove flush_area check on system state

2022-05-25 Thread Roger Pau Monne
Booting with Shadow Stacks leads to the following assert on a debug hypervisor: Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 [ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted ] CPU:0 RIP:e008:[] flush_area_mask+0x40/0x13e [...] Xen call trace: [] R flush_area

Re: [PATCH 2/2] docs/misra: add Rule 5.1

2022-05-25 Thread Jan Beulich
On 25.05.2022 02:35, Stefano Stabellini wrote: > From: Stefano Stabellini > > Add Rule 5.1, with the additional note that the character limit for Xen > is 63 characters. > > The max length identifiers found by ECLAIR are: > > __mitigate_spectre_bhb_clear_insn_start > domain_pause_by_systemcontr

Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability

2022-05-25 Thread Juergen Gross
On 25.05.22 09:45, Thorsten Leemhuis wrote: On 24.05.22 20:32, Chuck Zmudzinski wrote: On 5/21/22 6:47 AM, Thorsten Leemhuis wrote: On 20.05.22 16:48, Chuck Zmudzinski wrote: On 5/20/2022 10:06 AM, Jan Beulich wrote: On 20.05.2022 15:33, Chuck Zmudzinski wrote: On 5/20/2022 5:41 AM, Jan Be

Re: 回复: [PATCH v5 3/6] arm64/find_next_bit: Remove ext2_swab()

2022-05-25 Thread Julien Grall
Hi, On 24/05/2022 02:35, Lin Liu (刘林) wrote: Hi, On 23/05/2022 15:50, Lin Liu wrote: ext2 has nothing to do with this logic. You have again not addressed my comment. If you don't understand my comment then please ask. Cheers, -- Julien Grall Sorry I missed this one as I saw this

Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state

2022-05-25 Thread Jan Beulich
On 25.05.2022 09:46, Roger Pau Monné wrote: > On Wed, May 25, 2022 at 09:34:32AM +0200, Jan Beulich wrote: >> On 25.05.2022 09:21, Roger Pau Monné wrote: >>> On Wed, May 25, 2022 at 08:02:17AM +0200, Jan Beulich wrote: On 24.05.2022 18:46, Roger Pau Monné wrote: > Would you be fine with ad

Re: [PATCH] init-dom0less: better snprintf checks

2022-05-25 Thread Julien Grall
Hi Stefano, On 25/05/2022 00:35, Stefano Stabellini wrote: From: Stefano Stabellini snprintf returns the number of characters printed. A return value of size or more means that the output was truncated. Add a check for that in init-dom0less. Signed-off-by: Stefano Stabellini Acked-by: Jul

Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state

2022-05-25 Thread Roger Pau Monné
On Wed, May 25, 2022 at 09:34:32AM +0200, Jan Beulich wrote: > On 25.05.2022 09:21, Roger Pau Monné wrote: > > On Wed, May 25, 2022 at 08:02:17AM +0200, Jan Beulich wrote: > >> On 24.05.2022 18:46, Roger Pau Monné wrote: > >>> Would you be fine with adding: > >>> > >>> Note that FLUSH_FORCE_IPI doe

Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability

2022-05-25 Thread Thorsten Leemhuis
On 24.05.22 20:32, Chuck Zmudzinski wrote: > On 5/21/22 6:47 AM, Thorsten Leemhuis wrote: >> On 20.05.22 16:48, Chuck Zmudzinski wrote: >>> On 5/20/2022 10:06 AM, Jan Beulich wrote: On 20.05.2022 15:33, Chuck Zmudzinski wrote: > On 5/20/2022 5:41 AM, Jan Beulich wrote: >> On 20.05.2

Re: [PATCH 2/2] docs/misra: add Rule 5.1

2022-05-25 Thread Julien Grall
Hi, On 25/05/2022 01:35, Stefano Stabellini wrote: From: Stefano Stabellini Add Rule 5.1, with the additional note that the character limit for Xen is 63 characters. 63 is a bit an odd numbers. Why not 64? The max length identifiers found by ECLAIR are: __mitigate_spectre_bhb_clear_insn_

Re: [PATCH 1/2] docs/misra: introduce rules.rst

2022-05-25 Thread Julien Grall
Hi Stefano, On 25/05/2022 01:35, Stefano Stabellini wrote: From: Stefano Stabellini Introduce a list of MISRA C rules that apply to the Xen hypervisor. The list is in RST format. Add a mention of the new list to CODING_STYLE. Signed-off-by: Bertrand Marquis Signed-off-by: Stefano Stabellini

Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state

2022-05-25 Thread Jan Beulich
On 25.05.2022 09:21, Roger Pau Monné wrote: > On Wed, May 25, 2022 at 08:02:17AM +0200, Jan Beulich wrote: >> On 24.05.2022 18:46, Roger Pau Monné wrote: >>> Would you be fine with adding: >>> >>> Note that FLUSH_FORCE_IPI doesn't need to be handled explicitly, as >>> it's main purpose is to preven

Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state

2022-05-25 Thread Roger Pau Monné
On Wed, May 25, 2022 at 08:02:17AM +0200, Jan Beulich wrote: > On 24.05.2022 18:46, Roger Pau Monné wrote: > > On Tue, May 24, 2022 at 05:27:35PM +0200, Jan Beulich wrote: > >> On 24.05.2022 12:50, Roger Pau Monne wrote: > >>> Booting with Shadow Stacks leads to the following assert on a debug > >>