[PATCH v6 8/8] xen/x86: use INFO level for node's without memory log message

2022-06-09 Thread Wei Chen
In previous code, Xen was using KERN_WARNING for log message when Xen found a node without memory. Xen will print this warning message, and said that this may be an BIOS Bug or mis-configured hardware. But actually, this warning is bogus, because in an NUMA setting, nodes can only have processors,

[PATCH v6 6/8] xen/x86: use paddr_t for addresses in NUMA node structure

2022-06-09 Thread Wei Chen
NUMA node structure "struct node" is using u64 as node memory range. In order to make other architectures can reuse this NUMA node relative code, we replace the u64 to paddr_t. And use pfn_to_paddr and paddr_to_pfn to replace explicit shift operations. The relate PRIx64 in print messages have been

[PATCH v6 5/8] xen/arm: use !CONFIG_NUMA to keep fake NUMA API

2022-06-09 Thread Wei Chen
We have introduced CONFIG_NUMA in a previous patch. And this option is enabled only on x86 at the current stage. In a follow up patch, we will enable this option for Arm. But we still want users to be able to disable the CONFIG_NUMA via Kconfig. In this case, keep the fake NUMA API, will make Arm c

[PATCH v6 7/8] xen/x86: add detection of memory interleaves for different nodes

2022-06-09 Thread Wei Chen
One NUMA node may contain several memory blocks. In current Xen code, Xen will maintain a node memory range for each node to cover all its memory blocks. But here comes the problem, in the gap of one node's two memory blocks, if there are some memory blocks don't belong to this node (remote memory

[PATCH v6 3/8] xen: introduce an arch helper for default dma zone status

2022-06-09 Thread Wei Chen
In current code, when Xen is running in a multiple nodes NUMA system, it will set dma_bitsize in end_boot_allocator to reserve some low address memory as DMA zone. There are some x86 implications in the implementation. Because on x86, memory starts from 0. On a multiple-nodes NUMA system, if a sin

[PATCH v6 2/8] xen/arm: Keep memory nodes in device tree when Xen boots from EFI

2022-06-09 Thread Wei Chen
In current code, when Xen is booting from EFI, it will delete all memory nodes in device tree. This would work well in current stage, because Xen can get memory map from EFI system table. However, EFI system table cannot completely replace memory nodes of device tree. EFI system table doesn't conta

[PATCH v6 4/8] xen: decouple NUMA from ACPI in Kconfig

2022-06-09 Thread Wei Chen
In current Xen code only implements x86 ACPI-based NUMA support. So in Xen Kconfig system, NUMA equals to ACPI_NUMA. x86 selects NUMA by default, and CONFIG_ACPI_NUMA is hardcode in config.h. In a follow-up patch, we will introduce support for NUMA using the device tree. That means we will have tw

[PATCH v6 0/8] Device tree based NUMA support for Arm - Part#1

2022-06-09 Thread Wei Chen
(The Arm device tree based NUMA support patch set contains 35 patches. In order to make stuff easier for reviewers, I split them into 3 parts: 1. Preparation. I have re-sorted the patch series. And moved independent patches to the head of the series. 2. Move generically usable code from x86 to c

[PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm

2022-06-09 Thread Wei Chen
x86 is using compiler feature testing to decide EFI build enable or not. When EFI build is disabled, x86 will use an efi/stub.c file to replace efi/runtime.c for build objects. Following this idea, we introduce a stub file for Arm, but use CONFIG_ARM_EFI to decide EFI build enable or not. And the

[qemu-mainline test] 170902: FAIL

2022-06-09 Thread osstest service owner
flight 170902 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170902/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-rtds broken in 170891 Tests wh

[xen-4.16-testing test] 170901: regressions - FAIL

2022-06-09 Thread osstest service owner
flight 170901 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/170901/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-shadow 8 xen-boot fail REGR. vs. 170871 test-amd64-cor

[GIT PULL] xen: branch for v5.19-rc2

2022-06-09 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.19a-rc2-tag xen: branch for v5.19-rc2 It contains: - a small cleanup removing "export" of an __init function - a small series adding a new infrastructure for platform flags - a seri

Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE

2022-06-09 Thread Jacob Pan
Hi Peter, On Wed, 08 Jun 2022 16:27:27 +0200, Peter Zijlstra wrote: > Commit c227233ad64c ("intel_idle: enable interrupts before C1 on > Xeons") wrecked intel_idle in two ways: > > - must not have tracing in idle functions > - must return with IRQs disabled > > Additionally, it added a branc

[xen-unstable test] 170897: regressions - FAIL

2022-06-09 Thread osstest service owner
flight 170897 xen-unstable real [real] flight 170907 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170897/ http://logs.test-lab.xenproject.org/osstest/logs/170907/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

[PATCH] add more MISRA C rules to docs/misra/rules.rst

2022-06-09 Thread Stefano Stabellini
Add the new MISRA C rules agreed by the MISRA C working group to docs/misra/rules.rst. Signed-off-by: Stefano Stabellini --- I added the rules that we agreed upon this morning together with all the notes we discussed, in particular: - macros as macro parameters at invocation time for Rule 5.3

[linux-5.4 test] 170895: tolerable FAIL - PUSHED

2022-06-09 Thread osstest service owner
flight 170895 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/170895/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 170887 pass in 170895 test-armhf-armhf-xl-credit

[linux-linus test] 170894: regressions - FAIL

2022-06-09 Thread osstest service owner
flight 170894 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170894/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-li

[PATCH v5 2/5] grub-mkconfig linux_xen: Fix quadratic algorithm for sorting menu items

2022-06-09 Thread Mathieu Desnoyers
The current implementation of the 20_linux_xen script implements its menu items sorting in bash with a quadratic algorithm, calling "sed", "sort", "head", and "grep" to compare versions between individual lines, which is annoyingly slow for kernel developers who can easily end up with 50-100 kernel

Re: [RFC PATCH 2/2] xen/grant-table: Use unpopulated DMAable pages instead of real RAM ones

2022-06-09 Thread Oleksandr
On 04.06.22 00:19, Stefano Stabellini wrote: Hello Stefano Thank you for having a look and sorry for the late response. On Tue, 17 May 2022, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Depends on CONFIG_XEN_UNPOPULATED_ALLOC. If enabled then unpopulated DMAable (contiguous) pa

[xen-unstable-smoke test] 170900: tolerable all pass - PUSHED

2022-06-09 Thread osstest service owner
flight 170900 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170900/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[libvirt test] 170892: regressions - FAIL

2022-06-09 Thread osstest service owner
flight 170892 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170892/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH v2] x86emul/test: encourage compiler to use more embedded broadcast

2022-06-09 Thread Andrew Cooper
On 09/06/2022 16:35, Jan Beulich wrote: > For one it was an oversight to leave dup_{hi,lo}() undefined for 512-bit > vector size. And then in FMA testing we can also arrange for the > compiler to (hopefully) recognize broadcasting potential. Plus we can > replace the broadcast(1) use in the addsub(

[PATCH] EFI: strip xen.efi when putting it on the EFI partition

2022-06-09 Thread Jan Beulich
With debug info retained, xen.efi can be quite large. Unlike for xen.gz there's no intermediate step (mkelf32 there) involved which would strip debug info kind of as a side effect. While the installing of xen.efi on the EFI partition is an optional step (intended to be a courtesy to the developer),

Re: [PATCH] x86/mm: further simplify cleanup_page_mappings()

2022-06-09 Thread Andrew Cooper
On 09/06/2022 16:39, Jan Beulich wrote: > With the removal of update_xen_mappings() there's no need anymore for a > 2nd error code variable to transiently hold the IOMMU unmap return > value. > > Signed-off-by: Jan Beulich Oh - I'd not even spotted that simplification. Acked-by: Andrew Cooper

[PATCH] x86/mm: further simplify cleanup_page_mappings()

2022-06-09 Thread Jan Beulich
With the removal of update_xen_mappings() there's no need anymore for a 2nd error code variable to transiently hold the IOMMU unmap return value. Signed-off-by: Jan Beulich --- I have to admit that I was tempted to get rid of PAGE_ORDER_4K at this occasion, as it feels awkward to me to have such

[PATCH v2] x86emul/test: encourage compiler to use more embedded broadcast

2022-06-09 Thread Jan Beulich
For one it was an oversight to leave dup_{hi,lo}() undefined for 512-bit vector size. And then in FMA testing we can also arrange for the compiler to (hopefully) recognize broadcasting potential. Plus we can replace the broadcast(1) use in the addsub() surrogate with inline assembly explicitly usin

[PATCH] MAINTAINERS: drop XSM maintainer

2022-06-09 Thread Jan Beulich
While mail hasn't been bouncing, Daniel has not been responding to patch submissions or otherwise interacting with the community for several years. Move maintainership to THE REST in kind of an unusual way, with the goal to avoid - orphaning the component, - repeating all THE REST members here, - r

Re: [XEN PATCH 1/4] build: xen/include: use if_changed

2022-06-09 Thread Bertrand Marquis
Hi Antony, > On 9 Jun 2022, at 13:55, Anthony PERARD wrote: > > On Thu, Jun 09, 2022 at 11:51:20AM +, Bertrand Marquis wrote: >> Hi, >> >>> On 9 Jun 2022, at 11:26, Jan Beulich wrote: >>> >>> On 09.06.2022 12:16, Bertrand Marquis wrote: With this change, compiling for x86 is now endi

[PULL 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug()

2022-06-09 Thread Anthony PERARD
From: Bernhard Beschow This function was declared in a generic and public header, implemented in a device-specific source file but only used in xen_platform. Given its 'aux' parameter, this function is more xen-specific than piix-specific. Also, the hardcoded magic constants seem to be generic an

[qemu-mainline test] 170891: regressions - trouble: broken/fail/pass

2022-06-09 Thread osstest service owner
flight 170891 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170891/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-rtds broken test-amd64-i386-libvirt-qemuu-debianhvm-

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Gerd Hoffmann
Hi, > > > > (1) add refresh_rate > > > > (2) update users one by one > > > > (3) finally drop update_interval when no user is left. > > > > > > > > thanks, > > > > Gerd > > > > > > > > > > I think 1 and 3 should have to be done once since refresh_rate and > > > update_interval would inter

Re: [PATCH 2/2] xen/heap: pass order to free_heap_pages() in heap init

2022-06-09 Thread Jan Beulich
On 09.06.2022 10:30, Julien Grall wrote: > From: Hongyan Xia > > The idea is to split the range into multiple aligned power-of-2 regions > which only needs to call free_heap_pages() once each. We check the least > significant set bit of the start address and use its bit index as the > order of th

Re: [PATCH 1/2] xen/heap: Split init_heap_pages() in two

2022-06-09 Thread Julien Grall
Hi, On 09/06/2022 14:12, Jan Beulich wrote: On 09.06.2022 14:33, Julien Grall wrote: On 09/06/2022 13:09, Jan Beulich wrote: On 09.06.2022 10:30, Julien Grall wrote: From: Julien Grall At the moment, init_heap_pages() will call free_heap_pages() page by page. To reduce the time to initializ

Re: [PATCH 1/2] xen/heap: Split init_heap_pages() in two

2022-06-09 Thread Jan Beulich
On 09.06.2022 14:33, Julien Grall wrote: > On 09/06/2022 13:09, Jan Beulich wrote: >> On 09.06.2022 10:30, Julien Grall wrote: >>> From: Julien Grall >>> >>> At the moment, init_heap_pages() will call free_heap_pages() page >>> by page. To reduce the time to initialize the heap, we will want >>> t

Re: [PATCH 24/36] printk: Remove trace_.*_rcuidle() usage

2022-06-09 Thread Petr Mladek
On Thu 2022-06-09 12:02:04, Peter Zijlstra wrote: > On Thu, Jun 09, 2022 at 11:16:46AM +0200, Petr Mladek wrote: > > On Wed 2022-06-08 16:27:47, Peter Zijlstra wrote: > > > The problem, per commit fc98c3c8c9dc ("printk: use rcuidle console > > > tracepoint"), was printk usage from the cpuidle path

Re: [PATCH 24/36] printk: Remove trace_.*_rcuidle() usage

2022-06-09 Thread Petr Mladek
On Thu 2022-06-09 20:30:58, Sergey Senozhatsky wrote: > My emails are getting rejected... Let me try web-interface Bad day for mail sending. I have problems as well ;-) > Kudos to Petr for the questions and thanks to PeterZ for the answers. > > On Thu, Jun 9, 2022 at 7:02 PM Peter Zijlstra wrot

Re: [XEN PATCH 1/4] build: xen/include: use if_changed

2022-06-09 Thread Anthony PERARD
On Thu, Jun 09, 2022 at 11:51:20AM +, Bertrand Marquis wrote: > Hi, > > > On 9 Jun 2022, at 11:26, Jan Beulich wrote: > > > > On 09.06.2022 12:16, Bertrand Marquis wrote: > >> With this change, compiling for x86 is now ending up in: > >> CHK include/headers99.chk > >> make[9]: execvp: /b

Re: [XEN PATCH 1/4] build: xen/include: use if_changed

2022-06-09 Thread Bertrand Marquis
Hi, > On 9 Jun 2022, at 13:16, Jan Beulich wrote: > > On 09.06.2022 13:51, Bertrand Marquis wrote: >>> On 9 Jun 2022, at 11:26, Jan Beulich wrote: >>> On 09.06.2022 12:16, Bertrand Marquis wrote: > On 1 Jun 2022, at 17:59, Anthony PERARD wrote: > > Use "define" for the headers*_ch

Re: [PATCH 1/2] xen/heap: Split init_heap_pages() in two

2022-06-09 Thread Julien Grall
Hi Jan, On 09/06/2022 13:09, Jan Beulich wrote: On 09.06.2022 10:30, Julien Grall wrote: From: Julien Grall At the moment, init_heap_pages() will call free_heap_pages() page by page. To reduce the time to initialize the heap, we will want to provide multiple pages at the same time. init_heap

[xen-unstable-smoke test] 170899: tolerable all pass - PUSHED

2022-06-09 Thread osstest service owner
flight 170899 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170899/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: MOVING COMMUNITY CALL Call for agenda items for 9 June Community Call @ 1500 UTC

2022-06-09 Thread George Dunlap
> On 9 Jun 2022, at 12:24, Jan Beulich wrote: > > On 09.06.2022 13:11, Roberto Bagnara wrote: >> On 07/06/22 04:17, Stefano Stabellini wrote: >>> # Rule 9.1 "The value of an object with automatic storage duration shall >>> not be read before it has been set" >>> >>> The question is whether -W

Re: [XEN PATCH 1/4] build: xen/include: use if_changed

2022-06-09 Thread Jan Beulich
On 09.06.2022 13:51, Bertrand Marquis wrote: >> On 9 Jun 2022, at 11:26, Jan Beulich wrote: >> On 09.06.2022 12:16, Bertrand Marquis wrote: On 1 Jun 2022, at 17:59, Anthony PERARD wrote: Use "define" for the headers*_chk commands as otherwise the "#" is interpreted as a commen

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Akihiko Odaki
On 2022/06/09 21:02, Gerd Hoffmann wrote: On Thu, Jun 09, 2022 at 08:45:41PM +0900, Akihiko Odaki wrote: On 2022/06/09 19:28, Gerd Hoffmann wrote: --- a/include/ui/console.h +++ b/include/ui/console.h @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { int yoff; uint32_t width;

Re: [PATCH 1/2] xen/heap: Split init_heap_pages() in two

2022-06-09 Thread Jan Beulich
On 09.06.2022 10:30, Julien Grall wrote: > From: Julien Grall > > At the moment, init_heap_pages() will call free_heap_pages() page > by page. To reduce the time to initialize the heap, we will want > to provide multiple pages at the same time. > > init_heap_pages() is now split in two parts: >

Xen Security Advisory 401 v2 (CVE-2022-26362) - x86 pv: Race condition in typeref acquisition

2022-06-09 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2022-26362 / XSA-401 version 2 x86 pv: Race condition in typeref acquisition UPDATES IN VERSION 2 Update 4.16 and 4.15 baselines. Public releas

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Gerd Hoffmann
On Thu, Jun 09, 2022 at 08:45:41PM +0900, Akihiko Odaki wrote: > On 2022/06/09 19:28, Gerd Hoffmann wrote: > > > --- a/include/ui/console.h > > > +++ b/include/ui/console.h > > > @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { > > > int yoff; > > > uint32_t width; > > > uin

Re: [XEN PATCH 1/4] build: xen/include: use if_changed

2022-06-09 Thread Bertrand Marquis
Hi, > On 9 Jun 2022, at 11:26, Jan Beulich wrote: > > On 09.06.2022 12:16, Bertrand Marquis wrote: >>> On 1 Jun 2022, at 17:59, Anthony PERARD wrote: >>> >>> Use "define" for the headers*_chk commands as otherwise the "#" >>> is interpreted as a comment and make can't find the end of >>> $(for

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Akihiko Odaki
On 2022/06/09 19:28, Gerd Hoffmann wrote: --- a/include/ui/console.h +++ b/include/ui/console.h @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { int yoff; uint32_t width; uint32_t height; +uint32_t refresh_rate; } QemuUIInfo; /* cursor data format is 32bit RGB

Re: [PATCH 24/36] printk: Remove trace_.*_rcuidle() usage

2022-06-09 Thread Sergey Senozhatsky
My emails are getting rejected... Let me try web-interface Kudos to Petr for the questions and thanks to PeterZ for the answers. On Thu, Jun 9, 2022 at 7:02 PM Peter Zijlstra wrote: > This is the tracepoint used to spool all of printk into ftrace, I > suspect there's users, but I haven't used it

Re: MISRA C meeting tomorrow, was: MOVING COMMUNITY CALL Call for agenda items for 9 June Community Call @ 1500 UTC

2022-06-09 Thread Jan Beulich
On 09.06.2022 13:17, Roberto Bagnara wrote: > On 09/06/22 09:04, Jan Beulich wrote: >> On 09.06.2022 03:20, Stefano Stabellini wrote: >>> Finally, for Rule 13.2, I updated the link to ECLAIR's results. There >>> are a lot more violations than just 4, but I don't know if they are >>> valid or false

Re: MOVING COMMUNITY CALL Call for agenda items for 9 June Community Call @ 1500 UTC

2022-06-09 Thread Jan Beulich
On 09.06.2022 13:11, Roberto Bagnara wrote: > On 07/06/22 04:17, Stefano Stabellini wrote: > > # Rule 9.1 "The value of an object with automatic storage duration shall > not be read before it has been set" > > > > The question is whether -Wuninitalised already covers this case or not. > > I th

Re: [PATCH v5 7/8] xen/x86: add detection of memory interleaves for different nodes

2022-06-09 Thread Jan Beulich
On 06.06.2022 06:09, Wei Chen wrote: > v4 -> v5: > 1. Remove "nd->end == end && nd->start == start" from >conflicting_memblks. > 2. Use case NO_CONFLICT instead of "default". > 3. Correct wrong "node" to "pxm" in print message. > 4. Remove unnecesary "else" to remove the indent depth. > 5. Conv

Re: MISRA C meeting tomorrow, was: MOVING COMMUNITY CALL Call for agenda items for 9 June Community Call @ 1500 UTC

2022-06-09 Thread Roberto Bagnara
On 09/06/22 09:04, Jan Beulich wrote: On 09.06.2022 03:20, Stefano Stabellini wrote: Finally, for Rule 13.2, I updated the link to ECLAIR's results. There are a lot more violations than just 4, but I don't know if they are valid or false positives. I've picked just the one case in xen/common/e

Re: MOVING COMMUNITY CALL Call for agenda items for 9 June Community Call @ 1500 UTC

2022-06-09 Thread Roberto Bagnara
On 07/06/22 04:17, Stefano Stabellini wrote: > # Rule 9.1 "The value of an object with automatic storage duration shall not be read before it has been set" > > The question is whether -Wuninitalised already covers this case or not. > I think it does. > > Eclair is reporting a few issues where var

Re: [PATCH 33/36] cpuidle,omap3: Use WFI for omap3_pm_idle()

2022-06-09 Thread Peter Zijlstra
On Wed, Jun 08, 2022 at 06:28:33PM +0200, Arnd Bergmann wrote: > On Wed, Jun 8, 2022 at 4:27 PM Peter Zijlstra wrote: > > > > arch_cpu_idle() is a very simple idle interface and exposes only a > > single idle state and is expected to not require RCU and not do any > > tracing/instrumentation. > >

Re: [PATCH 24/36] printk: Remove trace_.*_rcuidle() usage

2022-06-09 Thread Petr Mladek
Sending again. The previous attempt was rejected by several recipients. It was caused by a mail server changes on my side. I am sorry for spamming those who got the 1st mail already. On Wed 2022-06-08 16:27:47, Peter Zijlstra wrote: > The problem, per commit fc98c3c8c9dc ("printk: use rcuidle con

Re: [PATCH 33/36] cpuidle,omap3: Use WFI for omap3_pm_idle()

2022-06-09 Thread Peter Zijlstra
On Thu, Jun 09, 2022 at 10:39:22AM +0300, Tony Lindgren wrote: > * Arnd Bergmann [220608 18:18]: > > On Wed, Jun 8, 2022 at 4:27 PM Peter Zijlstra wrote: > > > > > > arch_cpu_idle() is a very simple idle interface and exposes only a > > > single idle state and is expected to not require RCU and n

Re: [PATCH 24/36] printk: Remove trace_.*_rcuidle() usage

2022-06-09 Thread Petr Mladek
On Wed 2022-06-08 16:27:47, Peter Zijlstra wrote: > The problem, per commit fc98c3c8c9dc ("printk: use rcuidle console > tracepoint"), was printk usage from the cpuidle path where RCU was > already disabled. > > Per the patches earlier in this series, this is no longer the case. My understanding

Re: [PATCH 24/36] printk: Remove trace_.*_rcuidle() usage

2022-06-09 Thread Peter Zijlstra
On Thu, Jun 09, 2022 at 11:16:46AM +0200, Petr Mladek wrote: > On Wed 2022-06-08 16:27:47, Peter Zijlstra wrote: > > The problem, per commit fc98c3c8c9dc ("printk: use rcuidle console > > tracepoint"), was printk usage from the cpuidle path where RCU was > > already disabled. > > > > Per the patch

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Gerd Hoffmann
> --- a/include/ui/console.h > +++ b/include/ui/console.h > @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { > int yoff; > uint32_t width; > uint32_t height; > +uint32_t refresh_rate; > } QemuUIInfo; > > /* cursor data format is 32bit RGBA */ > @@ -426,7 +427,6 @@ typ

Re: [XEN PATCH 1/4] build: xen/include: use if_changed

2022-06-09 Thread Jan Beulich
On 09.06.2022 12:16, Bertrand Marquis wrote: >> On 1 Jun 2022, at 17:59, Anthony PERARD wrote: >> >> Use "define" for the headers*_chk commands as otherwise the "#" >> is interpreted as a comment and make can't find the end of >> $(foreach,). >> >> Adding several .PRECIOUS as without them `make` d

[PATCH v6 06/12] IOMMU/x86: prefill newly allocate page tables

2022-06-09 Thread Jan Beulich
Page tables are used for two purposes after allocation: They either start out all empty, or they are filled to replace a superpage. Subsequently, to replace all empty or fully contiguous page tables, contiguous sub-regions will be recorded within individual page tables. Install the initial set of m

[PATCH v6 11/12] IOMMU/x86: add perf counters for page table splitting / coalescing

2022-06-09 Thread Jan Beulich
Signed-off-by: Jan Beulich Reviewed-by: Kevin tian Reviewed-by: Roger Pau Monné --- v3: New. --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -125,4 +125,7 @@ PERFCOUNTER(realmode_exits, "vmexit PERFCOUNTER(pauseloop_exits, "vmexits from Pause-L

[PATCH v6 12/12] VT-d: fold dma_pte_clear_one() into its only caller

2022-06-09 Thread Jan Beulich
This way intel_iommu_unmap_page() ends up quite a bit more similar to intel_iommu_map_page(). No functional change intended. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monné --- v5: Re-base of changes earlier in the series. v4: New. --- a/xen/drivers/passthrough

[PATCH v6 02/12] IOMMU/x86: new command line option to suppress use of superpage mappings

2022-06-09 Thread Jan Beulich
Before actually enabling their use, provide a means to suppress it in case of problems. Note that using the option can also affect the sharing of page tables in the VT-d / EPT combination: If EPT would use large page mappings but the option is in effect, page table sharing would be suppressed (to p

Re: [PATCH v2] xen: Add MISRA support to cppcheck make rule

2022-06-09 Thread Bertrand Marquis
Hi Jan, > On 9 Jun 2022, at 11:12, Jan Beulich wrote: > > On 09.06.2022 11:34, Bertrand Marquis wrote: >> cppcheck MISRA addon can be used to check for non compliance to some of >> the MISRA standard rules. >> >> Add a CPPCHECK_MISRA variable that can be set to "y" using make command >> line to

[PATCH v6 10/12] VT-d: replace all-contiguous page tables by superpage mappings

2022-06-09 Thread Jan Beulich
When a page table ends up with all contiguous entries (including all identical attributes), it can be replaced by a superpage entry at the next higher level. The page table itself can then be scheduled for freeing. The adjustment to LEVEL_MASK is merely to avoid leaving a latent trap for whenever

[PATCH v6 09/12] AMD/IOMMU: replace all-contiguous page tables by superpage mappings

2022-06-09 Thread Jan Beulich
When a page table ends up with all contiguous entries (including all identical attributes), it can be replaced by a superpage entry at the next higher level. The page table itself can then be scheduled for freeing. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné --- Unlike the freeing of

[PATCH v6 08/12] VT-d: free all-empty page tables

2022-06-09 Thread Jan Beulich
When a page table ends up with no present entries left, it can be replaced by a non-present entry at the next higher level. The page table itself can then be scheduled for freeing. Note that while its output isn't used there yet, pt_update_contig_markers() right away needs to be called in all plac

[PATCH v6 07/12] AMD/IOMMU: free all-empty page tables

2022-06-09 Thread Jan Beulich
When a page table ends up with no present entries left, it can be replaced by a non-present entry at the next higher level. The page table itself can then be scheduled for freeing. Note that while its output isn't used there yet, pt_update_contig_markers() right away needs to be called in all plac

[PATCH v6 05/12] x86: introduce helper for recording degree of contiguity in page tables

2022-06-09 Thread Jan Beulich
This is a re-usable helper (kind of a template) which gets introduced without users so that the individual subsequent patches introducing such users can get committed independently of one another. See the comment at the top of the new file. To demonstrate the effect, if a page table had just 16 en

[PATCH v6 04/12] VT-d: allow use of superpage mappings

2022-06-09 Thread Jan Beulich
... depending on feature availability (and absence of quirks). Also make the page table dumping function aware of superpages. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monné --- v6: Re-base over addition of "iommu=no-superpages" command line option. v5: In intel

[PATCH v6 03/12] AMD/IOMMU: allow use of superpage mappings

2022-06-09 Thread Jan Beulich
No separate feature flags exist which would control availability of these; the only restriction is HATS (establishing the maximum number of page table levels in general), and even that has a lower bound of 4. Thus we can unconditionally announce 2M and 1G mappings. (Via non- default page sizes the

Re: [XEN PATCH 1/4] build: xen/include: use if_changed

2022-06-09 Thread Bertrand Marquis
Hi Anthony, > On 1 Jun 2022, at 17:59, Anthony PERARD wrote: > > Use "define" for the headers*_chk commands as otherwise the "#" > is interpreted as a comment and make can't find the end of > $(foreach,). > > Adding several .PRECIOUS as without them `make` deletes the > intermediate targets. Th

[PATCH v6 01/12] IOMMU/x86: support freeing of pagetables

2022-06-09 Thread Jan Beulich
For vendor specific code to support superpages we need to be able to deal with a superpage mapping replacing an intermediate page table (or hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is needed to free individual page tables while a domain is still alive. Since the freeing

[PATCH v6 00/12] IOMMU: superpage support when not sharing pagetables

2022-06-09 Thread Jan Beulich
For a long time we've been rather inefficient with IOMMU page table management when not sharing page tables, i.e. in particular for PV (and further specifically also for PV Dom0) and AMD (where nowadays we never share page tables). While up to about 3.5 years ago AMD code had logic to un-shatter pa

Re: [PATCH v2] xen: Add MISRA support to cppcheck make rule

2022-06-09 Thread Jan Beulich
On 09.06.2022 11:34, Bertrand Marquis wrote: > cppcheck MISRA addon can be used to check for non compliance to some of > the MISRA standard rules. > > Add a CPPCHECK_MISRA variable that can be set to "y" using make command > line to generate a cppcheck report including cppcheck misra checks. > >

Re: [PATCH v2 3/3] x86/vmx: implement Notify VM Exit

2022-06-09 Thread Roger Pau Monné
On Thu, Jun 09, 2022 at 03:39:33PM +0800, Xiaoyao Li wrote: > On 6/9/2022 3:04 PM, Tian, Kevin wrote: > > +Chenyi/Xiaoyao who worked on the KVM support. Presumably > > similar opens have been discussed in KVM hence they have the > > right background to comment here. > > > > > From: Roger Pau Monne

[PATCH v2] xen: Add MISRA support to cppcheck make rule

2022-06-09 Thread Bertrand Marquis
cppcheck MISRA addon can be used to check for non compliance to some of the MISRA standard rules. Add a CPPCHECK_MISRA variable that can be set to "y" using make command line to generate a cppcheck report including cppcheck misra checks. When MISRA checking is enabled, a file with a text descript

Re: [PATCH v6 2/9] xen: do not free reserved memory into heap

2022-06-09 Thread Julien Grall
Hi, On 09/06/2022 06:54, Penny Zheng wrote: -Original Message- From: Julien Grall Sent: Tuesday, June 7, 2022 5:13 PM To: Penny Zheng ; xen-devel@lists.xenproject.org Cc: Wei Chen ; Stefano Stabellini ; Bertrand Marquis ; Volodymyr Babchuk ; Andrew Cooper ; George Dunlap ; Jan Beulic

[PATCH 0/2] xen/mm: Optimize init_heap_pages()

2022-06-09 Thread Julien Grall
From: Julien Grall Hi all, As part of the Live-Update work, we noticed that a big part Xen boot is spent to add pages in the heap. For instance, on when running Xen in a nested envionment on a c5.metal, it takes ~1.5s. This small series is reworking init_heap_pages() to give the pages to free_h

[PATCH 1/2] xen/heap: Split init_heap_pages() in two

2022-06-09 Thread Julien Grall
From: Julien Grall At the moment, init_heap_pages() will call free_heap_pages() page by page. To reduce the time to initialize the heap, we will want to provide multiple pages at the same time. init_heap_pages() is now split in two parts: - init_heap_pages(): will break down the range in mul

[PATCH 2/2] xen/heap: pass order to free_heap_pages() in heap init

2022-06-09 Thread Julien Grall
From: Hongyan Xia The idea is to split the range into multiple aligned power-of-2 regions which only needs to call free_heap_pages() once each. We check the least significant set bit of the start address and use its bit index as the order of this increment. This makes sure that each increment is

[xen-unstable test] 170890: tolerable FAIL - PUSHED

2022-06-09 Thread osstest service owner
flight 170890 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170890/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail like 170877 test-amd64-amd64-xl-qemut-win7-amd64

Re: [PATCH 33/36] cpuidle,omap3: Use WFI for omap3_pm_idle()

2022-06-09 Thread Tony Lindgren
* Arnd Bergmann [220608 18:18]: > On Wed, Jun 8, 2022 at 4:27 PM Peter Zijlstra wrote: > > > > arch_cpu_idle() is a very simple idle interface and exposes only a > > single idle state and is expected to not require RCU and not do any > > tracing/instrumentation. > > > > As such, omap_sram_idle()

Re: [PATCH v2 3/3] x86/vmx: implement Notify VM Exit

2022-06-09 Thread Xiaoyao Li
On 6/9/2022 3:04 PM, Tian, Kevin wrote: +Chenyi/Xiaoyao who worked on the KVM support. Presumably similar opens have been discussed in KVM hence they have the right background to comment here. From: Roger Pau Monne Sent: Thursday, May 26, 2022 7:12 PM Under certain conditions guests can get t

Re: MISRA C meeting tomorrow, was: MOVING COMMUNITY CALL Call for agenda items for 9 June Community Call @ 1500 UTC

2022-06-09 Thread Jan Beulich
On 09.06.2022 03:20, Stefano Stabellini wrote: > Finally, for Rule 13.2, I updated the link to ECLAIR's results. There > are a lot more violations than just 4, but I don't know if they are > valid or false positives. I've picked just the one case in xen/common/efi/ebmalloc.c to check, and it says

RE: [PATCH v2 3/3] x86/vmx: implement Notify VM Exit

2022-06-09 Thread Tian, Kevin
+Chenyi/Xiaoyao who worked on the KVM support. Presumably similar opens have been discussed in KVM hence they have the right background to comment here. > From: Roger Pau Monne > Sent: Thursday, May 26, 2022 7:12 PM > > Under certain conditions guests can get the CPU stuck in an unbounded > loop