[linux-linus test] 171294: regressions - FAIL

2022-06-20 Thread osstest service owner
flight 171294 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171294/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel 8 xen-bootfail REGR. vs. 171277

[xen-unstable test] 171293: regressions - trouble: broken/fail/pass

2022-06-20 Thread osstest service owner
flight 171293 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171293/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd12-amd64 broken

Re: [PATCH v2 4/4] mini-os: fix bug in ballooning on PVH

2022-06-20 Thread Samuel Thibault
Juergen Gross, le dim. 19 juin 2022 08:52:53 +0200, a ecrit: > There is a subtle bug in ballooning code for PVH: in case ballooning > extends above a non-RAM area of the memory map, wrong pages will be > used. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - new

Re: [PATCH v2 3/4] mini-os: fix number of pages for PVH

2022-06-20 Thread Samuel Thibault
Juergen Gross, le dim. 19 juin 2022 08:52:52 +0200, a ecrit: > When getting the current allocation from Xen, this value includes the > pages allocated in the MMIO area. Fix the highest available RAM page > by subtracting the size of that area. > > This requires to read the E820 map before needing

Re: [PATCH 0/8] mini-os: some cleanup patches

2022-06-20 Thread Samuel Thibault
Hello, Juergen Gross, le lun. 20 juin 2022 09:38:12 +0200, a ecrit: > Do some cleanups. > > No functional change intended, apart from whitespace changes only > minor modifications making code easier to read. > > Juergen Gross (8): > mini-os: drop xenbus directory > mini-os: apply coding

[linux-linus test] 171291: regressions - FAIL

2022-06-20 Thread osstest service owner
flight 171291 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171291/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel 8 xen-bootfail REGR. vs. 171277

[xen-unstable-smoke test] 171292: tolerable all pass - PUSHED

2022-06-20 Thread osstest service owner
flight 171292 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171292/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[qemu-mainline test] 171288: tolerable FAIL - PUSHED

2022-06-20 Thread osstest service owner
flight 171288 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171288/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-shadow 7 xen-install fail in 171282 pass in 171288 test-armhf-armhf-xl-rtds

[PATCH V1 2/2] xen/grant-table: Use unpopulated contiguous pages instead of real RAM ones

2022-06-20 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Depends on CONFIG_XEN_UNPOPULATED_ALLOC. If enabled then unpopulated contiguous pages will be allocated for grant mapping into instead of ballooning out real RAM pages. Also fallback to allocate DMAable pages (balloon out real RAM pages) if we failed to allocate

[PATCH V1 0/2] Ability to allocate contiguous (was DMAable) pages using unpopulated-alloc

2022-06-20 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Hello all. You can find previous discussion at [1]. The purpose of this patch series is to get feedback about supporting the allocation of contiguous pages by Linux's unpopulated-alloc. The unpopulated-alloc feature has been enabled on Arm since the

[PATCH V1 1/2] xen/unpopulated-alloc: Introduce helpers for contiguous allocations

2022-06-20 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Add ability to allocate unpopulated contiguous pages suitable for grant mapping into. This is going to be used by userspace PV backends for grant mappings in gnttab code (see gnttab_dma_alloc_pages()). Patch also changes the allocation mechanism for unpopulated pages.

Re: [PATCH 1/2] x86/pat: fix x86_has_pat_wp()

2022-06-20 Thread Juergen Gross
On 20.06.22 17:27, Dave Hansen wrote: On 6/20/22 03:41, Juergen Gross wrote: But I'm only guessing - this needs a *lot* more elaboration and explanation why exactly this is needed. I will correct the code and update the commit message. It would also be great to cover the end-user-visible

Re: [PATCH 1/2] x86/pat: fix x86_has_pat_wp()

2022-06-20 Thread Dave Hansen
On 6/20/22 03:41, Juergen Gross wrote: >> But I'm only guessing - this needs a *lot* more elaboration and >> explanation why exactly this is needed. > > I will correct the code and update the commit message. It would also be great to cover the end-user-visible impact of the bug and the fix. It

Re: [PATCH v2 2/2] xen/arm: add FF-A mediator

2022-06-20 Thread Jens Wiklander
Hi Julien, On Fri, Jun 17, 2022 at 10:16 AM Julien Grall wrote: > > Hi Jens, > > On 16/06/2022 23:37, Jens Wiklander wrote: > > On Tue, Jun 14, 2022 at 07:47:18PM +, Volodymyr Babchuk wrote: > >> > >> Hello Jens, > >> > >> Sorry for late review, I was busy with internal projects. > >> > >>

[linux-linus test] 171284: regressions - FAIL

2022-06-20 Thread osstest service owner
flight 171284 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171284/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277

Re: [PATCH] tools/include: drop leading underscore from xen_list header

2022-06-20 Thread Juergen Gross
On 20.06.22 14:35, Roger Pau Monne wrote: A leading underscore is used to indicate auto generated headers, and the clean use of 'rm -f _*.h' will remove those. _xen_list.h also uses a leading underscore, but is checked in the repo and as such cannot be removed as part of the clean rule. Fix

[PATCH] tools/include: drop leading underscore from xen_list header

2022-06-20 Thread Roger Pau Monne
A leading underscore is used to indicate auto generated headers, and the clean use of 'rm -f _*.h' will remove those. _xen_list.h also uses a leading underscore, but is checked in the repo and as such cannot be removed as part of the clean rule. Fix this by dropping the leading underscore, so

[PATCH v2] x86/pat: fix x86_has_pat_wp()

2022-06-20 Thread Juergen Gross
x86_has_pat_wp() is using a wrong test, as it relies on the normal PAT configuration used by the kernel. In case the PAT MSR has been setup by another entity (e.g. BIOS or Xen hypervisor) it might return false even if the PAT configuration is allowing WP mappings. The correct way to test for WP

Re: [PATCH 1/2] x86/pat: fix x86_has_pat_wp()

2022-06-20 Thread Juergen Gross
On 20.06.22 12:26, Borislav Petkov wrote: On Tue, May 03, 2022 at 03:22:06PM +0200, Juergen Gross wrote: x86_has_pat_wp() is using a wrong test, as it relies on the normal PAT configuration used by the kernel. In case the PAT MSR has been setup by another entity (e.g. BIOS or Xen hypervisor) it

[xen-unstable test] 171283: tolerable FAIL

2022-06-20 Thread osstest service owner
flight 171283 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171283/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-examine 8 reboot fail in 171276 pass in 171283

Re: [PATCH 5/9] include/public: Use explicitly specified types

2022-06-20 Thread Andrew Cooper
On 20/06/2022 10:54, Julien Grall wrote: > Hi Michal, > > On 20/06/2022 08:02, Michal Orzel wrote: >> According to MISRA C 2012 Rule 8.1, types shall be explicitly >> specified. Fix all the findings reported by cppcheck with misra addon >> by substituting implicit type 'unsigned' to explicit

[libvirt test] 171285: regressions - FAIL

2022-06-20 Thread osstest service owner
flight 171285 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171285/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-i386-libvirt

Re: [PATCH 7/9] common/libfdt: Use explicitly specified types

2022-06-20 Thread Julien Grall
Hi Michal, On 20/06/2022 08:02, Michal Orzel wrote: According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel --- This

Re: [PATCH 5/9] include/public: Use explicitly specified types

2022-06-20 Thread Julien Grall
Hi Michal, On 20/06/2022 08:02, Michal Orzel wrote: According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Bump sysctl interface version. The

Re: [PATCH 4/9] include/xen: Use explicitly specified types

2022-06-20 Thread Julien Grall
Hi, On 20/06/2022 08:02, Michal Orzel wrote: According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel ---

Re: [PATCH 3/9] xen/common: Use explicitly specified types

2022-06-20 Thread Juergen Gross
On 20.06.22 09:02, Michal Orzel wrote: According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel Reviewed-by: Juergen

Re: [PATCH 3/9] xen/common: Use explicitly specified types

2022-06-20 Thread Julien Grall
Hi Michal, On 20/06/2022 08:02, Michal Orzel wrote: According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel

Re: [PATCH 2/9] xen/domain: Use explicitly specified types

2022-06-20 Thread Julien Grall
Hi Michal, On 20/06/2022 08:02, Michal Orzel wrote: According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel

Re: [PATCH 1/9] xen/arm: Use explicitly specified types

2022-06-20 Thread Julien Grall
Hi Michal, On 20/06/2022 08:02, Michal Orzel wrote: According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel

Re: [PATCH] xen/arm: smmuv1: remove iommu group when deassign a device

2022-06-20 Thread Rahul Singh
Hi Mykyta, > On 17 Jun 2022, at 12:15 pm, Mykyta Poturai wrote: > >> Hi Mykyta, >> >>> On 16 Jun 2022, at 8:48 am, Mykyta Poturai wrote: >>> >>> Hi Julien, Rahul >>> I've encountered a similar problem with IMX8 GPU recently. It wasn't probing >>> properly after the domain reboot. After some

Re: [RFC PATCH 2/2] tools/misc: Add xen-stats tool

2022-06-20 Thread Matias Ezequiel Vara Larsen
Hello Anthony, On Fri, Jun 03, 2022 at 01:08:20PM +0200, Matias Ezequiel Vara Larsen wrote: > Hello Anthony and thanks for your comments. I addressed them below: > > On Tue, May 31, 2022 at 12:16:02PM +0100, Anthony PERARD wrote: > > Hi Matias, > > > > On Tue, May 17, 2022 at 04:33:15PM +0200,

[PATCH 8/8] mini-os: add mini-os-debug[.gz] to .gitignore

2022-06-20 Thread Juergen Gross
mini-os-debug and mini-os-debug.gz are created when building Mini-OS, add them to .gitignore. Signed-off-by: Juergen Gross --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index d57c2bdd..abef46b2 100644 --- a/.gitignore +++ b/.gitignore @@ -14,3

[PATCH 7/8] mini-os: apply coding style to console.c

2022-06-20 Thread Juergen Gross
Make console.c coding style compliant. Signed-off-by: Juergen Gross --- console.c | 280 -- 1 file changed, 145 insertions(+), 135 deletions(-) diff --git a/console.c b/console.c index 29277eac..5d205c7d 100644 --- a/console.c +++ b/console.c

[PATCH 6/8] mini-os: eliminate console directory

2022-06-20 Thread Juergen Gross
Merge the two remaining source files in the console directory into a single one and move it to the main directory. Signed-off-by: Juergen Gross --- Makefile| 4 +- console/xencons_ring.c => console.c | 171 ++- console/console.c

[PATCH 5/8] mini-os: apply coding style to consfront.c

2022-06-20 Thread Juergen Gross
Make consfront.c coding style compliant. Signed-off-by: Juergen Gross --- consfront.c | 97 + 1 file changed, 53 insertions(+), 44 deletions(-) diff --git a/consfront.c b/consfront.c index 73659656..dfe6a3f0 100644 --- a/consfront.c +++

[PATCH 2/8] mini-os: apply coding style to xenbus.c

2022-06-20 Thread Juergen Gross
Make xenbus.c coding style compliant. Signed-off-by: Juergen Gross --- xenbus.c | 510 +-- 1 file changed, 303 insertions(+), 207 deletions(-) diff --git a/xenbus.c b/xenbus.c index b687678f..aa1fe7bf 100644 --- a/xenbus.c +++ b/xenbus.c @@

[PATCH 1/8] mini-os: drop xenbus directory

2022-06-20 Thread Juergen Gross
The xenbus directory contains only a single source. Move this source up and remove the xenbus directory. Signed-off-by: Juergen Gross --- Makefile| 3 +-- xenbus/xenbus.c => xenbus.c | 0 2 files changed, 1 insertion(+), 2 deletions(-) rename xenbus/xenbus.c => xenbus.c

[PATCH 0/8] mini-os: some cleanup patches

2022-06-20 Thread Juergen Gross
Do some cleanups. No functional change intended, apart from whitespace changes only minor modifications making code easier to read. Juergen Gross (8): mini-os: drop xenbus directory mini-os: apply coding style to xenbus.c mini-os: eliminate console/console.h mini-os: rename

[PATCH 4/8] mini-os: rename console/xenbus.c to consfront.c

2022-06-20 Thread Juergen Gross
Move console/xenbus.c into the main directory and rename it to consfront.c. Signed-off-by: Juergen Gross --- Makefile| 2 +- console/xenbus.c => consfront.c | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename console/xenbus.c => consfront.c (100%) diff --git

[PATCH 3/8] mini-os: eliminate console/console.h

2022-06-20 Thread Juergen Gross
console/console.h contains only a single prototype. Move that to include/console.h and remove console/console.h. Signed-off-by: Juergen Gross --- console/console.h | 2 -- console/xenbus.c | 2 +- console/xencons_ring.c | 2 +- include/console.h | 1 + 4 files changed, 3

[qemu-mainline test] 171282: regressions - FAIL

2022-06-20 Thread osstest service owner
flight 171282 qemu-mainline real [real] flight 171287 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171282/ http://logs.test-lab.xenproject.org/osstest/logs/171287/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not

[PATCH 8/9] common/inflate: Use explicitly specified types

2022-06-20 Thread Michal Orzel
According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel --- This patch may not be applicable as inflate comes from Linux.

[PATCH 9/9] drivers/acpi: Use explicitly specified types

2022-06-20 Thread Michal Orzel
According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel --- This patch may not be applicable as these files come from

[PATCH 7/9] common/libfdt: Use explicitly specified types

2022-06-20 Thread Michal Orzel
According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel --- This patch may not be applicable as these files come from

[PATCH 5/9] include/public: Use explicitly specified types

2022-06-20 Thread Michal Orzel
According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Bump sysctl interface version. Signed-off-by: Michal Orzel --- xen/include/public/physdev.h |

[PATCH 6/9] xsm/flask: Use explicitly specified types

2022-06-20 Thread Michal Orzel
According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel --- xen/xsm/flask/ss/avtab.c | 2 +- 1 file changed, 1

[PATCH 3/9] xen/common: Use explicitly specified types

2022-06-20 Thread Michal Orzel
According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel --- xen/common/grant_table.c | 6 +++--- xen/common/gunzip.c

[PATCH 4/9] include/xen: Use explicitly specified types

2022-06-20 Thread Michal Orzel
According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel --- xen/include/xen/perfc.h | 2 +- xen/include/xen/sched.h | 6

[PATCH 1/9] xen/arm: Use explicitly specified types

2022-06-20 Thread Michal Orzel
According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel --- xen/arch/arm/domain_build.c | 2 +-

[PATCH 2/9] xen/domain: Use explicitly specified types

2022-06-20 Thread Michal Orzel
According to MISRA C 2012 Rule 8.1, types shall be explicitly specified. Fix all the findings reported by cppcheck with misra addon by substituting implicit type 'unsigned' to explicit 'unsigned int'. Signed-off-by: Michal Orzel --- xen/common/domain.c | 2 +- xen/include/xen/domain.h | 2

[PATCH 0/9] MISRA C 2012 8.1 rule fixes

2022-06-20 Thread Michal Orzel
This series fixes all the findings for MISRA C 2012 8.1 rule, reported by cppcheck 2.7 with misra addon, for Arm (arm32/arm64 - target allyesconfig). Fixing this rule comes down to replacing implicit 'unsigned' with explicit 'unsigned int' type as there are no other violations being part of that

[ovmf test] 171286: all pass - PUSHED

2022-06-20 Thread osstest service owner
flight 171286 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171286/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e8034b534ab51635b62dca631514bb6305850a5a baseline version: ovmf

Re: [PATCH 1/2] x86/pat: fix x86_has_pat_wp()

2022-06-20 Thread Thorsten Leemhuis
On 20.06.22 07:30, Juergen Gross wrote: > On 20.06.22 07:22, Thorsten Leemhuis wrote: >> On 14.06.22 17:09, Juergen Gross wrote: >>> On 03.05.22 15:22, Juergen Gross wrote: x86_has_pat_wp() is using a wrong test, as it relies on the normal PAT configuration used by the kernel. In case