Re: [PATCH v2] Xen: fix EFI stub wchar_t size warning of arm32 building

2022-07-04 Thread Jan Beulich
On 05.07.2022 05:54, Wei Chen wrote: > Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 > is using stub.c of EFI common code for EFI stub functions. But > "-fshort-wchar" CFLAG will cause a warning when build stub.c > for Arm32: > "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in

[linux-linus test] 171495: regressions - FAIL

2022-07-04 Thread osstest service owner
flight 171495 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171495/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-li

[PATCH v2] Xen: fix EFI stub wchar_t size warning of arm32 building

2022-07-04 Thread Wei Chen
Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 is using stub.c of EFI common code for EFI stub functions. But "-fshort-wchar" CFLAG will cause a warning when build stub.c for Arm32: "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the output is to use

[qemu-mainline test] 171493: tolerable FAIL - PUSHED

2022-07-04 Thread osstest service owner
flight 171493 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171493/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 171462 test-armhf-armhf-libvirt 16 sav

[xen-unstable test] 171491: tolerable FAIL - PUSHED

2022-07-04 Thread osstest service owner
flight 171491 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171491/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 171477 test-armhf-armhf-libvirt 16 save

[linux-linus test] 171488: regressions - FAIL

2022-07-04 Thread osstest service owner
flight 171488 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171488/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-li

[qemu-mainline test] 171482: regressions - FAIL

2022-07-04 Thread osstest service owner
flight 171482 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171482/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 171462 Tests which are f

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread G.R.
On Tue, Jul 5, 2022 at 12:21 AM Roger Pau Monné wrote: > > On Mon, Jul 04, 2022 at 11:37:13PM +0800, G.R. wrote: > > On Mon, Jul 4, 2022 at 11:15 PM G.R. > > wrote: > > > > > > On Mon, Jul 4, 2022 at 10:51 PM G.R. > > > wrote: > > > > > > > > On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monné >

[xen-unstable-smoke test] 171486: tolerable all pass - PUSHED

2022-07-04 Thread osstest service owner
flight 171486 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171486/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread Jan Beulich
On 04.07.2022 18:05, Roger Pau Monné wrote: > On Mon, Jul 04, 2022 at 11:37:13PM +0800, G.R. wrote: >> On Mon, Jul 4, 2022 at 11:15 PM G.R. >> wrote: >>> >>> On Mon, Jul 4, 2022 at 10:51 PM G.R. >>> wrote: On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monné wrote: > Can you past

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread Jan Beulich
On 04.07.2022 17:33, Roger Pau Monné wrote: > On Mon, Jul 04, 2022 at 10:51:53PM +0800, G.R. wrote: >> On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monné wrote: 05:00.0 Non-Volatile memory controller: Sandisk Corp Device 501a (prog-if 02 [NVM Express]) Subsystem: Sandisk Cor

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread Roger Pau Monné
On Mon, Jul 04, 2022 at 11:37:13PM +0800, G.R. wrote: > On Mon, Jul 4, 2022 at 11:15 PM G.R. wrote: > > > > On Mon, Jul 4, 2022 at 10:51 PM G.R. > > wrote: > > > > > > On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monné > > > wrote: > > > > Can you paste the lspci -vvv output for any other device y

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread Roger Pau Monné
On Mon, Jul 04, 2022 at 11:44:14PM +0800, G.R. wrote: > On Mon, Jul 4, 2022 at 11:33 PM Roger Pau Monné wrote: > > > > Right, so hvmloader attempts to place a BAR from 05:00.0 and a BAR > > from 00:17.0 into the same page, which is not that good behavior. It > > might be sensible to attempt to sh

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread G.R.
On Mon, Jul 4, 2022 at 11:33 PM Roger Pau Monné wrote: > > Right, so hvmloader attempts to place a BAR from 05:00.0 and a BAR > from 00:17.0 into the same page, which is not that good behavior. It > might be sensible to attempt to share the page if both BARs belong to > the same device, but not i

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread G.R.
On Mon, Jul 4, 2022 at 11:15 PM G.R. wrote: > > On Mon, Jul 4, 2022 at 10:51 PM G.R. wrote: > > > > On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monné wrote: > > > Can you paste the lspci -vvv output for any other device you are also > > > passing through to this guest? > > > > > As reminded by this

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread Roger Pau Monné
On Mon, Jul 04, 2022 at 10:51:53PM +0800, G.R. wrote: > On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monné wrote: > > > > > > 05:00.0 Non-Volatile memory controller: Sandisk Corp Device 501a (prog-if > > > 02 [NVM Express]) > > > Subsystem: Sandisk Corp Device 501a > > > Control: I/O+ Mem

Re: [PATCH] tools/helpers: fix snprintf argument in init-dom0less.c

2022-07-04 Thread Bertrand Marquis
Hi Luca, > On 29 Jun 2022, at 13:49, Luca Fancellu wrote: > > Fix snprintf argument in init-dom0less.c because two instances of > the function are using libxl_dominfo struct members that are uint64_t > types, so change "%lu" to "%"PRIu64 to handle it properly when > building on arm32 and arm64.

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread G.R.
On Mon, Jul 4, 2022 at 10:51 PM G.R. wrote: > > On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monné wrote: > > > > > > 05:00.0 Non-Volatile memory controller: Sandisk Corp Device 501a (prog-if > > > 02 [NVM Express]) > > > Subsystem: Sandisk Corp Device 501a > > > Control: I/O+ Mem+ BusMa

Re: Hopefully correct backports for gntdev deadlock

2022-07-04 Thread Greg KH
On Mon, Jul 04, 2022 at 03:46:12PM +0200, Juergen Gross wrote: > On 01.07.22 02:09, Demi Marie Obenour wrote: > > This backports "xen/gntdev: Avoid blocking in unmap_grant_pages()" to > > the various stable trees, hopefully correctly. > > > > I have reviewed all backports and they seem correct to

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread G.R.
On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monné wrote: > > > > 05:00.0 Non-Volatile memory controller: Sandisk Corp Device 501a (prog-if > > 02 [NVM Express]) > > Subsystem: Sandisk Corp Device 501a > > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- > > Stepping-

[linux-linus test] 171478: regressions - FAIL

2022-07-04 Thread osstest service owner
flight 171478 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171478/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-li

Re: Hopefully correct backports for gntdev deadlock

2022-07-04 Thread Juergen Gross
On 01.07.22 02:09, Demi Marie Obenour wrote: This backports "xen/gntdev: Avoid blocking in unmap_grant_pages()" to the various stable trees, hopefully correctly. I have reviewed all backports and they seem correct to me. Greg, I'm fine with you adding the backports to the related stable branc

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread Roger Pau Monné
On Mon, Jul 04, 2022 at 07:34:47PM +0800, G.R. wrote: > On Mon, Jul 4, 2022 at 5:53 PM Roger Pau Monné wrote: > > > > On Sun, Jul 03, 2022 at 01:43:11AM +0800, G.R. wrote: > > > Hi everybody, > > > > > > I run into problems passing through a SN570 NVME SSD to a HVM guest. > > > So far I have no id

Re: [PATCH] public: constify xsd_errors[]

2022-07-04 Thread Juergen Gross
On 04.07.22 14:53, Jan Beulich wrote: While in principle this could break existing users, I think such users deserve to be put in trouble. After all the table should have been const from the very beginning. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD62

[PATCH] public: constify xsd_errors[]

2022-07-04 Thread Jan Beulich
While in principle this could break existing users, I think such users deserve to be put in trouble. After all the table should have been const from the very beginning. Signed-off-by: Jan Beulich --- Especially since the table definition lives in a header, the adding of "const" might render redun

Re: [PATCH 4/7] xen/arm: mm: Add more ASSERT() in {destroy, modify}_xen_mappings()

2022-07-04 Thread Bertrand Marquis
Hi Julien, > On 24 Jun 2022, at 10:11, Julien Grall wrote: > > From: Julien Grall > > Both destroy_xen_mappings() and modify_xen_mappings() will take in > parameter a range [start, end[. Both end should be page aligned. > > Add extra ASSERT() to ensure start and end are page aligned. Take the

Xen 4.15.3 released

2022-07-04 Thread Jan Beulich
All, we're pleased to announce the release of Xen 4.15.3. This is available immediately from its git repository http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.15 (tag RELEASE-4.15.3) or from the XenProject download page https://xenproject.org/downloads/xen-project-archiv

Re: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen

2022-07-04 Thread Jan Beulich
On 04.07.2022 13:58, Thorsten Leemhuis wrote: > On 25.05.22 10:55, Jan Beulich wrote: >> On 28.04.2022 16:50, Jan Beulich wrote: >>> The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT >>> with pat_enabled()") pat_enabled() returning false (because of PAT >>> initialization bein

[ANNOUNCE] Call for agenda items for 7 July Community Call @ 1500 UTC

2022-07-04 Thread George Dunlap
Hi all, The proposed agenda is in https://cryptpad.fr/pad/#/2/pad/edit/HjXEnZCVP3C2Lk16USDiJegJ/ and you can edit to add items. Alternatively, you can reply to this mail directly. Agenda items appreciated a few days before the call: please put your name besides items if you edit the document.

Re: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen

2022-07-04 Thread Thorsten Leemhuis
On 25.05.22 10:55, Jan Beulich wrote: > On 28.04.2022 16:50, Jan Beulich wrote: >> The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT >> with pat_enabled()") pat_enabled() returning false (because of PAT >> initialization being suppressed in the absence of MTRRs being announced

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread G.R.
On Mon, Jul 4, 2022 at 7:34 PM G.R. wrote: > > On Mon, Jul 4, 2022 at 5:53 PM Roger Pau Monné wrote: > > > > Would also be helpful if you could get the RMRR regions from that > > box. Booting with `iommu=verbose` on the Xen command line should print > > those. > Coming in my next reply... See at

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread G.R.
On Mon, Jul 4, 2022 at 5:53 PM Roger Pau Monné wrote: > > On Sun, Jul 03, 2022 at 01:43:11AM +0800, G.R. wrote: > > Hi everybody, > > > > I run into problems passing through a SN570 NVME SSD to a HVM guest. > > So far I have no idea if the problem is with this specific SSD or with > > the CPU + mo

[xen-unstable test] 171477: tolerable FAIL

2022-07-04 Thread osstest service owner
flight 171477 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171477/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 18 guest-localmigrate/x10 fail in 171463 pass in 171477 test-amd64

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread Jan Beulich
On 04.07.2022 11:50, Roger Pau Monné wrote: > On Sun, Jul 03, 2022 at 01:43:11AM +0800, G.R. wrote: >> Hi everybody, >> >> I run into problems passing through a SN570 NVME SSD to a HVM guest. >> So far I have no idea if the problem is with this specific SSD or with >> the CPU + motherboard combinat

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread Jan Beulich
(Note: please don't cross-post; removing xen-users@.) On 04.07.2022 08:37, G.R. wrote: > Update some findings with extra triage effort... > Detailed log could be found in the attachments. > 1. Confirm stock Debian 11.2 kernel (5.10) shares the same syndrome.. > 2. With loglvl=all, it reveals why t

Re: [PATCH v3 1/3] x86/vmx: implement VMExit based guest Bus Lock detection

2022-07-04 Thread Roger Pau Monné
On Mon, Jul 04, 2022 at 11:27:37AM +0200, Jan Beulich wrote: > On 01.07.2022 15:16, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/vmx/vmx.c > > +++ b/xen/arch/x86/hvm/vmx/vmx.c > > @@ -4065,6 +4065,11 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > > > > if ( unlikely(exit_reaso

Re: PCI pass-through problem for SN570 NVME SSD

2022-07-04 Thread Roger Pau Monné
On Sun, Jul 03, 2022 at 01:43:11AM +0800, G.R. wrote: > Hi everybody, > > I run into problems passing through a SN570 NVME SSD to a HVM guest. > So far I have no idea if the problem is with this specific SSD or with > the CPU + motherboard combination or the SW stack. > Looking for some suggestion

Re: [PATCH v1 01/10] drivers/char: Add support for Xue USB3 debugger

2022-07-04 Thread Jan Beulich
On 04.07.2022 11:27, Marek Marczykowski-Górecki wrote: > On Mon, Jul 04, 2022 at 08:05:06AM +0200, Jan Beulich wrote: >> On 03.07.2022 14:17, Marek Marczykowski-Górecki wrote: >>> On Thu, Jun 23, 2022 at 11:29:31AM +0200, Jan Beulich wrote: On 22.06.2022 17:47, Marek Marczykowski-Górecki wrote

[libvirt test] 171479: regressions - FAIL

2022-07-04 Thread osstest service owner
flight 171479 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171479/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

Re: [PATCH v3 1/3] x86/vmx: implement VMExit based guest Bus Lock detection

2022-07-04 Thread Jan Beulich
On 01.07.2022 15:16, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -4065,6 +4065,11 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > > if ( unlikely(exit_reason & VMX_EXIT_REASONS_FAILED_VMENTRY) ) > return vmx_failed_vment

Re: [PATCH v1 01/10] drivers/char: Add support for Xue USB3 debugger

2022-07-04 Thread Marek Marczykowski-Górecki
On Mon, Jul 04, 2022 at 08:05:06AM +0200, Jan Beulich wrote: > On 03.07.2022 14:17, Marek Marczykowski-Górecki wrote: > > On Thu, Jun 23, 2022 at 11:29:31AM +0200, Jan Beulich wrote: > >> On 22.06.2022 17:47, Marek Marczykowski-Górecki wrote: > >>> On Wed, Jun 15, 2022 at 04:25:54PM +0200, Jan Beul

Re: [PATCH v3 0/4] mini-os: some memory map updates for PVH

2022-07-04 Thread Jan Beulich
On 04.07.2022 11:12, Juergen Gross wrote: > On 04.07.22 10:55, Julien Grall wrote: >> Hi Juergen, >> >> On 04/07/2022 09:38, Juergen Gross wrote: >>> On 21.06.22 09:23, Juergen Gross wrote: Do some memory map related changes/fixes for PVH mode: - Prefer the memory map delivered via s

Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation

2022-07-04 Thread Xenia Ragiadakou
On 7/4/22 11:54, Luca Fancellu wrote: As said I would vote for external linkage here but would be nice to have other developers view on this. In addition to this, if we don’t want to provide a justification for those, since they seems to me code related to debugging they can be removed fro

Re: [PATCH v3 0/4] mini-os: some memory map updates for PVH

2022-07-04 Thread Juergen Gross
On 04.07.22 10:55, Julien Grall wrote: Hi Juergen, On 04/07/2022 09:38, Juergen Gross wrote: On 21.06.22 09:23, Juergen Gross wrote: Do some memory map related changes/fixes for PVH mode: - Prefer the memory map delivered via start-info over the one obtained    from the hypervisor. This is a

Re: [PATCH v3 0/4] mini-os: some memory map updates for PVH

2022-07-04 Thread Julien Grall
Hi Juergen, On 04/07/2022 09:38, Juergen Gross wrote: On 21.06.22 09:23, Juergen Gross wrote: Do some memory map related changes/fixes for PVH mode: - Prefer the memory map delivered via start-info over the one obtained    from the hypervisor. This is a prerequisite for Xenstore-stubdom    liv

Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation

2022-07-04 Thread Luca Fancellu
>> >> As said I would vote for external linkage here but would be nice to have >> other >> developers view on this. >> > In addition to this, if we don’t want to provide a justification for > those, since they seems to me > code related to debugging they can be r

Re: [PATCH 0/8] mini-os: some cleanup patches

2022-07-04 Thread Julien Grall
On 04/07/2022 09:39, Julien Grall wrote: Hi Juergen, On 04/07/2022 09:37, Juergen Gross wrote: On 20.06.22 09:38, Juergen Gross wrote: Do some cleanups. No functional change intended, apart from whitespace changes only minor modifications making code easier to read. Juergen Gross (8):   

Re: [PATCH 0/8] mini-os: some cleanup patches

2022-07-04 Thread Julien Grall
Hi Juergen, On 04/07/2022 09:37, Juergen Gross wrote: On 20.06.22 09:38, Juergen Gross wrote: Do some cleanups. No functional change intended, apart from whitespace changes only minor modifications making code easier to read. Juergen Gross (8):    mini-os: drop xenbus directory    mini-os: ap

Re: [PATCH v3 0/4] mini-os: some memory map updates for PVH

2022-07-04 Thread Juergen Gross
On 21.06.22 09:23, Juergen Gross wrote: Do some memory map related changes/fixes for PVH mode: - Prefer the memory map delivered via start-info over the one obtained from the hypervisor. This is a prerequisite for Xenstore-stubdom live-update with rising the memory limit. - Fix a bug rela

Re: [PATCH 0/8] mini-os: some cleanup patches

2022-07-04 Thread Juergen Gross
On 20.06.22 09:38, Juergen Gross wrote: Do some cleanups. No functional change intended, apart from whitespace changes only minor modifications making code easier to read. Juergen Gross (8): mini-os: drop xenbus directory mini-os: apply coding style to xenbus.c mini-os: eliminate conso

Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation

2022-07-04 Thread Julien Grall
Hi, On 04/07/2022 09:28, Bertrand Marquis wrote: On 4 Jul 2022, at 09:25, Luca Fancellu wrote: On 4 Jul 2022, at 09:06, Xenia Ragiadakou wrote: On 7/4/22 10:58, Luca Fancellu wrote: I am not 100% sure about this patch. I think show_stack() should be declared the same way as show_regist

Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation

2022-07-04 Thread Bertrand Marquis
> On 4 Jul 2022, at 09:25, Luca Fancellu wrote: > > > >> On 4 Jul 2022, at 09:06, Xenia Ragiadakou wrote: >> >> >> >> On 7/4/22 10:58, Luca Fancellu wrote: > I am not 100% sure about this patch. > I think show_stack() should be declared the same way as show_registers(). > So e

Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation

2022-07-04 Thread Luca Fancellu
> On 4 Jul 2022, at 09:06, Xenia Ragiadakou wrote: > > > > On 7/4/22 10:58, Luca Fancellu wrote: I am not 100% sure about this patch. I think show_stack() should be declared the same way as show_registers(). So either both of them will be declared with external linkage or both

Re: [PATCH 2/5] x86/lbr: enable hypervisor LER with arch LBR

2022-07-04 Thread Roger Pau Monné
On Mon, Jul 04, 2022 at 08:15:15AM +0200, Jan Beulich wrote: > On 01.07.2022 17:39, Roger Pau Monné wrote: > > On Mon, May 30, 2022 at 05:31:18PM +0200, Jan Beulich wrote: > >> On 20.05.2022 15:37, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/include/asm/msr-index.h > >>> +++ b/xen/arch/x86/incl

[qemu-mainline test] 171475: regressions - FAIL

2022-07-04 Thread osstest service owner
flight 171475 qemu-mainline real [real] flight 171480 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171475/ http://logs.test-lab.xenproject.org/osstest/logs/171480/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation

2022-07-04 Thread Xenia Ragiadakou
On 7/4/22 10:58, Luca Fancellu wrote: I am not 100% sure about this patch. I think show_stack() should be declared the same way as show_registers(). So either both of them will be declared with external linkage or both of them will be declared with internal linkage. I think that those 2 sh

Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation

2022-07-04 Thread Luca Fancellu
>> I am not 100% sure about this patch. >> I think show_stack() should be declared the same way as show_registers(). >> So either both of them will be declared with external linkage or both of them >> will be declared with internal linkage. > > I think that those 2 should be declared with externa

RE: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest device tree

2022-07-04 Thread Penny Zheng
Hi Stefano and Julien > -Original Message- > From: Stefano Stabellini > Sent: Saturday, June 25, 2022 5:57 AM > To: Julien Grall > Cc: Penny Zheng ; xen-devel@lists.xenproject.org; > Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v5 7/8] x

Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation

2022-07-04 Thread Bertrand Marquis
Hi Xenia, > On 4 Jul 2022, at 08:22, Xenia Ragiadakou wrote: > > The functions show_registers() and show_stack() are referenced only in > traps.c. > Change their linkage from external to internal by adding the storage-class > specifier static to their definitions and by removing show_registers(

[PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation

2022-07-04 Thread Xenia Ragiadakou
The functions show_registers() and show_stack() are referenced only in traps.c. Change their linkage from external to internal by adding the storage-class specifier static to their definitions and by removing show_registers() from asm/processor.h header file. Also, this patch resolves a MISRA C 20

RE: [PATCH v5 2/8] xen/arm: allocate static shared memory to the default owner dom_io

2022-07-04 Thread Penny Zheng
> -Original Message- > From: Julien Grall > Sent: Wednesday, June 29, 2022 6:35 PM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk ; Andrew Cooper > ; George Dunlap ; > Jan Beulich ; Wei Liu > Subject: Re: [