[linux-5.4 test] 172798: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172798 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172798/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172128 build-amd64-libvirt

[ovmf test] 172803: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172803 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172803/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[linux-linus test] 172796: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172796 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172796/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172133 build-amd64-libvirt

[ovmf test] 172802: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172802 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172802/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH 2/2] xen-blkfront: Advertise feature-persistent as user requested

2022-08-26 Thread SeongJae Park
On Fri, 26 Aug 2022 21:20:39 + SeongJae Park wrote: > Hi Max, > > On Fri, 26 Aug 2022 14:26:58 + Maximilian Heyne wrote: > > > On Thu, Aug 25, 2022 at 04:15:11PM +, SeongJae Park wrote: > > > > > > Commit e94c6101e151 ("xen-blkback: Apply 'feature_persistent' parameter > > > when

[xen-unstable test] 172795: tolerable FAIL

2022-08-26 Thread osstest service owner
flight 172795 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/172795/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 172781 pass in 172795 test-amd64-i38

[ovmf test] 172800: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172800 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172800/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH 7/7] xen/device_tree: Fix MISRA C 2012 Rule 20.7 violations

2022-08-26 Thread Stefano Stabellini
On Fri, 26 Aug 2022, Jan Beulich wrote: > On 26.08.2022 09:58, Xenia Ragiadakou wrote: > > On 8/26/22 09:21, Jan Beulich wrote: > >> On 25.08.2022 20:09, Stefano Stabellini wrote: > >>> But first, let's confirm whether this change: > >>> > >>> > >>> #define dt_for_each_property_node(dn, pp)

Re: [PATCH 2/2] xen-blkfront: Advertise feature-persistent as user requested

2022-08-26 Thread SeongJae Park
On Fri, 26 Aug 2022 21:20:39 + SeongJae Park wrote: > Hi Max, > > On Fri, 26 Aug 2022 14:26:58 + Maximilian Heyne wrote: > > > On Thu, Aug 25, 2022 at 04:15:11PM +, SeongJae Park wrote: > > > > > > Commit e94c6101e151 ("xen-blkback: Apply 'feature_persistent' parameter > > > when

Re: [PATCH 2/2] xen-blkfront: Advertise feature-persistent as user requested

2022-08-26 Thread SeongJae Park
Hi Max, On Fri, 26 Aug 2022 14:26:58 + Maximilian Heyne wrote: > On Thu, Aug 25, 2022 at 04:15:11PM +, SeongJae Park wrote: > > > > Commit e94c6101e151 ("xen-blkback: Apply 'feature_persistent' parameter > > when connect") made blkback to advertise its support of the persistent > > gran

[ovmf test] 172797: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172797 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172797/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[qemu-mainline test] 172789: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172789 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172789/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 172123 build-i386-libvir

Re: [PATCH] Make XEN_FW_EFI_MEM_INFO easier to use

2022-08-26 Thread Demi Marie Obenour
On Fri, Aug 26, 2022 at 09:18:50AM +0200, Jan Beulich wrote: > On 25.08.2022 22:36, Demi Marie Obenour wrote: > > On Thu, Aug 25, 2022 at 09:59:56AM +0200, Jan Beulich wrote: > >> On 24.08.2022 23:04, Demi Marie Obenour wrote: > >>> Fix both of these problems by unconditionally setting the memory r

Re: [PATCH] Add support for ESRT loading under Xen

2022-08-26 Thread Demi Marie Obenour
On Fri, Aug 26, 2022 at 09:53:29AM +0200, Jan Beulich wrote: > On 25.08.2022 23:52, Demi Marie Obenour wrote: > > @@ -40,6 +41,38 @@ > > > > #define efi_data(op) (op.u.efi_runtime_call) > > > > +static_assert(XEN_PAGE_SHIFT == EFI_PAGE_SHIFT, > > + "Mismatch between EFI_PAGE

[linux-5.4 test] 172787: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172787 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172787/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172128 build-amd64-libvirt

Re: [PATCH 07/12] xen/common: add colored heap info debug-key

2022-08-26 Thread Carlo Nonato
On Fri, Aug 26, 2022 at 4:13 PM Jan Beulich wrote: > On 26.08.2022 14:51, Carlo Nonato wrote: > > --- a/xen/common/page_alloc.c > > +++ b/xen/common/page_alloc.c > > @@ -605,6 +605,27 @@ static struct page_info > *alloc_col_domheap_page(struct domain *d, > > return pg; > > } > > > > +static

Re: [PATCH v2] PCI/MSI: Correct use of can_mask in msi_add_msi_desc()

2022-08-26 Thread Bjorn Helgaas
On Mon, Feb 14, 2022 at 11:07:47AM +0100, Josef Johansson wrote: > From: Josef Johansson > > PCI/MSI: Correct use of can_mask in msi_add_msi_desc() > > Commit 71020a3c0dff4 ("PCI/MSI: Use msi_add_msi_desc()") modifies > the logic of checking msi_attrib.can_mask, without any reason. > >

[ovmf test] 172794: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172794 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172794/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[linux-linus test] 172783: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172783 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172783/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172133 build-amd64-libvirt

Re: [PATCH v5 9/9] drivers/char: fix handling cable re-plug in XHCI console driver

2022-08-26 Thread Jan Beulich
On 22.08.2022 17:27, Marek Marczykowski-Górecki wrote: > @@ -1023,6 +1032,8 @@ static bool dbc_ensure_running(struct dbc *dbc) > writel(ctrl | (1U << DBC_CTRL_DRC), ®->ctrl); > writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); > wmb(); > +dbc_ring_doorbel

Re: [PATCH v5 8/9] drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC

2022-08-26 Thread Jan Beulich
On 22.08.2022 17:27, Marek Marczykowski-Górecki wrote: > That's possible, because the capability was designed specifically to > allow separate driver handle it, in parallel to unmodified xhci driver > (separate set of registers, pretending the port is "disconnected" for > the main xhci driver etc).

Re: [PATCH 2/2] xen-blkfront: Advertise feature-persistent as user requested

2022-08-26 Thread Maximilian Heyne
On Thu, Aug 25, 2022 at 04:15:11PM +, SeongJae Park wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > Commit e94c6101e151 ("xen-blkback: Apply 'feature

Re: [PATCH v5 1/9] drivers/char: separate dbgp=xhci to dbc=xhci option

2022-08-26 Thread Jan Beulich
On 26.08.2022 13:46, Marek Marczykowski-Górecki wrote: > On Thu, Aug 25, 2022 at 05:44:54PM +0200, Jan Beulich wrote: >> On 22.08.2022 17:27, Marek Marczykowski-Górecki wrote: >>> This allows configuring EHCI and XHCI consoles separately, >>> simultaneously. >>> >>> Suggested-by: Jan Beulich >> >>

Re: [PATCH 07/12] xen/common: add colored heap info debug-key

2022-08-26 Thread Jan Beulich
On 26.08.2022 14:51, Carlo Nonato wrote: > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -605,6 +605,27 @@ static struct page_info *alloc_col_domheap_page(struct > domain *d, > return pg; > } > > +static void dump_col_heap(unsigned char key) > +{ > +struct page_inf

Re: [PATCH v6 2/9] xen/arm: allocate static shared memory to the default owner dom_io

2022-08-26 Thread Julien Grall
Hi Penny, On 21/07/2022 14:21, Penny Zheng wrote: From: Penny Zheng This commit introduces process_shm to cope with static shared memory in domain construction. DOMID_IO will be the default owner of memory pre-shared among multiple domains at boot time, when no explicit owner is specified. T

Re: [PATCH 2/7] xsm/flask: sidtab: Fix MISRA C 2012 Rule 20.7 violations

2022-08-26 Thread Daniel P. Smith
On 8/19/22 15:43, Xenia Ragiadakou wrote: > In macros SIDTAB_HASH(), INIT_SIDTAB_LOCK(), SIDTAB_LOCK() and > SIDTAB_UNLOCK(), > add parentheses around the macro parameter to prevent against unintended > expansions. > > Signed-off-by: Xenia Ragiadakou > --- > xen/xsm/flask/ss/sidtab.c | 8

[xen-unstable test] 172781: tolerable FAIL - PUSHED

2022-08-26 Thread osstest service owner
flight 172781 xen-unstable real [real] flight 172793 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/172781/ http://logs.test-lab.xenproject.org/osstest/logs/172793/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: [PATCH v6 1/9] xen/arm: introduce static shared memory

2022-08-26 Thread Julien Grall
Hi Penny, On 21/07/2022 14:21, Penny Zheng wrote: From: Penny Zheng This patch series introduces a new feature: setting up static shared memory on a dom0less system, through device tree configuration. This commit parses shared memory node at boot-time, and reserve it in bootinfo.reserved_mem

Re: [PATCH v6 7/9] xen/arm: create shared memory nodes in guest device tree

2022-08-26 Thread Julien Grall
Hi Penny, On 21/07/2022 14:21, Penny Zheng wrote: +#ifdef CONFIG_STATIC_SHM +static int __init make_shm_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, +

Re: [PATCH v2] PCI/MSI: Correct use of can_mask in msi_add_msi_desc()

2022-08-26 Thread Jason Gunthorpe
On Fri, Aug 05, 2022 at 10:53:36AM -0500, Bjorn Helgaas wrote: > On Fri, Aug 05, 2022 at 09:10:41AM -0300, Jason Gunthorpe wrote: > > On Fri, Aug 05, 2022 at 12:03:15PM +0200, Josef Johansson wrote: > > > On 2/14/22 11:07, Josef Johansson wrote: > > > > From: Josef Johansson > > > > > > > > PCI/M

[libvirt test] 172784: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172784 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/172784/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

[PATCH 12/12] xen/arm: add cache coloring support for Xen

2022-08-26 Thread Carlo Nonato
This commit adds the cache coloring support for Xen own physical space. It extends the implementation of setup_pagetables to make use of Xen cache coloring configuration. Page tables construction is essentially the same except for the fact that the physical addresses, in case of cache coloring, ar

[ovmf test] 172791: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172791 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172791/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[PATCH 11/12] xen/arm: add Xen cache colors command line parameter

2022-08-26 Thread Carlo Nonato
This commit adds a new command line parameter to configure Xen cache colors. These colors can be dumped with the cache coloring info debug-key. By default, Xen uses the first color. Benchmarking the VM interrupt response time provides an estimation of LLC usage by Xen's most latency-critical runti

[PATCH 06/12] xen/common: add cache coloring allocator for domains

2022-08-26 Thread Carlo Nonato
This commit adds a new memory page allocator that implements the cache coloring mechanism. The allocation algorithm follows the given color configuration of the domain and maximizes contiguity in the page selection. Pages are stored in a color-indexed data structure of lists, sorted by their machi

[PATCH 04/12] tools/xl: add support for cache coloring configuration

2022-08-26 Thread Carlo Nonato
Add a new "colors" parameter that defines the color assignment for a domain. The user can specify one or more color ranges using the same syntax used everywhere else for color config described in the documentation. The parameter is defined as a list of strings that represent the color ranges. Also

[PATCH 09/12] Revert "xen/arm: mm: Initialize page-tables earlier"

2022-08-26 Thread Carlo Nonato
From: Luca Miccio This reverts commit 3a5d341681af650825bbe3bee9be5d187da35080. The cache coloring support will be configurable within the Xen command line, but it will be initialized before the page-tables; this is necessary for coloring the hypervisor itself beacuse we will create a specific m

[PATCH 08/12] Revert "xen/arm: setup: Add Xen as boot module before printing all boot modules"

2022-08-26 Thread Carlo Nonato
From: Luca Miccio This reverts commit 48fb2a9deba11ee48dde21c5c1aa93b4d4e1043b. The cache coloring support has the command line parsing as a prerequisite because of the color configurations passed in this way. Also, the Xen boot module will be placed at an address that depends on the coloring in

[PATCH 05/12] xen/arm: add support for cache coloring configuration via device-tree

2022-08-26 Thread Carlo Nonato
This commit adds the "colors" Device Tree attribute that can be used for DomUs and Dom0less color configurations. The syntax is the same used for every color config. Signed-off-by: Carlo Nonato Signed-off-by: Marco Solieri --- docs/misc/arm/cache-coloring.rst | 45 +

[PATCH 02/12] xen/arm: add cache coloring initialization for domains

2022-08-26 Thread Carlo Nonato
This commit adds array pointers to domains as well as to the hypercall and configuration structure employed in domain creation. The latter is used both by the toolstack and by Xen itself to pass configuration data to the domain creation function, so the XEN_GUEST_HANDLE macro must be adopted to be

[PATCH 10/12] Revert "xen/arm: Remove unused BOOT_RELOC_VIRT_START"

2022-08-26 Thread Carlo Nonato
This reverts commit 0c18fb76323bfb13615b6f13c98767face2d8097. Cache coloring support for Xen needs to relocate Xen code and data in a new colored physical space. The BOOT_RELOC_VIRT_START will be used as the virtual base address for a temporary mapping to this new space. --- xen/arch/arm/include/

[PATCH 00/12] Arm cache coloring

2022-08-26 Thread Carlo Nonato
Shared caches in multi-core CPU architectures represent a problem for predictability of memory access latency. This jeopardizes applicability of many Arm platform in real-time critical and mixed-criticality scenarios. We introduce support for cache partitioning with page coloring, a transparent sof

[PATCH 01/12] xen/arm: add cache coloring initialization

2022-08-26 Thread Carlo Nonato
This commit adds the cache coloring support initialization, Kconfig options, command line parameters and the initial documentation. The initialization consists of an auto probing of the cache layout necessary to retrieve the LLC way size which is used to compute the number of available colors. The

[PATCH 07/12] xen/common: add colored heap info debug-key

2022-08-26 Thread Carlo Nonato
This commit adds a debug-key to let the user inspect the colored heap information. The number of pages stored for each available color is dumped. Signed-off-by: Carlo Nonato Signed-off-by: Marco Solieri --- xen/common/page_alloc.c | 24 1 file changed, 24 insertions(+)

[PATCH 03/12] xen/arm: dump cache colors in domain info debug-key

2022-08-26 Thread Carlo Nonato
This commit adds cache colors to the information dumped with the domain info debug-key. Signed-off-by: Carlo Nonato Signed-off-by: Marco Solieri --- xen/arch/arm/coloring.c | 16 xen/arch/arm/domain.c | 3 +++ xen/arch/arm/include/asm/coloring.h | 1

Re: [PATCH v5 1/9] drivers/char: separate dbgp=xhci to dbc=xhci option

2022-08-26 Thread Marek Marczykowski-Górecki
On Thu, Aug 25, 2022 at 05:44:54PM +0200, Jan Beulich wrote: > On 22.08.2022 17:27, Marek Marczykowski-Górecki wrote: > > This allows configuring EHCI and XHCI consoles separately, > > simultaneously. > > > > Suggested-by: Jan Beulich > > But was I maybe confused, and much less of a change would

[ovmf test] 172788: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172788 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172788/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH v4] xen/privcmd: fix error exit of privcmd_ioctl_dm_op()

2022-08-26 Thread Juergen Gross
On 26.08.22 11:08, Oleksandr Tyshchenko wrote: On 25.08.22 17:19, Juergen Gross wrote: Hello Juergen The error exit of privcmd_ioctl_dm_op() is calling unlock_pages() potentially with pages being NULL, leading to a NULL dereference. Additionally lock_pages() doesn't check for pin_user_pages_

Re: [PATCH v4] xen/privcmd: fix error exit of privcmd_ioctl_dm_op()

2022-08-26 Thread Oleksandr Tyshchenko
On 25.08.22 17:19, Juergen Gross wrote: Hello Juergen > The error exit of privcmd_ioctl_dm_op() is calling unlock_pages() > potentially with pages being NULL, leading to a NULL dereference. > > Additionally lock_pages() doesn't check for pin_user_pages_fast() > having been completely successful,

Re: [PATCH 7/7] xen/device_tree: Fix MISRA C 2012 Rule 20.7 violations

2022-08-26 Thread Jan Beulich
On 26.08.2022 09:58, Xenia Ragiadakou wrote: > On 8/26/22 09:21, Jan Beulich wrote: >> On 25.08.2022 20:09, Stefano Stabellini wrote: >>> But first, let's confirm whether this change: >>> >>> >>> #define dt_for_each_property_node(dn, pp) \ >>> -for ( pp = dn->properties; pp

[qemu-mainline test] 172778: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172778 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172778/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 172123 build-i386-libvir

Re: [PATCH 7/7] xen/device_tree: Fix MISRA C 2012 Rule 20.7 violations

2022-08-26 Thread Xenia Ragiadakou
On 8/26/22 09:21, Jan Beulich wrote: On 25.08.2022 20:09, Stefano Stabellini wrote: But first, let's confirm whether this change: #define dt_for_each_property_node(dn, pp) \ -for ( pp = dn->properties; pp != NULL; pp = pp->next ) +for ( pp = (dn)->properties; pp !

Re: [PATCH] Add support for ESRT loading under Xen

2022-08-26 Thread Jan Beulich
On 25.08.2022 23:52, Demi Marie Obenour wrote: > @@ -40,6 +41,38 @@ > > #define efi_data(op) (op.u.efi_runtime_call) > > +static_assert(XEN_PAGE_SHIFT == EFI_PAGE_SHIFT, > + "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHIFT"); > + > +bool xen_efi_mem_desc_lookup(u64 phys_addr, e

[ovmf test] 172786: regressions - FAIL

2022-08-26 Thread osstest service owner
flight 172786 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172786/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH v6 9/9] xen: Add static memory sharing in SUPPORT.md

2022-08-26 Thread Michal Orzel
Hi Penny, On 21/07/2022 15:21, Penny Zheng wrote: > on ARM, static memory sharing is tech preview, which shall be documented NIT: missing 'a' before 'tech preview'. > in SUPPORT.md > > Signed-off-by: Penny Zheng > --- > v6 change: > - new commit > --- > SUPPORT.md | 6 ++ > 1 file changed,

Re: [PATCH] Make XEN_FW_EFI_MEM_INFO easier to use

2022-08-26 Thread Jan Beulich
On 25.08.2022 22:36, Demi Marie Obenour wrote: > On Thu, Aug 25, 2022 at 09:59:56AM +0200, Jan Beulich wrote: >> On 24.08.2022 23:04, Demi Marie Obenour wrote: >>> Fix both of these problems by unconditionally setting the memory region >>> size >> >> If you were to report a larger ending address, w

Re: [PATCH 0/2] xen-blk{front,back}: Advertise feature-persistent as user requested

2022-08-26 Thread Juergen Gross
On 25.08.22 18:15, SeongJae Park wrote: Commit e94c6101e151 ("xen-blkback: Apply 'feature_persistent' parameter when connect") made blkback to advertise its support of the persistent grants feature only if the user sets the 'feature_persistent' parameter of the driver and the frontend advertised