Re: [PATCH for-4.17] SUPPORT.md: Define support lifetime

2022-12-07 Thread Jan Beulich
On 07.12.2022 20:59, Julien Grall wrote: > Signed-off-by: Julien Grall Acked-by: Jan Beulich

[GIT PULL] xen: branch for v6.1-rc9b

2022-12-07 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-xsa-6.1-rc9b-tag xen: branch for v6.1-rc9b It contains a single fix for the recent security issue XSA-423. Thanks. Juergen drivers/net/xen-netback/netback.c | 2 +- 1 file changed

[ovmf test] 175085: all pass - PUSHED

2022-12-07 Thread osstest service owner
flight 175085 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175085/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d9e7f6fe49738421c02381425d289767d7055ef1 baseline version: ovmf ca33daafc630a7952de48

[xen-4.17-testing test] 175079: tolerable FAIL - PUSHED

2022-12-07 Thread osstest service owner
flight 175079 xen-4.17-testing real [real] flight 175084 xen-4.17-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175079/ http://logs.test-lab.xenproject.org/osstest/logs/175084/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-12-07 Thread Henry Wang
Hi Julien, Stefano, Bertrand, I am trying to work on the follow-up improvements about the Arm P2M code, and while trying to address the comment below, I noticed there was an unfinished discussion between me and Julien which I would like to continue and here opinions from all of you (if possible).

RE: [PATCH for-4.17] SUPPORT.md: Define support lifetime

2022-12-07 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: [PATCH for-4.17] SUPPORT.md: Define support lifetime > > Signed-off-by: Julien Grall Release-acked-by: Henry Wang Kind regards, Henry

RE: [PATCH v6 0/2] Final changelog changes for 4.17

2022-12-07 Thread Henry Wang
Hi Julien, > -Original Message- > Subject: Re: [PATCH v6 0/2] Final changelog changes for 4.17 > > Hi, > > On 01/12/2022 11:39, Henry Wang wrote: > > Hi all, > > > > These two patches should be the final changelog changes for 4.17. > > > > The first patch sets the release date and tag of

Re: [PATCH v3 2/5] xen/scripts: add cppcheck tool to the xen-analysis.py script

2022-12-07 Thread Stefano Stabellini
On Wed, 7 Dec 2022, Luca Fancellu wrote: > Add Cppcheck analysis to the xen-analysis.py script using the > arguments --run-cppcheck. > > Now cppcheck analysis will build Xen while the analysis is performed > on the source files, it will produce a text report and an additional > html output when th

Re: [PATCH v3 1/5] xen/scripts: add xen-analysis.py for coverity and eclair analysis

2022-12-07 Thread Stefano Stabellini
On Wed, 7 Dec 2022, Luca Fancellu wrote: > Add new script for coverity/eclair analysis tool that will enable > the procedure to suppress findings when these tool are used. > The procedure is documented in docs/misra/documenting-violations.rst > and the script is documented in docs/misra/xen-static-

[xen-unstable-smoke test] 175082: tolerable all pass - PUSHED

2022-12-07 Thread osstest service owner
flight 175082 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175082/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2022-12-07 Thread Stefano Stabellini
On Wed, 7 Dec 2022, Julien Grall wrote: > On 07/12/2022 22:27, Stefano Stabellini wrote: > > On Wed, 7 Dec 2022, Julien Grall wrote: > > > On 07/12/2022 01:37, Stefano Stabellini wrote: > > > > On Mon, 5 Dec 2022, Henry Wang wrote: > > > > > As we are having more and more types of static region, an

[PATCH v2] xsm/flask: misra rule 8.4 fix

2022-12-07 Thread Stefano Stabellini
Fix several MISRA Issues Rule 8.4 ("A compatible declaration shall be visible when an object or function with external linkage is defined") found by cppcheck affecting xen/xsm/flask. - policydb_loaded_version is not declared; removed it because it is unused - move ss_initialized declaration to x

Re: [PATCH 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2022-12-07 Thread Julien Grall
Hi Stefano, On 07/12/2022 22:27, Stefano Stabellini wrote: On Wed, 7 Dec 2022, Julien Grall wrote: On 07/12/2022 01:37, Stefano Stabellini wrote: On Mon, 5 Dec 2022, Henry Wang wrote: As we are having more and more types of static region, and all of these static regions are defined in bootinf

Re: Xen + linux 6.1.0-rc8, network to guest VM not working after commit ad7f402ae4f466647c3a669b8a6f3e5d4271c84a fixing XSA-423

2022-12-07 Thread Andrew Cooper
On 07/12/2022 21:42, Sander Eikelenboom wrote: > Hi Ross / Juergen, > > I just updated my linux kernel to the latest of Linus his tree which > included commit ad7f402ae4f466647c3a669b8a6f3e5d4271c84a fixing XSA-423. > > Unfortunately when using this kernel I can't SSH anymore into the Xen > guest I

Re: [PATCH v2] Use EfiACPIReclaimMemory for ESRT

2022-12-07 Thread Demi Marie Obenour
On Wed, Dec 07, 2022 at 11:11:40AM +0100, Jan Beulich wrote: > On 07.12.2022 00:27, Demi Marie Obenour wrote: > > A previous patch tried to get Linux to use the ESRT under Xen if it is > > in memory of type EfiRuntimeServicesData. However, this turns out to be > > a bad idea. Ard Biesheuvel point

Re: [PATCH 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2022-12-07 Thread Stefano Stabellini
On Wed, 7 Dec 2022, Julien Grall wrote: > Hi Stefano, > > On 07/12/2022 01:37, Stefano Stabellini wrote: > > On Mon, 5 Dec 2022, Henry Wang wrote: > > > As we are having more and more types of static region, and all of > > > these static regions are defined in bootinfo.reserved_mem, it is > > > ne

Re: [PATCH] Validate EFI memory descriptors

2022-12-07 Thread Demi Marie Obenour
On Wed, Dec 07, 2022 at 11:04:05AM +0100, Jan Beulich wrote: > On 07.12.2022 00:57, Demi Marie Obenour wrote: > > It turns out that these can be invalid in various ways. Based on code > > Ard Biesheuvel contributed for Linux. > > > > Co-developed-by: Ard Biesheuvel > > Signed-off-by: Demi Marie

[xen-unstable test] 175071: tolerable FAIL

2022-12-07 Thread osstest service owner
flight 175071 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175071/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-installfail pass in 175066 Tests which did not succeed, but

Xen + linux 6.1.0-rc8, network to guest VM not working after commit ad7f402ae4f466647c3a669b8a6f3e5d4271c84a fixing XSA-423

2022-12-07 Thread Sander Eikelenboom
Hi Ross / Juergen, I just updated my linux kernel to the latest of Linus his tree which included commit ad7f402ae4f466647c3a669b8a6f3e5d4271c84a fixing XSA-423. Unfortunately when using this kernel I can't SSH anymore into the Xen guest I start, but I don't see any apparent failures either. A

[linux-linus test] 175070: regressions - FAIL

2022-12-07 Thread osstest service owner
flight 175070 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175070/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 173462 test-arm64-arm64-ex

[xen-unstable-smoke test] 175075: tolerable all pass - PUSHED

2022-12-07 Thread osstest service owner
flight 175075 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175075/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v6 0/2] Final changelog changes for 4.17

2022-12-07 Thread Julien Grall
Hi, On 01/12/2022 11:39, Henry Wang wrote: Hi all, These two patches should be the final changelog changes for 4.17. The first patch sets the release date and tag of 4.17 release and should be "backported" to the staging/stable-4.17. The second patch starts a new unstable section, so should b

[PATCH for-4.17] SUPPORT.md: Define support lifetime

2022-12-07 Thread Julien Grall
Signed-off-by: Julien Grall --- SUPPORT.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index 765dd15685..cb504eec1e 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -10,9 +10,9 @@ for the definitions of the support status levels etc. # Release Sup

Re: [XEN][RFC PATCH v4 10/16] asm/smp.h: move cpu related function to asm/cpu.h

2022-12-07 Thread Vikram Garhwal
Hi Julien On 12/7/22 8:28 AM, Julien Grall wrote: Hi Vikram, On 07/12/2022 06:18, Vikram Garhwal wrote: Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing

Re: [PATCH for-4.17 v6 1/2] CHANGELOG: Set 4.17 release date and tag

2022-12-07 Thread Julien Grall
Hi Henry, On 01/12/2022 11:39, Henry Wang wrote: Signed-off-by: Henry Wang Reviewed-by: Julien Grall Cheers, -- Julien Grall

Re: [XEN][RFC PATCH v3 10/14] xen/arm: Implement device tree node removal functionalities

2022-12-07 Thread Julien Grall
On 07/12/2022 01:37, Vikram Garhwal wrote: In your use-case, are you planning to ask the admin to reboot if you can't remove a node? Yeah. What is error case where it may happen? The code below have many possible failures. I would suggest to test by throwing an error on the second node and

[libvirt test] 175069: tolerable all pass - PUSHED

2022-12-07 Thread osstest service owner
flight 175069 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/175069/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 175056 test-armhf-armhf-libvirt-raw 15 saveresto

Re: [PATCH 1/2] vchan-socket-proxy: add reconnect marker support

2022-12-07 Thread Marek Marczykowski-Górecki
On Wed, Dec 07, 2022 at 03:22:46PM +, Anthony PERARD wrote: > On Mon, Sep 05, 2022 at 03:50:18PM +0200, Marek Marczykowski-Górecki wrote: > > +reconnect_marker_value = atoi(optarg); > > atoi() isn't great, if there's garbage it just return 0, which is > validated below. > > Wo

Re: [XEN][RFC PATCH v4 11/16] common/device_tree: Add rwlock for dt_host

2022-12-07 Thread Julien Grall
Hi Vikram, On 07/12/2022 06:18, Vikram Garhwal wrote: Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing the dt_host. Looking at the user below, it is

Re: [XEN][RFC PATCH v4 10/16] asm/smp.h: move cpu related function to asm/cpu.h

2022-12-07 Thread Julien Grall
Hi Vikram, On 07/12/2022 06:18, Vikram Garhwal wrote: Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing the dt_host. But adding rwlock in device_tree.h causes

[xen-unstable-smoke test] 175072: regressions - FAIL

2022-12-07 Thread osstest service owner
flight 175072 xen-unstable-smoke real [real] flight 175073 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175072/ http://logs.test-lab.xenproject.org/osstest/logs/175073/ Regressions :-( Tests which did not succeed and are blocking, including tests which co

Re: [PATCH 2/2] tools/libxl: enable in-band reconnect marker for stubdom QMP proxy

2022-12-07 Thread Anthony PERARD
On Mon, Sep 05, 2022 at 03:50:19PM +0200, Marek Marczykowski-Górecki wrote: > This enables stubdom reliably detect when it needs to reconnect QMP > socket. It is critical, as otherwise QEMU will not send its handshake, > and so libxl will timeout while waiting on one. When it happens during > domai

Xen Security Advisory 423 v2 (CVE-2022-3643) - Guests can trigger NIC interface reset/abort/crash via netback

2022-12-07 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2022-3643 / XSA-423 version 2 Guests can trigger NIC interface reset/abort/crash via netback UPDATES IN VERSION 2 Patch updated. ISSUE DESCRIPTION ==

Re: [PATCH 1/2] vchan-socket-proxy: add reconnect marker support

2022-12-07 Thread Anthony PERARD
On Mon, Sep 05, 2022 at 03:50:18PM +0200, Marek Marczykowski-Górecki wrote: > +reconnect_marker_value = atoi(optarg); atoi() isn't great, if there's garbage it just return 0, which is validated below. Would there be value here in using strtol() which can detect input error? To at

Re: [PATCH net] xen/netback: don't call kfree_skb() under spin_lock_irqsave()

2022-12-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni : On Mon, 5 Dec 2022 22:13:33 +0800 you wrote: > It is not allowed to call kfree_skb() from hardware interrupt > context or with interrupts being disabled. So replace kfree_skb() > with dev_kfree_skb_irq() under spin_lock_irq

Re: [PATCH] xen/netback: fix build warning

2022-12-07 Thread Jason Andryuk
On Wed, Dec 7, 2022 at 2:24 AM Juergen Gross wrote: > > Commit ad7f402ae4f4 ("xen/netback: Ensure protocol headers don't fall in > the non-linear area") introduced a (valid) build warning. > > Fix it. > > Fixes: ad7f402ae4f4 ("xen/netback: Ensure protocol headers don't fall in the > non-linear ar

Re: [RFC] docs/misra: List files in Xen originated from external sources

2022-12-07 Thread Michal Orzel
On 17/11/2022 22:15, Stefano Stabellini wrote: > > > On Thu, 17 Nov 2022, Jan Beulich wrote: >> On 17.11.2022 11:39, Michal Orzel wrote: >>> On 17/11/2022 11:03, Jan Beulich wrote: On 16.11.2022 10:20, Michal Orzel wrote: > --- /dev/null > +++ b/docs/misra/external-files.txt >

[qemu-mainline test] 175068: tolerable FAIL - PUSHED

2022-12-07 Thread osstest service owner
flight 175068 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175068/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 175051 test-armhf-armhf-libvirt 16 sav

[PATCH v3 3/5] xen/Makefile: remove Cppcheck invocation from the Makefile

2022-12-07 Thread Luca Fancellu
The script xen-analysis.py is going to be used for the analysis with cppcheck, so remove the rules from the Makefile. The python script xen/tools/merge_cppcheck_reports.py was used by the makefile rules, but its functionality is integrated in the xen-analysis.py script now, so it can be removed.

[PATCH v3 2/5] xen/scripts: add cppcheck tool to the xen-analysis.py script

2022-12-07 Thread Luca Fancellu
Add Cppcheck analysis to the xen-analysis.py script using the arguments --run-cppcheck. Now cppcheck analysis will build Xen while the analysis is performed on the source files, it will produce a text report and an additional html output when the script is called with --cppcheck-html. With this p

[PATCH v3 4/5] tools/misra: fix skipped rule numbers

2022-12-07 Thread Luca Fancellu
MISRA rules are in the format Rule X.Y, currently the script convert_misra_doc.py is using two nested loop through range(1,22) to enumerate rules that needs to be skipped, using combination of X.Y in that range, however there are two issues in the code: - rule 22 is never included because the rang

[PATCH v3 0/5] Static analyser finding deviation

2022-12-07 Thread Luca Fancellu
This serie introduces a way to suppress a static analyser finding providing a proper justification for it. The process is explained in the docs/misra/documenting-violations.rst document that this serie will provide. The tools currently supported are eclair, coverity and cppcheck, but the design is

[PATCH v3 5/5] xen: Justify linker script defined symbols in include/xen/kernel.h

2022-12-07 Thread Luca Fancellu
Eclair and Coverity found violation of the MISRA rule 8.6 for the symbols _start, _end, start, _stext, _etext, _srodata, _erodata, _sinittext, _einittext which are declared in xen/include/xen/kernel.h. All those symbols are defined by the liker script so we can deviate from the rule 8.6 for these c

[PATCH v3 1/5] xen/scripts: add xen-analysis.py for coverity and eclair analysis

2022-12-07 Thread Luca Fancellu
Add new script for coverity/eclair analysis tool that will enable the procedure to suppress findings when these tool are used. The procedure is documented in docs/misra/documenting-violations.rst and the script is documented in docs/misra/xen-static-analysis.rst. Add in docs/misra/ the files safe.

Re: [PATCH] xsm: misra rule 8.4 fix

2022-12-07 Thread Michal Orzel
Hi Stefano, On 07/12/2022 03:12, Stefano Stabellini wrote: > > > Fix two MISRA Issues Rule 8.4 ("A compatible declaration shall be > visible when an object or function with external linkage is defined") > found by cppcheck affecting xen/xsm/flask/ss/services.c. > > Fix the first issue by making

[xen-4.16-testing test] 175067: tolerable FAIL - PUSHED

2022-12-07 Thread osstest service owner
flight 175067 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/175067/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 174981 test-amd64-amd64-xl-qemuu-win7-a

Re: [PATCH] xen/netback: fix build warning

2022-12-07 Thread Ross Lagerwall
> From: Xen-devel on behalf of Juergen > Gross > Sent: Wednesday, December 7, 2022 7:23 AM > To: linux-ker...@vger.kernel.org ; > net...@vger.kernel.org > Cc: Juergen Gross ; Wei Liu ; Paul > Durrant ; David S. Miller ; Eric Dumazet > ; Jakub Kicinski ; Paolo Abeni > ; xen-devel@lists.xenpr

Re: [PATCH 7/8] x86/mm: make code robust to future PAT changes

2022-12-07 Thread Andrew Cooper
On 07/12/2022 09:41, Jan Beulich wrote: > On 06.12.2022 18:55, Demi Marie Obenour wrote: >> On Tue, Dec 06, 2022 at 12:06:24PM +, Andrew Cooper wrote: >>> On 06/12/2022 04:33, Demi Marie Obenour wrote: @@ -961,13 +1000,24 @@ get_page_from_l1e( switch ( l1f & PAGE_CACHE

Re: [PATCH] xsm: misra rule 8.4 fix

2022-12-07 Thread Daniel P. Smith
On 12/7/22 04:47, Jan Beulich wrote: On 07.12.2022 03:12, Stefano Stabellini wrote: Fix two MISRA Issues Rule 8.4 ("A compatible declaration shall be visible when an object or function with external linkage is defined") found by cppcheck affecting xen/xsm/flask/ss/services.c. Fix the first issu

Re: [RFC PATCH] xen/common: cache colored buddy allocator for domains

2022-12-07 Thread Jan Beulich
On 22.10.2022 18:08, Carlo Nonato wrote: > This commit replaces the colored allocator for domains with a simple buddy > allocator indexed also by colors, so that it can allocate pages based on > some coloring configuration. > > It applies on top of Arm cache coloring (v3) as sent to the mailing li

Re: [PATCH 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2022-12-07 Thread Julien Grall
Hi Stefano, On 07/12/2022 01:37, Stefano Stabellini wrote: On Mon, 5 Dec 2022, Henry Wang wrote: As we are having more and more types of static region, and all of these static regions are defined in bootinfo.reserved_mem, it is necessary to add the overlap check of reserved memory regions in Xe

Ping: [PATCH v2] xen: credit2: respect credit2_runqueue=all when arranging runqueues

2022-12-07 Thread Jan Beulich
On 03.10.2022 18:21, Marek Marczykowski-Górecki wrote: > Documentation for credit2_runqueue=all says it should create one queue > for all pCPUs on the host. But since introduction > sched_credit2_max_cpus_runqueue, it actually created separate runqueue > per socket, even if the CPUs count is below

Re: [PATCH] xen/netback: fix build warning

2022-12-07 Thread Juergen Gross
On 07.12.22 11:26, Jan Beulich wrote: On 07.12.2022 11:18, Juergen Gross wrote: On 07.12.22 10:25, Jan Beulich wrote: On 07.12.2022 08:23, Juergen Gross wrote: Commit ad7f402ae4f4 ("xen/netback: Ensure protocol headers don't fall in the non-linear area") introduced a (valid) build warning. Fi

Re: [PATCH] x86/platform: Protect XENPF_get_dom0_console if CONFIG_VIDEO not set

2022-12-07 Thread Jan Beulich
On 07.12.2022 11:38, Michal Orzel wrote: > Hi Jan, > > On 07/12/2022 11:34, Jan Beulich wrote: >> >> >> On 07.12.2022 11:29, Michal Orzel wrote: >>> A build failure [1] is observed if CONFIG_VGA (and thus CONFIG_VIDEO) is >>> not set. This is because XENPF_get_dom0_console cmd of platform hypercal

Re: [PATCH] x86/platform: Protect XENPF_get_dom0_console if CONFIG_VIDEO not set

2022-12-07 Thread Michal Orzel
Hi Jan, On 07/12/2022 11:34, Jan Beulich wrote: > > > On 07.12.2022 11:29, Michal Orzel wrote: >> A build failure [1] is observed if CONFIG_VGA (and thus CONFIG_VIDEO) is >> not set. This is because XENPF_get_dom0_console cmd of platform hypercall >> makes a call to fill_console_start_info, whic

Re: [PATCH] x86/platform: Protect XENPF_get_dom0_console if CONFIG_VIDEO not set

2022-12-07 Thread Jan Beulich
On 07.12.2022 11:29, Michal Orzel wrote: > A build failure [1] is observed if CONFIG_VGA (and thus CONFIG_VIDEO) is > not set. This is because XENPF_get_dom0_console cmd of platform hypercall > makes a call to fill_console_start_info, which is defined in video/vga.c > and built only if CONFIG_VGA i

Re: [PATCH v2] ioreq_broadcast(): accept partial broadcast success

2022-12-07 Thread Jan Beulich
(Cc to xen-devel@ re-added; I don't see why it was dropped) On 07.12.2022 11:25, Per Bilse (3P) wrote: > On 07/12/2022 09:05, Jan Beulich wrote: >> On 06.12.2022 18:52, Per Bilse wrote: >>> +if ( !s->enabled || (buffered && >>> +s->bufioreq_handling == HVM_IOREQSRV_BUFI

[PATCH] x86/platform: Protect XENPF_get_dom0_console if CONFIG_VIDEO not set

2022-12-07 Thread Michal Orzel
A build failure [1] is observed if CONFIG_VGA (and thus CONFIG_VIDEO) is not set. This is because XENPF_get_dom0_console cmd of platform hypercall makes a call to fill_console_start_info, which is defined in video/vga.c and built only if CONFIG_VGA is set. To fix this issue, protect XENPF_get_dom0

Re: [PATCH] xen/netback: fix build warning

2022-12-07 Thread Jan Beulich
On 07.12.2022 11:18, Juergen Gross wrote: > On 07.12.22 10:25, Jan Beulich wrote: >> On 07.12.2022 08:23, Juergen Gross wrote: >>> Commit ad7f402ae4f4 ("xen/netback: Ensure protocol headers don't fall in >>> the non-linear area") introduced a (valid) build warning. >>> >>> Fix it. >>> >>> Fixes: ad

Re: [PATCH] xen/netback: fix build warning

2022-12-07 Thread Juergen Gross
On 07.12.22 10:25, Jan Beulich wrote: On 07.12.2022 08:23, Juergen Gross wrote: Commit ad7f402ae4f4 ("xen/netback: Ensure protocol headers don't fall in the non-linear area") introduced a (valid) build warning. Fix it. Fixes: ad7f402ae4f4 ("xen/netback: Ensure protocol headers don't fall in th

Re: [PATCH v2] Use EfiACPIReclaimMemory for ESRT

2022-12-07 Thread Jan Beulich
On 07.12.2022 00:27, Demi Marie Obenour wrote: > A previous patch tried to get Linux to use the ESRT under Xen if it is > in memory of type EfiRuntimeServicesData. However, this turns out to be > a bad idea. Ard Biesheuvel pointed out that EfiRuntimeServices* memory > winds up fragmenting both th

Re: [PATCH] Validate EFI memory descriptors

2022-12-07 Thread Jan Beulich
On 07.12.2022 00:57, Demi Marie Obenour wrote: > It turns out that these can be invalid in various ways. Based on code > Ard Biesheuvel contributed for Linux. > > Co-developed-by: Ard Biesheuvel > Signed-off-by: Demi Marie Obenour > Signed-off-by: Ard Biesheuvel This comes with the risk of br

Re: [PATCH 2/3] x86/pv-shim: don't even allow enabling GRANT_TABLE

2022-12-07 Thread Juergen Gross
On 07.12.22 10:35, Jan Beulich wrote: On 07.12.2022 10:11, Juergen Gross wrote: On 07.12.22 09:55, Jan Beulich wrote: On 07.12.2022 08:21, Jan Beulich wrote: On 06.12.2022 21:26, Andrew Cooper wrote: On 06/12/2022 14:30, Jan Beulich wrote: Grant table code is unused in shim mode, so there's

Re: [PATCH] xsm: misra rule 8.4 fix

2022-12-07 Thread Jan Beulich
On 07.12.2022 03:12, Stefano Stabellini wrote: > Fix two MISRA Issues Rule 8.4 ("A compatible declaration shall be > visible when an object or function with external linkage is defined") > found by cppcheck affecting xen/xsm/flask/ss/services.c. > > Fix the first issue by making policydb_loaded_ve

Re: [PATCH 7/8] x86/mm: make code robust to future PAT changes

2022-12-07 Thread Jan Beulich
On 06.12.2022 18:55, Demi Marie Obenour wrote: > On Tue, Dec 06, 2022 at 12:06:24PM +, Andrew Cooper wrote: >> On 06/12/2022 04:33, Demi Marie Obenour wrote: >>> @@ -961,13 +1000,24 @@ get_page_from_l1e( >>> >>> switch ( l1f & PAGE_CACHE_ATTRS ) >>> { >>> -case _PAGE

Re: [PATCH 2/3] x86/pv-shim: don't even allow enabling GRANT_TABLE

2022-12-07 Thread Jan Beulich
On 07.12.2022 10:11, Juergen Gross wrote: > On 07.12.22 09:55, Jan Beulich wrote: >> On 07.12.2022 08:21, Jan Beulich wrote: >>> On 06.12.2022 21:26, Andrew Cooper wrote: On 06/12/2022 14:30, Jan Beulich wrote: > Grant table code is unused in shim mode, so there's no point in > buildin

Re: [PATCH] xen/netback: fix build warning

2022-12-07 Thread Jan Beulich
On 07.12.2022 08:23, Juergen Gross wrote: > Commit ad7f402ae4f4 ("xen/netback: Ensure protocol headers don't fall in > the non-linear area") introduced a (valid) build warning. > > Fix it. > > Fixes: ad7f402ae4f4 ("xen/netback: Ensure protocol headers don't fall in the > non-linear area") > Sign

Re: [PATCH 2/3] x86/pv-shim: don't even allow enabling GRANT_TABLE

2022-12-07 Thread Juergen Gross
On 07.12.22 09:55, Jan Beulich wrote: On 07.12.2022 08:21, Jan Beulich wrote: On 06.12.2022 21:26, Andrew Cooper wrote: On 06/12/2022 14:30, Jan Beulich wrote: Grant table code is unused in shim mode, so there's no point in building it in the first place for shim-exclusive mode. Signed-off-by

Re: [PATCH v2] ioreq_broadcast(): accept partial broadcast success

2022-12-07 Thread Jan Beulich
On 06.12.2022 18:52, Per Bilse wrote: > --- a/xen/common/ioreq.c > +++ b/xen/common/ioreq.c > @@ -1317,7 +1317,8 @@ unsigned int ioreq_broadcast(ioreq_t *p, bool buffered) > > FOR_EACH_IOREQ_SERVER(d, id, s) > { > -if ( !s->enabled ) > +if ( !s->enabled || (buffered && >

Re: [PATCH 2/3] x86/pv-shim: don't even allow enabling GRANT_TABLE

2022-12-07 Thread Jan Beulich
On 07.12.2022 08:21, Jan Beulich wrote: > On 06.12.2022 21:26, Andrew Cooper wrote: >> On 06/12/2022 14:30, Jan Beulich wrote: >>> Grant table code is unused in shim mode, so there's no point in >>> building it in the first place for shim-exclusive mode. >>> >>> Signed-off-by: Jan Beulich >> >> na

[xen-unstable test] 175066: tolerable FAIL - PUSHED

2022-12-07 Thread osstest service owner
flight 175066 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175066/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 175062 test-amd64-i386-xl-qemuu-win7-amd64

Re: [XEN][RFC PATCH v4 12/16] xen/arm: Implement device tree node removal functionalities

2022-12-07 Thread Jan Beulich
On 07.12.2022 07:18, Vikram Garhwal wrote: > --- a/xen/include/public/sysctl.h > +++ b/xen/include/public/sysctl.h > @@ -1079,6 +1079,23 @@ typedef struct xen_sysctl_cpu_policy > xen_sysctl_cpu_policy_t; > DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cpu_policy_t); > #endif > > +#define XEN_SYSCTL_DT_OV

Re: [XEN][RFC PATCH v4 10/16] asm/smp.h: move cpu related function to asm/cpu.h

2022-12-07 Thread Jan Beulich
On 07.12.2022 07:18, Vikram Garhwal wrote: > --- a/xen/include/xen/cpu.h > +++ b/xen/include/xen/cpu.h > @@ -5,6 +5,10 @@ > #include > #include > > +#ifdef CONFIG_ARM > +#include > +#endif > + > /* Safely access cpu_online_map, cpu_present_map, etc. */ > bool get_cpu_maps(void); > void pu

Re: [PATCH RFC 07/10] domain: map/unmap GADDR based shared guest areas

2022-12-07 Thread Jan Beulich
On 06.12.2022 19:27, Julien Grall wrote: > On 29/11/2022 14:02, Jan Beulich wrote: >> On 29.11.2022 09:40, Julien Grall wrote: >>> On 28/11/2022 10:01, Jan Beulich wrote: On 24.11.2022 22:29, Julien Grall wrote: > On 19/10/2022 09:43, Jan Beulich wrote: >> --- a/xen/common/domain.c >>>

[linux-linus test] 175065: regressions - FAIL

2022-12-07 Thread osstest service owner
flight 175065 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175065/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 173462 test-arm64-arm64-ex