[xen-4.17-testing test] 180683: tolerable trouble: fail/pass/starved - PUSHED

2023-05-17 Thread osstest service owner
flight 180683 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/180683/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 180446 test-amd64-i386-xl-qemuu-win7-am

Re: [PATCH 2/2] xen/x86/pvh: copy ACPI tables to Dom0 instead of mapping

2023-05-17 Thread Roger Pau Monné
On Tue, May 16, 2023 at 04:34:09PM -0700, Stefano Stabellini wrote: > On Tue, 16 May 2023, Roger Pau Monné wrote: > > On Mon, May 15, 2023 at 05:11:25PM -0700, Stefano Stabellini wrote: > > > On Mon, 15 May 2023, Roger Pau Monné wrote: > > > > On Fri, May 12, 2023 at 06:17:20PM -0700, Stefano Stabe

Re: [PATCH 1/2] xen/x86/pvh: use preset XSDT header for XSDT generation

2023-05-17 Thread Roger Pau Monné
On Tue, May 16, 2023 at 03:11:49PM -0700, Stefano Stabellini wrote: > On Tue, 16 May 2023, Roger Pau Monné wrote: > > On Tue, May 16, 2023 at 10:10:07AM +0200, Roger Pau Monné wrote: > > > On Mon, May 15, 2023 at 05:16:27PM -0700, Stefano Stabellini wrote: > > > > On Mon, 15 May 2023, Jan Beulich w

Re: [PATCH 6/6] x86/boot: Expose MSR_ARCH_CAPS data in guest max policies

2023-05-17 Thread Jan Beulich
On 16.05.2023 21:31, Andrew Cooper wrote: > On 16/05/2023 3:53 pm, Jan Beulich wrote: >> On 16.05.2023 16:16, Andrew Cooper wrote: >>> On 16/05/2023 3:06 pm, Jan Beulich wrote: On 16.05.2023 15:51, Andrew Cooper wrote: > On 16/05/2023 2:06 pm, Jan Beulich wrote: >> On 15.05.2023 16:42,

Re: [PATCH] xen/pt: fix igd passthrough for pc machine with xen accelerator

2023-05-17 Thread Chuck Zmudzinski
On 5/17/2023 2:39 AM, Michael Tokarev wrote: > 08.02.2023 05:03, Chuck Zmudzinski wrote: > > Commit 998250e97661 ("xen, gfx passthrough: register host bridge specific > > to passthrough") uses the igd-passthrough-i440FX pci host device with > > the xenfv machine type and igd-passthru=on, but using

Re: [PATCH 2/2] xen/misra: diff-report.py: add report patching feature

2023-05-17 Thread Luca Fancellu
> On 17 May 2023, at 02:33, Stefano Stabellini wrote: > > On Thu, 4 May 2023, Luca Fancellu wrote: >> Add a feature to the diff-report.py script that improves the comparison >> between two analysis report, one from a baseline codebase and the other >> from the changes applied to the baseline. >

Re: [PATCH RFC] xen: Enable -Wwrite-strings

2023-05-17 Thread Jan Beulich
On 16.05.2023 22:34, Andrew Cooper wrote: > Following on from the MISRA discussions. > > On x86, most are trivial. The two slightly suspect cases are __hvm_copy() > where constness is dependent on flags, But do we ever pass string literals into there? I certainly would like to avoid the explicit

[qemu-mainline test] 180686: tolerable FAIL - PUSHED

2023-05-17 Thread osstest service owner
flight 180686 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180686/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 180673 test-amd64-amd64-xl-qemuu-ws16-amd6

Re: [PATCH 1/2] xen/misra: add diff-report.py tool

2023-05-17 Thread Luca Fancellu
> On 17 May 2023, at 02:26, Stefano Stabellini wrote: > > On Thu, 4 May 2023, Luca Fancellu wrote: >> Add a new tool, diff-report.py that can be used to make diff between >> reports generated by xen-analysis.py tool. >> Currently this tool supports the Xen cppcheck text report format in >> its

Re: [PATCH] xen/pt: fix igd passthrough for pc machine with xen accelerator

2023-05-17 Thread Michael Tokarev
17.05.2023 12:47, Chuck Zmudzinski wrote: On 5/17/2023 2:39 AM, Michael Tokarev wrote: 08.02.2023 05:03, Chuck Zmudzinski wrote:... Fixes: 998250e97661 ("xen, gfx passthrough: register host bridge specific to passthrough") Signed-off-by: Chuck Zmudzinski Has this change been forgotten? Is

[PATCH] xen: xen_debug_interrupt prototype to global header

2023-05-17 Thread Arnd Bergmann
From: Arnd Bergmann The xen_debug_interrupt() function is only called on x86, which has a prototype in an architecture specific header, but the definition also exists on others, where the lack of a prototype causes a W=1 warning: drivers/xen/events/events_2l.c:264:13: error: no previous prototyp

Re: [PATCH 1/4] x86/cpufeature: Rework {boot_,}cpu_has()

2023-05-17 Thread Jan Beulich
On 16.05.2023 16:53, Andrew Cooper wrote: > --- a/xen/arch/x86/include/asm/cpufeature.h > +++ b/xen/arch/x86/include/asm/cpufeature.h > @@ -7,6 +7,7 @@ > #define __ASM_I386_CPUFEATURE_H > > #include > +#include > #include This isn't needed up here, and ... > @@ -17,7 +18,6 @@ > #define X

[PATCH] libelf: make L1_MFN_VALID note known

2023-05-17 Thread Jan Beulich
We still don't use it (in the tool stack), and its values (plural) also aren't fetched correctly, but it is odd to continue to see the hypervisor log "ELF: note: unknown (0xd)" when loading a Linux Dom0. Signed-off-by: Jan Beulich --- a/xen/common/libelf/libelf-dominfo.c +++ b/xen/common/libelf/

[PATCH] x86: do away with HAVE_AS_NEGATIVE_TRUE

2023-05-17 Thread Jan Beulich
There's no real need for the associated probing - we can easily convert to a uniform value without knowing the specific behavior (note also that the respective comments weren't fully correct and have gone stale). All we (need to) depend upon is unary ! producing 0 or 1 (and never -1). For all pres

Re: [PATCH 2/4] x86/vtx: Remove opencoded MSR_ARCH_CAPS check

2023-05-17 Thread Jan Beulich
On 16.05.2023 16:53, Andrew Cooper wrote: > MSR_ARCH_CAPS data is now included in featureset information. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich albeit, like in one of the patches in the earlier series, ... > --- a/xen/arch/x86/include/asm/cpufeature.h > +++ b/xen/arch/x86/incl

Re: [PATCH 3/4] x86/tsx: Remove opencoded MSR_ARCH_CAPS check

2023-05-17 Thread Jan Beulich
On 16.05.2023 16:53, Andrew Cooper wrote: > The current cpu_has_tsx_ctrl tristate is serving double pupose; to signal the > first pass through tsx_init(), and the availability of MSR_TSX_CTRL. > > Drop the variable, replacing it with a once boolean, and altering > cpu_has_tsx_ctrl to come out of t

Re: [PATCH 2/4] x86/vtx: Remove opencoded MSR_ARCH_CAPS check

2023-05-17 Thread Jan Beulich
On 17.05.2023 16:36, Jan Beulich wrote: > On 16.05.2023 16:53, Andrew Cooper wrote: >> MSR_ARCH_CAPS data is now included in featureset information. >> >> Signed-off-by: Andrew Cooper > > Acked-by: Jan Beulich Oops - this was really meant to be Reviewed-by: Jan Beulich Jan > albeit, like in

Re: [PATCH 4/4] x86/spec-ctrl: Remove opencoded MSR_ARCH_CAPS check

2023-05-17 Thread Jan Beulich
On 16.05.2023 16:53, Andrew Cooper wrote: > @@ -401,6 +400,8 @@ static void __init print_details(enum ind_thunk thunk, > uint64_t caps) > cpuid_count(7, 2, &tmp, &tmp, &tmp, &_7d2); > if ( boot_cpu_data.extended_cpuid_level >= 0x8008 ) > cpuid(0x8008, &tmp, &e8b, &tm

Re: [PATCH] docs: fix xenstore-paths doc structure

2023-05-17 Thread Jan Beulich
On 09.05.2023 12:25, Yann Dirson wrote: > We currently have "Per Domain Paths" as an empty section, whereas it > looks like "General Paths" was not indended to include all the > following sections. > > Signed-off-by: Yann Dirson Reviewed-by: Jan Beulich Cc-ing the xenstore folks for an ack. J

Re: [PATCH 0/3] officializing xenstore control/feature-balloon entry

2023-05-17 Thread Jan Beulich
On 10.05.2023 16:20, Yann Dirson wrote: > The main topic of this patch series is the ~/control/feature-balloon > entry used by XAPI, prompted by the report of xe-guest-utilities on > FreeBSD not being able to report the feature when using just libxl on > the host. > > First patch is a bit off-topi

Re: [PATCH] MAINTAINERS: add more xenstore files

2023-05-17 Thread Jan Beulich
On 28.04.2023 15:27, Juergen Gross wrote: > Xenstore consists of more files than just the tools/xenstore directory. > > Add them to the XENSTORE block. > > Suggested-by: Andrew Cooper > Signed-off-by: Juergen Gross > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff --gi

Re: [PATCH v7 1/5] xen/riscv: add VM space layout

2023-05-17 Thread Oleksii
On Tue, 2023-05-16 at 17:42 +0200, Jan Beulich wrote: > On 11.05.2023 19:09, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/include/asm/config.h > > +++ b/xen/arch/riscv/include/asm/config.h > > @@ -4,6 +4,42 @@ > >  #include > >  #include > >   > > +/* > > + * RISC-V64 Layout: > > + * > > + *

[linux-linus test] 180687: regressions - FAIL

2023-05-17 Thread osstest service owner
flight 180687 linux-linus real [real] flight 180692 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180687/ http://logs.test-lab.xenproject.org/osstest/logs/180692/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

Re: [PATCH v7 2/5] xen/riscv: introduce setup_initial_pages

2023-05-17 Thread Oleksii
On Tue, 2023-05-16 at 18:02 +0200, Jan Beulich wrote: > On 11.05.2023 19:09, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/page.h > > @@ -0,0 +1,58 @@ > > +#ifndef _ASM_RISCV_PAGE_H > > +#define _ASM_RISCV_PAGE_H > > + > > +#include > > +#include > > + > > +#defin

Re: [PATCH 4/4] x86/spec-ctrl: Remove opencoded MSR_ARCH_CAPS check

2023-05-17 Thread Andrew Cooper
On 17/05/2023 3:47 pm, Jan Beulich wrote: > On 16.05.2023 16:53, Andrew Cooper wrote: >> @@ -401,6 +400,8 @@ static void __init print_details(enum ind_thunk thunk, >> uint64_t caps) >> cpuid_count(7, 2, &tmp, &tmp, &tmp, &_7d2); >> if ( boot_cpu_data.extended_cpuid_level >= 0x800

Re: [PATCH RFC] xen: Enable -Wwrite-strings

2023-05-17 Thread Andrew Cooper
On 17/05/2023 11:34 am, Jan Beulich wrote: > On 16.05.2023 22:34, Andrew Cooper wrote: >> Following on from the MISRA discussions. >> >> On x86, most are trivial. The two slightly suspect cases are __hvm_copy() >> where constness is dependent on flags, > But do we ever pass string literals into th

Re: [PATCH] x86: do away with HAVE_AS_NEGATIVE_TRUE

2023-05-17 Thread Andrew Cooper
On 17/05/2023 3:22 pm, Jan Beulich wrote: > There's no real need for the associated probing - we can easily convert > to a uniform value without knowing the specific behavior (note also that > the respective comments weren't fully correct and have gone stale). All > we (need to) depend upon is unar

Re: [PATCH v1] automation: allow to rerun build script

2023-05-17 Thread Stefano Stabellini
On Wed, 17 May 2023, Olaf Hering wrote: > Calling build twice in the same environment will fail because the > directory 'binaries' was already created before. Use mkdir -p to ignore > an existing directory and move on to the actual build. > > Signed-off-by: Olaf Hering Acked-by: Stefano Stabelli

Re: [PATCH v2 1/2] x86/mm: add API for marking only part of a MMIO page read only

2023-05-17 Thread Jason Andryuk
On Fri, May 5, 2023 at 5:26 PM Marek Marczykowski-Górecki wrote: > > In some cases, only few registers on a page needs to be write-protected. Maybe "In some cases, only part of a page needs to be write-protected"? > Examples include USB3 console (64 bytes worth of registers) or MSI-X's > PBA tab

[libvirt test] 180688: tolerable all pass - PUSHED

2023-05-17 Thread osstest service owner
flight 180688 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180688/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-checkfail like 180642 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [PATCH 2/2] xen/misra: diff-report.py: add report patching feature

2023-05-17 Thread Stefano Stabellini
On Wed, 17 May 2023, Luca Fancellu wrote: > > On 17 May 2023, at 02:33, Stefano Stabellini wrote: > > > > On Thu, 4 May 2023, Luca Fancellu wrote: > >> Add a feature to the diff-report.py script that improves the comparison > >> between two analysis report, one from a baseline codebase and the ot

Re: [PATCH] xen: xen_debug_interrupt prototype to global header

2023-05-17 Thread Stefano Stabellini
On Wed, 17 May 2023, Arnd Bergmann wrote: > From: Arnd Bergmann > > The xen_debug_interrupt() function is only called on x86, which has a > prototype in an architecture specific header, but the definition also > exists on others, where the lack of a prototype causes a W=1 warning: > > drivers/xe

Re: [PATCH] xen/pt: fix igd passthrough for pc machine with xen accelerator

2023-05-17 Thread Stefano Stabellini
On Wed, 17 May 2023, Michael Tokarev wrote: > 17.05.2023 12:47, Chuck Zmudzinski wrote: > > On 5/17/2023 2:39 AM, Michael Tokarev wrote: > > > 08.02.2023 05:03, Chuck Zmudzinski wrote:... > > > > Fixes: 998250e97661 ("xen, gfx passthrough: register host bridge > > > > specific to passthrough") > >

Re: [PATCH 2/2] xen/x86/pvh: copy ACPI tables to Dom0 instead of mapping

2023-05-17 Thread Stefano Stabellini
On Wed, 17 May 2023, Roger Pau Monné wrote: > On Tue, May 16, 2023 at 04:34:09PM -0700, Stefano Stabellini wrote: > > On Tue, 16 May 2023, Roger Pau Monné wrote: > > > On Mon, May 15, 2023 at 05:11:25PM -0700, Stefano Stabellini wrote: > > > > On Mon, 15 May 2023, Roger Pau Monné wrote: > > > > > O

[PATCH 2/6] block/nvme: convert to blk_io_plug_call() API

2023-05-17 Thread Stefan Hajnoczi
Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi --- block/nvme.c | 44 1 file changed, 12 insertions(+), 32 de

[PATCH 3/6] block/blkio: convert to blk_io_plug_call() API

2023-05-17 Thread Stefan Hajnoczi
Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi --- block/blkio.c | 40 +--- 1 file changed, 21 insertions(+), 19 delet

[PATCH 1/6] block: add blk_io_plug_call() API

2023-05-17 Thread Stefan Hajnoczi
Introduce a new API for thread-local blk_io_plug() that does not traverse the block graph. The goal is to make blk_io_plug() multi-queue friendly. Instead of having block drivers track whether or not we're in a plugged section, provide an API that allows them to defer a function call until we're u

[PATCH 6/6] block: remove bdrv_co_io_plug() API

2023-05-17 Thread Stefan Hajnoczi
No block driver implements .bdrv_co_io_plug() anymore. Get rid of the function pointers. Signed-off-by: Stefan Hajnoczi --- include/block/block-io.h | 3 --- include/block/block_int-common.h | 11 -- block/io.c | 37 3 files

[PATCH 5/6] block/linux-aio: convert to blk_io_plug_call() API

2023-05-17 Thread Stefan Hajnoczi
Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi --- include/block/raw-aio.h | 7 --- block/file-posix.c | 28 block/

[PATCH 4/6] block/io_uring: convert to blk_io_plug_call() API

2023-05-17 Thread Stefan Hajnoczi
Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi --- include/block/raw-aio.h | 7 --- block/file-posix.c | 10 - block/io_uring.c|

[PATCH 0/6] block: add blk_io_plug_call() API

2023-05-17 Thread Stefan Hajnoczi
The existing blk_io_plug() API is not block layer multi-queue friendly because the plug state is per-BlockDriverState. Change blk_io_plug()'s implementation so it is thread-local. This is done by introducing the blk_io_plug_call() function that block drivers use to batch calls while plugged. It is

[xen-unstable test] 180689: tolerable FAIL - PUSHED

2023-05-17 Thread osstest service owner
flight 180689 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180689/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 180682 test-amd64-i386-xl-qemuu-win7-amd64

PVH Dom0 related UART failure

2023-05-17 Thread Stefano Stabellini
Hi all, I have run into another PVH Dom0 issue. I am trying to enable a PVH Dom0 test with the brand new gitlab-ci runner offered by Qubes. It is an AMD Zen3 system and we already have a few successful tests with it, see automation/gitlab-ci/test.yaml. We managed to narrow down the issue to a con

Re: [PATCH] xen: Fix host pci for stubdom

2023-05-17 Thread Jason Andryuk
On Mon, May 15, 2023 at 11:04 AM Anthony PERARD wrote: > > On Sun, Mar 19, 2023 at 08:05:54PM -0400, Jason Andryuk wrote: > > diff --git a/hw/xen/xen-host-pci-device.c b/hw/xen/xen-host-pci-device.c > > index 8c6e9a1716..51a72b432d 100644 > > --- a/hw/xen/xen-host-pci-device.c > > +++ b/hw/xen/xen

[xen-unstable-smoke test] 180694: tolerable all pass - PUSHED

2023-05-17 Thread osstest service owner
flight 180694 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180694/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 180695: all pass - PUSHED

2023-05-17 Thread osstest service owner
flight 180695 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180695/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0abfb0be6cf78a8e962383e85cec57851ddae5bc baseline version: ovmf cafb4f3f36e2101cab2ed

[linux-5.4 test] 180690: tolerable FAIL - PUSHED

2023-05-17 Thread osstest service owner
flight 180690 linux-5.4 real [real] flight 180697 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180690/ http://logs.test-lab.xenproject.org/osstest/logs/180697/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386