[linux-linus test] 181186: regressions - trouble: broken/fail/pass

2023-06-05 Thread osstest service owner
flight 181186 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181186/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386-xsmbroken test-armhf-armhf-xl-credit1 8

[qemu-mainline test] 181185: regressions - trouble: blocked/broken/fail/pass

2023-06-05 Thread osstest service owner
flight 181185 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181185/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-coresched-amd64-xl broken test-amd64-amd64-libvirt-pair 30 leak-c

[qemu-mainline bisection] complete test-amd64-i386-libvirt

2023-06-05 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-libvirt testid leak-check/check Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbi

[linux-5.4 test] 181182: tolerable FAIL - PUSHED

2023-06-05 Thread osstest service owner
flight 181182 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/181182/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds18 guest-start/debian.repeat fail REGR. vs. 181015 Tests which did not succeed, b

Re: Xen reliance on non-standard GCC features

2023-06-05 Thread Stefano Stabellini
On Mon, 5 Jun 2023, Roberto Bagnara wrote: > > > Here is a list of extensions that are documented in the GCC manual: > > > > I suppose that this list wasn't meant to be complete? The most > > prominent example is probably asm(). > > As far as I can tell the list was almost complete (I realize now

Re: [XEN][PATCH v7 15/19] xen/arm: Implement device tree node removal functionalities

2023-06-05 Thread Julien Grall
Hi Vikram, On 02/06/2023 01:48, Vikram Garhwal wrote: Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using device tree overlay. xl dt-overlay remove file.dtbo: Removes all the nodes in a given dtbo. First, removes IRQ permissions and MMIO accesses. Next, it f

Re: [XEN][PATCH v7 14/19] common/device_tree: Add rwlock for dt_host

2023-06-05 Thread Julien Grall
Hi, On 02/06/2023 01:48, Vikram Garhwal wrote: Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing the dt_host during runtime. Please explain that writer

[xen-unstable-smoke test] 181195: tolerable all pass - PUSHED

2023-06-05 Thread osstest service owner
flight 181195 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181195/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [XEN][PATCH v7 13/19] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h

2023-06-05 Thread Julien Grall
Hi, On 02/06/2023 01:48, Vikram Garhwal wrote: Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing the dt_host. Reading this sentence, it sounds like you are

Re: [XEN][PATCH v7 11/19] xen/iommu: Introduce iommu_remove_dt_device()

2023-06-05 Thread Julien Grall
Hi, On 02/06/2023 01:48, Vikram Garhwal wrote: Remove master device from the IOMMU. This will be helpful when removing the overlay nodes using dynamic programming during run time. Signed-off-by: Vikram Garhwal Reviewed-by: Michal Orzel Acked-by: Jan Beulich --- xen/drivers/passthrough/devi

Re: [XEN][PATCH v7 10/19] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock

2023-06-05 Thread Julien Grall
Hi, On 02/06/2023 01:48, Vikram Garhwal wrote: Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access add. The commit message is a bit light. What sort of concurrent access add are you talking about? Is it of the same node? Different node? Also, is it a existing issue o

Re: [XEN][PATCH v7 09/19] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller

2023-06-05 Thread Julien Grall
Hi, On 02/06/2023 08:45, Michal Orzel wrote: On 02/06/2023 02:48, Vikram Garhwal wrote: diff --git a/xen/include/xen/iommu-private.h b/xen/include/xen/iommu-private.h new file mode 100644 index 00..5615decaff --- /dev/null +++ b/xen/include/xen/iommu-private.h @@ -0,0 +1,27 @@ +/* SPDX

Re: [XEN][PATCH v7 09/19] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller

2023-06-05 Thread Julien Grall
Hi, On 02/06/2023 01:48, Vikram Garhwal wrote: Rename iommu_dt_device_is_assigned() to iommu_dt_device_is_assigned_locked(). Remove static type so this can also be used by SMMU drivers to check if the device is being used before removing. Moving spin_lock to caller was done to prevent the concu

Re: [XEN][PATCH v7 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree

2023-06-05 Thread Julien Grall
Hi, On 02/06/2023 01:48, Vikram Garhwal wrote: Add device_tree_find_node_by_path() to find a matching node with path for a AFAICT, the only difference in name between the new function and the existing one is "device_tree" vs "dt". The latter is just a shorthand of "device tree", so it feels

Re: [XEN][PATCH v7 07/19] libfdt: overlay: change overlay_get_target()

2023-06-05 Thread Julien Grall
Hi, On 02/06/2023 01:48, Vikram Garhwal wrote: Rename overlay_get_target() to fdt_overlay_target_offset() and remove static function type. This is done to get the target path for the overlay nodes which is very useful in many cases. For example, Xen hypervisor needs it when applying overlays be

Re: [XEN][PATCH v7 04/19] common/device_tree: change __unflatten_device_tree() type

2023-06-05 Thread Julien Grall
Hi, Title: 'type' is a bit confusing here. How about "Export __unflatten_device_tre()"? On 02/06/2023 01:48, Vikram Garhwal wrote: Following changes are done to __unflatten_device_tree(): 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). 2. Remove __init and static

Re: [XEN][PATCH v7 01/19] common/device_tree: handle memory allocation failure in __unflatten_device_tree()

2023-06-05 Thread Julien Grall
Hi, On 02/06/2023 01:48, Vikram Garhwal wrote: Change __unflatten_device_tree() return type to integer so it can propagate memory allocation failure. Add panic() in dt_unflatten_host_device_tree() for memory allocation failure during boot. Fixes: fb97eb614acf ("xen/arm: Create a hierarchical de

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-05 Thread Julien Grall
Hi, On 01/06/2023 13:38, Michal Orzel wrote: On 01/06/2023 14:17, Julien Grall wrote: On Thu, 1 Jun 2023 at 13:48, Michal Orzel mailto:michal.or...@amd.com>> wrote: Hi Julien, On 01/06/2023 13:12, Julien Grall wrote: > > > > Hi, > > Sorry

Re: [PATCH v3 2/6] iommu/arm: Add iommu_dt_xlate()

2023-06-05 Thread Stewart Hildebrand
On 5/22/23 10:48, Michal Orzel wrote: > Hi Stewart, > > On 18/05/2023 23:06, Stewart Hildebrand wrote: >> >> >> From: Oleksandr Tyshchenko >> >> Move code for processing DT IOMMU specifier to a separate helper. >> This helper will be re-used for adding PCI devices by the subsequent >> patches as

Re: [PATCH v3 1/6] xen/arm: Move is_protected flag to struct device

2023-06-05 Thread Stewart Hildebrand
On 5/22/23 10:28, Michal Orzel wrote: > Hi Stewart, > > On 18/05/2023 23:06, Stewart Hildebrand wrote: >> >> >> From: Oleksandr Tyshchenko >> >> This flag will be re-used for PCI devices by the subsequent >> patches. >> >> Signed-off-by: Oleksandr Tyshchenko >> Signed-off-by: Stewart Hildebrand

[PATCH v2 3/4] x86/microcode: Ignore microcode loading interface for revision = -1

2023-06-05 Thread Alejandro Vallejo
Some hypervisors report ~0 as the microcode revision to mean "don't issue microcode updates". Ignore the microcode loading interface in that case. Signed-off-by: Alejandro Vallejo --- v2: * New addition --- xen/arch/x86/cpu/microcode/core.c | 17 +++-- 1 file changed, 15 insertions

[PATCH v2 0/4] Prevent attempting updates known to fail

2023-06-05 Thread Alejandro Vallejo
[This series spun out of a previous patch with the same name, with this series adding more related enhancements. Kept as v2 to preserve the linkage with previous suggestions.] v2: * Removed a redundant check * Ignore microcode interface if the revision is -1 * Perform the DIS_MCU_LOA

[PATCH v2 1/4] x86/microcode: Remove Intel's family check on early_microcode_init()

2023-06-05 Thread Alejandro Vallejo
Intel only suuports 64bits on families 6 and 15, so we can always assume microcode loading facilities are present and skip the check. Signed-off-by: Alejandro Vallejo --- v2: * New addition --- xen/arch/x86/cpu/microcode/core.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)

[PATCH v2 2/4] x86: Read MSR_ARCH_CAPS after early_microcode_init()

2023-06-05 Thread Alejandro Vallejo
tsx_init() has some ad-hoc code to read MSR_ARCH_CAPS if present. In order to suuport DIS_MCU_UPDATE we need access to it earlier, so this patch moves early read to the tail of early_microcode_init(), after the early microcode update. The read of the 7d0 CPUID leaf is left in a helper because it's

[PATCH v2 4/4] x86/microcode: Prevent attempting updates if DIS_MCU_LOAD is set

2023-06-05 Thread Alejandro Vallejo
If IA32_MSR_MCU_CONTROL exists then it's possible a CPU may be unable to perform microcode updates. This is controlled through the DIS_MCU_LOAD bit and is intended for baremetal clouds where the owner may not trust the tenant to choose the microcode version in use. This patch makes sure we only exp

[xen-unstable-smoke test] 181191: tolerable all pass - PUSHED

2023-06-05 Thread osstest service owner
flight 181191 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181191/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] amd: disable C6 after 1000 days on Fam17h models 30-3fh

2023-06-05 Thread Andrew Cooper
On 05/06/2023 4:54 pm, Jan Beulich wrote: > On 05.06.2023 17:10, Roger Pau Monne wrote: >> As specified on Errata 1474: >> >> "A core will fail to exit CC6 after about 1044 days after the last >> system reset. The time of failure may vary depending on the spread >> spectrum and REFCLK frequency." >

Re: [PATCH] amd: disable C6 after 1000 days on Fam17h models 30-3fh

2023-06-05 Thread Jan Beulich
On 05.06.2023 17:10, Roger Pau Monne wrote: > As specified on Errata 1474: > > "A core will fail to exit CC6 after about 1044 days after the last > system reset. The time of failure may vary depending on the spread > spectrum and REFCLK frequency." > > Detect when running on AMD Fam17h models 30h

Re: [PATCH] amd: disable C6 after 1000 days on Fam17h models 30-3fh

2023-06-05 Thread Andrew Cooper
On 05/06/2023 4:10 pm, Roger Pau Monne wrote: > diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c > index 0d3143031b5b..728fa61a54bb 100644 > --- a/xen/arch/x86/cpu/amd.c > +++ b/xen/arch/x86/cpu/amd.c > @@ -1189,3 +1190,44 @@ const struct cpu_dev amd_cpu_dev = { > .c_early_init

Re: [PATCH 1/2] x86: Introduce arch_domain_teardown()

2023-06-05 Thread Andrew Cooper
On 05/06/2023 4:19 pm, Roger Pau Monné wrote: > On Mon, Jun 05, 2023 at 03:43:30PM +0100, Andrew Cooper wrote: >> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >> index 85242a73d374..854f3e32c00e 100644 >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -589,6

Re: [PATCH 1/2] x86: Introduce arch_domain_teardown()

2023-06-05 Thread Roger Pau Monné
On Mon, Jun 05, 2023 at 03:43:30PM +0100, Andrew Cooper wrote: > Plumb it into domain_teardown(). Provide arch_val in the teardown > continuation information for use by arch_domain_teardown(). > > No practical change. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Mon

[PATCH] amd: disable C6 after 1000 days on Fam17h models 30-3fh

2023-06-05 Thread Roger Pau Monne
As specified on Errata 1474: "A core will fail to exit CC6 after about 1044 days after the last system reset. The time of failure may vary depending on the spread spectrum and REFCLK frequency." Detect when running on AMD Fam17h models 30h-3fh and setup a timer to prevent entering C6 after 1000 d

Re: [PATCH] x86/microcode: Add missing unlock in microcode_update_helper()

2023-06-05 Thread Andrew Cooper
On 05/06/2023 4:01 pm, Alejandro Vallejo wrote: > microcode_update_helper() may return early while holding > cpu_add_remove_lock, hence preventing any writers from taking it again. > > Leave through the `put` label instead so it's properly released. Fixes: 5ed12565aa32 ("microcode: rendezvous CPUs

Re: [PATCH 0/2] xen: Arch Teardown

2023-06-05 Thread Bertrand Marquis
Hi Andrew, > On 5 Jun 2023, at 16:43, Andrew Cooper wrote: > > Sorry this is late... Patch 1 ought to be ready in this form. > > I'll leave it up to the ARM maintainers as to whether they want to take patch > 2 in that form (with TEE in patch 3), or whether to merge the two. > > Compile teste

[PATCH] x86/microcode: Add missing unlock in microcode_update_helper()

2023-06-05 Thread Alejandro Vallejo
microcode_update_helper() may return early while holding cpu_add_remove_lock, hence preventing any writers from taking it again. Leave through the `put` label instead so it's properly released. Signed-off-by: Alejandro Vallejo --- xen/arch/x86/cpu/microcode/core.c | 3 ++- 1 file changed, 2 ins

[PATCH 0/2] xen: Arch Teardown

2023-06-05 Thread Andrew Cooper
Sorry this is late... Patch 1 ought to be ready in this form. I'll leave it up to the ARM maintainers as to whether they want to take patch 2 in that form (with TEE in patch 3), or whether to merge the two. Compile tested on all architectures, functionally tested on x86 only. Branch available f

[PATCH 1/2] x86: Introduce arch_domain_teardown()

2023-06-05 Thread Andrew Cooper
Plumb it into domain_teardown(). Provide arch_val in the teardown continuation information for use by arch_domain_teardown(). No practical change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk

[PATCH 2/2] arm: Boilerpate arch_domain_teardown()

2023-06-05 Thread Andrew Cooper
XXX to be filled in with TEE teardown. Signed-off-by: Andrew Cooper --- CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Jens Wiklander Jens: In the same was as the previous patch in the common path, you want to add a PROG_tee(?) here, and rearrange the

Re: [PATCH v8 0/7] Add pci_dev_for_each_resource() helper and update users

2023-06-05 Thread Andy Shevchenko
On Wed, May 31, 2023 at 04:30:28PM -0500, Bjorn Helgaas wrote: > On Wed, May 31, 2023 at 08:48:35PM +0200, Jonas Gorski wrote: ... > > Looking at the code I understand where coverity is coming from: > > > > #define __pci_dev_for_each_res0(dev, res, ...) \ > >for (

RE: [PATCH v2 10/10] x86emul: AVX512-FP16 testing

2023-06-05 Thread Henry Wang
Hi Jan, > -Original Message- > Subject: Re: [PATCH v2 10/10] x86emul: AVX512-FP16 testing > > Henry, > > On 03.04.2023 17:00, Jan Beulich wrote: > > Naming of some of the builtins isn't fully consistent with that of pre- > > existing ones, so there's a need for a new BR2() wrapper macro.

Re: Xen reliance on non-standard GCC features

2023-06-05 Thread Roberto Bagnara
On 05/06/23 11:28, Jan Beulich wrote: On 05.06.2023 07:28, Roberto Bagnara wrote: U1) Use of _Static_assert in C99 mode. U2) Empty initialization lists, both in C99 mode (ARM64 and X86_64) and C18 mode (only X86_64). U3) Returning void expressions. As per above, tiny extensions like th

Re: [PATCH] libs/light: use the cpuid feature names from cpufeatureset.h

2023-06-05 Thread Roger Pau Monné
On Mon, Jun 05, 2023 at 12:36:57PM +0200, Roger Pau Monne wrote: > @@ -81,6 +83,14 @@ static libxl_cpuid_policy_list > cpuid_find_match(libxl_cpuid_policy_list *list, > return *list + i; > } > > +static int search_feature(const void *a, const void *b) > +{ > +const char *key = a; > +

Re: [PATCH v2 10/10] x86emul: AVX512-FP16 testing

2023-06-05 Thread Jan Beulich
Henry, On 03.04.2023 17:00, Jan Beulich wrote: > Naming of some of the builtins isn't fully consistent with that of pre- > existing ones, so there's a need for a new BR2() wrapper macro. > > With the tests providing some proof of proper functioning of the > emulator code also enable use of the fe

Re: Xen reliance on non-standard GCC features

2023-06-05 Thread Jan Beulich
On 05.06.2023 14:15, Roberto Bagnara wrote: > On 05/06/23 10:58, Andrew Cooper wrote: >> On 05/06/2023 6:28 am, Roberto Bagnara wrote: >>> U10) \m escape sequence. >>> Is this an undocumented GCC extension or just a typo? >> >> Where are you seeing this? >> >> The only examples I see are in a

Re: Xen reliance on non-standard GCC features

2023-06-05 Thread Roberto Bagnara
On 05/06/23 10:58, Andrew Cooper wrote: On 05/06/2023 6:28 am, Roberto Bagnara wrote: U10) \m escape sequence. Is this an undocumented GCC extension or just a typo? Where are you seeing this? The only examples I see are in asm macros, and they're all parameter substitutions. This inclu

Re: [PATCH v2 00/10] x86: support AVX512-FP16

2023-06-05 Thread Andrew Cooper
On 23/05/2023 7:35 am, Jan Beulich wrote: > On 22.05.2023 18:25, Andrew Cooper wrote: >> On 03/04/2023 3:56 pm, Jan Beulich wrote: >>> While I (quite obviously) don't have any suitable hardware, Intel's >>> SDE allows testing the implementation. And since there's no new >>> state (registers) associ

Re: [PATCH] x86emul: rework compiler probing in the test harness

2023-06-05 Thread Andrew Cooper
On 02/03/2023 2:28 pm, Jan Beulich wrote: > Checking for what $(SIMD) contains was initially right, but already the > addition of $(FMA) wasn't. Later categories (correctly) weren't added. > Instead what is of interest is anything the main harness source file > uses outside of suitable #if and with

Re: [PATCH v2] xen: Fix incorrect taint constant

2023-06-05 Thread Bertrand Marquis
Hi Andrew, > On 5 Jun 2023, at 13:23, Andrew Cooper wrote: > > Insecure is the word being looked for here. Especially given the nature of > the sole caller, and the (correct) comment next to it. > > Also update the taint marker from 'U' to 'I' for consistency; this isn't > expected to impact a

[xen-unstable test] 181178: trouble: broken/fail/pass

2023-06-05 Thread osstest service owner
flight 181178 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/181178/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64 broken Tests whi

[PATCH v2] xen: Fix incorrect taint constant

2023-06-05 Thread Andrew Cooper
Insecure is the word being looked for here. Especially given the nature of the sole caller, and the (correct) comment next to it. Also update the taint marker from 'U' to 'I' for consistency; this isn't expected to impact anyone in practice. Fixes: 82c0d3d491cc ("xen: Add an unsecure Taint type"

Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()

2023-06-05 Thread Akihiko Odaki
On 2023/06/05 17:06, Alexander Bulekov wrote: On 230601 1218, Akihiko Odaki wrote: Recently MemReentrancyGuard was added to DeviceState to record that the device is engaging in I/O. The network device backend needs to update it when delivering a packet to a device. In preparation for such a cha

Re: [PATCH] xen: Fix incorrect taint constant

2023-06-05 Thread Andrew Cooper
On 05/06/2023 11:29 am, Bertrand Marquis wrote: > Hi Andrew, > >> On 5 Jun 2023, at 12:05, Andrew Cooper wrote: >> >> Insecure the word being looked for here. Especially given the nature of the >> sole caller, and the (correct) comment next to it. > Good finding. > >> I've left the taint constant

[PATCH] libs/light: use the cpuid feature names from cpufeatureset.h

2023-06-05 Thread Roger Pau Monne
The current implementation in libxl_cpuid_parse_config() requires keeping a list of cpuid feature bits that should be mostly in sync with the contents of cpufeatureset.h. Avoid such duplication by using the automatically generated list of cpuid features in INIT_FEATURE_NAMES in order to map featur

Re: [PATCH] xen: Fix incorrect taint constant

2023-06-05 Thread Jan Beulich
On 05.06.2023 12:14, Andrew Cooper wrote: > On 05/06/2023 11:10 am, Jan Beulich wrote: >> On 05.06.2023 12:05, Andrew Cooper wrote: >>> Insecure the word being looked for here. Especially given the nature of the >> Nit: Missing "is"? > > Oops yes. > >> >>> sole caller, and the (correct) comment

Re: [PATCH] x86/microcode: Prevent attempting updates known to fail

2023-06-05 Thread Alejandro Vallejo
On Fri, Jun 02, 2023 at 09:35:56PM +0100, Andrew Cooper wrote: > For this MCU_CONTROL_DIS_MCU_LOAD case, we don't want to be trying to > load new microcode because that's a waste of time, but we absolutely > should query the current microcode revision.  It is frequently relevant > for security reas

Re: [PATCH] xen: Fix incorrect taint constant

2023-06-05 Thread Bertrand Marquis
Hi Andrew, > On 5 Jun 2023, at 12:05, Andrew Cooper wrote: > > Insecure the word being looked for here. Especially given the nature of the > sole caller, and the (correct) comment next to it. Good finding. > > I've left the taint constant as 'U' as it's a rather more user-visible. I would v

[PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

2023-06-05 Thread Ross Lagerwall
To facilitate diskless iSCSI boot, the firmware can place a table of configuration details in memory called the iBFT. The presence of this table is not specified, nor is the precise location (and it's not in the E820) so the kernel has to search for a magic marker to find it. When running under Xe

Re: [PATCH v2] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

2023-06-05 Thread Ross Lagerwall
> From: Dave Hansen > Sent: Thursday, June 1, 2023 5:57 PM > To: Ross Lagerwall ; linux-ker...@vger.kernel.org > ; xen-devel@lists.xenproject.org > > Cc: Jan Beulich ; Thomas Gleixner ; > Ingo Molnar ; Borislav Petkov ; Dave Hansen > ; x...@kernel.org ; Juergen > Gross ; Boris Ostrovsky ; Pe

Re: [PATCH] xen: Fix incorrect taint constant

2023-06-05 Thread Andrew Cooper
On 05/06/2023 11:10 am, Jan Beulich wrote: > On 05.06.2023 12:05, Andrew Cooper wrote: >> Insecure the word being looked for here. Especially given the nature of the > Nit: Missing "is"? Oops yes. > >> sole caller, and the (correct) comment next to it. >> >> I've left the taint constant as 'U' a

Re: [PATCH] xen: Fix incorrect taint constant

2023-06-05 Thread Jan Beulich
On 05.06.2023 12:05, Andrew Cooper wrote: > Insecure the word being looked for here. Especially given the nature of the Nit: Missing "is"? > sole caller, and the (correct) comment next to it. > > I've left the taint constant as 'U' as it's a rather more user-visible. > > Fixes: 82c0d3d491cc ("

[PATCH] xen: Fix incorrect taint constant

2023-06-05 Thread Andrew Cooper
Insecure the word being looked for here. Especially given the nature of the sole caller, and the (correct) comment next to it. I've left the taint constant as 'U' as it's a rather more user-visible. Fixes: 82c0d3d491cc ("xen: Add an unsecure Taint type") Signed-off-by: Andrew Cooper --- CC: Jan

Re: [PATCH v2 2/3] x86/spec-ctrl: Fix up the RSBA/RRSBA bits as appropriate

2023-06-05 Thread Andrew Cooper
On 05/06/2023 8:50 am, Jan Beulich wrote: > On 05.06.2023 09:48, Jan Beulich wrote: >> On 02.06.2023 15:57, Andrew Cooper wrote: >>> On 02/06/2023 10:56 am, Jan Beulich wrote: On 01.06.2023 16:48, Andrew Cooper wrote: > @@ -593,15 +596,85 @@ static bool __init retpoline_calculations(void)

Re: Xen reliance on non-standard GCC features

2023-06-05 Thread Jan Beulich
On 05.06.2023 11:19, Roberto Bagnara wrote: > On 05/06/23 09:35, Jan Beulich wrote: >> On 05.06.2023 07:28, Roberto Bagnara wrote: >>> Finally, Xen seems to rely on explicitly undefined behavior, namely >>> C99 UB 58: "A structure or union is defined as containing no named >>> members (6.7.2.1)." A

Re: Xen reliance on non-standard GCC features

2023-06-05 Thread Jan Beulich
On 05.06.2023 07:28, Roberto Bagnara wrote: > It appears Xen uses lots of GCC features that are outside the C99 > standard. Some of them are documented GNU extensions to the language. > Some of them seem not to be documented, so they do not qualify > as language extensions (at least, not as far as

Re: [PATCH v3 0/3] diff-report.py tool

2023-06-05 Thread Luca Fancellu
> On 25 May 2023, at 09:33, Luca Fancellu wrote: > > > This serie is dependent on this patch, in case cppcheck report are generated > using xen-analysis.py that calls the makefile with in-tree build, because > this

Re: Xen reliance on non-standard GCC features

2023-06-05 Thread Roberto Bagnara
On 05/06/23 09:35, Jan Beulich wrote: On 05.06.2023 07:28, Roberto Bagnara wrote: Finally, Xen seems to rely on explicitly undefined behavior, namely C99 UB 58: "A structure or union is defined as containing no named members (6.7.2.1)." All instances but one occur via macro BUILD_BUG_ON_ZERO, th

Re: Xen reliance on non-standard GCC features

2023-06-05 Thread Andrew Cooper
On 05/06/2023 6:28 am, Roberto Bagnara wrote: > U10) \m escape sequence. > Is this an undocumented GCC extension or just a typo? Where are you seeing this? The only examples I see are in asm macros, and they're all parameter substitutions. This includes the one in x86's bug.h where it's a p

Re: [XEN][PATCH v7 16/19] xen/arm: Implement device tree node addition functionalities

2023-06-05 Thread Michal Orzel
Hi Vikram, On 02/06/2023 02:48, Vikram Garhwal wrote: > Update sysctl XEN_SYSCTL_dt_overlay to enable support for dtbo nodes addition > using device tree overlay. > > xl dt-overlay add file.dtbo: > Each time overlay nodes are added using .dtbo, a new fdt(memcpy of > device_tree_flattened)

[linux-linus test] 181175: regressions - FAIL

2023-06-05 Thread osstest service owner
flight 181175 linux-linus real [real] flight 181183 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181175/ http://logs.test-lab.xenproject.org/osstest/logs/181183/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

Re: [PATCH v2 3/3] x86/cpu-policy: Derive RSBA/RRSBA for guest policies

2023-06-05 Thread Jan Beulich
On 02.06.2023 17:29, Andrew Cooper wrote: > On 02/06/2023 11:20 am, Jan Beulich wrote: >> On 01.06.2023 16:48, Andrew Cooper wrote: >>> @@ -786,6 +825,20 @@ void recalculate_cpuid_policy(struct domain *d) >>> >>> sanitise_featureset(fs); >>> >>> +/* >>> + * If the host suffers from

Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()

2023-06-05 Thread Alexander Bulekov
On 230601 1218, Akihiko Odaki wrote: > Recently MemReentrancyGuard was added to DeviceState to record that the > device is engaging in I/O. The network device backend needs to update it > when delivering a packet to a device. > > In preparation for such a change, add MemReentrancyGuard * as a > pa

Re: [PATCH v2 2/2] net: Update MemReentrancyGuard for NIC

2023-06-05 Thread Alexander Bulekov
On 230601 1218, Akihiko Odaki wrote: > Recently MemReentrancyGuard was added to DeviceState to record that the > device is engaging in I/O. The network device backend needs to update it > when delivering a packet to a device. > > This implementation follows what bottom half does, but it does not a

Re: [PATCH v2 3/3] x86/cpu-policy: Derive RSBA/RRSBA for guest policies

2023-06-05 Thread Jan Beulich
On 02.06.2023 17:38, Andrew Cooper wrote: > On 02/06/2023 4:29 pm, Andrew Cooper wrote: >> On 02/06/2023 11:20 am, Jan Beulich wrote: >>> On 01.06.2023 16:48, Andrew Cooper wrote: >>> What about a tool stack request leading to us setting the 2nd of the two >>> bits here, while the other was already

Re: [XEN][PATCH v7 15/19] xen/arm: Implement device tree node removal functionalities

2023-06-05 Thread Michal Orzel
Hi Vikram, On 02/06/2023 02:48, Vikram Garhwal wrote: > Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using > device tree overlay. > > xl dt-overlay remove file.dtbo: > Removes all the nodes in a given dtbo. > First, removes IRQ permissions and MMIO accesses. Ne

Re: [PATCH v2 2/3] x86/spec-ctrl: Fix up the RSBA/RRSBA bits as appropriate

2023-06-05 Thread Jan Beulich
On 05.06.2023 09:48, Jan Beulich wrote: > On 02.06.2023 15:57, Andrew Cooper wrote: >> On 02/06/2023 10:56 am, Jan Beulich wrote: >>> On 01.06.2023 16:48, Andrew Cooper wrote: @@ -593,15 +596,85 @@ static bool __init retpoline_calculations(void) return false; /*

Re: [PATCH v2 2/3] x86/spec-ctrl: Fix up the RSBA/RRSBA bits as appropriate

2023-06-05 Thread Jan Beulich
On 02.06.2023 15:57, Andrew Cooper wrote: > On 02/06/2023 10:56 am, Jan Beulich wrote: >> On 01.06.2023 16:48, Andrew Cooper wrote: >>> @@ -593,15 +596,85 @@ static bool __init retpoline_calculations(void) >>> return false; >>> >>> /* >>> - * RSBA may be set by a hypervisor to i

[qemu-mainline test] 181177: regressions - FAIL

2023-06-05 Thread osstest service owner
flight 181177 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181177/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair 30 leak-check/check/src_host fail REGR. vs. 180691 test-amd64-amd

Re: Xen reliance on non-standard GCC features

2023-06-05 Thread Jan Beulich
On 05.06.2023 07:28, Roberto Bagnara wrote: > Finally, Xen seems to rely on explicitly undefined behavior, namely > C99 UB 58: "A structure or union is defined as containing no named > members (6.7.2.1)." All instances but one occur via macro BUILD_BUG_ON_ZERO, > the remaining instance concerns str

Re: [XEN][PATCH v7 14/19] common/device_tree: Add rwlock for dt_host

2023-06-05 Thread Michal Orzel
Hi Vikram, On 02/06/2023 02:48, Vikram Garhwal wrote: > Dynamic programming ops will modify the dt_host and there might be other > function which are browsing the dt_host at the same time. To avoid the race > conditions, adding rwlock for browsing the dt_host during runtime. > > Reason behind

Re: [PATCH v4 0/7] Resolve TYPE_PIIX3_XEN_DEVICE

2023-06-05 Thread Bernhard Beschow
Am 22. Mai 2023 15:42:03 UTC schrieb Bernhard Beschow : > > >Am 15. Mai 2023 20:52:40 UTC schrieb Stefano Stabellini >: >>On Sat, 13 May 2023, Bernhard Beschow wrote: >>> Am 21. April 2023 07:38:10 UTC schrieb "Michael S. Tsirkin" >>> : >>> >On Mon, Apr 03, 2023 at 09:41:17AM +0200, Bernhard B