[xen-unstable test] 181953: regressions - FAIL

2023-07-21 Thread osstest service owner
flight 181953 xen-unstable real [real] flight 181967 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181953/ http://logs.test-lab.xenproject.org/osstest/logs/181967/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: [ARM][xencons] PV Console hangs due to illegal ring buffer accesses

2023-07-21 Thread George Mocanu
Hello, Stefano, Hello, Julien, Thanks for your suggestions. I gave each of them a try, but it doesn't look like it brings me anywhere at the moment. On 21/07/2023 02:25, Stefano Stabellini wrote: > > On Thu, 20 Jul 2023, Julien Grall wrote: > > (+ Juergen) > > > > On 19/07/2023 17:13, Andrei Ch

Fwd: UBSAN: index 1 is out of range for type 'xen_netif_rx_sring_entry [1]'

2023-07-21 Thread Bagas Sanjaya
Hi, I notice a regression report on Bugzilla [1]. Quoting from it: > Hi Kernel Team, > > I rebuild today latest version from mainline repo. > And i notice issue regarding xen-netfront.c. > > Error: > [3.477400] > =

[qemu-mainline test] 181952: tolerable FAIL - PUSHED

2023-07-21 Thread osstest service owner
flight 181952 qemu-mainline real [real] flight 181965 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181952/ http://logs.test-lab.xenproject.org/osstest/logs/181965/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-ar

Re: [PATCH] automation: avoid duplicated builds of staging branch

2023-07-21 Thread Stefano Stabellini
Hi Andrew, Oleksii, Please see below. It looks like you have configured your personal repositories to mirror upstream Xen: https://gitlab.com/xen-project/people/olkur/xen https://gitlab.com/xen-project/people/andyhhp/xen Make sure that the option "Trigger pipelines for mirror updates" is unsele

Re: [PATCH] automation: avoid duplicated builds of staging branch

2023-07-21 Thread Marek Marczykowski-Górecki
On Fri, Jul 21, 2023 at 05:49:49PM -0700, Stefano Stabellini wrote: > On Sat, 22 Jul 2023, Marek Marczykowski-Górecki wrote: > > On Fri, Jul 21, 2023 at 05:14:01PM -0700, Stefano Stabellini wrote: > > > On Sat, 22 Jul 2023, Marek Marczykowski-Górecki wrote: > > > > On Fri, Jul 21, 2023 at 04:42:11P

Re: [PATCH] automation: avoid duplicated builds of staging branch

2023-07-21 Thread Stefano Stabellini
On Sat, 22 Jul 2023, Marek Marczykowski-Górecki wrote: > On Fri, Jul 21, 2023 at 05:14:01PM -0700, Stefano Stabellini wrote: > > On Sat, 22 Jul 2023, Marek Marczykowski-Górecki wrote: > > > On Fri, Jul 21, 2023 at 04:42:11PM -0700, Stefano Stabellini wrote: > > > > On Mon, 17 Jul 2023, Marek Marczy

Re: [PATCH] automation: avoid duplicated builds of staging branch

2023-07-21 Thread Marek Marczykowski-Górecki
On Fri, Jul 21, 2023 at 05:14:01PM -0700, Stefano Stabellini wrote: > On Sat, 22 Jul 2023, Marek Marczykowski-Górecki wrote: > > On Fri, Jul 21, 2023 at 04:42:11PM -0700, Stefano Stabellini wrote: > > > On Mon, 17 Jul 2023, Marek Marczykowski-Górecki wrote: > > > > On Mon, Jul 17, 2023 at 02:14:14P

Re: [PATCH] automation: avoid duplicated builds of staging branch

2023-07-21 Thread Stefano Stabellini
On Sat, 22 Jul 2023, Marek Marczykowski-Górecki wrote: > On Fri, Jul 21, 2023 at 04:42:11PM -0700, Stefano Stabellini wrote: > > On Mon, 17 Jul 2023, Marek Marczykowski-Górecki wrote: > > > On Mon, Jul 17, 2023 at 02:14:14PM +0100, Andrew Cooper wrote: > > > > On 17/07/2023 2:09 pm, Marek Marczykow

Re: [PATCH] automation: avoid duplicated builds of staging branch

2023-07-21 Thread Marek Marczykowski-Górecki
On Fri, Jul 21, 2023 at 04:42:11PM -0700, Stefano Stabellini wrote: > On Mon, 17 Jul 2023, Marek Marczykowski-Górecki wrote: > > On Mon, Jul 17, 2023 at 02:14:14PM +0100, Andrew Cooper wrote: > > > On 17/07/2023 2:09 pm, Marek Marczykowski-Górecki wrote: > > > > "staging" branch is mirrored (automa

Re: [PATCH] automation: avoid duplicated builds of staging branch

2023-07-21 Thread Stefano Stabellini
On Mon, 17 Jul 2023, Marek Marczykowski-Górecki wrote: > On Mon, Jul 17, 2023 at 02:14:14PM +0100, Andrew Cooper wrote: > > On 17/07/2023 2:09 pm, Marek Marczykowski-Górecki wrote: > > > "staging" branch is mirrored (automatically or manually) to several > > > repositories. Avoid building it severa

Re: [PATCH 01/10] x86 setup: move x86 boot module counting into a new boot_info struct

2023-07-21 Thread Stefano Stabellini
(You might want to check your email settings because it looks like you sent an html email) On Thu, 20 Jul 2023, Christopher Clark wrote: > > +struct boot_info { > > This is what we call struct bootmodules on ARM right? Would it help if > we used the same name? > > I am no

[PATCH] xenbus: check xen_domain in xenbus_probe_initcall

2023-07-21 Thread Stefano Stabellini
The same way we already do in xenbus_init. Fixes the following warning: [ 352.175563] Trying to free already-free IRQ 0 [ 352.177355] WARNING: CPU: 1 PID: 88 at kernel/irq/manage.c:1893 free_irq+0xbf/0x350 [...] [ 352.213951] Call Trace: [ 352.214390] [ 352.214717] ? __warn+0x81/0x170 [

Re: [XEN PATCH] xen/sched: mechanical renaming to address MISRA C:2012 Rule 5.3

2023-07-21 Thread Stefano Stabellini
On Fri, 21 Jul 2023, Nicola Vetrini wrote: > Rule 5.3 has the following headline: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope" > > The renaming s/sched_id/scheduler_id of the function defined in > 'xen/common/sched/core.c' prevents any hidi

Re: [XEN PATCH] xen/spinlock: mechanically rename parameter name 'debug'

2023-07-21 Thread Stefano Stabellini
On Fri, 21 Jul 2023, Nicola Vetrini wrote: > Rule 5.3 has the following headline: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope" > > To avoid any confusion resulting from the parameter 'debug' > hiding the homonymous function declared at > 'x

Re: [XEN PATCH] efi: mechanical renaming to address MISRA C:2012 Rule 5.3

2023-07-21 Thread Stefano Stabellini
On Fri, 21 Jul 2023, Nicola Vetrini wrote: > Rule 5.3 has the following headline: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope" > > The function parameters renamed in this patch are hiding a variable defined > in an enclosing scope or a func

Re: [XEN PATCH] device_tree: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-07-21 Thread Stefano Stabellini
On Fri, 21 Jul 2023, Federico Serafini wrote: > Give a name to unnamed parameters thus addressing violations of > MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with > named parameters"). > Keep consistency between parameter names and types used in function > declarations and the

Re: [XEN PATCH] x86/cpu-policy: address violations of MISRA C:2012 Rule 8.3 on parameter names

2023-07-21 Thread Stefano Stabellini
On Fri, 21 Jul 2023, Federico Serafini wrote: > Change parameter names in function declarations to be consistent with > the ones used in the correponding definitions, thus addressing > violations of MISRA C:2012 Rule 8.3: "All declarations of an object or > function shall use the same names and typ

Re: [XEN PATCH] automation: add ECLAIR pipeline

2023-07-21 Thread Stefano Stabellini
On Fri, 21 Jul 2023, Simone Ballarin wrote: > Il giorno ven 21 lug 2023 alle ore 00:29 Stefano Stabellini > ha scritto: > > Patchew automatically picked it up from xen-devel and started a pipeline > here: > > https://gitlab.com/xen-project/patchew/xen/-/pipelines/939440592 >

[PATCH v2] docs/misra: add Rule 1.1 and 5.6

2023-07-21 Thread Stefano Stabellini
From: Stefano Stabellini Rule 1.1 is uncontroversial and we are already following it. Rule 5.6 has been deemed a good rule to have by the MISRA C group. However, we do have a significant amount of violations that will take time to resolve and might require partial deviations in the form of in-co

Re: [PATCH 03/10] x86 setup: change bootstrap map to accept new boot module structures

2023-07-21 Thread Stefano Stabellini
On Fri, 21 Jul 2023, Jan Beulich wrote: > On 21.07.2023 00:12, Christopher Clark wrote: > > On Thu, Jul 13, 2023 at 11:51 PM Christopher Clark < > > christopher.w.cl...@gmail.com> wrote: > > > >> > >> > >> On Sat, Jul 8, 2023 at 11:47 AM Stefano Stabellini > >> wrote: > >> > >>> On Sat, 1 Jul 202

Re: [ARM][xencons] PV Console hangs due to illegal ring buffer accesses

2023-07-21 Thread Stefano Stabellini
On Fri, 21 Jul 2023, Andrei Cherechesu (OSS) wrote: > > I am really confused. I would try with regular Linux instead of Linux RT > > and also would try to replace all the barriers in > > drivers/tty/hvc/hvc_xen.c with their virt_* version to see if we can > > narrow down the problem a bit. > > >

[xen-4.17-testing test] 181945: tolerable FAIL - PUSHED

2023-07-21 Thread osstest service owner
flight 181945 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/181945/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 181861 test-amd64-i386-xl-qemut-win7-am

[libvirt test] 181943: tolerable FAIL - PUSHED

2023-07-21 Thread osstest service owner
flight 181943 libvirt real [real] flight 181964 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181943/ http://logs.test-lab.xenproject.org/osstest/logs/181964/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-li

Re: [PATCH 2/8] arm/mm: Document the differences between arm32 and arm64 directmaps

2023-07-21 Thread Julien Grall
Hi Alejandro, On 21/07/2023 16:09, Alejandro Vallejo wrote: On Thu, Jul 20, 2023 at 09:05:55PM +0100, Julien Grall wrote: Hi Alejandro, On 17/07/2023 17:03, Alejandro Vallejo wrote: arm32 merely covers the XENHEAP, whereas arm64 currently covers anything in the frame table. These comments hig

Re: [PATCH] xen: privcmd: Add support for irqfd

2023-07-21 Thread Oleksandr Tyshchenko
On 20.07.23 12:41, Viresh Kumar wrote: Hello Viresh > On 13-07-23, 14:40, Oleksandr Tyshchenko wrote: >> Viresh, great work! > > Thanks Oleksandr. > >> Do you perhaps have corresponding users-space (virtio backend) example >> adopted for that feature (I would like to take a look at it if poss

Re: [PATCH 6/8] mm/pdx: Standardize region validation wrt pdx compression

2023-07-21 Thread Julien Grall
Hi Alejandro, On 17/07/2023 17:03, Alejandro Vallejo wrote: Regions must be occasionally validated for pdx compression validity. That is, whether any of the machine addresses spanning the region have a bit set in the pdx "hole" (which is expected to always contain zeroes). There are a few such t

[PATCH v5 0/4] Early serial on Power

2023-07-21 Thread Shawn Anastasio
Hello all, This series adds support for early serial printing on Power, as well as a simple CI smoke test modeled after the riscv one. The first patch is responsible for setting up a basic C environment with an initial stack while the second sets up an Open Firmware serial console and primitive e

[PATCH v5 3/4] xen/ppc: Implement early serial printk on pseries

2023-07-21 Thread Shawn Anastasio
On typical Power VMs (e.g. QEMU's -M pseries), a variety of services including an early serial console are provided by Open Firmware. Implement the required interfaces to call into Open Firmware and write to the serial console. Since Open Firmware runs in 32-bit Big Endian mode and Xen runs in 64-

[PATCH v5 1/4] common: Move a few more standalone macros from xen/lib.h to xen/macros.h

2023-07-21 Thread Shawn Anastasio
Move a few more macros which have no dependencies on other headers from xen/lib.h to xen/macros.h. Notably, this includes BUILD_BUG_ON* and ARRAY_SIZE. Signed-off-by: Shawn Anastasio Reviewed-by: Jan Beulich --- xen/include/xen/lib.h| 28 xen/include/xen/macros.

[PATCH v5 4/4] automation: Add smoke test for ppc64le

2023-07-21 Thread Shawn Anastasio
Add an initial smoke test that boots xen on a ppc64/pseries machine and checks for a magic string. Based on the riscv smoke test. Eventually the powernv9 (POWER9 bare metal) machine type will want to be tested as well, but for now we only boot on pseries. Signed-off-by: Shawn Anastasio Reviewed-

[PATCH v5 2/4] xen/ppc: Set up a basic C environment

2023-07-21 Thread Shawn Anastasio
Update ppc64/head.S to set up an initial boot stack, zero the .bss section, and jump to C. The required setup is done using 32-bit immediate address loads for now, but they will be changed to TOC-relative loads once the position-independent code model is enabled. Additionally, move the cpu0_boot_s

Re: [PATCH v4 3/4] xen/ppc: Implement early serial printk on pseries

2023-07-21 Thread Shawn Anastasio
On 7/19/23 9:05 AM, Jan Beulich wrote: > On 18.07.2023 22:20, Shawn Anastasio wrote: >> +void __init boot_of_init(unsigned long vec) >> +{ >> +int bof_chosen; >> + >> +of_vec = vec; >> + >> +/* Get a handle to the default console */ >> +bof_chosen = of_finddevice("/chosen"); >> +

Re: [OSSTEST] ts-kernel-build: add kernel kconfig for the Arndale

2023-07-21 Thread Luca Fancellu
> On 21 Jul 2023, at 14:24, Jan Beulich wrote: > > On 21.07.2023 14:16, Luca Fancellu wrote: >> The Linux commit 33629d35090f5ce2b1b4ce78aa39954c603536d5 has >> removed the 'snps,dwc-ahci' compatible from the generic >> AHCI-platform driver control module selected by >> CONFIG_SATA_AHCI_PLATFOR

Re: [XEN PATCH] atomic: change parameter name in atomic_cmpxchg() definition

2023-07-21 Thread Julien Grall
On 21/07/2023 17:15, Federico Serafini wrote: Hello Julien, Hi, On 21/07/23 17:44, Julien Grall wrote:> Title: Please add "xen/arm: " to clarify this is a patch touching the Arm code. Ok. On 21/07/2023 16:37, Federico Serafini wrote: Change parameter name from 'ptr' to 'v' in the funct

Re: [XEN PATCH] atomic: change parameter name in atomic_cmpxchg() definition

2023-07-21 Thread Federico Serafini
Hello Julien, On 21/07/23 17:44, Julien Grall wrote:> Title: Please add "xen/arm: " to clarify this is a patch touching the Arm code. Ok. On 21/07/2023 16:37, Federico Serafini wrote: Change parameter name from 'ptr' to 'v' in the function definition thus addressing violations of MISRA C:2

Re: [PATCH 5/8] mm: Factor out the pdx compression logic in ma/va converters

2023-07-21 Thread Julien Grall
Hi Alejandro, On 17/07/2023 17:03, Alejandro Vallejo wrote: This patch factors out the pdx compression logic hardcoded in both ports for the maddr<->vaddr conversion functions. Touches both x86 and arm ports. Signed-off-by: Alejandro Vallejo --- xen/arch/arm/include/asm/mm.h | 3 +

Re: [XEN PATCH] xen/arm: mechanical renaming to address MISRA C:2012 Rule 5.3

2023-07-21 Thread Julien Grall
Hi, On 21/07/2023 16:22, Nicola Vetrini wrote: Rule 5.3 has the following headline: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" The function parameters renamed in this patch are hiding a variable defined in an enclosing scope or a function

Re: [XEN PATCH] atomic: change parameter name in atomic_cmpxchg() definition

2023-07-21 Thread Julien Grall
Hi, Title: Please add "xen/arm: " to clarify this is a patch touching the Arm code. On 21/07/2023 16:37, Federico Serafini wrote: Change parameter name from 'ptr' to 'v' in the function definition thus addressing violations of MISRA C:2012 Rule 8.3: "All declarations of an object or function s

[XEN PATCH] atomic: change parameter name in atomic_cmpxchg() definition

2023-07-21 Thread Federico Serafini
Change parameter name from 'ptr' to 'v' in the function definition thus addressing violations of MISRA C:2012 Rule 8.3: "All declarations of an object or function shall use the same names and type qualifiers". No functional changes. Signed-off-by: Federico Serafini --- xen/arch/arm/include/asm/

[XEN PATCH] xen/sched: mechanical renaming to address MISRA C:2012 Rule 5.3

2023-07-21 Thread Nicola Vetrini
Rule 5.3 has the following headline: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" The renaming s/sched_id/scheduler_id of the function defined in 'xen/common/sched/core.c' prevents any hiding of that function by the many instances of omonymous

[XEN PATCH] xen/spinlock: mechanically rename parameter name 'debug'

2023-07-21 Thread Nicola Vetrini
Rule 5.3 has the following headline: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" To avoid any confusion resulting from the parameter 'debug' hiding the homonymous function declared at 'xen/arch/x86/include/asm/processor.h:428' the rename of pa

[XEN PATCH] efi: mechanical renaming to address MISRA C:2012 Rule 5.3

2023-07-21 Thread Nicola Vetrini
Rule 5.3 has the following headline: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" The function parameters renamed in this patch are hiding a variable defined in an enclosing scope or a function identifier. The following rename is made: - s/cfg

[XEN PATCH] xen/arm: mechanical renaming to address MISRA C:2012 Rule 5.3

2023-07-21 Thread Nicola Vetrini
Rule 5.3 has the following headline: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" The function parameters renamed in this patch are hiding a variable defined in an enclosing scope or a function identifier. The following renames have been made:

Re: [XEN PATCH] automation: add ECLAIR pipeline

2023-07-21 Thread Simone Ballarin
Il giorno ven 21 lug 2023 alle ore 00:29 Stefano Stabellini < sstabell...@kernel.org> ha scritto: > > Patchew automatically picked it up from xen-devel and started a pipeline > here: > > https://gitlab.com/xen-project/patchew/xen/-/pipelines/939440592 > > However the eclair-x86_64 job failed with:

Re: [PATCH 2/8] arm/mm: Document the differences between arm32 and arm64 directmaps

2023-07-21 Thread Alejandro Vallejo
Hi Julian, On Thu, Jul 20, 2023 at 09:05:55PM +0100, Julien Grall wrote: > Hi Alejandro, > > On 17/07/2023 17:03, Alejandro Vallejo wrote: > > arm32 merely covers the XENHEAP, whereas arm64 currently covers anything in > > the frame table. These comments highlight why arm32 doesn't need to accoun

Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Bertrand Marquis
Hi Jan, > On 21 Jul 2023, at 16:24, Jan Beulich wrote: > > On 21.07.2023 16:07, Bertrand Marquis wrote: >>> On 21 Jul 2023, at 15:08, Jan Beulich wrote: >>> On 21.07.2023 14:27, Bertrand Marquis wrote: So what should i keep or remove here ? >>> >>> My understanding so far was that "visibi

[XEN PATCH] device_tree: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-07-21 Thread Federico Serafini
Give a name to unnamed parameters thus addressing violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Keep consistency between parameter names and types used in function declarations and the ones used in the corresponding function definitions, th

Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Jan Beulich
On 21.07.2023 16:07, Bertrand Marquis wrote: >> On 21 Jul 2023, at 15:08, Jan Beulich wrote: >> On 21.07.2023 14:27, Bertrand Marquis wrote: >>> So what should i keep or remove here ? >> >> My understanding so far was that "visibility" merely hides all prompts >> underneath (but then I use the com

[xen-unstable-smoke test] 181956: tolerable all pass - PUSHED

2023-07-21 Thread osstest service owner
flight 181956 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181956/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v8 12/13] xen/arm: translate virtual PCI bus topology for guests

2023-07-21 Thread Roger Pau Monné
On Thu, Jul 20, 2023 at 12:32:34AM +, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > There are three originators for the PCI configuration space access: > 1. The domain that owns physical host bridge: MMIO handlers are > there so we can update vPCI register handlers with the va

Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Bertrand Marquis
Hi Jan, > On 21 Jul 2023, at 15:08, Jan Beulich wrote: > > On 21.07.2023 14:27, Bertrand Marquis wrote: >> Hi Jan, >> >>> On 21 Jul 2023, at 12:45, Jan Beulich wrote: >>> >>> On 21.07.2023 11:02, Bertrand Marquis wrote: > On 21 Jul 2023, at 10:52, Jan Beulich wrote: > On 21.07.2023 1

Re: [PATCH v8 11/13] vpci: add initial support for virtual PCI bus topology

2023-07-21 Thread Roger Pau Monné
On Thu, Jul 20, 2023 at 12:32:33AM +, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > Assign SBDF to the PCI devices being passed through with bus 0. > The resulting topology is where PCIe devices reside on the bus 0 of the > root complex itself (embedded endpoints). > This imple

Re: [PATCH v8 11/13] vpci: add initial support for virtual PCI bus topology

2023-07-21 Thread Roger Pau Monné
On Thu, Jul 20, 2023 at 12:32:33AM +, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > index 80dd150bbf..478bd21f3e 100644 > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -461,6 +461,14 @@ struct do

Re: [PATCH v8 09/13] vpci/header: emulate PCI_COMMAND register for guests

2023-07-21 Thread Roger Pau Monné
On Fri, Jul 21, 2023 at 03:32:27PM +0200, Roger Pau Monné wrote: > On Thu, Jul 20, 2023 at 12:32:33AM +, Volodymyr Babchuk wrote: > > From: Oleksandr Andrushchenko > > +/* > > + * According to "PCI LOCAL BUS SPECIFICATION, REV. 3.0", section "6.2.2 > > + * Device Control" the reset

[linux-linus test] 181934: regressions - FAIL

2023-07-21 Thread osstest service owner
flight 181934 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181934/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail REGR. vs. 180278 test-amd64-amd64

Re: [PATCH v8 10/13] vpci/header: reset the command register when adding devices

2023-07-21 Thread Roger Pau Monné
On Thu, Jul 20, 2023 at 12:32:33AM +, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > Reset the command register when assigning a PCI device to a guest: > according to the PCI spec the PCI_COMMAND register is typically all 0's > after reset, but this might not be true for the gue

Re: [PATCH v8 09/13] vpci/header: emulate PCI_COMMAND register for guests

2023-07-21 Thread Roger Pau Monné
On Thu, Jul 20, 2023 at 12:32:33AM +, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > Xen and/or Dom0 may have put values in PCI_COMMAND which they expect > to remain unaltered. PCI_COMMAND_SERR bit is a good example: while the > guest's view of this will want to be zero initiall

Re: [OSSTEST] ts-kernel-build: add kernel kconfig for the Arndale

2023-07-21 Thread Jan Beulich
On 21.07.2023 14:16, Luca Fancellu wrote: > The Linux commit 33629d35090f5ce2b1b4ce78aa39954c603536d5 has > removed the 'snps,dwc-ahci' compatible from the generic > AHCI-platform driver control module selected by > CONFIG_SATA_AHCI_PLATFORM. > > A new driver, the DWC AHCI SATA platform driver is

Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Jan Beulich
On 21.07.2023 14:27, Bertrand Marquis wrote: > Hi Jan, > >> On 21 Jul 2023, at 12:45, Jan Beulich wrote: >> >> On 21.07.2023 11:02, Bertrand Marquis wrote: On 21 Jul 2023, at 10:52, Jan Beulich wrote: On 21.07.2023 10:02, Bertrand Marquis wrote: > --- a/xen/arch/arm/tee/Kconfig >>>

Re: [PATCH v8 08/13] vpci/header: program p2m with guest BAR view

2023-07-21 Thread Roger Pau Monné
On Thu, Jul 20, 2023 at 12:32:33AM +, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > Take into account guest's BAR view and program its p2m accordingly: > gfn is guest's view of the BAR and mfn is the physical BAR value as set > up by the PCI bus driver in the hardware domain.

Re: [PATCH v2] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Bertrand Marquis
Hi Julien, > On 21 Jul 2023, at 14:44, Julien Grall wrote: > > Hi, > > On 21/07/2023 13:28, Bertrand Marquis wrote: >>> On 21 Jul 2023, at 12:00, Julien Grall wrote: >>> >>> Hi Bertrand, >>> >>> On 21/07/2023 10:23, Bertrand Marquis wrote: Rework TEE mediators to put them under a submen

Re: [PATCH LINUX v5 2/2] xen: add support for initializing xenstore later as HVM domain

2023-07-21 Thread Petr Mladek
On Thu 2023-07-20 16:31:16, Stefano Stabellini wrote: > On Thu, 20 Jul 2023, Petr Mladek wrote: > > On Wed 2023-07-19 18:46:08, Stefano Stabellini wrote: > > > On Wed, 19 Jul 2023, Petr Mladek wrote: > > > > I see the following warning from free_irq() in 6.5-rc2 when running > > > > livepatching se

Re: [PATCH v2] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Julien Grall
Hi, On 21/07/2023 13:28, Bertrand Marquis wrote: On 21 Jul 2023, at 12:00, Julien Grall wrote: Hi Bertrand, On 21/07/2023 10:23, Bertrand Marquis wrote: Rework TEE mediators to put them under a submenu in Kconfig. The submenu is only visible if UNSUPPORTED is activated as all currently exist

Re: [OSSTEST] ts-kernel-build: add kernel kconfig for the Arndale

2023-07-21 Thread Roger Pau Monné
On Fri, Jul 21, 2023 at 01:16:27PM +0100, Luca Fancellu wrote: > The Linux commit 33629d35090f5ce2b1b4ce78aa39954c603536d5 has > removed the 'snps,dwc-ahci' compatible from the generic > AHCI-platform driver control module selected by > CONFIG_SATA_AHCI_PLATFORM. > > A new driver, the DWC AHCI SAT

Re: [PATCH v2] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Bertrand Marquis
Hi, > On 21 Jul 2023, at 12:00, Julien Grall wrote: > > Hi Bertrand, > > On 21/07/2023 10:23, Bertrand Marquis wrote: >> Rework TEE mediators to put them under a submenu in Kconfig. >> The submenu is only visible if UNSUPPORTED is activated as all currently >> existing mediators are UNSUPPORTED

Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Bertrand Marquis
Hi Jan, > On 21 Jul 2023, at 12:45, Jan Beulich wrote: > > On 21.07.2023 11:02, Bertrand Marquis wrote: >>> On 21 Jul 2023, at 10:52, Jan Beulich wrote: >>> On 21.07.2023 10:02, Bertrand Marquis wrote: --- a/xen/arch/arm/tee/Kconfig +++ b/xen/arch/arm/tee/Kconfig @@ -1,7 +1,17 @@

[OSSTEST] ts-kernel-build: add kernel kconfig for the Arndale

2023-07-21 Thread Luca Fancellu
The Linux commit 33629d35090f5ce2b1b4ce78aa39954c603536d5 has removed the 'snps,dwc-ahci' compatible from the generic AHCI-platform driver control module selected by CONFIG_SATA_AHCI_PLATFORM. A new driver, the DWC AHCI SATA platform driver is now implemented and handles the above compatible when

Re: [PATCH v8 05/13] vpci/header: implement guest BAR register handlers

2023-07-21 Thread Roger Pau Monné
On Fri, Jul 21, 2023 at 12:50:23PM +0200, Jan Beulich wrote: > On 21.07.2023 12:36, Rahul Singh wrote: > >> On 20 Jul 2023, at 1:32 am, Volodymyr Babchuk > >> wrote: > >> @@ -599,34 +681,50 @@ static int cf_check init_bars(struct pci_dev *pdev) > >> bars[i].size = size; > >> bars[

Re: [PATCH v8 07/13] vpci/header: handle p2m range sets per BAR

2023-07-21 Thread Roger Pau Monné
On Thu, Jul 20, 2023 at 12:32:32AM +, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > Instead of handling a single range set, that contains all the memory > regions of all the BARs and ROM, have them per BAR. > As the range sets are now created when a PCI device is added and dest

Re: [PATCH v8 05/13] vpci/header: implement guest BAR register handlers

2023-07-21 Thread Jan Beulich
On 21.07.2023 12:36, Rahul Singh wrote: >> On 20 Jul 2023, at 1:32 am, Volodymyr Babchuk >> wrote: >> @@ -599,34 +681,50 @@ static int cf_check init_bars(struct pci_dev *pdev) >> bars[i].size = size; >> bars[i].prefetchable = val & PCI_BASE_ADDRESS_MEM_PREFETCH; > > I think there

Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Jan Beulich
On 21.07.2023 11:02, Bertrand Marquis wrote: >> On 21 Jul 2023, at 10:52, Jan Beulich wrote: >> On 21.07.2023 10:02, Bertrand Marquis wrote: >>> --- a/xen/arch/arm/tee/Kconfig >>> +++ b/xen/arch/arm/tee/Kconfig >>> @@ -1,7 +1,17 @@ >>> +menu "TEE mediators" >>> + visible if UNSUPPORTED >> >> With

[xen-unstable-smoke test] 181948: regressions - FAIL

2023-07-21 Thread osstest service owner
flight 181948 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181948/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181941 Tests which

[xen-unstable test] 181927: tolerable FAIL - PUSHED

2023-07-21 Thread osstest service owner
flight 181927 xen-unstable real [real] flight 181950 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181927/ http://logs.test-lab.xenproject.org/osstest/logs/181950/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: [PATCH v8 05/13] vpci/header: implement guest BAR register handlers

2023-07-21 Thread Rahul Singh
Hi Volodymyr, > On 20 Jul 2023, at 1:32 am, Volodymyr Babchuk > wrote: > > From: Oleksandr Andrushchenko > > Add relevant vpci register handlers when assigning PCI device to a domain > and remove those when de-assigning. This allows having different > handlers for different domains, e.g. hwdo

Re: [PATCH] drm: Explicitly include correct DT includes

2023-07-21 Thread Thierry Reding
On Fri, Jul 14, 2023 at 11:45:34AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each oth

Re: [XEN PATCH] xen/arm: optee: provide an initialization for struct arm_smccc_res

2023-07-21 Thread Julien Grall
Hi, On 21/07/2023 08:28, Nicola Vetrini wrote: On 20/07/23 17:54, Julien Grall wrote: Hi Nicola, On 20/07/2023 15:29, Nicola Vetrini wrote: The local variables with type 'struct arm_smccc_res' are initialized just after the declaration to avoid any possible read usage prior to any write usage

Re: [XEN PATCH] xen/arm: p2m: refactor 'p2m_get_entry'

2023-07-21 Thread Julien Grall
Hi Nicola, I would add "to please ECLAIR" in the commit title. On 21/07/2023 07:49, Nicola Vetrini wrote: This function is refactored to avoid using a local dummy variable that served as a fallback if the parameter 't' is NULL. Storing the address of that variable into 't' caused static analys

Re: [PATCH v2] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Julien Grall
Hi Bertrand, On 21/07/2023 10:23, Bertrand Marquis wrote: Rework TEE mediators to put them under a submenu in Kconfig. The submenu is only visible if UNSUPPORTED is activated as all currently existing mediators are UNSUPPORTED. While there rework a bit the configuration so that OP-TEE and FF-A

[PATCH v2] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Bertrand Marquis
Rework TEE mediators to put them under a submenu in Kconfig. The submenu is only visible if UNSUPPORTED is activated as all currently existing mediators are UNSUPPORTED. While there rework a bit the configuration so that OP-TEE and FF-A mediators are selecting the generic TEE interface instead of

Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Julien Grall
Hi Bertrand, On 21/07/2023 10:07, Bertrand Marquis wrote: On 21 Jul 2023, at 10:52, Julien Grall wrote: + config OPTEE - bool "Enable OP-TEE mediator" + bool "Enable OP-TEE mediator (UNSUPPORTED)" if UNSUPPORTED Given this is under 'TEE mediators', do we still need the 'if UNSUPPORTED'?

Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Bertrand Marquis
Hi Julien, > On 21 Jul 2023, at 10:52, Julien Grall wrote: > > Hi Bertrand, > > On 21/07/2023 09:02, Bertrand Marquis wrote: >> Rework TEE mediators to put them under a submenu in Kconfig. >> The submenu is only visible if UNSUPPORTED is activated as all currently >> existing mediators are UNSU

[XEN PATCH] x86/cpu-policy: address violations of MISRA C:2012 Rule 8.3 on parameter names

2023-07-21 Thread Federico Serafini
Change parameter names in function declarations to be consistent with the ones used in the correponding definitions, thus addressing violations of MISRA C:2012 Rule 8.3: "All declarations of an object or function shall use the same names and type qualifiers". No functional changes. Signed-off-by:

Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Bertrand Marquis
Hi Jan, > On 21 Jul 2023, at 10:52, Jan Beulich wrote: > > On 21.07.2023 10:02, Bertrand Marquis wrote: >> --- a/xen/arch/arm/tee/Kconfig >> +++ b/xen/arch/arm/tee/Kconfig >> @@ -1,7 +1,17 @@ >> +menu "TEE mediators" >> + visible if UNSUPPORTED > > With this ... > >> +config TEE >> + bool >> +

Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Jan Beulich
On 21.07.2023 10:02, Bertrand Marquis wrote: > --- a/xen/arch/arm/tee/Kconfig > +++ b/xen/arch/arm/tee/Kconfig > @@ -1,7 +1,17 @@ > +menu "TEE mediators" > + visible if UNSUPPORTED With this ... > +config TEE > + bool > + default n > + help > + This option enables generic TE

Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Julien Grall
Hi Bertrand, On 21/07/2023 09:02, Bertrand Marquis wrote: Rework TEE mediators to put them under a submenu in Kconfig. The submenu is only visible if UNSUPPORTED is activated as all currently existing mediators are UNSUPPORTED. While there rework a bit the configuration so that OP-TEE and FF-A

Re: [PATCH v8 02/13] vpci: use per-domain PCI lock to protect vpci structure

2023-07-21 Thread Jan Beulich
On 21.07.2023 09:43, Roger Pau Monné wrote: > On Fri, Jul 21, 2023 at 08:02:33AM +0200, Jan Beulich wrote: >> On 20.07.2023 18:14, Roger Pau Monné wrote: >>> Strictly speaking however the init >>> handlers don't require the lock in write mode unless we use such >>> locking to get exclusive access

Re: [PATCH v2 3/3] [FUTURE] xen/arm: enable vPCI for domUs

2023-07-21 Thread Rahul Singh
Hi Stewart, > On 21 Jul 2023, at 5:54 am, Stewart Hildebrand > wrote: > > On 7/7/23 07:04, Rahul Singh wrote: >> Hi Stewart, >> >>> On 7 Jul 2023, at 2:47 am, Stewart Hildebrand >>> wrote: >>> >>> Remove is_hardware_domain check in has_vpci, and select >>> HAS_VPCI_GUEST_SUPPORT >>> in Kco

Re: [ARM][xencons] PV Console hangs due to illegal ring buffer accesses

2023-07-21 Thread Andrei Cherechesu (OSS)
Hello, Julien, Stefano, Thank you for your replies. On 21/07/2023 02:25, Stefano Stabellini wrote: > > On Thu, 20 Jul 2023, Julien Grall wrote: >> (+ Juergen) >> >> On 19/07/2023 17:13, Andrei Cherechesu (OSS) wrote: >>> Hello, >> >> Hi Andrei, >> >>> As we're running Xen 4.17 (with platform-rel

Re: [PATCH V4] libxl: arm: Add grant_usage parameter for virtio devices

2023-07-21 Thread George Dunlap
On Thu, Jul 6, 2023 at 8:29 AM Viresh Kumar wrote: > Currently, the grant mapping related device tree properties are added if > the backend domain is not Dom0. While Dom0 is privileged and can do > foreign mapping for the entire guest memory, it is still desired for > Dom0 to access guest's memor

[PATCH] xen/arm: Move TEE mediators in a kconfig submenu

2023-07-21 Thread Bertrand Marquis
Rework TEE mediators to put them under a submenu in Kconfig. The submenu is only visible if UNSUPPORTED is activated as all currently existing mediators are UNSUPPORTED. While there rework a bit the configuration so that OP-TEE and FF-A mediators are selecting the generic TEE interface instead of

[ovmf test] 181944: all pass - PUSHED

2023-07-21 Thread osstest service owner
flight 181944 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181944/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 925c445fd37bf529ca78f9d6c416cca37c7e6da5 baseline version: ovmf c6b512962e92ae54a895b

Re: [PATCH v8 02/13] vpci: use per-domain PCI lock to protect vpci structure

2023-07-21 Thread Roger Pau Monné
On Fri, Jul 21, 2023 at 08:02:33AM +0200, Jan Beulich wrote: > On 20.07.2023 18:14, Roger Pau Monné wrote: > > Strictly speaking however the init > > handlers don't require the lock in write mode unless we use such > > locking to get exclusive access to all the devices assigned to the > > domain B

Re: [XEN PATCH] xen/arm: optee: provide an initialization for struct arm_smccc_res

2023-07-21 Thread Nicola Vetrini
On 20/07/23 17:54, Julien Grall wrote: Hi Nicola, On 20/07/2023 15:29, Nicola Vetrini wrote: The local variables with type 'struct arm_smccc_res' are initialized just after the declaration to avoid any possible read usage prior to any write usage, which would constitute a violation of MISRA

Re: [XEN PATCH v10 04/24] xen/arm: tee: add a primitive FF-A mediator

2023-07-21 Thread Bertrand Marquis
Hi Julien, > On 21 Jul 2023, at 00:29, Julien Grall wrote: > > Hi Bertrand, > > On 20/07/2023 11:20, Bertrand Marquis wrote: >> Hi Jens, >>> On 17 Jul 2023, at 09:20, Jens Wiklander wrote: >>> >>> Adds a FF-A version 1.1 [1] mediator to communicate with a Secure >>> Partition in secure world.