[xen-4.17-testing test] 182095: tolerable FAIL - PUSHED

2023-08-01 Thread osstest service owner
flight 182095 xen-4.17-testing real [real] flight 182109 xen-4.17-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182095/ http://logs.test-lab.xenproject.org/osstest/logs/182109/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [PATCH v2] arm32: Avoid using solaris syntax for .section directive

2023-08-01 Thread Michal Orzel
Hi, On 01/08/2023 19:49, Khem Raj wrote: > > > Assembler from binutils 2.41 rejects [1] this syntax > > .section "name"[, flags...] > > where flags could be #alloc, #write, #execinstr, #exclude, and #tls [2] > > It is almost like a regression compared to 2.40 or older release, > It likely wen

RE: [PATCH 2/2] fdt: make fdt handling reusable across arch

2023-08-01 Thread Henry Wang
Hi Daniel, > -Original Message- > Subject: [PATCH 2/2] fdt: make fdt handling reusable across arch > > This refactors reusable code from Arm's bootfdt.c and device-tree.h that is > general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is > introduced for when the ability of p

Re: [PATCH v3 21/25] tools/xenstore: introduce read_node_nocopy()

2023-08-01 Thread Juergen Gross
On 02.08.23 00:00, Julien Grall wrote: Hi Juergen, Title: I can't find read_node_nocopy(). I found a read_node_const(). Which name did you intend to use? Oh, sorry for that. I think read_node_const() is the better choice. On 24/07/2023 12:02, Juergen Gross wrote: +static int read_node_hel

Re: [PATCH v3 20/25] tools/xenstore: alloc new memory in domain_adjust_node_perms()

2023-08-01 Thread Juergen Gross
On 01.08.23 23:46, Julien Grall wrote: Hi Juergen, On 24/07/2023 12:02, Juergen Gross wrote: In order to avoid modifying the node data in the data base in case a domain is gone, let domain_adjust_node_perms() allocate new memory for the permissions in case they need to be modified. As this shou

Re: [PATCH v3 19/25] tools/xenstore: use struct node_hdr in struct node

2023-08-01 Thread Juergen Gross
On 01.08.23 23:34, Julien Grall wrote: Hi Juergen, On 24/07/2023 12:02, Juergen Gross wrote: diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index c72fc0c725..404ecd0c62 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -555,6 +

Re: [PATCH v3 18/25] tools/xenstore: don't use struct node_perms in struct node

2023-08-01 Thread Juergen Gross
On 01.08.23 23:29, Julien Grall wrote: Hi Juergen, On 24/07/2023 12:02, Juergen Gross wrote: Open code struct node_perms in struct node in order to prepare using struct node_hdr in struct node. Add two helpers to transfer permissions between struct node and struct node_perms. Signed-off-by: J

RE: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of MPU work

2023-08-01 Thread Henry Wang
Hi Julien, Thanks for your prompt response and your time on the review! > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of > MPU work > > Hi, > > On 01/08/2023 04:44, Henry Wang wrote: > > Based on the discussion in th

[xen-4.16-testing test] 182094: tolerable FAIL - PUSHED

2023-08-01 Thread osstest service owner
flight 182094 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/182094/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 181998 test-amd64-amd64-xl-qemut-win7-a

Re: [RFC 6/6] capabilities: convert attach debugger into a capability

2023-08-01 Thread Stefano Stabellini
On Tue, 1 Aug 2023, Daniel P. Smith wrote: > Expresses the ability to attach a debugger as a capability that a domain can > be > provisioned. > > Signed-off-by: Daniel P. Smith > --- > xen/arch/x86/hvm/svm/svm.c | 8 > xen/arch/x86/hvm/vmx/realmode.c | 2 +- > xen/arch/x86/hvm/v

Re: [RFC 4/6] capabilities: introduce console io as a domain capability

2023-08-01 Thread Stefano Stabellini
On Tue, 1 Aug 2023, Daniel P. Smith wrote: > The field `is_console` suggests that the field represents a state of being or > posession, not that it reflects the privilege to access the console. In this ^ possession > patch the field is renamed to capabilities to encapsulate the capabilities a >

Re: [RFC 3/6] roles: add a role for xenstore domain

2023-08-01 Thread Stefano Stabellini
On Tue, 1 Aug 2023, Daniel P. Smith wrote: > Expand the possible roles for a domain to include a role for the Xenstore > domain. > > Signed-off-by: Daniel P. Smith Reviewed-by: Stefano Stabellini > --- > xen/common/domain.c | 3 +++ > xen/include/xen/sched.h | 3 ++- > 2 files changed, 5

[xen-4.15-testing test] 182093: tolerable FAIL - PUSHED

2023-08-01 Thread osstest service owner
flight 182093 xen-4.15-testing real [real] flight 182105 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182093/ http://logs.test-lab.xenproject.org/osstest/logs/182105/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [RFC 2/6] roles: provide abstraction for the possible domain roles

2023-08-01 Thread Stefano Stabellini
On Tue, 1 Aug 2023, Daniel P. Smith wrote: > The existing concepts such as unbounded domain, ie. all powerful, control > domain and hardware domain are, effectively, roles the domains provide for the > system. Currently, these are represented with booleans within `struct domain` > or global domid v

Re: [RFC 1/6] dom0: replace explict zero checks

2023-08-01 Thread Stefano Stabellini
On Tue, 1 Aug 2023, Daniel P. Smith wrote: > A legacy concept is that the initial domain will have a domain id of zero. As > a > result there are places where a check that a domain is the inital domain is > determined by an explicit check that the domid is zero. > > This commit seeks to abstract

Re: [PATCH 0/4] xen/ppc: Add PowerNV bare metal support

2023-08-01 Thread Shawn Anastasio
On 8/1/23 7:11 PM, Shawn Anastasio wrote: > Hello all, Apologies, the subject should indicate that this is a v2 but I forgot to pass the appropriate argument to git-send-email. Thanks, Shawn

[PATCH 1/4] xen/ppc: Switch to medium PIC code model

2023-08-01 Thread Shawn Anastasio
Switch Xen to the medium PIC code model on Power. Among other things, this allows us to be load address agnostic and will open the door to booting on bare metal PowerNV systems that don't use OpenFirmware. Also update XEN_VIRT_START to 0xc000, which is equivalent to address 0x0 when th

[PATCH 2/4] xen/ppc: Add OPAL API definition header file

2023-08-01 Thread Shawn Anastasio
OPAL (OpenPower Abstraction Layer) is the interface exposed by firmware on PowerNV (bare metal) systems. Import Linux's header definining the API and related information. >From Linux commit 5321d1b1afb9a17302c6cec79f0cbf823eb0d3fc Signed-off-by: Shawn Anastasio --- Changed in v2: - Add Linux c

[PATCH 4/4] xen/ppc: Implement early serial console on PowerNV

2023-08-01 Thread Shawn Anastasio
Implement the OPAL firmware calls required to write to the serial console on PowerNV systems. Unlike pseries/Open Firmware, the OPAL firmware interface can be used past early boot and as such the relevant functions are not marked as __init. Signed-off-by: Shawn Anastasio --- Changed in v2: - In

[PATCH 0/4] xen/ppc: Add PowerNV bare metal support

2023-08-01 Thread Shawn Anastasio
Hello all, This series adds support for booting and using the serial console on bare metal PowerNV/OpenPOWER systems. Up until now, Xen could only be booted on the QEMU pseries model, which was initially targetted for ease of development, but which differs significantly from the bare metal systems

[PATCH 3/4] xen/ppc: Parse device tree for OPAL node on PowerNV

2023-08-01 Thread Shawn Anastasio
Communication with firmware boot services on PowerNV requires parsing the fdt blob passed by the bootloader in order to obtain the firmware entrypoint. Use Xen's libfdt to do this and store the information required for firmware calls, to be implemented in a future patch. The full xen/common build

Re: [XEN PATCH 3/4] automation/eclair: add scheduled pipelines

2023-08-01 Thread Stefano Stabellini
On Wed, 2 Aug 2023, Marek Marczykowski-Górecki wrote: > On Tue, Aug 01, 2023 at 03:55:20PM -0700, Stefano Stabellini wrote: > > On Tue, 1 Aug 2023, Simone Ballarin wrote: > > > This patch introduces six new ECLAIR jobs that run only > > > when triggered by a GitLab scheduled pipeline. > > > > > >

Re: [XEN PATCH 3/4] automation/eclair: add scheduled pipelines

2023-08-01 Thread Marek Marczykowski-Górecki
On Tue, Aug 01, 2023 at 03:55:20PM -0700, Stefano Stabellini wrote: > On Tue, 1 Aug 2023, Simone Ballarin wrote: > > This patch introduces six new ECLAIR jobs that run only > > when triggered by a GitLab scheduled pipeline. > > > > Signed-off-by: Simone Ballarin > > --- > > +.eclair-analysis:on-s

RE: [PATCH RESEND v9 33/36] KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling

2023-08-01 Thread Li, Xin3
> > +#include "../../entry/calling.h" > > Rather than do the low level PUSH_REGS and POP_REGS, I vote to have core code > expose a FRED-specific wrapper for invoking external_interrupt(). More below. Nice idea! > > + /* > > +* A FRED stack frame has extra 16 bytes of information pushed

Re: [XEN PATCH 4/4] automation/eclair: avoid failure in case of missing merge point

2023-08-01 Thread Stefano Stabellini
On Tue, 1 Aug 2023, Simone Ballarin wrote: > In the context of an auto pull request, when a common merge point > is not found the integration will continue the analysis without > failing. > > Signed-off-by: Simone Ballarin Acked-by: Stefano Stabellini > --- > automation/eclair_analysis/ECLAI

Re: [XEN PATCH 3/4] automation/eclair: add scheduled pipelines

2023-08-01 Thread Stefano Stabellini
On Tue, 1 Aug 2023, Simone Ballarin wrote: > This patch introduces six new ECLAIR jobs that run only > when triggered by a GitLab scheduled pipeline. > > Signed-off-by: Simone Ballarin > --- > .../eclair_analysis/ECLAIR/action.settings| 2 +- > automation/gitlab-ci/analyze.yaml

Re: [XEN PATCH 2/4] automation/eclair: add direct link to reports

2023-08-01 Thread Stefano Stabellini
On Tue, 1 Aug 2023, Simone Ballarin wrote: > This patch adds direct links to the analysis findings in the > console log. > > Signed-off-by: Simone Ballarin Acked-by: Stefano Stabellini > --- > .../eclair_analysis/ECLAIR/action.helpers | 84 ++- > 1 file changed, 65 insert

Re: [XEN PATCH 1/4] automation/eclair: add support for tag pipelines

2023-08-01 Thread Stefano Stabellini
On Tue, 1 Aug 2023, Simone Ballarin wrote: > The ECLAIR jobs fail when triggered by tag pipelines (e.g. > xen-project/patchew/xen). > > This patch extends the integration to support such pipelines. > > Signed-off-by: Simone Ballarin Acked-by: Stefano Stabellini Thanks for the fix! One good su

Re: [PATCH 5/5] xen/ppc: Implement early serial console on PowerNV

2023-08-01 Thread Shawn Anastasio
On 8/1/23 6:19 AM, Jan Beulich wrote: > On 28.07.2023 23:35, Shawn Anastasio wrote: >> --- a/xen/arch/ppc/include/asm/asm-defns.h >> +++ b/xen/arch/ppc/include/asm/asm-defns.h >> @@ -23,6 +23,18 @@ >> addis reg,%r2,name@toc@ha; >> \ >> addi

Re: [XEN PATCH v2 3/3] arm/efi: address MISRA C:2012 Rule 5.3

2023-08-01 Thread Stefano Stabellini
On Tue, 1 Aug 2023, Nicola Vetrini wrote: > Rule 5.3 has the following headline: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope" > > The file-scope variable 'fdt' is shadowed by function parameters, > and thus violates the rule, hence it's ren

Re: [PATCH v3 21/25] tools/xenstore: introduce read_node_nocopy()

2023-08-01 Thread Julien Grall
Hi Juergen, Title: I can't find read_node_nocopy(). I found a read_node_const(). Which name did you intend to use? On 24/07/2023 12:02, Juergen Gross wrote: +static int read_node_helper(struct connection *conn, struct node *node) +{ /* Data is binary blob (usually ascii, no nul). */ -

Re: [PATCH v2] arm32: Avoid using solaris syntax for .section directive

2023-08-01 Thread Khem Raj
On Tue, Aug 1, 2023 at 2:03 PM Julien Grall wrote: > > Hi, > > Title: This patch is not arm32 specific anymore. So I would replace > 'arm32' with 'arm'. This can be done on commit. > > On 01/08/2023 18:49, Khem Raj wrote: > > Assembler from binutils 2.41 rejects [1] this syntax > > > > .section "n

Re: [PATCH v3 20/25] tools/xenstore: alloc new memory in domain_adjust_node_perms()

2023-08-01 Thread Julien Grall
Hi Juergen, On 24/07/2023 12:02, Juergen Gross wrote: In order to avoid modifying the node data in the data base in case a domain is gone, let domain_adjust_node_perms() allocate new memory for the permissions in case they need to be modified. As this should happen only in very rare cases, it is

Re: [PATCH v3 19/25] tools/xenstore: use struct node_hdr in struct node

2023-08-01 Thread Julien Grall
Hi Juergen, On 24/07/2023 12:02, Juergen Gross wrote: diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index c72fc0c725..404ecd0c62 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -555,6 +555,12 @@ static void initialize_fds(int

Re: [PATCH v3 18/25] tools/xenstore: don't use struct node_perms in struct node

2023-08-01 Thread Julien Grall
Hi Juergen, On 24/07/2023 12:02, Juergen Gross wrote: Open code struct node_perms in struct node in order to prepare using struct node_hdr in struct node. Add two helpers to transfer permissions between struct node and struct node_perms. Signed-off-by: Juergen Gross --- V2: - new patch ---

[xen-4.14-testing test] 182092: tolerable FAIL - PUSHED

2023-08-01 Thread osstest service owner
flight 182092 xen-4.14-testing real [real] flight 182104 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182092/ http://logs.test-lab.xenproject.org/osstest/logs/182104/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [PATCH v2] arm32: Avoid using solaris syntax for .section directive

2023-08-01 Thread Julien Grall
Hi, Title: This patch is not arm32 specific anymore. So I would replace 'arm32' with 'arm'. This can be done on commit. On 01/08/2023 18:49, Khem Raj wrote: Assembler from binutils 2.41 rejects [1] this syntax .section "name"[, flags...] where flags could be #alloc, #write, #execinstr, #exc

[RFC 6/6] capabilities: convert attach debugger into a capability

2023-08-01 Thread Daniel P. Smith
Expresses the ability to attach a debugger as a capability that a domain can be provisioned. Signed-off-by: Daniel P. Smith --- xen/arch/x86/hvm/svm/svm.c | 8 xen/arch/x86/hvm/vmx/realmode.c | 2 +- xen/arch/x86/hvm/vmx/vmcs.c | 2 +- xen/arch/x86/hvm/vmx/vmx.c | 10 ++

[RFC 5/6] capabilities: add dom0 cpu faulting disable

2023-08-01 Thread Daniel P. Smith
This encapsulates disableing cpu faulting for PV dom0 as a capability. Signed-off-by: Daniel P. Smith --- xen/arch/x86/cpu-policy.c | 2 +- xen/arch/x86/cpu/common.c | 82 +++ xen/arch/x86/setup.c | 4 ++ xen/include/xen/sched.h | 8 +++- 4 files cha

[RFC 4/6] capabilities: introduce console io as a domain capability

2023-08-01 Thread Daniel P. Smith
The field `is_console` suggests that the field represents a state of being or posession, not that it reflects the privilege to access the console. In this patch the field is renamed to capabilities to encapsulate the capabilities a domain has been granted. The first capability being the ability to

[RFC 3/6] roles: add a role for xenstore domain

2023-08-01 Thread Daniel P. Smith
Expand the possible roles for a domain to include a role for the Xenstore domain. Signed-off-by: Daniel P. Smith --- xen/common/domain.c | 3 +++ xen/include/xen/sched.h | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/common/domain.c b/xen/common/domain.c index 0ff

[RFC 2/6] roles: provide abstraction for the possible domain roles

2023-08-01 Thread Daniel P. Smith
The existing concepts such as unbounded domain, ie. all powerful, control domain and hardware domain are, effectively, roles the domains provide for the system. Currently, these are represented with booleans within `struct domain` or global domid variables that are compared against. This patch begi

[RFC 1/6] dom0: replace explict zero checks

2023-08-01 Thread Daniel P. Smith
A legacy concept is that the initial domain will have a domain id of zero. As a result there are places where a check that a domain is the inital domain is determined by an explicit check that the domid is zero. This commit seeks to abstract this check into a function call and replace all check lo

[RFC 0/6] Hyperlaunch domain roles and capabilities

2023-08-01 Thread Daniel P. Smith
A goal of the hyperlaunch effort was to solidify the concept of the different types of domains the hypervisor has some notion around. The initial approach was to formalize these types as roles enforced through the XSM framework. In this RFC, a simpler approach is taken to lay a foundation of domain

Re: [PATCH RESEND v9 33/36] KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling

2023-08-01 Thread Sean Christopherson
On Tue, Aug 01, 2023, Peter Zijlstra wrote: > On Tue, Aug 01, 2023 at 07:01:15PM +, Sean Christopherson wrote: > > The spec I have from May 2022 says the NMI bit colocated with CS, not SS. > > And > > the cover letter's suggestion to use a search engine to find the spec ain't > > exactly help

Re: [PATCH RESEND v9 33/36] KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling

2023-08-01 Thread Peter Zijlstra
On Tue, Aug 01, 2023 at 07:01:15PM +, Sean Christopherson wrote: > The spec I have from May 2022 says the NMI bit colocated with CS, not SS. And > the cover letter's suggestion to use a search engine to find the spec ain't > exactly helpful, that just gives me the same "May 2022 Revision 3.0"

Re: [PATCH RESEND v9 33/36] KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling

2023-08-01 Thread Sean Christopherson
On Tue, Aug 01, 2023, Xin Li wrote: > > diff --git a/arch/x86/kvm/vmx/vmenter.S b/arch/x86/kvm/vmx/vmenter.S > index 07e927d4d099..5ee6a57b59a5 100644 > --- a/arch/x86/kvm/vmx/vmenter.S > +++ b/arch/x86/kvm/vmx/vmenter.S > @@ -2,12 +2,14 @@ > #include > #include > #include > +#include > #i

Re: [PATCH 4/5] xen/ppc: Parse device tree for OPAL node on PowerNV

2023-08-01 Thread Shawn Anastasio
On 7/31/23 11:06 AM, Jan Beulich wrote: > On 28.07.2023 23:35, Shawn Anastasio wrote: >> --- a/xen/arch/ppc/arch.mk >> +++ b/xen/arch/ppc/arch.mk >> @@ -10,5 +10,5 @@ CFLAGS += -mstrict-align -mcmodel=medium -mabi=elfv2 -fPIC >> -mno-altivec -mno-vsx >> LDFLAGS += -m elf64lppc >> >> # TODO: Dr

Re: [PATCH 2/5] xen/ppc: Switch to medium PIC code model

2023-08-01 Thread Shawn Anastasio
On 8/1/23 7:20 AM, Jan Beulich wrote: > On 28.07.2023 23:35, Shawn Anastasio wrote: >> @@ -11,16 +13,19 @@ ENTRY(start) >> FIXUP_ENDIAN >> >> /* set up the TOC pointer */ >> -LOAD_IMM32(%r2, .TOC.) >> +bcl 20, 31, .+4 >> +1: mflr%r12 >> +addis %r2, %r12, .TOC.

Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t

2023-08-01 Thread Andy Shevchenko
On Tue, Aug 01, 2023 at 02:54:45PM +0200, Takashi Iwai wrote: > On Mon, 31 Jul 2023 21:40:20 +0200, > Mark Brown wrote: > > On Mon, Jul 31, 2023 at 09:30:29PM +0200, Takashi Iwai wrote: > > > Mark Brown wrote: > > > > > > It really feels like we ought to rename, or add an alias for, the type > > >

[PATCH v2] arm32: Avoid using solaris syntax for .section directive

2023-08-01 Thread Khem Raj
Assembler from binutils 2.41 rejects [1] this syntax .section "name"[, flags...] where flags could be #alloc, #write, #execinstr, #exclude, and #tls [2] It is almost like a regression compared to 2.40 or older release, It likely went unnoticed so far because Linux kernel changed to GNU syntax al

RE: [PATCH RESEND v9 00/36] x86: enable FRED for x86-64

2023-08-01 Thread Li, Xin3
> > I also believe there is a kernel.org service for sending patch series, > > but i'm not sure I remember the details. > > https://b4.docs.kernel.org/en/latest/contributor/send.html It says: The kernel.org endpoint can only be used for kernel.org-hosted projects. If there are no recognized maili

RE: [PATCH RESEND v9 00/36] x86: enable FRED for x86-64

2023-08-01 Thread Li, Xin3
> > Resend because the mail system failed to deliver some messages yesterday. > > The one from yesterday came in 6 thread groups: 0-25, 26, 27, 28, 29, 30-36, > while the one from today comes in 2 thread groups: 0-26, 27-36. Which I > suppose one can count as an improvement :/ Sigh, sorry for the

Re: [PATCH v7 0/9] Allow dynamic allocation of software IO TLB bounce buffers

2023-08-01 Thread Petr Tesarik
On 8/1/2023 6:03 PM, Christoph Hellwig wrote: > Thanks, > > I've applied this to a new swiotlb-dynamic branch that I'll pull into > the dma-mapping for-next tree. Thank you. I guess I can prepare some follow-up series now. ;-) Petr T

Re: [PATCH] common: move simple_strto{,u}l{,l}() to lib/

2023-08-01 Thread Shawn Anastasio
On 8/1/23 5:34 AM, Jan Beulich wrote: > Convert style from a Xen/Linux mix to pure Xen while doing the move. No > other changes, despite having been heavily tempted to do some - at the > very least to make simple_strtoul() and simple_strtoull() the same in > how they deal with non-numeric digits. >

[PATCH 2/2] fdt: make fdt handling reusable across arch

2023-08-01 Thread Daniel P. Smith
This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is introduced for when the ability of parsing DTB files is needed by a capability such as hyperlaunch. Signed-off-by: Daniel P. Smith --- MAINTAINERS

[PATCH 1/2] docs: update hyperlaunch device tree

2023-08-01 Thread Daniel P. Smith
With on going development of hyperlaunch, changes to the device tree definitions has been necessary. This commit updates the specification for all current changes along with changes expected to be made in finalizing the capability. This commit also adds a HYPERLAUNCH section to the MAINTAINERS fi

[PATCH 0/2] Rebranding dom0less to hyperlaunch part 1

2023-08-01 Thread Daniel P. Smith
This is the first series of the proposal put forth on moving to have dom0less folded under and thus rebranded as a part of hyperlaunch. As laid out in the proposal, the series updates the hyperlaunch device tree documentation and applies the general refactoring of FDT parsing to make core logic com

[PATCH] console: generalize the ability for domU access

2023-08-01 Thread Daniel P. Smith
This patch reworks the console rotation logic to provide a general mechanism to incorporate domU in to the rotation. It does so by walking the domain list using the XSM console privlege check to determine if the domain is given access. In reworking the rotation logic, the assumption that the hardw

Re: [PATCH v7 0/9] Allow dynamic allocation of software IO TLB bounce buffers

2023-08-01 Thread Christoph Hellwig
Thanks, I've applied this to a new swiotlb-dynamic branch that I'll pull into the dma-mapping for-next tree.

Re: [PATCH v6 2/2] xen/riscv: introduce identity mapping

2023-08-01 Thread Oleksii
On Tue, 2023-08-01 at 16:50 +0200, Jan Beulich wrote: > On 01.08.2023 16:30, Oleksii Kurochko wrote: > > @@ -54,3 +70,17 @@ ENTRY(reset_stack) > >   > > ret > >   > > +    .section .text.ident, "ax", %progbits > > + > > +ENTRY(turn_on_mmu) > > +    sfence.vma > > + > > +    li 

[PATCH -next] xen/evtchn: Remove unused function declaration xen_set_affinity_evtchn()

2023-08-01 Thread Yue Haibing
Commit 67473b8194bc ("xen/events: Remove disfunct affinity spreading") leave this unused declaration. Signed-off-by: Yue Haibing --- include/xen/events.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/xen/events.h b/include/xen/events.h index 95970a2f7695..95d5e28de324 100644 --- a/i

Re: [PATCH] arm32: Avoid using solaris syntax for .section directive

2023-08-01 Thread Khem Raj
On Tue, Aug 1, 2023 at 12:39 AM Michal Orzel wrote: > > Hi, > > On 01/08/2023 02:28, Khem Raj wrote: > > > > > > Assembler from binutils 2.41 rejects this syntax > > > > .section "name"[, flags...] > > > > where flags could be #alloc, #write, #execstr > s/execstr/execinstr + there is also #exclude

Re: [PATCH] arm32: Avoid using solaris syntax for .section directive

2023-08-01 Thread Khem Raj
On Tue, Aug 1, 2023 at 12:33 AM Jan Beulich wrote: > > On 01.08.2023 02:12, Khem Raj wrote: > > Assembler from binutils 2.41 rejects this syntax > > > > .section "name"[, flags...] > > > > where flags could be #alloc, #write, #execstr > > Switch to using ELF syntax > > You mean GNU, not ELF (ELF i

Re: [PATCH v6 2/2] xen/riscv: introduce identity mapping

2023-08-01 Thread Jan Beulich
On 01.08.2023 16:30, Oleksii Kurochko wrote: > @@ -54,3 +70,17 @@ ENTRY(reset_stack) > > ret > > +.section .text.ident, "ax", %progbits > + > +ENTRY(turn_on_mmu) > +sfence.vma > + > +li t0, RV_STAGE1_MODE > +sllit0, t0, SATP_MODE_SHIFT > + > +

Xen Security Advisory 436 v1 (CVE-2023-34320) - arm: Guests can trigger a deadlock on Cortex-A77

2023-08-01 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2023-34320 / XSA-436 arm: Guests can trigger a deadlock on Cortex-A77 ISSUE DESCRIPTION = Cortex-A77 cores (r0p0 and r1p0) are affected by erratum 1508412 where software, under certa

[PATCH v6 1/2] xen/riscv: introduce function for physical offset calculation

2023-08-01 Thread Oleksii Kurochko
The function was introduced to calculate and save physical offset before MMU is enabled because access to start() is PC-relative and in case of linker_addr != load_addr it will result in incorrect value in phys_offset. Signed-off-by: Oleksii Kurochko --- Changes in V6: - After 9380f06fe8("xen: D

[PATCH v6 2/2] xen/riscv: introduce identity mapping

2023-08-01 Thread Oleksii Kurochko
The way how switch to virtual address was implemented in the commit e66003e7be ("xen/riscv: introduce setup_initial_pages") isn't safe enough as: * enable_mmu() depends on hooking all exceptions and pagefault. * Any exception other than pagefault, or not taking a pagefault causes it to malfunct

[PATCH v6 0/2] xen/riscv: introduce identity mapping

2023-08-01 Thread Oleksii Kurochko
The patch series introduces things necessary to implement identity mapping: 1. Make identity mapping for the entire Xen. 2. Enable MMU. 3. Jump to the virtual address world 4. Remove identity mapping. Also current patch series introduces the calculation of physical offset before MMU is ena

Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t

2023-08-01 Thread Mark Brown
On Tue, Aug 01, 2023 at 02:54:45PM +0200, Takashi Iwai wrote: > That's true. The question is how more widely it'll be used, then. Indeed. > Is something like below what you had in mind, too? Yes, or Andy's suggestion of just copying without trying to put a redirect in works for me too. I imag

Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t

2023-08-01 Thread Andy Shevchenko
On Mon, Jul 31, 2023 at 09:30:29PM +0200, Takashi Iwai wrote: > On Mon, 31 Jul 2023 19:20:54 +0200, > Mark Brown wrote: > > > > On Mon, Jul 31, 2023 at 05:46:54PM +0200, Takashi Iwai wrote: > > > > > this is a patch set to clean up the PCM copy ops using sockptr_t as a > > > "universal" pointer,

Re: [XEN PATCH] x86/cpu-policy: justify a violation of MISRA C:2012 Rule 1.3

2023-08-01 Thread Nicola Vetrini
On 01/08/2023 15:40, Jan Beulich wrote: On 01.08.2023 15:06, Nicola Vetrini wrote: The empty feature set 'str_7c1' in 'tools/misc/xen-cpuid.c' causes the struct declaration to have no named members, hence violating Rule 1.3: "There shall be no occurrence of undefined or critical unspecified beh

Re: [XEN PATCH] xen/spinlock: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-08-01 Thread Jan Beulich
On 01.08.2023 11:46, Federico Serafini wrote: > --- a/xen/include/xen/spinlock.h > +++ b/xen/include/xen/spinlock.h > @@ -125,8 +125,9 @@ struct lock_profile_qhead { > } while(0) > > void _lock_profile_register_struct( > -int32_t, struct lock_profile_qhead *, int32_t); > -void _lock_pro

Re: [XEN PATCH] x86: mechanically rename to address MISRA C:2012 Rule 5.3

2023-08-01 Thread Jan Beulich
On 01.08.2023 10:58, Nicola Vetrini wrote: > Rule 5.3 has the following headline: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope" > > The renames done by this patch avoid shadowing from happening. > They are as follows: > - s/socket_info/sock_

Re: [XEN PATCH] xen/lib: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-08-01 Thread Jan Beulich
On 01.08.2023 09:05, Federico Serafini wrote: > Give a name to unnamed parameters thus addressing violations of > MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with > named parameters"). > Keep consistency between parameter names and types used in function > declarations and the

Re: xen | Failed pipeline for staging | c2026b88

2023-08-01 Thread Jan Beulich
On 01.08.2023 15:35, GitLab wrote: > > > Pipeline #951705012 has failed! > > Project: xen ( https://gitlab.com/xen-project/xen ) > Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) > > Commit: c2026b88 ( > https://gitlab.com/xen-project/xen/-/commit/c2026b88b58cbb6a84e28

Re: [XEN PATCH] x86/cpu-policy: justify a violation of MISRA C:2012 Rule 1.3

2023-08-01 Thread Jan Beulich
On 01.08.2023 15:06, Nicola Vetrini wrote: > The empty feature set 'str_7c1' in 'tools/misc/xen-cpuid.c' causes the > struct declaration to have no named members, hence violating > Rule 1.3: > "There shall be no occurrence of undefined or critical unspecified behaviour" > because it is forbidden by

Re: [XEN PATCH v2 1/3] xen/common: address MISRA C:2012 Rule 5.3

2023-08-01 Thread Nicola Vetrini
On 01/08/2023 15:33, Jan Beulich wrote: On 01.08.2023 14:47, Nicola Vetrini wrote: --- a/xen/common/compat/memory.c +++ b/xen/common/compat/memory.c @@ -81,6 +81,7 @@ int compat_memory_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) compat) struct compat_memory_exchange xchg;

Re: [XEN PATCH v2 2/3] drivers/char: address MISRA C:2012 Rule 5.3

2023-08-01 Thread Jan Beulich
On 01.08.2023 14:47, Nicola Vetrini wrote: > The following strategies are adopted to deal with violations > of MISRA C:2012 Rule 5.3: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope". > > Local variable 'ctrl' shadows a variable defined in an o

Re: [XEN PATCH v2 1/3] xen/common: address MISRA C:2012 Rule 5.3

2023-08-01 Thread Jan Beulich
On 01.08.2023 14:47, Nicola Vetrini wrote: > --- a/xen/common/compat/memory.c > +++ b/xen/common/compat/memory.c > @@ -81,6 +81,7 @@ int compat_memory_op(unsigned int cmd, > XEN_GUEST_HANDLE_PARAM(void) compat) > struct compat_memory_exchange xchg; > struct compat_add_to_

[linux-linus test] 182087: regressions - FAIL

2023-08-01 Thread osstest service owner
flight 182087 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182087/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl

Re: [PATCH 3/3] xen/ppc: Implement initial Radix MMU support

2023-08-01 Thread Jan Beulich
On 29.07.2023 00:21, Shawn Anastasio wrote: > --- /dev/null > +++ b/xen/arch/ppc/include/asm/bitops.h > @@ -0,0 +1,11 @@ > +#ifndef _ASM_PPC_BITOPS_H > +#define _ASM_PPC_BITOPS_H > + > +#include Not a big deal, but ... > +/* PPC bit number conversion */ > +#define PPC_BITLSHIFT(be)(BITS_PER_

[XEN PATCH] x86/cpu-policy: justify a violation of MISRA C:2012 Rule 1.3

2023-08-01 Thread Nicola Vetrini
The empty feature set 'str_7c1' in 'tools/misc/xen-cpuid.c' causes the struct declaration to have no named members, hence violating Rule 1.3: "There shall be no occurrence of undefined or critical unspecified behaviour" because it is forbidden by ISO/IEC 9899:1999(E), Section 6.7.2.1.7: "If the str

Re: [PATCH RESEND v9 00/36] x86: enable FRED for x86-64

2023-08-01 Thread Peter Zijlstra
On Tue, Aug 01, 2023 at 12:52:36PM +0200, Peter Zijlstra wrote: > I also believe there is a kernel.org service for sending patch series, > but i'm not sure I remember the details. https://b4.docs.kernel.org/en/latest/contributor/send.html

Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t

2023-08-01 Thread Takashi Iwai
On Mon, 31 Jul 2023 21:40:20 +0200, Mark Brown wrote: > > On Mon, Jul 31, 2023 at 09:30:29PM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > > It really feels like we ought to rename, or add an alias for, the type > > > if we're going to start using it more widely - it's not helping to mak

[XEN PATCH v2 3/3] arm/efi: address MISRA C:2012 Rule 5.3

2023-08-01 Thread Nicola Vetrini
Rule 5.3 has the following headline: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" The file-scope variable 'fdt' is shadowed by function parameters, and thus violates the rule, hence it's renamed to 'fdt_efi' No functional changes. Signed-off-

[XEN PATCH v2 0/3] xen: address MISRA C:2012 Rule 5.3

2023-08-01 Thread Nicola Vetrini
Rule 5.3 has the following headline: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope". The following two strategies are adopted to deal with some violations of this rule: - renaming of local variables, functions or parameters; - removal of unnecess

[XEN PATCH v2 2/3] drivers/char: address MISRA C:2012 Rule 5.3

2023-08-01 Thread Nicola Vetrini
The following strategies are adopted to deal with violations of MISRA C:2012 Rule 5.3: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope". Local variable 'ctrl' shadows a variable defined in an outer scope. Since the innermost variable is used only o

[XEN PATCH v2 1/3] xen/common: address MISRA C:2012 Rule 5.3

2023-08-01 Thread Nicola Vetrini
The following strategies are adopted to deal with violations of MISRA C:2012 Rule 5.3: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope". - s/nodes/numa_nodes/ for the file-scope variable in 'common/numa.c'; - move the variable 'struct compat_remove

[xen-unstable-smoke test] 182100: tolerable all pass - PUSHED

2023-08-01 Thread osstest service owner
flight 182100 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182100/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH 2/5] xen/ppc: Switch to medium PIC code model

2023-08-01 Thread Jan Beulich
On 28.07.2023 23:35, Shawn Anastasio wrote: > @@ -11,16 +13,19 @@ ENTRY(start) > FIXUP_ENDIAN > > /* set up the TOC pointer */ > -LOAD_IMM32(%r2, .TOC.) > +bcl 20, 31, .+4 > +1: mflr%r12 > +addis %r2, %r12, .TOC.-1b@ha > +addi%r2, %r2, .TOC.-1b@l >

Re: [PATCH v1 7/7] xenalyze: handle more potential exit reason values from vmx.h

2023-08-01 Thread Olaf Hering
Fri, 28 Jul 2023 21:35:54 +0100 George Dunlap : > Everything looks good (including adding the missing strings), except for > the removal of the fixed array size. Call me paranoid, but if we define it > as REASON_MAX length, then there will never be any way that a value less > than REASON_MAX caus

Re: [PATCH 5/5] xen/ppc: Implement early serial console on PowerNV

2023-08-01 Thread Jan Beulich
On 28.07.2023 23:35, Shawn Anastasio wrote: > --- a/xen/arch/ppc/include/asm/asm-defns.h > +++ b/xen/arch/ppc/include/asm/asm-defns.h > @@ -23,6 +23,18 @@ > addis reg,%r2,name@toc@ha; > \ > addi reg,reg,name@toc@l Noticing only now, because

Re: [PATCH RESEND v9 00/36] x86: enable FRED for x86-64

2023-08-01 Thread Peter Zijlstra
On Tue, Aug 01, 2023 at 01:32:42AM -0700, Xin Li wrote: > Resend because the mail system failed to deliver some messages yesterday. Well, you need to figure out how to send patches, because both yesterday and today are screwy. The one from yesterday came in 6 thread groups: 0-25, 26, 27, 28, 29,

[PATCH] common: move simple_strto{,u}l{,l}() to lib/

2023-08-01 Thread Jan Beulich
Convert style from a Xen/Linux mix to pure Xen while doing the move. No other changes, despite having been heavily tempted to do some - at the very least to make simple_strtoul() and simple_strtoull() the same in how they deal with non-numeric digits. Requested-by: Shawn Anastasio Signed-off-by:

Re: [PATCH 0/3] x86: Some MISRA Rule 5.3 fixes

2023-08-01 Thread Jan Beulich
On 28.07.2023 21:43, Andrew Cooper wrote: > 'debug' and 'str' account for an awefully large number of shadowed variable > violations. > > Andrew Cooper (3): > x86/traps: Move do_general_protection() earlier > x86/entry: Rename the exception entrypoints > x86: Delete str() Series Acked-by: J

Re: [PATCH v4 1/1] ns16550: add support for polling mode when device tree is used

2023-08-01 Thread Jan Beulich
On 01.08.2023 11:46, Oleksii wrote: > On Mon, 2023-07-31 at 15:24 +0200, Jan Beulich wrote: >> On 27.07.2023 18:45, Oleksii Kurochko wrote: >>> @@ -654,6 +674,9 @@ static void ns16550_init_common(struct ns16550 >>> *uart) >>>   >>> /* Default lsr_mask = UART_LSR_THRE */ >>> uart->lsr_mask

[XEN PATCH 4/4] automation/eclair: avoid failure in case of missing merge point

2023-08-01 Thread Simone Ballarin
In the context of an auto pull request, when a common merge point is not found the integration will continue the analysis without failing. Signed-off-by: Simone Ballarin --- automation/eclair_analysis/ECLAIR/action.settings | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/a

[XEN PATCH 2/4] automation/eclair: add direct link to reports

2023-08-01 Thread Simone Ballarin
This patch adds direct links to the analysis findings in the console log. Signed-off-by: Simone Ballarin --- .../eclair_analysis/ECLAIR/action.helpers | 84 ++- 1 file changed, 65 insertions(+), 19 deletions(-) diff --git a/automation/eclair_analysis/ECLAIR/action.helpers b

[XEN PATCH 3/4] automation/eclair: add scheduled pipelines

2023-08-01 Thread Simone Ballarin
This patch introduces six new ECLAIR jobs that run only when triggered by a GitLab scheduled pipeline. Signed-off-by: Simone Ballarin --- .../eclair_analysis/ECLAIR/action.settings| 2 +- automation/gitlab-ci/analyze.yaml | 65 +-- 2 files changed, 62 insertions(

  1   2   >