Re: [PATCH v3 01/10] xen/version: Calculate xen_capabilities_info once at boot

2023-08-15 Thread Jan Beulich
On 16.08.2023 01:03, Stefano Stabellini wrote: > On Tue, 15 Aug 2023, Andrew Cooper wrote: >> The arch_get_xen_caps() infrastructure is horribly inefficient for something >> that is constant after features have been resolved on boot. >> >> Every instance used snprintf() to format constants into a s

Re: [PATCH v3 02/10] xen/version: Introduce non-truncating deterministically-signed XENVER_* subops

2023-08-15 Thread Jan Beulich
On 16.08.2023 04:58, Andrew Cooper wrote: > On 16/08/2023 1:19 am, Stefano Stabellini wrote: >> On Tue, 15 Aug 2023, Andrew Cooper wrote: >>> --- a/xen/include/public/version.h >>> +++ b/xen/include/public/version.h >>> @@ -19,12 +19,20 @@ >>> /* arg == NULL; returns major:minor (16:16). */ >>> #

Re: [PATCH V4] xen: privcmd: Add support for irqfd

2023-08-15 Thread Viresh Kumar
On 25-07-23, 16:27, Viresh Kumar wrote: > Xen provides support for injecting interrupts to the guests via the > HYPERVISOR_dm_op() hypercall. The same is used by the Virtio based > device backend implementations, in an inefficient manner currently. > > Generally, the Virtio backends are implemente

Re: [PATCH v3 1/5] build: make cc-option properly deal with unrecognized sub-options

2023-08-15 Thread Jan Beulich
On 11.08.2023 15:48, Anthony PERARD wrote: > On Wed, Jul 26, 2023 at 12:33:07PM +0200, Jan Beulich wrote: >> In options like -march=, it may be only the sub-option which is >> unrecognized by the compiler. In such an event the error message often >> splits option and argument, typically saying some

Re: [PATCH v3 02/10] xen/version: Introduce non-truncating deterministically-signed XENVER_* subops

2023-08-15 Thread Andrew Cooper
On 16/08/2023 1:19 am, Stefano Stabellini wrote: > On Tue, 15 Aug 2023, Andrew Cooper wrote: >> @@ -498,6 +499,59 @@ static int __init cf_check param_init(void) >> >> +sz = strlen(str); >> + >> +if ( sz > KB(64) ) /* Arbitrary limit. Avoid long-running operations. >> */ >> +return

[qemu-mainline test] 182338: tolerable FAIL - PUSHED

2023-08-15 Thread osstest service owner
flight 182338 qemu-mainline real [real] flight 182354 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182338/ http://logs.test-lab.xenproject.org/osstest/logs/182354/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-am

Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

2023-08-15 Thread Henry Wang
Hi Daniel, > On Aug 9, 2023, at 05:05, Daniel P. Smith > wrote: > > On 8/4/23 00:10, Henry Wang wrote: >> Hi Daniel, > > Hey Henry! > >>> -Original Message- >>> Subject: [PATCH v2 2/2] fdt: make fdt handling reusable across arch >>> >>> This refactors reusable code from Arm's bootfdt

Re: [PATCH] docs: Drop warning about 2M limit for ARM

2023-08-15 Thread Henry Wang
Hi Andrew, > On Aug 16, 2023, at 00:14, Andrew Cooper wrote: > > This issue has been addressed in the 4.18 timeframe. > > Signed-off-by: Andrew Cooper Reviewed-by: Henry Wang Kind regards, Henry

Re: [PATCH v3 02/10] xen/version: Introduce non-truncating deterministically-signed XENVER_* subops

2023-08-15 Thread Stefano Stabellini
On Tue, 15 Aug 2023, Andrew Cooper wrote: > Recently in XenServer, we have encountered problems caused by both > XENVER_extraversion and XENVER_commandline having fixed bounds. > > More than just the invariant size, the APIs/ABIs also broken by typedef-ing an > array, and using an unqualified 'cha

Re: [PATCH v3 01/10] xen/version: Calculate xen_capabilities_info once at boot

2023-08-15 Thread Stefano Stabellini
On Tue, 15 Aug 2023, Andrew Cooper wrote: > The arch_get_xen_caps() infrastructure is horribly inefficient for something > that is constant after features have been resolved on boot. > > Every instance used snprintf() to format constants into a string (which gets > shorter when %d gets resolved!),

Re: [PATCH v3 04/10] xen/version: Misc style fixes

2023-08-15 Thread Daniel P. Smith
On 8/15/23 17:06, Andrew Cooper wrote: No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Reviewed-by: Daniel P. Smith

Re: [PATCH v3 02/10] xen/version: Introduce non-truncating deterministically-signed XENVER_* subops

2023-08-15 Thread Daniel P. Smith
On 8/15/23 17:06, Andrew Cooper wrote: Recently in XenServer, we have encountered problems caused by both XENVER_extraversion and XENVER_commandline having fixed bounds. More than just the invariant size, the APIs/ABIs also broken by typedef-ing an array, and using an unqualified 'char' which ha

[xen-unstable-smoke test] 182353: tolerable all pass - PUSHED

2023-08-15 Thread osstest service owner
flight 182353 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182353/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH v3 10/10] tools: Introduce a xc_xenver_buildid() wrapper

2023-08-15 Thread Andrew Cooper
... which converts binary content to hex automatically. Update libxl to match. No API/ABI change. This removes a latent libxl bug for cases when the buildid is longer than 4092 bytes. Signed-off-by: Andrew Cooper Acked-by: Anthony PERARD --- CC: Wei Liu CC: Anthony PERARD CC: Juergen Gross

[PATCH v3 02/10] xen/version: Introduce non-truncating deterministically-signed XENVER_* subops

2023-08-15 Thread Andrew Cooper
Recently in XenServer, we have encountered problems caused by both XENVER_extraversion and XENVER_commandline having fixed bounds. More than just the invariant size, the APIs/ABIs also broken by typedef-ing an array, and using an unqualified 'char' which has implementation-specific signed-ness. P

[PATCH v3 05/10] tools/libxc: Move xc_version() out of xc_private.c into its own file

2023-08-15 Thread Andrew Cooper
kexec-tools uses xc_version(), meaning that it is not a private API. As we're going to extend the functionality substantially, move it to its own file. Signed-off-by: Andrew Cooper Acked-by: Anthony PERARD --- CC: Wei Liu CC: Anthony PERARD CC: Juergen Gross --- tools/libs/ctrl/Makefile.com

[PATCH v3 08/10] tools: Introduce a non-truncating xc_xenver_changeset()

2023-08-15 Thread Andrew Cooper
Update libxl and the ocaml stubs to match. No API/ABI change in either. Signed-off-by: Andrew Cooper Acked-by: Anthony PERARD Acked-by: Christian Lindig --- CC: Wei Liu CC: Anthony PERARD CC: Juergen Gross CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes --- tools/incl

[PATCH v3 01/10] xen/version: Calculate xen_capabilities_info once at boot

2023-08-15 Thread Andrew Cooper
The arch_get_xen_caps() infrastructure is horribly inefficient for something that is constant after features have been resolved on boot. Every instance used snprintf() to format constants into a string (which gets shorter when %d gets resolved!), and which get double buffered on the stack. Switch

[PATCH v3 03/10] xen/version: Fold build_id handling into xenver_varbuf_op()

2023-08-15 Thread Andrew Cooper
struct xen_build_id and struct xen_varbuf are identical from an ABI point of view, so XENVER_build_id can reuse xenver_varbuf_op() rather than having it's own almost identical copy of the logic. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: George Dunlap C

[PATCH v3 for-4.18 00/10] Non-truncating XENVER_* subops

2023-08-15 Thread Andrew Cooper
https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/968728976 https://cirrus-ci.com/build/6741556116324352 Posting both parts, as there has been minor rebasing in all of them. Andrew Cooper (10): xen/version: Calculate xen_capabilities_info once at boot xen/version: Introduce non-tr

[PATCH v3 04/10] xen/version: Misc style fixes

2023-08-15 Thread Andrew Cooper
No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall CC: Daniel De Graaf CC: Daniel Smith CC: Jason Andryuk CC: Henry Wang --- xen/common/kernel.c | 11 +-- xen/common

[PATCH v3 09/10] tools: Introduce a non-truncating xc_xenver_cmdline()

2023-08-15 Thread Andrew Cooper
Update libxl to match. No API/ABI change. Signed-off-by: Andrew Cooper Acked-by: Anthony PERARD --- CC: Wei Liu CC: Anthony PERARD CC: Juergen Gross --- tools/include/xenctrl.h | 1 + tools/libs/ctrl/xc_version.c | 5 + tools/libs/light/libxl.c | 4 +--- 3 files changed, 7 inse

[PATCH v3 06/10] tools: Introduce a non-truncating xc_xenver_extraversion()

2023-08-15 Thread Andrew Cooper
... which uses XENVER_extraversion2. In order to do sensibly, use manual hypercall buffer handling. Not only does this avoid an extra bounce buffer (we need to strip the xen_varbuf_t header anyway), it's also shorter and easlier to follow. Update libxl and the ocaml stubs to match. No API/ABI c

[PATCH v3 07/10] tools: Introduce a non-truncating xc_xenver_capabilities()

2023-08-15 Thread Andrew Cooper
Update libxl and the ocaml stubs to match. No API/ABI change in either. Signed-off-by: Andrew Cooper Acked-by: Anthony PERARD Acked-by: Christian Lindig --- CC: Wei Liu CC: Anthony PERARD CC: Juergen Gross CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes --- tools/incl

Re: [PATCH] tboot: Disable CET at shutdown

2023-08-15 Thread Daniel P. Smith
On 8/15/23 12:11, Jason Andryuk wrote: tboot_shutdown() calls into tboot to perform the actual system shutdown. tboot isn't built with endbr annotations, and Xen has CET-IBT enabled on newer hardware. shutdown_entry isn't annotated with endbr and Xen faults: Panic on CPU 0: CONTROL-FLOW PROTECT

[PATCH v2 15/25] ALSA: xen: Convert to generic PCM copy ops

2023-08-15 Thread Takashi Iwai
This patch converts the xen frontend driver code to use the new unified PCM copy callback. It's a straightforward conversion from *_user() to *_iter() variants. Note that copy_from/to_iter() returns the copied bytes, hence the error condition is adjusted accordingly. Cc: Oleksandr Andrushchenko

[PATCH v2 00/25] ALSA: Generic PCM copy ops using iov_iter

2023-08-15 Thread Takashi Iwai
Hi, this is a v2 patch set for cleaning up the PCM copy ops using iov_iter to deal with kernel / user-space pointers consistently. v1->v2: * The error condition checks of copy_to/from_iter() are changed to be more strictly * Put Acked and Reviewed tags * The indents in the patch in dmaengine wa

[libvirt test] 182337: tolerable FAIL - PUSHED

2023-08-15 Thread osstest service owner
flight 182337 libvirt real [real] flight 182349 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182337/ http://logs.test-lab.xenproject.org/osstest/logs/182349/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-li

Re: [PATCH] tboot: Disable CET at shutdown

2023-08-15 Thread Andrew Cooper
On 15/08/2023 5:11 pm, Jason Andryuk wrote: > tboot_shutdown() calls into tboot to perform the actual system shutdown. > tboot isn't built with endbr annotations, and Xen has CET-IBT enabled on > newer hardware. shutdown_entry isn't annotated with endbr and Xen > faults: > > Panic on CPU 0: > CONT

[PATCH] docs: Drop warning about 2M limit for ARM

2023-08-15 Thread Andrew Cooper
This issue has been addressed in the 4.18 timeframe. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall --- docs/hypervisor-guide/code-coverage.rst | 5 - 1 file changed, 5 deletions(-) diff --git a/docs/hypervisor-gui

[PATCH] tboot: Disable CET at shutdown

2023-08-15 Thread Jason Andryuk
tboot_shutdown() calls into tboot to perform the actual system shutdown. tboot isn't built with endbr annotations, and Xen has CET-IBT enabled on newer hardware. shutdown_entry isn't annotated with endbr and Xen faults: Panic on CPU 0: CONTROL-FLOW PROTECTION FAULT: #CP[0003] endbranch And Xen h

[linux-5.4 test] 182335: tolerable FAIL - PUSHED

2023-08-15 Thread osstest service owner
flight 182335 linux-5.4 real [real] flight 182346 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182335/ http://logs.test-lab.xenproject.org/osstest/logs/182346/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armh

Re: [PATCH] libxl: slightly correct JSON generation of CPU policy

2023-08-15 Thread Anthony PERARD
On Tue, Aug 15, 2023 at 04:44:57PM +0200, Jan Beulich wrote: > On 15.08.2023 16:28, Andrew Cooper wrote: > > On 15/08/2023 3:26 pm, Anthony PERARD wrote: > >> On Tue, Aug 15, 2023 at 02:35:55PM +0200, Jan Beulich wrote: > >>> The "cpuid_empty" label is also (in principle; maybe only for rubbish > >

Re: [PATCH] libxl: slightly correct JSON generation of CPU policy

2023-08-15 Thread Jan Beulich
On 15.08.2023 16:28, Andrew Cooper wrote: > On 15/08/2023 3:26 pm, Anthony PERARD wrote: >> On Tue, Aug 15, 2023 at 02:35:55PM +0200, Jan Beulich wrote: >>> The "cpuid_empty" label is also (in principle; maybe only for rubbish >>> input) reachable in the "cpuid_only" case. Hence the label needs to

Re: [PATCH] libxl: slightly correct JSON generation of CPU policy

2023-08-15 Thread Andrew Cooper
On 15/08/2023 3:26 pm, Anthony PERARD wrote: > On Tue, Aug 15, 2023 at 02:35:55PM +0200, Jan Beulich wrote: >> The "cpuid_empty" label is also (in principle; maybe only for rubbish >> input) reachable in the "cpuid_only" case. Hence the label needs to live >> ahead of the check of the variable. >>

Re: [PATCH] libxl: slightly correct JSON generation of CPU policy

2023-08-15 Thread Anthony PERARD
On Tue, Aug 15, 2023 at 02:35:55PM +0200, Jan Beulich wrote: > The "cpuid_empty" label is also (in principle; maybe only for rubbish > input) reachable in the "cpuid_only" case. Hence the label needs to live > ahead of the check of the variable. > > Fixes: 5b80cecb747b ("libxl: introduce MSR data

[PATCH] libxl: slightly correct JSON generation of CPU policy

2023-08-15 Thread Jan Beulich
The "cpuid_empty" label is also (in principle; maybe only for rubbish input) reachable in the "cpuid_only" case. Hence the label needs to live ahead of the check of the variable. Fixes: 5b80cecb747b ("libxl: introduce MSR data in libxl_cpuid_policy") Signed-off-by: Jan Beulich --- a/tools/libs/l

Re: [PATCH -next] xen: Switch to use kmemdup() helper

2023-08-15 Thread Juergen Gross
On 15.08.23 11:24, Ruan Jinjie wrote: Use kmemdup() helper instead of open-coding to simplify the code. Signed-off-by: Ruan Jinjie Reviewed-by: Juergen Gross with one nit ... --- drivers/xen/xen-acpi-processor.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a

[PATCH -next] xen: Switch to use kmemdup() helper

2023-08-15 Thread Ruan Jinjie
Use kmemdup() helper instead of open-coding to simplify the code. Signed-off-by: Ruan Jinjie --- drivers/xen/xen-acpi-processor.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c index 9cb61db67efd..e4b

Re: [PATCH v4 01/48] mm: move some shrinker-related function declarations to mm/internal.h

2023-08-15 Thread Qi Zheng
On 2023/8/15 16:36, Muchun Song wrote: On Aug 7, 2023, at 19:08, Qi Zheng wrote: The following functions are only used inside the mm subsystem, so it's better to move their declarations to the mm/internal.h file. 1. shrinker_debugfs_add() 2. shrinker_debugfs_detach() 3. shrinker_debugfs_

Re: [PATCH v4 12/48] gfs2: dynamically allocate the gfs2-qd shrinker

2023-08-15 Thread Muchun Song
> On Aug 7, 2023, at 19:09, Qi Zheng wrote: > > Use new APIs to dynamically allocate the gfs2-qd shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song

Re: [PATCH v4 02/48] mm: vmscan: move shrinker-related code into a separate file

2023-08-15 Thread Muchun Song
> On Aug 7, 2023, at 19:08, Qi Zheng wrote: > > The mm/vmscan.c file is too large, so separate the shrinker-related > code from it into a separate file. No functional changes. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song

Re: [PATCH v4 01/48] mm: move some shrinker-related function declarations to mm/internal.h

2023-08-15 Thread Muchun Song
> On Aug 7, 2023, at 19:08, Qi Zheng wrote: > > The following functions are only used inside the mm subsystem, so it's > better to move their declarations to the mm/internal.h file. > > 1. shrinker_debugfs_add() > 2. shrinker_debugfs_detach() > 3. shrinker_debugfs_remove() > > Signed-off-by:

[xen-unstable test] 182333: regressions - FAIL

2023-08-15 Thread osstest service owner
flight 182333 xen-unstable real [real] flight 182340 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182333/ http://logs.test-lab.xenproject.org/osstest/logs/182340/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: [PATCH 3/3] xen: Illustrate the transition to sync_try_cmpxchg

2023-08-15 Thread Juergen Gross
On 10.07.23 21:21, Uros Bizjak wrote: This patch illustrates the transition to sync_try_cmpxchg. It is not intended to be merged as-is. Cc: Peter Zijlstra Cc: Juergen Gross Cc: Stefano Stabellini Cc: Oleksandr Tyshchenko Signed-off-by: Uros Bizjak Acked-by: Juergen Gross Juergen Ope