Re: [PATCH] docs/misra: add rule 2.1 exceptions

On 23.08.2023 02:24, Stefano Stabellini wrote: > From: Stefano Stabellini > > During the discussions that led to the acceptable of Rule 2.1, we Nit (as before): "acceptance"? > decided on a few exceptions that were not properly recorded in > rules.rst. Add them now. > > Signed-off-by: Stefano

Re: [PATCH v4 2/3] xen/ppc: Relocate kernel to physical address 0 on boot

On 23.08.2023 01:03, Shawn Anastasio wrote: > Introduce a small assembly loop in `start` to copy the kernel to > physical address 0 before continuing. This ensures that the physical > address lines up with XEN_VIRT_START (0xc000) and allows us > to identity map the kernel when the MMU i

Re: [PATCH v4 1/3] xen/ppc: Bump minimum target ISA to 3.0 (POWER9)

On 23.08.2023 01:03, Shawn Anastasio wrote: > In preparation for implementing ISA3+ Radix MMU support, drop ISA 2.07B > from the supported ISA list to avoid having a non-working > configuration in tree. It can be re-added at a later point when Hash > MMU support is added. > > Signed-off-by: Shawn

Re: [PATCH] docs/misra: add exceptions to rules

On 23.08.2023 02:23, Stefano Stabellini wrote: > On Tue, 22 Aug 2023, Jan Beulich wrote: >> On 22.08.2023 03:40, Stefano Stabellini wrote: >>> If we only mention BUG, we are basically saying that as a general rule >>> only BUG is an exception. Then we have a longer more detailed list for >>> ECLAIR

Re: [PATCH] docs/misra: add exceptions to rules

On 23.08.2023 02:19, Stefano Stabellini wrote: > On Tue, 22 Aug 2023, Jan Beulich wrote: >> (re-adding xen-devel@) >> >> On 22.08.2023 17:09, Nicola Vetrini wrote: >>> >> + - Switch with a controlling value incompatible with labeled >> + statements > > What does th

Re: [PATCH v3 2/4] xen/pci: convert pci_find_*cap* to pci_sbdf_t

On 23.08.2023 05:03, Stewart Hildebrand wrote: > On 8/22/23 08:53, Jan Beulich wrote: >> On 22.08.2023 03:29, Stewart Hildebrand wrote: >>> --- a/xen/include/xen/pci.h >>> +++ b/xen/include/xen/pci.h >>> @@ -193,11 +193,10 @@ int pci_mmcfg_read(unsigned int seg, unsigned int bus, >>>

Re: [PATCH] xen/xenbus: Avoid a lockdep warning when adding a watch

On 07.06.23 14:36, Petr Pavlu wrote: The following lockdep warning appears during boot on a Xen dom0 system: [ 96.388794] == [ 96.388797] WARNING: possible circular locking dependency detected [ 96.388799] 6.4.0-rc5-default+ #8 Tainted: G

Re: [PATCH V5] xen: privcmd: Add support for irqfd

On 22.08.23 11:45, Viresh Kumar wrote: Xen provides support for injecting interrupts to the guests via the HYPERVISOR_dm_op() hypercall. The same is used by the Virtio based device backend implementations, in an inefficient manner currently. Generally, the Virtio backends are implemented to work

[xen-4.17-testing test] 182423: regressions - FAIL

flight 182423 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/182423/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 182410 build-amd64-pr

Re: [PATCH v5 11/13] xen/arm: mmu: move MMU specific P2M code to mmu/p2m.{c,h}

Hi Julien On 2023/8/23 02:01, Julien Grall wrote: Hi Henry, On 14/08/2023 05:25, Henry Wang wrote: From: Penny Zheng Current P2M implementation is designed for MMU system only. We move the MMU-specific codes into mmu/p2m.c, and only keep generic codes in p2m.c, like VMID allocator, etc. We a

"rcu_preempt detected stalls" with xen_free_irq involved - regression

Hi, Since updating from 5.15.124 to 6.1.43, I observe rather often an issue like in the subject. This happens on a domU with heavy vchan usage (several connections established and released per second). The domain in question is a PVH with 16 vCPUs and generally is rather busy (CPU time, but also

Re: [PATCH v3 2/4] xen/pci: convert pci_find_*cap* to pci_sbdf_t

On 8/22/23 08:53, Jan Beulich wrote: > On 22.08.2023 03:29, Stewart Hildebrand wrote: >> @@ -291,12 +291,9 @@ static void msi_set_enable(struct pci_dev *dev, int >> enable) >> static void msix_set_enable(struct pci_dev *dev, int enable) >> { >> int pos; >> -u16 control, seg = dev->seg;

Re: [PATCH v4 43/48] drm/ttm: introduce pool_shrink_rwsem

Hi Daniel, On 2023/8/22 21:56, Daniel Vetter wrote: On Mon, Aug 07, 2023 at 07:09:31PM +0800, Qi Zheng wrote: Currently, the synchronize_shrinkers() is only used by TTM pool. It only requires that no shrinkers run in parallel. After we use RCU+refcount method to implement the lockless slab shr

Re: [PATCH v5 11/13] xen/arm: mmu: move MMU specific P2M code to mmu/p2m.{c,h}

Hi Julien, > On Aug 23, 2023, at 02:01, Julien Grall wrote: > > Hi Henry, > > On 14/08/2023 05:25, Henry Wang wrote: >> From: Penny Zheng >> Current P2M implementation is designed for MMU system only. >> We move the MMU-specific codes into mmu/p2m.c, and only keep generic >> codes in p2m.c, li

Re: [PATCH v5 12/13] xen/arm: mmu: relocate copy_from_paddr() to setup.c

Hi Stefano, > On Aug 23, 2023, at 08:10, Stefano Stabellini wrote: > > On Tue, 22 Aug 2023, Julien Grall wrote: I also don't like the idea of having again a massive mm.c files. So maybe we need a split like: * File 1: Boot CPU0 MM bringup (mmu/setup.c) * File 2: Secondary C

[PATCH] docs/misra: add rule 2.1 exceptions

From: Stefano Stabellini During the discussions that led to the acceptable of Rule 2.1, we decided on a few exceptions that were not properly recorded in rules.rst. Add them now. Signed-off-by: Stefano Stabellini --- docs/misra/rules.rst | 13 - 1 file changed, 12 insertions(+), 1

Re: [PATCH] docs/misra: add exceptions to rules

On Tue, 22 Aug 2023, Jan Beulich wrote: > On 22.08.2023 03:40, Stefano Stabellini wrote: > > On Mon, 21 Aug 2023, Jan Beulich wrote: > >> On 19.08.2023 03:24, Stefano Stabellini wrote: > >>> @@ -106,7 +107,23 @@ maintainers if you want to suggest a change. > >>> * - `Rule 2.1 > >>>

[qemu-mainline test] 182422: tolerable FAIL - PUSHED

flight 182422 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182422/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182355 test-armhf-armhf-libvirt-qcow2 15 s

Re: [PATCH] docs/misra: add exceptions to rules

On Tue, 22 Aug 2023, Jan Beulich wrote: > (re-adding xen-devel@) > > On 22.08.2023 17:09, Nicola Vetrini wrote: > > > + - Switch with a controlling value incompatible with labeled > + statements > >>> > >>> What does this mean? > >> > >> I am not certain about this one

Re: [PATCH v5 12/13] xen/arm: mmu: relocate copy_from_paddr() to setup.c

On Tue, 22 Aug 2023, Julien Grall wrote: > > > I also don't like the idea of having again a massive mm.c files. So maybe > > > we need a split like: > > > * File 1: Boot CPU0 MM bringup (mmu/setup.c) > > > * File 2: Secondary CPUs MM bringup (mmu/smpboot.c) > > > * File 3: Page tables update.

Re: [RFC PATCH 3/3] automation/eclair: build docs/misra to address MISRA C:2012 Dir 4.1

On Mon, 21 Aug 2023, Nicola Vetrini wrote: > The documentation pertaining Directive 4.1 is contained in docs/misra. > The build script driving the analysis is amended to allow ECLAIR to > find it and thus resolving violations of the directive. > > Signed-off-by: Nicola Vetrini Acked-by: Stefano

Re: [PATCH v2] docs/misra: document gcc-specific behavior with shifting signed integers

On Tue, 22 Aug 2023, Julien Grall wrote: > Hi Stefano, > > On 22/08/2023 02:02, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > Signed-off-by: Stefano Stabellini > > --- > > v2: > > - split << and >> > > - do not use the word "shift" instead of << or >> > > --- > > docs/misra/C

Re: [PATCH v2] docs/misra: add exceptions to rules

On Tue, 22 Aug 2023, Jan Beulich wrote: > On 22.08.2023 03:30, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > During the discussions that led to the acceptable of the Rules, we > > Nit: acceptance > > > decided on a few exceptions that were not properly recorded in > > rules.rst

Re: [PATCH v2] docs/misra: add exceptions to rules

On Tue, 22 Aug 2023, Jan Beulich wrote: > On 22.08.2023 12:33, Julien Grall wrote: > > Hi Jan, > > > > On 22/08/2023 11:12, Jan Beulich wrote: > >> On 22.08.2023 09:56, Julien Grall wrote: > >>> On 22/08/2023 02:30, Stefano Stabellini wrote: > --- a/docs/misra/rules.rst > +++ b/docs/misr

[PATCH v4 3/3] xen/ppc: Implement initial Radix MMU support

Add code to construct early identity-mapped page tables as well as the required process and partition tables to enable the MMU. Signed-off-by: Shawn Anastasio --- v4: - (page.h) Drop *_SHIFT constants in page.h and include shift directly in corresponding *_MASK constant instead. - (regs.h

[PATCH v4 1/3] xen/ppc: Bump minimum target ISA to 3.0 (POWER9)

In preparation for implementing ISA3+ Radix MMU support, drop ISA 2.07B from the supported ISA list to avoid having a non-working configuration in tree. It can be re-added at a later point when Hash MMU support is added. Signed-off-by: Shawn Anastasio --- v4: no changes. v3: no changes. v2: no ch

[PATCH v4 2/3] xen/ppc: Relocate kernel to physical address 0 on boot

Introduce a small assembly loop in `start` to copy the kernel to physical address 0 before continuing. This ensures that the physical address lines up with XEN_VIRT_START (0xc000) and allows us to identity map the kernel when the MMU is set up in the next patch. We are also able to sta

[PATCH v4 0/3] xen/ppc: Add early Radix MMU support

Hello all, This series adds support for bringing up the Radix MMU with basic identity-mapped page tables. In order to simplify the memory layout, the series changes XEN_VIRT _START to 0xC000___, which has a couple of convenient properties. When the MMU is off, the top 4 address bits a

Re: [PATCH v3 3/3] xen/ppc: Implement initial Radix MMU support

On 8/14/23 8:27 AM, Jan Beulich wrote: > On 10.08.2023 00:48, Shawn Anastasio wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/page.h >> @@ -0,0 +1,181 @@ >> +#ifndef _ASM_PPC_PAGE_H >> +#define _ASM_PPC_PAGE_H >> + >> +#include >> + >> +#include >> +#include >> + >> +#define PDE_VALID

Re: [PATCH v3 2/3] xen/ppc: Relocate kernel to physical address 0 on boot

On 8/14/23 8:09 AM, Jan Beulich wrote: > On 10.08.2023 00:48, Shawn Anastasio wrote: >> --- a/xen/arch/ppc/ppc64/head.S >> +++ b/xen/arch/ppc/ppc64/head.S >> @@ -17,6 +17,33 @@ ENTRY(start) >> addis %r2, %r12, .TOC.-1b@ha >> addi%r2, %r2, .TOC.-1b@l >> >> +/* >> + * Copy Xen

Re: [XEN][PATCH v9 11/19] xen/iommu: Introduce iommu_remove_dt_device()

Hi, On 19/08/2023 01:28, Vikram Garhwal wrote: Remove master device from the IOMMU. This will be helpful when removing the overlay nodes using dynamic programming during run time. Signed-off-by: Vikram Garhwal Acked-by: Jan Beulich --- Changes from v7: Add check if IOMMU is enabled.

Re: [XEN][PATCH v9 10/19] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock

Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access to add/remove/assign/deassign. With addition of dynamic programming feature(follow-up patches in this series), Typo: missing space before '('. this function can b

Re: [XEN][PATCH v9 09/19] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller

Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: Rename iommu_dt_device_is_assigned() to iommu_dt_device_is_assigned_locked(). Remove static type so this can also be used by SMMU drivers to check if the device is being used before removing. I have commented on v8. But I will comment here

4.17 backports

Hello, Looking at the patchqueue, the following should be considered for backport: 19c6cbd90965 xen/vcpu: ignore VCPU_SSHOTTMR_future 0946068e7fae x86/head: check base address alignment eaa324bfebcf x86/trampoline: load the GDT located in the trampoline page aab4b38b5d77 xenalyze: Handle start-of

Re: [XEN][PATCH v9 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree

Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: Add device_tree_find_node_by_path() to find a matching node with path for a dt_device_node. Reason behind this function: Each time overlay nodes are added using .dtbo, a new fdt(memcpy of Typo: missing space before (. device_tr

Re: [XEN][PATCH v9 05/19] xen/arm: Add CONFIG_OVERLAY_DTB

Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: Introduce a config option where the user can enable support for adding/removing device tree nodes using a device tree binary overlay. Update SUPPORT.md and CHANGELOG.md to state the Device Tree Overlays support for Arm. Signed-off-by: Vikra

Re: [XEN][PATCH v9 01/19] common/device_tree: handle memory allocation failure in __unflatten_device_tree()

Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: Change __unflatten_device_tree() return type to integer so it can propagate memory allocation failure. Add panic() in dt_unflatten_host_device_tree() for memory allocation failure during boot. Fixes: fb97eb614acf ("xen/arm: Create a hierarch

Re: [XEN][PATCH v9 04/19] common/device_tree: Export __unflatten_device_tree()

Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: Following changes are done to __unflatten_device_tree(): 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). 2. Remove __init and static function type. The changes are done to make this function useable for dynamic

Re: [XEN][PATCH v9 03/19] xen/arm/device: Remove __init from function type

Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: Remove __init from following function to access during runtime: 1. map_irq_to_domain() 2. handle_device_interrupts() 3. map_range_to_domain() 4. unflatten_dt_node() We are at v9 now, so this is more a remark for the futu

[xen-unstable test] 182419: tolerable FAIL

flight 182419 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182419/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 28 guest-migrate/dst_host/src_host/debian.repeat fail in 182413 pass in 182419 te

Re: [XEN][PATCH v9 02/19] common/device_tree.c: unflatten_device_tree() propagate errors

Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: This will be useful in dynamic node programming when new dt nodes are unflattend during runtime. Invalid device tree node related errors should be propagated back to the caller. Signed-off-by: Vikram Garhwal --- Changes from v7: Free

Re: [PATCH v5 11/13] xen/arm: mmu: move MMU specific P2M code to mmu/p2m.{c,h}

Hi Henry, On 14/08/2023 05:25, Henry Wang wrote: From: Penny Zheng Current P2M implementation is designed for MMU system only. We move the MMU-specific codes into mmu/p2m.c, and only keep generic codes in p2m.c, like VMID allocator, etc. We also move MMU-specific definitions and declarations t

[RFC] network hotplug scripts - set qlen 1000 by default

Hello all, would it be useful and/or right to add ... ip link set dev ${dev} qlen 1000 ... to one of the hotplug scripts ? For now, all vifs are created with "qlen 32", but (most?) domUs use 1000 by default. I can propose the patch. I tested locally by putting : ip link set dev ${dev} ql

[xen-unstable-smoke test] 182421: tolerable all pass - PUSHED

flight 182421 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182421/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH 1/5] x86: Fix calculation of %dr6/7 reserved bits

On 8/22/23 23:54, Jan Beulich wrote: > But that's not the only change that was requested back then. There was > one aspect Andrew didn't like, so leaving that part as is would be > fine. But for the items he didn't further respond to, I'd expect a > re-submission to take care of them. Somehow I as

Re: [PATCH] docs/misra: add exceptions to rules

(re-adding xen-devel@) On 22.08.2023 17:09, Nicola Vetrini wrote: > + - Switch with a controlling value incompatible with labeled + statements >>> >>> What does this mean? >> >> I am not certain about this one actually. It could be when we have: >> >> switch (var) { >>

Re: [PATCH v1 57/57] xxxen/riscv: WIP ( need advise )

On Wed, 2023-08-16 at 13:20 +0300, Oleksii Kurochko wrote: > These changes are needed only to make GitLab CI happy is it doesn't > take into account tiny64_defconfig where unnecessary configs are > disabled. > > I tried different approaches to deal with it: > 1. Override EXTRA_XEN_CONFIG and EXTRA

Re: [PATCH v1 44/57] xen/riscv: introduce asm/vm_event.h

On Mon, 2023-08-21 at 18:43 +0200, Tamas K Lengyel wrote: > On Wed, Aug 16, 2023 at 12:30 PM Oleksii Kurochko > wrote: > > > > Signed-off-by: Oleksii Kurochko > > --- > >  xen/arch/riscv/include/asm/vm_event.h | 52 > > +++ > >  1 file changed, 52 insertions(+) > >  create

Re: [RFC PATCH 2/3] docs: make the docs for MISRA C:2012 Dir 4.1 visible to ECLAIR

On Mon, Aug 21, 2023 at 06:54:38PM +0200, Nicola Vetrini wrote: > diff --git a/docs/misra/Makefile b/docs/misra/Makefile > new file mode 100644 > index ..f62cd936bfcc > --- /dev/null > +++ b/docs/misra/Makefile > @@ -0,0 +1,36 @@ > +XEN_ROOT=$(CURDIR)/../.. > +include $(XEN_ROOT)/Config

Re: [PATCH v1 45/57] xen/riscv: add definition of __read_mostly

On Tue, 2023-08-22 at 08:22 +0200, Jan Beulich wrote: > I did already post a patch eliminating the need for this. It's just > that > Andrew doesn't like the new placement of the construct, yet neither > suggested a reasonable alternative nor showed willingness to accept > the > change as an interme

Re: [PATCH 1/5] x86: Fix calculation of %dr6/7 reserved bits

On 8/22/23 23:54, Jan Beulich wrote: > On 21.08.2023 18:12, Jinoh Kang wrote: >> On 8/22/23 00:56, Jinoh Kang wrote: >>> From: Andrew Cooper >>> >>> The reserved bit calculations for %dr6 and %dr7 depend on whether the VM has >>> the Restricted Transnational Memory feature available. >> >> s/Trans

Re: [PATCH] x86/AMD: extend Zenbleed check to models "good" ucode isn't known for

On 22.08.2023 16:53, Andrew Cooper wrote: > On 22/08/2023 3:22 pm, Jan Beulich wrote: >> Reportedly the AMD Custom APU 0405 found on SteamDeck, models 0x90 and >> 0x91, (quoting the respective Linux commit) is similarly affected. Put >> another instance of our Zen1 vs Zen2 distinction checks in >>

Re: [PATCH 0/5] Fixes to debugging facilities

On 8/22/23 15:16, Jan Beulich wrote: > One important formal question: Where did Andrew's S-o-b go on all of the > patches? Thanks for catching it. Looks like I confused the submission process with that of another (non-LF) project. I'll re-read the docs to see if I missed something else w.r.t. ta

Re: [PATCH 1/5] x86: Fix calculation of %dr6/7 reserved bits

On 21.08.2023 18:12, Jinoh Kang wrote: > On 8/22/23 00:56, Jinoh Kang wrote: >> From: Andrew Cooper >> >> The reserved bit calculations for %dr6 and %dr7 depend on whether the VM has >> the Restricted Transnational Memory feature available. > > s/Transnational/Transactional/. > > It was in the o

Re: [PATCH] x86/AMD: extend Zenbleed check to models "good" ucode isn't known for

On 22/08/2023 3:22 pm, Jan Beulich wrote: > Reportedly the AMD Custom APU 0405 found on SteamDeck, models 0x90 and > 0x91, (quoting the respective Linux commit) is similarly affected. Put > another instance of our Zen1 vs Zen2 distinction checks in > amd_check_zenbleed(), forcing use of the chicken

Re: [PATCH 3/5] x86/hvm: RFC - PROBABLY BROKEN - Defer all debugging/monitor actions to {svm,vmx}_inject_event()

On 8/22/23 01:34, Tamas K Lengyel wrote: > On Mon, Aug 21, 2023 at 5:57 PM Jinoh Kang wrote: >> This is RFC because it probably breaks introspection, as injection replies >> from the introspection engine will (probably, but I haven't confirmed) >> trigger >> new monitor events. >> >> First of all

[PATCH] build: restrict gcc11 workaround to versions earlier than 11.3.0

The fix for this issue was backported to 11.3, so let's not unduly engage the workaround. Signed-off-by: Jan Beulich --- a/xen/include/xen/compiler.h +++ b/xen/include/xen/compiler.h @@ -146,7 +146,8 @@ __asm__ ("" : "=r"(__ptr) : "0"(ptr)); \ (typeof(ptr)) (__ptr + (off)); }) -

Re: [RFC PATCH 2/3] docs: make the docs for MISRA C:2012 Dir 4.1 visible to ECLAIR

On Tue, Aug 22, 2023 at 12:10:28PM +0200, Jan Beulich wrote: > On 22.08.2023 10:27, Nicola Vetrini wrote: > >>> +C-runtime-failures.c: C-runtime-failures.rst > >>> +# sed is used in place of cat to prevent occurrences of '*/' > >>> +# in the .rst from breaking the compilation > >>> + ( \ > >>> +

[libvirt test] 182416: tolerable all pass - PUSHED

flight 182416 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182416/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182376 test-armhf-armhf-libvirt-qcow2 15 saveres

[PATCH] x86/AMD: extend Zenbleed check to models "good" ucode isn't known for

Reportedly the AMD Custom APU 0405 found on SteamDeck, models 0x90 and 0x91, (quoting the respective Linux commit) is similarly affected. Put another instance of our Zen1 vs Zen2 distinction checks in amd_check_zenbleed(), forcing use of the chickenbit irrespective of ucode version (building upon r

Re: [PATCH v4 43/48] drm/ttm: introduce pool_shrink_rwsem

On Mon, Aug 07, 2023 at 07:09:31PM +0800, Qi Zheng wrote: > Currently, the synchronize_shrinkers() is only used by TTM pool. It only > requires that no shrinkers run in parallel. > > After we use RCU+refcount method to implement the lockless slab shrink, > we can not use shrinker_rwsem or synchron

Re: [PATCH v3 4/4] xen/vpci: header: status register handler

On 22.08.2023 03:29, Stewart Hildebrand wrote: > Introduce a handler for the PCI status register, with ability to mask the > capabilities bit. The status register is write-1-to-clear, so introduce > handling > for this type of register in vPCI. > > Signed-off-by: Stewart Hildebrand > --- > v2->v

Re: [PATCH v3 3/4] xen/vpci: header: filter PCI capabilities

On 22.08.2023 03:29, Stewart Hildebrand wrote: > Currently, Xen vPCI only supports virtualizing the MSI and MSI-X capabilities. > Hide all other PCI capabilities (including extended capabilities) from domUs > for > now, even though there may be certain devices/drivers that depend on being > able

Re: [PATCH v4 5/6] libxl: use the cpuid feature names from cpufeatureset.h

On Tue, Aug 22, 2023 at 12:27:10PM +0200, Jan Beulich wrote: > On 25.07.2023 15:05, Roger Pau Monne wrote: > > {"invtsc", 0x8007, NA, CPUID_REG_EDX, 8, 1}, > > > > -{"clzero", 0x8008, NA, CPUID_REG_EBX, 0, 1}, > > -{"rstr-fp-err-ptrs", 0x8008,

Re: [PATCH] CI: Update FreeBSD to 12.4

On Tue, Aug 22, 2023 at 02:01:42PM +0100, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Thanks.

[PATCH] CI: Update FreeBSD to 12.4

Signed-off-by: Andrew Cooper --- CC: Roger Pau Monné CC: Anthony PERARD CC: Stefano Stabellini Example run: https://cirrus-ci.com/task/4911727880437760 --- .cirrus.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 9bb6cce4ead3..7e0beb20

Re: [PATCH v3 2/4] xen/pci: convert pci_find_*cap* to pci_sbdf_t

On 22.08.2023 03:29, Stewart Hildebrand wrote: > @@ -291,12 +291,9 @@ static void msi_set_enable(struct pci_dev *dev, int > enable) > static void msix_set_enable(struct pci_dev *dev, int enable) > { > int pos; > -u16 control, seg = dev->seg; > -u8 bus = dev->bus; > -u8 slot = PC

Re: [PATCH v2] docs/misra: add exceptions to rules

On 22.08.2023 12:33, Julien Grall wrote: > Hi Jan, > > On 22/08/2023 11:12, Jan Beulich wrote: >> On 22.08.2023 09:56, Julien Grall wrote: >>> On 22/08/2023 02:30, Stefano Stabellini wrote: --- a/docs/misra/rules.rst +++ b/docs/misra/rules.rst @@ -59,7 +59,8 @@ maintainers if you wa

Re: [PATCH v2] docs/misra: add exceptions to rules

Hi Jan, On 22/08/2023 11:12, Jan Beulich wrote: On 22.08.2023 09:56, Julien Grall wrote: On 22/08/2023 02:30, Stefano Stabellini wrote: --- a/docs/misra/rules.rst +++ b/docs/misra/rules.rst @@ -59,7 +59,8 @@ maintainers if you want to suggest a change. - Required - Precautions

Re: [PATCH v4 5/6] libxl: use the cpuid feature names from cpufeatureset.h

On 25.07.2023 15:05, Roger Pau Monne wrote: > {"invtsc", 0x8007, NA, CPUID_REG_EDX, 8, 1}, > > -{"clzero", 0x8008, NA, CPUID_REG_EBX, 0, 1}, > -{"rstr-fp-err-ptrs", 0x8008, NA, CPUID_REG_EBX, 2, 1}, > -{"wbnoinvd", 0x8008, NA, C

Re: [PATCH v3 1/5] build: make cc-option properly deal with unrecognized sub-options

On Wed, Aug 16, 2023 at 08:06:52AM +0200, Jan Beulich wrote: > On 11.08.2023 15:48, Anthony PERARD wrote: > > But isn't it doing doing pattern matching on an error message going to > > lead sometime to false positive? Linux's build system seems to works > > fine by just using the exit value. They'v

[xen-unstable-smoke test] 182417: tolerable all pass - PUSHED

flight 182417 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182417/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH V5] xen: privcmd: Add support for irqfd

On 22.08.23 11:45, Viresh Kumar wrote: Xen provides support for injecting interrupts to the guests via the HYPERVISOR_dm_op() hypercall. The same is used by the Virtio based device backend implementations, in an inefficient manner currently. Generally, the Virtio backends are implemented to work

Re: [PATCH v2] docs/misra: add exceptions to rules

On 22.08.2023 09:56, Julien Grall wrote: > On 22/08/2023 02:30, Stefano Stabellini wrote: >> --- a/docs/misra/rules.rst >> +++ b/docs/misra/rules.rst >> @@ -59,7 +59,8 @@ maintainers if you want to suggest a change. >>- Required >>- Precautions shall be taken in order to prevent the

Re: [RFC PATCH 2/3] docs: make the docs for MISRA C:2012 Dir 4.1 visible to ECLAIR

(Nicola, I'm sorry for the duplicate, but I didn't mean to drop xen-devel@.) On 22.08.2023 10:27, Nicola Vetrini wrote: >>> +C-runtime-failures.c: C-runtime-failures.rst >>> +# sed is used in place of cat to prevent occurrences of '*/' >>> +# in the .rst from breaking the compilation >>> + ( \ >

[linux-linus test] 182414: tolerable FAIL - PUSHED

flight 182414 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182414/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail in 182409 pass in 182414 test-amd64-amd64-dom0pvh-xl-intel

[PATCH V5] xen: privcmd: Add support for irqfd

Xen provides support for injecting interrupts to the guests via the HYPERVISOR_dm_op() hypercall. The same is used by the Virtio based device backend implementations, in an inefficient manner currently. Generally, the Virtio backends are implemented to work with the Eventfd based mechanism. In ord

[PATCH] xenbus: fix error exit in xenbus_init()

In case an error occurs in xenbus_init(), xen_store_domain_type should be set to XS_UNKNOWN. Fix one instance where this action is missing. Fixes: 5b3353949e89 ("xen: add support for initializing xenstore later as HVM domain") Reported-by: kernel test robot Reported-by: Dan Carpenter Link: htt

Re: [PATCH v3 0/8] Follow-up static shared memory PART I

Hi Penny, On 22/08/2023 07:32, Penny Zheng wrote: > > > Hi, michal > > On 2023/8/21 18:49, Michal Orzel wrote: >> Hi Penny, >> >> On 21/08/2023 06:00, Penny Zheng wrote: >>> >>> >>> There are some unsolving issues on current 4.17 static shared memory >>> feature[1], including: >>> - In order to

Re: [PATCH v5 13/13] xen/arm: mmu: enable SMMU subsystem only in MMU

On 22/08/2023 09:48, Henry Wang wrote: Hi Julien, On Aug 22, 2023, at 16:18, Julien Grall wrote: On 22/08/2023 03:11, Henry Wang wrote: Hi Julien, Hi, On Aug 22, 2023, at 05:34, Julien Grall wrote: Hi, On 14/08/2023 05:25, Henry Wang wrote: From: Penny Zheng SMMU subsystem is onl

Re: [PATCH v5 12/13] xen/arm: mmu: relocate copy_from_paddr() to setup.c

Hi Julien, > On Aug 22, 2023, at 16:42, Julien Grall wrote: > > On 22/08/2023 08:44, Henry Wang wrote: >>> On Aug 22, 2023, at 05:31, Julien Grall wrote: >>> >>> Hi, >>> >>> On 14/08/2023 05:25, Henry Wang wrote: From: Penny Zheng Function copy_from_paddr() is defined in asm/setup.

Re: [PATCH v5 13/13] xen/arm: mmu: enable SMMU subsystem only in MMU

Hi Julien, > On Aug 22, 2023, at 16:18, Julien Grall wrote: > > On 22/08/2023 03:11, Henry Wang wrote: >> Hi Julien, > > Hi, > >>> On Aug 22, 2023, at 05:34, Julien Grall wrote: >>> >>> Hi, >>> >>> On 14/08/2023 05:25, Henry Wang wrote: From: Penny Zheng SMMU subsystem is only su

[xen-unstable test] 182413: tolerable FAIL - PUSHED

flight 182413 xen-unstable real [real] flight 182418 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182413/ http://logs.test-lab.xenproject.org/osstest/logs/182418/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: [PATCH v5 12/13] xen/arm: mmu: relocate copy_from_paddr() to setup.c

On 22/08/2023 08:44, Henry Wang wrote: On Aug 22, 2023, at 05:31, Julien Grall wrote: Hi, On 14/08/2023 05:25, Henry Wang wrote: From: Penny Zheng Function copy_from_paddr() is defined in asm/setup.h, so it is better to be implemented in setup.c. I don't agree with this reasoning. We used

Re: [PATCH V4] xen: privcmd: Add support for irqfd

On 25.07.23 12:57, Viresh Kumar wrote: Xen provides support for injecting interrupts to the guests via the HYPERVISOR_dm_op() hypercall. The same is used by the Virtio based device backend implementations, in an inefficient manner currently. Generally, the Virtio backends are implemented to work

Re: [PATCH v5 13/13] xen/arm: mmu: enable SMMU subsystem only in MMU

On 22/08/2023 03:11, Henry Wang wrote: Hi Julien, Hi, On Aug 22, 2023, at 05:34, Julien Grall wrote: Hi, On 14/08/2023 05:25, Henry Wang wrote: From: Penny Zheng SMMU subsystem is only supported in MMU system, so we make it dependent on CONFIG_HAS_MMU. "only supported" as in it doesn't

Re: [PATCH v5 08/13] xen/arm: Fold pmap and fixmap into MMU system

Hi Julien, > On Aug 22, 2023, at 16:06, Julien Grall wrote: > > Hi, > > On 22/08/2023 03:42, Henry Wang wrote: >> diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c >> index 0d433a32e7..bc3e5bd6f9 100644 >> --- a/xen/arch/arm/kernel.c >> +++ b/xen/arch/arm/kernel.c >> @@ -16,7 +16,6 @@

Re: [PATCH v5 08/13] xen/arm: Fold pmap and fixmap into MMU system

Hi, On 22/08/2023 03:42, Henry Wang wrote: diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c index 0d433a32e7..bc3e5bd6f9 100644 --- a/xen/arch/arm/kernel.c +++ b/xen/arch/arm/kernel.c @@ -16,7 +16,6 @@ #include #include -#include #include #include ``` The changes in ker

Re: [PATCH v2] docs/misra: document gcc-specific behavior with shifting signed integers

Hi Stefano, On 22/08/2023 02:02, Stefano Stabellini wrote: From: Stefano Stabellini Signed-off-by: Stefano Stabellini --- v2: - split << and >> - do not use the word "shift" instead of << or >> --- docs/misra/C-language-toolchain.rst | 9 + 1 file changed, 9 insertions(+) diff --g

Re: [PATCH v3 0/8] Follow-up static shared memory PART I

Hi, michal On 2023/8/21 18:49, Michal Orzel wrote: Hi Penny, On 21/08/2023 06:00, Penny Zheng wrote: There are some unsolving issues on current 4.17 static shared memory feature[1], including: - In order to avoid keeping growing 'membank', having the shared memory info in separate structures

Re: [PATCH v2] docs/misra: add exceptions to rules

Hi Stefano, On 22/08/2023 02:30, Stefano Stabellini wrote: From: Stefano Stabellini During the discussions that led to the acceptable of the Rules, we decided on a few exceptions that were not properly recorded in rules.rst. Other times, the exceptions were decided later when it came to enabli

[PATCH v7] tools/xenstore: move xenstored sources into dedicated directory

In tools/xenstore there are living xenstored and xenstore clients. They are no longer sharing anything apart from the "xenstore" in their names. Move the xenstored sources into a new directory tools/xenstored while dropping the "xenstored_" prefix from their names. This will make it clearer that x

Re: [PATCH v5 12/13] xen/arm: mmu: relocate copy_from_paddr() to setup.c

Hi Julien, Stefano, Bertrand, > On Aug 22, 2023, at 05:31, Julien Grall wrote: > > Hi, > > On 14/08/2023 05:25, Henry Wang wrote: >> From: Penny Zheng >> Function copy_from_paddr() is defined in asm/setup.h, so it is better >> to be implemented in setup.c. > > I don't agree with this reasonin

Re: [PATCH v2] docs/misra: add exceptions to rules

On 22.08.2023 03:30, Stefano Stabellini wrote: > From: Stefano Stabellini > > During the discussions that led to the acceptable of the Rules, we Nit: acceptance > decided on a few exceptions that were not properly recorded in > rules.rst. Other times, the exceptions were decided later when it c