[linux-linus test] 182626: regressions - FAIL

flight 182626 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182626/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 182531 test-amd64-amd64-xl

Re: [PATCH] Arm: constrain {,u}int64_aligned_t in public header

Hi Jan, > On Sep 1, 2023, at 15:26, Jan Beulich wrote: > > This using a GNU extension, it may not be exposed in general, just like > is done on x86. External consumers need to make this type available up > front (just like we expect {,u}int_t to be supplied) - unlike on x86 > the type is actuall

Re: [PATCH 2/2] xen: Change parameter of generic_fls() to unsigned int

Hi Jan and Michal, > On Sep 4, 2023, at 23:13, Jan Beulich wrote: > > On 04.09.2023 16:03, Michal Orzel wrote: >> On 04/09/2023 15:28, Jan Beulich wrote: >>> On 04.09.2023 11:14, Michal Orzel wrote: --- a/xen/include/xen/bitops.h +++ b/xen/include/xen/bitops.h @@ -51,7 +51,7 @@ st

[linux-linus test] 182625: regressions - FAIL

flight 182625 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182625/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 182531 test-amd64-amd64-xl

[XEN PATCH v2] xen/arm: ioreq: add header for 'handle_ioserv' and 'try_fwd_ioserv'

The functions referenced by this patch should have had a compatible declaration visible prior to their definition. This is achieved by including the arch-specific header in 'xen/arch/arm/ioreq.c' Fixes: cb9953d2f2bc ("arm/ioreq: Introduce arch specific bits for IOREQ/DM features") Signed-off-by:

Re: [PATCH] Arm: constrain {,u}int64_aligned_t in public header

Hi Jan, > On 4 Sep 2023, at 17:20, Jan Beulich wrote: > > On 04.09.2023 16:05, Bertrand Marquis wrote: >>> On 4 Sep 2023, at 16:01, Jan Beulich wrote: >>> >>> On 04.09.2023 15:42, Bertrand Marquis wrote: > On 1 Sep 2023, at 09:26, Jan Beulich wrote: > > This using a GNU extension

Re: [PATCH] Arm: constrain {,u}int64_aligned_t in public header

On 04.09.2023 16:05, Bertrand Marquis wrote: >> On 4 Sep 2023, at 16:01, Jan Beulich wrote: >> >> On 04.09.2023 15:42, Bertrand Marquis wrote: On 1 Sep 2023, at 09:26, Jan Beulich wrote: This using a GNU extension, it may not be exposed in general, just like >>> >>> Nit: Missing "i

Re: [PATCH] xen/arm: ffa: fix guest map RX/TX error code

Hi Jens, > On 4 Sep 2023, at 16:58, Jens Wiklander wrote: > > FFA_RXTX_MAP is currently limited to mapping only one 4k page for each > RX and TX buffer. If a guest tries to map more than one page, an error > is returned. Until this patch, we have been using FFA_RET_NOT_SUPPORTED. > However, that

Re: [PATCH 2/2] xen: Change parameter of generic_fls() to unsigned int

On 04.09.2023 16:03, Michal Orzel wrote: > On 04/09/2023 15:28, Jan Beulich wrote: >> On 04.09.2023 11:14, Michal Orzel wrote: >>> --- a/xen/include/xen/bitops.h >>> +++ b/xen/include/xen/bitops.h >>> @@ -51,7 +51,7 @@ static inline int generic_ffs(int x) >>> * fls: find last bit set. >>> */ >>

[PATCH] xen/arm: ffa: fix guest map RX/TX error code

FFA_RXTX_MAP is currently limited to mapping only one 4k page for each RX and TX buffer. If a guest tries to map more than one page, an error is returned. Until this patch, we have been using FFA_RET_NOT_SUPPORTED. However, that error code is reserved in the FF-A specification to report that the fu

Re: [PATCH v1 2/2] xen/arm: Enlarge identity map space to 127TiB

Hi Bertrand, On Mon, Sep 04, 2023 at 01:55:12PM +, Bertrand Marquis wrote: > Hi Leo, > > > On 31 Aug 2023, at 13:01, Leo Yan wrote: > > > > On some platforms, the memory regions could be: > > > > (XEN) MODULE[0]: 0807f6df - 0807f6f3e000 Xen > > (XEN) MODULE[1]: 0807f80540

Re: [PATCH] Arm: constrain {,u}int64_aligned_t in public header

Hi Jan, > On 4 Sep 2023, at 16:01, Jan Beulich wrote: > > On 04.09.2023 15:42, Bertrand Marquis wrote: >>> On 1 Sep 2023, at 09:26, Jan Beulich wrote: >>> >>> This using a GNU extension, it may not be exposed in general, just like >> >> Nit: Missing "is" > > I would guess you would want it a

Re: [PATCH 2/2] xen: Change parameter of generic_fls() to unsigned int

On 04/09/2023 15:28, Jan Beulich wrote: > > > On 04.09.2023 11:14, Michal Orzel wrote: >> --- a/xen/include/xen/bitops.h >> +++ b/xen/include/xen/bitops.h >> @@ -51,7 +51,7 @@ static inline int generic_ffs(int x) >> * fls: find last bit set. >> */ >> >> -static __inline__ int generic_fls(i

Re: [PATCH] Arm: constrain {,u}int64_aligned_t in public header

On 04.09.2023 15:42, Bertrand Marquis wrote: >> On 1 Sep 2023, at 09:26, Jan Beulich wrote: >> >> This using a GNU extension, it may not be exposed in general, just like > > Nit: Missing "is" I would guess you would want it added as the 2nd word of the sentence. If not, please clarify where you

Re: [PATCH v1 1/2] xen/arm: Add macro XEN_VM_MAPPING

Hi Leo, > On 31 Aug 2023, at 13:01, Leo Yan wrote: > > Xen maps the virtual memory space starting from L0 slot 4, so it's open > coded for macros with the offset '4'. > > For more readable, add a new macro XEN_VM_MAPPING which defines the > start slot for Xen virtual memory mapping, and all vir

Re: [Xen-devel] [PATCH] x86/HVM: adjust hvm_interrupt_blocked()

On 31.08.2023 12:42, Roger Pau Monné wrote: > On Fri, Oct 12, 2018 at 09:58:46AM -0600, Jan Beulich wrote: >> First of all, hvm_intsrc_mce was not considered here at all, yet nothing >> blocks #MC (other than an already in-progress #MC, but dealing with this >> is not the purpose of this patch). >>

Re: [PATCH v1 2/2] xen/arm: Enlarge identity map space to 127TiB

Hi Leo, > On 31 Aug 2023, at 13:01, Leo Yan wrote: > > On some platforms, the memory regions could be: > > (XEN) MODULE[0]: 0807f6df - 0807f6f3e000 Xen > (XEN) MODULE[1]: 0807f8054000 - 0807f8056000 Device Tree > (XEN) MODULE[2]: fa834000 - fc5de1d5 Ramdis

Re: [PATCH] Arm: constrain {,u}int64_aligned_t in public header

Hi Jan, > On 1 Sep 2023, at 09:26, Jan Beulich wrote: > > This using a GNU extension, it may not be exposed in general, just like Nit: Missing "is" > is done on x86. External consumers need to make this type available up > front (just like we expect {,u}int_t to be supplied) - unlike on x86 >

Re: [Xen-devel] [PATCH] x86/HVM: adjust hvm_interrupt_blocked()

On 31.08.2023 12:57, Roger Pau Monné wrote: > On Thu, Aug 31, 2023 at 12:42:58PM +0200, Roger Pau Monné wrote: >> On Fri, Oct 12, 2018 at 09:58:46AM -0600, Jan Beulich wrote: >>> First of all, hvm_intsrc_mce was not considered here at all, yet nothing >>> blocks #MC (other than an already in-progre

Re: [PATCH v4 1/2] xen: asm-generic support

Hi Oleksii, > On 1 Sep 2023, at 18:02, Oleksii Kurochko wrote: > > Some headers are shared between individual architectures or are empty. > To avoid duplication of these headers, asm-generic is introduced. > > With the following patch, an architecture uses generic headers > mentioned in the fil

Re: [PATCH 2/2] xen: Change parameter of generic_fls() to unsigned int

On 04.09.2023 11:14, Michal Orzel wrote: > --- a/xen/include/xen/bitops.h > +++ b/xen/include/xen/bitops.h > @@ -51,7 +51,7 @@ static inline int generic_ffs(int x) > * fls: find last bit set. > */ > > -static __inline__ int generic_fls(int x) > +static __inline__ int generic_fls(unsigned int

Documentation survey

Hey everyone, Hope you've all had a good weekend! I know that documentation is an important part of The Xen Project, and I have received feedback from a number of users on this topic. Currently, there are some barriers to entry and improvements that can be made. In order to understand further, p

Re: [XEN PATCH 05/13] automation/eclair: add deviation for usercopy.c

> On 28 Aug 2023, at 23:27, Stefano Stabellini wrote: > > +Nicola, Luca > > On Mon, 28 Aug 2023, Simone Ballarin wrote: >> xen/arch/x86/usercopy.c includes itself, so it is not supposed to >> comply with Directive 4.10: >> "Precautions shall be taken in order to prevent the contents of a >> he

Re: xen-analysis ECLAIR support

> On 25 Aug 2023, at 22:56, Stefano Stabellini wrote: > > On Fri, 25 Aug 2023, Nicola Vetrini wrote: >> On 25/08/2023 00:24, Stefano Stabellini wrote: >>> Hi Luca, >>> >>> We are looking into adding ECLAIR support for xen-analysis so that we >>> can use the SAF-n-safe tags also with ECLAIR. >>

Re: xen-analysis ECLAIR support

> On 25 Aug 2023, at 09:28, Jan Beulich wrote: > > On 25.08.2023 10:18, Michal Orzel wrote: >> Hi Stefano, >> >> On 25/08/2023 00:24, Stefano Stabellini wrote: >>> >>> >>> Hi Luca, >>> >>> We are looking into adding ECLAIR support for xen-analysis so that we >>> can use the SAF-n-safe tags

Re: xen-analysis ECLAIR support

> On 25 Aug 2023, at 09:18, Michal Orzel wrote: > > Hi Stefano, > > On 25/08/2023 00:24, Stefano Stabellini wrote: >> >> >> Hi Luca, >> >> We are looking into adding ECLAIR support for xen-analysis so that we >> can use the SAF-n-safe tags also with ECLAIR. >> >> One question that came up

[linux-linus test] 182624: regressions - FAIL

flight 182624 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182624/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 182531 test-amd64-amd64-xl

Re: [PATCH 1/2] xen/arm: smmuv3: Add missing U for shifted constant

Hi Michal, > On 4 Sep 2023, at 11:14, Michal Orzel wrote: > > When running with SMMUv3 and UBSAN enabled, the following is printed: > > (XEN) UBSAN: Undefined behaviour in drivers/passthrough/arm/smmu-v3.c:297:12 > (XEN) left shift of 1 by 31 places cannot be represented in type 'int' > > This

Re: [XEN][PATCH v11 15/20] arm/asm/setup.h: Update struct map_range_data to add rangeset.

On 01/09/2023 06:59, Vikram Garhwal wrote: > Add rangesets for IRQs and IOMEMs. This was done to accommodate dynamic > overlay > node addition/removal operations. With overlay operations, new IRQs and IOMEMs > are added in dt_host and routed. While removing overlay nodes, nodes are > removed >

Re: [PATCH v4 2/2] xen: move arm/include/asm/vm_event.h to asm-generic

On Mon, 2023-09-04 at 08:54 +0200, Jan Beulich wrote: > On 01.09.2023 18:02, Oleksii Kurochko wrote: > > asm/vm_event.h is common for ARM and RISC-V so it will be moved to > > asm-generic dir. > > > > Original asm/vm_event.h from ARM was updated: > >  * use SPDX-License-Identifier. > >  * update c

Re: [PATCH v4 2/2] xen: move arm/include/asm/vm_event.h to asm-generic

On Mon, 2023-09-04 at 08:53 +0200, Jan Beulich wrote: > On 01.09.2023 19:14, Oleksii Kurochko wrote: > > The change which adds generic-y += vm_event.h to ARM's Kbuild was > > lost > > during creation of the patch. Should be added in the next patch > > version > > Which I guess is an indication tha

[xen-unstable test] 182623: tolerable FAIL

flight 182623 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182623/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail in 182620 pass in 182623 test-armhf-armhf-libvirt-qcow2 1

Re: [XEN][PATCH v11 14/20] common/device_tree: Add rwlock for dt_host

On 01/09/2023 06:59, Vikram Garhwal wrote: > Dynamic programming ops will modify the dt_host and there might be other > functions which are browsing the dt_host at the same time. To avoid the race > conditions, adding rwlock for browsing the dt_host during runtime. dt_host > writer will be added

Re: [XEN][PATCH v11 12/20] xen/smmu: Add remove_device callback for smmu_iommu ops

On 01/09/2023 06:59, Vikram Garhwal wrote: > Add remove_device callback for removing the device entry from smmu-master > using > following steps: > 1. Find if SMMU master exists for the device node. > 2. Check if device is currently in use. Just like in v10: you are not checking it. I asked you

Re: [XEN][PATCH v11 11/20] xen/iommu: Introduce iommu_remove_dt_device()

On 01/09/2023 06:59, Vikram Garhwal wrote: > Remove master device from the IOMMU. This will be helpful when removing the > overlay nodes using dynamic programming during run time. > > Signed-off-by: Vikram Garhwal > > --- > Changes from v10: > Add comment regarding return values of iommu_

Re: [PATCH] tools/misc/xencov_split: Add python 3 compatibility

Hi, On Mon, Sep 04, 2023 at 08:51:31AM +0200, Jan Beulich wrote: > On 02.09.2023 18:21, Javi Merino wrote: > > Closes #154 > > > > Signed-off-by: Javi Merino > > The title isn't really in line with ... > > > --- a/tools/misc/xencov_split > > +++ b/tools/misc/xencov_split > > @@ -1,5 +1,7 @@ >

[PATCH 1/2] xen/arm: smmuv3: Add missing U for shifted constant

When running with SMMUv3 and UBSAN enabled, the following is printed: (XEN) UBSAN: Undefined behaviour in drivers/passthrough/arm/smmu-v3.c:297:12 (XEN) left shift of 1 by 31 places cannot be represented in type 'int' This refers to shift in Q_OVERFLOW_FLAG that is missing 'U' suffix. While there

[PATCH 2/2] xen: Change parameter of generic_fls() to unsigned int

When running with SMMUv3 and UBSAN enabled on arm64, there are a lot of warnings printed related to shifting into sign bit in generic_fls() as it takes parameter of type int. Example: (XEN) UBSAN: Undefined behaviour in ./include/xen/bitops.h:69:11 (XEN) left shift of 134217728 by 4 places cannot

[PATCH 0/2] xen: fixes for UBSAN findings with SMMUv3 enabled

This series contains fixes for UBSAN findings reported when running with SMMUv3 enabled. Michal Orzel (2): xen/arm: smmuv3: Add missing U for shifted constant xen: Change parameter of generic_fls() to unsigned int xen/drivers/passthrough/arm/smmu-v3.h | 4 ++-- xen/include/xen/bitops.h

Re: [XEN PATCH 1/2] xen: apply deviation for Rule 8.4 (asm-only definitions)

On 04.09.2023 09:19, Nicola Vetrini wrote: > On 04/09/2023 09:02, Jan Beulich wrote: >> Further in the cover letter you say "Deviating variables needs more >> care, and >> is therefore postponed to another patch", yet then here you annotate a >> couple >> of variables as well. Could you clarify w

[PATCH v1] automation: add awk to opensuse images

Some awk binary is used in many places during build, make sure it is part of the image. Signed-off-by: Olaf Hering --- automation/build/suse/opensuse-leap.dockerfile | 1 + automation/build/suse/opensuse-tumbleweed.dockerfile | 1 + 2 files changed, 2 insertions(+) diff --git a/automation

Re: [XEN PATCH 1/2] xen: apply deviation for Rule 8.4 (asm-only definitions)

On 04/09/2023 09:02, Jan Beulich wrote: On 01.09.2023 18:34, Nicola Vetrini wrote: As stated in 'docs/misra/rules.rst' the functions that are used only by asm modules do not need to conform to MISRA C:2012 Rule 8.4. The deviations are carried out with a SAF comment. Signed-off-by: Nicola Vetri

Re: [XEN PATCH 1/2] xen: apply deviation for Rule 8.4 (asm-only definitions)

On 01.09.2023 18:34, Nicola Vetrini wrote: > As stated in 'docs/misra/rules.rst' the functions that are used only by > asm modules do not need to conform to MISRA C:2012 Rule 8.4. > The deviations are carried out with a SAF comment. > > Signed-off-by: Nicola Vetrini > --- > Where the identifier f