Re: [XEN][PATCH v12 20/20] tools/xl: Add new xl command overlay for device tree overlay support

2023-09-05 Thread Jan Beulich
On 06.09.2023 03:16, Vikram Garhwal wrote: > --- a/tools/xl/xl_vmcontrol.c > +++ b/tools/xl/xl_vmcontrol.c > @@ -1265,6 +1265,58 @@ int main_create(int argc, char **argv) > return 0; > } > > +int main_dt_overlay(int argc, char **argv) > +{ > +const char *overlay_ops = NULL; > +const

[xen-unstable test] 182632: tolerable FAIL - PUSHED

2023-09-05 Thread osstest service owner
flight 182632 xen-unstable real [real] flight 182643 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182632/ http://logs.test-lab.xenproject.org/osstest/logs/182643/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: [PATCH 2/2] xen/ppc: Drop support for pseries/OpenFirmware

2023-09-05 Thread Jan Beulich
On 05.09.2023 23:46, Shawn Anastasio wrote: > Since QEMU's PowerNV support has matured to the point where it is > now suitable for development, drop support for booting on the > paravirtualized pseries machine type and its associated interfaces. I think you want to mention that the pseries functio

Re: [XEN][PATCH v12 16/20] xen/arm: Implement device tree node removal functionalities

2023-09-05 Thread Jan Beulich
On 06.09.2023 03:16, Vikram Garhwal wrote: > --- a/xen/include/public/sysctl.h > +++ b/xen/include/public/sysctl.h > @@ -1185,6 +1185,25 @@ typedef struct xen_sysctl_cpu_policy > xen_sysctl_cpu_policy_t; > DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cpu_policy_t); > #endif > > +#if defined(__arm__) ||

Re: [XEN][PATCH v12 11/20] xen/iommu: Introduce iommu_remove_dt_device()

2023-09-05 Thread Jan Beulich
On 06.09.2023 03:16, Vikram Garhwal wrote: > Remove master device from the IOMMU. This will be helpful when removing the > overlay nodes using dynamic programming during run time. > > Signed-off-by: Vikram Garhwal > Reviewed-by: Michal Orzel > Acked-by: Stefano Stabellini Since apparently requ

Re: [XEN PATCH 12/13] xen: address violations of MISRA C:2012 Directive 4.10

2023-09-05 Thread Jan Beulich
On 06.09.2023 00:27, Stefano Stabellini wrote: > On Thu, 31 Aug 2023, Simone Ballarin wrote: >> On 29/08/23 00:51, Stefano Stabellini wrote: >>> On Mon, 28 Aug 2023, Simone Ballarin wrote: Move or amended inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions

Re: [XEN PATCH 09/13] xen/common: address violations of MISRA C:2012 Directive 4.10

2023-09-05 Thread Jan Beulich
On 06.09.2023 00:18, Stefano Stabellini wrote: > On Thu, 31 Aug 2023, Simone Ballarin wrote: >> On 31/08/23 15:05, Jan Beulich wrote: >>> On 31.08.2023 14:54, Simone Ballarin wrote: On 31/08/23 13:10, Jan Beulich wrote: > On 31.08.2023 12:08, Simone Ballarin wrote: >> The danger of mul

[xen-4.17-testing test] 182639: tolerable trouble: fail/pass/starved - PUSHED

2023-09-05 Thread osstest service owner
flight 182639 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/182639/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail like 182630 test-amd64-i386-xl-qemuu-win7-am

[xen-unstable-smoke test] 182641: regressions - FAIL

2023-09-05 Thread osstest service owner
flight 182641 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182641/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 182635 Tests which

Re: [PATCH 1/7] migration/rdma: Fix save_page method to fail on polling error

2023-09-05 Thread Zhijian Li (Fujitsu)
On 31/08/2023 21:25, Markus Armbruster wrote: > qemu_rdma_save_page() reports polling error with error_report(), then > succeeds anyway. This is because the variable holding the polling > status *shadows* the variable the function returns. The latter > remains zero. > > Broken since day one, a

[ovmf test] 182640: all pass - PUSHED

2023-09-05 Thread osstest service owner
flight 182640 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182640/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f008890ae55929f7f17e7d2f8aff929255007d33 baseline version: ovmf 8b66f9df1bb0fd5ebb743

Re: [QEMU PATCH v4 09/13] virtio-gpu: Handle resource blob commands

2023-09-05 Thread Akihiko Odaki
On 2023/09/06 12:09, Huang Rui wrote: On Tue, Sep 05, 2023 at 05:20:43PM +0800, Akihiko Odaki wrote: On 2023/09/05 18:08, Huang Rui wrote: On Thu, Aug 31, 2023 at 06:24:32PM +0800, Akihiko Odaki wrote: On 2023/08/31 18:32, Huang Rui wrote: From: Antonio Caggiano Support BLOB resources creat

Re: [QEMU PATCH v4 09/13] virtio-gpu: Handle resource blob commands

2023-09-05 Thread Huang Rui
On Tue, Sep 05, 2023 at 05:20:43PM +0800, Akihiko Odaki wrote: > On 2023/09/05 18:08, Huang Rui wrote: > > On Thu, Aug 31, 2023 at 06:24:32PM +0800, Akihiko Odaki wrote: > >> On 2023/08/31 18:32, Huang Rui wrote: > >>> From: Antonio Caggiano > >>> > >>> Support BLOB resources creation, mapping and

RE: [EXT] Re: xen arm64 low power sleep support

2023-09-05 Thread Stefano Stabellini
On Thu, 31 Aug 2023, Anthony Chan wrote: > On Thu, 30 Aug 2023, Stefano Stabellini wrote: > > On Wed, 30 Aug 2023, Anthony Chan wrote: > > > On Tue, 29 Aug 2023, Stefano Stabellini wrote: > > > > On Tue, 29 Aug 2023, Anthony Chan wrote: > > > > > Hi all, > > > > > > > > > > My name is Tony and I've

Re: [XEN][PATCH v12 17/20] xen/arm: Implement device tree node addition functionalities

2023-09-05 Thread Stefano Stabellini
On Tue, 5 Sep 2023, Vikram Garhwal wrote: > Update sysctl XEN_SYSCTL_dt_overlay to enable support for dtbo nodes addition > using device tree overlay. > > xl dt-overlay add file.dtbo: > Each time overlay nodes are added using .dtbo, a new fdt(memcpy of > device_tree_flattened) is created a

[XEN][PATCH v12 20/20] tools/xl: Add new xl command overlay for device tree overlay support

2023-09-05 Thread Vikram Garhwal
Signed-off-by: Vikram Garhwal Reviewed-by: Anthony PERARD --- tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c | 6 + tools/xl/xl_vmcontrol.c | 52 + 3 files changed, 59 insertions(+) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index 72538d6a81

[XEN][PATCH v12 15/20] arm/asm/setup.h: Update struct map_range_data to add rangeset.

2023-09-05 Thread Vikram Garhwal
Add rangesets for IRQs and IOMEMs. This was done to accommodate dynamic overlay node addition/removal operations. With overlay operations, new IRQs and IOMEMs are added in dt_host and routed. While removing overlay nodes, nodes are removed from dt_host and their IRQs and IOMEMs routing is also remo

Re: [XEN][PATCH v12 14/20] common/device_tree: Add rwlock for dt_host

2023-09-05 Thread Stefano Stabellini
On Tue, 5 Sep 2023, Vikram Garhwal wrote: > Dynamic programming ops will modify the dt_host and there might be other > functions which are browsing the dt_host at the same time. To avoid the race > conditions, adding rwlock for browsing the dt_host during runtime. dt_host > writer will be added in

[XEN][PATCH v12 12/20] xen/smmu: Add remove_device callback for smmu_iommu ops

2023-09-05 Thread Vikram Garhwal
Add remove_device callback for removing the device entry from smmu-master using following steps: 1. Find if SMMU master exists for the device node. 2. Check if device is currently in use. 3. Remove the SMMU master. Signed-off-by: Vikram Garhwal Acked-by: Stefano Stabellini --- Changes from v9:

[XEN][PATCH v12 19/20] tools/libs/light: Implement new libxl functions for device tree overlay ops

2023-09-05 Thread Vikram Garhwal
Signed-off-by: Vikram Garhwal Reviewed-by: Anthony PERARD --- tools/include/libxl.h | 11 + tools/libs/light/Makefile | 3 ++ tools/libs/light/libxl_dt_overlay.c | 71 + 3 files changed, 85 insertions(+) create mode 100644 tools/libs/ligh

[XEN][PATCH v12 18/20] tools/libs/ctrl: Implement new xc interfaces for dt overlay

2023-09-05 Thread Vikram Garhwal
xc_dt_overlay() sends the device tree binary overlay, size of .dtbo and overlay operation type i.e. add or remove to xen. Signed-off-by: Vikram Garhwal Reviewed-by: Anthony PERARD --- tools/include/xenctrl.h | 5 tools/libs/ctrl/Makefile.common | 1 + tools/libs/ctrl/xc_dt_overla

[XEN][PATCH v12 16/20] xen/arm: Implement device tree node removal functionalities

2023-09-05 Thread Vikram Garhwal
Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using device tree overlay. xl dt-overlay remove file.dtbo: Removes all the nodes in a given dtbo. First, removes IRQ permissions and MMIO accesses. Next, it finds the nodes in dt_host and delete the device node en

[XEN][PATCH v12 17/20] xen/arm: Implement device tree node addition functionalities

2023-09-05 Thread Vikram Garhwal
Update sysctl XEN_SYSCTL_dt_overlay to enable support for dtbo nodes addition using device tree overlay. xl dt-overlay add file.dtbo: Each time overlay nodes are added using .dtbo, a new fdt(memcpy of device_tree_flattened) is created and updated with overlay nodes. This updated fdt is

[XEN][PATCH v12 11/20] xen/iommu: Introduce iommu_remove_dt_device()

2023-09-05 Thread Vikram Garhwal
Remove master device from the IOMMU. This will be helpful when removing the overlay nodes using dynamic programming during run time. Signed-off-by: Vikram Garhwal Reviewed-by: Michal Orzel Acked-by: Stefano Stabellini --- Changes from v10: Add comment regarding return values of iommu_remove

[XEN][PATCH v12 14/20] common/device_tree: Add rwlock for dt_host

2023-09-05 Thread Vikram Garhwal
Dynamic programming ops will modify the dt_host and there might be other functions which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing the dt_host during runtime. dt_host writer will be added in the follow-up patch for device tree overlay functi

[XEN][PATCH v12 07/20] libfdt: overlay: change overlay_get_target()

2023-09-05 Thread Vikram Garhwal
Rename overlay_get_target() to fdt_overlay_target_offset() and remove static function type. This is done to get the target path for the overlay nodes which is very useful in many cases. For example, Xen hypervisor needs it when applying overlays because Xen needs to do further processing of the ov

[XEN][PATCH v12 13/20] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h

2023-09-05 Thread Vikram Garhwal
Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, we will need to add a rwlock to protect access to the dt_host. However, adding rwlock in device_tree.h causes following circular dependenc

[XEN][PATCH v12 04/20] common/device_tree: Export __unflatten_device_tree()

2023-09-05 Thread Vikram Garhwal
Following changes are done to __unflatten_device_tree(): 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). 2. Remove __init and static function type. The changes are done to make this function useable for dynamic node programming where new device tree overlay nodes are ad

[XEN][PATCH v12 05/20] xen/arm: Add CONFIG_OVERLAY_DTB

2023-09-05 Thread Vikram Garhwal
Introduce a config option where the user can enable support for adding/removing device tree nodes using a device tree binary overlay. Update SUPPORT.md and CHANGELOG.md to state the Device Tree Overlays support for Arm. Signed-off-by: Vikram Garhwal Acked-by: Henry Wang Reviewed-by: Michal Orze

[XEN][PATCH v12 06/20] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB.

2023-09-05 Thread Vikram Garhwal
This is done to access fdt library function which are required for adding device tree overlay nodes for dynamic programming of nodes. Signed-off-by: Vikram Garhwal Acked-by: Julien Grall --- xen/common/libfdt/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/xen/common/libfdt/Mak

[XEN][PATCH v12 08/20] xen/device-tree: Add dt_find_node_by_path_from() to find nodes in device tree

2023-09-05 Thread Vikram Garhwal
Add dt_find_node_by_path_from() to find a matching node with path for a dt_device_node. Reason behind this function: Each time overlay nodes are added using .dtbo, a new fdt (memcpy of device_tree_flattened) is created and updated with overlay nodes. This updated fdt is further unflatt

[XEN][PATCH v12 10/20] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock

2023-09-05 Thread Vikram Garhwal
Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access to add/remove/assign/deassign. With addition of dynamic programming feature(follow-up patches in this series), this function can be concurrently accessed by dynamic node add/remove using device tree overlays. Signed-off-by

[XEN][PATCH v12 02/20] common/device_tree.c: unflatten_device_tree() propagate errors

2023-09-05 Thread Vikram Garhwal
This will be useful in dynamic node programming when new dt nodes are unflattend during runtime. Invalid device tree node related errors should be propagated back to the caller. Signed-off-by: Vikram Garhwal Reviewed-by: Michal Orzel Acked-by: Stefano Stabellini --- Changes from v9: Replac

[XEN][PATCH v12 09/20] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller

2023-09-05 Thread Vikram Garhwal
Rename iommu_dt_device_is_assigned() to iommu_dt_device_is_assigned_locked(). Moving spin_lock to caller was done to prevent the concurrent access to iommu_dt_device_is_assigned while doing add/remove/assign/deassign. Follow-up patches in this series introduces node add/remove feature. Signed-off

[XEN][PATCH v12 01/20] common/device_tree: handle memory allocation failure in __unflatten_device_tree()

2023-09-05 Thread Vikram Garhwal
Change __unflatten_device_tree() return type to integer so it can propagate memory allocation failure. Add panic() in dt_unflatten_host_device_tree() for memory allocation failure during boot. Fixes: fb97eb614acf ("xen/arm: Create a hierarchical device tree") Signed-off-by: Vikram Garhwal Reviewe

[XEN][PATCH v12 00/20] dynamic node programming using overlay dtbo

2023-09-05 Thread Vikram Garhwal
Hi, This patch series is for introducing dynamic programming i.e. add/remove the devices during run time. Using "xl dt_overlay" a device can be added/removed with dtbo. For adding a node using dynamic programming: 1. flatten device tree overlay node will be added to a fdt 2. Updated fdt wi

[XEN][PATCH v12 03/20] xen/arm/device: Remove __init from function type

2023-09-05 Thread Vikram Garhwal
Remove __init from following function to access during runtime: 1. map_irq_to_domain() 2. handle_device_interrupts() 3. map_range_to_domain() 4. unflatten_dt_node() 5. handle_device() 6. map_device_children() 7. map_dt_irq_to_domain() Move map_irq_to_domain() prototype f

Re: [XEN][PATCH v11 14/20] common/device_tree: Add rwlock for dt_host

2023-09-05 Thread Stefano Stabellini
On Mon, 4 Sep 2023, Michal Orzel wrote: > On 01/09/2023 06:59, Vikram Garhwal wrote: > > Dynamic programming ops will modify the dt_host and there might be other > > functions which are browsing the dt_host at the same time. To avoid the race > > conditions, adding rwlock for browsing the dt_host d

Re: [XEN][PATCH v11 17/20] xen/arm: Implement device tree node addition functionalities

2023-09-05 Thread Stefano Stabellini
On Thu, 31 Aug 2023, Vikram Garhwal wrote: > Update sysctl XEN_SYSCTL_dt_overlay to enable support for dtbo nodes addition > using device tree overlay. > > xl dt-overlay add file.dtbo: > Each time overlay nodes are added using .dtbo, a new fdt(memcpy of > device_tree_flattened) is created

Re: [XEN][PATCH v11 16/20] xen/arm: Implement device tree node removal functionalities

2023-09-05 Thread Stefano Stabellini
On Thu, 31 Aug 2023, Vikram Garhwal wrote: > Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using > device tree overlay. > > xl dt-overlay remove file.dtbo: > Removes all the nodes in a given dtbo. > First, removes IRQ permissions and MMIO accesses. Next, it finds

Re: [XEN][PATCH v11 15/20] arm/asm/setup.h: Update struct map_range_data to add rangeset.

2023-09-05 Thread Stefano Stabellini
On Mon, 4 Sep 2023, Michal Orzel wrote: > On 01/09/2023 06:59, Vikram Garhwal wrote: > > Add rangesets for IRQs and IOMEMs. This was done to accommodate dynamic > > overlay > > node addition/removal operations. With overlay operations, new IRQs and > > IOMEMs > > are added in dt_host and routed.

Re: [XEN][PATCH v11 12/20] xen/smmu: Add remove_device callback for smmu_iommu ops

2023-09-05 Thread Stefano Stabellini
On Mon, 4 Sep 2023, Michal Orzel wrote: > On 01/09/2023 06:59, Vikram Garhwal wrote: > > Add remove_device callback for removing the device entry from smmu-master > > using > > following steps: > > 1. Find if SMMU master exists for the device node. > > 2. Check if device is currently in use. > Jus

Re: [XEN][PATCH v11 11/20] xen/iommu: Introduce iommu_remove_dt_device()

2023-09-05 Thread Stefano Stabellini
On Mon, 4 Sep 2023, Michal Orzel wrote: > On 01/09/2023 06:59, Vikram Garhwal wrote: > > Remove master device from the IOMMU. This will be helpful when removing the > > overlay nodes using dynamic programming during run time. > > > > Signed-off-by: Vikram Garhwal > > > > --- > > Changes from v10

Re: [XEN][PATCH v11 10/20] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock

2023-09-05 Thread Stefano Stabellini
On Thu, 31 Aug 2023, Vikram Garhwal wrote: > Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access > to add/remove/assign/deassign. > With addition of dynamic programming feature(follow-up patches in this > series), > this function can be concurrently accessed by dynamic node

Re: [XEN][PATCH v11 09/20] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller

2023-09-05 Thread Stefano Stabellini
On Thu, 31 Aug 2023, Vikram Garhwal wrote: > Rename iommu_dt_device_is_assigned() to iommu_dt_device_is_assigned_locked(). > > Moving spin_lock to caller was done to prevent the concurrent access to > iommu_dt_device_is_assigned while doing add/remove/assign/deassign. Follow-up > patches in this s

Re: [XEN][PATCH v11 05/20] xen/arm: Add CONFIG_OVERLAY_DTB

2023-09-05 Thread Stefano Stabellini
On Thu, 31 Aug 2023, Vikram Garhwal wrote: > Introduce a config option where the user can enable support for > adding/removing > device tree nodes using a device tree binary overlay. > > Update SUPPORT.md and CHANGELOG.md to state the Device Tree Overlays support > for > Arm. > > Signed-off-by:

Re: [XEN][PATCH v11 03/20] xen/arm/device: Remove __init from function type

2023-09-05 Thread Stefano Stabellini
On Thu, 31 Aug 2023, Vikram Garhwal wrote: > Remove __init from following function to access during runtime: > 1. map_irq_to_domain() > 2. handle_device_interrupts() > 3. map_range_to_domain() > 4. unflatten_dt_node() > 5. handle_device() > 6. map_device_children() > 7.

Re: [XEN PATCH 12/13] xen: address violations of MISRA C:2012 Directive 4.10

2023-09-05 Thread Stefano Stabellini
On Thu, 31 Aug 2023, Simone Ballarin wrote: > On 29/08/23 00:51, Stefano Stabellini wrote: > > On Mon, 28 Aug 2023, Simone Ballarin wrote: > > > Move or amended inclusion guards to address violations of > > > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order > > > to prevent the con

[xen-4.17-testing test] 182630: tolerable FAIL - PUSHED

2023-09-05 Thread osstest service owner
flight 182630 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/182630/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail like 182427 test-armhf-armhf-libvirt 16

Re: [XEN PATCH 09/13] xen/common: address violations of MISRA C:2012 Directive 4.10

2023-09-05 Thread Stefano Stabellini
On Thu, 31 Aug 2023, Simone Ballarin wrote: > On 31/08/23 15:05, Jan Beulich wrote: > > On 31.08.2023 14:54, Simone Ballarin wrote: > > > On 31/08/23 13:10, Jan Beulich wrote: > > > > On 31.08.2023 12:08, Simone Ballarin wrote: > > > > > The danger of multi-inclusion also exists for .c files, why d

[ovmf test] 182636: all pass - PUSHED

2023-09-05 Thread osstest service owner
flight 182636 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182636/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8b66f9df1bb0fd5ebb743944d41cb33178cf2fdd baseline version: ovmf dfb941d32a2f38c917772

Re: [PATCH v3 0/5] ppc: Enable full Xen build

2023-09-05 Thread Shawn Anastasio
On 9/5/23 4:02 PM, Shawn Anastasio wrote: > On 9/5/23 11:07 AM, Jan Beulich wrote: >> On 01.09.2023 20:25, Shawn Anastasio wrote: >> Another thing I wanted to ask: Would it be possible to configure >> whatever mail client you use for sending patches to send plain ASCII or >> UTF-8 text, not quoted-

[PATCH 1/2] automation: Switch ppc64le tests to PowerNV machine type

2023-09-05 Thread Shawn Anastasio
Run ppc64le tests with the PowerNV machine type (bare metal) instead of the paravirtualized pseries machine. This requires a more modern version of QEMU than is present in debian bullseye's repository, so update the dockerfile to build QEMU from source. Signed-off-by: Shawn Anastasio --- .../bui

[PATCH 2/2] xen/ppc: Drop support for pseries/OpenFirmware

2023-09-05 Thread Shawn Anastasio
Since QEMU's PowerNV support has matured to the point where it is now suitable for development, drop support for booting on the paravirtualized pseries machine type and its associated interfaces. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/Makefile | 1 - xen/arch/ppc/boot-of.c

[PATCH 0/2] ppc: Drop support for QEMU pseries

2023-09-05 Thread Shawn Anastasio
Hello all, This small series drops support for the QEMU paravirtualized pseries machine type in favor of the bare metal PowerNV platform. pseries was originally targeted for initial bringup since it has historically been much better supported by QEMU, but PowerNV support in QEMU has recently deve

Re: [PATCH v3 0/5] ppc: Enable full Xen build

2023-09-05 Thread Shawn Anastasio
On 9/5/23 11:07 AM, Jan Beulich wrote: > On 01.09.2023 20:25, Shawn Anastasio wrote: >> Hello all, >> >> This patch series performs all of the additions necessary to drop the >> build overrides for PPC and enable the full Xen build. Except in cases >> where compatibile implementations already exist

[PATCH v2] tools/misc/xencov_split: Add python 3 compatibility

2023-09-05 Thread Javi Merino
Closes #154 Signed-off-by: Javi Merino --- Changes since v1: - Don't touch the shebang. tools/misc/xencov_split | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tools/misc/xencov_split b/tools/misc/xencov_split index e4f68ebb6e..a921e8ef44 100755 --- a/tool

Re: [PATCH v4 3/3] xen/ppc: Implement initial Radix MMU support

2023-09-05 Thread Shawn Anastasio
On 9/5/23 5:01 AM, Jan Beulich wrote: > On 23.08.2023 01:03, Shawn Anastasio wrote: >> Add code to construct early identity-mapped page tables as well as the >> required process and partition tables to enable the MMU. >> >> Signed-off-by: Shawn Anastasio > > Having committed this, something broke

[xen-unstable-smoke test] 182635: tolerable all pass - PUSHED

2023-09-05 Thread osstest service owner
flight 182635 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182635/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[libvirt test] 182629: tolerable all pass - PUSHED

2023-09-05 Thread osstest service owner
flight 182629 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182629/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182611 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [PATCH v3 0/5] ppc: Enable full Xen build

2023-09-05 Thread Jan Beulich
On 01.09.2023 20:25, Shawn Anastasio wrote: > Hello all, > > This patch series performs all of the additions necessary to drop the > build overrides for PPC and enable the full Xen build. Except in cases > where compatibile implementations already exist (e.g. atomic.h and > bitops.h), the newly ad

Re: [PATCH v3 1/5] xen/ppc: Implement atomic.h

2023-09-05 Thread Jan Beulich
On 05.09.2023 16:58, Jan Beulich wrote: > On 01.09.2023 20:25, Shawn Anastasio wrote: >> +static inline atomic_t atomic_compareandswap(atomic_t old, atomic_t new, >> + atomic_t *v) >> +{ >> +atomic_t rc; >> +rc.counter = __cmpxchg(&v->counter, old

Re: [PATCH v3 3/5] xen/ppc: Define minimal stub headers required for full build

2023-09-05 Thread Jan Beulich
On 01.09.2023 20:25, Shawn Anastasio wrote: > --- /dev/null > +++ b/xen/arch/ppc/include/asm/device.h > @@ -0,0 +1,53 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef __ASM_PPC_DEVICE_H__ > +#define __ASM_PPC_DEVICE_H__ > + > +enum device_type > +{ > +DEV_DT, > +DEV_PCI, > +}; >

Re: [XEN][PATCH v11 14/20] common/device_tree: Add rwlock for dt_host

2023-09-05 Thread Vikram Garhwal
Hi, On Mon, Sep 04, 2023 at 01:09:52PM +0200, Michal Orzel wrote: > > > On 01/09/2023 06:59, Vikram Garhwal wrote: > > Dynamic programming ops will modify the dt_host and there might be other > > functions which are browsing the dt_host at the same time. To avoid the race > > conditions, adding r

Re: [XEN][PATCH v11 12/20] xen/smmu: Add remove_device callback for smmu_iommu ops

2023-09-05 Thread Vikram Garhwal
Hi Michal, On Mon, Sep 04, 2023 at 12:38:01PM +0200, Michal Orzel wrote: > > > On 01/09/2023 06:59, Vikram Garhwal wrote: > > Add remove_device callback for removing the device entry from smmu-master > > using > > following steps: > > 1. Find if SMMU master exists for the device node. > > 2. Ch

Re: [PATCH v3 2/5] xen/ppc: Implement bitops.h

2023-09-05 Thread Jan Beulich
On 01.09.2023 20:25, Shawn Anastasio wrote: > Implement bitops.h, based on Linux's implementation as of commit > 5321d1b1afb9a17302c6cec79f0cbf823eb0d3fc. Though it is based off of > Linux's implementation, this code diverges significantly in a number of > ways: > - Bitmap entries changed to 32-b

Re: [PATCH v3 1/5] xen/ppc: Implement atomic.h

2023-09-05 Thread Jan Beulich
On 01.09.2023 20:25, Shawn Anastasio wrote: > +static inline atomic_t atomic_compareandswap(atomic_t old, atomic_t new, > + atomic_t *v) > +{ > +atomic_t rc; > +rc.counter = __cmpxchg(&v->counter, old.counter, new.counter, > sizeof(int)); I can'

Re: [XEN PATCH v3] drivers/video: make declarations of defined functions available

2023-09-05 Thread Jan Beulich
On 01.09.2023 09:02, Nicola Vetrini wrote: > The declarations for 'vesa_{init,early_init,endboot}' needed by > 'xen/drivers/video/vesa.c' and 'fill_console_start_info' in 'vga.c' > are now available by moving the relative code inside 'vga.h'. > > While moving the code, the alternative definitions

[linux-linus test] 182628: regressions - FAIL

2023-09-05 Thread osstest service owner
flight 182628 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182628/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 182531 test-amd64-amd64-xl

Re: [PATCH v4 1/2] xen: asm-generic support

2023-09-05 Thread Bertrand Marquis
Hi Oleksii, > On 5 Sep 2023, at 15:37, Oleksii wrote: > > Hi Bertrand, > > On Mon, 2023-09-04 at 13:39 +, Bertrand Marquis wrote: >> Hi Oleksii, >> >>> On 1 Sep 2023, at 18:02, Oleksii Kurochko >>> wrote: >>> >>> Some headers are shared between individual architectures or are >>> empty.

Re: [PATCH v4 1/2] xen: asm-generic support

2023-09-05 Thread Oleksii
Hi Bertrand, On Mon, 2023-09-04 at 13:39 +, Bertrand Marquis wrote: > Hi Oleksii, > > > On 1 Sep 2023, at 18:02, Oleksii Kurochko > > wrote: > > > > Some headers are shared between individual architectures or are > > empty. > > To avoid duplication of these headers, asm-generic is introduce

Re: [QEMU PATCH v4 07/13] softmmu/memory: enable automatic deallocation of memory regions

2023-09-05 Thread Huang Rui
On Tue, Sep 05, 2023 at 05:17:32PM +0800, Akihiko Odaki wrote: > On 2023/09/05 18:07, Huang Rui wrote: > > On Thu, Aug 31, 2023 at 06:10:08PM +0800, Akihiko Odaki wrote: > >> On 2023/08/31 18:32, Huang Rui wrote: > >>> From: Xenia Ragiadakou > >>> > >>> When the memory region has a different life-

Re: [PATCH v4 0/3] sysemu/accel: Simplify sysemu/xen.h

2023-09-05 Thread Philippe Mathieu-Daudé
On 5/9/23 14:20, Philippe Mathieu-Daudé wrote: Trivial cleanups which simplify "sysemu/xen.h". Philippe Mathieu-Daudé (3): sysemu/xen: Remove unuseful CONFIG_USER_ONLY header guard sysemu/xen: Remove unreachable xen_ram_alloc() code sysemu/xen: Allow elision of xen_hvm_modified_memory()

[PATCH 3/3] sysemu/xen: Allow elision of xen_hvm_modified_memory()

2023-09-05 Thread Philippe Mathieu-Daudé
Call xen_enabled() before xen_hvm_modified_memory() to let the compiler elide its call. Have xen_enabled() return a boolean to match its declaration in the CONFIG_XEN_IS_POSSIBLE case. Suggested-by: Daniel Henrique Barboza Signed-off-by: Philippe Mathieu-Daudé --- include/exec/ram_addr.h | 8

[PATCH 2/3] sysemu/xen: Remove unreachable xen_ram_alloc() code

2023-09-05 Thread Philippe Mathieu-Daudé
The xen_ram_alloc() call in softmmu/physmem.c is guarded by checking for xen_enabled(), which evaluate to 'false' when XEN is not built in. The compiler elide the function call, and thus the inlined function is not used. Remove it. Inspired-by: Daniel Henrique Barboza Signed-off-by: Philippe Math

[PATCH 1/3] sysemu/xen: Remove unuseful CONFIG_USER_ONLY header guard

2023-09-05 Thread Philippe Mathieu-Daudé
In commit da278d58a0 ("accel: Move Xen accelerator code under accel/xen/") we used include/sysemu/kvm.h as a template for include/sysemu/xen.h, using the CONFIG_USER_ONLY header guard. In retrospective, it is not used / useful, so remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/syse

[PATCH 0/3] sysemu/accel: Simplify sysemu/xen.h

2023-09-05 Thread Philippe Mathieu-Daudé
Trivial cleanups which simplify "sysemu/xen.h". Philippe Mathieu-Daudé (3): sysemu/xen: Remove unuseful CONFIG_USER_ONLY header guard sysemu/xen: Remove unreachable xen_ram_alloc() code sysemu/xen: Allow elision of xen_hvm_modified_memory() include/exec/ram_addr.h | 8 ++-- include/sy

[PATCH v4 0/3] sysemu/accel: Simplify sysemu/xen.h

2023-09-05 Thread Philippe Mathieu-Daudé
Trivial cleanups which simplify "sysemu/xen.h". Philippe Mathieu-Daudé (3): sysemu/xen: Remove unuseful CONFIG_USER_ONLY header guard sysemu/xen: Remove unreachable xen_ram_alloc() code sysemu/xen: Allow elision of xen_hvm_modified_memory() include/exec/ram_addr.h | 8 ++-- include/sy

Xen Security Advisory 437 v2 (CVE-2023-34321) - arm32: The cache may not be properly cleaned/invalidated

2023-09-05 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2023-34321 / XSA-437 version 2 arm32: The cache may not be properly cleaned/invalidated UPDATES IN VERSION 2 Public release. ISSUE DESCRIPTION =

[xen-unstable-smoke test] 182631: tolerable all pass - PUSHED

2023-09-05 Thread osstest service owner
flight 182631 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182631/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH] x86/HVM: adjust hvm_interrupt_blocked()

2023-09-05 Thread Roger Pau Monné
On Mon, Sep 04, 2023 at 03:40:46PM +0200, Jan Beulich wrote: > On 31.08.2023 12:57, Roger Pau Monné wrote: > > On Thu, Aug 31, 2023 at 12:42:58PM +0200, Roger Pau Monné wrote: > >> On Fri, Oct 12, 2018 at 09:58:46AM -0600, Jan Beulich wrote: > >>> First of all, hvm_intsrc_mce was not considered her

[xen-unstable test] 182627: trouble: broken/fail/pass

2023-09-05 Thread osstest service owner
flight 182627 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182627/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 broken Tests whic

Re: QEMU features useful for Xen development?

2023-09-05 Thread Alex Bennée
Ayan Kumar Halder writes: > Hi Peter/Alex, > > Appreciate your help. :) > > On 31/08/2023 11:03, Peter Maydell wrote: >> On Thu, 31 Aug 2023 at 10:53, Alex Bennée wrote: >>> >>> Peter Maydell writes: >>> On Thu, 31 Aug 2023 at 01:57, Stefano Stabellini wrote: > As Xen is gaini

Re: [PATCH v4 3/3] xen/ppc: Implement initial Radix MMU support

2023-09-05 Thread Jan Beulich
On 23.08.2023 01:03, Shawn Anastasio wrote: > Add code to construct early identity-mapped page tables as well as the > required process and partition tables to enable the MMU. > > Signed-off-by: Shawn Anastasio Having committed this, something broke in CI. As per the artifacts of https://gitlab.

Re: [PATCH v1 net] page_pool: Cap queue size to 32k.

2023-09-05 Thread Dan Carpenter
On Mon, Aug 14, 2023 at 11:34:11AM +0530, Ratheesh Kannoth wrote: > Clamp to 32k instead of returning error. What is the motivation here? What is the real world impact for the users? > > Please find discussion at > https://lore.kernel.org/lkml/ > CY4PR1801MB1911E15D518A77535F6E51E2D308A@CY4PR18

Re: [PATCH v2] Arm: constrain {,u}int64_aligned_t in public header

2023-09-05 Thread Henry Wang
Hi Jan, > On Sep 5, 2023, at 16:26, Jan Beulich wrote: > > For using a GNU extension, it may not be exposed in general, just like > is done on x86 (except that here we need to also work around not all of > the tool stack actually defining __XEN_TOOLS__). External consumers (not > using gcc or a

Re: [QEMU PATCH v4 09/13] virtio-gpu: Handle resource blob commands

2023-09-05 Thread Akihiko Odaki
On 2023/09/05 18:08, Huang Rui wrote: On Thu, Aug 31, 2023 at 06:24:32PM +0800, Akihiko Odaki wrote: On 2023/08/31 18:32, Huang Rui wrote: From: Antonio Caggiano Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when av

Re: [QEMU PATCH v4 07/13] softmmu/memory: enable automatic deallocation of memory regions

2023-09-05 Thread Akihiko Odaki
On 2023/09/05 18:07, Huang Rui wrote: On Thu, Aug 31, 2023 at 06:10:08PM +0800, Akihiko Odaki wrote: On 2023/08/31 18:32, Huang Rui wrote: From: Xenia Ragiadakou When the memory region has a different life-cycle from that of her parent, could be automatically released, once has been unparent

[PATCH] x86/PV: consolidate LDT checks

2023-09-05 Thread Jan Beulich
Consolidate all hypercall time checking into a single helper function, checking only static properties. The dynamic properties are already taken care of by the __addr_ok() check in guest_get_eff_kern_l1e(), used by pv_map_ldt_shadow_page(), in a formally more "precise" manner (accounting for the of

Re: [QEMU PATCH v4 09/13] virtio-gpu: Handle resource blob commands

2023-09-05 Thread Huang Rui
On Thu, Aug 31, 2023 at 06:24:32PM +0800, Akihiko Odaki wrote: > On 2023/08/31 18:32, Huang Rui wrote: > > From: Antonio Caggiano > > > > Support BLOB resources creation, mapping and unmapping by calling the > > new stable virglrenderer 0.10 interface. Only enabled when available and > > via the

Re: [QEMU PATCH v4 07/13] softmmu/memory: enable automatic deallocation of memory regions

2023-09-05 Thread Huang Rui
On Thu, Aug 31, 2023 at 06:10:08PM +0800, Akihiko Odaki wrote: > On 2023/08/31 18:32, Huang Rui wrote: > > From: Xenia Ragiadakou > > > > When the memory region has a different life-cycle from that of her parent, > > could be automatically released, once has been unparent and once all of her > >

[PATCH] x86/PV: don't use access_ok() in set_debugreg()

2023-09-05 Thread Jan Beulich
access_ok() is not be applicable here; we really only want a linear address check for breakpoint addresses, as putting those in debug register isn't going to result in actual memory accesses. Furthermore access_ok() assumes to be acting on current, which isn't the case here when called from arch_se

Re: xen | Failed pipeline for staging-4.17 | 699de512

2023-09-05 Thread Bertrand Marquis
Hi Jan, > On 5 Sep 2023, at 10:36, Jan Beulich wrote: > > On 05.09.2023 10:23, GitLab wrote: >> >> >> Pipeline #992747061 has failed! >> >> Project: xen ( https://gitlab.com/xen-project/xen ) >> Branch: staging-4.17 ( >> https://gitlab.com/xen-project/xen/-/commits/staging-4.17 ) >> >> Comm

Re: xen | Failed pipeline for staging-4.17 | 699de512

2023-09-05 Thread Michal Orzel
On 05/09/2023 10:36, Jan Beulich wrote: > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 05.09.2023 10:23, GitLab wrote: >> >> >> Pipeline #992747061 has failed! >> >> Project: xen ( https://gitl

Re: xen | Failed pipeline for staging-4.17 | 699de512

2023-09-05 Thread Jan Beulich
On 05.09.2023 10:23, GitLab wrote: > > > Pipeline #992747061 has failed! > > Project: xen ( https://gitlab.com/xen-project/xen ) > Branch: staging-4.17 ( > https://gitlab.com/xen-project/xen/-/commits/staging-4.17 ) > > Commit: 699de512 ( > https://gitlab.com/xen-project/xen/-/commit/699de512

Re: [XEN PATCH] xen/types: address Rule 10.1 for macro BITS_TO_LONGS

2023-09-05 Thread Jan Beulich
On 05.09.2023 10:20, Nicola Vetrini wrote: > On 05/09/2023 09:46, Jan Beulich wrote: >> On 05.09.2023 09:31, Nicola Vetrini wrote: >>> Given its use in the declaration >>> 'DECLARE_BITMAP(features, IOMMU_FEAT_count)' the argument >>> 'bits' has essential type 'enum iommu_feature', which is not >>>

Re: [PATCH] tools/misc/xencov_split: Add python 3 compatibility

2023-09-05 Thread Javi Merino
On Mon, Sep 04, 2023 at 08:51:31AM +0200, Jan Beulich wrote: > On 02.09.2023 18:21, Javi Merino wrote: > > Closes #154 > > > > Signed-off-by: Javi Merino > > The title isn't really in line with ... > > > --- a/tools/misc/xencov_split > > +++ b/tools/misc/xencov_split > > @@ -1,5 +1,7 @@ > > -#!

[PATCH v2] Arm: constrain {,u}int64_aligned_t in public header

2023-09-05 Thread Jan Beulich
For using a GNU extension, it may not be exposed in general, just like is done on x86 (except that here we need to also work around not all of the tool stack actually defining __XEN_TOOLS__). External consumers (not using gcc or a compatible compiler) need to make this type available up front (just

Re: [PATCH] Arm: constrain {,u}int64_aligned_t in public header

2023-09-05 Thread Jan Beulich
On 05.09.2023 04:08, Henry Wang wrote: >> On Sep 1, 2023, at 15:26, Jan Beulich wrote: >> --- a/xen/include/public/arch-arm.h >> +++ b/xen/include/public/arch-arm.h >> @@ -152,8 +152,10 @@ >> >> #define XEN_HYPERCALL_TAG 0XEA1 >> >> -#define int64_aligned_t int64_t __attribute__((aligned(8)))

Re: [XEN PATCH] xen/types: address Rule 10.1 for macro BITS_TO_LONGS

2023-09-05 Thread Nicola Vetrini
On 05/09/2023 09:46, Jan Beulich wrote: On 05.09.2023 09:31, Nicola Vetrini wrote: Given its use in the declaration 'DECLARE_BITMAP(features, IOMMU_FEAT_count)' the argument 'bits' has essential type 'enum iommu_feature', which is not allowed by the Rule as an operand to the addition operator. G

  1   2   >