[linux-linus test] 183010: regressions - FAIL

2023-09-15 Thread osstest service owner
flight 183010 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183010/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 182531

Re: [PATCH v6 08/13] xen/arm: Fold mmu_init_secondary_cpu() to head.S

2023-09-15 Thread Henry Wang
Hi Julien, > On Sep 16, 2023, at 05:58, Julien Grall wrote: > > Hi Henry, > > On 28/08/2023 02:32, Henry Wang wrote: >> Currently mmu_init_secondary_cpu() only enforces the page table >> should not contain mapping that are both Writable and eXecutables >> after boot. To ease the arch/arm/mm.c

[PATCH] xen/arm64: head.S: Fix wrong enable_boot_cpu_mm() code movement

2023-09-15 Thread Henry Wang
Some addressed comments on enable_boot_cpu_mm() were reintroduced back during the code movement from arm64/head.S to arm64/mmu/head.S. We should drop the unreachable code, move the 'mov lr, x5' closer to 'b remove_identity_mapping' so it is clearer that it will return, and update the in-code

[xen-unstable test] 183009: tolerable FAIL - PUSHED

2023-09-15 Thread osstest service owner
flight 183009 xen-unstable real [real] flight 183012 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183009/ http://logs.test-lab.xenproject.org/osstest/logs/183012/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

[xen-unstable-smoke test] 183011: tolerable all pass - PUSHED

2023-09-15 Thread osstest service owner
flight 183011 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183011/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH for-4.18 v2] tools/light: Revoke permissions when a PCI detach for HVM domain

2023-09-15 Thread Henry Wang
Hi Julien, > On Sep 15, 2023, at 20:52, Julien Grall wrote: > > From: Julien Grall > > Currently, libxl will grant IOMEM, I/O port and IRQ permissions when > a PCI is attached (see pci_add_dm_done()) for all domain types. However, > the permissions are only revoked for non-HVM domain (see

Re: [PATCH v6 03/13] xen/arm64: Split and move MMU-specific head.S to mmu/head.S

2023-09-15 Thread Henry Wang
Hi, > On Sep 16, 2023, at 07:17, Henry Wang wrote: > > Hi Julien, > >> On Sep 16, 2023, at 05:41, Julien Grall wrote: >> >> Hi Henry, >> >> I realize that this was already committed. But something went wrong during >> the code movement. >> >> On 28/08/2023 02:32, Henry Wang wrote: >>> +/*

Re: [PATCH v6 03/13] xen/arm64: Split and move MMU-specific head.S to mmu/head.S

2023-09-15 Thread Henry Wang
Hi Julien, > On Sep 16, 2023, at 05:41, Julien Grall wrote: > > Hi Henry, > > I realize that this was already committed. But something went wrong during > the code movement. > > On 28/08/2023 02:32, Henry Wang wrote: >> +/* >> + * Enable mm (turn on the data cache and the MMU) for the boot

Re: [PATCH v6 08/13] xen/arm: Fold mmu_init_secondary_cpu() to head.S

2023-09-15 Thread Julien Grall
Hi Henry, On 28/08/2023 02:32, Henry Wang wrote: Currently mmu_init_secondary_cpu() only enforces the page table should not contain mapping that are both Writable and eXecutables after boot. To ease the arch/arm/mm.c split work, fold this function to head.S. Introduce assembly macro

Re: [PATCH 3/3] x86/xen: allow nesting of same lazy mode

2023-09-15 Thread Boris Ostrovsky
On 9/13/23 7:38 AM, Juergen Gross wrote: When running as a paravirtualized guest under Xen, Linux is using "lazy mode" for issuing hypercalls which don't need to take immediate effect in order to improve performance (examples are e.g. multiple PTE changes). There are two different lazy modes

Re: [PATCH v6 03/13] xen/arm64: Split and move MMU-specific head.S to mmu/head.S

2023-09-15 Thread Julien Grall
Hi Henry, I realize that this was already committed. But something went wrong during the code movement. On 28/08/2023 02:32, Henry Wang wrote: +/* + * Enable mm (turn on the data cache and the MMU) for the boot CPU. + * The function will return to the virtual address provided in LR (e.g. the

Re: [PATCH v2] xen/arm: Skip Xen specific nodes/properties from hwdom /chosen node

2023-09-15 Thread Julien Grall
Hi Henry, On 13/09/2023 01:49, Henry Wang wrote: Hi Stefano, On Sep 13, 2023, at 01:46, Stefano Stabellini wrote: On Tue, 12 Sep 2023, Michal Orzel wrote: Skip the following Xen specific host device tree nodes/properties from being included into hardware domain /chosen node: -

Re: [PATCH v2 for-4.18?] x86: support data operand independent timing mode

2023-09-15 Thread Julien Grall
Hi Jan, On 14/09/2023 12:01, Jan Beulich wrote: On 14.09.2023 11:18, Julien Grall wrote: On 14/09/2023 10:11, Jan Beulich wrote: On 14.09.2023 11:04, Julien Grall wrote: On 14/09/2023 07:32, Jan Beulich wrote: On 13.09.2023 19:56, Julien Grall wrote: If not, I think we should taint Xen

[PATCH 2/7] x86/emul: Fix and extend #DB trap handling

2023-09-15 Thread Andrew Cooper
Lots of this is very very broken, but we need to start somewhere. First, the bugfix. Hooks which use X86EMUL_DONE to skip the general emulation still need to evaluate singlestep as part of completing the instruction. Defer the logic until X86EMUL_DONE has been converted to X86EMUL_OKAY. Second,

[PATCH 7/7] x86/pv: Rewrite %dr6 handling

2023-09-15 Thread Andrew Cooper
All #DB exceptions result in an update of %dr6, but this isn't handled properly by Xen for any guest type. Remove all ad-hoc dr6 handling, leaving it to pv_inject_event() in most cases and using the new x86_merge_dr6() helper. In do_debug(), swap the dr6 to pending_dbg in order to operate

[PATCH 5/7] x86: Introduce x86_merge_dr6()

2023-09-15 Thread Andrew Cooper
The current logic used to update %dr6 when injecting #DB is buggy. The SDM/APM documention on %dr6 updates is far from ideal, but does at least make clear that it's non-trivial. The actual behaviour is to overwrite B{0..3} and accumulate all other bits. Introduce x86_merge_dr6() to perform the

[PATCH 4/7] x86/pv: Drop priv_op_ctxt.bpmatch and use pending_dbg instead

2023-09-15 Thread Andrew Cooper
With a full pending_dbg field in x86_emulate_ctxt, use it rather than using a local bpmatch field. This simplifies the X86EMUL_OKAY path as singlestep is already accumulated by x86_emulate() when appropriate. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger

[PATCH v2 0/7] x86/pv: #DB vs %dr6 fixes, part 2

2023-09-15 Thread Andrew Cooper
This time with a bit of sanity testing. See patches for details. Andrew Cooper (7): x86/emul: ASSERT that X86EMUL_DONE doesn't escape to callers x86/emul: Fix and extend #DB trap handling x86/pv: Fix the determiniation of whether to inject #DB x86/pv: Drop priv_op_ctxt.bpmatch and use

[PATCH 3/7] x86/pv: Fix the determiniation of whether to inject #DB

2023-09-15 Thread Andrew Cooper
We long ago fixed the emulator to not inject exceptions behind our back. Therefore, assert that that a PV event (including interrupts, because that would be buggy too) isn't pending, rather than skipping the #DB injection if one is. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC:

[PATCH 1/7] x86/emul: ASSERT that X86EMUL_DONE doesn't escape to callers

2023-09-15 Thread Andrew Cooper
This property is far from clear. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Jinoh Kang v2: * New --- xen/arch/x86/x86_emulate/x86_emulate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c

[PATCH 6/7] x86: Extend x86_event with a pending_dbg field

2023-09-15 Thread Andrew Cooper
... using the Intel VMCS PENDING_DBG semantics, and sharing storage with cr2. This requires working around anonymous union bugs in obsolete versions of GCC, which in turn needs to drop unnecessary const qualifiers. Also introduce a pv_inject_DB() wrapper use this field nicely. Signed-off-by:

Re: [PATCH 0/5] x86/pv: #DB vs %dr6 fixes, part 2

2023-09-15 Thread Andrew Cooper
On 13/09/2023 12:21 am, Andrew Cooper wrote: > Slightly RFC. This is the next chunk of debug fixes from the bug that Jinoh > reported. I was trying to do a bit of due diligence before posting v2, and have made some discoveries. pv/emul-priv-op SingleStep vs Branch Step  

[linux-linus test] 183008: regressions - FAIL

2023-09-15 Thread osstest service owner
flight 183008 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183008/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 182531

Re: [PATCH] x86/shutdown: change default reboot method preference

2023-09-15 Thread Marek Marczykowski-Górecki
On Fri, Sep 15, 2023 at 09:11:50AM +0200, Roger Pau Monné wrote: > On Thu, Sep 14, 2023 at 06:42:03PM +0100, Andrew Cooper wrote: > > On 14/09/2023 4:21 pm, Roger Pau Monne wrote: > > > The current logic to chose the preferred reboot method is based on the > > > mode Xen > > > has been booted

Re: [PATCH v5 2/5] xen/ppc: Implement bitops.h

2023-09-15 Thread Shawn Anastasio
On 9/15/23 1:50 AM, Jan Beulich wrote: > On 14.09.2023 20:15, Shawn Anastasio wrote: >> On 9/13/23 2:29 AM, Jan Beulich wrote: >>> On 12.09.2023 20:35, Shawn Anastasio wrote: --- a/xen/arch/ppc/include/asm/bitops.h +++ b/xen/arch/ppc/include/asm/bitops.h @@ -1,9 +1,335 @@ +/*

Re: [QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer

2023-09-15 Thread Akihiko Odaki
On 2023/09/15 20:11, Huang Rui wrote: Patch "virtio-gpu: CONTEXT_INIT feature" has added the context_init feature flags. We would like to enable the feature with virglrenderer, so add to create virgl renderer context with flags using context_id when valid. Originally-by: Antonio Caggiano

Re: [QEMU PATCH v5 10/13] virtio-gpu: Resource UUID

2023-09-15 Thread Akihiko Odaki
On 2023/09/15 20:11, Huang Rui wrote: From: Antonio Caggiano Enable resource UUID feature and implement command resource assign UUID. This is done by introducing a hash table to map resource IDs to their UUIDs. Signed-off-by: Antonio Caggiano Signed-off-by: Huang Rui --- V4 -> V5: -

Re: [QEMU PATCH v5 09/13] virtio-gpu: Handle resource blob commands

2023-09-15 Thread Akihiko Odaki
On 2023/09/16 1:04, Akihiko Odaki wrote: On 2023/09/15 20:11, Huang Rui wrote: From: Antonio Caggiano Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device

Re: [QEMU PATCH v5 09/13] virtio-gpu: Handle resource blob commands

2023-09-15 Thread Akihiko Odaki
On 2023/09/15 20:11, Huang Rui wrote: From: Antonio Caggiano Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true Signed-off-by: Antonio Caggiano

Re: [QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer

2023-09-15 Thread Akihiko Odaki
On 2023/09/15 20:11, Huang Rui wrote: Patch "virtio-gpu: CONTEXT_INIT feature" has added the context_init feature flags. We would like to enable the feature with virglrenderer, so add to create virgl renderer context with flags using context_id when valid. Originally-by: Antonio Caggiano

Re: [QEMU PATCH v5 07/13] softmmu/memory: enable automatic deallocation of memory regions

2023-09-15 Thread Akihiko Odaki
On 2023/09/15 20:11, Huang Rui wrote: From: Xenia Ragiadakou When the memory region has a different life-cycle from that of her parent, could be automatically released, once has been unparent and once all of her references have gone away, via the object's free callback. However, currently,

[PATCH 9/9] x86/spec-ctrl: Mitigate the Zen1 DIV leakge

2023-09-15 Thread Andrew Cooper
In the Zen1 microarchitecure, there is one divider in the pipeline which services uops from both threads. In the case of #DE, the latched result from the previous DIV to execute will be forwarded speculatively. This is an interesting covert channel that allows two threads to communicate without

[PATCH 7/9] x86/spec-ctrl: Issue VERW during IST exit to Xen

2023-09-15 Thread Andrew Cooper
There is a corner case where e.g. an NMI hitting an exit-to-guest path after SPEC_CTRL_EXIT_TO_* would have run the entire NMI handler *after* the VERW flush to scrub potentially sensitive data from uarch buffers. In order to compensate, issue VERW when exiting to Xen from an IST entry.

[PATCH 2/9] x86/spec-ctrl: Fold DO_SPEC_CTRL_EXIT_TO_XEN into it's single user

2023-09-15 Thread Andrew Cooper
With the SPEC_CTRL_EXIT_TO_XEN{,_IST} confusion fixed, it's now obvious that there's only a single EXIT_TO_XEN path. Fold DO_SPEC_CTRL_EXIT_TO_XEN into SPEC_CTRL_EXIT_TO_XEN to simplify further fixes. When merging labels, switch the name to .L\@_skip_sc_msr as "skip" on its own is going to be

[PATCH 8/9] x86/amd: Introduce is_zen{1,2}_uarch() predicates

2023-09-15 Thread Andrew Cooper
We already have 3 cases using STIBP as a Zen1/2 heuristic, and are about to introduce a 4th. Wrap the heuristic into a pair of predictes rather than opencoding it, and the explaination of the heursitic, at each usage site. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné

[PATCH 3/9] x86/spec-ctrl: Turn the remaining SPEC_CTRL_{ENTRY,EXIT}_* into asm macros

2023-09-15 Thread Andrew Cooper
These have grown more complex over time, with some already having been converted. Provide full Requires/Clobbers comments, otherwise missing at this level of indirection. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC:

[PATCH 5/9] x86/entry: Adjust restore_all_xen to hold stack_end in %r14

2023-09-15 Thread Andrew Cooper
All other SPEC_CTRL_{ENTRY,EXIT}_* helpers hold stack_end in %r14. Adjust it for consistency. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/include/asm/spec_ctrl_asm.h | 8 xen/arch/x86/x86_64/entry.S

[PATCH 1/9] x86/spec-ctrl: Fix confusion between SPEC_CTRL_EXIT_TO_XEN{,_IST}

2023-09-15 Thread Andrew Cooper
c/s 3fffaf9c13e9 ("x86/entry: Avoid using alternatives in NMI/#MC paths") dropped the only user, leaving behind the (incorrect) implication that Xen had split exit paths. Delete the unused SPEC_CTRL_EXIT_TO_XEN and rename SPEC_CTRL_EXIT_TO_XEN_IST to SPEC_CTRL_EXIT_TO_XEN for consistency. No

[PATCH 4/9] x86/spec-ctrl: Improve all SPEC_CTRL_{ENTER,EXIT}_* comments

2023-09-15 Thread Andrew Cooper
... to better explain how they're used. Doing so highlights that SPEC_CTRL_EXIT_TO_XEN is missing a VERW flush for the corner case when e.g. an NMI hits late in an exit-to-guest path. Leave a TODO, which will be addressed in subsequent patches which arrange for DO_COND_VERW to be safe within

[PATCH 6/9] x86/entry: Track the IST-ness of an entry for the exit paths

2023-09-15 Thread Andrew Cooper
Use %r12 to hold an ist_exit boolean. This register is zero elsewhere in the entry/exit asm, so it only needs setting in the IST path. As this is subtle and fragile, add check_ist_exit() to be used in debugging builds to cross-check that the ist_exit boolean matches the entry vector. Write

[PATCH 0/9] x86/spec-ctrl: AMD DIV fix, and VERW prerequisite bugfixes

2023-09-15 Thread Andrew Cooper
Patch 9 is the XSA-439 fix for the AMD DIV issue, disclosed insufficiently ahead of August 8th for us to prepare a fix for the embargo. Patches 1 thru 8 are prerequisites, identified while trying to write patch 9. All 9 patches are for all security trees. Andrew Cooper (9): x86/spec-ctrl: Fix

Re: [PATCH 3/5] x86/emul: Add a pending_dbg field to x86_emulate_ctxt.retire

2023-09-15 Thread Andrew Cooper
On 15/09/2023 3:24 pm, Jinoh Kang wrote: > On 9/15/23 21:20, Jinoh Kang wrote: >> On 9/13/23 08:21, Andrew Cooper wrote: >>> diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h >>> b/xen/arch/x86/x86_emulate/x86_emulate.h >>> index 698750267a90..f0e74d23c378 100644 >>> ---

Re: [PATCH 1/2] xen/x86: io_apic: Introduce a command line option to skip timer check

2023-09-15 Thread Julien Grall
Hi Roger, On 15/09/2023 14:54, Roger Pau Monné wrote: On Fri, Aug 18, 2023 at 02:44:40PM +0100, Julien Grall wrote: From: Julien Grall Currently, Xen will spend ~100ms to check if the timer works. If the Admin knows their platform have a working timer, then it would be handy to be able to

Re: [PATCH 3/5] x86/emul: Add a pending_dbg field to x86_emulate_ctxt.retire

2023-09-15 Thread Jinoh Kang
On 9/15/23 21:20, Jinoh Kang wrote: > On 9/13/23 08:21, Andrew Cooper wrote: >> diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h >> b/xen/arch/x86/x86_emulate/x86_emulate.h >> index 698750267a90..f0e74d23c378 100644 >> --- a/xen/arch/x86/x86_emulate/x86_emulate.h >> +++

[libvirt test] 183007: tolerable all pass - PUSHED

2023-09-15 Thread osstest service owner
flight 183007 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/183007/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183001 test-armhf-armhf-libvirt-qcow2 15

Re: [PATCH 2/2] xen/x86: ioapic: Bail out from timer_irq_works() as soon as possible

2023-09-15 Thread Julien Grall
Hi Jan, On 07/09/2023 15:28, Jan Beulich wrote: On 18.08.2023 15:44, Julien Grall wrote: From: Julien Grall Currently timer_irq_works() will wait the full 100ms before checking that pit0_ticks has been incremented at least 4 times. However, the bulk of the BIOS/platform should not have a

Re: [PATCH 1/2] xen/x86: io_apic: Introduce a command line option to skip timer check

2023-09-15 Thread Roger Pau Monné
On Fri, Aug 18, 2023 at 02:44:40PM +0100, Julien Grall wrote: > From: Julien Grall > > Currently, Xen will spend ~100ms to check if the timer works. If the > Admin knows their platform have a working timer, then it would be > handy to be able to bypass the check. I'm of the opinion that the

Re: [PATCH 1/2] xen/x86: io_apic: Introduce a command line option to skip timer check

2023-09-15 Thread George Dunlap
On Fri, Sep 15, 2023 at 2:18 PM Julien Grall wrote: > I don't mind too much about using - over _ but it is never clear why you > strongly push for it (and whether the others agrees). Is this documented > somewhere? If not, can you do it so everyone can apply it consistently? > (At least I would

Re: [PATCH 1/2] xen/x86: io_apic: Introduce a command line option to skip timer check

2023-09-15 Thread Julien Grall
Hi, On 07/09/2023 15:09, Jan Beulich wrote: On 18.08.2023 15:44, Julien Grall wrote: --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1896,6 +1896,13 @@ This option is ignored in **pv-shim** mode. ### nr_irqs (x86) > `= ` +### no_timer_works (x86) +>

[PATCH for-4.18 v2] tools/light: Revoke permissions when a PCI detach for HVM domain

2023-09-15 Thread Julien Grall
From: Julien Grall Currently, libxl will grant IOMEM, I/O port and IRQ permissions when a PCI is attached (see pci_add_dm_done()) for all domain types. However, the permissions are only revoked for non-HVM domain (see do_pci_remove()). This means that HVM domains will be left with extra

[xen-unstable test] 183005: tolerable FAIL

2023-09-15 Thread osstest service owner
flight 183005 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183005/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 183000 test-amd64-i386-xl-qemuu-win7-amd64

Re: [PATCH 3/5] x86/emul: Add a pending_dbg field to x86_emulate_ctxt.retire

2023-09-15 Thread Jinoh Kang
On 9/13/23 08:21, Andrew Cooper wrote: > diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h > b/xen/arch/x86/x86_emulate/x86_emulate.h > index 698750267a90..f0e74d23c378 100644 > --- a/xen/arch/x86/x86_emulate/x86_emulate.h > +++ b/xen/arch/x86/x86_emulate/x86_emulate.h > @@ -588,15 +588,26 @@

Re: [PATCH] Revert "EDAC/mce_amd: Do not load edac_mce_amd module on guests"

2023-09-15 Thread Borislav Petkov
On Thu, Sep 14, 2023 at 10:02:05AM -0700, Elliott Mitchell wrote: > Indeed. At what point is the lack of information and response long > enough to simply commit a revert due to those lacks? At no point. > Even with the commit message having been rewritten and the link to: >

[QEMU PATCH v5 11/13] virtio-gpu: Support Venus capset

2023-09-15 Thread Huang Rui
From: Antonio Caggiano Add support for the Venus capset, which enables Vulkan support through the Venus Vulkan driver for virtio-gpu. Signed-off-by: Antonio Caggiano Signed-off-by: Huang Rui --- V4 -> V5: - Send kernel patch to define VIRTIO_GPU_CAPSET_VENUS and will use another

[QEMU PATCH v5 08/13] virtio-gpu: Don't require udmabuf when blobs and virgl are enabled

2023-09-15 Thread Huang Rui
From: Dmitry Osipenko The udmabuf usage is mandatory when virgl is disabled and blobs feature enabled in the Qemu machine configuration. If virgl and blobs are enabled, then udmabuf requirement is optional. Since udmabuf isn't widely supported by a popular Linux distros today, let's relax the

[QEMU PATCH v5 13/13] virtio-gpu: Enable virglrenderer render server flag for venus

2023-09-15 Thread Huang Rui
Venus in virglrenderer has required render server support. Signed-off-by: Huang Rui --- hw/display/virtio-gpu-virgl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 39c04d730c..65ffce85a8 100644 ---

[QEMU PATCH v5 09/13] virtio-gpu: Handle resource blob commands

2023-09-15 Thread Huang Rui
From: Antonio Caggiano Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true Signed-off-by: Antonio Caggiano Signed-off-by: Dmitry Osipenko

[QEMU PATCH v5 12/13] virtio-gpu: Initialize Venus

2023-09-15 Thread Huang Rui
From: Antonio Caggiano Request Venus when initializing VirGL. Signed-off-by: Antonio Caggiano Signed-off-by: Huang Rui --- V4 -> V5: - Add meson check to make sure unstable APIs defined from 0.9.0. (Antonio) hw/display/virtio-gpu-virgl.c | 4 meson.build | 5

[QEMU PATCH v5 10/13] virtio-gpu: Resource UUID

2023-09-15 Thread Huang Rui
From: Antonio Caggiano Enable resource UUID feature and implement command resource assign UUID. This is done by introducing a hash table to map resource IDs to their UUIDs. Signed-off-by: Antonio Caggiano Signed-off-by: Huang Rui --- V4 -> V5: - Add virtio migration handling for uuid

[QEMU PATCH v5 07/13] softmmu/memory: enable automatic deallocation of memory regions

2023-09-15 Thread Huang Rui
From: Xenia Ragiadakou When the memory region has a different life-cycle from that of her parent, could be automatically released, once has been unparent and once all of her references have gone away, via the object's free callback. However, currently, references to the memory region are held

[QEMU PATCH v5 06/13] virtio-gpu: Support context init feature with virglrenderer

2023-09-15 Thread Huang Rui
Patch "virtio-gpu: CONTEXT_INIT feature" has added the context_init feature flags. We would like to enable the feature with virglrenderer, so add to create virgl renderer context with flags using context_id when valid. Originally-by: Antonio Caggiano Signed-off-by: Huang Rui --- V4 -> V5:

[QEMU PATCH v5 05/13] virtio-gpu: Configure context init for virglrenderer

2023-09-15 Thread Huang Rui
Configure context init feature flag for virglrenderer. Originally-by: Antonio Caggiano Signed-off-by: Huang Rui --- V4 -> V5: - Inverted patch 5 and 6 because we should configure HAVE_VIRGL_CONTEXT_INIT firstly. (Philippe) meson.build | 4 1 file changed, 4 insertions(+) diff

[QEMU PATCH v5 04/13] virtio-gpu: blob prep

2023-09-15 Thread Huang Rui
From: Antonio Caggiano This adds preparatory functions needed to: - decode blob cmds - tracking iovecs Signed-off-by: Antonio Caggiano Signed-off-by: Dmitry Osipenko Signed-off-by: Gurchetan Singh Tested-by: Alyssa Ross Tested-by: Emmanouil Pitsidianakis Tested-by: Akihiko Odaki

[QEMU PATCH v5 02/13] virtio-gpu: CONTEXT_INIT feature

2023-09-15 Thread Huang Rui
From: Antonio Caggiano The feature can be enabled when a backend wants it. Signed-off-by: Antonio Caggiano Signed-off-by: Gurchetan Singh Tested-by: Alyssa Ross Tested-by: Akihiko Odaki Tested-by: Huang Rui Acked-by: Huang Rui Reviewed-by: Marc-André Lureau Reviewed-by: Philippe

[QEMU PATCH v5 03/13] virtio-gpu: hostmem

2023-09-15 Thread Huang Rui
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. Signed-off-by: Antonio Caggiano Tested-by: Alyssa Ross Tested-by: Akihiko Odaki Tested-by: Huang Rui Acked-by: Huang Rui Acked-by: Michael S. Tsirkin Reviewed-by: Akihiko Odaki Signed-off-by: Huang Rui ---

[QEMU PATCH v5 01/13] virtio: Add shared memory capability

2023-09-15 Thread Huang Rui
From: "Dr. David Alan Gilbert" Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG' to allow defining shared memory regions with sizes and offsets of 2^32 and more. Multiple instances of the capability are allowed and distinguished by a device-specific 'id'. Signed-off-by: Dr. David

[QEMU PATCH v5 00/13] Support blob memory and venus on qemu

2023-09-15 Thread Huang Rui
Hi all, Antonio Caggiano made the venus with QEMU on KVM platform last September[1]. This series are inherited from his original work to support the features of context init, hostmem, resource uuid, and blob resources for venus. At March of this year, we sent out the V1 version[2] for the review.

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

2023-09-15 Thread George Dunlap
On Thu, Sep 14, 2023 at 12:18 AM Stefano Stabellini wrote: > > On Wed, 13 Sep 2023, George Dunlap wrote: > > On Tue, Sep 12, 2023 at 8:57 AM Thomas Gleixner wrote: > > > > > > On Mon, Sep 11 2023 at 19:24, Andrew Cooper wrote: > > > > Furthermore, cursory testing that Thomas did for the Linux

Re: [PATCH v2] timer: fix NR_CPUS=1 build with gcc13

2023-09-15 Thread George Dunlap
On Thu, Sep 14, 2023 at 3:32 PM Jan Beulich wrote: > > Gcc13 apparently infers from "if ( old_cpu < new_cpu )" that "new_cpu" > is >= 1, and then (on x86) complains about "per_cpu(timers, new_cpu)" > exceeding __per_cpu_offset[]'s bounds (being an array of 1 in such a > configuration). Make the

Re: [QEMU PATCH v4 10/13] virtio-gpu: Resource UUID

2023-09-15 Thread Albert Esteve
On Thu, Sep 14, 2023 at 6:56 PM Akihiko Odaki wrote: > On 2023/09/14 17:29, Albert Esteve wrote: > > > > > > On Thu, Sep 14, 2023 at 9:17 AM Akihiko Odaki > > wrote: > > > > On 2023/09/13 23:18, Albert Esteve wrote: > > > > > > > > > On Wed,

Re: [PATCH 6/8] x86/entry: Track the IST-ness of an entry for the exit paths

2023-09-15 Thread Andrew Cooper
On 15/09/2023 8:13 am, Jan Beulich wrote: > On 14.09.2023 21:44, Andrew Cooper wrote: >> On 14/09/2023 10:32 am, Jan Beulich wrote: >>> On 13.09.2023 22:27, Andrew Cooper wrote: --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -142,10 +142,16 @@ process_trap:

Re: [PATCH 4/8] x86/spec-ctrl: Extend all SPEC_CTRL_{ENTER,EXIT}_* comments

2023-09-15 Thread Andrew Cooper
On 15/09/2023 8:07 am, Jan Beulich wrote: > On 14.09.2023 21:23, Andrew Cooper wrote: >> On 14/09/2023 8:58 am, Jan Beulich wrote: >>> On 13.09.2023 22:27, Andrew Cooper wrote: @@ -319,7 +334,14 @@ UNLIKELY_DISPATCH_LABEL(\@_serialise): UNLIKELY_END(\@_serialise) .endm

Re: [PATCH 6/7] block: Clean up local variable shadowing

2023-09-15 Thread Kevin Wolf
Am 31.08.2023 um 15:25 hat Markus Armbruster geschrieben: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: delete inner declarations when they are actually redundant, > else rename

Re: [PATCH 4/7] block/dirty-bitmap: Clean up local variable shadowing

2023-09-15 Thread Kevin Wolf
Am 31.08.2023 um 15:25 hat Markus Armbruster geschrieben: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: delete inner declarations when they are actually redundant, > else rename

[PATCH v2] x86/shutdown: change default reboot method preference

2023-09-15 Thread Roger Pau Monne
The current logic to chose the preferred reboot method is based on the mode Xen has been booted into, so if the box is booted from UEFI, the preferred reboot method will be to use the ResetSystem() run time service call. However, that method seems to be widely untested, and quite often leads to a

Re: [PATCH 2/5] x86: Introduce x86_merge_dr6()

2023-09-15 Thread Jan Beulich
On 14.09.2023 20:03, Andrew Cooper wrote: > On 14/09/2023 3:53 pm, Jan Beulich wrote: >> On 13.09.2023 01:21, Andrew Cooper wrote: >>> The current logic used to update %dr6 when injecting #DB is buggy. The >>> architectural behaviour is to overwrite B{0..3} and accumulate all other >>> bits. >>

Re: [PATCH 5/7] block/vdi: Clean up local variable shadowing

2023-09-15 Thread Kevin Wolf
Am 31.08.2023 um 15:25 hat Markus Armbruster geschrieben: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: delete inner declarations when they are actually redundant, > else rename

Re: 4.8-unstable: building firmware/hvmloader errors in Bookworm with gcc-12.2

2023-09-15 Thread Jan Beulich
On 14.09.2023 22:53, Pry Mar wrote: > First attempt to build xen-4.18-unstabl in deb12 (Bookworm): > /home/mockbuild/pbdeps/xen-4.18~rc0/debian/build/build-utils_amd64/tools/firmware/hvmloader/dsdt_anycpu.asl > 9851: Name ( SLT, 0x0 ) > Remark 2173 - Creation of named

Re: [PATCH 7/8] x86/spec-ctrl: Issue VERW during IST exit to Xen

2023-09-15 Thread Jan Beulich
On 14.09.2023 21:49, Andrew Cooper wrote: > On 14/09/2023 11:01 am, Jan Beulich wrote: >> On 13.09.2023 22:27, Andrew Cooper wrote: >>> There is a corner case where e.g. an NMI hitting an exit-to-guest path after >>> SPEC_CTRL_EXIT_TO_* would have run the entire NMI handler *after* the VERW >>>

Re: [PATCH 6/8] x86/entry: Track the IST-ness of an entry for the exit paths

2023-09-15 Thread Jan Beulich
On 14.09.2023 21:44, Andrew Cooper wrote: > On 14/09/2023 10:32 am, Jan Beulich wrote: >> On 13.09.2023 22:27, Andrew Cooper wrote: >>> --- a/xen/arch/x86/x86_64/compat/entry.S >>> +++ b/xen/arch/x86/x86_64/compat/entry.S >>> @@ -117,8 +117,15 @@ compat_process_trap: >>> call

Re: [PATCH] x86/shutdown: change default reboot method preference

2023-09-15 Thread Roger Pau Monné
On Thu, Sep 14, 2023 at 06:42:03PM +0100, Andrew Cooper wrote: > On 14/09/2023 4:21 pm, Roger Pau Monne wrote: > > The current logic to chose the preferred reboot method is based on the mode > > Xen > > has been booted into, so if the box is booted from UEFI, the preferred > > reboot > > method

Re: [PATCH 4/8] x86/spec-ctrl: Extend all SPEC_CTRL_{ENTER,EXIT}_* comments

2023-09-15 Thread Jan Beulich
On 14.09.2023 21:23, Andrew Cooper wrote: > On 14/09/2023 8:58 am, Jan Beulich wrote: >> On 13.09.2023 22:27, Andrew Cooper wrote: >>> --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h >>> +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h >>> @@ -218,7 +218,10 @@ >>> wrmsr >>> .endm >>> >>> -/*

Re: [PATCH v4 4/8] Arm: annotate entry points with type and size

2023-09-15 Thread Jan Beulich
On 14.09.2023 23:25, Julien Grall wrote: > On 04/08/2023 07:28, Jan Beulich wrote: >> Use the generic framework in xen/linkage.h. No change in generated code >> except for the changed padding value (noticable when config.gz isn't a >> multiple of 4 in size). Plus of course the converted symbols

Re: [PATCH v5 2/5] xen/ppc: Implement bitops.h

2023-09-15 Thread Jan Beulich
On 14.09.2023 20:15, Shawn Anastasio wrote: > On 9/13/23 2:29 AM, Jan Beulich wrote: >> On 12.09.2023 20:35, Shawn Anastasio wrote: >>> --- a/xen/arch/ppc/include/asm/bitops.h >>> +++ b/xen/arch/ppc/include/asm/bitops.h >>> @@ -1,9 +1,335 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >>>

Re: [PATCH v1 16/29] xen/asm-generic: introduce stub header flushtlb.h

2023-09-15 Thread Jiamei Xie
Hi Oleksii On 2023/9/14 22:56, Oleksii Kurochko wrote: The patch introduces header stub necessry for full Xen build. Signed-off-by: Oleksii Kurochko --- xen/include/asm-generic/flushtlb.h | 42 ++ 1 file changed, 42 insertions(+) create mode 100644

[linux-linus test] 183004: regressions - FAIL

2023-09-15 Thread osstest service owner
flight 183004 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183004/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 182531