Re: [PATCH v2] ARM: GICv3 ITS: flush caches for newly allocated ITT

2023-09-22 Thread Stewart Hildebrand
On 9/22/23 18:27, Volodymyr Babchuk wrote: > ITS manages Device Tables and Interrupt Translation Tables on its own, > so generally we are not interested in maintaining any coherence with > CPU's view of those memory regions, except one case: ITS requires that > Interrupt Translation Tables should b

[libvirt test] 183112: regressions - FAIL

2023-09-22 Thread osstest service owner
flight 183112 libvirt real [real] flight 183124 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183112/ http://logs.test-lab.xenproject.org/osstest/logs/183124/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-

[xen-unstable-smoke test] 183121: tolerable all pass - PUSHED

2023-09-22 Thread osstest service owner
flight 183121 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183121/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[linux-linus test] 183109: tolerable FAIL - PUSHED

2023-09-22 Thread osstest service owner
flight 183109 linux-linus real [real] flight 183122 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183109/ http://logs.test-lab.xenproject.org/osstest/logs/183122/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-

RE: [PATCH v10 03/38] x86/msr: Add the WRMSRNS instruction support

2023-09-22 Thread Li, Xin3
> > I notice there are several call sites using the safe version w/o > > checking the return value, should the unsafe version be a better > > choice in such cases? > > Depends. The safe version does not emit a warning on fail. So if the > callsite truly does not care about the error it's fine. Ri

[PATCH v2] ARM: GICv3 ITS: flush caches for newly allocated ITT

2023-09-22 Thread Volodymyr Babchuk
ITS manages Device Tables and Interrupt Translation Tables on its own, so generally we are not interested in maintaining any coherence with CPU's view of those memory regions, except one case: ITS requires that Interrupt Translation Tables should be initialized with zeroes. Existing code already do

Re: [PATCH v1 2/3] ARM: GICv3 ITS: do not invalidate memory while sending a command

2023-09-22 Thread Volodymyr Babchuk
Hello Marc, Marc Zyngier writes: > Volodymyr, > > On Fri, 22 Sep 2023 01:22:11 +0100, > Volodymyr Babchuk wrote: >> >> >> Hi Mark, > > s/k/c/ Oh, I'm sorry. >> >> I am writing to you, because you are GICv3 maintainer in Linux. We are >> updating ITS driver in Xen and we have a question a

[xen-unstable-smoke test] 183120: tolerable all pass - PUSHED

2023-09-22 Thread osstest service owner
flight 183120 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183120/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v3 4/4] pdx: Add CONFIG_PDX_COMPRESSION as a common Kconfig option

2023-09-22 Thread Andrew Cooper
Several things. First, Shawn: PPC has gained a HAS_PDX, the deletion of which needs merging into this patch. It was added as part of 4a2f68f909304 which was "minimal to build".  This series address the issue you presumably encountered where pdx.c appears to be optional but wasn't. Do PPC platfo

[xen-unstable-smoke test] 183118: tolerable all pass - PUSHED

2023-09-22 Thread osstest service owner
flight 183118 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183118/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 183119: all pass - PUSHED

2023-09-22 Thread osstest service owner
flight 183119 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183119/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8b2e6b90b85fd4b1f7f921da09b16f5175acea8a baseline version: ovmf b5003ab72564b51892f4c

[xen-4.15-testing test] 183110: tolerable trouble: fail/pass/starved - PUSHED

2023-09-22 Thread osstest service owner
flight 183110 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/183110/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 183095 pass in 183110 test-amd6

Re: [PATCH 5/7] x86: Introduce x86_merge_dr6()

2023-09-22 Thread Andrew Cooper
On 18/09/2023 12:37 pm, Jan Beulich wrote: > On 15.09.2023 22:36, Andrew Cooper wrote: >> The current logic used to update %dr6 when injecting #DB is buggy. >> >> The SDM/APM documention on %dr6 updates is far from ideal, but does at least >> make clear that it's non-trivial. The actual behaviour

Re: [PATCH WIP] xen/public: move incomplete type definitions to xen.h

2023-09-22 Thread Elliott Mitchell
On Fri, Sep 22, 2023 at 10:21:21AM +0200, Jan Beulich wrote: > On 21.09.2023 18:18, Elliott Mitchell wrote: > > Hypercall wrappers need the incomplete type definitions. Only when the > > actual structure needed. > > While in the first sentence "only" looks to be missing, I can't really > make sen

[XEN PATCH v2] xen/emul-i8254: remove forward declarations and re-order functions

2023-09-22 Thread Federico Serafini
Remove forward declarations, including one that violates MISRA C Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"), and re-order functions. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/emul-i8254.c | 129 +++

RE: [PATCH v10 03/38] x86/msr: Add the WRMSRNS instruction support

2023-09-22 Thread Thomas Gleixner
On Fri, Sep 22 2023 at 08:16, Xin3 Li wrote: >> > > +static __always_inline void __wrmsrns(u32 msr, u32 low, u32 high) >> > >> > Shouldn't this be named wrmsrns_safe since it has exception handling, >> > similar >> to >> > the current wrmsrl_safe. >> > >> >> Both safe and unsafe versions have exc

Re: [PATCH v2 1/2] credit: Limit load balancing to once per millisecond

2023-09-22 Thread George Dunlap
On Fri, Sep 22, 2023 at 2:49 PM Jan Beulich wrote: > > On 22.09.2023 14:20, George Dunlap wrote: > > On Thu, Sep 21, 2023 at 2:12 PM Juergen Gross wrote: > >> > >> On 21.09.23 14:23, George Dunlap wrote: > >>> The credit scheduler tries as hard as it can to ensure that it always > >>> runs schedu

Re: Xen 4.18 release: Reminder about feature/code freeze

2023-09-22 Thread George Dunlap
On Mon, Sep 11, 2023 at 2:08 AM Henry Wang wrote: > > Hi everyone, > > > > This is the reminder that we are currently in the feature freeze. I apologise > > for the delay. > > > > I decided to make the code freeze date on Fri Sep 22, 2023, to give people > more > > time to react because of my lat

Re: Xen 4.18 release: Reminder about feature/code freeze

2023-09-22 Thread Andrew Cooper
On 11/09/2023 2:08 am, Henry Wang wrote: > Also, below is the critical items on my list for 4.18 release: > > 1. [PATCH 0/7] tools: More Python 3 fixes (part 1 of N) > > https://gitlab.com/xen-project/xen/-/issues/114 > I've committed all the work so far, which means it's nearly done. There's one

Re: [PATCH v2 1/2] credit: Limit load balancing to once per millisecond

2023-09-22 Thread Jan Beulich
On 22.09.2023 14:20, George Dunlap wrote: > On Thu, Sep 21, 2023 at 2:12 PM Juergen Gross wrote: >> >> On 21.09.23 14:23, George Dunlap wrote: >>> The credit scheduler tries as hard as it can to ensure that it always >>> runs scheduling units with positive credit (PRI_TS_UNDER) before >>> running

[xen-unstable test] 183103: tolerable FAIL - PUSHED

2023-09-22 Thread osstest service owner
flight 183103 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183103/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 183074 test-amd64-amd64-xl-qemut-win7-amd64

[xen-unstable-smoke test] 183116: tolerable all pass - PUSHED

2023-09-22 Thread osstest service owner
flight 183116 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183116/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v2 1/2] credit: Limit load balancing to once per millisecond

2023-09-22 Thread Juergen Gross
On 22.09.23 14:20, George Dunlap wrote: On Thu, Sep 21, 2023 at 2:12 PM Juergen Gross wrote: On 21.09.23 14:23, George Dunlap wrote: The credit scheduler tries as hard as it can to ensure that it always runs scheduling units with positive credit (PRI_TS_UNDER) before running those with negati

Re: [PATCH v2 1/2] credit: Limit load balancing to once per millisecond

2023-09-22 Thread George Dunlap
On Thu, Sep 21, 2023 at 2:12 PM Juergen Gross wrote: > > On 21.09.23 14:23, George Dunlap wrote: > > The credit scheduler tries as hard as it can to ensure that it always > > runs scheduling units with positive credit (PRI_TS_UNDER) before > > running those with negative credit (PRI_TS_OVER). If

[ovmf test] 183115: all pass - PUSHED

2023-09-22 Thread osstest service owner
flight 183115 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183115/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b5003ab72564b51892f4c933eb39d7d6083f3824 baseline version: ovmf 28a267af4024c329e5812

Re: [XEN PATCH] xen/emul-i8254: address a violation of MISRA C:2012 Rule 8.3

2023-09-22 Thread Federico Serafini
On 22/09/23 10:29, Jan Beulich wrote: On 21.09.2023 17:05, Federico Serafini wrote: Make function declaration and definition consistent. No fuctional change. Signed-off-by: Federico Serafini --- xen/arch/x86/emul-i8254.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xe

[xen-unstable-smoke test] 183113: tolerable all pass - PUSHED

2023-09-22 Thread osstest service owner
flight 183113 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183113/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v1 2/3] ARM: GICv3 ITS: do not invalidate memory while sending a command

2023-09-22 Thread Marc Zyngier
Volodymyr, On Fri, 22 Sep 2023 01:22:11 +0100, Volodymyr Babchuk wrote: > > > Hi Mark, s/k/c/ > > I am writing to you, because you are GICv3 maintainer in Linux. We are > updating ITS driver in Xen and we have a question about cache > maintenance WRT memory shared with ITS. As I can see, the

[ovmf test] 183114: all pass - PUSHED

2023-09-22 Thread osstest service owner
flight 183114 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183114/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 28a267af4024c329e58121ccd9bf5f4f7aabc0f4 baseline version: ovmf f67e1934d985dcb8a465d

Re: qemu-system-i386 crashes on i9 coffee lake

2023-09-22 Thread Andrew Cooper
On 21/09/2023 11:24 pm, Stefan Kadow wrote: > Hello, > > since commit b9ade05c > https://xenbits.xenproject.org/gitweb/?p=xen.git;a=commit;h=b9ade05cbba977673d5a08bc7a5940c5fd8add0e > > > qemu-system-i386 crashes on my Intel i9 Coffee Lake System. > > This does not happen when the system is booted

Re: [XEN PATCH 1/3] docs/misra: add documentation skeleton for MISRA C:2012 Dir 4.1

2023-09-22 Thread Nicola Vetrini
+Documentation for MISRA C:2012 Dir 4.1: invariant violation +___ + +To be written. What's an invariant violation? It's the violation of a project invariant (e.g., an assert or BUILD_BUG). Something along the lines of this could fi

Re: [XEN PATCH 2/3] docs: make the docs for MISRA C:2012 Dir 4.1 visible to ECLAIR

2023-09-22 Thread Nicola Vetrini
On 08/09/2023 13:04, Anthony PERARD wrote: On Fri, Sep 01, 2023 at 11:06:39AM +0200, Nicola Vetrini wrote: diff --git a/docs/misra/Makefile b/docs/misra/Makefile new file mode 100644 index ..8ea0505c8a20 --- /dev/null +++ b/docs/misra/Makefile @@ -0,0 +1,17 @@ +TARGETS := C-runtime-f

Re: [PATCH v9 15/16] xen/arm: vpci: check guest range

2023-09-22 Thread Roger Pau Monné
On Tue, Aug 29, 2023 at 11:19:47PM +, Volodymyr Babchuk wrote: > From: Stewart Hildebrand > > Skip mapping the BAR if it is not in a valid range. > > Signed-off-by: Stewart Hildebrand > --- > xen/drivers/vpci/header.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/xen/d

Re: [PATCH v9 13/16] xen/arm: translate virtual PCI bus topology for guests

2023-09-22 Thread Roger Pau Monné
On Tue, Aug 29, 2023 at 11:19:46PM +, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > There are three originators for the PCI configuration space access: > 1. The domain that owns physical host bridge: MMIO handlers are > there so we can update vPCI register handlers with the va

Re: [XEN PATCH] xen/emul-i8254: address a violation of MISRA C:2012 Rule 8.3

2023-09-22 Thread Jan Beulich
On 21.09.2023 17:05, Federico Serafini wrote: > Make function declaration and definition consistent. > No fuctional change. > > Signed-off-by: Federico Serafini > --- > xen/arch/x86/emul-i8254.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/x86/emul-i8254.c b

[ovmf test] 183111: all pass - PUSHED

2023-09-22 Thread osstest service owner
flight 183111 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183111/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f67e1934d985dcb8a465dcf44484be3688be99a5 baseline version: ovmf ea628f28e59849ee7b91e

Re: [PATCH WIP] xen/public: move incomplete type definitions to xen.h

2023-09-22 Thread Jan Beulich
On 21.09.2023 18:18, Elliott Mitchell wrote: > Hypercall wrappers need the incomplete type definitions. Only when the > actual structure needed. While in the first sentence "only" looks to be missing, I can't really make sense of the second (without implying what I think you mean). > As such th

RE: [PATCH v10 03/38] x86/msr: Add the WRMSRNS instruction support

2023-09-22 Thread Li, Xin3
> > > +static __always_inline void __wrmsrns(u32 msr, u32 low, u32 high) > > > > Shouldn't this be named wrmsrns_safe since it has exception handling, > > similar > to > > the current wrmsrl_safe. > > > > Both safe and unsafe versions have exception handling, while the safe > version returns an i

Re: [PATCH v3] console/serial: bump buffer from 16K to 128K

2023-09-22 Thread Julien Grall
Hi Jan, On 19/09/2023 15:26, Jan Beulich wrote: On 19.09.2023 16:14, Roger Pau Monné wrote: On Tue, Sep 19, 2023 at 03:06:45PM +0200, Jan Beulich wrote: On 19.09.2023 14:51, Roger Pau Monne wrote: Testing on a Kaby Lake box with 8 CPUs leads to the serial buffer being filled halfway during do

Re: [PATCH v13 6/9] gfxstream + rutabaga: add initial support for gfxstream

2023-09-22 Thread Akihiko Odaki
On 2023/09/22 16:42, Alyssa Ross wrote: Akihiko Odaki writes: Practically there is very low chance to hit the bug. I think only fuzzers and malicious actors will trigger it, and probably no one will dare using virtio-gpu-rutabaga or virtio-gpu-gl in a security-sensitive context. Well, this i

Re: [PATCH v13 6/9] gfxstream + rutabaga: add initial support for gfxstream

2023-09-22 Thread Alyssa Ross
Akihiko Odaki writes: > Practically there is very low chance to hit the bug. I think only > fuzzers and malicious actors will trigger it, and probably no one will > dare using virtio-gpu-rutabaga or virtio-gpu-gl in a security-sensitive > context. Well, this is exactly what Chrome OS does, al

Re: [PATCH v2 2/2] credit: Don't steal vcpus which have yielded

2023-09-22 Thread Juergen Gross
On 21.09.23 14:23, George Dunlap wrote: On large systems with many vcpus yielding due to spinlock priority inversion, it's not uncommon for a vcpu to yield its timeslice, only to be immediately stolen by another pcpu looking for higher-priority work. To prevent this: * Keep the YIELD flag until