Re: [PATCH] tools/xenstore: Avoid leaking memory in check_store

2023-09-28 Thread Juergen Gross
On 29.09.23 06:57, David Kahurani wrote: I'd like the following paragraph added to the commit message: check_store() will leak the memory from reading the "@introduceDomain" and "@releaseDomain" nodes. While this code should not be trigger-able from an unprivileged domain it is called mult

Re: [PATCH v3 0/7] Steps towards enabling -Wshadow=local

2023-09-28 Thread Markus Armbruster
Markus Armbruster writes: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Bugs love to hide in such code. > Evidence: PATCH 1. > > Enabling -Wshadow would prevent bugs like this one. But we'd have to > clean up all the offenders fir

Re: [PATCH 2/2] xen: privcmd: Add support for ioeventfd

2023-09-28 Thread Juergen Gross
On 29.08.23 14:29, Viresh Kumar wrote: Virtio guests send VIRTIO_MMIO_QUEUE_NOTIFY notification when they need to notify the backend of an update to the status of the virtqueue. The backend or another entity, polls the MMIO address for updates to know when the notification is sent. It works well

[linux-5.4 test] 183205: regressions - FAIL

2023-09-28 Thread osstest service owner
flight 183205 linux-5.4 real [real] flight 183209 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183205/ http://logs.test-lab.xenproject.org/osstest/logs/183209/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: t

[PATCH] tools/xenstore: Avoid leaking memory in check_store

2023-09-28 Thread David Kahurani
While this code should not be trigger-able from an unprivileged domain it is called multiple times when the database gets inconsistent. This means that a malicious guest able to corrupt the database will trigger the leaks here. Fix the leaks so that this code can be safely called from anywhere Si

Issue with shared information page on Xen/ARM 4.17

2023-09-28 Thread Elliott Mitchell
I'm trying to get FreeBSD/ARM operational on Xen/ARM. Current issue is the changes with the handling of the shared information page appear to have broken things for me. With a pre-4.17 build of Xen/ARM things worked fine. Yet with a build of the 4.17 release, mapping the shared information page

Re: [PATCH WIP] xen/public: move incomplete type definitions to xen.h

2023-09-28 Thread Elliott Mitchell
On Mon, Sep 25, 2023 at 08:27:31AM +0200, Jan Beulich wrote: > On 22.09.2023 17:42, Elliott Mitchell wrote: > > On Fri, Sep 22, 2023 at 10:21:21AM +0200, Jan Beulich wrote: > >> On 21.09.2023 18:18, Elliott Mitchell wrote: > >>> As such these incomplete definitions should be > >>> in xen.h next to

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-09-28 Thread Stefano Stabellini
On Wed, 27 Sep 2023, Luca Fancellu wrote: > Currently the dom0less feature code is mostly inside domain_build.c > and setup.c, it is a feature that may not be useful to everyone so > put the code in a different compilation module in order to make it > easier to disable the feature in the future. >

[xen-unstable test] 183202: tolerable FAIL - PUSHED

2023-09-28 Thread osstest service owner
flight 183202 xen-unstable real [real] flight 183207 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183202/ http://logs.test-lab.xenproject.org/osstest/logs/183207/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: Misra rule 10.3 violations report script

2023-09-28 Thread Stefano Stabellini
On Thu, 28 Sep 2023, Ayan Kumar Halder wrote: > On 28/09/2023 09:34, Luca Fancellu wrote: > > CAUTION: This message has originated from an External Source. Please use > > proper judgment and caution when opening attachments, clicking links, or > > responding to this email. > > > > > > Hi all, > H

[PATCH] cpumask: fix integer type in cpumask_first

2023-09-28 Thread Stefano Stabellini
nr_cpu_ids is unsigned int, but find_first_bit returns unsigned long (at least on arm). Use the larger type for min_t to avoid larger-to-smaller type assignments. This address 141 MISRA C 10.3 violations. Signed-off-by: Stefano Stabellini --- diff --git a/xen/include/xen/cpumask.h b/xen/include/

Re: Misra rule 10.3 violations report script

2023-09-28 Thread Stefano Stabellini
On Thu, 28 Sep 2023, Luca Fancellu wrote: > Hi all, > > In the last MISRA meeting Stefano told me about the Rule 10.3 and that we > have a lot of violations, > but GCC has a way to list them as written in rules.rst. > > So the issue was just that we have a lot of violations, most of them coming

[PATCH 3/3] xen/ppc: Implement a basic exception handler

2023-09-28 Thread Shawn Anastasio
Implement a basic exception handler that dumps the CPU state to the console, as well as the code required to set the correct exception vector table's base address in setup.c. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/processor.h | 31 +++ xen/arch/ppc/ppc64/Makefile

[PATCH 2/3] xen/ppc: Add .text.exceptions section for exception vectors

2023-09-28 Thread Shawn Anastasio
On Power, the exception vectors must lie at a fixed address, depending on the state of the Alternate Interrupt Location (AIL) field of the Logical Partition Control Register (LPCR). Create a .text.exceptions section in the linker script at an address suitable for AIL=3 plus an accompanying assertio

[PATCH 1/3] xen/ppc: Fix stack initialization in head.S

2023-09-28 Thread Shawn Anastasio
The code to set up the stack in head.S erroneously loads the bottom of the stack (the symbol cpu0_boot_stack) into r1 instead of the top of the stack (cpu0_boot_stack + STACK_SIZE). Fixes: 3a4e6f67bc68 ("xen/ppc: Set up a basic C environment") Signed-off-by: Shawn Anastasio --- xen/arch/ppc/ppc6

[PATCH] bitmap: fix n__ signess

2023-09-28 Thread Stefano Stabellini
All callers of the bitmap_switch macro (which are all within bitmap.h) pass an int as first parameter. Do not assign it to an unsigned int potentially introducing errors. Signed-off-by: Stefano Stabellini --- We could also have gone the other way and change all the callers and the callers' calle

[PATCH 0/3] Early exception handlers on Power

2023-09-28 Thread Shawn Anastasio
Hello all, This series implements a basic exception handler and the required support infrastructure on Power. Currently the handler just dumps all registers to the serial console and nothing else, but even this is useful for debugging during early bring-up. An additional patch to fix the stack se

Re: [XEN PATCH v7 4/4] xen/x86: address violations of MISRA C:2012 Rule 7.2

2023-09-28 Thread Stefano Stabellini
On Thu, 28 Sep 2023, Simone Ballarin wrote: > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose > headline states: > "A 'u' or 'U' suffix shall be applied to all integer constants > that are represented in an unsigned type". > > Add the 'U' suffix to integers literals with unsigne

Re: [XEN PATCH v7 3/4] x86/include: address violations of MISRA C:2012 Rule 7.2

2023-09-28 Thread Stefano Stabellini
On Thu, 28 Sep 2023, Simone Ballarin wrote: > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose > headline states: > "A 'u' or 'U' suffix shall be applied to all integer constants > that are represented in an unsigned type". > > Add the 'U' suffix to integers literals with unsigne

Re: [XEN PATCH v2 1/3] docs/misra: add documentation skeleton for MISRA C:2012 Dir 4.1

2023-09-28 Thread Stefano Stabellini
On Thu, 28 Sep 2023, Nicola Vetrini wrote: > On 28/09/2023 02:55, Stefano Stabellini wrote: > > On Wed, 27 Sep 2023, Nicola Vetrini wrote: > > > The aforementioned directive requires the project to supply documentation > > > on the measures taken towards the minimization of run-time failures. > >

Re: [XEN PATCH v2 00/10] address violations of MISRA C:2012 Directive 4.10

2023-09-28 Thread Stefano Stabellini
On Thu, 28 Sep 2023, Jan Beulich wrote: > On 28.09.2023 15:17, Simone Ballarin wrote: > > On 28/09/23 14:51, Jan Beulich wrote: > >> On 28.09.2023 14:46, Simone Ballarin wrote: > >>> On 13/09/23 10:02, Jan Beulich wrote: > On 12.09.2023 11:36, Simone Ballarin wrote: > > Add or move inclusi

Re: changing Dom0 data during smc call inside of xen during cache coloring

2023-09-28 Thread Stefano Stabellini
On Thu, 28 Sep 2023, Oleg Nikitenko wrote: > Hello Julien, > > I am still fighting with xen Cache Coloring with aes. > When I sent a request to hardware aes after xen with CC started I got the > mistake in CSU. > When I dumped structure contents on both sides I got the different data. > Xilinx re

Re: [PATCH v3] SUPPORT: downgrade Physical CPU Hotplug to Experimental

2023-09-28 Thread Stefano Stabellini
On Thu, 28 Sep 2023, Roger Pau Monné wrote: > On Thu, Sep 28, 2023 at 11:32:22AM +0200, Jan Beulich wrote: > > On 28.09.2023 10:32, Roger Pau Monné wrote: > > > On Wed, Sep 27, 2023 at 04:20:04PM -0700, Stefano Stabellini wrote: > > >> From: Stefano Stabellini > > >> > > >> The feature is not comm

Re: [PATCH] xen/arm: Validate generic timer frequency

2023-09-28 Thread Stefano Stabellini
On Thu, 27 Sep 2023, Michal Orzel wrote: > Generic timer dt node property "clock-frequency" (refer Linux dt binding > Documentation/devicetree/bindings/timer/arm,arch_timer.yaml) is used to > override the incorrect value set by firmware in CNTFRQ_EL0. If the value > of this property is 0 (i.e. by m

Re: [PATCH v9 15/16] xen/arm: vpci: check guest range

2023-09-28 Thread Stewart Hildebrand
On 9/28/23 04:28, Roger Pau Monné wrote: > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Wed, Sep 27, 2023 at 02:03:30PM -0400, Stewart Hildebrand wrote: >> On 9/26/23 11:48, Roger Pau Monné wro

Re: Misra rule 10.3 violations report script

2023-09-28 Thread Ayan Kumar Halder
On 28/09/2023 09:34, Luca Fancellu wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. Hi all, Hi Luca, In the last MISRA meeting Stefano told me about the Rule

Re: [PATCH v11 35/37] x86/syscall: Split IDT syscall setup code into idt_syscall_init()

2023-09-28 Thread Thomas Gleixner
On Mon, Sep 25 2023 at 09:07, H. Peter Anvin wrote: > On September 23, 2023 2:42:10 AM PDT, Xin Li wrote: >>+/* May not be marked __init: used by software suspend */ >>+void syscall_init(void) >>+{ >>+ /* The default user and kernel segments */ >>+ wrmsr(MSR_STAR, 0, (__USER32_CS << 16) |

[libvirt test] 183201: tolerable all pass - PUSHED

2023-09-28 Thread osstest service owner
flight 183201 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/183201/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183188 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [PATCH 11/15] sgi-xp: Remove the now superfluous sentinel element from ctl_table array

2023-09-28 Thread Steve Wahl
On Thu, Sep 28, 2023 at 03:21:36PM +0200, Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel a

Re: [PATCH 00/15] sysctl: Remove sentinel elements from drivers

2023-09-28 Thread Christophe Leroy
Le 28/09/2023 à 15:21, Joel Granados via B4 Relay a écrit : > From: Joel Granados Automatic test fails on powerpc, see https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20230928-jag-sysctl_remove_empty_elem_drivers-v1-15-e59120fca...@samsung.com/ Kernel attempted to read user p

[linux-5.4 test] 183199: regressions - FAIL

2023-09-28 Thread osstest service owner
flight 183199 linux-5.4 real [real] flight 183204 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183199/ http://logs.test-lab.xenproject.org/osstest/logs/183204/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: t

Re: [XEN PATCH v2 1/3] docs/misra: add documentation skeleton for MISRA C:2012 Dir 4.1

2023-09-28 Thread Nicola Vetrini
On 28/09/2023 02:55, Stefano Stabellini wrote: On Wed, 27 Sep 2023, Nicola Vetrini wrote: The aforementioned directive requires the project to supply documentation on the measures taken towards the minimization of run-time failures. + +Documentation for MISRA C:2012 Dir 4.1: mistyped access

Re: [XEN PATCH v2 00/10] address violations of MISRA C:2012 Directive 4.10

2023-09-28 Thread Simone Ballarin
On 28/09/23 17:00, Jan Beulich wrote: On 28.09.2023 15:17, Simone Ballarin wrote: On 28/09/23 14:51, Jan Beulich wrote: On 28.09.2023 14:46, Simone Ballarin wrote: On 13/09/23 10:02, Jan Beulich wrote: On 12.09.2023 11:36, Simone Ballarin wrote: Add or move inclusion guards to address violat

Re: [PATCH 14/15] hyper-v/azure: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Wei Liu
Please change the prefix to "Drivers: hv:" in the subject line in the two patches. On Thu, Sep 28, 2023 at 03:21:39PM +0200, Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_tabl

Re: [PATCH 1/2] xen: evtchn: Allow shared registration of IRQ handers

2023-09-28 Thread Juergen Gross
On 29.08.23 14:29, Viresh Kumar wrote: Currently the handling of events is supported either in the kernel or userspace, but not both. In order to support fast delivery of interrupts from the guest to the backend, we need to handle the Queue notify part of Virtio protocol in kernel and the rest i

[XEN PATCH v7 3/4] x86/include: address violations of MISRA C:2012 Rule 7.2

2023-09-28 Thread Simone Ballarin
The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline states: "A 'u' or 'U' suffix shall be applied to all integer constants that are represented in an unsigned type". Add the 'U' suffix to integers literals with unsigned type. Use _AC() for macro costants that are used also

[XEN PATCH v7 1/4] x86/vmx: address violations of MISRA C:2012 Rule 7.2

2023-09-28 Thread Simone Ballarin
From: Gianluca Luparini The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline states: "A 'u' or 'U' suffix shall be applied to all integer constants that are represented in an unsigned type". Add the 'U' suffix to integers literals with unsigned type. For the sake of unifo

[XEN PATCH v7 0/4] xen/x86: address violations of MISRA C:2012 Rule 7.2

2023-09-28 Thread Simone Ballarin
The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline states: "A 'u' or 'U' suffix shall be applied to all integer constants that are represented in an unsigned type". These violations are caused by the missing "u" or "U" suffix in unsigned integer constants, such as: xen/ar

[XEN PATCH v7 4/4] xen/x86: address violations of MISRA C:2012 Rule 7.2

2023-09-28 Thread Simone Ballarin
The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline states: "A 'u' or 'U' suffix shall be applied to all integer constants that are represented in an unsigned type". Add the 'U' suffix to integers literals with unsigned type. For the sake of uniformity, the following chang

[XEN PATCH v7 2/4] x86/hvm: address violations of MISRA C:2012 Rule 7.2

2023-09-28 Thread Simone Ballarin
The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline states: "A 'u' or 'U' suffix shall be applied to all integer constants that are represented in an unsigned type". Add the 'U' suffix to integers literals with unsigned type. For the sake of uniformity, the following chang

Re: [PATCH 13/15] raid: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Song Liu
On Thu, Sep 28, 2023 at 6:20 AM Joel Granados via B4 Relay wrote: > > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel and run t

Re: [XEN PATCH v2 00/10] address violations of MISRA C:2012 Directive 4.10

2023-09-28 Thread Jan Beulich
On 28.09.2023 15:17, Simone Ballarin wrote: > On 28/09/23 14:51, Jan Beulich wrote: >> On 28.09.2023 14:46, Simone Ballarin wrote: >>> On 13/09/23 10:02, Jan Beulich wrote: On 12.09.2023 11:36, Simone Ballarin wrote: > Add or move inclusion guards to address violations of > MISRA C:201

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-28 Thread Leo Yan
Hi Michal, Julien, On Wed, Sep 27, 2023 at 02:49:23PM +0200, Michal Orzel wrote: [...] > Either way is fine. The advantage of placing the check in boot_fdt_info() is > that we can have a single check instead of duplicated and we do the check > before > the "first" use which happens to be the ba

[PATCH v2] xen/arm: Skip memory nodes if not enabled

2023-09-28 Thread Leo Yan
Currently, the Xen hypervisor doesn't handle the status, the issue can be described from two perspectives: the memory nodes and the reserved memory nodes. - If a memory node has a status "disabled" it implies that it should not be used. Xen does not handle the status property for the memory no

Re: [PATCH v4 5/9] x86/mem-sharing: copy GADDR based shared guest areas

2023-09-28 Thread Roger Pau Monné
On Thu, Sep 28, 2023 at 08:57:04AM -0400, Tamas K Lengyel wrote: > On Thu, Sep 28, 2023 at 7:08 AM Roger Pau Monné wrote: > > > > On Thu, Sep 28, 2023 at 12:11:02PM +0200, Jan Beulich wrote: > > > On 28.09.2023 11:51, Roger Pau Monné wrote: > > > > On Thu, Sep 28, 2023 at 09:16:20AM +0200, Jan Beu

Re: [PATCH] xen/arm: Validate generic timer frequency

2023-09-28 Thread Luca Fancellu
> On 28 Sep 2023, at 13:34, Michal Orzel wrote: > > Generic timer dt node property "clock-frequency" (refer Linux dt binding > Documentation/devicetree/bindings/timer/arm,arch_timer.yaml) is used to > override the incorrect value set by firmware in CNTFRQ_EL0. If the value > of this property i

Beginner looking to contribute to project in archived list

2023-09-28 Thread Sahil
Hi, I have never contributed to the Xen Project before. I am interested in virtualization, firmware and low-level systems programming. I would like to start contributing to Xen and learn more about these fields while working on the job. I was going through the archived project listings [1] in t

Re: [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Greg Kroah-Hartman
On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel a

Re: [PATCH 03/15] xen: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Juergen Gross
On 28.09.23 15:21, Joel Granados via B4 Relay wrote: From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64

[PATCH 11/15] sgi-xp: Remove the now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 10/15] vrf: Remove the now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 00/15] sysctl: Remove sentinel elements from drivers

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados What? These commits remove the sentinel element (last empty element) from the sysctl arrays of all the files under the "drivers/" directory that use a sysctl array for registration. The merging of the preparation patches (in https://lore.kernel.org/all/zo5yx5jfoggi%2f...@bomba

[PATCH 09/15] char-misc: Remove the now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 02/15] hpet: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 06/15] parport: Remove the now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 15/15] intel drm: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 13/15] raid: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 14/15] hyper-v/azure: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 08/15] infiniband: Remove the now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 12/15] fw loader: Remove the now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 05/15] scsi: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 07/15] macintosh: Remove the now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH 03/15] xen: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

Re: [PATCH v4 5/9] x86/mem-sharing: copy GADDR based shared guest areas

2023-09-28 Thread Jan Beulich
On 28.09.2023 14:57, Tamas K Lengyel wrote: > On Thu, Sep 28, 2023 at 7:08 AM Roger Pau Monné wrote: >> On Thu, Sep 28, 2023 at 12:11:02PM +0200, Jan Beulich wrote: >>> On 28.09.2023 11:51, Roger Pau Monné wrote: On Thu, Sep 28, 2023 at 09:16:20AM +0200, Jan Beulich wrote: > +/* >

Re: [XEN PATCH v2 00/10] address violations of MISRA C:2012 Directive 4.10

2023-09-28 Thread Simone Ballarin
On 28/09/23 14:51, Jan Beulich wrote: On 28.09.2023 14:46, Simone Ballarin wrote: On 13/09/23 10:02, Jan Beulich wrote: On 12.09.2023 11:36, Simone Ballarin wrote: Add or move inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent

Re: [XEN PATCH v2 00/10] address violations of MISRA C:2012 Directive 4.10

2023-09-28 Thread Jan Beulich
On 28.09.2023 14:46, Simone Ballarin wrote: > On 13/09/23 10:02, Jan Beulich wrote: >> On 12.09.2023 11:36, Simone Ballarin wrote: >>> Add or move inclusion guards to address violations of >>> MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order >>> to prevent the contents of a header

Re: [XEN PATCH v2 00/10] address violations of MISRA C:2012 Directive 4.10

2023-09-28 Thread Simone Ballarin
On 13/09/23 10:02, Jan Beulich wrote: On 12.09.2023 11:36, Simone Ballarin wrote: Add or move inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Inclusion guards mu

[PATCH] xen/arm: Validate generic timer frequency

2023-09-28 Thread Michal Orzel
Generic timer dt node property "clock-frequency" (refer Linux dt binding Documentation/devicetree/bindings/timer/arm,arch_timer.yaml) is used to override the incorrect value set by firmware in CNTFRQ_EL0. If the value of this property is 0 (i.e. by mistake), Xen would continue to work and use the v

Re: [PATCH v4 3/9] domain: update GADDR based runstate guest area

2023-09-28 Thread Julien Grall
Hi Jan, On 28/09/2023 08:15, Jan Beulich wrote: Before adding a new vCPU operation to register the runstate area by guest-physical address, add code to actually keep such areas up-to-date. Note that updating of the area will be done exclusively following the model enabled by VMASST_TYPE_runstat

[XEN v2] xen: arm: procinfo.h: Fixed a typo

2023-09-28 Thread Ayan Kumar Halder
Change VPCU to vCPU. Also add a space before '*/'. Signed-off-by: Ayan Kumar Halder Acked-by: Julien Grall --- Changes from - v1 - 1. Change VCPU --> vCPU. 2. Add a space before '*/'. xen/arch/arm/include/asm/procinfo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/

Re: [XEN v1] xen: arm: procinfo.h: Fixed a typo

2023-09-28 Thread Ayan Kumar Halder
On 28/09/2023 12:57, Julien Grall wrote: Hi Ayan, Hi Julien, On 28/09/2023 12:48, Ayan Kumar Halder wrote: Change VPCU to VCPU. Signed-off-by: Ayan Kumar Halder ---   xen/arch/arm/include/asm/procinfo.h | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/inc

Re: [XEN PATCH v6 2/7] x86/hvm: address violations of MISRA C:2012 Rule 7.2

2023-09-28 Thread Simone Ballarin
On 28/09/23 14:01, Jan Beulich wrote: On 28.09.2023 13:11, Simone Ballarin wrote: On 13/09/23 11:44, Jan Beulich wrote: On 12.09.2023 17:38, Simone Ballarin wrote: The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline states: "A 'u' or 'U' suffix shall be applied to all i

Re: [XEN PATCH v6 2/7] x86/hvm: address violations of MISRA C:2012 Rule 7.2

2023-09-28 Thread Jan Beulich
On 28.09.2023 13:11, Simone Ballarin wrote: > On 13/09/23 11:44, Jan Beulich wrote: >> On 12.09.2023 17:38, Simone Ballarin wrote: >>> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose >>> headline states: >>> "A 'u' or 'U' suffix shall be applied to all integer constants >>> that

Re: [XEN v1] xen: arm: procinfo.h: Fixed a typo

2023-09-28 Thread Julien Grall
Hi Ayan, On 28/09/2023 12:48, Ayan Kumar Halder wrote: Change VPCU to VCPU. Signed-off-by: Ayan Kumar Halder --- xen/arch/arm/include/asm/procinfo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/procinfo.h b/xen/arch/arm/include/asm/procinfo

[XEN v1] xen: arm: procinfo.h: Fixed a typo

2023-09-28 Thread Ayan Kumar Halder
Change VPCU to VCPU. Signed-off-by: Ayan Kumar Halder --- xen/arch/arm/include/asm/procinfo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/procinfo.h b/xen/arch/arm/include/asm/procinfo.h index 02be56e348..8b8dae3dd4 100644 --- a/xen/arch/arm/incl

Re: [PATCH v3 8/8] common: convert vCPU info area registration

2023-09-28 Thread Roger Pau Monné
On Thu, Sep 28, 2023 at 12:35:23PM +0200, Jan Beulich wrote: > On 28.09.2023 12:15, Roger Pau Monné wrote: > > On Thu, Sep 28, 2023 at 11:53:36AM +0200, Jan Beulich wrote: > >> On 28.09.2023 10:24, Roger Pau Monné wrote: > >>> On Wed, May 03, 2023 at 05:58:30PM +0200, Jan Beulich wrote: > @@ -

Re: [XEN PATCH v6 2/7] x86/hvm: address violations of MISRA C:2012 Rule 7.2

2023-09-28 Thread Simone Ballarin
On 13/09/23 11:44, Jan Beulich wrote: On 12.09.2023 17:38, Simone Ballarin wrote: The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline states: "A 'u' or 'U' suffix shall be applied to all integer constants that are represented in an unsigned type". Add the 'U' suffix to i

Re: [PATCH v4 6/9] domain: map/unmap GADDR based shared guest areas

2023-09-28 Thread Roger Pau Monné
On Thu, Sep 28, 2023 at 12:14:17PM +0200, Jan Beulich wrote: > On 28.09.2023 12:04, Roger Pau Monné wrote: > > On Thu, Sep 28, 2023 at 09:16:48AM +0200, Jan Beulich wrote: > >> The registration by virtual/linear address has downsides: At least on > >> x86 the access is expensive for HVM/PVH domains

Re: [PATCH v4 5/9] x86/mem-sharing: copy GADDR based shared guest areas

2023-09-28 Thread Roger Pau Monné
On Thu, Sep 28, 2023 at 12:11:02PM +0200, Jan Beulich wrote: > On 28.09.2023 11:51, Roger Pau Monné wrote: > > On Thu, Sep 28, 2023 at 09:16:20AM +0200, Jan Beulich wrote: > >> --- a/xen/arch/x86/mm/mem_sharing.c > >> +++ b/xen/arch/x86/mm/mem_sharing.c > >> @@ -1641,6 +1641,68 @@ static void copy_

Re: [XEN PATCH] x86/domain_page: address violations of MISRA C:2012 Rule 8.3

2023-09-28 Thread Federico Serafini
On 28/09/23 08:25, Jan Beulich wrote: On 27.09.2023 17:09, Federico Serafini wrote: Make function declarations and definitions consistent. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/domain_page.c | 36 ++-- 1 file changed, 18 inse

Re: [PATCH v3 8/8] common: convert vCPU info area registration

2023-09-28 Thread Jan Beulich
On 28.09.2023 12:15, Roger Pau Monné wrote: > On Thu, Sep 28, 2023 at 11:53:36AM +0200, Jan Beulich wrote: >> On 28.09.2023 10:24, Roger Pau Monné wrote: >>> On Wed, May 03, 2023 at 05:58:30PM +0200, Jan Beulich wrote: @@ -1633,14 +1528,44 @@ int map_guest_area(struct vcpu *v, paddr >>>

[linux-linus test] 183196: tolerable FAIL - PUSHED

2023-09-28 Thread osstest service owner
flight 183196 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183196/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 183189 Tests which did not succeed,

Re: [PATCH v3 8/8] common: convert vCPU info area registration

2023-09-28 Thread Roger Pau Monné
On Thu, Sep 28, 2023 at 11:53:36AM +0200, Jan Beulich wrote: > On 28.09.2023 10:24, Roger Pau Monné wrote: > > On Wed, May 03, 2023 at 05:58:30PM +0200, Jan Beulich wrote: > >> Switch to using map_guest_area(). Noteworthy differences from > >> map_vcpu_info(): > >> - remote vCPU-s are paused rather

Re: [PATCH v4 6/9] domain: map/unmap GADDR based shared guest areas

2023-09-28 Thread Jan Beulich
On 28.09.2023 12:04, Roger Pau Monné wrote: > On Thu, Sep 28, 2023 at 09:16:48AM +0200, Jan Beulich wrote: >> The registration by virtual/linear address has downsides: At least on >> x86 the access is expensive for HVM/PVH domains. Furthermore for 64-bit >> PV domains the areas are inaccessible (an

Re: [PATCH v4 5/9] x86/mem-sharing: copy GADDR based shared guest areas

2023-09-28 Thread Jan Beulich
On 28.09.2023 11:51, Roger Pau Monné wrote: > On Thu, Sep 28, 2023 at 09:16:20AM +0200, Jan Beulich wrote: >> --- a/xen/arch/x86/mm/mem_sharing.c >> +++ b/xen/arch/x86/mm/mem_sharing.c >> @@ -1641,6 +1641,68 @@ static void copy_vcpu_nonreg_state(struc >> hvm_set_nonreg_state(cd_vcpu, &nrs); >>

Re: [PATCH v4 6/9] domain: map/unmap GADDR based shared guest areas

2023-09-28 Thread Roger Pau Monné
On Thu, Sep 28, 2023 at 09:16:48AM +0200, Jan Beulich wrote: > The registration by virtual/linear address has downsides: At least on > x86 the access is expensive for HVM/PVH domains. Furthermore for 64-bit > PV domains the areas are inaccessible (and hence cannot be updated by > Xen) when in guest

Re: [PATCH v3 8/8] common: convert vCPU info area registration

2023-09-28 Thread Jan Beulich
On 28.09.2023 10:24, Roger Pau Monné wrote: > On Wed, May 03, 2023 at 05:58:30PM +0200, Jan Beulich wrote: >> Switch to using map_guest_area(). Noteworthy differences from >> map_vcpu_info(): >> - remote vCPU-s are paused rather than checked for being down (which in >> principle can change right

Re: [PATCH v3] SUPPORT: downgrade Physical CPU Hotplug to Experimental

2023-09-28 Thread Roger Pau Monné
On Thu, Sep 28, 2023 at 11:32:22AM +0200, Jan Beulich wrote: > On 28.09.2023 10:32, Roger Pau Monné wrote: > > On Wed, Sep 27, 2023 at 04:20:04PM -0700, Stefano Stabellini wrote: > >> From: Stefano Stabellini > >> > >> The feature is not commonly used, and we don't have hardware to test it, > >> n

Re: [PATCH v4 5/9] x86/mem-sharing: copy GADDR based shared guest areas

2023-09-28 Thread Roger Pau Monné
On Thu, Sep 28, 2023 at 09:16:20AM +0200, Jan Beulich wrote: > In preparation of the introduction of new vCPU operations allowing to > register the respective areas (one of the two is x86-specific) by > guest-physical address, add the necessary fork handling (with the > backing function yet to be f

Re: [PATCH v3] SUPPORT: downgrade Physical CPU Hotplug to Experimental

2023-09-28 Thread Jan Beulich
On 28.09.2023 10:32, Roger Pau Monné wrote: > On Wed, Sep 27, 2023 at 04:20:04PM -0700, Stefano Stabellini wrote: >> From: Stefano Stabellini >> >> The feature is not commonly used, and we don't have hardware to test it, >> not in OSSTest, not in Gitlab, and not even ad-hoc manually by community >

Re: changing Dom0 data during smc call inside of xen during cache coloring

2023-09-28 Thread Oleg Nikitenko
Hello Julien, I am still fighting with xen Cache Coloring with aes. When I sent a request to hardware aes after xen with CC started I got the mistake in CSU. When I dumped structure contents on both sides I got the different data. Xilinx related contact wrote to me. When cache coloring is enabled

Re: [PATCH v4 1/9] x86/shim: zap runstate and time area handles during shutdown

2023-09-28 Thread Roger Pau Monné
On Thu, Sep 28, 2023 at 09:01:53AM +0200, Jan Beulich wrote: > While likely the guest would just re-register the same areas after > a possible resume, let's not take this for granted and avoid the risk of > otherwise corrupting guest memory. > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Mon

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-28 Thread Bertrand Marquis
> On 28 Sep 2023, at 02:40, Stefano Stabellini wrote: > > On Wed, 27 Sep 2023, Bertrand Marquis wrote: >>> On 27 Sep 2023, at 09:53, Nicola Vetrini wrote: >>> >> diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c >> index 695d2fa1f1..2a8527cacc 100644 >> --- a/xen/arch/arm/ps

Re: [PATCH v2] docs/misra: add rule 2.1 exceptions

2023-09-28 Thread Bertrand Marquis
Hi Stefano, > On 24 Aug 2023, at 00:39, Stefano Stabellini wrote: > > From: Stefano Stabellini > > During the discussions that led to the acceptance of Rule 2.1, we > decided on a few exceptions that were not properly recorded in > rules.rst. Add them now. > > Signed-off-by: Stefano Stabellin

Misra rule 10.3 violations report script

2023-09-28 Thread Luca Fancellu
Hi all, In the last MISRA meeting Stefano told me about the Rule 10.3 and that we have a lot of violations, but GCC has a way to list them as written in rules.rst. So the issue was just that we have a lot of violations, most of them coming from headers and the Developer might feel a bit lost si

Re: [PATCH v3] SUPPORT: downgrade Physical CPU Hotplug to Experimental

2023-09-28 Thread Roger Pau Monné
On Wed, Sep 27, 2023 at 04:20:04PM -0700, Stefano Stabellini wrote: > From: Stefano Stabellini > > The feature is not commonly used, and we don't have hardware to test it, > not in OSSTest, not in Gitlab, and not even ad-hoc manually by community > members. We could use QEMU to test it, but even

Re: Xen(arm64) hang on suspend/resume

2023-09-28 Thread Julien Grall
On 25/09/2023 12:15, Jonas Blixt wrote: Hello, Hi, I've encountered a strange behavior with Xen on arm64 with regards to suspend/resume. My setup: Version: Xen 4.13.1 This has been relaesed in 2019 and not even the latest point release for 4.13 (it is 4.13.5). For new development, I

Re: [PATCH v9 15/16] xen/arm: vpci: check guest range

2023-09-28 Thread Roger Pau Monné
On Wed, Sep 27, 2023 at 02:03:30PM -0400, Stewart Hildebrand wrote: > On 9/26/23 11:48, Roger Pau Monné wrote: > > On Tue, Sep 26, 2023 at 11:27:48AM -0400, Stewart Hildebrand wrote: > >> On 9/26/23 04:07, Roger Pau Monné wrote: > >>> On Mon, Sep 25, 2023 at 05:49:00PM -0400, Stewart Hildebrand wro

  1   2   >