Re: [PATCH 2/2] xen: privcmd: Add support for ioeventfd

2023-10-04 Thread Viresh Kumar
On 29-09-23, 07:46, Juergen Gross wrote: > On 29.08.23 14:29, Viresh Kumar wrote: > > +static irqreturn_t ioeventfd_interrupt(int irq, void *dev_id) > > +{ > > + struct ioreq_port *port = dev_id; > > + struct privcmd_kernel_ioreq *kioreq = port->kioreq; > > + struct ioreq *ioreq = &kioreq->io

Re: [PATCH v12 00/37] x86: enable FRED for x86-64

2023-10-04 Thread Nikolay Borisov
On 3.10.23 г. 9:24 ч., Xin Li wrote: This patch set enables the Intel flexible return and event delivery (FRED) architecture for x86-64. Which tree is this based on now? I tried running 'b4 diff' but it complains it can't find some context around arch/x86/kernel/cpu/common.c . I have the

[linux-linus test] 183265: tolerable FAIL - PUSHED

2023-10-04 Thread osstest service owner
flight 183265 linux-linus real [real] flight 183267 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183265/ http://logs.test-lab.xenproject.org/osstest/logs/183267/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-

Re: [XEN PATCH v3] xen/mm: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-10-04 Thread Henry Wang
Hi, > On Oct 4, 2023, at 04:54, Stefano Stabellini wrote: > > On Tue, 3 Oct 2023, Federico Serafini wrote: >> Add missing parameter names and make function declarations and definitions >> consistent. No functional change. >> >> Signed-off-by: Federico Serafini > > Reviewed-by: Stefano Stabell

Re: [PATCH v5 00/10] runstate/time area registration by (guest) physical address

2023-10-04 Thread Henry Wang
Hi Roger, > On Oct 2, 2023, at 23:11, Roger Pau Monne wrote: > > Since it was indicated that introducing specific new vCPU ops may be > beneficial independent of the introduction of a fully physical- > address-based ABI flavor, here we go. There continue to be a few open > questions throughout t

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Elliott Mitchell
On Wed, Oct 04, 2023 at 03:52:54PM -0700, Stefano Stabellini wrote: > On Wed, 4 Oct 2023, Julien Grall wrote: > > > > If we want to handle such firmware, I think it would be better if we > > > > provide > > > > an hypercall that would return the GFN where it is currently mapped. > > > > > > Sure,

SAF-x-safe rename

2023-10-04 Thread Stefano Stabellini
Hi MISRA C working group (Jan, Roger, Andrew, Julien, Bertrand, George) in a recent thread Andrew pointed out that the SAF-2-safe tag is confusing and requested a rename: https://marc.info/?l=xen-devel&m=169634970821202 As documented by docs/misra/documenting-violations.rst: - SAF-X-safe: This

Re: [XEN PATCH] xen: Add SAF deviations for MISRA C:2012 Rule 7.1

2023-10-04 Thread Stefano Stabellini
On Wed, 4 Oct 2023, Luca Fancellu wrote: > > On 4 Oct 2023, at 11:29, Nicola Vetrini wrote: > > On 04/10/2023 12:06, Luca Fancellu wrote: > >> Hi Nicola, > >>> On 4 Oct 2023, at 10:56, andrew.coop...@citrix.com wrote: > >>> On 03/10/2023 9:46 pm, Stefano Stabellini wrote: > On Tue, 3 Oct 2023

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-10-04 Thread Stefano Stabellini
On Wed, 4 Oct 2023, Julien Grall wrote: > On 03/10/2023 21:40, Stefano Stabellini wrote: > > On Tue, 3 Oct 2023, Julien Grall wrote: > > > On 03/10/2023 20:52, Stefano Stabellini wrote: > > > > On Tue, 3 Oct 2023, Michal Orzel wrote: > > > > > On 03/10/2023 09:44, Luca Fancellu wrote: > > > > > > G

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Stefano Stabellini
On Wed, 4 Oct 2023, Julien Grall wrote: > > > This is not very different here. For Arm we decided to not follow a > > > behavior > > > that I consider incorrect and potentially more harmful than trying to > > > support bootloader not removing the shared page. > > > > I think this is not very frien

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Stefano Stabellini
On Wed, 4 Oct 2023, Elliott Mitchell wrote: > On Wed, Oct 04, 2023 at 03:21:04PM -0700, Stefano Stabellini wrote: > > On Wed, 4 Oct 2023, Elliott Mitchell wrote: > > > On Wed, Oct 04, 2023 at 03:39:16PM +0200, Roger Pau Monné wrote: > > > > On Wed, Oct 04, 2023 at 02:03:43PM +0100, Julien Grall wro

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Elliott Mitchell
On Wed, Oct 04, 2023 at 03:21:04PM -0700, Stefano Stabellini wrote: > On Wed, 4 Oct 2023, Elliott Mitchell wrote: > > On Wed, Oct 04, 2023 at 03:39:16PM +0200, Roger Pau Monné wrote: > > > On Wed, Oct 04, 2023 at 02:03:43PM +0100, Julien Grall wrote: > > > > > > > > On 04/10/2023 13:53, Roger Pau

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Stefano Stabellini
On Wed, 4 Oct 2023, Elliott Mitchell wrote: > On Wed, Oct 04, 2023 at 03:39:16PM +0200, Roger Pau Monné wrote: > > On Wed, Oct 04, 2023 at 02:03:43PM +0100, Julien Grall wrote: > > > > > > On 04/10/2023 13:53, Roger Pau Monné wrote: > > > > > > > > When using UEFI there's RAM that will always be

Re: [PATCH v6 06/10] x86/mem-sharing: copy GADDR based shared guest areas

2023-10-04 Thread Tamas K Lengyel
On Wed, Oct 4, 2023 at 9:54 AM Roger Pau Monne wrote: > > From: Jan Beulich > > In preparation of the introduction of new vCPU operations allowing to > register the respective areas (one of the two is x86-specific) by > guest-physical address, add the necessary fork handling (with the > backing f

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Elliott Mitchell
Heavily trimming earlier messages. Also doing one response to cover several items. Hopefully I'm not missing something which needs a response. On Wed, Oct 04, 2023 at 03:39:16PM +0200, Roger Pau Monné wrote: > On Wed, Oct 04, 2023 at 02:03:43PM +0100, Julien Grall wrote: > > > > On 04/10/2023

Re: [PATCH] net/xen-netback: Break build if netback slots > max_skbs + 1

2023-10-04 Thread Jakub Kicinski
On Wed, 27 Sep 2023 11:29:18 +0300 David Kahurani wrote: > If XEN_NETBK_LEGACY_SLOTS_MAX and MAX_SKB_FRAGS have a difference of > more than 1, with MAX_SKB_FRAGS being the lesser value, it opens up a > path for null-dereference. It was also noted that some distributions > were modifying upstream be

[ovmf test] 183263: all pass - PUSHED

2023-10-04 Thread osstest service owner
flight 183263 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183263/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d073a545119140070c83e4b2b249bf0448c6f89e baseline version: ovmf 1497c4b074946f3ad9d46

Re: [PATCH v2 1/3] xen/arm: pci: introduce PCI_PASSTHROUGH Kconfig option

2023-10-04 Thread Stewart Hildebrand
On 7/20/23 05:20, Julien Grall wrote: > Hi, > > On 18/07/2023 18:35, Stewart Hildebrand wrote: >> On 7/13/23 14:40, Julien Grall wrote: >>> Hi Stewart, >>> >>> On 07/07/2023 02:47, Stewart Hildebrand wrote: From: Rahul Singh Setting CONFIG_PCI_PASSTHROUGH=y will enable PCI passthro

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Julien Grall
Hi, On 04/10/2023 15:53, Roger Pau Monné wrote: On Wed, Oct 04, 2023 at 03:06:14PM +0100, Julien Grall wrote: Neither of the two behaviors help the users. In fact, I think they only make the experience worse because you don't know when the issue will happen. AFAICT, there is no way for an HVM

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-10-04 Thread Julien Grall
Hi, On 03/10/2023 21:40, Stefano Stabellini wrote: On Tue, 3 Oct 2023, Julien Grall wrote: On 03/10/2023 20:52, Stefano Stabellini wrote: On Tue, 3 Oct 2023, Michal Orzel wrote: On 03/10/2023 09:44, Luca Fancellu wrote: Given that the status after the move to common of the above functions is

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Oleksandr Tyshchenko
On 04.10.23 15:59, Roger Pau Monné wrote: Hello Roger > On Wed, Oct 04, 2023 at 11:42:32AM +, Oleksandr Tyshchenko wrote: >> >> >> On 04.10.23 13:55, Julien Grall wrote: >> >> Hello all. >> >>> Hi Roger, >>> >>> On 04/10/2023 09:13, Roger Pau Monné wrote: On Tue, Oct 03, 2023 at 12:1

Re: [PATCH v5 10/10] common: convert vCPU info area registration

2023-10-04 Thread Julien Grall
Hi Roger, On 02/10/2023 16:11, Roger Pau Monne wrote: From: Jan Beulich Switch to using map_guest_area(). Noteworthy differences from map_vcpu_info(): - remote vCPU-s are paused rather than checked for being down (which in principle can change right after the check), - the domain lock is ta

Re: [PATCH] arm/ioreq: clean data field in ioreq struct on read operations

2023-10-04 Thread Julien Grall
On 04/10/2023 09:42, Andrii Chepurnyi wrote: Hello, Hi, On 10/3/23 16:49, Julien Grall wrote: Hi, On 03/10/2023 14:19, Andrii Chepurnyi wrote: For read operations, there's a potential issue when the data field of the ioreq struct is partially updated in the response. To address this, zero

[PATCH v5 7/9] xen/arm: Fix mapping for PCI bridge mmio region

2023-10-04 Thread Stewart Hildebrand
From: Rahul Singh Current code skip the mapping for PCI bridge MMIO region to dom0 when pci_passthrough_enabled flag is set. Mapping should be skip when has_vpci(d) is enabled for the domain, as we need to skip the mapping only when VPCI handler are registered for ECAM. Signed-off-by: Rahul Sing

[PATCH v5 9/9] xen/arm: Map ITS doorbell register to IOMMU page tables.

2023-10-04 Thread Stewart Hildebrand
From: Rahul Singh Signed-off-by: Rahul Singh --- v4->v5: * new patch --- xen/arch/arm/vgic-v3-its.c | 12 1 file changed, 12 insertions(+) diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c index 05429030b539..df8f045198a3 100644 --- a/xen/arch/arm/vgic-v3-its.c

[PATCH v5 8/9] Revert "xen/arm: Add cmdline boot option "pci-passthrough = ""

2023-10-04 Thread Stewart Hildebrand
From: Rahul Singh This enables us to use IOMMU + PCI in dom0 without having to specify "pci-passthrough=yes". This reverts commit 15517ed61f55be6039aedcc99720ee07c772ed44. --- v4->v5: * new patch --- docs/misc/xen-command-line.pandoc | 7 --- xen/arch/arm/include/asm/pci.h| 12

[PATCH v5 6/9] xen/arm: smmuv3: Add PCI devices support for SMMUv3

2023-10-04 Thread Stewart Hildebrand
From: Rahul Singh Signed-off-by: Rahul Singh Signed-off-by: Stewart Hildebrand --- v4->v5: * deassign from hwdom * add TODO regarding locking * fixup after dropping ("xen/arm: Move is_protected flag to struct device") v3->v4: * no change v2->v3: * rebase * invoke iommu_add_pci_sideband_ids()

[libvirt test] 183260: tolerable all pass - PUSHED

2023-10-04 Thread osstest service owner
flight 183260 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/183260/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183246 test-armhf-armhf-libvirt-qcow2 15 saveres

[PATCH v5 5/9] xen/arm: smmuv2: Add PCI devices support for SMMUv2

2023-10-04 Thread Stewart Hildebrand
From: Oleksandr Andrushchenko Signed-off-by: Oleksandr Tyshchenko Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Stewart Hildebrand --- v4->v5: * assign device to pdev->domain (usually dom0) by default in add_device() hook * deassign from hwdom * rebase on top of ("dynamic node programm

[PATCH v5 4/9] iommu/arm: iommu_add_dt_pci_sideband_ids phantom handling

2023-10-04 Thread Stewart Hildebrand
Handle phantom functions in iommu_add_dt_pci_sideband_ids(). Each phantom function will have a unique requestor ID (RID)/BDF. On ARM, we need to map/translate the RID/BDF to an AXI stream ID for each phantom function according to the pci-iommu device tree mapping [1]. The RID/BDF -> AXI stream ID m

[PATCH v5 3/9] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API

2023-10-04 Thread Stewart Hildebrand
From: Oleksandr Tyshchenko The main purpose of this patch is to add a way to register PCI device (which is behind the IOMMU) using the generic PCI-IOMMU DT bindings [1] before assigning that device to a domain. This behaves similarly to the existing iommu_add_dt_device API, except it handles PCI

[PATCH v5 2/9] iommu/arm: Add iommu_dt_xlate()

2023-10-04 Thread Stewart Hildebrand
From: Oleksandr Tyshchenko Move code for processing DT IOMMU specifier to a separate helper. This helper will be re-used for adding PCI devices by the subsequent patches as we will need exact the same actions for processing DT PCI-IOMMU specifier. While at it introduce NO_IOMMU to avoid magic "1

[PATCH v5 0/9] SMMU handling for PCIe Passthrough on ARM

2023-10-04 Thread Stewart Hildebrand
This series introduces SMMU handling for PCIe passthrough on ARM. These patches and should be able to be upstreamed independently from the vPCI series [1]. See [2] for notes about test cases. [1] https://lists.xenproject.org/archives/html/xen-devel/2023-08/msg02361.html [2] https://lists.xenprojec

[PATCH v5 1/9] xen/arm: don't pass iommu properties to hwdom for iommu-map

2023-10-04 Thread Stewart Hildebrand
A device tree node for a PCIe root controller may have an iommu-map property [1] with a phandle reference to the SMMU node, but not necessarily an iommus property. In this case, we want to treat it the same as we currently handle devices with an iommus property: don't pass the iommu related propert

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Roger Pau Monné
On Wed, Oct 04, 2023 at 03:06:14PM +0100, Julien Grall wrote: > Hi Roger, > > On 04/10/2023 14:39, Roger Pau Monné wrote: > > On Wed, Oct 04, 2023 at 02:03:43PM +0100, Julien Grall wrote: > > > Hi Roger, > > > > > > On 04/10/2023 13:53, Roger Pau Monné wrote: > > > > On Wed, Oct 04, 2023 at 11:55

[linux-linus test] 183259: tolerable FAIL - PUSHED

2023-10-04 Thread osstest service owner
flight 183259 linux-linus real [real] flight 183262 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183259/ http://logs.test-lab.xenproject.org/osstest/logs/183262/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Julien Grall
Hi Roger, On 04/10/2023 14:39, Roger Pau Monné wrote: On Wed, Oct 04, 2023 at 02:03:43PM +0100, Julien Grall wrote: Hi Roger, On 04/10/2023 13:53, Roger Pau Monné wrote: On Wed, Oct 04, 2023 at 11:55:05AM +0100, Julien Grall wrote: Hi Roger, On 04/10/2023 09:13, Roger Pau Monné wrote: On T

Re: [PATCH] arm/ioreq: clean data field in ioreq struct on read operations

2023-10-04 Thread Andrii Chepurnyi
Hello, On 10/3/23 16:49, Julien Grall wrote: > Hi, > > On 03/10/2023 14:19, Andrii Chepurnyi wrote: >> For read operations, there's a potential issue when the data field >> of the ioreq struct is partially updated in the response. To address >> this, zero data field during read operations. This m

Re: [PATCH v2 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

2023-10-04 Thread Phillip Potter
> From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel and run time > memory bloat by ~64 bytes per sentinel (further information Lin

[PATCH] arm/ioreq: clean data field in ioreq struct on read operations

2023-10-04 Thread Andrii Chepurnyi
For read operations, there's a potential issue when the data field of the ioreq struct is partially updated in the response. To address this, zero data field during read operations. This modification serves as a safeguard against implementations that may inadvertently partially update the data fiel

Re: [PATCH v2 10/15] vrf: Remove the now superfluous sentinel element from ctl_table array

2023-10-04 Thread David Ahern
On 10/2/23 2:55 AM, Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel and run time > memory b

[PATCH v6 06/10] x86/mem-sharing: copy GADDR based shared guest areas

2023-10-04 Thread Roger Pau Monne
From: Jan Beulich In preparation of the introduction of new vCPU operations allowing to register the respective areas (one of the two is x86-specific) by guest-physical address, add the necessary fork handling (with the backing function yet to be filled in). Signed-off-by: Jan Beulich Signed-of

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Roger Pau Monné
On Wed, Oct 04, 2023 at 02:03:43PM +0100, Julien Grall wrote: > Hi Roger, > > On 04/10/2023 13:53, Roger Pau Monné wrote: > > On Wed, Oct 04, 2023 at 11:55:05AM +0100, Julien Grall wrote: > > > Hi Roger, > > > > > > On 04/10/2023 09:13, Roger Pau Monné wrote: > > > > On Tue, Oct 03, 2023 at 12:18

[xtf test] 183261: all pass - PUSHED

2023-10-04 Thread osstest service owner
flight 183261 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183261/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf 8ab636aee07918402d80da2ea605ce449b0fd657 baseline version: xtf f91cd602586c28f76b04f2

Re: [XEN PATCH] xen/types: address Rule 10.1 for macro BITS_TO_LONGS

2023-10-04 Thread Nicola Vetrini
On 05/09/2023 09:31, Nicola Vetrini wrote: Given its use in the declaration 'DECLARE_BITMAP(features, IOMMU_FEAT_count)' the argument 'bits' has essential type 'enum iommu_feature', which is not allowed by the Rule as an operand to the addition operator. Given that its value can be represented by

Re: [PATCH v5 06/10] x86/mem-sharing: copy GADDR based shared guest areas

2023-10-04 Thread Julien Grall
On 04/10/2023 14:00, Roger Pau Monné wrote: On Wed, Oct 04, 2023 at 12:01:21PM +0100, Julien Grall wrote: Hi Roger, On 04/10/2023 09:20, Roger Pau Monné wrote: On Tue, Oct 03, 2023 at 04:25:58PM -0400, Tamas K Lengyel wrote: On Tue, Oct 3, 2023 at 11:07 AM Julien Grall wrote: Hi Roger,

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Julien Grall
Hi Roger, On 04/10/2023 13:53, Roger Pau Monné wrote: On Wed, Oct 04, 2023 at 11:55:05AM +0100, Julien Grall wrote: Hi Roger, On 04/10/2023 09:13, Roger Pau Monné wrote: On Tue, Oct 03, 2023 at 12:18:35PM -0700, Elliott Mitchell wrote: On Tue, Oct 03, 2023 at 10:26:28AM +0200, Roger Pau Monn

Re: [PATCH v5 06/10] x86/mem-sharing: copy GADDR based shared guest areas

2023-10-04 Thread Roger Pau Monné
On Wed, Oct 04, 2023 at 12:01:21PM +0100, Julien Grall wrote: > Hi Roger, > > On 04/10/2023 09:20, Roger Pau Monné wrote: > > On Tue, Oct 03, 2023 at 04:25:58PM -0400, Tamas K Lengyel wrote: > > > On Tue, Oct 3, 2023 at 11:07 AM Julien Grall wrote: > > > > > > > > Hi Roger, > > > > > > > > On 0

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Roger Pau Monné
On Wed, Oct 04, 2023 at 11:42:32AM +, Oleksandr Tyshchenko wrote: > > > On 04.10.23 13:55, Julien Grall wrote: > > Hello all. > > > Hi Roger, > > > > On 04/10/2023 09:13, Roger Pau Monné wrote: > >> On Tue, Oct 03, 2023 at 12:18:35PM -0700, Elliott Mitchell wrote: > >>> On Tue, Oct 03, 202

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Roger Pau Monné
On Wed, Oct 04, 2023 at 11:55:05AM +0100, Julien Grall wrote: > Hi Roger, > > On 04/10/2023 09:13, Roger Pau Monné wrote: > > On Tue, Oct 03, 2023 at 12:18:35PM -0700, Elliott Mitchell wrote: > > > On Tue, Oct 03, 2023 at 10:26:28AM +0200, Roger Pau Monné wrote: > > > > On Thu, Sep 28, 2023 at 07:

Re: [XEN PATCH] xen: Add SAF deviations for MISRA C:2012 Rule 7.1

2023-10-04 Thread Nicola Vetrini
On 04/10/2023 12:52, Luca Fancellu wrote: On 4 Oct 2023, at 11:29, Nicola Vetrini wrote: On 04/10/2023 12:06, Luca Fancellu wrote: Hi Nicola, On 4 Oct 2023, at 10:56, andrew.coop...@citrix.com wrote: On 03/10/2023 9:46 pm, Stefano Stabellini wrote: On Tue, 3 Oct 2023, Nicola Vetrini wrote:

Re: [PATCH 2/3] sysemu/xen: Remove unreachable xen_ram_alloc() code

2023-10-04 Thread Michael Tokarev
05.09.2023 15:21, Philippe Mathieu-Daudé wrote: The xen_ram_alloc() call in softmmu/physmem.c is guarded by checking for xen_enabled(), which evaluate to 'false' when XEN is not built in. The compiler elide the function call, and thus the inlined function is not used. Remove it. I still don't t

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Oleksandr Tyshchenko
On 04.10.23 13:55, Julien Grall wrote: Hello all. > Hi Roger, > > On 04/10/2023 09:13, Roger Pau Monné wrote: >> On Tue, Oct 03, 2023 at 12:18:35PM -0700, Elliott Mitchell wrote: >>> On Tue, Oct 03, 2023 at 10:26:28AM +0200, Roger Pau Monné wrote: On Thu, Sep 28, 2023 at 07:49:18PM -0700,

Re: [XEN PATCH] xen: Add SAF deviations for MISRA C:2012 Rule 7.1

2023-10-04 Thread Luca Fancellu
> On 4 Oct 2023, at 12:17, Andrew Cooper wrote: > > On 04/10/2023 11:52 am, Luca Fancellu wrote: >> >> From the documentation: >> >> In the Xen codebase, these tags will be used to document and suppress >> findings: >> >> - SAF-X-safe: This tag means that the next line of code contains a fi

Re: [XEN PATCH] xen: Add SAF deviations for MISRA C:2012 Rule 7.1

2023-10-04 Thread Andrew Cooper
On 04/10/2023 11:52 am, Luca Fancellu wrote: > From the documentation: > > In the Xen codebase, these tags will be used to document and suppress > findings: > > - SAF-X-safe: This tag means that the next line of code contains a > finding, but > the non compliance to the checker is a

Re: [PATCH v5 06/10] x86/mem-sharing: copy GADDR based shared guest areas

2023-10-04 Thread Julien Grall
Hi Roger, On 04/10/2023 09:20, Roger Pau Monné wrote: On Tue, Oct 03, 2023 at 04:25:58PM -0400, Tamas K Lengyel wrote: On Tue, Oct 3, 2023 at 11:07 AM Julien Grall wrote: Hi Roger, On 03/10/2023 15:29, Roger Pau Monné wrote: On Tue, Oct 03, 2023 at 09:53:11AM -0400, Tamas K Lengyel wrote:

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Julien Grall
Hi Roger, On 04/10/2023 09:13, Roger Pau Monné wrote: On Tue, Oct 03, 2023 at 12:18:35PM -0700, Elliott Mitchell wrote: On Tue, Oct 03, 2023 at 10:26:28AM +0200, Roger Pau Monné wrote: On Thu, Sep 28, 2023 at 07:49:18PM -0700, Elliott Mitchell wrote: I'm trying to get FreeBSD/ARM operational

Re: [XEN PATCH] xen: Add SAF deviations for MISRA C:2012 Rule 7.1

2023-10-04 Thread Luca Fancellu
> On 4 Oct 2023, at 11:29, Nicola Vetrini wrote: > > On 04/10/2023 12:06, Luca Fancellu wrote: >> Hi Nicola, >>> On 4 Oct 2023, at 10:56, andrew.coop...@citrix.com wrote: >>> On 03/10/2023 9:46 pm, Stefano Stabellini wrote: On Tue, 3 Oct 2023, Nicola Vetrini wrote: > As specified in ru

Re: [XEN PATCH] xen: Add SAF deviations for MISRA C:2012 Rule 7.1

2023-10-04 Thread Nicola Vetrini
On 04/10/2023 12:06, Luca Fancellu wrote: Hi Nicola, On 4 Oct 2023, at 10:56, andrew.coop...@citrix.com wrote: On 03/10/2023 9:46 pm, Stefano Stabellini wrote: On Tue, 3 Oct 2023, Nicola Vetrini wrote: As specified in rules.rst, these constants can be used in the code. Their deviation is no

Re: [XEN PATCH] xen: Add SAF deviations for MISRA C:2012 Rule 7.1

2023-10-04 Thread Luca Fancellu
Hi Nicola, > On 4 Oct 2023, at 10:56, andrew.coop...@citrix.com wrote: > > On 03/10/2023 9:46 pm, Stefano Stabellini wrote: >> On Tue, 3 Oct 2023, Nicola Vetrini wrote: >> >>> As specified in rules.rst, these constants can be used >>> in the code. >>> Their deviation is now accomplished by using

Re: [XEN PATCH] xen: Add SAF deviations for MISRA C:2012 Rule 7.1

2023-10-04 Thread andrew . cooper3
On 03/10/2023 9:46 pm, Stefano Stabellini wrote: > On Tue, 3 Oct 2023, Nicola Vetrini wrote: >> As specified in rules.rst, these constants can be used >> in the code. >> Their deviation is now accomplished by using a SAF comment, >> rather than an ECLAIR configuration. >> >> Signed-off-by: Nicola V

[xen-unstable test] 183258: tolerable FAIL

2023-10-04 Thread osstest service owner
flight 183258 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183258/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 183249 test-amd64-amd64-xl-qemut-debian

Re: [PATCH 0/3] sysemu/accel: Simplify sysemu/xen.h

2023-10-04 Thread Philippe Mathieu-Daudé
On 5/9/23 14:21, Philippe Mathieu-Daudé wrote: Trivial cleanups which simplify "sysemu/xen.h". Philippe Mathieu-Daudé (3): sysemu/xen: Remove unuseful CONFIG_USER_ONLY header guard sysemu/xen: Remove unreachable xen_ram_alloc() code sysemu/xen: Allow elision of xen_hvm_modified_memory()

Re: [PATCH v5 06/10] x86/mem-sharing: copy GADDR based shared guest areas

2023-10-04 Thread Roger Pau Monné
On Tue, Oct 03, 2023 at 04:25:58PM -0400, Tamas K Lengyel wrote: > On Tue, Oct 3, 2023 at 11:07 AM Julien Grall wrote: > > > > Hi Roger, > > > > On 03/10/2023 15:29, Roger Pau Monné wrote: > > > On Tue, Oct 03, 2023 at 09:53:11AM -0400, Tamas K Lengyel wrote: > > > > Tamas, somehow your e-mails do

Re: Issue with shared information page on Xen/ARM 4.17

2023-10-04 Thread Roger Pau Monné
On Tue, Oct 03, 2023 at 12:18:35PM -0700, Elliott Mitchell wrote: > On Tue, Oct 03, 2023 at 10:26:28AM +0200, Roger Pau Monné wrote: > > On Thu, Sep 28, 2023 at 07:49:18PM -0700, Elliott Mitchell wrote: > > > I'm trying to get FreeBSD/ARM operational on Xen/ARM. Current issue is > > > the changes