flight 183304 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/183304/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 183284
test-amd64-amd64-xl-qemuu-win7-amd64
flight 183307 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/183307/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
ovmf 82191f8a0e57f674657c7461189e194b6f863e26
baseline version:
ovmf d073a545119140070c83e
On Fri, 6 Oct 2023, Julien Grall wrote:
> Hi Nicola,
>
> On 06/10/2023 11:10, Nicola Vetrini wrote:
> > On 06/10/2023 11:34, Julien Grall wrote:
> > > Hi Nicola,
> > >
> > > On 06/10/2023 09:26, Nicola Vetrini wrote:
> > > > Given its use in the declaration
> > > > 'DECLARE_BITMAP(features, IOMMU
On Fri, 6 Oct 2023, Luca Fancellu wrote:
> > On 6 Oct 2023, at 02:02, Stefano Stabellini wrote:
> >
> > On Thu, 5 Oct 2023, Luca Fancellu wrote:
> >>> On 5 Oct 2023, at 00:32, Stefano Stabellini
> >>> wrote:
> >>>
> >>> On Wed, 4 Oct 2023, Luca Fancellu wrote:
> > On 4 Oct 2023, at 11:29,
On Fri, 6 Oct 2023, Simone Ballarin wrote:
> Remove deviations for ERROR_EXIT, ERROR_EXIT_DOM and PIN_FAIL:
> the aforementioned macros have been removed.
> Add deviation for Rule 2.1 for pure declarations.
> Remove legacy text-based deviations: these are now implemented
> with SAF comments.
> Add
On Fri, 6 Oct 2023, Julien Grall wrote:
> On 06/10/2023 10:58, Nicola Vetrini wrote:
> > On 06/10/2023 11:27, Julien Grall wrote:
> > > Hi,
> > >
> > > On 05/10/2023 09:45, Nicola Vetrini wrote:
> > > > The constant 0 is used instead of NULL in '__ACCESS_ONCE' as a
> > > > compile-time check to de
On Fri, 6 Oct 2023, Stefano Stabellini wrote:
> On Fri, 6 Oct 2023, Julien Grall wrote:
> > Hi Nicola,
> >
> > On 06/10/2023 11:34, Nicola Vetrini wrote:
> > > On 06/10/2023 12:22, Julien Grall wrote:
> > > > On 06/10/2023 11:02, Nicola Vetrini wrote:
> > > > > On 06/10/2023 11:29, Julien Grall wr
On Fri, 6 Oct 2023, Julien Grall wrote:
> Hi Nicola,
>
> On 06/10/2023 11:34, Nicola Vetrini wrote:
> > On 06/10/2023 12:22, Julien Grall wrote:
> > > On 06/10/2023 11:02, Nicola Vetrini wrote:
> > > > On 06/10/2023 11:29, Julien Grall wrote:
> > > > > Hi,
> > > > >
> > > > > On 06/10/2023 09:26,
Hi,
> On Oct 7, 2023, at 02:54, Andrew Cooper wrote:
>
> From: Michal Orzel
>
> The x86 hypercall ABI really used to have 6-argument hypercalls. V4V, the
> downstream predecessor to Argo did take 6th args.
>
> However, the 6th arg being %ebp in the 32bit ABI makes it unusable in
> practice,
Hi Andrew,
Title typo: s/spnix/sphinx/. Can be fixed on commit.
> On Oct 7, 2023, at 02:54, Andrew Cooper wrote:
>
> This will simplify inserting a new one in the middle.
>
> Signed-off-by: Andrew Cooper
Release-acked-by: Henry Wang
Kind regards,
Henry
> ---
> CC: George Dunlap
> CC: Jan
flight 183301 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/183301/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
On Thu, Oct 05, 2023 at 04:08:31PM +0200, Roger Pau Monne wrote:
> Do not set netback interfaces (vifs) default TX queue size to the ring size.
> The TX queue size is not related to the ring size, and using the ring size
> (32)
> as the queue size can lead to packet drops. Note the TX side of the
flight 183284 linux-linus real [real]
flight 183302 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/183284/
http://logs.test-lab.xenproject.org/osstest/logs/183302/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-amd64-
flight 183298 xen-unstable-smoke real [real]
flight 183300 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/183298/
http://logs.test-lab.xenproject.org/osstest/logs/183300/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which co
On 06/10/2023 2:07 am, Stefano Stabellini wrote:
> On Thu, 5 Oct 2023, Nicola Vetrini wrote:
>> The constant 0 is used as a null pointer constant, in
>> violation of MISRA C:2012 Rule 11.9, in builds with
>> CONFIG_DEBUG_LOCK_PROFILE defined.
>>
>> Signed-off-by: Nicola Vetrini
> Reviewed-by: Stef
On 06/10/2023 9:26 am, Nicola Vetrini wrote:
> The definition of MC_NCLASSES contained a violation of MISRA C:2012
> Rule 10.1, therefore by moving it as an enumeration constant resolves the
> violation and makes it more resilient to possible additions to that enum.
>
> Signed-off-by: Nicola Vetrin
An extention to the original patch Michal did, providing the historical
context.
Arguably for backport to 4.17.
Andrew Cooper (1):
docs/spnix: Switch hypercall-abi.rst to named footnotes
Michal Orzel (1):
x86: Clarify that only 5 hypercall parameters are supported
docs/guest-guide/x86/hype
From: Michal Orzel
The x86 hypercall ABI really used to have 6-argument hypercalls. V4V, the
downstream predecessor to Argo did take 6th args.
However, the 6th arg being %ebp in the 32bit ABI makes it unusable in
practice, because that's the frame pointer in builds with frame pointers
enabled.
This will simplify inserting a new one in the middle.
Signed-off-by: Andrew Cooper
---
CC: George Dunlap
CC: Jan Beulich
CC: Stefano Stabellini
CC: Wei Liu
CC: Julien Grall
CC: Michal Orzel
CC: Henry Wang
---
docs/guest-guide/x86/hypercall-abi.rst | 24
1 file cha
On 06/10/2023 9:26 am, Nicola Vetrini wrote:
> The COUNT_LEAVES macro is introduced to avoid using an essentially
> boolean value in a subtraction.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini
> ---
> xen/include/xen/lib/x86/cpu-policy.h | 13 +++--
> 1 file changed, 7 inse
On 06/10/2023 3:50 pm, Roger Pau Monne wrote:
> diff --git a/tools/misc/Makefile b/tools/misc/Makefile
> index 233a7948c050..9938bc235968 100644
> --- a/tools/misc/Makefile
> +++ b/tools/misc/Makefile
> @@ -36,11 +36,8 @@ INSTALL_SBIN += xen-livepatch
> INSTALL_SBIN
On 06/10/2023 9:26 am, Nicola Vetrini wrote:
> diff --git a/xen/include/xen/macros.h b/xen/include/xen/macros.h
> index d0caae7db298..bb9a1c9a53d0 100644
> --- a/xen/include/xen/macros.h
> +++ b/xen/include/xen/macros.h
> @@ -8,8 +8,10 @@
> #define DIV_ROUND(n, d) (((n) + (d) / 2) / (d))
> #defin
flight 183291 xen-unstable-smoke real [real]
flight 183295 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/183291/
http://logs.test-lab.xenproject.org/osstest/logs/183295/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which co
On 06/10/2023 4:09 pm, Julien Grall wrote:
>
>
> On 06/10/2023 15:44, Andrew Cooper wrote:
>> From: Alejandro Vallejo
>>
>> Adds a new compile-time flag to allow disabling PDX compression and
>> compiles out compression-related code/data. It also shorts the pdx<->pfn
>> conversion macros and cre
On 06/10/2023 16:35, Julien Grall wrote:
Hi Nicola,
On 06/10/2023 11:34, Nicola Vetrini wrote:
On 06/10/2023 12:22, Julien Grall wrote:
On 06/10/2023 11:02, Nicola Vetrini wrote:
On 06/10/2023 11:29, Julien Grall wrote:
Hi,
On 06/10/2023 09:26, Nicola Vetrini wrote:
The purpose of this macr
On Fri, Oct 06, 2023 at 04:09:19PM +0100, Julien Grall wrote:
>
>
> On 06/10/2023 15:44, Andrew Cooper wrote:
> > From: Alejandro Vallejo
> >
> > Adds a new compile-time flag to allow disabling PDX compression and
> > compiles out compression-related code/data. It also shorts the pdx<->pfn
> >
On Fri, Oct 06, 2023 at 03:44:05PM +0100, Andrew Cooper wrote:
> From: Alejandro Vallejo
>
> Adds a new compile-time flag to allow disabling PDX compression and
> compiles out compression-related code/data. It also shorts the pdx<->pfn
> conversion macros and creates stubs for masking functions.
On 06/10/2023 15:44, Andrew Cooper wrote:
From: Alejandro Vallejo
Adds a new compile-time flag to allow disabling PDX compression and
compiles out compression-related code/data. It also shorts the pdx<->pfn
conversion macros and creates stubs for masking functions.
While at it, removes the
Hi,
> On Oct 6, 2023, at 22:55, Andrew Cooper wrote:
>
> On 06/10/2023 3:50 pm, Roger Pau Monne wrote:
>> The script heavily relies on the urlgrabber python module, which doesn't seem
>> to be packaged by all distros, it's missing from newer Debian versions at
>> least.
>>
>> Also the usage of
On 06/10/2023 3:50 pm, Roger Pau Monne wrote:
> The script heavily relies on the urlgrabber python module, which doesn't seem
> to be packaged by all distros, it's missing from newer Debian versions at
> least.
>
> Also the usage of the commands module has been deprecated since Python 2.6,
> and
>
The script heavily relies on the urlgrabber python module, which doesn't seem
to be packaged by all distros, it's missing from newer Debian versions at
least.
Also the usage of the commands module has been deprecated since Python 2.6, and
removed in Python 3, so the code would need to be re-writte
On 06/10/2023 2:19 pm, Roger Pau Monné wrote:
> On Fri, Oct 06, 2023 at 02:05:18PM +0100, Andrew Cooper wrote:
>> On 06/10/2023 2:00 pm, Roger Pau Monne wrote:
>>> diff --git a/xen/include/public/features.h b/xen/include/public/features.h
>>> index d2a9175aae67..22713a51b520 100644
>>> --- a/xen/in
Hi Nicola,
On 06/10/2023 11:10, Nicola Vetrini wrote:
On 06/10/2023 11:34, Julien Grall wrote:
Hi Nicola,
On 06/10/2023 09:26, Nicola Vetrini wrote:
Given its use in the declaration
'DECLARE_BITMAP(features, IOMMU_FEAT_count)' the argument
'bits' has essential type 'enum iommu_feature', which
From: Alejandro Vallejo
Adds a new compile-time flag to allow disabling PDX compression and
compiles out compression-related code/data. It also shorts the pdx<->pfn
conversion macros and creates stubs for masking functions.
While at it, removes the old arch-defined CONFIG_HAS_PDX flag. Despite
Hi Nicola,
On 06/10/2023 11:34, Nicola Vetrini wrote:
On 06/10/2023 12:22, Julien Grall wrote:
On 06/10/2023 11:02, Nicola Vetrini wrote:
On 06/10/2023 11:29, Julien Grall wrote:
Hi,
On 06/10/2023 09:26, Nicola Vetrini wrote:
The purpose of this macro is to encapsulate the well-known expres
On Fri, Oct 06, 2023 at 02:57:45PM +0100, Andrew Cooper wrote:
> The last user of this variable was dropped.
>
> Fixes: 295514ff7550 ("common: convert vCPU info area registration")
> Signed-off-by: Andrew Cooper
Reviewed-by: Roger Pau Monné
Thanks for noticing this.
Hi Roger,
On 06/10/2023 14:00, Roger Pau Monne wrote:
unmap_domain_page_global() expects the provided address to be page aligned, or
else some of the called functions will trigger assertions, like
modify_xen_mappings() on x86 or destroy_xen_mappings() on Arm.
The following assert has been repor
Hi,
> On Oct 6, 2023, at 21:05, Andrew Cooper wrote:
>
> On 06/10/2023 2:00 pm, Roger Pau Monne wrote:
>> diff --git a/xen/include/public/features.h b/xen/include/public/features.h
>> index d2a9175aae67..22713a51b520 100644
>> --- a/xen/include/public/features.h
>> +++ b/xen/include/public/featu
Hi Roger,
> On Oct 6, 2023, at 21:00, Roger Pau Monne wrote:
>
> unmap_domain_page_global() expects the provided address to be page aligned, or
> else some of the called functions will trigger assertions, like
> modify_xen_mappings() on x86 or destroy_xen_mappings() on Arm.
>
> The following as
Hi Anthony,
> On Oct 6, 2023, at 21:54, Anthony PERARD wrote:
>
> Sometime, a contributer would like to be CCed on part of the changes,
> and it could happen that we end-up with a section that doesn't have
> any maintainer, but a Ack from a maintainer would still be needed.
>
> Rework get_maint
Hi Andrew,
> On Oct 6, 2023, at 21:57, Andrew Cooper wrote:
>
> The last user of this variable was dropped.
>
> Fixes: 295514ff7550 ("common: convert vCPU info area registration")
> Signed-off-by: Andrew Cooper
Release-acked-by: Henry Wang
Kind regards,
Henry
> ---
> CC: Jan Beulich
> CC:
The last user of this variable was dropped.
Fixes: 295514ff7550 ("common: convert vCPU info area registration")
Signed-off-by: Andrew Cooper
---
CC: Jan Beulich
CC: Roger Pau Monné
CC: Wei Liu
CC: Tamas K Lengyel
CC: Henry Wang
I expect Gitlab randconfig to find this eventually, but it does
flight 183283 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/183283/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183269
test-armhf-armhf-libvirt-qcow2 15 saveres
Sometime, a contributer would like to be CCed on part of the changes,
and it could happen that we end-up with a section that doesn't have
any maintainer, but a Ack from a maintainer would still be needed.
Rework get_maintainer so if there's no maintainers beside THE REST, it
doesn't drop THE REST
On 25/09/2023 6:37 pm, Shawn Anastasio wrote:
> On 9/22/23 3:03 PM, Andrew Cooper wrote:
>> Several things.
>>
>> First, Shawn: PPC has gained a HAS_PDX, the deletion of which needs
>> merging into this patch.
>>
>> It was added as part of 4a2f68f909304 which was "minimal to build".
>> This series
On Fri, Oct 06, 2023 at 02:05:18PM +0100, Andrew Cooper wrote:
> On 06/10/2023 2:00 pm, Roger Pau Monne wrote:
> > diff --git a/xen/include/public/features.h b/xen/include/public/features.h
> > index d2a9175aae67..22713a51b520 100644
> > --- a/xen/include/public/features.h
> > +++ b/xen/include/pub
On Thu, Oct 5, 2023 at 3:08 PM Roger Pau Monne wrote:
>
> Do not set netback interfaces (vifs) default TX queue size to the ring size.
> The TX queue size is not related to the ring size, and using the ring size
> (32)
> as the queue size can lead to packet drops. Note the TX side of the vif
> i
On 06/10/2023 2:00 pm, Roger Pau Monne wrote:
> diff --git a/xen/include/public/features.h b/xen/include/public/features.h
> index d2a9175aae67..22713a51b520 100644
> --- a/xen/include/public/features.h
> +++ b/xen/include/public/features.h
> @@ -111,6 +111,15 @@
> #define XENFEAT_not_direct_mappe
unmap_domain_page_global() expects the provided address to be page aligned, or
else some of the called functions will trigger assertions, like
modify_xen_mappings() on x86 or destroy_xen_mappings() on Arm.
The following assert has been reported by osstest arm 32bit tests:
(XEN) Assertion 'IS_ALIG
XENFEAT_runstate_phys_area is exposed to all architectures, while
XENFEAT_vcpu_time_phys_area is currently only implemented for x86, and hence
the feature flag is also only exposed on x86.
Additionally add dummy guards with TODOs in the respective hypercall
implementations, to signal the intention
Hello,
First patch fixes a bug reported by osstest, second patch is an addition
requested by Andrew, I think this should remove the blocker raised
against the series.
Roger Pau Monne (2):
domain: fix misaligned unmap address in {,un}map_guest_area()
domain: expose newly introduced hypercalls
The list is out of date and does not specify all the hypercalls/sub-ops
we support, so update it.
Signed-off-by: Michal Orzel
Release-acked-by: Henry Wang
Acked-by: Julien Grall
---
Changes in v2:
- explicitly list dm_op sub-ops
- add Julien's Ab, Henry's Rab
---
xen/include/public/arch-arm.
On 06/10/23 12:23, Simone Ballarin wrote:
+-doc_begin="XEN only supports architectures where signed integers are
+representend using two's complement and all the XEN developers are aware of
+this."
+-config=MC3R1.R10.1,etypes+={safe,
+ "stmt(operator(and||or||xor||not||and_assign||or_assign||xor
On 06/10/2023 13:38, Michal Orzel wrote:
Hello,
On 06/10/2023 14:31, Julien Grall wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
On 06/10/2023 11:20, Michal Orzel wrote:
On 06/10/2023 12:11, Jul
On 05/10/2023 16:17, Julien Grall wrote:
Hi Andrii,
Hi,
On 05/10/2023 14:30, Andrii Chepurnyi wrote:
For read operations, there's a potential issue when the data field
of the ioreq struct is partially updated in the response. To address
this, zero data field during read operations. This m
Hello,
On 06/10/2023 14:31, Julien Grall wrote:
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On 06/10/2023 11:20, Michal Orzel wrote:
>> On 06/10/2023 12:11, Julien Grall wrote:
>>>
>>>
>>> Hi Mic
On 06/10/2023 10:58, Nicola Vetrini wrote:
On 06/10/2023 11:27, Julien Grall wrote:
Hi,
On 05/10/2023 09:45, Nicola Vetrini wrote:
The constant 0 is used instead of NULL in '__ACCESS_ONCE' as a
compile-time check to detect non-scalar types; its usage for this
purpose is documented in rules.
On 06/10/2023 11:20, Michal Orzel wrote:
On 06/10/2023 12:11, Julien Grall wrote:
Hi Michal,
On 06/10/2023 08:51, Michal Orzel wrote:
The list is out of date and does not specify all the hypercalls/sub-ops
we support, so update it.
Signed-off-by: Michal Orzel
---
xen/include/public/a
On Fri, Oct 06, 2023 at 12:19:29PM +0100, Andrew Cooper wrote:
> On 06/10/2023 12:02 pm, Roger Pau Monné wrote:
> > On Fri, Oct 06, 2023 at 11:47:48AM +0100, Andrew Cooper wrote:
> >> diff --git a/xen/common/domain.c b/xen/common/domain.c
> >> index b8281d7cff9d..df994bd30fd2 100644
> >> --- a/xen/
flight 183281 xen-unstable-smoke real [real]
flight 183286 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/183281/
http://logs.test-lab.xenproject.org/osstest/logs/183286/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which co
On 06/10/2023 12:02 pm, Roger Pau Monné wrote:
> On Fri, Oct 06, 2023 at 11:47:48AM +0100, Andrew Cooper wrote:
>> diff --git a/xen/common/domain.c b/xen/common/domain.c
>> index b8281d7cff9d..df994bd30fd2 100644
>> --- a/xen/common/domain.c
>> +++ b/xen/common/domain.c
>> @@ -1998,6 +1998,10 @@ lo
On Fri, Oct 06, 2023 at 11:47:48AM +0100, Andrew Cooper wrote:
> On 06/10/2023 10:13 am, Roger Pau Monne wrote:
> > XENFEAT_runstate_phys_area is exposed to all architectures, while
> > XENFEAT_vcpu_time_phys_area is currnelty only implemented for x86, and hence
> > the feature flag is also only ex
On 06/10/2023 10:13 am, Roger Pau Monne wrote:
> XENFEAT_runstate_phys_area is exposed to all architectures, while
> XENFEAT_vcpu_time_phys_area is currnelty only implemented for x86, and hence
> the feature flag is also only exposed on x86.
>
> Signed-off-by: Roger Pau Monné
Thanks for doing thi
On Fri, Oct 06, 2023 at 11:08:09AM +0100, Julien Grall wrote:
> Hi Roger,
>
> On 06/10/2023 10:13, Roger Pau Monne wrote:
> > unmap_domain_page_global() expects the provided address to be page aligned,
> > or
> > else some of the called functions will trigger assertions, like
> > modify_xen_mappi
flight 183278 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/183278/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-amd64-i386-livepatch 7 xen-installfail pass in 183271
test-amd64-i386-xl-xsm7
On 06/10/2023 12:22, Julien Grall wrote:
On 06/10/2023 11:02, Nicola Vetrini wrote:
On 06/10/2023 11:29, Julien Grall wrote:
Hi,
On 06/10/2023 09:26, Nicola Vetrini wrote:
The purpose of this macro is to encapsulate the well-known
expression
'x & -x', that in 2's complement architectures on u
Remove deviations for ERROR_EXIT, ERROR_EXIT_DOM and PIN_FAIL:
the aforementioned macros have been removed.
Add deviation for Rule 2.1 for pure declarations.
Remove legacy text-based deviations: these are now implemented
with SAF comments.
Add deviations for Dir 4.3 and Rules 8.4, 10.1, 13.5, 14.2,
On 06/10/2023 11:02, Nicola Vetrini wrote:
On 06/10/2023 11:29, Julien Grall wrote:
Hi,
On 06/10/2023 09:26, Nicola Vetrini wrote:
The purpose of this macro is to encapsulate the well-known expression
'x & -x', that in 2's complement architectures on unsigned integers will
give 2^ffs(x), wh
On 06/10/2023 9:00 am, Roger Pau Monné wrote:
> On Thu, Oct 05, 2023 at 07:58:50PM +0100, Andrew Cooper wrote:
>> Henry: Blocker for 4.18. The absolutely bare minimum necessary to
>> avoid reversion is some kind of positive enumeration that the two new
>> hypercalls are available.
>>
>> Otherwise
Hi Julien,
On 06/10/2023 12:11, Julien Grall wrote:
>
>
> Hi Michal,
>
> On 06/10/2023 08:51, Michal Orzel wrote:
>> The list is out of date and does not specify all the hypercalls/sub-ops
>> we support, so update it.
>>
>> Signed-off-by: Michal Orzel
>> ---
>> xen/include/public/arch-arm.h
Hi Michal,
On 06/10/2023 08:51, Michal Orzel wrote:
The list is out of date and does not specify all the hypercalls/sub-ops
we support, so update it.
Signed-off-by: Michal Orzel
---
xen/include/public/arch-arm.h | 21 +
1 file changed, 21 insertions(+)
diff --git a/xen/
On 06/10/2023 11:34, Julien Grall wrote:
Hi Nicola,
On 06/10/2023 09:26, Nicola Vetrini wrote:
Given its use in the declaration
'DECLARE_BITMAP(features, IOMMU_FEAT_count)' the argument
'bits' has essential type 'enum iommu_feature', which is not
allowed by the Rule as an operand to the additio
Hi Roger,
On 06/10/2023 10:13, Roger Pau Monne wrote:
unmap_domain_page_global() expects the provided address to be page aligned, or
else some of the called functions will trigger assertions, like
modify_xen_mappings() on x86 or destroy_xen_mappings() on Arm.
The following assert has been repor
On 06/10/2023 11:29, Julien Grall wrote:
Hi,
On 06/10/2023 09:26, Nicola Vetrini wrote:
The purpose of this macro is to encapsulate the well-known expression
'x & -x', that in 2's complement architectures on unsigned integers
will
give 2^ffs(x), where ffs(x) is the position of the lowest set b
Hi Julien,
On 06/10/2023 11:43, Julien Grall wrote:
>
>
> On 05/10/2023 21:15, Michal Orzel wrote:
>> Hi Julien,
>
> Hi Michal,
>
>> On 05/10/2023 18:54, Julien Grall wrote:
>>>
>>>
>>> From: Julien Grall
>>>
>>> Per ACPI 6.5 section 5.2.25 ("Generic Timer Description Table (GTDT)"),
>>> the
On 06/10/2023 11:27, Julien Grall wrote:
Hi,
On 05/10/2023 09:45, Nicola Vetrini wrote:
The constant 0 is used instead of NULL in '__ACCESS_ONCE' as a
compile-time check to detect non-scalar types; its usage for this
purpose is documented in rules.rst as an exception.
Documenting ACCESS_ONCE()
On 05/10/2023 21:15, Michal Orzel wrote:
Hi Julien,
Hi Michal,
On 05/10/2023 18:54, Julien Grall wrote:
From: Julien Grall
Per ACPI 6.5 section 5.2.25 ("Generic Timer Description Table (GTDT)"),
the fields "Secure EL1 Timer GSIV/Flags" are optional and an OS running
in non-secure worl
Hi Nicola,
On 06/10/2023 09:26, Nicola Vetrini wrote:
Given its use in the declaration
'DECLARE_BITMAP(features, IOMMU_FEAT_count)' the argument
'bits' has essential type 'enum iommu_feature', which is not
allowed by the Rule as an operand to the addition operator
in macro 'BITS_TO_LONGS'.
A co
Hi,
On 06/10/2023 09:26, Nicola Vetrini wrote:
The purpose of this macro is to encapsulate the well-known expression
'x & -x', that in 2's complement architectures on unsigned integers will
give 2^ffs(x), where ffs(x) is the position of the lowest set bit in x.
A deviation for ECLAIR is also in
Hi,
On 05/10/2023 09:45, Nicola Vetrini wrote:
The constant 0 is used instead of NULL in '__ACCESS_ONCE' as a
compile-time check to detect non-scalar types; its usage for this
purpose is documented in rules.rst as an exception.
Documenting ACCESS_ONCE() in rules.rst seems a bit odd. I am guessin
Hi Roger,
> On Oct 6, 2023, at 17:13, Roger Pau Monne wrote:
>
> unmap_domain_page_global() expects the provided address to be page aligned, or
> else some of the called functions will trigger assertions, like
> modify_xen_mappings() on x86 or destroy_xen_mappings() on Arm.
>
> The following as
Hi Roger,
> On Oct 6, 2023, at 17:13, Roger Pau Monne wrote:
>
> XENFEAT_runstate_phys_area is exposed to all architectures, while
> XENFEAT_vcpu_time_phys_area is currnelty only implemented for x86, and hence
> the feature flag is also only exposed on x86.
>
> Signed-off-by: Roger Pau Monné
Hello,
First patch fixes a bug reported by osstest, second patch is an addition
requested by Andrew, I think this should remove the blocker raised
against the series.
Roger Pau Monne (2):
domain: fix misaligned unmap address in unmap_guest_area()
domain: expose newly introduced hypercalls as
Given the following macros in and
#define perfc_incra(x,y)
\
( (y) <= PERFC_LAST_ ## x - PERFC_ ## x ?
\
++this_cpu(perfcounters)[PERFC_ ## x + (y)] : 0 )
and the following violation
xen/arch/arm/traps.c:1
XENFEAT_runstate_phys_area is exposed to all architectures, while
XENFEAT_vcpu_time_phys_area is currnelty only implemented for x86, and hence
the feature flag is also only exposed on x86.
Signed-off-by: Roger Pau Monné
---
CHANGELOG.md | 2 ++
xen/common/kernel.c | 6
unmap_domain_page_global() expects the provided address to be page aligned, or
else some of the called functions will trigger assertions, like
modify_xen_mappings() on x86 or destroy_xen_mappings() on Arm.
The following assert has been reported by osstest arm 32bit tests:
(XEN) Assertion 'IS_ALIG
On Fri, Oct 06, 2023 at 03:32:00AM +, osstest service owner wrote:
> flight 183276 xen-unstable-smoke real [real]
> flight 183279 xen-unstable-smoke real-retest [real]
> http://logs.test-lab.xenproject.org/osstest/logs/183276/
> http://logs.test-lab.xenproject.org/osstest/logs/183279/
>
> Regr
The definition of MC_NCLASSES contained a violation of MISRA C:2012
Rule 10.1, therefore by moving it as an enumeration constant resolves the
violation and makes it more resilient to possible additions to that enum.
Signed-off-by: Nicola Vetrini
---
Note that the use of an enum constant as operan
The purpose of this macro is to encapsulate the well-known expression
'x & -x', that in 2's complement architectures on unsigned integers will
give 2^ffs(x), where ffs(x) is the position of the lowest set bit in x.
A deviation for ECLAIR is also introduced.
Signed-off-by: Nicola Vetrini
---
aut
The essential type of the result of an inequality operator is
essentially boolean, therefore it shouldn't be used as an argument of
the multiplication operator, which expects an integer.
Signed-off-by: Nicola Vetrini
---
xen/include/xen/compat.h | 10 ++
1 file changed, 6 insertions(+),
The COUNT_LEAVES macro is introduced to avoid using an essentially
boolean value in a subtraction.
No functional change.
Signed-off-by: Nicola Vetrini
---
xen/include/xen/lib/x86/cpu-policy.h | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/xen/include/xen/lib/x
The various definitions of macro CNT (and the related BUILD_BUG_ON)
can be rewritten using LOWEST_POW2, encapsulating a violation of
MISRA C:2012 Rule 10.1.
Signed-off-by: Nicola Vetrini
---
I do find somewhat odd the multiple identical #define-s and #undef-s of CNT in
this file, as well as the l
Given its use in the declaration
'DECLARE_BITMAP(features, IOMMU_FEAT_count)' the argument
'bits' has essential type 'enum iommu_feature', which is not
allowed by the Rule as an operand to the addition operator
in macro 'BITS_TO_LONGS'.
A comment in BITS_TO_LONGS is added to make it clear that
val
The definition of PDX_GROUP_COUNT causes violations of
MISRA C:2012 Rule 10.1, therefore the problematic part now uses
the LOWEST_POW2 macro, which encapsulates the pattern.
Signed-off-by: Nicola Vetrini
---
xen/include/xen/pdx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The definitions of ffs{l}? violate Rule 10.1, by using the well-known
pattern (x & -x); its usage is wrapped by the LOWEST_POW2 macro.
No functional change.
---
xen/arch/arm/include/asm/bitops.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/include/asm/bit
The definition of IO_APIC_BASE contains a sum of an essentially enum
value (FIX_IO_APIC_BASE_0) that is positive with an index that, in all
instances, is unsigned, therefore the former is cast to unsigned, so that
the operands are of the same essential type.
No functional change.
---
xen/arch/x86
This series aims to resolve or deviate various violations of Rule 10.1
(operands of inappropriate essential type).
To do so, the widely-used construct
(x & -x), where x is an unsigned integer quantity represented in 2's complement,
does yield the expected result. Since all architectures that are t
On Fri, Oct 06, 2023 at 10:00:35AM +0200, Roger Pau Monné wrote:
> On Thu, Oct 05, 2023 at 07:58:50PM +0100, Andrew Cooper wrote:
> > I see this series has been committed. But it's broken in a really
> > fundamental way.
> >
> >
> > This is a new extension with persistent side effects to an exis
On Thu, Oct 05, 2023 at 07:58:50PM +0100, Andrew Cooper wrote:
> I see this series has been committed. But it's broken in a really
> fundamental way.
>
>
> This is a new extension with persistent side effects to an existing part
> of the guest ABI.
The only change in the ABI is the different re
> On 6 Oct 2023, at 02:02, Stefano Stabellini wrote:
>
> On Thu, 5 Oct 2023, Luca Fancellu wrote:
>>> On 5 Oct 2023, at 00:32, Stefano Stabellini wrote:
>>>
>>> On Wed, 4 Oct 2023, Luca Fancellu wrote:
> On 4 Oct 2023, at 11:29, Nicola Vetrini
> wrote:
> On 04/10/2023 12:06, Luc
1 - 100 of 104 matches
Mail list logo
