Re: [Stratos-dev] [PATCH V3 2/2] xen: privcmd: Add support for ioeventfd

2023-10-10 Thread Bill Mills
Hi Viresh, On 10/9/23 7:29 AM, Viresh Kumar via Stratos-dev wrote: Virtio guests send VIRTIO_MMIO_QUEUE_NOTIFY notification when they need to notify the backend of an update to the status of the virtqueue. The backend or another entity, polls the MMIO address for updates to know when the

[xen-unstable test] 183332: tolerable FAIL - PUSHED

2023-10-10 Thread osstest service owner
flight 183332 xen-unstable real [real] flight 183336 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183332/ http://logs.test-lab.xenproject.org/osstest/logs/183336/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: MISRA C:2012 D4.11 caution on staging

2023-10-10 Thread Andrew Cooper
On 10/10/2023 5:31 pm, Nicola Vetrini wrote: > Hi, > > as you can see from [1], there's a MISRA C guideline, D4.11, that is > supposed to be clean > (i.e., have no reports), but has a caution on an argument to memcpy > (the second argument might be null according to the checker, given a > set of

Re: MISRA C:2012 D4.11 caution on staging

2023-10-10 Thread Stefano Stabellini
Hey Julien, please double-check what I am writing below On Tue, 10 Oct 2023, Nicola Vetrini wrote: > Hi, > > as you can see from [1], there's a MISRA C guideline, D4.11, that is supposed > to be clean > (i.e., have no reports), but has a caution on an argument to memcpy > (the second argument

Re: [XEN PATCH] xen: Add SAF deviations for MISRA C:2012 Rule 7.1

2023-10-10 Thread Stefano Stabellini
On Tue, 10 Oct 2023, Julien Grall wrote: > Hi Stefano, > > On 09/10/2023 23:19, Stefano Stabellini wrote: > > > > > > I am not sure this is better. This is a long line to read. But this is a > > > personal opinion. > > > > > > On the technical side, can we easily teach a tool to format this

Re: [QEMU][PATCH v1 2/7] xen: add pseudo RAM region for grant mappings

2023-10-10 Thread Stefano Stabellini
On Tue, 10 Oct 2023, Vikram Garhwal wrote: > On Mon, Oct 09, 2023 at 05:02:14PM -0700, Stefano Stabellini wrote: > > On Thu, 5 Oct 2023, Vikram Garhwal wrote: > > > From: Juergen Gross > > > > > > Add a memory region which can be used to automatically map granted > > > memory. It is starting at

Re: [XEN PATCH][for-4.19 v2 2/2] docs/misra: add deviations.rst to document additional deviations.

2023-10-10 Thread Stefano Stabellini
On Tue, 10 Oct 2023, Nicola Vetrini wrote: > On 10/10/2023 03:19, Stefano Stabellini wrote: > > +Henry > > > > On Mon, 9 Oct 2023, Nicola Vetrini wrote: > > > This file contains the deviation that are not marked by > > > a deviation comment, as specified in > > >

Re: [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers

2023-10-10 Thread Luis Chamberlain
On Mon, Oct 02, 2023 at 10:55:17AM +0200, Joel Granados via B4 Relay wrote: > Changes in v2: > - Left the dangling comma in the ctl_table arrays. > - Link to v1: > https://lore.kernel.org/r/20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca...@samsung.com Thanks! Pushed onto

Re: Rule 10.1 violations in perfc_incra and PERFCOUNTER_ARRAY

2023-10-10 Thread Stefano Stabellini
On Tue, 10 Oct 2023, Nicola Vetrini wrote: > On 10/10/2023 03:56, Stefano Stabellini wrote: > > On Fri, 6 Oct 2023, Nicola Vetrini wrote: > > > Given the following macros in and > > > > > > #define perfc_incra(x,y)\ > > > ( (y) <= PERFC_LAST_

Re: [QEMU][PATCH v1 2/7] xen: add pseudo RAM region for grant mappings

2023-10-10 Thread Vikram Garhwal
Hi Stefano, On Mon, Oct 09, 2023 at 05:02:14PM -0700, Stefano Stabellini wrote: > On Thu, 5 Oct 2023, Vikram Garhwal wrote: > > From: Juergen Gross > > > > Add a memory region which can be used to automatically map granted > > memory. It is starting at 0x8000ULL in order to be able

Re: [QEMU][PATCH v1 1/7] xen: when unplugging emulated devices skip virtio devices

2023-10-10 Thread Vikram Garhwal
Hi Stefano, On Mon, Oct 09, 2023 at 04:51:53PM -0700, Stefano Stabellini wrote: > On Thu, 5 Oct 2023, Vikram Garhwal wrote: > > From: Juergen Gross > > > > Virtio devices should never be unplugged at boot time, as they are > > similar to pci passthrough devices. > > > > Signed-off-by: Juergen

[xen-unstable-smoke test] 183333: tolerable all pass - PUSHED

2023-10-10 Thread osstest service owner
flight 18 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/18/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[PATCH v3] acpi/processor: sanitize _OSC/_PDC capabilities for Xen dom0

2023-10-10 Thread Jason Andryuk
From: Roger Pau Monne The Processor capability bits notify ACPI of the OS capabilities, and so ACPI can adjust the return of other Processor methods taking the OS capabilities into account. When Linux is running as a Xen dom0, the hypervisor is the entity in charge of processor power

RE: [PATCH] xen/arm: vtimer: Don't read/use the secure physical timer interrupt for ACPI

2023-10-10 Thread Driscoll, Dan
Julien, Verified this patch works on Graviton 2... so looks good from this perspective. Thanks, Dan > -Original Message- > From: Julien Grall > Sent: Thursday, October 5, 2023 11:55 AM > To: xen-devel@lists.xenproject.org > Cc: henry.w...@arm.com; Driscoll, Dan (DI SW CAS ES

Re: [PATCH v2 2/2] credit: Don't steal vcpus which have yielded

2023-10-10 Thread Marcus Granado
On Thu, 21 Sept 2023 at 15:14, George Dunlap wrote: > > On Thu, Sep 21, 2023 at 1:23 PM George Dunlap wrote: > > > > On large systems with many vcpus yielding due to spinlock priority > > inversion, it's not uncommon for a vcpu to yield its timeslice, only > > to be immediately stolen by another

Re: [XEN PATCH v1] tools/python: Add python3 compatibility

2023-10-10 Thread Andrew Cooper
On 10/10/2023 10:18 pm, Javi Merino wrote: > Most of the work for python3 compatibility was done in > 1430c5a8cad4 (tools/python: Python 3 compatibility, 2019-12-18). This > just adds a few builtins needed for python3. > > Resolves: xen-project/xen#156 > > Signed-off-by: Javi Merino > --- > > I

Re: [XEN PATCH 9/9] xen/compat: address Rule 10.1 for macros CHECK_SIZE

2023-10-10 Thread Andrew Cooper
On 11/10/2023 12:06 am, Nicola Vetrini wrote: > On 10/10/2023 18:00, Andrew Cooper wrote: >> On 10/10/2023 9:02 am, Stefano Stabellini wrote: >>> On Fri, 6 Oct 2023, Nicola Vetrini wrote: The essential type of the result of an inequality operator is essentially boolean, therefore it

Re: [XEN PATCH 9/9] xen/compat: address Rule 10.1 for macros CHECK_SIZE

2023-10-10 Thread Nicola Vetrini
On 10/10/2023 18:00, Andrew Cooper wrote: On 10/10/2023 9:02 am, Stefano Stabellini wrote: On Fri, 6 Oct 2023, Nicola Vetrini wrote: The essential type of the result of an inequality operator is essentially boolean, therefore it shouldn't be used as an argument of the multiplication operator,

Re: [XEN PATCH 9/9] xen/compat: address Rule 10.1 for macros CHECK_SIZE

2023-10-10 Thread Andrew Cooper
On 10/10/2023 9:02 am, Stefano Stabellini wrote: > On Fri, 6 Oct 2023, Nicola Vetrini wrote: >> The essential type of the result of an inequality operator is >> essentially boolean, therefore it shouldn't be used as an argument of >> the multiplication operator, which expects an integer. >> >>

Re: [XEN PATCH v1] tools/python: Add python3 compatibility

2023-10-10 Thread Marek Marczykowski-Górecki
On Tue, Oct 10, 2023 at 03:18:45PM +0100, Javi Merino wrote: > Most of the work for python3 compatibility was done in > 1430c5a8cad4 (tools/python: Python 3 compatibility, 2019-12-18). This > just adds a few builtins needed for python3. > > Resolves: xen-project/xen#156 > > Signed-off-by: Javi

Re: [PATCH v7 1/8] xen/arm: Split page table related code to mmu/pt.c

2023-10-10 Thread Julien Grall
Hi Henry, On 09/10/2023 02:03, Henry Wang wrote: The extraction of MMU related code is the basis of MPU support. This commit starts this work by firstly splitting the page table related code to mmu/pt.c, so that we will not end up with again massive mm.c files. Introduce a mmu specific

[XEN PATCH v1] tools/python: Add python3 compatibility

2023-10-10 Thread Javi Merino
Most of the work for python3 compatibility was done in 1430c5a8cad4 (tools/python: Python 3 compatibility, 2019-12-18). This just adds a few builtins needed for python3. Resolves: xen-project/xen#156 Signed-off-by: Javi Merino --- I haven't tested it. README

Re: [PATCH] xen/arm: Validate generic timer frequency

2023-10-10 Thread Julien Grall
(+ Henry) Hi Michal, On 29/09/2023 08:38, Julien Grall wrote: Hi Michal, On 28/09/2023 13:34, Michal Orzel wrote: Generic timer dt node property "clock-frequency" (refer Linux dt binding Documentation/devicetree/bindings/timer/arm,arch_timer.yaml) is used to override the incorrect value set

Re: [for-4.18][PATCH v2] xen/public: arch-arm: Update list of supported hypercalls

2023-10-10 Thread Julien Grall
Hi, On 06/10/2023 13:52, Michal Orzel wrote: The list is out of date and does not specify all the hypercalls/sub-ops we support, so update it. Signed-off-by: Michal Orzel Release-acked-by: Henry Wang Acked-by: Julien Grall It is now committed. Cheers, -- Julien Grall

Re: [XEN PATCH] get_maintainer: Add THE REST for sections with reviewers only

2023-10-10 Thread Julien Grall
Hi Anthony, On 06/10/2023 14:54, Anthony PERARD wrote: Sometime, a contributer would like to be CCed on part of the changes, and it could happen that we end-up with a section that doesn't have any maintainer, but a Ack from a maintainer would still be needed. Rework get_maintainer so if

[PATCH 1/1] xen-netback: add software timestamp capabilities

2023-10-10 Thread Luca Fancellu
Add software timestamp capabilities to the xen-netback driver by advertising it on the struct ethtool_ops and calling skb_tx_timestamp before passing the buffer to the queue. Signed-off-by: Luca Fancellu --- drivers/net/xen-netback/interface.c | 5 - 1 file changed, 4 insertions(+), 1

[PATCH 0/1] Add software timestamp capabilities to xen-netback device

2023-10-10 Thread Luca Fancellu
Hi all, during some experiment using PTP (ptp4l) between a Dom0 domain and a DomU guest, I noticed that the virtual interface brought up by the toolstack was not able to be used as ptp4l interface on the Dom0 side, a brief investigation on the drivers revealed that the backend driver doesn't have

Re: [Stratos-dev] [PATCH V3 2/2] xen: privcmd: Add support for ioeventfd

2023-10-10 Thread Viresh Kumar
Hi Bill, On Tue, 10 Oct 2023 at 18:52, Bill Mills wrote: > On 10/9/23 7:29 AM, Viresh Kumar via Stratos-dev wrote: > > -config XEN_PRIVCMD_IRQFD > > - bool "Xen irqfd support" > > +config XEN_PRIVCMD_EVENTFD > > + bool "Xen Ioeventfd and irqfd support" > > You certainly know about

Re: [XEN PATCH][for-4.19 8/9] xen/types: address Rule 10.1 for DECLARE_BITMAP use

2023-10-10 Thread Nicola Vetrini
On 10/10/2023 12:53, Julien Grall wrote: On 10/10/2023 02:09, Stefano Stabellini wrote: On Mon, 9 Oct 2023, Julien Grall wrote: On 07/10/2023 02:04, Stefano Stabellini wrote: On Fri, 6 Oct 2023, Julien Grall wrote: Hi Nicola, On 06/10/2023 11:10, Nicola Vetrini wrote: On 06/10/2023 11:34,

Re: [XEN PATCH][for-4.19 8/9] xen/types: address Rule 10.1 for DECLARE_BITMAP use

2023-10-10 Thread Nicola Vetrini
On 10/10/2023 14:15, Julien Grall wrote: On 10/10/2023 13:13, Julien Grall wrote: On 10/10/2023 13:07, Nicola Vetrini wrote: I agree on everything Julien's wrote and I was about to suggest to use a SAF comment to suppress the warning because it is clearer than a int cast. But then I

[xen-unstable-smoke test] 183331: tolerable all pass - PUSHED

2023-10-10 Thread osstest service owner
flight 183331 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183331/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Xen Security Advisory 444 v3 (CVE-2023-34327,CVE-2023-34328) - x86/AMD: Debug Mask handling

2023-10-10 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2023-34327,CVE-2023-34328 / XSA-444 version 3 x86/AMD: Debug Mask handling UPDATES IN VERSION 3 Public release. ISSUE DESCRIPTION

Re: [XEN PATCH][for-4.19 8/9] xen/types: address Rule 10.1 for DECLARE_BITMAP use

2023-10-10 Thread Nicola Vetrini
I agree on everything Julien's wrote and I was about to suggest to use a SAF comment to suppress the warning because it is clearer than a int cast. But then I realized that even if BITS_TO_LONGS was fixed, wouldn't still we have a problem because IOMMU_FEAT_count is an enum? Is it the

Re: [QEMU PATCH v5 12/13] virtio-gpu: Initialize Venus

2023-10-10 Thread Dmitry Osipenko
On 9/15/23 14:11, Huang Rui wrote: > + if virgl.version().version_compare('>= 0.9.0') and > virgl.version().version_compare('< 1.0.0') > +message('Enabling virglrenderer unstable APIs') > +virgl = declare_dependency(compile_args: > '-DVIRGL_RENDERER_UNSTABLE_APIS', > +

Re: [XEN PATCH][for-4.19 8/9] xen/types: address Rule 10.1 for DECLARE_BITMAP use

2023-10-10 Thread Julien Grall
On 10/10/2023 13:13, Julien Grall wrote: On 10/10/2023 13:07, Nicola Vetrini wrote: I agree on everything Julien's wrote and I was about to suggest to use a SAF comment to suppress the warning because it is clearer than a int cast. But then I realized that even if BITS_TO_LONGS was

Re: [XEN PATCH][for-4.19 8/9] xen/types: address Rule 10.1 for DECLARE_BITMAP use

2023-10-10 Thread Julien Grall
On 10/10/2023 13:07, Nicola Vetrini wrote: I agree on everything Julien's wrote and I was about to suggest to use a SAF comment to suppress the warning because it is clearer than a int cast. But then I realized that even if BITS_TO_LONGS was fixed, wouldn't still we have a problem

Xen Security Advisory 442 v2 (CVE-2023-34326) - x86/AMD: missing IOMMU TLB flushing

2023-10-10 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2023-34326 / XSA-442 version 2 x86/AMD: missing IOMMU TLB flushing UPDATES IN VERSION 2 Public release. ISSUE DESCRIPTION

Xen Security Advisory 440 v3 (CVE-2023-34323) - xenstored: A transaction conflict can crash C Xenstored

2023-10-10 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2023-34323 / XSA-440 version 3 xenstored: A transaction conflict can crash C Xenstored UPDATES IN VERSION 3 Public release. ISSUE DESCRIPTION

Xen Security Advisory 441 v4 (CVE-2023-34324) - Possible deadlock in Linux kernel event handling

2023-10-10 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2023-34324 / XSA-441 version 4 Possible deadlock in Linux kernel event handling UPDATES IN VERSION 4 Public release. Modified advisory again to

Re: [QEMU PATCH v5 00/13] Support blob memory and venus on qemu

2023-10-10 Thread Dmitry Osipenko
On 9/15/23 14:11, Huang Rui wrote: > Hi all, > > Antonio Caggiano made the venus with QEMU on KVM platform last > September[1]. This series are inherited from his original work to support > the features of context init, hostmem, resource uuid, and blob resources > for venus. > At March of this

Re: [QEMU PATCH v5 05/13] virtio-gpu: Configure context init for virglrenderer

2023-10-10 Thread Daniel P . Berrangé
On Tue, Oct 10, 2023 at 02:41:22PM +0300, Dmitry Osipenko wrote: > On 9/15/23 14:11, Huang Rui wrote: > > Configure context init feature flag for virglrenderer. > > > > Originally-by: Antonio Caggiano > > Signed-off-by: Huang Rui > > --- > > > > V4 -> V5: > > - Inverted patch 5 and 6

Re: [QEMU PATCH v5 13/13] virtio-gpu: Enable virglrenderer render server flag for venus

2023-10-10 Thread Dmitry Osipenko
On 9/15/23 14:11, Huang Rui wrote: > Venus in virglrenderer has required render server support. > > Signed-off-by: Huang Rui > --- > hw/display/virtio-gpu-virgl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/display/virtio-gpu-virgl.c

Re: [QEMU PATCH v5 05/13] virtio-gpu: Configure context init for virglrenderer

2023-10-10 Thread Dmitry Osipenko
On 9/15/23 14:11, Huang Rui wrote: > Configure context init feature flag for virglrenderer. > > Originally-by: Antonio Caggiano > Signed-off-by: Huang Rui > --- > > V4 -> V5: > - Inverted patch 5 and 6 because we should configure > HAVE_VIRGL_CONTEXT_INIT firstly. (Philippe) > >

[xen-unstable test] 183328: tolerable FAIL

2023-10-10 Thread osstest service owner
flight 183328 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183328/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183323

Re: [XEN PATCH][for-4.19 8/9] xen/types: address Rule 10.1 for DECLARE_BITMAP use

2023-10-10 Thread Julien Grall
On 10/10/2023 02:09, Stefano Stabellini wrote: On Mon, 9 Oct 2023, Julien Grall wrote: On 07/10/2023 02:04, Stefano Stabellini wrote: On Fri, 6 Oct 2023, Julien Grall wrote: Hi Nicola, On 06/10/2023 11:10, Nicola Vetrini wrote: On 06/10/2023 11:34, Julien Grall wrote: Hi Nicola, On

Re: [XEN PATCH] xen: Add SAF deviations for MISRA C:2012 Rule 7.1

2023-10-10 Thread Julien Grall
Hi Stefano, On 09/10/2023 23:19, Stefano Stabellini wrote: I am not sure this is better. This is a long line to read. But this is a personal opinion. On the technical side, can we easily teach a tool to format this kind of exception? If not, then this should not be an exception we should

[libvirt test] 183329: tolerable all pass - PUSHED

2023-10-10 Thread osstest service owner
flight 183329 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/183329/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183283 test-armhf-armhf-libvirt-qcow2 15

[PATCH for-4.19] x86/cpu-policy: Adjust CPUID_MAX_SERIALISED_LEAVES to placate MISRA

2023-10-10 Thread Andrew Cooper
MISRA doesn't like !!CONST being used in place of a 1 (Rule 10.1). Update the expression to just be a plain 1, which still matches the description. No functional change. Reported-by: Nicola Vetrini Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Nicola

Re: [XEN PATCH][for-4.19 1/2] xen: introduce a deviation for Rule 11.9

2023-10-10 Thread Nicola Vetrini
On 07/10/2023 02:33, Stefano Stabellini wrote: On Fri, 6 Oct 2023, Julien Grall wrote: On 06/10/2023 10:58, Nicola Vetrini wrote: > On 06/10/2023 11:27, Julien Grall wrote: > > Hi, > > > > On 05/10/2023 09:45, Nicola Vetrini wrote: > > > The constant 0 is used instead of NULL in '__ACCESS_ONCE'

Re: [PATCH v8 0/4] Prevent attempting updates known to fail

2023-10-10 Thread Henry Wang
Hi Andrew, > On Oct 10, 2023, at 17:19, Andrew Cooper wrote: > > On 30/08/2023 11:53 pm, Alejandro Vallejo wrote: >> Now that XENLOG_INFO is the default logging level... >> >> v8: >> * Fixed last bits mentioned by Jan in v7/patch1 (v8/patch2) >> * Rolled back to having new printk as INFO >>

MISRA C:2012 D4.11 caution on staging

2023-10-10 Thread Nicola Vetrini
Hi, as you can see from [1], there's a MISRA C guideline, D4.11, that is supposed to be clean (i.e., have no reports), but has a caution on an argument to memcpy (the second argument might be null according to the checker, given a set of assumptions on the control flow). To access the report

Re: [PATCH v8 0/4] Prevent attempting updates known to fail

2023-10-10 Thread Andrew Cooper
On 30/08/2023 11:53 pm, Alejandro Vallejo wrote: > Now that XENLOG_INFO is the default logging level... > > v8: > * Fixed last bits mentioned by Jan in v7/patch1 (v8/patch2) > * Rolled back to having new printk as INFO > * Added v8/patch1 to ensure the existing early exit from >

Re: [XEN PATCH] xen: Add SAF deviations for MISRA C:2012 Rule 7.1

2023-10-10 Thread Nicola Vetrini
On 10/10/2023 09:29, Luca Fancellu wrote: /* SAF-x-safe */ if ( modrm_mod == MASK_EXTR(instr_modrm, 0300) && (modrm_reg & 7) == MASK_EXTR(instr_modrm, 0070) && (modrm_rm & 7) == MASK_EXTR(instr_modrm, 0007) ) Any other ideas? Could we have a number in the comment to indicate the number

Re: [PATCH for-4.18 v5] xen/pdx: Make CONFIG_PDX_COMPRESSION a common Kconfig option

2023-10-10 Thread Andrew Cooper
On 10/10/2023 3:58 pm, Oleksii wrote: >> Oleksii: I've not touched RISCV yet, because I don't know how the >> platforms >> typically look.  I'm happy to default it active in RISCV too if >> that's the >> right thing to do. > We are still waiting for a platform with hypervisor extension support >

Re: [XEN PATCH][for-4.19 v2 2/2] docs/misra: add deviations.rst to document additional deviations.

2023-10-10 Thread Nicola Vetrini
On 10/10/2023 03:19, Stefano Stabellini wrote: +Henry On Mon, 9 Oct 2023, Nicola Vetrini wrote: This file contains the deviation that are not marked by a deviation comment, as specified in docs/misra/documenting-violations.rst. Suggested-by: Stefano Stabellini Signed-off-by: Nicola Vetrini

Re: Rule 10.1 violations in perfc_incra and PERFCOUNTER_ARRAY

2023-10-10 Thread Nicola Vetrini
On 10/10/2023 03:56, Stefano Stabellini wrote: On Fri, 6 Oct 2023, Nicola Vetrini wrote: Given the following macros in and #define perfc_incra(x,y) \ ( (y) <= PERFC_LAST_ ## x - PERFC_ ## x ? \

Re: [PATCH for-4.18 v5] xen/pdx: Make CONFIG_PDX_COMPRESSION a common Kconfig option

2023-10-10 Thread Oleksii
> > Oleksii: I've not touched RISCV yet, because I don't know how the > platforms > typically look.  I'm happy to default it active in RISCV too if > that's the > right thing to do. We are still waiting for a platform with hypervisor extension support but I am using PDX in my Xen's repo. ~

Re: [XEN PATCH] xen: Add SAF deviations for MISRA C:2012 Rule 7.1

2023-10-10 Thread Luca Fancellu
> >>> /* SAF-x-safe */ >>> if ( modrm_mod == MASK_EXTR(instr_modrm, 0300) && (modrm_reg & 7) == >>> MASK_EXTR(instr_modrm, 0070) && (modrm_rm & 7) == MASK_EXTR(instr_modrm, >>> 0007) ) >>> >>> Any other ideas? >> >> Could we have a number in the comment to indicate the number of lines the >>