Re: [XEN PATCH][for-4.19 v4 1/8] xen/include: add macro ISOLATE_LOW_BIT

2023-10-31 Thread Nicola Vetrini
On 2023-10-31 09:28, Nicola Vetrini wrote: On 2023-10-31 08:43, Jan Beulich wrote: On 30.10.2023 23:44, Stefano Stabellini wrote: On Mon, 30 Oct 2023, Jan Beulich wrote: On 27.10.2023 15:34, Nicola Vetrini wrote: --- a/xen/include/xen/macros.h +++ b/xen/include/xen/macros.h @@ -8,8 +8,14 @@

Re: [PATCH for-4.18 v2] automation: fix race condition in adl-suspend test

2023-10-31 Thread Henry Wang
Hi Marek, > On Oct 31, 2023, at 10:16, Marek Marczykowski-Górecki > wrote: > > If system suspends too quickly, the message for the test controller to > wake up the system may be not sent to the console before suspending. > This will cause the test to timeout. > > Fix this by calling sync on th

Re: [RFC PATCH 02/22] x86/msr: implement MSR_SMI_COUNT for Dom0 on Intel

2023-10-31 Thread Jan Beulich
On 31.10.2023 10:42, Edwin Torok wrote: >> On 30 Oct 2023, at 16:20, Jan Beulich wrote: >> On 25.10.2023 21:29, Edwin Török wrote: >>> Dom0 should always be able to read this MSR: it is useful when >>> investigating performance issues in production. >> >> While I'm not outright opposed, I'm also n

Re: [PATCH] x86/PVH: allow Dom0 ELF parsing to be verbose

2023-10-31 Thread Jan Beulich
On 31.10.2023 10:08, Roger Pau Monné wrote: > On Mon, Oct 30, 2023 at 02:14:44PM +0100, Jan Beulich wrote: >> VERBOSE had ceased to exist already before the introduction of this ELF >> parsing code. >> >> Fixes: 62ba982424cb ("x86: parse Dom0 kernel for PVHv2") >> Signed-off-by: Jan Beulich > > A

[xen-4.18-testing test] 183624: tolerable FAIL - PUSHED

2023-10-31 Thread osstest service owner
flight 183624 xen-4.18-testing real [real] flight 183634 xen-4.18-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183624/ http://logs.test-lab.xenproject.org/osstest/logs/183634/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [RFC PATCH 02/22] x86/msr: implement MSR_SMI_COUNT for Dom0 on Intel

2023-10-31 Thread Edwin Torok
> On 30 Oct 2023, at 16:20, Jan Beulich wrote: > > On 25.10.2023 21:29, Edwin Török wrote: >> Dom0 should always be able to read this MSR: it is useful when >> investigating performance issues in production. > > While I'm not outright opposed, I'm also not convinced. At the very least > ... >

Re: [RFC PATCH 03/22] x86/msr: always allow a pinned Dom0 to read any unknown MSR

2023-10-31 Thread Edwin Torok
> On 30 Oct 2023, at 16:29, Jan Beulich wrote: > > On 25.10.2023 21:29, Edwin Török wrote: >> This can be useful if you realize you have to inspect the value of an >> MSR in production, without having to change into a new Xen first that >> handles the MSR. > > Yet on a non-pinned Dom0 you'd s

[XEN PATCH v2] xen/domain_page: address violations of MISRA C:2012 Rule 8.3

2023-10-31 Thread Federico Serafini
Make function defintions and declarations consistent. No functional change. Signed-off-by: Federico Serafini --- Changes in v2: - use 'ptr' do denote a const void * parameter. --- xen/arch/arm/domain_page.c| 10 +- xen/include/xen/domain_page.h | 12 ++-- 2 files changed, 11

Re: [PATCH] x86/PVH: allow Dom0 ELF parsing to be verbose

2023-10-31 Thread Roger Pau Monné
On Mon, Oct 30, 2023 at 02:14:44PM +0100, Jan Beulich wrote: > VERBOSE had ceased to exist already before the introduction of this ELF > parsing code. > > Fixes: 62ba982424cb ("x86: parse Dom0 kernel for PVHv2") > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Some of the printed informa

Re: [XEN PATCH][for-4.19 v4 6/8] x86/mce: Move MC_NCLASSES into the enum mctelem_class

2023-10-31 Thread Nicola Vetrini
On 2023-10-27 22:50, Stefano Stabellini wrote: On Fri, 27 Oct 2023, Nicola Vetrini wrote: The definition of MC_NCLASSES contained a violation of MISRA C:2012 Rule 10.1, therefore by moving it as an enumeration constant resolves the violation and makes it more resilient to possible additions to

Re: [XEN PATCH v2] xen/set_{c,p}x_pminfo: address violations od MISRA C:2012 Rule 8.3

2023-10-31 Thread Jan Beulich
On 31.10.2023 09:33, Federico Serafini wrote: > Make function definitions and declarations consistent. > No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Jan Beulich > @@ -488,22 +488,22 @@ int set_px_pminfo(uint32_t acpi_id, struct > xen_processor_performance *dom0_px_

[XEN PATCH v2] xen/set_{c,p}x_pminfo: address violations od MISRA C:2012 Rule 8.3

2023-10-31 Thread Federico Serafini
Make function definitions and declarations consistent. No functional change. Signed-off-by: Federico Serafini --- Changes in v2: - removed unwanted changes to cpu_callback(); - improved code style. --- xen/arch/x86/x86_64/cpu_idle.c | 5 +-- xen/arch/x86/x86_64/cpufreq.c | 6 ++-- xen/drivers

Re: [XEN PATCH][for-4.19 v4 1/8] xen/include: add macro ISOLATE_LOW_BIT

2023-10-31 Thread Nicola Vetrini
On 2023-10-31 08:43, Jan Beulich wrote: On 30.10.2023 23:44, Stefano Stabellini wrote: On Mon, 30 Oct 2023, Jan Beulich wrote: On 27.10.2023 15:34, Nicola Vetrini wrote: --- a/xen/include/xen/macros.h +++ b/xen/include/xen/macros.h @@ -8,8 +8,14 @@ #define DIV_ROUND(n, d) (((n) + (d) / 2) / (

Re: [XEN PATCH][for-4.19 v5 2/8] x86: add deviation for asm-only functions

2023-10-31 Thread Jan Beulich
On 31.10.2023 09:22, Nicola Vetrini wrote: > On 2023-10-30 16:12, Jan Beulich wrote: >> On 30.10.2023 10:11, Nicola Vetrini wrote: >>> --- a/automation/eclair_analysis/ECLAIR/deviations.ecl >>> +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl >>> @@ -163,6 +163,15 @@ Therefore the absence of

Re: [XEN PATCH][for-4.19 v5 2/8] x86: add deviation for asm-only functions

2023-10-31 Thread Nicola Vetrini
On 2023-10-30 16:12, Jan Beulich wrote: On 30.10.2023 10:11, Nicola Vetrini wrote: --- a/automation/eclair_analysis/ECLAIR/deviations.ecl +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl @@ -163,6 +163,15 @@ Therefore the absence of prior declarations is safe." -config=MC3R1.R8.4,report

Re: [XEN PATCH][for-4.19 v5 2/8] x86: add deviation for asm-only functions

2023-10-31 Thread Nicola Vetrini
On 2023-10-31 08:50, Jan Beulich wrote: On 31.10.2023 00:02, Stefano Stabellini wrote: On Mon, 30 Oct 2023, Jan Beulich wrote: On 30.10.2023 10:11, Nicola Vetrini wrote: --- a/automation/eclair_analysis/ECLAIR/deviations.ecl +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl @@ -163,6 +163

Re: [XEN PATCH][for-4.19 v5 2/8] x86: add deviation for asm-only functions

2023-10-31 Thread Nicola Vetrini
On 2023-10-30 23:54, Stefano Stabellini wrote: On Mon, 30 Oct 2023, Julien Grall wrote: Hi Nicola, On 30/10/2023 09:11, Nicola Vetrini wrote: > As stated in rules.rst, functions used only in asm modules > are allowed to have no prior declaration visible when being > defined, hence these functio

Re: [XEN PATCH][for-4.19 v5 2/8] x86: add deviation for asm-only functions

2023-10-31 Thread Jan Beulich
On 31.10.2023 00:02, Stefano Stabellini wrote: > On Mon, 30 Oct 2023, Jan Beulich wrote: >> On 30.10.2023 10:11, Nicola Vetrini wrote: >>> --- a/automation/eclair_analysis/ECLAIR/deviations.ecl >>> +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl >>> @@ -163,6 +163,15 @@ Therefore the absence

Re: [XEN PATCH][for-4.19 v4 1/8] xen/include: add macro ISOLATE_LOW_BIT

2023-10-31 Thread Jan Beulich
On 30.10.2023 23:44, Stefano Stabellini wrote: > On Mon, 30 Oct 2023, Jan Beulich wrote: >> On 27.10.2023 15:34, Nicola Vetrini wrote: >>> --- a/xen/include/xen/macros.h >>> +++ b/xen/include/xen/macros.h >>> @@ -8,8 +8,14 @@ >>> #define DIV_ROUND(n, d) (((n) + (d) / 2) / (d)) >>> #define DIV_ROU

<    1   2