Re: [PATCH v2] misra: add R21.1 R21.2

2023-11-15 Thread Jan Beulich
On 14.11.2023 23:59, Stefano Stabellini wrote: > Add 21.1 and 21.2, with a longer comment to explain how strategy with > leading underscores and why we think we are safe today. > > Signed-off-by: Stefano Stabellini Acked-by: Jan Beulich with one nit: > --- a/docs/misra/rules.rst > +++ b/docs/m

Re: [PATCH 4/5] tools/xenstored: remove "-N" command line option

2023-11-15 Thread Edwin Torok
> On 14 Nov 2023, at 22:11, Andrew Cooper wrote: > > On 13/11/2023 12:43 pm, Juergen Gross wrote: >> The "-N" (do not daemonize) command line option is of questionable use: >> its sole purpose seems to be to aid debugging of xenstored by making it >> easier to start xenstored under gdb, or to

Re: [PATCH v3] xen/asm-generic: ifdef inclusion of

2023-11-15 Thread Oleksii
On Tue, 2023-11-14 at 18:19 +0100, Jan Beulich wrote: > On 14.11.2023 16:13, Oleksii Kurochko wrote: > > ifdefing inclusion of in > > allows to avoid generation of empty header > > for the case when !CONFIG_MEM_ACCESS. > > > > For Arm it was explicitly added inclusion of for > > p2m.c > > and

[xen-4.18-testing test] 183754: tolerable FAIL - PUSHED

2023-11-15 Thread osstest service owner
flight 183754 xen-4.18-testing real [real] flight 183761 xen-4.18-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183754/ http://logs.test-lab.xenproject.org/osstest/logs/183761/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [PATCH 4/5] tools/xenstored: remove "-N" command line option

2023-11-15 Thread Juergen Gross
On 15.11.23 09:31, Edwin Torok wrote: On 14 Nov 2023, at 22:11, Andrew Cooper wrote: On 13/11/2023 12:43 pm, Juergen Gross wrote: The "-N" (do not daemonize) command line option is of questionable use: its sole purpose seems to be to aid debugging of xenstored by making it easier to start x

Re: [PATCH v2 07/15] xen/asm-generic: introduce stub header

2023-11-15 Thread Jan Beulich
On 10.11.2023 17:30, Oleksii Kurochko wrote: > is common for Arm, PPC and RISC-V thereby it > is moved to asm-generic. When you say "moved", ... > Signed-off-by: Oleksii Kurochko > --- > Changes in V2: > - update the commit messages > --- > xen/include/asm-generic/random.h | 20 ++

Re: [PATCH v2 13/15] xen/asm-generic: introduce stub header monitor.h

2023-11-15 Thread Jan Beulich
On 10.11.2023 17:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/include/asm-generic/monitor.h > @@ -0,0 +1,62 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * include/asm-GENERIC/monitor.h > + * > + * Arch-specific monitor_op domctl handler. > + * > + * Copyright (c) 2015 Tamas K L

Re: [PATCH v2 14/15] xen/asm-generic: introduce stub header numa.h

2023-11-15 Thread Jan Beulich
On 10.11.2023 17:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/include/asm-generic/numa.h > @@ -0,0 +1,40 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef __ARCH_GENERIC_NUMA_H > +#define __ARCH_GENERIC_NUMA_H > + > +#include > +#include I'm afraid I can't spot what you nee

Re: xen | Failed pipeline for staging-4.17 | 28f44b60

2023-11-15 Thread Jan Beulich
On 14.11.2023 21:26, GitLab wrote: > > > Pipeline #1072370735 has failed! > > Project: xen ( https://gitlab.com/xen-project/xen ) > Branch: staging-4.17 ( > https://gitlab.com/xen-project/xen/-/commits/staging-4.17 ) > > Commit: 28f44b60 ( > https://gitlab.com/xen-project/xen/-/commit/28f44b6

Re: [PATCH v2] xen: remove

2023-11-15 Thread Jan Beulich
On 31.10.2023 15:28, Oleksii Kurochko wrote: > only declares udelay() function so udelay() > declaration was moved to xen/delay.h. > > For x86, __udelay() was renamed to udelay() and removed > inclusion of in x86 code. > > For ppc, udelay() stub definition was moved to ppc/stubs.c. > > Suggest

Re: [XEN PATCH v4 1/2] automation/eclair: make the docs for MISRA C:2012 Dir 4.1 visible to ECLAIR

2023-11-15 Thread Nicola Vetrini
On 2023-11-14 23:12, Julien Grall wrote: Hi, On 14/11/2023 15:36, Nicola Vetrini wrote: To be able to check for the existence of the necessary subsections in the documentation for MISRA C:2012 Dir 4.1, ECLAIR needs to have a source file that is built. This file is generated from 'C-runtime-f

Re: [XEN PATCH v4 1/2] automation/eclair: make the docs for MISRA C:2012 Dir 4.1 visible to ECLAIR

2023-11-15 Thread Julien Grall
Hi, On 15/11/2023 11:02, Nicola Vetrini wrote: On 2023-11-14 23:12, Julien Grall wrote: Hi, On 14/11/2023 15:36, Nicola Vetrini wrote: To be able to check for the existence of the necessary subsections in the documentation for MISRA C:2012 Dir 4.1, ECLAIR needs to have a source file that is

[RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Sergiy Kibrik
From: Oleksandr Tyshchenko In order to enable more use-cases such as having multiple device-models (Qemu) running in different backend domains which provide virtio-pci devices for the same guest, we allocate and expose one PCI host bridge for every virtio backend domain for that guest. For that

[RFC PATCH 0/6] ARM virtio-pci initial support

2023-11-15 Thread Sergiy Kibrik
Hi, In this patch series we introduce support of PCI devices emulated by Virtio on ARM platform. A guest system is presented with Virtio Host bridge device, through which a number of emulated PCI devices (e.g. disk, network, graphic, audio etc) can work with corresponding guests' subsystems. For

[RFC PATCH 4/6] libxl/arm: Reuse generic PCI-IOMMU bindings for virtio-pci devices

2023-11-15 Thread Sergiy Kibrik
From: Oleksandr Tyshchenko Use the same "xen-grant-dma" device concept for the PCI devices behind device-tree based PCI Host controller, but with one modification. Unlike for platform devices, we cannot use generic IOMMU bindings (iommus property), as we need to support more flexible configuratio

[RFC PATCH 1/6] libxl: Pass max_vcpus to Qemu in case of PVH domain (Arm) as well

2023-11-15 Thread Sergiy Kibrik
From: Oleksandr Tyshchenko The number of vCPUs used for the IOREQ configuration (machine->smp.cpus) should really match the system value as for each vCPU we setup a dedicated evtchn for the communication with Xen at the runtime. This is needed for the IOREQ to be properly configured and work if t

[RFC PATCH 3/6] libxl/arm: Add basic virtio-pci support

2023-11-15 Thread Sergiy Kibrik
From: Oleksandr Tyshchenko Introduce new transport mechanism "pci" for the Virtio device and update parsing and configuration logic accordingly. In order to enable more use-cases such as having multiple device-models (Qemu) running in different backend domains which provide virtio-pci devices fo

[RFC PATCH 5/6] xen/arm: Intercept vPCI config accesses and forward them to emulator

2023-11-15 Thread Sergiy Kibrik
From: Oleksandr Tyshchenko This is needed for supporting virtio-pci. In case when the PCI Host bridge is emulated outside of Xen (IOREQ server), we need some mechanism to intercept config space accesses on Xen on Arm, and forward them to the emulator (for example, virtio backend) via IOREQ reque

Re: [XEN PATCH][for-4.19 v2] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-15 Thread Nicola Vetrini
On 2023-11-13 15:44, Jan Beulich wrote: On 07.11.2023 11:30, Nicola Vetrini wrote: --- a/xen/arch/x86/boot/cmdline.c +++ b/xen/arch/x86/boot/cmdline.c @@ -31,6 +31,7 @@ asm ( ); #include +#include #include "defs.h" #include "video.h" Please respect the goal of alphabetically sorted

[RFC PATCH 6/6] libxl: Add "backend_type" property for the Virtio devices

2023-11-15 Thread Sergiy Kibrik
From: Oleksandr Tyshchenko Introduce new configuration option "backend_type" for the Virtio devices in order to specify backend implementation to use. There are two possible values "qemu" (default) and "standalone". If backend is in Qemu (backend_type=qemu) and Qemu runs in toolstack domain (bac

Important - Documentation Discussion

2023-11-15 Thread Kelly Choi
Hi all, As you may be aware, we are in the process of reviewing our existing documentation platform and content. In order to meet the requirements of the community and project, I need your input and feedback. The aim of the new documentation is to encourage community members to collaborate in upd

Re: Important - Documentation Discussion

2023-11-15 Thread Alejandro Vallejo
Hi, On Wed, Nov 15, 2023 at 11:43:46AM +, Kelly Choi wrote: > Hi all, > > As you may be aware, we are in the process of reviewing our existing > documentation platform and content. In order to meet the requirements of > the community and project, I need your input and feedback. > > The aim o

[PATCH for-4.18] SUPPORT.md: Define support lifetime

2023-11-15 Thread Julien Grall
From: Julien Grall Signed-off-by: Julien Grall --- SUPPORT.md | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index fff4b4c5bad6..c452635eb552 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -9,10 +9,10 @@ for the definitions of the support status

Re: [PATCH for-4.18] SUPPORT.md: Define support lifetime

2023-11-15 Thread Henry Wang
Hi Julien, > On Nov 15, 2023, at 20:16, Julien Grall wrote: > > From: Julien Grall > > Signed-off-by: Julien Grall Thanks for the patch and all your effort during the release period! Release-acked-by: Henry Wang Kind regards, Henry > --- > SUPPORT.md | 8 > 1 file changed, 4 inse

Re: [PATCH for-4.18] SUPPORT.md: Define support lifetime

2023-11-15 Thread Henry Wang
Hi Julien, > On Nov 15, 2023, at 20:16, Julien Grall wrote: > > From: Julien Grall > > Signed-off-by: Julien Grall > --- > SUPPORT.md | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/SUPPORT.md b/SUPPORT.md > index fff4b4c5bad6..c452635eb552 100644 > --- a/SUPP

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Julien Grall
Hi, Thanks for adding support for virtio-pci in Xen. I have some questions. On 15/11/2023 11:26, Sergiy Kibrik wrote: From: Oleksandr Tyshchenko In order to enable more use-cases such as having multiple device-models (Qemu) running in different backend domains which provide virtio-pci devices

Re: [PATCH for-4.18] SUPPORT.md: Define support lifetime

2023-11-15 Thread Julien Grall
Hi Henry, On 15/11/2023 12:27, Henry Wang wrote: On Nov 15, 2023, at 20:16, Julien Grall wrote: From: Julien Grall Signed-off-by: Julien Grall --- SUPPORT.md | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index fff4b4c5bad6..c452635eb552 1

Re: [PATCH for-4.18] SUPPORT.md: Define support lifetime

2023-11-15 Thread Henry Wang
Hi Julien, > On Nov 15, 2023, at 20:35, Julien Grall wrote: > > Hi Henry, > > On 15/11/2023 12:27, Henry Wang wrote: >>> On Nov 15, 2023, at 20:16, Julien Grall wrote: >>> >>> From: Julien Grall >>> >>> Signed-off-by: Julien Grall >>> --- >>> SUPPORT.md | 8 >>> 1 file changed, 4 i

Re: [PATCH v2 07/15] xen/asm-generic: introduce stub header

2023-11-15 Thread Oleksii
On Wed, 2023-11-15 at 10:56 +0100, Jan Beulich wrote: > On 10.11.2023 17:30, Oleksii Kurochko wrote: > > is common for Arm, PPC and RISC-V thereby it > > is moved to asm-generic. > > When you say "moved", ... > > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V2: > >  - update the com

Re: [RFC PATCH 5/6] xen/arm: Intercept vPCI config accesses and forward them to emulator

2023-11-15 Thread Julien Grall
Hi, On 15/11/2023 11:26, Sergiy Kibrik wrote: From: Oleksandr Tyshchenko This is needed for supporting virtio-pci. In case when the PCI Host bridge is emulated outside of Xen (IOREQ server), we need some mechanism to intercept config space accesses on Xen on Arm, and forward them to the emula

Re: [PATCH v2 13/15] xen/asm-generic: introduce stub header monitor.h

2023-11-15 Thread Oleksii
On Wed, 2023-11-15 at 11:00 +0100, Jan Beulich wrote: > On 10.11.2023 17:30, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/include/asm-generic/monitor.h > > @@ -0,0 +1,62 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * include/asm-GENERIC/monitor.h > > + * > > + * Arch-spec

Re: [PATCH 0/2] livepatch-tools: fixes for building on non-glibc

2023-11-15 Thread Ross Lagerwall
On Mon, Nov 13, 2023 at 4:10 PM Roger Pau Monne wrote: > > Hello, > > A couple of fixes to allow building the tools on non-glibc systems (BSD > and musl tested). > > No functional changes intended for either of the two fixes. > Reviewed-by: Ross Lagerwall Applied, thanks. Ross

[xen-unstable-smoke test] 183762: tolerable all pass - PUSHED

2023-11-15 Thread osstest service owner
flight 183762 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183762/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[xen-unstable test] 183755: tolerable FAIL - PUSHED

2023-11-15 Thread osstest service owner
flight 183755 xen-unstable real [real] flight 183763 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183755/ http://logs.test-lab.xenproject.org/osstest/logs/183763/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armh

Re: [PATCH v2 14/15] xen/asm-generic: introduce stub header numa.h

2023-11-15 Thread Oleksii
On Wed, 2023-11-15 at 11:07 +0100, Jan Beulich wrote: > On 10.11.2023 17:30, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/include/asm-generic/numa.h > > @@ -0,0 +1,40 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +#ifndef __ARCH_GENERIC_NUMA_H > > +#define __ARCH_GENERIC_NUMA_H

Re: [PATCH v2 13/15] xen/asm-generic: introduce stub header monitor.h

2023-11-15 Thread Oleksii
On Wed, 2023-11-15 at 14:54 +0200, Oleksii wrote: > On Wed, 2023-11-15 at 11:00 +0100, Jan Beulich wrote: > > On 10.11.2023 17:30, Oleksii Kurochko wrote: > > > --- /dev/null > > > +++ b/xen/include/asm-generic/monitor.h > > > @@ -0,0 +1,62 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > +/*

xen | Successful pipeline for staging-4.18 | 1924da16

2023-11-15 Thread GitLab
Pipeline #1073406875 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging-4.18 ( https://gitlab.com/xen-project/xen/-/commits/staging-4.18 ) Commit: 1924da16 ( https://gitlab.com/xen-project/xen/-/commit/1924da16239703edc7be6de0f5a549a30aa84b82 ) Commit Message: Co

Re: xen | Failed pipeline for staging-4.17 | 28f44b60

2023-11-15 Thread Anthony PERARD
On Wed, Nov 15, 2023 at 11:11:30AM +0100, Jan Beulich wrote: > On 14.11.2023 21:26, GitLab wrote: > > Pipeline #1072370735 ( > > https://gitlab.com/xen-project/xen/-/pipelines/1072370735 ) triggered by > > Ganis ( https://gitlab.com/ganis ) > > had 4 failed jobs. > > > > Job #5534997591 ( https:

Re: [PATCH v2] xen: remove

2023-11-15 Thread Oleksii
On Wed, 2023-11-15 at 11:24 +0100, Jan Beulich wrote: > On 31.10.2023 15:28, Oleksii Kurochko wrote: > > only declares udelay() function so udelay() > > declaration was moved to xen/delay.h. > > > > For x86, __udelay() was renamed to udelay() and removed > > inclusion of in x86 code. > > > > Fo

Re: [PATCH v2 08/15] xen/asm-generic: introduce generic header percpu.h

2023-11-15 Thread Oleksii
I have to drop arch specific headers and switch to asm-generic version. I'll do the same for patches 09-12 in the next patch version. ~ Oleksii On Fri, 2023-11-10 at 18:30 +0200, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes in V2: > - use smp_processor_id() in

[Discussion]: Making "LIBXL_HOTPLUG_TIMEOUT" configurable through 'xl.conf'

2023-11-15 Thread Divin Raj
Hi Xen community, On one of our internal projects we came across an issue in the toolstack: when multiple network interfaces are initialized concurrently with other system workloads, the execution time of the hotplug script often exceeds 40 seconds, leading to an error. To mitigate this issue,

Re: [RFC PATCH 6/6] libxl: Add "backend_type" property for the Virtio devices

2023-11-15 Thread Juergen Gross
On 15.11.23 12:44, Sergiy Kibrik wrote: From: Oleksandr Tyshchenko Introduce new configuration option "backend_type" for the Virtio devices in order to specify backend implementation to use. There are two possible values "qemu" (default) and "standalone". If backend is in Qemu (backend_type=qe

[linux-linus test] 183759: trouble: broken/fail/pass

2023-11-15 Thread osstest service owner
flight 183759 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183759/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64 broken test-amd64

Re: Values generated by the ViryaOS uboot-script-gen do not work correctly on the Chromebook Snow

2023-11-15 Thread Chuck Zmudzinski
On 11/14/2023 6:43 PM, Mario Marietto wrote: > I hope that the informations below are correct : I don't know that they are correct. I have not spent the necessary time to determine what the correct values for MEMORY_START and MEMORY_END are for the Chromebook we are using. I just presumed, probabl

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Oleksandr Tyshchenko
On 15.11.23 14:33, Julien Grall wrote: > Hi, Hello Julien Let me please try to explain some bits. > > Thanks for adding support for virtio-pci in Xen. I have some questions. > > On 15/11/2023 11:26, Sergiy Kibrik wrote: >> From: Oleksandr Tyshchenko >> >> In order to enable more use-cases

xen | Failed pipeline for staging | 7ad0c774

2023-11-15 Thread GitLab
Pipeline #1073278423 has failed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 7ad0c774 ( https://gitlab.com/xen-project/xen/-/commit/7ad0c774e474f6d95dfda868d876af507d399657 ) Commit Message: x86/boot: tid

Re: [Discussion]: Making "LIBXL_HOTPLUG_TIMEOUT" configurable through 'xl.conf'

2023-11-15 Thread Olaf Hering
Wed, 15 Nov 2023 15:29:09 + Divin Raj : > LIBXL_HOTPLUG_TIMEOUT This is already solved by "libxl.LIBXL_HOTPLUG_TIMEOUT.patch" from https://build.opensuse.org/package/show/openSUSE:Factory/xen Up to now it was not considered important enough for xen.git#staging. Olaf pgpNn3pRObDgi.pgp Des

[PATCH 2/3] vl: disable default serial when xen-console is enabled

2023-11-15 Thread David Woodhouse
From: David Woodhouse If a Xen console is configured on the command line, do not add a default serial port. Signed-off-by: David Woodhouse --- system/vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/system/vl.c b/system/vl.c index 5af7ced2a1..8109231834 100644 --- a/system/vl.c +++ b/s

[PATCH 1/3] net: do not delete nics in net_cleanup()

2023-11-15 Thread David Woodhouse
From: David Woodhouse In net_cleanup() we only need to delete the netdevs, as those may have state which outlives Qemu when it exits, and thus may actually need to be cleaned up on exit. The nics, on the other hand, are owned by the device which created them. Most devices don't bother to clean u

[PATCH 3/3] hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive

2023-11-15 Thread David Woodhouse
From: David Woodhouse Coverity couldn't see that nr_existing was always going to be zero when qemu_xen_xs_directory() returned NULL in the ENOENT case (CID 1523906). Perhaps more to the point, neither could Peter at first glance. Improve the code to hopefully make it clearer to Coverity and huma

[PATCH 0/3] Misc fixes for 8.2

2023-11-15 Thread David Woodhouse
Fix a use-after-free (or double-free) due to net_cleanup() freeing NICs that don't belong to it, fix a newly-introduced launch failure with a documented command line, and clean up code to avoid a Coverity warning. David Woodhouse (3): net: do not delete nics in net_cleanup() vl: disabl

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Julien Grall
Hi Oleksandr, On 15/11/2023 16:51, Oleksandr Tyshchenko wrote: On 15.11.23 14:33, Julien Grall wrote: Hi, Hello Julien Let me please try to explain some bits. Thanks for adding support for virtio-pci in Xen. I have some questions. On 15/11/2023 11:26, Sergiy Kibrik wrote: From: Olek

Re: [PATCH] arm/mm: add option to prefer IOMMU ops for DMA on Xen

2023-11-15 Thread Chuck Zmudzinski
On 11/14/2023 5:20 PM, Stefano Stabellini wrote: > On Tue, 14 Nov 2023, Robin Murphy wrote: >> On 11/11/2023 6:45 pm, Chuck Zmudzinski wrote: >> > Enabling the new option, ARM_DMA_USE_IOMMU_XEN, fixes this error when >> > attaching the Exynos mixer in Linux dom0 on Xen on the Chromebook Snow >> > (

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Oleksandr Tyshchenko
On 15.11.23 19:31, Julien Grall wrote: > Hi Oleksandr, Hello Julien > > On 15/11/2023 16:51, Oleksandr Tyshchenko wrote: >> >> >> On 15.11.23 14:33, Julien Grall wrote: >>> Hi, >> >> >> Hello Julien >> >> Let me please try to explain some bits. >> >> >>> >>> Thanks for adding support for virt

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Julien Grall
Hi Oleksandr, On 15/11/2023 18:14, Oleksandr Tyshchenko wrote: On 15.11.23 19:31, Julien Grall wrote: On 15/11/2023 16:51, Oleksandr Tyshchenko wrote: On 15.11.23 14:33, Julien Grall wrote: Thanks for adding support for virtio-pci in Xen. I have some questions. On 15/11/2023 11:26, Sergiy Ki

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Oleksandr Tyshchenko
On 15.11.23 20:33, Julien Grall wrote: > Hi Oleksandr, Hello Julien > > On 15/11/2023 18:14, Oleksandr Tyshchenko wrote: >> On 15.11.23 19:31, Julien Grall wrote: >>> On 15/11/2023 16:51, Oleksandr Tyshchenko wrote: On 15.11.23 14:33, Julien Grall wrote: > Thanks for adding support f

Re: [PATCH] arm/mm: add option to prefer IOMMU ops for DMA on Xen

2023-11-15 Thread Mario Marietto
---> So I plan to do some tests and see what DMA ops the other devices use if swiotlb-xen is disabled and also what DMA ops the other devices use when Linux runs on the Chromebook on bare metal without Xen. If these tests show the problem can be fixed by disabling swiotlb-xen with a Kconfig or com

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Julien Grall
Hi Oleksandr, On 15/11/2023 19:38, Oleksandr Tyshchenko wrote: The ioreq.c code was always meant to be generic and is always for every emulated MMIO. So you want to limit any change in it. Checking the MMIO region belongs to the hostbridge and doing the translation is IMHO not a good idea to do

[xen-4.17-testing test] 183760: tolerable FAIL - PUSHED

2023-11-15 Thread osstest service owner
flight 183760 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/183760/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183753 test-amd64-i386-xl-qemuu-win7-am

Re: [PATCH 3/3] hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive

2023-11-15 Thread Paul Durrant
On 15/11/2023 12:24, David Woodhouse wrote: From: David Woodhouse Coverity couldn't see that nr_existing was always going to be zero when qemu_xen_xs_directory() returned NULL in the ENOENT case (CID 1523906). Perhaps more to the point, neither could Peter at first glance. Improve the code to

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Stefano Stabellini
+ Stewart, Vikram On Wed, 15 Nov 2023, Oleksandr Tyshchenko wrote: > On 15.11.23 14:33, Julien Grall wrote: > > Thanks for adding support for virtio-pci in Xen. I have some questions. > > > > On 15/11/2023 11:26, Sergiy Kibrik wrote: > >> From: Oleksandr Tyshchenko > >> > >> In order to enable m

Re: [RFC PATCH 5/6] xen/arm: Intercept vPCI config accesses and forward them to emulator

2023-11-15 Thread Stefano Stabellini
On Wed, 15 Nov 2023, Julien Grall wrote: > Hi, > > On 15/11/2023 11:26, Sergiy Kibrik wrote: > > From: Oleksandr Tyshchenko > > > > This is needed for supporting virtio-pci. > > > > In case when the PCI Host bridge is emulated outside of Xen > > (IOREQ server), we need some mechanism to interce

Re: Values generated by the ViryaOS uboot-script-gen do not work correctly on the Chromebook Snow

2023-11-15 Thread Stefano Stabellini
On Wed, 15 Nov 2023, Chuck Zmudzinski wrote: > On 11/14/2023 6:43 PM, Mario Marietto wrote: > > I hope that the informations below are correct : > > I don't know that they are correct. I have not spent the necessary time to > determine what the correct values for MEMORY_START and MEMORY_END are fo

Re: [PATCH v2] misra: add R21.1 R21.2

2023-11-15 Thread Stefano Stabellini
On Wed, 15 Nov 2023, Jan Beulich wrote: > On 14.11.2023 23:59, Stefano Stabellini wrote: > > Add 21.1 and 21.2, with a longer comment to explain how strategy with > > leading underscores and why we think we are safe today. > > > > Signed-off-by: Stefano Stabellini > > Acked-by: Jan Beulich > wi

Re: Values generated by the ViryaOS uboot-script-gen do not work correctly on the Chromebook Snow

2023-11-15 Thread Mario Marietto
It didn't work. This is the scr file generated. ext2load mmc 1:3 0x5100 zImage-6.6.0-xen-iommu-dma-on-xen ext2load mmc 1:3 0x6000 xen-4.17-armhf.ub ext2load mmc 1:3 0x6100 exynos5250-snow.dtb fdt addr 0x6100 fdt resize 1024 fdt set /chosen \#address-cells <0x2> fdt set /chosen \#si

Re: [RFC 1/4] x86/ioemul: address MISRA C:2012 Rule 9.3

2023-11-15 Thread Stefano Stabellini
On Mon, 13 Nov 2023, Jan Beulich wrote: > On 11.11.2023 02:23, Stefano Stabellini wrote: > > On Mon, 6 Nov 2023, Nicola Vetrini wrote: > > There's also this functionally equivalent alternative, with or without > > the zeros, which > > doesn't incur in the risk of mistakenly attempting t

Re: Values generated by the ViryaOS uboot-script-gen do not work correctly on the Chromebook Snow

2023-11-15 Thread Stefano Stabellini
I miscalculated MEMORY_START. If you try with: offset=$((240*1024*1024)) # this change in scripts/uboot-script-gen MEMORY_START="0x2400" MEMORY_END="0x8000" then it should use: tftpb 0x4200 Linux tftpb 0x5000 Xen tftpb 0x6000 DTB which is very similar to what Chuck used. It m

xen | Successful pipeline for staging | fb62aa71

2023-11-15 Thread GitLab
Pipeline #1074149645 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: fb62aa71 ( https://gitlab.com/xen-project/xen/-/commit/fb62aa714d72349722d63b32a5a6d20a677f39e0 ) Commit Message: misra: add R2

[xen-4.18-testing test] 183764: tolerable FAIL - PUSHED

2023-11-15 Thread osstest service owner
flight 183764 xen-4.18-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/183764/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail blocked in 183754 test-armhf-armhf-libvirt 16

[xen-unstable-smoke test] 183767: tolerable all pass - PUSHED

2023-11-15 Thread osstest service owner
flight 183767 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183767/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v2 07/15] xen/asm-generic: introduce stub header

2023-11-15 Thread Jan Beulich
On 15.11.2023 13:39, Oleksii wrote: > On Wed, 2023-11-15 at 10:56 +0100, Jan Beulich wrote: >> On 10.11.2023 17:30, Oleksii Kurochko wrote: >>> is common for Arm, PPC and RISC-V thereby it >>> is moved to asm-generic. >> >> When you say "moved", ... >> >>> Signed-off-by: Oleksii Kurochko >>> ---

Re: [PATCH v2 13/15] xen/asm-generic: introduce stub header monitor.h

2023-11-15 Thread Jan Beulich
On 15.11.2023 13:54, Oleksii wrote: > On Wed, 2023-11-15 at 11:00 +0100, Jan Beulich wrote: >> On 10.11.2023 17:30, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/include/asm-generic/monitor.h >>> @@ -0,0 +1,62 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +/* >>> + * include/asm-GENE

Re: [PATCH v2 14/15] xen/asm-generic: introduce stub header numa.h

2023-11-15 Thread Jan Beulich
On 15.11.2023 15:11, Oleksii wrote: > On Wed, 2023-11-15 at 11:07 +0100, Jan Beulich wrote: >> On 10.11.2023 17:30, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/include/asm-generic/numa.h >>> @@ -0,0 +1,40 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>> +#ifndef __ARCH_GENERIC_NU

[xen-unstable test] 183765: tolerable FAIL - PUSHED

2023-11-15 Thread osstest service owner
flight 183765 xen-unstable real [real] flight 183768 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183765/ http://logs.test-lab.xenproject.org/osstest/logs/183768/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: [PATCH v2 08/15] xen/asm-generic: introduce generic header percpu.h

2023-11-15 Thread Jan Beulich
On 10.11.2023 17:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/include/asm-generic/percpu.h > @@ -0,0 +1,35 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef __ASM_GENERIC_PERCPU_H__ > +#define __ASM_GENERIC_PERCPU_H__ > + > +#ifndef __ASSEMBLY__ > + > +#include > + > +extern

Re: [Discussion]: Making "LIBXL_HOTPLUG_TIMEOUT" configurable through 'xl.conf'

2023-11-15 Thread Jan Beulich
On 15.11.2023 18:23, Olaf Hering wrote: > Wed, 15 Nov 2023 15:29:09 + Divin Raj : > >> LIBXL_HOTPLUG_TIMEOUT > > This is already solved by "libxl.LIBXL_HOTPLUG_TIMEOUT.patch" from > https://build.opensuse.org/package/show/openSUSE:Factory/xen > Up to now it was not considered important enoug

4.18 vs mini-os

2023-11-15 Thread Jan Beulich
All, may I ask on what basis the xen-RELEASE-4.18.0 tag placement was chosen? It matches the 4.17 ones, despite there having been new commits from Jürgen dating back to January / February. (My own build fix would have been nice to have, too, but I can see how that came late.) Jan

Re: [Discussion]: Making "LIBXL_HOTPLUG_TIMEOUT" configurable through 'xl.conf'

2023-11-15 Thread Olaf Hering
Thu, 16 Nov 2023 08:45:43 +0100 Jan Beulich : > Did you ever submit it? Likely not. I think the approach to use a xenstore entry was used to avoid ABI incompatibilities due to changed .idl files. In case anyone really wants up upstream such change, a global per-device timeout should not go into