Re: [PATCH v2] tools/libs/evtchn: replace assert()s in stubdom with proper locking

2023-12-07 Thread Juergen Gross
On 08.12.23 08:34, Jan Beulich wrote: On 07.12.2023 07:25, Juergen Gross wrote: In tools/libs/evtchn/minios.c there are assert()s for the current thread being the main thread when binding an event channel. As Mini-OS is supporting multiple threads, there is no real reason why the binding

Re: [PATCH v2] tools/libs/evtchn: replace assert()s in stubdom with proper locking

2023-12-07 Thread Jan Beulich
On 07.12.2023 07:25, Juergen Gross wrote: > In tools/libs/evtchn/minios.c there are assert()s for the current > thread being the main thread when binding an event channel. > > As Mini-OS is supporting multiple threads, there is no real reason > why the binding shouldn't be allowed to happen in

Re: [PATCH v2] docs/misra/rules.rst: add more rules

2023-12-07 Thread Jan Beulich
On 08.12.2023 01:09, Stefano Stabellini wrote: > Add the rules accepted in the last three MISRA C working group meetings. > > Signed-off-by: Stefano Stabellini Acked-by: Jan Beulich > --- a/docs/misra/rules.rst > +++ b/docs/misra/rules.rst > @@ -462,6 +462,13 @@ maintainers if you want to

Re: [PATCH] docs/misra/rules.rst: add more rules

2023-12-07 Thread Jan Beulich
On 08.12.2023 01:08, Stefano Stabellini wrote: > On Thu, 7 Dec 2023, Jan Beulich wrote: >> On 07.12.2023 03:42, Stefano Stabellini wrote: >>> On Wed, 6 Dec 2023, Jan Beulich wrote: On 06.12.2023 04:02, Stefano Stabellini wrote: > --- a/docs/misra/rules.rst > +++ b/docs/misra/rules.rst

Re: [RFC KERNEL PATCH v2 2/3] xen/pvh: Unmask irq for passthrough device in PVH dom0

2023-12-07 Thread Chen, Jiqian
Thank Stefano and Juergen, I will use this approach in next version. On 2023/12/7 14:43, Juergen Gross wrote: > On 07.12.23 03:18, Stefano Stabellini wrote: >> On Tue, 5 Dec 2023, Chen, Jiqian wrote: >>> When PVH dom0 enable a device, it will get trigger and polarity from ACPI >>> (see

[PATCH v2 5/5] automation: Add the arm64 FVP build and Dom0 smoke test jobs

2023-12-07 Thread Henry Wang
Add a job in the build stage to export the TF-A, U-Boot and the device tree for the FVP platform from the test artifact container. Add a FVP smoke test job in the test stage to do the same test as the `qemu-smoke-dom0-arm64-gcc` job. Signed-off-by: Henry Wang Reviewed-by: Stefano Stabellini

[PATCH v2 1/5] automation: Add a Dockerfile for running FVP_Base jobs

2023-12-07 Thread Henry Wang
Fixed Virtual Platforms (FVPs) are complete simulations of an Arm system, including processor, memory and peripherals. These are set out in a "programmer's view", which gives programmers a comprehensive model on which to build and test software. FVP can be configured to different setups by its

[PATCH v2 3/5] automation: Add the expect script with test case for FVP

2023-12-07 Thread Henry Wang
To interact with the FVP (for example entering the U-Boot shell and transferring the files by TFTP), we need to connect the corresponding port by the telnet first. Use an expect script to simplify the automation of the whole "interacting with FVP" stuff. The expect script will firstly detect the

[PATCH v2 4/5] automation: Add the script for the FVP smoke test

2023-12-07 Thread Henry Wang
This commit adds the shell script for the FVP smoke test. Similarly as the QEMU jobs, the shell script will firstly prepare the DomU BusyBox image, use the ImageBuilder to arrange the binaries in memory and generate the U-Boot script, then start the test. To provide the TFTP service for the FVP,

[PATCH v2 2/5] automation: Add the Dockerfile to build TF-A and U-Boot for FVP

2023-12-07 Thread Henry Wang
Unlike the emulators that currently being used in the CI pipelines, the FVP must start at EL3. Therefore we need the firmware, i.e. the TrustedFirmware-A (TF-A), for corresponding functionality. There is a dedicated board (vexpress_fvp) in U-Boot (serve as the BL33 of the TF-A) for the FVP

[PATCH v2 0/5] automation: Support running FVP Dom0 smoke test for Arm

2023-12-07 Thread Henry Wang
This series adds the support for running FVP Dom0 smoke test for Arm on the Arm64 GitLab CI runner. Detailed changes please refer to the commit message of each commit. An example test pipeline with these patches applied (with the docker registry changed to my own registry and unrelated job

Re: [PATCH 3/5] automation: Add the expect script with test case for FVP

2023-12-07 Thread Henry Wang
Hi Stefano, > On Dec 8, 2023, at 10:03, Henry Wang wrote: > > Hi Stefano, > >> On Dec 8, 2023, at 09:38, Stefano Stabellini wrote: >>> +set host_ip $expect_out(0,string) >>> + >>> +# Start the FVP and run the test >>> +spawn bash -c "$runcmd" >>> + >>> +test_boot 2000 "$host_ip" >>> + >>>

Re: [PATCH 3/5] automation: Add the expect script with test case for FVP

2023-12-07 Thread Henry Wang
Hi Stefano, > On Dec 8, 2023, at 09:38, Stefano Stabellini wrote: > > On Thu, 7 Dec 2023, Henry Wang wrote: >> To interact with the FVP (for example entering the U-Boot shell >> and transferring the files by TFTP), we need to connect the >> corresponding port by the telnet first. Use an expect

Re: [PATCH 4/5] automation: Add the script for the FVP smoke test

2023-12-07 Thread Henry Wang
Hi Stefano, > On Dec 8, 2023, at 09:41, Stefano Stabellini wrote: > > On Thu, 7 Dec 2023, Henry Wang wrote: >> This commit adds the shell script for the FVP smoke test. Similarly >> as the QEMU jobs, the shell script will firstly prepare the DomU >> BusyBox image, use the ImageBuilder to

Re: [PATCH 1/5] automation: Add a Dockerfile for running FVP_Base jobs

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Stefano Stabellini wrote: > On Thu, 7 Dec 2023, Henry Wang wrote: > > Fixed Virtual Platforms (FVPs) are complete simulations of an Arm > > system, including processor, memory and peripherals. These are set > > out in a "programmer's view", which gives programmers a

Re: [PATCH 5/5] automation: Add the arm64 FVP build and Dom0 smoke test jobs

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Henry Wang wrote: > Add a job in the build stage to export the TF-A, U-Boot and the > device tree for the FVP platform from the test artifact container. > > Add a FVP smoke test job in the test stage to do the same test as > the `qemu-smoke-dom0-arm64-gcc` job. > >

Re: [PATCH 4/5] automation: Add the script for the FVP smoke test

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Henry Wang wrote: > This commit adds the shell script for the FVP smoke test. Similarly > as the QEMU jobs, the shell script will firstly prepare the DomU > BusyBox image, use the ImageBuilder to arrange the binaries in memory > and generate the U-Boot script, then start the

Re: [PATCH 3/5] automation: Add the expect script with test case for FVP

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Henry Wang wrote: > To interact with the FVP (for example entering the U-Boot shell > and transferring the files by TFTP), we need to connect the > corresponding port by the telnet first. Use an expect script to > simplify the automation of the whole "interacting with FVP"

Re: [PATCH 2/5] automation: Add the Dockerfile to build TF-A and U-Boot for FVP

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Henry Wang wrote: > Unlike the emulators that currently being used in the CI pipelines, > the FVP must start at EL3. Therefore we need the firmware, i.e. the > TrustedFirmware-A (TF-A), for corresponding functionality. > > There is a dedicated board (vexpress_fvp) in U-Boot

Re: [PATCH 1/5] automation: Add a Dockerfile for running FVP_Base jobs

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Henry Wang wrote: > Fixed Virtual Platforms (FVPs) are complete simulations of an Arm > system, including processor, memory and peripherals. These are set > out in a "programmer's view", which gives programmers a comprehensive > model on which to build and test software. FVP

[linux-linus test] 184021: regressions - FAIL

2023-12-07 Thread osstest service owner
flight 184021 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184021/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 6 kernel-build fail REGR. vs. 183973 Tests which did

Re: [RFC PATCH v1 1/1] xen/Makefile: introduce ARCH_FIXED_CONFIG for randconfig

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Oleksii wrote: > On Thu, 2023-12-07 at 20:17 +, Andrew Cooper wrote: > > On 07/12/2023 5:03 pm, Oleksii Kurochko wrote: > > > ARCH_FIXED_CONFIG is required in the case of randconfig > > > and CI for configs that aren't ready or are not > > > supposed to be implemented for

Re: [PATCH 3/3] xen: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Simone Ballarin wrote: > From: Maria Celeste Cesario > > The xen sources contain violations of MISRA C:2012 Rule 14.4 whose > headline states: > "The controlling expression of an if statement and the controlling > expression of an iteration-statement shall have essentially

Re: [PATCH 2/3] xen/x86: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Simone Ballarin wrote: > From: Maria Celeste Cesario > > The xen sources contain violations of MISRA C:2012 Rule 14.4 whose > headline states: > "The controlling expression of an if statement and the controlling > expression of an iteration-statement shall have essentially

Re: [PATCH 1/3] AMD/IOMMU: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Simone Ballarin wrote: > From: Maria Celeste Cesario > > The xen sources contain violations of MISRA C:2012 Rule 14.4 whose > headline states: > "The controlling expression of an if statement and the controlling > expression of an iteration-statement shall have essentially

Re: [XEN PATCH v2 2/5] xen/acpi: address violations of MISRA C:2012 Rule 8.2

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH v2 4/5] x86/mm: address violations of MISRA C:2012 Rule 8.2

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH v2 5/5] AMD/IOMMU: address violations of MISRA C:2012 Rule 8.2

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Federico Serafini wrote: > Add missing parameter names to address violations of MISRA C:2012 > Rule 8.2. Remove trailing spaces and use C standard types to comply > with XEN coding style. No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano

Re: [XEN PATCH v2 3/5] x86/mm: remove compat_subarch_memory_op()

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Federico Serafini wrote: > Remove remove compat_subarch_memory_op() declaration: there is no > definition and there are no calls to such function in the XEN project. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 16.3

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Julien Grall wrote: > Hi Federico, > > On 07/12/2023 09:08, Federico Serafini wrote: > > MISRA C:2012 Rule 16.3 states that an unconditional break statement > > shall terminate every switch-clause. > > > > Update ECLAIR configuration to take into account: > > - continue,

[PATCH] docs/misra/rules.rst: add Rule 16.2

2023-12-07 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst index 2b570af0e0..7cb9544a96 100644 --- a/docs/misra/rules.rst +++ b/docs/misra/rules.rst @@ -469,6 +469,15 @@ maintainers if you want to suggest a change. - In addition to break, also other flow

[PATCH v2] docs/misra/rules.rst: add more rules

2023-12-07 Thread Stefano Stabellini
Add the rules accepted in the last three MISRA C working group meetings. Signed-off-by: Stefano Stabellini --- Changes in v2: - remove 17.1 for now, to be a separate patch - add a clarification comment for 17.7 --- docs/misra/rules.rst | 34 ++ 1 file changed, 34

Re: [PATCH] docs/misra/rules.rst: add more rules

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Jan Beulich wrote: > On 07.12.2023 03:42, Stefano Stabellini wrote: > > On Wed, 6 Dec 2023, Jan Beulich wrote: > >> On 06.12.2023 04:02, Stefano Stabellini wrote: > >>> --- a/docs/misra/rules.rst > >>> +++ b/docs/misra/rules.rst > >>> @@ -462,11 +462,23 @@ maintainers if you

Re: [PATCH] MAINTAINERS: Hand over the release manager role to Oleksii Kurochko

2023-12-07 Thread Henry Wang
Hi Julien, Oleksii, > On Dec 8, 2023, at 05:09, Oleksii wrote: > > Hi Julien and Henry, > > On Thu, 2023-12-07 at 18:46 +, Julien Grall wrote: >> Hi, >> >> On 07/12/2023 16:20, Henry Wang wrote: >>> I've finished the opportunity to do two releases (4.17 and 4.18) >>> and Oleksii Kurochko

xen | Failed pipeline for staging | bc4fe94a

2023-12-07 Thread GitLab
Pipeline #1099444749 has failed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: bc4fe94a ( https://gitlab.com/xen-project/xen/-/commit/bc4fe94a69d4dab103c37045d97e589ef75f8647 ) Commit Message:

[xen-unstable-smoke test] 184030: tolerable all pass - PUSHED

2023-12-07 Thread osstest service owner
flight 184030 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184030/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[ovmf test] 184028: all pass - PUSHED

2023-12-07 Thread osstest service owner
flight 184028 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184028/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf eccdab611c01aa40b6cefcfbcb4d23e54b4c0ec6 baseline version: ovmf

Re: [RFC PATCH] xen/arm: Add emulation of Debug Data Transfer Registers

2023-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Julien Grall wrote: > Hi Stefano, > > On 05/12/2023 23:21, Stefano Stabellini wrote: > > On Tue, 5 Dec 2023, Julien Grall wrote: > > > I agree that crashing a guest is bad, but is lying to the domain really > > > better? The consequence here is not that bad and hopefully it

[xen-unstable test] 184020: tolerable FAIL - PUSHED

2023-12-07 Thread osstest service owner
flight 184020 xen-unstable real [real] flight 184029 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/184020/ http://logs.test-lab.xenproject.org/osstest/logs/184029/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH] MAINTAINERS: Hand over the release manager role to Oleksii Kurochko

2023-12-07 Thread Oleksii
Hi Julien and Henry, On Thu, 2023-12-07 at 18:46 +, Julien Grall wrote: > Hi, > > On 07/12/2023 16:20, Henry Wang wrote: > > I've finished the opportunity to do two releases (4.17 and 4.18) > > and Oleksii Kurochko has volunteered to be the next release > > manager. > > Henry, thanks for

Re: [RFC PATCH v1 1/1] xen/Makefile: introduce ARCH_FIXED_CONFIG for randconfig

2023-12-07 Thread Oleksii
On Thu, 2023-12-07 at 20:17 +, Andrew Cooper wrote: > On 07/12/2023 5:03 pm, Oleksii Kurochko wrote: > > ARCH_FIXED_CONFIG is required in the case of randconfig > > and CI for configs that aren't ready or are not > > supposed to be implemented for specific architecture. > > These configs

Re: preparations for 4.17.3

2023-12-07 Thread Andrew Cooper
On 07/12/2023 7:06 am, Jan Beulich wrote: > All, > > the release is about due. Please point out backports you find missing > from the respective staging branch, but which you consider relevant. e3c409d59ac8 "x86/x2apic: introduce a mixed physical/cluster mode" There's now clear evidence on the

Re: [RFC PATCH v1 1/1] xen/Makefile: introduce ARCH_FIXED_CONFIG for randconfig

2023-12-07 Thread Andrew Cooper
On 07/12/2023 5:03 pm, Oleksii Kurochko wrote: > ARCH_FIXED_CONFIG is required in the case of randconfig > and CI for configs that aren't ready or are not > supposed to be implemented for specific architecture. > These configs should always be disabled to prevent randconfig > related tests from

[ovmf test] 184027: all pass - PUSHED

2023-12-07 Thread osstest service owner
flight 184027 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184027/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 238690a30d02d3f95f0355c88c35dc0e4232342a baseline version: ovmf

xen | Failed pipeline for staging | d2b7c442

2023-12-07 Thread GitLab
Pipeline #1099081266 has failed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: d2b7c442 ( https://gitlab.com/xen-project/xen/-/commit/d2b7c442b4a066bb670ee83e24800cabc415241d ) Commit Message:

Re: [PATCH] Mini-OS: don't use objcopy --dump-section

2023-12-07 Thread Andrew Cooper
On 06/12/2023 4:17 pm, Juergen Gross wrote: > The objcopy option "--dump-section" isn't supported in binutils before > version 2.25, which are still supported by the Xen build system. > > Avoid that by using the "-O binary" format together with > "--only-section". This requires to set the "alloc"

Re: [PATCH] MAINTAINERS: Hand over the release manager role to Oleksii Kurochko

2023-12-07 Thread Julien Grall
Hi, On 07/12/2023 16:20, Henry Wang wrote: I've finished the opportunity to do two releases (4.17 and 4.18) and Oleksii Kurochko has volunteered to be the next release manager. Henry, thanks for your time as release manager. Oleksii, thanks for stepping up and good luck for the role! Hand

[xen-unstable-smoke test] 184026: tolerable all pass - PUSHED

2023-12-07 Thread osstest service owner
flight 184026 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184026/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v2 07/39] xen/riscv: introduce arch-riscv/hvm/save.h

2023-12-07 Thread Shawn Anastasio
On 12/5/23 9:59 AM, Jan Beulich wrote: > On 24.11.2023 11:30, Oleksii Kurochko wrote: >> --- a/xen/include/public/hvm/save.h >> +++ b/xen/include/public/hvm/save.h >> @@ -91,6 +91,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct hvm_save_end); >> #include "../arch-arm/hvm/save.h" >> #elif

Re: [XEN PATCH] automation/eclair_analysis: file exclusion automation

2023-12-07 Thread Julien Grall
Hi Nicola, On 07/12/2023 17:53, Nicola Vetrini wrote: On 2023-12-07 18:08, Julien Grall wrote: On 07/12/2023 11:39, Nicola Vetrini wrote: +-doc_begin="libfdt is out of scope." +-file_tag+={out_of_scope,"^xen/include/xen/libfdt/.*$"} AFAICT, before this was marked as "adopted". But this is

Re: [XEN PATCH] automation/eclair_analysis: file exclusion automation

2023-12-07 Thread Nicola Vetrini
On 2023-12-07 18:08, Julien Grall wrote: On 07/12/2023 11:39, Nicola Vetrini wrote: +-doc_begin="libfdt is out of scope." +-file_tag+={out_of_scope,"^xen/include/xen/libfdt/.*$"} AFAICT, before this was marked as "adopted". But this is now moved to "out_of_scope". Can you explain why? It

xen | Failed pipeline for staging | 25147005

2023-12-07 Thread GitLab
Pipeline #1098955890 has failed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 25147005 ( https://gitlab.com/xen-project/xen/-/commit/25147005daf5a4e121b96496d6d208fac05fca35 ) Commit Message: xen/sched:

Re: [XEN PATCH] automation/eclair_analysis: file exclusion automation

2023-12-07 Thread Julien Grall
On 07/12/2023 11:39, Nicola Vetrini wrote: +-doc_begin="libfdt is out of scope." +-file_tag+={out_of_scope,"^xen/include/xen/libfdt/.*$"} AFAICT, before this was marked as "adopted". But this is now moved to "out_of_scope". Can you explain why? It also feels somewhat unrelated to the

[RFC PATCH v1 0/1] ARCH_FIXED_CONFIG introduction for randconfig

2023-12-07 Thread Oleksii Kurochko
Brief Overview: In the earlier patch series [1], it was introduced a comprehensive set of changes enabling a full Xen build for RISC-V. This early support primarily provides the minimum stubs required for the RISC-V Xen build. At this stage of development, many configs are deemed unnecessary and

[RFC PATCH v1 1/1] xen/Makefile: introduce ARCH_FIXED_CONFIG for randconfig

2023-12-07 Thread Oleksii Kurochko
ARCH_FIXED_CONFIG is required in the case of randconfig and CI for configs that aren't ready or are not supposed to be implemented for specific architecture. These configs should always be disabled to prevent randconfig related tests from failing. Signed-off-by: Oleksii Kurochko ---

Re: [RFC PATCH] xen/arm: Add emulation of Debug Data Transfer Registers

2023-12-07 Thread Julien Grall
Hi Stefano, On 05/12/2023 23:21, Stefano Stabellini wrote: On Tue, 5 Dec 2023, Julien Grall wrote: I agree that crashing a guest is bad, but is lying to the domain really better? The consequence here is not that bad and hopefully it would be fairly easy to find. But this is not always the

Re: [PATCH] xen/xenbus: client: fix kernel-doc comments

2023-12-07 Thread Randy Dunlap
On 12/7/23 01:27, Juergen Gross wrote: > On 06.12.23 19:17, Randy Dunlap wrote: >> Correct function kernel-doc notation to prevent warnings from >> scripts/kernel-doc. >> >> >> Signed-off-by: Randy Dunlap >> Cc: Juergen Gross >> Cc: Stefano Stabellini >> Cc: Oleksandr Tyshchenko >> Cc:

Re: [XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 16.3

2023-12-07 Thread Julien Grall
Hi again, On 07/12/2023 09:08, Federico Serafini wrote: MISRA C:2012 Rule 16.3 states that an unconditional break statement shall terminate every switch-clause. Update ECLAIR configuration to take into account: - continue, goto, return statements; - functions and macros that do not give the

Re: [XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 16.3

2023-12-07 Thread Julien Grall
Hi Federico, On 07/12/2023 09:08, Federico Serafini wrote: MISRA C:2012 Rule 16.3 states that an unconditional break statement shall terminate every switch-clause. Update ECLAIR configuration to take into account: - continue, goto, return statements; - functions and macros that do not give the

[PATCH] MAINTAINERS: Hand over the release manager role to Oleksii Kurochko

2023-12-07 Thread Henry Wang
I've finished the opportunity to do two releases (4.17 and 4.18) and Oleksii Kurochko has volunteered to be the next release manager. Hand over the role to him by changing the maintainership of the CHANGELOG.md. Signed-off-by: Henry Wang --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 17/39] xen/riscv: introduce asm/atomic.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > From: Bobby Eshleman > > Signed-off-by: Oleksii Kurochko > --- > Changes in V2: > - Change an author of commit. I got this header from Bobby's old repo. Not sure how to deal with that when there's not also an S-o-b. > --- /dev/null > +++

[xen-unstable-smoke test] 184025: tolerable all pass - PUSHED

2023-12-07 Thread osstest service owner
flight 184025 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184025/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v2 16/39] xen/riscv: introduce asm/smp.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/smp.h > @@ -0,0 +1,23 @@ > +#ifndef __ASM_RISCV_SMP_H > +#define __ASM_RISCV_SMP_H > + > +#ifndef __ASSEMBLY__ > +#include > +#include > +#endif If you want this to be possible to include from

Re: [PATCH v2 15/39] xen/riscv: introduce flushtlb.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko Again, with an SPDX header Acked-by: Jan Beulich

Re: [PATCH v2 14/39] xen/riscv: introduce bitops.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko So this looks to have been taken from Linux, which could do with saying (including which version or most recent commit). It may e.g. justify you using tab indentation here, albeit ... > --- /dev/null > +++

Re: [PATCH v5 11/11] xen/arm: create another /memory node for static shm

2023-12-07 Thread Michal Orzel
Hi Penny, On 06/12/2023 10:06, Penny Zheng wrote: > > > Static shared memory region shall be described both under /memory and > /reserved-memory. > > We introduce export_shm_memory_node() to create another /memory node to > contain the static shared memory ranges. > > Signed-off-by: Penny

xen | Failed pipeline for staging | 02d0a615

2023-12-07 Thread GitLab
Pipeline #1098841648 has failed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 02d0a615 ( https://gitlab.com/xen-project/xen/-/commit/02d0a615b32d03702f79807fa5e88f0cf78dde84 ) Commit Message: xen/arm:

Re: [PATCH v2 01/39] xen/riscv: disable unnecessary configs

2023-12-07 Thread Jan Beulich
On 07.12.2023 15:51, Oleksii wrote: > On Thu, 2023-12-07 at 15:11 +0100, Jan Beulich wrote: >> On 07.12.2023 14:44, Oleksii wrote: >>> On Thu, 2023-12-07 at 11:00 +0100, Jan Beulich wrote: On 07.12.2023 10:22, Oleksii wrote: > On Tue, 2023-12-05 at 16:38 +0100, Jan Beulich wrote: >>>

[libvirt test] 184019: tolerable all pass - PUSHED

2023-12-07 Thread osstest service owner
flight 184019 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/184019/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184003 test-armhf-armhf-libvirt-qcow2 15

Re: [PATCH v2 13/39] xen/riscv: introduce asm/system.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/system.h > @@ -0,0 +1,79 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef _ASM_RISCV_BARRIER_H > +#define _ASM_RISCV_BARRIER_H > + > +#include > + > +#ifndef __ASSEMBLY__ > + > +#define

Re: [PATCH v2 01/39] xen/riscv: disable unnecessary configs

2023-12-07 Thread Oleksii
On Thu, 2023-12-07 at 15:11 +0100, Jan Beulich wrote: > On 07.12.2023 14:44, Oleksii wrote: > > On Thu, 2023-12-07 at 11:00 +0100, Jan Beulich wrote: > > > On 07.12.2023 10:22, Oleksii wrote: > > > > On Tue, 2023-12-05 at 16:38 +0100, Jan Beulich wrote: > > > > > > On 24.11.2023 11:30, Oleksii

Re: [PATCH] CODING_STYLE: Add a section of the naming convention

2023-12-07 Thread Julien Grall
Hi George, On 06/12/2023 16:22, George Dunlap wrote: On Wed, Dec 6, 2023 at 11:22 AM Julien Grall wrote: Hi, On 06/12/2023 11:19, Andrew Cooper wrote: On 06/12/2023 8:41 am, Jan Beulich wrote: On 06.12.2023 03:21, George Dunlap wrote: On Tue, Dec 5, 2023 at 6:12 PM Julien Grall wrote:

Re: [PATCH] xen/arm: bootfdt: Check return code of device_tree_for_each_node()

2023-12-07 Thread Michal Orzel
On 07/12/2023 13:54, Julien Grall wrote: > > > Hi Michal, > > On 07/12/2023 12:39, Michal Orzel wrote: >> On 07/12/2023 13:20, Julien Grall wrote: >>> >>> >>> Hi Michal, >>> >>> On 07/12/2023 10:14, Michal Orzel wrote: As a result of not checking the return code of

Re: [PATCH v2 00/39] Enable build of full Xen for RISC-V

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > Bobby Eshleman (1): > xen/riscv: introduce asm/atomic.h > > Oleksii Kurochko (38): > xen/riscv: disable unnecessary configs > xen/riscv: use some asm-generic headers > xen/riscv:introduce asm/byteorder.h > xen/riscv: add public arch-riscv.h

Re: [PATCH v2 12/39] xen/riscv: introduce asm/setup.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko With at least SPDX header Acked-by: Jan Beulich

Re: [PATCH v2 11/39] xen/riscv: introduce asm/nospec.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/nospec.h > @@ -0,0 +1,25 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. */ > + > +#ifndef _ASM_RISCV_NOSPEC_H > +#define

Re: [PATCH v2 08/39] xen/riscv: introduce asm/cpufeature.h

2023-12-07 Thread Jan Beulich
On 07.12.2023 15:19, Jan Beulich wrote: > On 24.11.2023 11:30, Oleksii Kurochko wrote: >> Signed-off-by: Oleksii Kurochko > > Acked-by: Jan Beulich Actually - with an SPDX header added. I only now realize that I committed the earlier two patches without paying attention to this aspect. I'd

Re: [PATCH 2/3] xen/x86: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Simone Ballarin
On 07/12/23 15:15, Jan Beulich wrote: On 07.12.2023 14:53, Simone Ballarin wrote: On 07/12/23 11:54, Jan Beulich wrote: On 07.12.2023 10:48, Simone Ballarin wrote: --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -279,7 +279,7 @@ static int hpet_msi_write(struct hpet_event_channel *ch,

Re: [PATCH v2 10/39] xen/riscv: introduce asm/iommu.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/iommu.h > @@ -0,0 +1,7 @@ > +#ifndef __ASM_RISCV_IOMMU_H__ > +#define __ASM_RISCV_IOMMU_H__ > + > +struct arch_iommu { > +}; > + > +#endif /* __ASM_IOMMU_H__ */ Instead of adding this header, didn't we

Re: [PATCH v2 09/39] xen/riscv: introduce asm/guest_atomics.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/guest_atomics.h > @@ -0,0 +1,48 @@ > +#ifndef __ASM_RISCV_GUEST_ATOMICS_H > +#define __ASM_RISCV_GUEST_ATOMICS_H > + > +/* > + * TODO: implement guest atomics > + */ Along with this, wouldn't it be

Re: [PATCH v2 08/39] xen/riscv: introduce asm/cpufeature.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich Would have been nice ... > --- /dev/null > +++ b/xen/arch/riscv/include/asm/cpufeature.h > @@ -0,0 +1,22 @@ > +#ifndef __ASM_RISCV_CPUFEATURE_H > +#define __ASM_RISCV_CPUFEATURE_H > + >

Re: [PATCH 2/3] xen/x86: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Jan Beulich
On 07.12.2023 14:53, Simone Ballarin wrote: > On 07/12/23 11:54, Jan Beulich wrote: >> On 07.12.2023 10:48, Simone Ballarin wrote: >>> --- a/xen/arch/x86/hpet.c >>> +++ b/xen/arch/x86/hpet.c >>> @@ -279,7 +279,7 @@ static int hpet_msi_write(struct hpet_event_channel >>> *ch, struct msi_msg *msg)

Re: [XEN PATCH v2 3/3] xen/mm: add declaration for first_valid_mfn

2023-12-07 Thread Nicola Vetrini
On 2023-12-07 14:52, Julien Grall wrote: Hi, On 07/12/2023 11:11, Nicola Vetrini wrote: Such declaration is needed to comply with MISRA C Rule 8.4, because a compatible declaration is not visible in xen/common/page_alloc.c, where the variable is defined. That variable can't yet be static

Re: [PATCH v2 01/39] xen/riscv: disable unnecessary configs

2023-12-07 Thread Jan Beulich
On 07.12.2023 14:44, Oleksii wrote: > On Thu, 2023-12-07 at 11:00 +0100, Jan Beulich wrote: >> On 07.12.2023 10:22, Oleksii wrote: >>> On Tue, 2023-12-05 at 16:38 +0100, Jan Beulich wrote: > On 24.11.2023 11:30, Oleksii Kurochko wrote: >>> The patch also fixes the build script as conf util

[ovmf test] 184023: all pass - PUSHED

2023-12-07 Thread osstest service owner
flight 184023 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184023/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 553dfb0f57ae8a666938873cf836a33549568c87 baseline version: ovmf

[PATCH 4/5] automation: Add the script for the FVP smoke test

2023-12-07 Thread Henry Wang
This commit adds the shell script for the FVP smoke test. Similarly as the QEMU jobs, the shell script will firstly prepare the DomU BusyBox image, use the ImageBuilder to arrange the binaries in memory and generate the U-Boot script, then start the test. To provide the TFTP service for the FVP,

[PATCH 5/5] automation: Add the arm64 FVP build and Dom0 smoke test jobs

2023-12-07 Thread Henry Wang
Add a job in the build stage to export the TF-A, U-Boot and the device tree for the FVP platform from the test artifact container. Add a FVP smoke test job in the test stage to do the same test as the `qemu-smoke-dom0-arm64-gcc` job. Signed-off-by: Henry Wang --- Although it does not affect the

[PATCH 2/5] automation: Add the Dockerfile to build TF-A and U-Boot for FVP

2023-12-07 Thread Henry Wang
Unlike the emulators that currently being used in the CI pipelines, the FVP must start at EL3. Therefore we need the firmware, i.e. the TrustedFirmware-A (TF-A), for corresponding functionality. There is a dedicated board (vexpress_fvp) in U-Boot (serve as the BL33 of the TF-A) for the FVP

[PATCH 0/5] automation: Support running FVP Dom0 smoke test for Arm

2023-12-07 Thread Henry Wang
This series adds the support for running FVP Dom0 smoke test for Arm on the Arm64 GitLab CI runner. Detailed changes please refer to the commit message of each commit. An example test pipeline with these patches applied (with the docker registry changed to my own registry and unrelated job

[PATCH 3/5] automation: Add the expect script with test case for FVP

2023-12-07 Thread Henry Wang
To interact with the FVP (for example entering the U-Boot shell and transferring the files by TFTP), we need to connect the corresponding port by the telnet first. Use an expect script to simplify the automation of the whole "interacting with FVP" stuff. The expect script will firstly detect the

[PATCH 1/5] automation: Add a Dockerfile for running FVP_Base jobs

2023-12-07 Thread Henry Wang
Fixed Virtual Platforms (FVPs) are complete simulations of an Arm system, including processor, memory and peripherals. These are set out in a "programmer's view", which gives programmers a comprehensive model on which to build and test software. FVP can be configured to different setups by its

Re: [PATCH 2/3] xen/x86: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Simone Ballarin
On 07/12/23 11:54, Jan Beulich wrote: On 07.12.2023 10:48, Simone Ballarin wrote: --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -279,7 +279,7 @@ static int hpet_msi_write(struct hpet_event_channel *ch, struct msi_msg *msg) { ch->msi.msg = *msg; -if ( iommu_intremap ) +

Re: [XEN PATCH v2 3/3] xen/mm: add declaration for first_valid_mfn

2023-12-07 Thread Julien Grall
Hi, On 07/12/2023 11:11, Nicola Vetrini wrote: Such declaration is needed to comply with MISRA C Rule 8.4, because a compatible declaration is not visible in xen/common/page_alloc.c, where the variable is defined. That variable can't yet be static because of the lack of support from ARM and PPC

Re: [PATCH v2 01/39] xen/riscv: disable unnecessary configs

2023-12-07 Thread Oleksii
On Thu, 2023-12-07 at 11:00 +0100, Jan Beulich wrote: > On 07.12.2023 10:22, Oleksii wrote: > > On Tue, 2023-12-05 at 16:38 +0100, Jan Beulich wrote: > > > > On 24.11.2023 11:30, Oleksii Kurochko wrote: > > > > > > The patch also fixes the build script as conf util expects > > > > > > to have each

Re: [PATCH v2] tools/libs/evtchn: replace assert()s in stubdom with proper locking

2023-12-07 Thread Jason Andryuk
On Thu, Dec 7, 2023 at 1:26 AM Juergen Gross wrote: > > In tools/libs/evtchn/minios.c there are assert()s for the current > thread being the main thread when binding an event channel. > > As Mini-OS is supporting multiple threads, there is no real reason > why the binding shouldn't be allowed to

Re: [PATCH v2 0/5] tools/xenstored: remove some command line options

2023-12-07 Thread Julien Grall
On 07/12/2023 08:26, Juergen Gross wrote: On 21.11.23 12:40, Juergen Gross wrote: Remove some command line options which have no real use case. Changes in V2: - moved removal of "-N" into last patch of the series, as this is the    only option which seems to have a use case (OTOH using it

Re: [PATCH] xen/arm: bootfdt: Check return code of device_tree_for_each_node()

2023-12-07 Thread Julien Grall
On 07/12/2023 12:20, Julien Grall wrote: Hi Michal, On 07/12/2023 10:14, Michal Orzel wrote: As a result of not checking the return code of device_tree_for_each_node() in boot_fdt_info(), any error occured during early FDT parsing does not stop Xen from booting. This can result in an

Re: [PATCH v2 3/3] xen/sched: do some minor cleanup of sched_move_domain()

2023-12-07 Thread George Dunlap
On Mon, Dec 4, 2023 at 3:23 PM Juergen Gross wrote: > > Do some minor cleanups: > > - Move setting of old_domdata and old_units next to each other > - Drop incrementing unit_idx in the final loop of sched_move_domain() > as it isn't used afterwards > - Rename new_p to new_cpu and unit_p to

Re: ARM: MISRA C:2012 Rule 5.6

2023-12-07 Thread Julien Grall
On 07/12/2023 12:44, Jan Beulich wrote: On 07.12.2023 12:48, Federico Serafini wrote: On 07/12/23 12:43, Federico Serafini wrote: Hello everyone, Rule 5.6 states that a typedef name shall be a unique identifier. This is to avoid developer confusion. For ARM, the violations left [1] are

Re: [PATCH] xen/arm: bootfdt: Check return code of device_tree_for_each_node()

2023-12-07 Thread Julien Grall
Hi Michal, On 07/12/2023 12:39, Michal Orzel wrote: On 07/12/2023 13:20, Julien Grall wrote: Hi Michal, On 07/12/2023 10:14, Michal Orzel wrote: As a result of not checking the return code of device_tree_for_each_node() in boot_fdt_info(), any error occured during early FDT parsing does

  1   2   >