Re: [PATCH v6 14/15] xen/arm: add cache coloring support for Xen

2024-02-13 Thread Jan Beulich
On 13.02.2024 18:29, Carlo Nonato wrote: > On Tue, Feb 13, 2024 at 4:25 PM Jan Beulich wrote: >> On 29.01.2024 18:18, Carlo Nonato wrote: >>> @@ -218,9 +230,44 @@ static void xen_pt_enforce_wnx(void) >>> --- a/xen/common/llc-coloring.c >>> +++ b/xen/common/llc-coloring.c >>> @@ -29,6 +29,8 @@ stat

Re: [regression] Re: [PATCH v2 2/2] iommu/vt-d: switch to common RMRR checker

2024-02-13 Thread Jan Beulich
On 13.02.2024 23:37, Andrew Cooper wrote: > On 12/02/2024 2:38 pm, Jan Beulich wrote: >> On 07.02.2024 16:34, Roger Pau Monne wrote: >>> Use the newly introduced generic unity map checker. >>> >>> Also drop the message recommending the usage of iommu_inclusive_mapping: the >>> ranges would end up b

[ovmf test] 184663: all pass - PUSHED

2024-02-13 Thread osstest service owner
flight 184663 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184663/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5fd3078a2e08f607dc86a16c1b184b6e30a34a49 baseline version: ovmf a1c426e8440b55ee12d92

Re: [PATCH] tools/ocaml: Add missing vmtrace_buf_kb field

2024-02-13 Thread Jan Beulich
On 08.02.2024 10:13, Christian Lindig wrote: >> On 7 Feb 2024, at 22:04, Petr Beneš wrote: >> Add the missing `vmtrace_buf_kb` field to the OCaml bindings to match the >> vm.cfg configuration, correcting an oversight from its initial introduction. >> >> Signed-off-by: Petr Beneš > > Acked-by: Ch

[ovmf test] 184661: all pass - PUSHED

2024-02-13 Thread osstest service owner
flight 184661 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184661/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a1c426e8440b55ee12d92cefa7114fd6f7b599cb baseline version: ovmf 8801c75b4d77c2e6e06b3

[linux-linus test] 184659: tolerable FAIL - PUSHED

2024-02-13 Thread osstest service owner
flight 184659 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184659/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184654 test-amd64-amd64-xl-qemut-win7-amd64

[regression] Re: [PATCH v2 2/2] iommu/vt-d: switch to common RMRR checker

2024-02-13 Thread Andrew Cooper
On 12/02/2024 2:38 pm, Jan Beulich wrote: > On 07.02.2024 16:34, Roger Pau Monne wrote: >> Use the newly introduced generic unity map checker. >> >> Also drop the message recommending the usage of iommu_inclusive_mapping: the >> ranges would end up being mapped anyway even if some of the checks abo

[PATCH v2 3/3] docs/misra/rules.rst: add rule 14.4

2024-02-13 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini --- docs/misra/rules.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst index 931158b354..3e6f94d7bd 100644 --- a/docs/misra/rules.rst +++ b/docs/misra/rules.rst @@ -468,6 +468,15 @@ maintainers if you wan

[PATCH v2] docs/misra/rules.rst update

2024-02-13 Thread Stefano Stabellini
Hi all, Update docs/misra/rules.rst to reflect the MISRA C rules accepted in the last couple of months. Cheers, Stefano

[PATCH v2 2/3] docs/misra/rules.rst: add rule 5.5

2024-02-13 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini --- docs/misra/rules.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst index c185366966..931158b354 100644 --- a/docs/misra/rules.rst +++ b/docs/misra/rules.rst @@ -181,6 +181,12 @@ maintainers if you want t

[PATCH v2 1/3] docs/misra/rules.rst: add rule 16.6 and 20.12

2024-02-13 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini --- docs/misra/rules.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst index 182331089d..c185366966 100644 --- a/docs/misra/rules.rst +++ b/docs/misra/rules.rst @@ -478,6 +478,12 @@ maintainers if y

Re: [PATCH v1] docs/misra/rules.rst: catch up with accepted rules

2024-02-13 Thread Stefano Stabellini
On Tue, 13 Feb 2024, Jan Beulich wrote: > On 13.02.2024 00:18, Stefano Stabellini wrote: > > On Mon, 12 Feb 2024, Jan Beulich wrote: > >> On 10.02.2024 02:00, Stefano Stabellini wrote: > >>> Update docs/misra/rules.rst to reflect the MISRA C rules accepted in the > >>> last couple of months. > >>>

[xen-unstable test] 184656: tolerable FAIL

2024-02-13 Thread osstest service owner
flight 184656 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184656/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184653 test-amd64-amd64-xl-qemut-win7-amd64

Re: [PATCH v8 6/7] xen/arm: switch Arm to use asm-generic/device.h

2024-02-13 Thread Julien Grall
Hi Oleksii, On 09/02/2024 18:00, Oleksii Kurochko wrote: The following changes were done as a result of switching to asm-generic/device.h: * DEVICE_GIC was renamed to DEVICE_INTERRUPT_CONTROLLER according to definition of enum device_class in asm-generic/device.h. * acpi-related things i

Re: [PATCH v8 5/7] xen/asm-generic: introduce generic device.h

2024-02-13 Thread Julien Grall
Hi Oleksii, On 09/02/2024 18:00, Oleksii Kurochko wrote: diff --git a/xen/include/asm-generic/device.h b/xen/include/asm-generic/device.h new file mode 100644 index 00..6e56658271 --- /dev/null +++ b/xen/include/asm-generic/device.h @@ -0,0 +1,149 @@ +/* SPDX-License-Identifier: GPL-2.0-

Re: [PATCH v5 15/22] tools/libs/light: add backend type for 9pfs PV devices

2024-02-13 Thread Anthony PERARD
On Thu, Feb 08, 2024 at 05:55:39PM +0100, Juergen Gross wrote: > +struct libxl__aop9_state { > +libxl__spawn_state spawn; > +libxl__ao_device *aodev; > +libxl_device_p9 p9; > +uint32_t domid; > +void (*callback)(libxl__egc *, libxl__aop9_state *, int); This "callback" is never

Re: [PATCH v8 4/7] xen/asm-generic: ifdef inclusion of

2024-02-13 Thread Julien Grall
Hi Oleksii, On 09/02/2024 18:00, Oleksii Kurochko wrote: ifdefing inclusion of in allows to avoid generation of empty header for the case when !CONFIG_MEM_ACCESS. For Arm it was explicitly added inclusion of for p2m.c and traps.c because they require some functions from which aren't availa

Re: [PATCH v8 3/7] xen/asm-generic: introduce stub header monitor.h

2024-02-13 Thread Julien Grall
Hi, On 13/02/2024 17:40, Julien Grall wrote: Hi Oleksii, On 09/02/2024 18:00, Oleksii Kurochko wrote: The header is shared between several archs so it is moved to asm-generic. Switch partly Arm and PPC to asm-generic/monitor.h and only arch_monitor_get_capabilities() left in arch-specific/mon

Re: [PATCH v8 3/7] xen/asm-generic: introduce stub header monitor.h

2024-02-13 Thread Julien Grall
Hi Oleksii, On 09/02/2024 18:00, Oleksii Kurochko wrote: The header is shared between several archs so it is moved to asm-generic. Switch partly Arm and PPC to asm-generic/monitor.h and only arch_monitor_get_capabilities() left in arch-specific/monitor.h. Signed-off-by: Oleksii Kurochko Acked

Re: [PATCH v5 01/22] tools: add access macros for unaligned data

2024-02-13 Thread Anthony PERARD
On Thu, Feb 08, 2024 at 05:55:25PM +0100, Juergen Gross wrote: > Add the basic access macros for unaligned data to common-macros.h. > > Signed-off-by: Juergen Gross > Acked-by: Andrew Cooper Acked-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH v6 14/15] xen/arm: add cache coloring support for Xen

2024-02-13 Thread Carlo Nonato
Hi Jan, On Tue, Feb 13, 2024 at 4:25 PM Jan Beulich wrote: > > On 29.01.2024 18:18, Carlo Nonato wrote: > > @@ -218,9 +230,44 @@ static void xen_pt_enforce_wnx(void) > > flush_xen_tlb_local(); > > } > > > > +static void __init create_llc_coloring_mappings(void) > > +{ > > +lpae_t pte; >

Re: [PATCH v2] xen/lib: introduce generic find next bit operations

2024-02-13 Thread Julien Grall
Hi Oleksii, On 09/02/2024 17:58, Oleksii Kurochko wrote: find-next-bit.c is common for Arm64, PPC and RISCV64, so it is moved to xen/lib. PPC has been transitioned to generic functions from find-next-bit.c since it now shares the same implementation as the PPC-specific code. The MISRA exclude

Re: Return type of clean_and_invalidate_dcache_va_range

2024-02-13 Thread Julien Grall
Hi Jan, On 13/02/2024 07:13, Jan Beulich wrote: On 12.02.2024 19:38, Julien Grall wrote: An alternative would be to introduced arch_grant_cache_flush() and move the if/else logic there. Something like: diff --git a/xen/arch/arm/include/asm/page.h b/xen/arch/arm/include/asm/page.h index 69f817d

Re: [PATCH v13 01/14] vpci: use per-domain PCI lock to protect vpci structure

2024-02-13 Thread Stewart Hildebrand
On 2/13/24 04:05, Jan Beulich wrote: > On 13.02.2024 10:01, Roger Pau Monné wrote: >> On Tue, Feb 13, 2024 at 09:44:58AM +0100, Jan Beulich wrote: >>> On 13.02.2024 09:35, Roger Pau Monné wrote: On Fri, Feb 02, 2024 at 04:33:05PM -0500, Stewart Hildebrand wrote: > --- a/xen/include/xen/sch

Re: [PATCH v13 01/14] vpci: use per-domain PCI lock to protect vpci structure

2024-02-13 Thread Stewart Hildebrand
On 2/13/24 03:35, Roger Pau Monné wrote: > On Fri, Feb 02, 2024 at 04:33:05PM -0500, Stewart Hildebrand wrote: >> From: Oleksandr Andrushchenko >> >> Use the per-domain PCI read/write lock to protect the presence of the >> pci device vpci field. This lock can be used (and in a few cases is used >>

[xen-unstable-smoke test] 184658: tolerable all pass - PUSHED

2024-02-13 Thread osstest service owner
flight 184658 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184658/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v6 3/3] xen/livepatch: align functions to ensure minimal distance between entry points

2024-02-13 Thread Jan Beulich
On 07.02.2024 15:55, Roger Pau Monne wrote: > The minimal function size requirements for an x86 livepatch are either 5 bytes > (for jmp) or 9 bytes (for endbr + jmp), and always 4 bytes on Arm. Ensure > that > distance between functions entry points is always at least of the minimal > required si

[libvirt test] 184655: tolerable all pass - PUSHED

2024-02-13 Thread osstest service owner
flight 184655 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/184655/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184642 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [PATCH v3] tools/xentop: add option to display dom0 first

2024-02-13 Thread Anthony PERARD
On Wed, Feb 07, 2024 at 08:02:00PM +0100, zithro / Cyril Rébert wrote: > From: Cyril Rébert > > Add a command line option to xentop to be able to display dom0 first, on top > of the list. > This is unconditional, so sorting domains with the S option will also ignore > dom0. > > Signed-off-by:

Re: [PATCH v6 1/3] xen: introduce Kconfig function alignment option

2024-02-13 Thread Jan Beulich
On 07.02.2024 15:55, Roger Pau Monne wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -29,6 +29,7 @@ config X86 > select HAS_UBSAN > select HAS_VPCI if HVM > select NEEDS_LIBELF > + select FUNCTION_ALIGNMENT_16B With the insertion here as well as for Arm

Re: [PATCH v3 1/8] serial: fake IRQ-regs context in poll handlers

2024-02-13 Thread Jan Beulich
On 13.02.2024 16:11, Marek Marczykowski wrote: > On Tue, Feb 13, 2024 at 04:00:32PM +0100, Jan Beulich wrote: >> On 13.02.2024 15:53, Marek Marczykowski wrote: >>> On Tue, Feb 13, 2024 at 08:45:54AM +0100, Jan Beulich wrote: On 13.02.2024 04:43, Marek Marczykowski wrote: > On Mon, Feb 12,

Re: [PATCH v2] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB

2024-02-13 Thread Luca Fancellu
> On 13 Feb 2024, at 15:27, Jan Beulich wrote: > > On 13.02.2024 16:08, Petr Beneš wrote: >>> On Tue, Feb 13, 2024 at 4:02 PM Jan Beulich wrote: >>> >>> On 13.02.2024 15:56, Petr Beneš wrote: From: Petr Beneš It's located in libxl_domain_build_info, not libxl_domain_create_in

Re: [PATCH v2] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB

2024-02-13 Thread Jan Beulich
On 13.02.2024 16:08, Petr Beneš wrote: >> On Tue, Feb 13, 2024 at 4:02 PM Jan Beulich wrote: >> >> On 13.02.2024 15:56, Petr Beneš wrote: >>> From: Petr Beneš >>> >>> It's located in libxl_domain_build_info, not libxl_domain_create_info. >>> >>> Signed-off-by: Petr Beneš >>> Acked-by: Anthony PE

Re: [PATCH v6 14/15] xen/arm: add cache coloring support for Xen

2024-02-13 Thread Jan Beulich
On 29.01.2024 18:18, Carlo Nonato wrote: > @@ -218,9 +230,44 @@ static void xen_pt_enforce_wnx(void) > flush_xen_tlb_local(); > } > > +static void __init create_llc_coloring_mappings(void) > +{ > +lpae_t pte; > +unsigned int i; > +struct bootmodule *xen_bootmodule = > boot_modu

Re: [PATCH v3 1/8] serial: fake IRQ-regs context in poll handlers

2024-02-13 Thread Marek Marczykowski
On Tue, Feb 13, 2024 at 04:00:32PM +0100, Jan Beulich wrote: > On 13.02.2024 15:53, Marek Marczykowski wrote: > > On Tue, Feb 13, 2024 at 08:45:54AM +0100, Jan Beulich wrote: > >> On 13.02.2024 04:43, Marek Marczykowski wrote: > >>> On Mon, Feb 12, 2024 at 10:04:38AM +0100, Jan Beulich wrote: > >>>

Re: [PATCH v2] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB

2024-02-13 Thread Petr Beneš
> On Tue, Feb 13, 2024 at 4:02 PM Jan Beulich wrote: > > On 13.02.2024 15:56, Petr Beneš wrote: > > From: Petr Beneš > > > > It's located in libxl_domain_build_info, not libxl_domain_create_info. > > > > Signed-off-by: Petr Beneš > > Acked-by: Anthony PERARD > > Any reason you didn't also add t

Re: [PATCH v2] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB

2024-02-13 Thread Jan Beulich
On 13.02.2024 15:56, Petr Beneš wrote: > From: Petr Beneš > > It's located in libxl_domain_build_info, not libxl_domain_create_info. > > Signed-off-by: Petr Beneš > Acked-by: Anthony PERARD Any reason you didn't also add the Fixes: tag that Anthony suggested to put there (for me to recognize

Re: [PATCH v3 1/8] serial: fake IRQ-regs context in poll handlers

2024-02-13 Thread Jan Beulich
On 13.02.2024 15:53, Marek Marczykowski wrote: > On Tue, Feb 13, 2024 at 08:45:54AM +0100, Jan Beulich wrote: >> On 13.02.2024 04:43, Marek Marczykowski wrote: >>> On Mon, Feb 12, 2024 at 10:04:38AM +0100, Jan Beulich wrote: On 08.02.2024 23:00, Julien Grall wrote: > On 05/02/2024 13:27, J

[PATCH v2] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB

2024-02-13 Thread Petr Beneš
From: Petr Beneš It's located in libxl_domain_build_info, not libxl_domain_create_info. Signed-off-by: Petr Beneš Acked-by: Anthony PERARD --- tools/include/libxl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/include/libxl.h b/tools/include/libxl.h index f1652b16

Re: [PATCH v3 1/8] serial: fake IRQ-regs context in poll handlers

2024-02-13 Thread Marek Marczykowski
On Tue, Feb 13, 2024 at 08:45:54AM +0100, Jan Beulich wrote: > On 13.02.2024 04:43, Marek Marczykowski wrote: > > On Mon, Feb 12, 2024 at 10:04:38AM +0100, Jan Beulich wrote: > >> On 08.02.2024 23:00, Julien Grall wrote: > >>> On 05/02/2024 13:27, Jan Beulich wrote: > In preparation of droppin

Xen Summit 2024 - Registrations now open!

2024-02-13 Thread Kelly Choi
Hello Xen Community, Our Xen Summit 2024 registrations are now open! Secure your early bird rates today. https://events.linuxfoundation.org/xen-project-summit/register/ If you're an academic studying for a relevant degree, entry is free! (subject to a social media or blog post after the event) P

Re: [PATCH v4 26/30] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-02-13 Thread Jan Beulich
On 05.02.2024 16:32, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes in V4: > - update an argument name of PFN_ORDERN macros. > - drop pad at the end of 'struct page_info'. > - Change message -> subject in "Changes in V3" > - delete duplicated macros from riscv/mm.h >

[linux-linus test] 184654: tolerable FAIL - PUSHED

2024-02-13 Thread osstest service owner
flight 184654 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184654/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184652 test-amd64-amd64-xl-qemut-win7-amd64

Re: [PATCH v4 25/30] xen/riscv: add minimal stuff to processor.h to build full Xen

2024-02-13 Thread Jan Beulich
On 05.02.2024 16:32, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/Kconfig > +++ b/xen/arch/riscv/Kconfig > @@ -45,6 +45,13 @@ config RISCV_ISA_C > > If unsure, say Y. > > +config TOOLCHAIN_HAS_ZIHINTPAUSE > + bool > + default y Shorter as "def_bool y". > + depends on !64

[xen-unstable-smoke test] 184657: tolerable all pass - PUSHED

2024-02-13 Thread osstest service owner
flight 184657 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184657/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v4 22/30] xen/riscv: define an address of frame table

2024-02-13 Thread Jan Beulich
On 05.02.2024 16:32, Oleksii Kurochko wrote: > Also, the patch adds some helpful macros that assist in avoiding > the redefinition of memory layout for each MMU mode. > > Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich

[PATCH net 1/7] net: fill in MODULE_DESCRIPTION()s for xen-netback

2024-02-13 Thread Breno Leitao
W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). Add descriptions to the Xen backend network module. Signed-off-by: Breno Leitao --- drivers/net/xen-netback/netback.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-ne

Re: [PATCH V2] libxl: Add "grant_usage" parameter for virtio disk devices

2024-02-13 Thread Anthony PERARD
On Tue, Feb 06, 2024 at 02:38:14PM +0200, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Allow administrators to control whether Xen grant mappings for > the virtio disk devices should be used. By default (when new > parameter is not specified), the existing behavior is retained > (

Re: [PATCH] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB

2024-02-13 Thread Anthony PERARD
On Tue, Feb 06, 2024 at 11:23:45PM +, Petr Beneš wrote: > From: Petr Beneš > > It's located in libxl_domain_build_info, not libxl_domain_create_info. Hi Petr, You need a "Signed-off-by:" tag when sending patches. We could probably add also a fixes tag Fixes: 45ba9a7d7688 ("tools/[lib]xl: A

Re: [PATCH v2 2/3] libxl: Allow Phy backend for CDROM devices

2024-02-13 Thread Anthony PERARD
On Thu, Feb 01, 2024 at 04:40:03PM -0500, Jason Andryuk wrote: > A Linux HVM domain ignores PV block devices with type cdrom. The > Windows PV drivers also ignore device-type != "disk". Therefore QEMU's > emulated CD-ROM support is used. This allows ejection and other CD-ROM > features to work.

Re: [PATCH v2 1/3] libxl: Create empty file for Phy cdrom

2024-02-13 Thread Anthony PERARD
On Thu, Feb 01, 2024 at 04:40:02PM -0500, Jason Andryuk wrote: > With a device model stubdom, dom0 exports a PV disk to the stubdom. > Inside the stubdom, QEMU emulates a cdrom to the guest with a > host_device pointing at the PV frontend (/dev/xvdc) > > An empty cdrom drive causes problems bootin

Re: [PATCH v2 0/3] libxl: Stubdom cd-rom changing support

2024-02-13 Thread Anthony PERARD
On Thu, Feb 01, 2024 at 04:40:01PM -0500, Jason Andryuk wrote: > Linux locks the cd-rom by default? That means the QMP eject commands > fail, but then Linux unlocks. Re-running a second time works. Windows > doesn't do that. Yes, looks like it. It would be possible to have libxl retry automatic

Re: [PATCH v4 14/30] xen/riscv: introduce atomic.h

2024-02-13 Thread Jan Beulich
On 05.02.2024 16:32, Oleksii Kurochko wrote: > From: Bobby Eshleman > > Additionally, this patch introduces macros in fence.h, > which are utilized in atomic.h. These are used in an earlier patch already, so either you want to re-order the series, or you want to move that introduction ahead. >

Re: [PATCH net 1/7] net: fill in MODULE_DESCRIPTION()s for xen-netback

2024-02-13 Thread Paul Durrant
On 13/02/2024 11:21, Breno Leitao wrote: W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). Add descriptions to the Xen backend network module. Signed-off-by: Breno Leitao --- drivers/net/xen-netback/netback.c | 1 + 1 file changed, 1 insertion(+) Acked-by: Paul Durran

Re: [PATCH v2 3/3] libxl: Enable stubdom cdrom changing

2024-02-13 Thread Anthony PERARD
On Thu, Feb 01, 2024 at 04:40:04PM -0500, Jason Andryuk wrote: > To change the cd-rom medium, libxl will: > - QMP eject the medium from QEMU > - block-detach the old PV disk > - block-attach the new PV disk > - QMP change the medium to the new PV disk by fdset-id > > The QMP code is reused, an

[XEN PATCH v5] xen/arm: ffa: reclaim shared memory on guest destroy

2024-02-13 Thread Jens Wiklander
When an FF-A enabled guest is destroyed it may leave behind memory shared with SPs. This memory must be reclaimed before it's reused or an SP may make changes to memory used by a new unrelated guest. So when the domain is teared down add FF-A requests to reclaim all remaining shared memory. SPs in

Re: [PATCH v4 13/30] xen/riscv: introduce io.h

2024-02-13 Thread Jan Beulich
On 05.02.2024 16:32, Oleksii Kurochko wrote: > The header taken form Linux 6.4.0-rc1 and is based on > arch/riscv/include/asm/mmio.h. > > Addionally, to the header was added definions of ioremap_*(). > > Signed-off-by: Oleksii Kurochko > --- > Changes in V4: > - delete inner parentheses in macr

Re: [PATCH v4 12/30] xen/riscv: introduce cmpxchg.h

2024-02-13 Thread Jan Beulich
On 05.02.2024 16:32, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/cmpxchg.h > @@ -0,0 +1,237 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* Copyright (C) 2014 Regents of the University of California */ > + > +#ifndef _ASM_RISCV_CMPXCHG_H > +#define _ASM_RISCV_

Re: [XEN PATCH v2] docs/misra: add asm-offset.c to exclude-list

2024-02-13 Thread Julien Grall
Hi Nicola, On 09/02/2024 13:20, Nicola Vetrini wrote: On 2024-02-09 13:17, Julien Grall wrote: Hi Jan, On 09/02/2024 11:46, Jan Beulich wrote: On 09.02.2024 10:40, Julien Grall wrote: Replying on the v2 as well. And answering here despite the respective question was raised on the v1 thread

Re: [PATCH v4 09/30] xen/riscv: introduce bitops.h

2024-02-13 Thread Jan Beulich
On 05.02.2024 16:32, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/include/asm/config.h > +++ b/xen/arch/riscv/include/asm/config.h > @@ -50,6 +50,8 @@ > # error "Unsupported RISCV variant" > #endif > > +#define BITS_PER_BYTE 8 > + > #define BYTES_PER_LONG (1 << LONG_BYTEORDER) > #define BIT

Re: [PATCH] xen/events: close evtchn after mapping cleanup

2024-02-13 Thread Jürgen Groß
On 24.01.24 17:31, Maximilian Heyne wrote: shutdown_pirq and startup_pirq are not taking the irq_mapping_update_lock because they can't due to lock inversion. Both are called with the irq_desc->lock being taking. The lock order, however, is first irq_mapping_update_lock and then irq_desc->lock.

Re: [PATCH v13 01/14] vpci: use per-domain PCI lock to protect vpci structure

2024-02-13 Thread Jan Beulich
On 13.02.2024 10:01, Roger Pau Monné wrote: > On Tue, Feb 13, 2024 at 09:44:58AM +0100, Jan Beulich wrote: >> On 13.02.2024 09:35, Roger Pau Monné wrote: >>> On Fri, Feb 02, 2024 at 04:33:05PM -0500, Stewart Hildebrand wrote: --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h >>>

Re: [PATCH v13 01/14] vpci: use per-domain PCI lock to protect vpci structure

2024-02-13 Thread Roger Pau Monné
On Tue, Feb 13, 2024 at 09:44:58AM +0100, Jan Beulich wrote: > On 13.02.2024 09:35, Roger Pau Monné wrote: > > On Fri, Feb 02, 2024 at 04:33:05PM -0500, Stewart Hildebrand wrote: > >> --- a/xen/include/xen/sched.h > >> +++ b/xen/include/xen/sched.h > >> @@ -462,7 +462,8 @@ struct domain > >> #ifde

Re: [PATCH v13 01/14] vpci: use per-domain PCI lock to protect vpci structure

2024-02-13 Thread Jan Beulich
On 13.02.2024 09:35, Roger Pau Monné wrote: > On Fri, Feb 02, 2024 at 04:33:05PM -0500, Stewart Hildebrand wrote: >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -462,7 +462,8 @@ struct domain >> #ifdef CONFIG_HAS_PCI >> struct list_head pdev_list; >> /* >> -

Re: [PATCH v13 01/14] vpci: use per-domain PCI lock to protect vpci structure

2024-02-13 Thread Roger Pau Monné
On Fri, Feb 02, 2024 at 04:33:05PM -0500, Stewart Hildebrand wrote: > From: Oleksandr Andrushchenko > > Use the per-domain PCI read/write lock to protect the presence of the > pci device vpci field. This lock can be used (and in a few cases is used > right away) so that vpci removal can be perfor

Re: [PATCH v2 1/2] iommu/x86: introduce a generic IVMD/RMRR range validity helper

2024-02-13 Thread Roger Pau Monné
On Mon, Feb 12, 2024 at 03:34:59PM +0100, Jan Beulich wrote: > On 07.02.2024 16:34, Roger Pau Monne wrote: > > IVMD and RMRR ranges are functionally equivalent, and as so could use the > > same > > validity checker. > > > > Move the IVMD to x86 common IOMMU code and adjust the function to take a