[xen-unstable test] 187939: tolerable FAIL - PUSHED

2024-10-02 Thread osstest service owner
flight 187939 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/187939/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 187930 test-amd64-amd64-xl-qemuu-ws16-amd64

Re: [PATCH v7 0/2] x86/boot: Reduce assembly code

2024-10-02 Thread Marek Marczykowski-Górecki
On Wed, Oct 02, 2024 at 04:27:19PM +0100, Frediano Ziglio wrote: > On Wed, Oct 2, 2024 at 3:04 PM Marek Marczykowski-Górecki > wrote: > > > > On Tue, Oct 01, 2024 at 11:22:37AM +0100, Frediano Ziglio wrote: > > > This series came from part of the work of removing duplications between > > > boot co

Re: [XEN PATCH v2 3/3] automation/eclair: tag Rule 13.6 as clean

2024-10-02 Thread Stefano Stabellini
On Mon, 30 Sep 2024, Federico Serafini wrote: > Update ECLAIR configuration to consider Rule 13.6 as clean: > new violations of this rule will cause a failure of the CI pipeline. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini > --- > automation/eclair_analysis/ECLAIR/ta

Re: [XEN PATCH v2 1/3] EFI: address a violation of MISRA C Rule 13.6

2024-10-02 Thread Stefano Stabellini
On Mon, 30 Sep 2024, Federico Serafini wrote: > guest_handle_ok()'s expansion contains a sizeof() involving its > first argument which is guest_handle_cast(). > The expansion of the latter, in turn, contains a variable > initialization. > > Since MISRA considers the initialization (even of a local

Re: [PATCH 2/2] automation: add a smoke test for xen.efi on X86

2024-10-02 Thread Stefano Stabellini
On Thu, 3 Oct 2024, Marek Marczykowski-Górecki wrote: > On Wed, Oct 02, 2024 at 04:30:25PM -0700, Stefano Stabellini wrote: > > On Thu, 3 Oct 2024, Marek Marczykowski-Górecki wrote: > > > The problem is this doesn't work. The group-level variable overrides the > > > one in yaml. See the commit mess

Re: [PATCH 2/2] automation: add a smoke test for xen.efi on X86

2024-10-02 Thread Marek Marczykowski-Górecki
On Wed, Oct 02, 2024 at 04:30:25PM -0700, Stefano Stabellini wrote: > On Thu, 3 Oct 2024, Marek Marczykowski-Górecki wrote: > > The problem is this doesn't work. The group-level variable overrides the > > one in yaml. See the commit message and the link there... > > Now I understand the problem, w

[ovmf test] 187942: all pass - PUSHED

2024-10-02 Thread osstest service owner
flight 187942 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/187942/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e73ec569429ba72fbb6829518d6c192b4cd3346f baseline version: ovmf cac73c45c4a9eaf816132

Re: [PATCH 2/2] automation: add a smoke test for xen.efi on X86

2024-10-02 Thread Stefano Stabellini
On Thu, 3 Oct 2024, Marek Marczykowski-Górecki wrote: > On Wed, Oct 02, 2024 at 03:22:59PM -0700, Stefano Stabellini wrote: > > I forgot to reply to one important part below > > > > > > On Wed, 2 Oct 2024, Stefano Stabellini wrote: > > > On Wed, 2 Oct 2024, Marek Marczykowski-Górecki wrote: > > >

[PATCH] x86/boot: Further simplify CR4 handling in dom0_construct_pv()

2024-10-02 Thread Andrew Cooper
The logic would be more robust disabling SMAP based on its precense in CR4, rather than SMAP's accociation with a synthetic feature. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné v2: * Strip LASS changes back out. --- xen/arch/x86/pv/dom0_build.c | 9 + 1 file

Re: [PATCH 2/2] automation: add a smoke test for xen.efi on X86

2024-10-02 Thread Andrew Cooper
On 02/10/2024 11:55 pm, Marek Marczykowski-Górecki wrote: > On Wed, Oct 02, 2024 at 03:22:59PM -0700, Stefano Stabellini wrote: >> I forgot to reply to one important part below >> >> >> On Wed, 2 Oct 2024, Stefano Stabellini wrote: >>> On Wed, 2 Oct 2024, Marek Marczykowski-Górecki wrote: Chec

Re: [PATCH 2/2] automation: add a smoke test for xen.efi on X86

2024-10-02 Thread Marek Marczykowski-Górecki
On Wed, Oct 02, 2024 at 03:22:59PM -0700, Stefano Stabellini wrote: > I forgot to reply to one important part below > > > On Wed, 2 Oct 2024, Stefano Stabellini wrote: > > On Wed, 2 Oct 2024, Marek Marczykowski-Górecki wrote: > > > Check if xen.efi is bootable with an XTF dom0. > > > > > > The T

[PATCH] stubdom: Fix newlib build with GCC-14

2024-10-02 Thread Andrew Cooper
Based on a fix from OpenSUSE, but adjusted to be Clang-compatible too. Pass -Wno-implicit-function-declaration library-wide rather than using local GCC pragmas. Fix of copy_past_newline() to avoid triggering -Wstrict-prototypes. Link: https://build.opensuse.org/request/show/1178775 Signed-off-by

[xen-unstable-smoke test] 187940: tolerable all pass - PUSHED

2024-10-02 Thread osstest service owner
flight 187940 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/187940/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH 2/2] automation: add a smoke test for xen.efi on X86

2024-10-02 Thread Stefano Stabellini
I forgot to reply to one important part below On Wed, 2 Oct 2024, Stefano Stabellini wrote: > On Wed, 2 Oct 2024, Marek Marczykowski-Górecki wrote: > > Check if xen.efi is bootable with an XTF dom0. > > > > The TEST_TIMEOUT is set in the script to override project-global value. > > Setting it in

Re: [PATCH 2/2] automation: add a smoke test for xen.efi on X86

2024-10-02 Thread Stefano Stabellini
On Wed, 2 Oct 2024, Marek Marczykowski-Górecki wrote: > Check if xen.efi is bootable with an XTF dom0. > > The TEST_TIMEOUT is set in the script to override project-global value. > Setting it in the gitlab yaml file doesn't work, as it's too low > priority > (https://docs.gitlab.com/ee/ci/variable

Re: [PATCH 1/2] automation: preserve built xen.efi

2024-10-02 Thread Stefano Stabellini
On Wed, 2 Oct 2024, Marek Marczykowski-Górecki wrote: > On Wed, Oct 02, 2024 at 09:42:13PM +0100, Andrew Cooper wrote: > > On 02/10/2024 1:42 pm, Marek Marczykowski-Górecki wrote: > > > It will be useful for further tests. > > > > > > Signed-off-by: Marek Marczykowski-Górecki > > > > > > --- > >

Re: [RFC-for-4.20 v2 1/1] x86/hvm: Introduce Xen-wide ASID allocator

2024-10-02 Thread Andrew Cooper
On 02/10/2024 12:02 pm, Jan Beulich wrote: > On 13.08.2024 21:01, Vaishali Thakkar wrote: >> +static DEFINE_SPINLOCK(hvm_asid_lock); >> + >> /* >> - * ASIDs partition the physical TLB. In the current implementation ASIDs >> are >> - * introduced to reduce the number of TLB flushes. Each time th

[qemu-mainline test] 187938: regressions - FAIL

2024-10-02 Thread osstest service owner
flight 187938 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/187938/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail REGR. vs. 187720 Tests whi

Re: [PATCH v2 4/5] x86/xen: Avoid relocatable quantities in Xen ELF notes

2024-10-02 Thread Jason Andryuk
On 2024-09-30 03:15, Ard Biesheuvel wrote: From: Ard Biesheuvel Xen puts virtual and physical addresses into ELF notes that are treated by the linker as relocatable by default. Doing so is not only pointless, given that the ELF notes are only intended for consumption by Xen before the kernel bo

Re: [PATCH 2/2] automation: add a smoke test for xen.efi on X86

2024-10-02 Thread Andrew Cooper
On 02/10/2024 1:42 pm, Marek Marczykowski-Górecki wrote: > Check if xen.efi is bootable with an XTF dom0. > > The TEST_TIMEOUT is set in the script to override project-global value. > Setting it in the gitlab yaml file doesn't work, as it's too low > priority > (https://docs.gitlab.com/ee/ci/variab

Re: [PATCH 1/2] automation: preserve built xen.efi

2024-10-02 Thread Marek Marczykowski-Górecki
On Wed, Oct 02, 2024 at 09:42:13PM +0100, Andrew Cooper wrote: > On 02/10/2024 1:42 pm, Marek Marczykowski-Górecki wrote: > > It will be useful for further tests. > > > > Signed-off-by: Marek Marczykowski-Górecki > > --- > > automation/scripts/build | 7 ++- > > 1 file changed, 6 insertions(+

Re: [PATCH 1/2] automation: preserve built xen.efi

2024-10-02 Thread Andrew Cooper
On 02/10/2024 1:42 pm, Marek Marczykowski-Górecki wrote: > It will be useful for further tests. > > Signed-off-by: Marek Marczykowski-Górecki > --- > automation/scripts/build | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/automation/scripts/build b/automation/scrip

[PATCH] x86/boot: Convert remaining uses of the legacy ALIGN

2024-10-02 Thread Andrew Cooper
There are only two remaining standalone uses the legacy ALIGN macro. Drop these by switching the .incbin's over to using FUNC()/END() which has alignment handled internally. While the incbin's aren't technically one single function, they're as good as one single function. Finally, expand ALIGN i

Re: [RFC PATCH 25/28] x86: Use PIE codegen for the core kernel

2024-10-02 Thread Linus Torvalds
On Wed, 2 Oct 2024 at 08:31, Ard Biesheuvel wrote: > > I guess you are referring to the use of a GOT? That is a valid > concern, but it does not apply here. With hidden visibility and > compiler command line options like -mdirect-access-extern, all emitted > symbol references are direct. I absolu

[PATCH 0/2] drm: Treewide plane/crtc legacy state sweeping

2024-10-02 Thread Ville Syrjala
From: Ville Syrjälä An attempt to hide the drm_plane/crtc legacy state better. This also highlights the fact that a lot of supposedly atomic drivers are poking around in the legacy crtc state, which is rather questionable. For planes we did force the legacy state to NULL already to force drivers

[PATCH 2/2] drm: Move crtc->{x,y,mode,enabled} to legacy sub-structure

2024-10-02 Thread Ville Syrjala
From: Ville Syrjälä Atomic drivers shouldn't be using the legacy state stored directly under drm_crtc. Move that junk into a 'legacy' sub structure to highlight the offenders, of which there are quite a few unfortunately. I'm hoping we could get all these fixed and then declare the legacy state

Re: [PATCH 0/3] Switch flat driver to use phys dst for ext ints

2024-10-02 Thread Andrew Cooper
On 02/10/2024 4:17 pm, Matthew Barnes wrote: > This patch series switches the apic_default APIC driver from using > logical flat destination mode for external interrupts, to using > physical destination mode for external interrupts. > > This is followed up by two non-functional cleanup commits. > >

[libvirt test] 187932: tolerable all pass - PUSHED

2024-10-02 Thread osstest service owner
flight 187932 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/187932/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 187917 test-amd64-amd64-libvirt 15 migrate-s

Re: [PATCH v2 2/7] tests/x86: Introduce a userspace test harness for x86_decode_lite()

2024-10-02 Thread Andrew Cooper
On 02/10/2024 4:27 pm, Andrew Cooper wrote: > Despite claiming full APX support in the 2.43 release, binutils trunk doesn't > tolerate JMPABS at all. Clang-IAS like it but only when encoded as an > immediate, despite the fact the operand should be a moffset and encoded > without a $ prefix. https

[PATCH v2 7/7] x86/spec-ctrl: Introduce and use DO_COND_BHB_SEQ

2024-10-02 Thread Andrew Cooper
Now that alternatives can fix up call displacements even when they're not the first instruction of the replacement, move the SCF_entry_bhb conditional inside the replacement block. This removes a conditional branch from the fastpaths of BHI-unaffected hardware. Signed-off-by: Andrew Cooper --- C

[PATCH v2 5/7] x86/alternative: Replace a continue with a goto

2024-10-02 Thread Andrew Cooper
A subsequent patch is going to insert a loop, which interferes with the continue in the devirtualisation logic. Replace it with a goto, and a paragraph explaining why we intentionally avoid setting a->priv = 1. No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Ja

[PATCH v2 3/7] x86/alternative: Walk all replacements during self tests

2024-10-02 Thread Andrew Cooper
When self tests are active, walk all alternative replacements with x86_decode_lite(). This checks that we can decode all instructions, and also lets us check that disp8's don't leave the replacement block as such a case will definitely malfunction. Signed-off-by: Andrew Cooper Reviewed-by: Jan B

Re: [PATCH v7 0/2] x86/boot: Reduce assembly code

2024-10-02 Thread Frediano Ziglio
On Wed, Oct 2, 2024 at 3:04 PM Marek Marczykowski-Górecki wrote: > > On Tue, Oct 01, 2024 at 11:22:37AM +0100, Frediano Ziglio wrote: > > This series came from part of the work of removing duplications between > > boot code and rewriting part of code from assembly to C. > > Rewrites EFI code in pu

[PATCH v2 0/7] x86/alternatives: Adjust all insn-relative fields

2024-10-02 Thread Andrew Cooper
Alternatives have had a reasonably severe restriction since their introduction. This has been the source of several bugs, and several inefficiencies particularly in the speculative safety paths. v2: Most work is in patch 1 and the new patch 2 (userspace harness). Other patches with minor or

[PATCH v2 6/7] x86/alternative: Relocate all insn-relative fields

2024-10-02 Thread Andrew Cooper
Right now, relocation of displacements is restricted to finding 0xe8/e9 as the first byte of the replacement, but this is overly restrictive. Use x86_decode_lite() to find and adjust all insn-relative fields. As with disp8's not leaving the replacemnet block, some disp32's don't either. e.g. the

[PATCH v2 4/7] x86/alternative: Indent the relocation logic

2024-10-02 Thread Andrew Cooper
... to make subsequent patches legible. No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné --- xen/arch/x86/alternative.c | 124 +++-- 1 file changed, 63 insertions(+), 61 deletions(-) diff --git a

[PATCH v2 2/7] tests/x86: Introduce a userspace test harness for x86_decode_lite()

2024-10-02 Thread Andrew Cooper
All the interesting behaviour is in insns.S. There are 4 interesting cases; "not an instruction we tolerate", or one we do tolerate, split by no relation, disp8 or disp32. The DECL()/END() macros start and terminate the tests_*[] arrays used by C. Between DECL()/END(), a macro named _ adds an en

[PATCH v2 1/7] x86: Introduce x86_decode_lite()

2024-10-02 Thread Andrew Cooper
In order to relocate all IP-relative fields in an alternative replacement block, we need to decode the instructions enough to obtain their length and any relative fields. Full x86_decode() is far too heavyweight, so introduce a minimal form which can make several simplifying assumptions. This a m

Re: [RFC PATCH 25/28] x86: Use PIE codegen for the core kernel

2024-10-02 Thread Ard Biesheuvel
Hi Peter, Thanks for taking a look. On Tue, 1 Oct 2024 at 23:13, H. Peter Anvin wrote: > > On 9/25/24 08:01, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > > > As an intermediate step towards enabling PIE linking for the 64-bit x86 > > kernel, enable PIE codegen for all objects that are lin

[PATCH 1/3] x86/APIC: Switch flat driver to use phys dst for ext ints

2024-10-02 Thread Matthew Barnes
Resolves: https://gitlab.com/xen-project/xen/-/issues/194 Signed-off-by: Matthew Barnes --- xen/arch/x86/include/asm/genapic.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/include/asm/genapic.h b/xen/arch/x86/include/asm/genapic.h index a694371c6d16

[PATCH 2/3] x86/APIC: Remove unnecessary logical flat functions

2024-10-02 Thread Matthew Barnes
Now that GENAPIC_FLAT uses physical destination for external interrupts, these functions implementing logical flat for external interrupts are no longer used. No functional change. Signed-off-by: Matthew Barnes --- xen/arch/x86/genapic/delivery.c| 10 -- xen/arch/x86/include/asm/gen

[PATCH 0/3] Switch flat driver to use phys dst for ext ints

2024-10-02 Thread Matthew Barnes
This patch series switches the apic_default APIC driver from using logical flat destination mode for external interrupts, to using physical destination mode for external interrupts. This is followed up by two non-functional cleanup commits. Matthew Barnes (3): x86/APIC: Switch flat driver to us

[PATCH 3/3] x86/APIC: Refactor GENAPIC_FLAT -> GENAPIC_MIXED

2024-10-02 Thread Matthew Barnes
The macro name is changed to somewhat mirror x2apic driver code, as logical flat is no longer used for external interrupts for this mode. No functional change. Signed-off-by: Matthew Barnes --- xen/arch/x86/genapic/default.c | 2 +- xen/arch/x86/include/asm/genapic.h | 2 +- 2 files changed

Re: [ANNOUNCE] Call for agenda items - Community Call 3rd October 2024

2024-10-02 Thread Kelly Choi
Hi all, As the 3rd of October is a public holiday in Germany, I propose we postpone the call by a week to the *10th October.* If there are any urgent issues to discuss or objections, please reply to this email. Kelly Choi Community Manager Xen Project On Tue, Oct 1, 20

Re: [PATCH v7 1/2] x86/boot: Rewrite EFI/MBI2 code partly in C

2024-10-02 Thread Daniel P. Smith
On 10/1/24 06:22, Frediano Ziglio wrote: No need to have it coded in assembly. Declare efi_multiboot2 in a new header to reuse between implementations and caller. Signed-off-by: Frediano Ziglio I unfortunately do not have time to test this myself, but I have given a read through and it looks

[xen-unstable test] 187930: tolerable FAIL - PUSHED

2024-10-02 Thread osstest service owner
flight 187930 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/187930/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 187916 test-amd64-amd64-xl-qemuu-ws16-amd64

Re: [PATCH v7 0/2] x86/boot: Reduce assembly code

2024-10-02 Thread Marek Marczykowski-Górecki
On Tue, Oct 01, 2024 at 11:22:37AM +0100, Frediano Ziglio wrote: > This series came from part of the work of removing duplications between > boot code and rewriting part of code from assembly to C. > Rewrites EFI code in pure C. The MB2+EFI tests on Adler Lake fail with this series: https://gitlab

Re: [PATCH v1 3/3] xen/riscv: register Xen's load address as a boot module

2024-10-02 Thread oleksii . kurochko
On Wed, 2024-10-02 at 14:11 +0200, Jan Beulich wrote: > On 02.10.2024 13:25, oleksii.kuroc...@gmail.com wrote: > > On Tue, 2024-10-01 at 17:49 +0200, Jan Beulich wrote: > > > On 30.09.2024 17:08, Oleksii Kurochko wrote: > > > > @@ -26,6 +27,8 @@ unsigned char __initdata > > > > cpu0_boot_stack[STAC

Re: [PATCH v4] xen: move per-cpu area management into common code

2024-10-02 Thread Michal Orzel
On 30/09/2024 18:39, Oleksii Kurochko wrote: > > > Centralize per-cpu area management to reduce code duplication and > enhance maintainability across architectures. > > The per-cpu area management code, which is largely common among > architectures, is moved to a shared implementation in > xe

Re: [PATCH] x86/kexec: Separate code and data by at least 1 cacheline

2024-10-02 Thread Andrew Cooper
On 02/10/2024 1:08 pm, Jan Beulich wrote: > On 02.10.2024 12:30, Andrew Cooper wrote: >> No functional change, but it performs a bit better. >> >> Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich Thanks. > > A question nevertheless: > >> --- a/xen/arch/x86/x86_64/kexec_reloc.S >> +++ b/x

Re: [PATCH] automation: add a smoke test for xen.efi on X86

2024-10-02 Thread Marek Marczykowski-Górecki
On Wed, Oct 02, 2024 at 02:41:55PM +0200, Marek Marczykowski-Górecki wrote: > Check if xen.efi is bootable with an XTF dom0. > > The TEST_TIMEOUT is set in the script to override project-global value. > Setting it in the gitlab yaml file doesn't work, as it's too low > priority > (https://docs.git

[PATCH 2/2] automation: add a smoke test for xen.efi on X86

2024-10-02 Thread Marek Marczykowski-Górecki
Check if xen.efi is bootable with an XTF dom0. The TEST_TIMEOUT is set in the script to override project-global value. Setting it in the gitlab yaml file doesn't work, as it's too low priority (https://docs.gitlab.com/ee/ci/variables/#cicd-variable-precedence). The multiboot2+EFI path is tested o

[PATCH 1/2] automation: preserve built xen.efi

2024-10-02 Thread Marek Marczykowski-Górecki
It will be useful for further tests. Signed-off-by: Marek Marczykowski-Górecki --- automation/scripts/build | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/automation/scripts/build b/automation/scripts/build index b3c71fb6fb60..4cd41cb2c471 100755 --- a/automation/scrip

[PATCH] automation: add a smoke test for xen.efi on X86

2024-10-02 Thread Marek Marczykowski-Górecki
Check if xen.efi is bootable with an XTF dom0. The TEST_TIMEOUT is set in the script to override project-global value. Setting it in the gitlab yaml file doesn't work, as it's too low priority (https://docs.gitlab.com/ee/ci/variables/#cicd-variable-precedence). The multiboot2+EFI path is tested o

Re: [PATCH v1 3/3] xen/riscv: register Xen's load address as a boot module

2024-10-02 Thread Jan Beulich
On 02.10.2024 13:25, oleksii.kuroc...@gmail.com wrote: > On Tue, 2024-10-01 at 17:49 +0200, Jan Beulich wrote: >> On 30.09.2024 17:08, Oleksii Kurochko wrote: >>> @@ -26,6 +27,8 @@ unsigned char __initdata >>> cpu0_boot_stack[STACK_SIZE] >>>  void __init noreturn start_xen(unsigned long bootcpu_id,

Re: [PATCH] x86/kexec: Separate code and data by at least 1 cacheline

2024-10-02 Thread Jan Beulich
On 02.10.2024 12:30, Andrew Cooper wrote: > No functional change, but it performs a bit better. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich A question nevertheless: > --- a/xen/arch/x86/x86_64/kexec_reloc.S > +++ b/xen/arch/x86/x86_64/kexec_reloc.S > @@ -19,6 +19,7 @@ > #includ

[qemu-mainline test] 187928: regressions - FAIL

2024-10-02 Thread osstest service owner
flight 187928 qemu-mainline real [real] flight 187937 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/187928/ http://logs.test-lab.xenproject.org/osstest/logs/187937/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH v1 3/3] xen/riscv: register Xen's load address as a boot module

2024-10-02 Thread oleksii . kurochko
On Tue, 2024-10-01 at 17:49 +0200, Jan Beulich wrote: > On 30.09.2024 17:08, Oleksii Kurochko wrote: > > @@ -26,6 +27,8 @@ unsigned char __initdata > > cpu0_boot_stack[STACK_SIZE] > >  void __init noreturn start_xen(unsigned long bootcpu_id, > >     paddr_t dtb_addr) > >

Re: [PATCH v1 2/3] xen/riscv: switch LINK_TO_LOAD() to virt_to_maddr()

2024-10-02 Thread oleksii . kurochko
On Tue, 2024-10-01 at 17:44 +0200, Jan Beulich wrote: > On 30.09.2024 17:08, Oleksii Kurochko wrote: > > Except for switching LINK_TO_LOAD() to virt_to_maddr(), > > LINK_TO_LOAD() is dropped, as virt_to_maddr() covers all > > the cases where LINK_TO_LOAD() is used. > > Why "Except for ..."? I'm af

Re: [RFC-for-4.20 v2 1/1] x86/hvm: Introduce Xen-wide ASID allocator

2024-10-02 Thread Jan Beulich
On 13.08.2024 21:01, Vaishali Thakkar wrote: > Currently ASID generation and management is done per-PCPU. This > scheme is incompatible with SEV technologies as SEV VMs need to > have a fixed ASID associated with all vcpus of the VM throughout > it's lifetime. > > This commit introduces a Xen-wide

[PATCH] x86/kexec: Separate code and data by at least 1 cacheline

2024-10-02 Thread Andrew Cooper
No functional change, but it performs a bit better. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné v2: * Rebase over metadata changes. --- xen/arch/x86/x86_64/kexec_reloc.S | 4 1 file changed, 4 insertions(+) diff --git a/xen/arch/x86/x86_64/kexec_reloc.S b/xen/

[xen-unstable-smoke test] 187933: tolerable all pass - PUSHED

2024-10-02 Thread osstest service owner
flight 187933 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/187933/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v1 1/3] xen/riscv: implement virt_to_maddr()

2024-10-02 Thread oleksii . kurochko
On Tue, 2024-10-01 at 17:41 +0200, Jan Beulich wrote: > On 30.09.2024 17:08, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/include/asm/mm.h > > +++ b/xen/arch/riscv/include/asm/mm.h > > @@ -28,7 +28,20 @@ static inline void *maddr_to_virt(paddr_t ma) > > return NULL; > >  } > >   > > -#defi

Re: [PATCH] hw/xen: Remove deadcode

2024-10-02 Thread Thomas Huth
On 17/09/2024 02.22, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" xen_be_copy_grant_refs is unused since 2019's 19f87870ba ("xen: remove the legacy 'xen_disk' backend") xen_config_dev_console is unused since 2018's 6d7c06c213 ("Remove broken Xen PV domain builder") Remove them

[PATCH v2] NUMA: Introduce NODE_DATA->node_present_pages(RAM pages)

2024-10-02 Thread Bernhard Kaindl
From: Bernhard Kaindl Changes in v2: - Remove update of numainfo call, only calculate RAM for each node. - Calculate RAM based on page boundaries, coding style fixes Some admin tools like 'xl info -n' like to display the total memory for each NUMA node. The Xen backend[1] of hwloc comes to mind

[ovmf test] 187934: all pass - PUSHED

2024-10-02 Thread osstest service owner
flight 187934 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/187934/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf cac73c45c4a9eaf81613260fb52bfc990e59bc0d baseline version: ovmf 3297be20bb8f575feb79e

Re: [PATCH] x86/ACPI: annotate assembly data with type and size

2024-10-02 Thread Jan Beulich
On 02.10.2024 11:07, Andrew Cooper wrote: > On 02/10/2024 8:41 am, Jan Beulich wrote: >> Further use the generic framework from xen/linkage.h. While there drop >> excess alignment and move to .bss. >> >> Requested-by: Andrew Cooper >> Signed-off-by: Jan Beulich >> --- >> Of course alongside ASM_I

Re: [PATCH] x86/ACPI: annotate assembly data with type and size

2024-10-02 Thread Andrew Cooper
On 02/10/2024 8:41 am, Jan Beulich wrote: > Further use the generic framework from xen/linkage.h. While there drop > excess alignment and move to .bss. > > Requested-by: Andrew Cooper > Signed-off-by: Jan Beulich > --- > Of course alongside ASM_INT() we could introduce ASM_QUAD() and > ASM_QUAD_L

Re: [PATCH v1 1/2] xen/riscv: initialize bootinfo from dtb

2024-10-02 Thread oleksii . kurochko
On Tue, 2024-10-01 at 17:54 +0200, Jan Beulich wrote: > On 30.09.2024 17:13, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/setup.c > > +++ b/xen/arch/riscv/setup.c > > @@ -28,6 +28,7 @@ void __init noreturn start_xen(unsigned long > > bootcpu_id, > >     paddr_t dtb_a

[PATCH] x86/ACPI: annotate assembly data with type and size

2024-10-02 Thread Jan Beulich
Further use the generic framework from xen/linkage.h. While there drop excess alignment and move to .bss. Requested-by: Andrew Cooper Signed-off-by: Jan Beulich --- Of course alongside ASM_INT() we could introduce ASM_QUAD() and ASM_QUAD_LOCAL() (only the latter needed right here) to aid readabi

[PATCH] CODING_STYLE: header file guard naming rules

2024-10-02 Thread Jan Beulich
Provide a (small) set of rules on how header guard identifiers ought to be spelled and what precautions ought to be taken to avoid name collisions. Signed-off-by: Jan Beulich Acked-by: Stefano Stabellini --- a/CODING_STYLE +++ b/CODING_STYLE @@ -153,6 +153,48 @@ E.g. timer-works. Note that som