[linux-linus test] 188043: tolerable FAIL - PUSHED

2024-10-10 Thread osstest service owner
flight 188043 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/188043/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 188028 test-amd64-amd64-xl-qemuu-win7-amd64

[xen-unstable test] 188045: tolerable trouble: fail/pass/starved - PUSHED

2024-10-10 Thread osstest service owner
flight 188045 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/188045/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 188034 test-amd64-amd64-xl-qemut-win7-amd64

[libvirt test] 188038: regressions - FAIL

2024-10-10 Thread osstest service owner
flight 188038 libvirt real [real] flight 188050 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188038/ http://logs.test-lab.xenproject.org/osstest/logs/188050/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-

[PATCH v3] xen: Remove dependency between pciback and privcmd

2024-10-10 Thread Jiqian Chen
Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev") adds a weak reverse dependency to the config XEN_PRIVCMD definition, that dependency causes xen-privcmd can't be loaded on domU, because dependent xen-pciback isn't always be loaded successfully on domU. To solve above proble

[ovmf test] 188049: all pass - PUSHED

2024-10-10 Thread osstest service owner
flight 188049 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/188049/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d2a41d1a7a555e54336e03731c801eb93fba801d baseline version: ovmf 0bae161fed39d8996693e

Re: [PATCH 3/3] stubdom: use real lib dependencies for xenstore stubdoms

2024-10-10 Thread Samuel Thibault
Juergen Gross, le jeu. 10 oct. 2024 17:54:59 +0200, a ecrit: > Today the build of Xenstore stubdoms depend on libxenguest just because > libxenguest depends on all needed libraries. In reality there is no > dependency on libxenguest for Xenstore stubdoms. > > Use the actual dependencies instead. >

[xen-unstable-smoke test] 188046: tolerable all pass - PUSHED

2024-10-10 Thread osstest service owner
flight 188046 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/188046/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v3 1/6] xen/arm: Skip initializing the BSS section when it is empty

2024-10-10 Thread Frediano Ziglio
On Thu, Oct 10, 2024 at 3:05 PM Ayan Kumar Halder wrote: > > If the BSS section is empty, then the function can just return. > > Signed-off-by: Ayan Kumar Halder > --- > Changes from :- > > v1..v2 - New patch introduced in v3. > > xen/arch/arm/arm64/head.S | 2 ++ > 1 file changed, 2 insertions(

Re: [PATCH v3 1/6] xen/arm: Skip initializing the BSS section when it is empty

2024-10-10 Thread Frediano Ziglio
On Thu, Oct 10, 2024 at 6:29 PM Ayan Kumar Halder wrote: > > Hi Frediano, > > Appreciate your feedback. > > On 10/10/2024 15:43, Frediano Ziglio wrote: > > On Thu, Oct 10, 2024 at 3:05 PM Ayan Kumar Halder > > wrote: > >> If the BSS section is empty, then the function can just return. > >> > >> S

Re: [PATCH] device-tree: Move dt-overlay.c to common/device-tree/

2024-10-10 Thread Stefano Stabellini
On Thu, 10 Oct 2024, Michal Orzel wrote: > The code is DT specific and as such should be placed under common > directory for DT related files. Update MAINTAINERS file accordingly > and drop the line with a path from a top-level comment in dt-overlay.c. > It serves no purpose and requires being upda

Re: [PATCH v2] xen: Remove dependency between pciback and privcmd

2024-10-10 Thread Stefano Stabellini
On Thu, 10 Oct 2024, Jiqian Chen wrote: > Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev") > adds a weak reverse dependency to the config XEN_PRIVCMD definition, that > dependency causes xen-privcmd can't be loaded on domU, because > dependent xen-pciback is always not be lo

Re: [RFC PATCH 13/13] Remove devres from pci_intx()

2024-10-10 Thread Dan Carpenter
On Thu, Oct 10, 2024 at 11:43:14AM -0600, Alex Williamson wrote: > FWIW, I think pcim_intx() and pci_intx() align better to our naming > convention for devres interfaces. Would it be sufficient if pci_intx() > triggered a WARN_ON if called for a pci_is_managed() device? Thanks, > To be honest,

[xen-unstable-smoke test] 188044: tolerable all pass - PUSHED

2024-10-10 Thread osstest service owner
flight 188044 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/188044/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [RFC PATCH 13/13] Remove devres from pci_intx()

2024-10-10 Thread Alex Williamson
On Thu, 10 Oct 2024 11:11:36 +0200 Philipp Stanner wrote: > On Thu, 2024-10-10 at 11:50 +0300, Dan Carpenter wrote: > > On Wed, Oct 09, 2024 at 10:35:19AM +0200, Philipp Stanner wrote: > > > pci_intx() is a hybrid function which can sometimes be managed > > > through > > > devres. This hybrid n

Re: [RFC PATCH 01/13] PCI: Prepare removing devres from pci_intx()

2024-10-10 Thread Alex Williamson
On Wed, 9 Oct 2024 10:35:07 +0200 Philipp Stanner wrote: > pci_intx() is a hybrid function which sometimes performs devres > operations, depending on whether pcim_enable_device() has been used to > enable the pci_dev. This sometimes-managed nature of the function is > problematic. Notably, it ca

[xen-unstable test] 188034: tolerable FAIL

2024-10-10 Thread osstest service owner
flight 188034 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/188034/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-credit1 13 debian-fixup fail in 188018 pass in 188034 test-amd64-amd64-xl-qemut-debian

Re: [PATCH v3 1/6] xen/arm: Skip initializing the BSS section when it is empty

2024-10-10 Thread Ayan Kumar Halder
Hi Frediano, Appreciate your feedback. On 10/10/2024 15:43, Frediano Ziglio wrote: On Thu, Oct 10, 2024 at 3:05 PM Ayan Kumar Halder wrote: If the BSS section is empty, then the function can just return. Signed-off-by: Ayan Kumar Halder --- Changes from :- v1..v2 - New patch introduced in

Re: [PATCH v5 20/44] x86/boot: convert xsm policy loading to struct boot_module

2024-10-10 Thread Jason Andryuk
On 2024-10-09 13:21, Daniel P. Smith wrote: On 10/8/24 12:13, Jason Andryuk wrote: On 2024-10-06 17:49, Daniel P. Smith wrote: Iterate through the unclaimed struct boot_module to see if any are an XSM FLASK policy. If one is located, mark it as an xsm policy. Signed-off-by: Daniel P. Smith

[PATCH 0/3] stubdom: reduce xenstore library dependencies

2024-10-10 Thread Juergen Gross
Instead of letting the xenstore stubdoms depend on libxenguest and with that on basically all Xen libraries, only let it depend on the actually used libraries. This is in preparation of removing the libxenctrl dependency from Xenstore and with that the capability to use xenstore-stubdom on multipl

[PATCH 2/3] tools/xenstored: remove unneeded libxenguest reference

2024-10-10 Thread Juergen Gross
Today the xenstored Makefile contains an unneeded reference to the not used libxenguest library. Remove it. Signed-off-by: Juergen Gross --- tools/xenstored/Makefile.common | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/xenstored/Makefile.common b/tools/xenstored/Makefile.common index

[PATCH 3/3] stubdom: use real lib dependencies for xenstore stubdoms

2024-10-10 Thread Juergen Gross
Today the build of Xenstore stubdoms depend on libxenguest just because libxenguest depends on all needed libraries. In reality there is no dependency on libxenguest for Xenstore stubdoms. Use the actual dependencies instead. Signed-off-by: Juergen Gross --- stubdom/Makefile | 6 -- 1 file

[PATCH 1/3] config: update Mini-OS commit

2024-10-10 Thread Juergen Gross
Update the Mini-OS upstream revision. Signed-off-by: Juergen Gross --- Config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Config.mk b/Config.mk index 1a3938b6c4..6dd2f9439c 100644 --- a/Config.mk +++ b/Config.mk @@ -224,7 +224,7 @@ QEMU_UPSTREAM_URL ?= https://xenbits

Re: [PATCH v3 0/6] Enable early bootup of AArch64 MPU systems

2024-10-10 Thread oleksii . kurochko
Hello Ayan, I think that we have to mention in CHANGELOG.md that experimental support of Xen with MPU for Arm is added. ( if I understand correctly what is this patch series about ). Thanks. ~ Oleksii On Thu, 2024-10-10 at 15:03 +0100, Ayan Kumar Halder wrote: > We have enabled early booting of

[PATCH v2 0/2] Parse and handle command line from dtb

2024-10-10 Thread Oleksii Kurochko
This patch series initializes bootinfo from dtb and then parse and handle command line from dtb. --- Changes in v2: - Update the cover letter message: drop information about patch series dependency. - Add Acked-by for the patch 2 ( xen/riscv: parse and handle fdt command line ) - Minor chang

[PATCH v2 2/2] xen/riscv: parse and handle fdt command line

2024-10-10 Thread Oleksii Kurochko
Receive Xen's command line passed by DTB using boot_fdt_cmdline() and passed it to cmdline_parse() for further procesinng and setup of Xen-specific parameters. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V2: - add Acked-by: Jan Beulich --- xen/arch/riscv/setup.c | 6 +

[PATCH v2 1/2] xen/riscv: initialize bootinfo from dtb

2024-10-10 Thread Oleksii Kurochko
Parse DTB during startup, allowing memory banks and reserved memory regions to be set up, along with early device tree node ( chosen, "xen,domain", "reserved-memory", etc ) handling. Signed-off-by: Oleksii Kurochko --- Changes in V2: - Drop local variable fdt_size as it is going to be used only

Re: [PATCH v2 0/6] xen/arm: dt overlay fixes

2024-10-10 Thread Julien Grall
Hi Michal, On 04/10/2024 13:22, Michal Orzel wrote: This series contains fixes and improvements after doing some tests with DT overlay support in Xen. I split the series so that each patch handles a separate issue. Michal Orzel (6): dt-overlay: Fix NULL pointer dereference device-tree: Re

Re: [RFC PATCH 00/13] Remove implicit devres from pci_intx()

2024-10-10 Thread Andy Shevchenko
On Thu, Oct 10, 2024 at 10:09:12AM +0200, Philipp Stanner wrote: > On Wed, 2024-10-09 at 20:32 +0200, Heiner Kallweit wrote: > > On 09.10.2024 10:35, Philipp Stanner wrote: ... > > > To do so, a pci_intx() version that is always-managed, and one that > > > is > > > never-managed are provided. The

Re: [RFC PATCH 02/13] ALSA: hda: hda_intel: Use always-managed version of pcim_intx()

2024-10-10 Thread Andy Shevchenko
On Wed, Oct 09, 2024 at 10:35:08AM +0200, Philipp Stanner wrote: > pci_intx() is a hybrid function which can sometimes be managed through > devres. To remove this hybrid nature from pci_intx(), it is necessary to > port users to either an always-managed or a never-managed version. > > hda_intel en

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-10-10 Thread David Woodhouse
On Thu, 2024-03-07 at 09:39 +0100, Jan Beulich wrote: > On 06.03.2024 18:28, Sébastien Chaumat wrote: > > Reasoning backward  (using a  kernel without the pinctrl_amd driver to > > > ensure xen only is at stake) : > > >  checking the diff in IOAPIC  between bare metal and xen  (IRQ7 is on > > > pin

Re: [PATCH v3 1/6] xen/arm: Skip initializing the BSS section when it is empty

2024-10-10 Thread Frediano Ziglio
On Thu, Oct 10, 2024 at 3:05 PM Ayan Kumar Halder wrote: > > If the BSS section is empty, then the function can just return. > > Signed-off-by: Ayan Kumar Halder > --- > Changes from :- > > v1..v2 - New patch introduced in v3. > > xen/arch/arm/arm64/head.S | 2 ++ > 1 file changed, 2 insertions(

Re: [RFC PATCH 01/13] PCI: Prepare removing devres from pci_intx()

2024-10-10 Thread Andy Shevchenko
On Wed, Oct 09, 2024 at 10:35:07AM +0200, Philipp Stanner wrote: > pci_intx() is a hybrid function which sometimes performs devres > operations, depending on whether pcim_enable_device() has been used to > enable the pci_dev. This sometimes-managed nature of the function is > problematic. Notably,

Re: [PATCH v3 6/6] xen/arm: mpu: Implement a dummy enable_secondary_cpu_mm

2024-10-10 Thread Jan Beulich
On 10.10.2024 16:03, Ayan Kumar Halder wrote: > --- a/xen/arch/Kconfig > +++ b/xen/arch/Kconfig > @@ -6,11 +6,13 @@ config PHYS_ADDR_T_32 > > config NR_CPUS > int "Maximum number of CPUs" > + range 1 1 if MPU I think this "if" and ... > range 1 16383 > default "256" if X8

[PATCH v3 3/6] xen/arm: mpu: Define Xen start address for MPU systems

2024-10-10 Thread Ayan Kumar Halder
From: Wei Chen On Armv8-A, Xen has a fixed virtual start address (link address too) for all Armv8-A platforms. In an MMU based system, Xen can map its loaded address to this virtual start address. So, on Armv8-A platforms, the Xen start address does not need to be configurable. But on Armv8-R pla

[PATCH v3 6/6] xen/arm: mpu: Implement a dummy enable_secondary_cpu_mm

2024-10-10 Thread Ayan Kumar Halder
Secondary cpus initialization is not yet supported. Thus, we print an appropriate message and put the secondary cpus in WFE state. And we introduce to BUILD_BUG_ON to prevent users using from building Xen on multiprocessor based MPU systems. In Arm, there is no clean way to disable SMP. As of now,

[PATCH v3 1/6] xen/arm: Skip initializing the BSS section when it is empty

2024-10-10 Thread Ayan Kumar Halder
If the BSS section is empty, then the function can just return. Signed-off-by: Ayan Kumar Halder --- Changes from :- v1..v2 - New patch introduced in v3. xen/arch/arm/arm64/head.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index

[PATCH v3 4/6] xen/arm: mpu: Create boot-time MPU protection regions

2024-10-10 Thread Ayan Kumar Halder
Define enable_boot_cpu_mm() for the AArch64-V8R system. Like boot-time page table in MMU system, we need a boot-time MPU protection region configuration in MPU system so Xen can fetch code and data from normal memory. To do this, Xen maps the following sections of the binary as separate regions (

[PATCH v3 5/6] xen/arm: mpu: Enable MPU

2024-10-10 Thread Ayan Kumar Halder
After the regions have been created, now we enable the MPU. For this we disable the background region so that the new memory map created for the regions take effect. Also, we treat all RW regions as non executable and the data cache is enabled. Signed-off-by: Ayan Kumar Halder --- Changes from :-

[PATCH v3 2/6] xen/arm: mpu: Introduce choice between MMU and MPU

2024-10-10 Thread Ayan Kumar Halder
There are features in the forthcoming patches which are dependent on MPU. For eg fixed start address. Also, some of the Xen features (eg STATIC_MEMORY) will be selected by the MPU configuration. Thus, this patch introduces a choice between MMU and MPU for the type of memory management system. By d

[PATCH v3 0/6] Enable early bootup of AArch64 MPU systems

2024-10-10 Thread Ayan Kumar Halder
We have enabled early booting of R82. Changes from v2 :- 1. Added a new patch "xen/arm: Skip initializing the BSS section when it is empty". 2. Split "xen/arm: mpu: Create boot-time MPU protection regions" into 2 patches. Ayan Kumar Halder (6): xen/arm: Skip initializing the BSS section when i

Re: [PATCH v2 4/6] x86/boot: Reuse code to relocate trampoline

2024-10-10 Thread Andrew Cooper
On 07/10/2024 3:15 pm, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio This patch looks fine now (give or take some knock-on effects from patch 3). However it probably does need a little more in the way of commit message.  You're moving the EFI implementation, building it for both 32 and

Re: [PATCH v2 5/6] x86/boot: Use trampoline_phys variable directly from C code

2024-10-10 Thread Frediano Ziglio
On Thu, Oct 10, 2024 at 1:57 PM Andrew Cooper wrote: > > On 07/10/2024 3:15 pm, Frediano Ziglio wrote: > > No more need to pass from assembly code. > > > > Signed-off-by: Frediano Ziglio > > --- > > Changes since v1: > > - split the 2 variable changes into 2 commits. > > --- > > xen/arch/x86/boo

Re: [PATCH v2 6/6] x86/boot: Use boot_vid_info variable directly from C code

2024-10-10 Thread Andrew Cooper
On 07/10/2024 3:15 pm, Frediano Ziglio wrote: > No more need to pass from assembly code. > > Signed-off-by: Frediano Ziglio This patch is fine now. As noted in patch 5, there will be less net churn if the order was swapped.  (As it stands, there's at least one correction in this patch as a knock

Re: [PATCH v2] stubdom: add fine grained library config items to Mini-OS configs

2024-10-10 Thread Andrew Cooper
On 10/10/2024 1:49 pm, Anthony PERARD wrote: > On Thu, Oct 10, 2024 at 01:19:46PM +0200, Juergen Gross wrote: >> Today Mini-OS can only be configured to use all or none Xen library. >> In order to prepare a more fine grained configuration scheme, add per >> library config items to the Mini-OS confi

Re: [PATCH v2 5/6] x86/boot: Use trampoline_phys variable directly from C code

2024-10-10 Thread Andrew Cooper
On 07/10/2024 3:15 pm, Frediano Ziglio wrote: > No more need to pass from assembly code. > > Signed-off-by: Frediano Ziglio > --- > Changes since v1: > - split the 2 variable changes into 2 commits. > --- > xen/arch/x86/boot/head.S | 13 - > xen/arch/x86/boot/reloc.c | 9 ++--- >

Re: [PATCH v2] stubdom: add fine grained library config items to Mini-OS configs

2024-10-10 Thread Anthony PERARD
On Thu, Oct 10, 2024 at 01:19:46PM +0200, Juergen Gross wrote: > Today Mini-OS can only be configured to use all or none Xen library. > In order to prepare a more fine grained configuration scheme, add per > library config items to the Mini-OS config files. > > As some libraries pull in others, th

Re: [PATCH] iommu/amd-vi: do not error if device referenced in IVMD is not behind any IOMMU

2024-10-10 Thread Marek Marczykowski-Górecki
On Wed, Oct 09, 2024 at 03:37:06PM +0200, Roger Pau Monné wrote: > On Wed, Oct 09, 2024 at 02:09:33PM +0200, Jan Beulich wrote: > > On 09.10.2024 13:47, Roger Pau Monné wrote: > > > On Wed, Oct 09, 2024 at 01:28:19PM +0200, Jan Beulich wrote: > > >> On 09.10.2024 13:13, Roger Pau Monné wrote: > > >

[linux-linus test] 188028: tolerable FAIL - PUSHED

2024-10-10 Thread osstest service owner
flight 188028 linux-linus real [real] flight 188042 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188028/ http://logs.test-lab.xenproject.org/osstest/logs/188042/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-

Re: [PATCH v3 00/19] Update header guards bases on new coding style

2024-10-10 Thread Frediano Ziglio
On Thu, Oct 10, 2024 at 12:26 PM Andrew Cooper wrote: > > On 04/10/2024 9:16 am, Frediano Ziglio wrote: > > Frediano Ziglio (19): > > xen: Update header guards - Generic > > xen: Update header guards - X86 > > xen: Update header guards - ACPI > > xen: Update header guards - ARGO > > xen:

[xen-unstable-smoke test] 188041: tolerable all pass - PUSHED

2024-10-10 Thread osstest service owner
flight 188041 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/188041/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [MINI-OS PATCH v2] add config support for each Xen library

2024-10-10 Thread Jürgen Groß
On 10.10.24 13:45, Jan Beulich wrote: On 09.10.2024 16:05, Juergen Gross wrote: Instead of adding all or no Xen library (controlled by CONFIG_XC), support a dedicated config option for each library instead, defaulting to disabled. As it is no longer needed now, drop the CONFIG_XC support. Sign

Re: [MINI-OS PATCH v2] add config support for each Xen library

2024-10-10 Thread Jan Beulich
On 09.10.2024 16:05, Juergen Gross wrote: > Instead of adding all or no Xen library (controlled by CONFIG_XC), > support a dedicated config option for each library instead, > defaulting to disabled. > > As it is no longer needed now, drop the CONFIG_XC support. > > Signed-off-by: Juergen Gross >

Re: [PATCH v3 00/19] Update header guards bases on new coding style

2024-10-10 Thread Andrew Cooper
On 04/10/2024 9:16 am, Frediano Ziglio wrote: > Frediano Ziglio (19): > xen: Update header guards - Generic > xen: Update header guards - X86 > xen: Update header guards - ACPI > xen: Update header guards - ARGO > xen: Update header guards - ARM > xen: Update header guards - Device tree

[PATCH v2] stubdom: add fine grained library config items to Mini-OS configs

2024-10-10 Thread Juergen Gross
Today Mini-OS can only be configured to use all or none Xen library. In order to prepare a more fine grained configuration scheme, add per library config items to the Mini-OS config files. As some libraries pull in others, the config files need to be extended at build time to reflect those indirec

[PATCH] device-tree: Move dt-overlay.c to common/device-tree/

2024-10-10 Thread Michal Orzel
The code is DT specific and as such should be placed under common directory for DT related files. Update MAINTAINERS file accordingly and drop the line with a path from a top-level comment in dt-overlay.c. It serves no purpose and requires being updated on every code movement. Signed-off-by: Micha

Re: [PATCH v5 25/44] x86/boot: convert create_dom0 to use boot info

2024-10-10 Thread Daniel P. Smith
On 10/10/24 04:03, Jan Beulich wrote: On 10.10.2024 01:02, Daniel P. Smith wrote: On 10/8/24 12:52, Jason Andryuk wrote: On 2024-10-06 17:49, Daniel P. Smith wrote: This commit changes create_dom0 to no longer take the individual components and take struct boot_info instead. Internally, it is

Re: [PATCH v2] xen: Remove dependency between pciback and privcmd

2024-10-10 Thread Jürgen Groß
On 10.10.24 10:43, Chen, Jiqian wrote: On 2024/10/10 16:39, Jürgen Groß wrote: On 10.10.24 09:58, Jiqian Chen wrote: Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev") adds a weak reverse dependency to the config XEN_PRIVCMD definition, that dependency causes xen-privcmd c

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-10 Thread Bertrand Marquis
HI Ayan, > On 10 Oct 2024, at 11:18, Ayan Kumar Halder wrote: > > Hi Bertrand, > > < snip> > >>> 4) AoU on domain - 1) Domains should not use HVC DCC registers as Xen does >>> not emulate them. >> Xen does not depend on that, the domain does so this is only a Xen expected >> behaviour and we

[PATCH v9 1/2] x86/boot: Align mbi2.c stack to 16 bytes

2024-10-10 Thread Frediano Ziglio
Doing previous testing with an Alder Lake Intel machine the with "x86/boot: Improve MBI2 structure check" commit test started to fail. Removing the commit makes the tests succeed however there was not apparent reason (looking at the code) for the failure. So I instrumented code to output the struct

[PATCH v9 2/2] x86/boot: Improve MBI2 structure check

2024-10-10 Thread Frediano Ziglio
Tag structure should contain at least the tag header. Entire tag structure must be contained inside MBI2 data. Reviewed-by: Jan Beulich Signed-off-by: Frediano Ziglio --- Changes since v6: - compare against total_size every time to avoid overflows. Changes since v7: - check for tag type being M

[PATCH v9 0/2] x86/boot: Improve MBI2 structure check (was: Reduce assembly code)

2024-10-10 Thread Frediano Ziglio
This series came from part of the work of removing duplications between boot code and rewriting part of code from assembly to C. Changes since v1, more details in specific commits: - style updates; - comments and descriptions improvements; - other improvements. Changes since v2: - rebased on mast

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-10 Thread Ayan Kumar Halder
Hi Bertrand, < snip> 4) AoU on domain - 1) Domains should not use HVC DCC registers as Xen does not emulate them. Xen does not depend on that, the domain does so this is only a Xen expected behaviour and we should document that Domains shall not use it. Agreed, we need to document somewher

Re: [RFC PATCH 10/13] staging: rts5280: Use always-managed version of pci_intx()

2024-10-10 Thread Philipp Stanner
On Thu, 2024-10-10 at 11:03 +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 10, 2024 at 10:03:30AM +0200, Philipp Stanner wrote: > > On Wed, 2024-10-09 at 21:41 +0200, Philipp Hortmann wrote: > > > On 10/9/24 11:38, Greg Kroah-Hartman wrote: > > > > On Wed, Oct 09, 2024 at 10:35:16AM +0200, Philipp

Re: [RFC PATCH 13/13] Remove devres from pci_intx()

2024-10-10 Thread Philipp Stanner
On Thu, 2024-10-10 at 11:50 +0300, Dan Carpenter wrote: > On Wed, Oct 09, 2024 at 10:35:19AM +0200, Philipp Stanner wrote: > > pci_intx() is a hybrid function which can sometimes be managed > > through > > devres. This hybrid nature is undesirable. > > > > Since all users of pci_intx() have by now

Re: [RFC PATCH 10/13] staging: rts5280: Use always-managed version of pci_intx()

2024-10-10 Thread Greg Kroah-Hartman
On Thu, Oct 10, 2024 at 10:03:30AM +0200, Philipp Stanner wrote: > On Wed, 2024-10-09 at 21:41 +0200, Philipp Hortmann wrote: > > On 10/9/24 11:38, Greg Kroah-Hartman wrote: > > > On Wed, Oct 09, 2024 at 10:35:16AM +0200, Philipp Stanner wrote: > > > > pci_intx() is a hybrid function which can some

Re: [RFC PATCH 13/13] Remove devres from pci_intx()

2024-10-10 Thread Dan Carpenter
On Wed, Oct 09, 2024 at 10:35:19AM +0200, Philipp Stanner wrote: > pci_intx() is a hybrid function which can sometimes be managed through > devres. This hybrid nature is undesirable. > > Since all users of pci_intx() have by now been ported either to > always-managed pcim_intx() or never-managed p

Re: [PATCH v2] xen: Remove dependency between pciback and privcmd

2024-10-10 Thread Chen, Jiqian
On 2024/10/10 16:39, Jürgen Groß wrote: > On 10.10.24 09:58, Jiqian Chen wrote: >> Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev") >> adds a weak reverse dependency to the config XEN_PRIVCMD definition, that >> dependency causes xen-privcmd can't be loaded on domU, because

Re: [PATCH v2] xen: Remove dependency between pciback and privcmd

2024-10-10 Thread Chen, Jiqian
On 2024/10/10 16:17, Jan Beulich wrote: > On 10.10.2024 09:58, Jiqian Chen wrote: >> --- a/drivers/xen/acpi.c >> +++ b/drivers/xen/acpi.c >> @@ -125,3 +125,20 @@ int xen_acpi_get_gsi_info(struct pci_dev *dev, >> return 0; >> } >> EXPORT_SYMBOL_GPL(xen_acpi_get_gsi_info); >> + >> +get_gsi_fro

Re: [PATCH v8 1/2] x86/boot: Align mbi2.c stack to 16 bytes

2024-10-10 Thread Jan Beulich
On 10.10.2024 10:34, Frediano Ziglio wrote: > On Wed, Oct 9, 2024 at 12:13 PM Jan Beulich wrote: >> >> On 09.10.2024 12:15, Frediano Ziglio wrote: >>> On Wed, Oct 9, 2024 at 9:20 AM Jan Beulich wrote: On 09.10.2024 10:04, Frediano Ziglio wrote: > --- a/xen/arch/x86/efi/Makefile > +++

Re: [PATCH v2] xen: Remove dependency between pciback and privcmd

2024-10-10 Thread Jürgen Groß
On 10.10.24 09:58, Jiqian Chen wrote: Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev") adds a weak reverse dependency to the config XEN_PRIVCMD definition, that dependency causes xen-privcmd can't be loaded on domU, because dependent xen-pciback is always not be loaded suc

Re: [PATCH v8 1/2] x86/boot: Align mbi2.c stack to 16 bytes

2024-10-10 Thread Frediano Ziglio
On Wed, Oct 9, 2024 at 12:13 PM Jan Beulich wrote: > > On 09.10.2024 12:15, Frediano Ziglio wrote: > > On Wed, Oct 9, 2024 at 9:20 AM Jan Beulich wrote: > >> On 09.10.2024 10:04, Frediano Ziglio wrote: > >>> --- a/xen/arch/x86/efi/Makefile > >>> +++ b/xen/arch/x86/efi/Makefile > >>> @@ -11,6 +11,

[ovmf test] 188039: all pass - PUSHED

2024-10-10 Thread osstest service owner
flight 188039 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/188039/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0bae161fed39d8996693e586b77f31094b61b9d7 baseline version: ovmf da1c6dd62a19361186739

Re: [PATCH v2] xen: Remove dependency between pciback and privcmd

2024-10-10 Thread Jan Beulich
On 10.10.2024 09:58, Jiqian Chen wrote: > --- a/drivers/xen/acpi.c > +++ b/drivers/xen/acpi.c > @@ -125,3 +125,20 @@ int xen_acpi_get_gsi_info(struct pci_dev *dev, > return 0; > } > EXPORT_SYMBOL_GPL(xen_acpi_get_gsi_info); > + > +get_gsi_from_sbdf_t get_gsi_from_sbdf = NULL; > + > +void xe

[qemu-upstream-4.19-testing test] 188027: tolerable FAIL - PUSHED

2024-10-10 Thread osstest service owner
flight 188027 qemu-upstream-4.19-testing real [real] flight 188040 qemu-upstream-4.19-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188027/ http://logs.test-lab.xenproject.org/osstest/logs/188040/ Failures :-/ but no regressions. Tests which are failing intermittentl

Re: [RFC PATCH 00/13] Remove implicit devres from pci_intx()

2024-10-10 Thread Philipp Stanner
On Wed, 2024-10-09 at 20:32 +0200, Heiner Kallweit wrote: > On 09.10.2024 10:35, Philipp Stanner wrote: > > Hi all, > > > > this series removes a problematic feature from pci_intx(). That > > function > > sometimes implicitly uses devres for automatic cleanup. We should > > get > > rid of this imp

Re: [PATCH v5 36/44] x86/boot: remove remaining early_mod references

2024-10-10 Thread Jan Beulich
On 10.10.2024 01:42, Daniel P. Smith wrote: > On 10/9/24 02:53, Jan Beulich wrote: >> On 08.10.2024 21:15, Jason Andryuk wrote: >>> On 2024-10-06 17:49, Daniel P. Smith wrote: Any direct usages of struct mod have been transitioned, remove the remaining references to early_mod fields

Re: [RFC PATCH 10/13] staging: rts5280: Use always-managed version of pci_intx()

2024-10-10 Thread Philipp Stanner
On Wed, 2024-10-09 at 21:41 +0200, Philipp Hortmann wrote: > On 10/9/24 11:38, Greg Kroah-Hartman wrote: > > On Wed, Oct 09, 2024 at 10:35:16AM +0200, Philipp Stanner wrote: > > > pci_intx() is a hybrid function which can sometimes be managed > > > through > > > devres. To remove this hybrid nature

Re: [PATCH v5 25/44] x86/boot: convert create_dom0 to use boot info

2024-10-10 Thread Jan Beulich
On 10.10.2024 01:02, Daniel P. Smith wrote: > On 10/8/24 12:52, Jason Andryuk wrote: >> On 2024-10-06 17:49, Daniel P. Smith wrote: >>> This commit changes create_dom0 to no longer take the individual >>> components and >>> take struct boot_info instead. Internally, it is changed to locate the >>

[PATCH v2] xen: Remove dependency between pciback and privcmd

2024-10-10 Thread Jiqian Chen
Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev") adds a weak reverse dependency to the config XEN_PRIVCMD definition, that dependency causes xen-privcmd can't be loaded on domU, because dependent xen-pciback is always not be loaded successfully on domU. To solve above probl

Re: [PATCH v6 09/11] xen/x86: Derive topologically correct x2APIC IDs from the policy

2024-10-10 Thread Jan Beulich
On 09.10.2024 19:29, Alejandro Vallejo wrote: > On Wed Oct 9, 2024 at 3:53 PM BST, Jan Beulich wrote: >> On 01.10.2024 14:38, Alejandro Vallejo wrote: >>> Implements the helper for mapping vcpu_id to x2apic_id given a valid >>> topology in a policy. The algo is written with the intention of >>> ext

Re: [PATCH v6 08/11] xen/lib: Add topology generator for x86

2024-10-10 Thread Jan Beulich
On 09.10.2024 19:57, Alejandro Vallejo wrote: > On Wed Oct 9, 2024 at 3:45 PM BST, Jan Beulich wrote: >> On 01.10.2024 14:38, Alejandro Vallejo wrote: >>> --- a/xen/lib/x86/policy.c >>> +++ b/xen/lib/x86/policy.c >>> @@ -2,6 +2,94 @@ >>> >>> #include >>> >>> +static unsigned int order(unsigne

Re: [PATCH v6 05/11] tools/hvmloader: Retrieve (x2)APIC IDs from the APs themselves

2024-10-10 Thread Jan Beulich
On 09.10.2024 19:19, Alejandro Vallejo wrote: > On Wed Oct 9, 2024 at 3:03 PM BST, Jan Beulich wrote: >> On 01.10.2024 14:38, Alejandro Vallejo wrote: >>> Make it so the APs expose their own APIC IDs in a LUT. We can use that >>> LUT to populate the MADT, decoupling the algorithm that relates CPU I

Re: [PATCH v6 04/11] xen/x86: Add supporting code for uploading LAPIC contexts during domain create

2024-10-10 Thread Jan Beulich
On 09.10.2024 18:44, Alejandro Vallejo wrote: > On Wed Oct 9, 2024 at 2:28 PM BST, Jan Beulich wrote: >> On 01.10.2024 14:38, Alejandro Vallejo wrote: >>> If toolstack were to upload LAPIC contexts as part of domain creation it >> >> If it were to - yes. But it doesn't, an peeking ahead in the seri

Re: [PATCH v6 01/11] lib/x86: Relax checks about policy compatibility

2024-10-10 Thread Jan Beulich
On 09.10.2024 17:57, Alejandro Vallejo wrote: > On Wed Oct 9, 2024 at 10:40 AM BST, Jan Beulich wrote: >> On 01.10.2024 14:37, Alejandro Vallejo wrote: >>> --- a/xen/lib/x86/policy.c >>> +++ b/xen/lib/x86/policy.c >>> @@ -15,7 +15,16 @@ int x86_cpu_policies_are_compatible(const struct >>> cpu_poli

Re: [RFC PATCH 12/13] HID: amd_sfh: Use always-managed version of pcim_intx()

2024-10-10 Thread Basavaraj Natikar
On 10/9/2024 2:05 PM, Philipp Stanner wrote: pci_intx() is a hybrid function which can sometimes be managed through devres. To remove this hybrid nature from pci_intx(), it is necessary to port users to either an always-managed or a never-managed version. All users of amd_mp2_pci_remove(), whe

Re: [PATCH] xen: Remove config dependency in XEN_PRIVCMD definition

2024-10-10 Thread Jürgen Groß
On 10.10.24 09:01, Jan Beulich wrote: On 10.10.2024 07:39, Jürgen Groß wrote: On 10.10.24 00:46, Stefano Stabellini wrote: On Wed, 9 Oct 2024, Jan Beulich wrote: On 09.10.2024 08:20, Jiqian Chen wrote: Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev") adds a weak revers

Re: [PATCH] xen: Remove config dependency in XEN_PRIVCMD definition

2024-10-10 Thread Jürgen Groß
On 10.10.24 09:07, Chen, Jiqian wrote: On 2024/10/10 13:39, Jürgen Groß wrote: On 10.10.24 00:46, Stefano Stabellini wrote: On Wed, 9 Oct 2024, Jan Beulich wrote: On 09.10.2024 08:20, Jiqian Chen wrote: Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev") adds a weak rever

Re: [PATCH] xen: Remove config dependency in XEN_PRIVCMD definition

2024-10-10 Thread Chen, Jiqian
On 2024/10/10 13:39, Jürgen Groß wrote: > On 10.10.24 00:46, Stefano Stabellini wrote: >> On Wed, 9 Oct 2024, Jan Beulich wrote: >>> On 09.10.2024 08:20, Jiqian Chen wrote: Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev") adds a weak reverse dependency to the confi

Re: [PATCH] xen: Remove config dependency in XEN_PRIVCMD definition

2024-10-10 Thread Jan Beulich
On 10.10.2024 07:39, Jürgen Groß wrote: > On 10.10.24 00:46, Stefano Stabellini wrote: >> On Wed, 9 Oct 2024, Jan Beulich wrote: >>> On 09.10.2024 08:20, Jiqian Chen wrote: Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev") adds a weak reverse dependency to the confi