Re: [PATCH 13/13] PCI: Deprecate pci_intx(), pcim_intx()

2024-10-20 Thread Philipp Stanner
On Fri, 2024-10-18 at 18:45 -0500, Bjorn Helgaas wrote: > On Wed, Oct 16, 2024 at 10:53:16AM +0200, Philipp Stanner wrote: > > On Wed, 2024-10-16 at 10:43 +0200, Heiner Kallweit wrote: > > > On 16.10.2024 08:57, Philipp Stanner wrote: > > > > On Tue, 2024-10-15 at 13:53 -0600, Alex Williamson wrote

[PATCH v7 16/38] x86/boot: remove module_map usage from microcode loading

2024-10-20 Thread Daniel P. Smith
With all consumers of module_map converted, remove usage of it by the microcode loading logic. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v5: - dropped unnecessary parens --- xen/arch/x86/cpu/microcode/core.c| 20 xen/arch/x86/include/as

[PATCH v7 37/38] x86/boot: convert dom0_construct_pv to struct boot_domain

2024-10-20 Thread Daniel P. Smith
With construct_dom0 consuming struct boot_domain, continue passing the structure down to dom0_construct_pv. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v5: - reverted back *v d->vcpu[0] --- xen/arch/x86/dom0_build.c | 2 +- xen/arch/x86/include/asm/d

[PATCH v7 25/38] x86/boot: convert dom0_construct_pvh to struct boot_module

2024-10-20 Thread Daniel P. Smith
This changes both the kernel and ramdisk parameters over to struct boot_module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v6: - removed unnecessary indentation changes --- xen/arch/x86/dom0_build.c | 3 +-- xen/arch/x86/hvm/dom0_build.c | 9

[PATCH v7 22/38] x86/boot: add cmdline to struct boot_module

2024-10-20 Thread Daniel P. Smith
Add a char pointer field, cmdline, to struct boot_module to hold the address pointed to by the string field of struct mod. This removes the need to use the early_mod field to get to the dom0 kernel command line. Signed-off-by: Daniel P. Smith --- Changes since v5: - changed boot_module element cm

[PATCH v7 19/38] x86/boot: convert create_dom0 to use boot info

2024-10-20 Thread Daniel P. Smith
This commit changes create_dom0 to no longer take the individual components and take struct boot_info instead. Internally, it is changed to locate the kernel and ramdisk details from struct boot_info. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v5: - change headro

[PATCH v7 28/38] x86/boot: drop the use of initial_images unit global

2024-10-20 Thread Daniel P. Smith
Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v5: - coding style changes --- xen/arch/x86/setup.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 0f8fb3c572c6..87b118cdcf1e 10064

[PATCH v7 07/38] x86/boot: add start and size fields to struct boot_module

2024-10-20 Thread Daniel P. Smith
This commit introduces the start and size fields to struct boot_module and assigns their value during boot_info construction. The EFI entry point is a special case, as the EFI file loading boot service may load a file beyond the 4G barrier. As a result, to make the address fit in the 32bit integer

[PATCH v7 24/38] x86/boot: convert dom0_construct_pv initrd param to struct boot_module

2024-10-20 Thread Daniel P. Smith
This changes the type for the initrd parameter of dom0_construct_pv to be struct boot_module. This conversion requires several adjustments throughout dom0_construct_pv to account for the type change. Removes the usage of early_mod field for ramdisk module. Signed-off-by: Daniel P. Smith Reviewe

[PATCH v7 27/38] x86/boot: convert initial_images to struct boot_module

2024-10-20 Thread Daniel P. Smith
The variable initial_images is used for tracking the boot modules passed in by the boot loader. Convert to a struct boot_module and adjust the code that uses it accordingly. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v5: - coding style changes --- xen/arch/x86/s

[PATCH v7 09/38] x86/boot: transition relocation calculations to struct boot_module

2024-10-20 Thread Daniel P. Smith
Use struct boot_module fields, start and size, when calculating the relocation address and size. It also ensures that early_mod references are kept in sync. Signed-off-by: Daniel P. Smith --- Changes since v6: - introduce local s and l refs for start and size, shortening the lines while correct

[PATCH v7 26/38] x86/boot: convert pvh_load_kernel to struct boot_module

2024-10-20 Thread Daniel P. Smith
This changes both the kernel and ramdisk parameters over to struct boot_module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- xen/arch/x86/hvm/dom0_build.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/xen/arch/x86/hvm/dom0_build

[PATCH v7 23/38] x86/boot: convert dom0_construct_pv image param to struct boot_module

2024-10-20 Thread Daniel P. Smith
This changes the type for the image parameter of dom0_construct_pv to be struct boot_module. Removing the usage of early_mod field for kernel module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v6: - removed unnecessary indentation changes Changes since v5: - rep

[PATCH v7 11/38] x86/boot: convert microcode loading to consume struct boot_info

2024-10-20 Thread Daniel P. Smith
Convert the microcode loading functions to take struct boot_info, and then using struct boot_module to map and check for microcode. To keep the changes focused, continue using the struct mod to hold the reference to the microcode that is used by the late microcode logic. To support loading the mic

[PATCH v7 30/38] x86/boot: remove remaining module_t references

2024-10-20 Thread Daniel P. Smith
Any direct usages of module_t have been transitioned, remove the remaining references to the mod field. This also removes any external use of bootstrap_map(), dropping from setup.h and making it static. Signed-off-by: Daniel P. Smith --- Changes since v6: - drop efi exclusion check for module mem

[PATCH v7 10/38] x86/boot: introduce consumed flag for struct boot_module

2024-10-20 Thread Daniel P. Smith
Allow the tracking of when a boot module has been consumed by a handler in the hypervisor independent of when it is claimed. The instances where the hypervisor does nothing beyond claiming, the dom0 kernel, dom0 ramdisk, and a placeholder for itself, are updated as being consumed at the time of bei

[PATCH v7 29/38] x86/boot: remove usage of mod_end by discard_initial_images

2024-10-20 Thread Daniel P. Smith
This eliminates usage of early_mod by discard_initial_images Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- xen/arch/x86/setup.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 87b118cdcf1e..67e72459170a 1

[PATCH v7 35/38] x86/boot: add struct domain to struct boot_domain

2024-10-20 Thread Daniel P. Smith
Store a reference to the created domain in struct boot_domain. Signed-off-by: Daniel P. Smith --- Changes since v5: - moved back to using variable *d to hold domain reference locally --- xen/arch/x86/include/asm/bootdomain.h | 3 +++ xen/arch/x86/setup.c | 4 +++- 2 files change

[PATCH v7 13/38] x86/boot: use consumed boot module flag for microcode

2024-10-20 Thread Daniel P. Smith
To track if the microcode boot module was loaded, a copy of the boot module is kept. The size element of this copy is set to zero as the indicator that the microcode was loaded. A side effect is that the modules have to be rescanned to find the boot module post-relocation, so the cache copy can be

[PATCH v7 12/38] x86/boot: convert late microcode loading to struct boot_module

2024-10-20 Thread Daniel P. Smith
Remove the use of struct mod to hold the reference for the microcode, converting the code to work with a struct boot_module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- xen/arch/x86/cpu/microcode/core.c | 29 ++--- 1 file changed, 14 insertions(+), 15 d

[PATCH v7 21/38] x86/boot: relocate kextra into boot info

2024-10-20 Thread Daniel P. Smith
Move kextra into struct boot_info, thus no longer needed to be passed as a parameter to create_dom0. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- xen/arch/x86/include/asm/bootinfo.h | 1 + xen/arch/x86/setup.c| 12 ++-- 2 files changed, 7 insertions(+),

[PATCH v7 06/38] x86/boot: introduce boot module flags

2024-10-20 Thread Daniel P. Smith
The existing startup code employs various ad-hoc state tracking about certain boot module types by each area of the code. A boot module flags bitfield is added to enable tracking these different states. The first state to be transition by this commit is module relocation. Signed-off-by: Daniel P.

[PATCH v7 08/38] x86/boot: populate boot module for xen entry

2024-10-20 Thread Daniel P. Smith
Populate the start and size fields for the Xen entry when populating them in the reserved module_t entry. Signed-off-by: Daniel P. Smith --- Changes since v6: - apply correct conversion of assignment to mod_start - rewrite commit message to reflect code change Changes since v5: - corrected conve

[PATCH v7 36/38] x86/boot: convert construct_dom0 to struct boot_domain

2024-10-20 Thread Daniel P. Smith
A struct boot_domain now encapsulates the domain reference, kernel, ramdisk, and command line for the domain being constructed. As a result of this encapsulation, construct_dom0 can now take a single struct boot_domain instead of these four parameters. Signed-off-by: Daniel P. Smith --- Changes s

[PATCH v7 38/38] x86/boot: convert dom0_construct_pvh to struct boot_domain

2024-10-20 Thread Daniel P. Smith
With construct_dom0 consuming struct boot_domain, continue passing the structure down to dom0_construct_pvh. Signed-off-by: Daniel P. Smith --- Changes since v5: - revert back to using *d as local reference for struct domain --- xen/arch/x86/dom0_build.c | 2 +- xen/arch/x86/hvm/dom0

[PATCH v7 00/38] Boot modules for Hyperlaunch

2024-10-20 Thread Daniel P. Smith
The Boot Modules for Hyperlaunch series is an effort to split out preliminary changes necessary for the introduction of the Hyperlaunch domain builder logic. These preliminary changes revolve around introducing the struct boot_module and struct boot_domain structures. This includes converting the d

[PATCH v7 33/38] x86/boot: introduce domid field to struct boot_domain

2024-10-20 Thread Daniel P. Smith
Add a domid field to struct boot_domain to hold the assigned domain id for the domain. During initialization, ensure all instances of struct boot_domain have the invalid domid to ensure that the domid must be set either by convention or configuration. Signed-off-by: Daniel P. Smith Reviewed-by: J

[PATCH v7 31/38] x86/boot: remove mod from struct boot_module

2024-10-20 Thread Daniel P. Smith
With all references to mod field removed, remove the mod field from struct boot_module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- xen/arch/x86/include/asm/bootinfo.h | 4 xen/arch/x86/setup.c| 3 --- 2 files changed, 7 deletions(-) diff --git a/xen/arch

[PATCH v7 32/38] x86/boot: introduce boot domain

2024-10-20 Thread Daniel P. Smith
To begin moving toward allowing the hypervisor to construct more than one domain at boot, a container is needed for a domain's build information. Introduce a new header, , that contains the initial struct boot_domain that encapsulate the build information for a domain. No functional change intend

[PATCH v7 34/38] x86/boot: add cmdline to struct boot_domain

2024-10-20 Thread Daniel P. Smith
Add a container for the "cooked" command line for a domain. Signed-off-by: Daniel P. Smith --- xen/arch/x86/include/asm/bootdomain.h | 4 xen/arch/x86/setup.c | 18 -- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/xen/arch/x86/include/asm

[PATCH v7 20/38] x86/boot: convert construct_dom0 to use struct boot_module

2024-10-20 Thread Daniel P. Smith
The construct_dom0 function is converted to consume struct boot_module instances for the kernel and ramdisk. With this change, it is no longer necessary for the internal use of struct mod by create_dom0, so they are changed to struct boot_module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason

[PATCH v7 17/38] x86/boot: remove module_map usage from xsm policy loading

2024-10-20 Thread Daniel P. Smith
Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v5: - adjust comment to coding style --- xen/arch/x86/setup.c | 2 +- xen/include/xsm/xsm.h | 9 +++-- xen/xsm/xsm_core.c| 6 ++ xen/xsm/xsm_policy.c | 4 +--- 4 files changed, 7 insertions(+), 14 deletions

[PATCH v7 18/38] x86/boot: remove module_map usage by ramdisk loading

2024-10-20 Thread Daniel P. Smith
The ramdisk loading is the last user of module_map, remove its usage and any remaining remnants of module_map. Signed-off-by: Daniel P. Smith --- Changes since v5: - set excessive module check down to MAX_NR_BOOTMODS --- xen/arch/x86/setup.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletion

[PATCH v7 15/38] x86/boot: convert ramdisk locating to struct boot_module

2024-10-20 Thread Daniel P. Smith
Locate the first unclaimed struct boot_module and mark it as ramdisk. If there are any remaining unclaimed struct boot_module instances, report to the console. In the change, the new boot module iterator is used to find the initrd index, which returns a signed int. Switch initrdidx from unsigned to

[PATCH v7 14/38] x86/boot: convert xsm policy loading to struct boot_module

2024-10-20 Thread Daniel P. Smith
Iterate through the unclaimed boot modules to see if any are an XSM FLASK policy. If one is located, mark it as an xsm policy. To assist with looking up the index of the xsm policy in the boot module array, an iterator is provided. Signed-off-by: Daniel P. Smith --- Changes since v6: - converted

[PATCH v7 04/38] x86/boot: convert mod refs to boot_module mod

2024-10-20 Thread Daniel P. Smith
To allow a slow conversion of x86 over to struct boot_module, start with replacing all references to module_t mod, only in setup.c, to the mod element of struct boot_module. These serves twofold, first to allow the incremental transition from module_t fields to struct boot_module fields. The second

[PATCH v7 03/38] x86/boot: move headroom to boot modules

2024-10-20 Thread Daniel P. Smith
The purpose of struct boot_module is to encapsulate the state of boot module as it is processed by Xen. Locating boot module state struct boot_module reduces the number of global variables as well as the number of state variables that must be passed around. It also lays the groundwork for hyperlaun

[PATCH v7 01/38] x86/boot: introduce struct boot_module

2024-10-20 Thread Daniel P. Smith
This will introduce a new struct boot_module to provide a rich state representation around modules provided by the boot loader. Support is for 64 boot modules, one held in reserve for Xen, and up to 63 can be provided by the boot loader. The array of struct boot_modules will be accessible via a ref

[PATCH v7 05/38] x86/boot: introduce boot module types

2024-10-20 Thread Daniel P. Smith
This commit introduces module types of xen, kernel, and ramdisk to allow boot module detect code to tag the purpose of a boot module. This reduces the need for hard coded order assumptions and global variables to be used by consumers of boot modules, such as domain construction. Signed-off-by: Dan

[PATCH v7 02/38] x86/boot: convert consider_modules to struct boot_module

2024-10-20 Thread Daniel P. Smith
To start transitioning consider_modules() over to struct boot_module, begin with taking the array of struct boot_modules but use the temporary struct element mod. No functional change intended. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v5: - drop unnecessary ty

Re: [GIT PULL] xen: branch for v6.12-rc4

2024-10-20 Thread pr-tracker-bot
The pull request you sent on Sun, 20 Oct 2024 12:05:33 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-6.12a-rc4-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a5ee44c8297803efd36cd0c773d72687afdd7500 Thank you! -- Deet-doot-dot,

[xen-unstable test] 188309: tolerable FAIL

2024-10-20 Thread osstest service owner
flight 188309 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/188309/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-qcow220 leak-check/check fail in 188308 pass in 188309 test-armhf-armhf-xl-arndale 10

[GIT PULL] xen: branch for v6.12-rc4

2024-10-20 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.12a-rc4-tag xen: branch for v6.12-rc4 It contains just a single fix for a build failure introduced with a patch in the 6.12 merge window. Thanks. Juergen drivers/xen/Kconfig