Re: [PATCH v5 3/4] SUPPORT.md: Add entry for guest PSCI SYSTEM_SUSPEND support

2025-06-28 Thread Julien Grall
Hi Mykola, On 27/06/2025 11:51, Mykola Kvach wrote: From: Mykola Kvach Document support for the optional PSCI SYSTEM_SUSPEND function, exposed via the virtual PSCI (vPSCI) interface to guests. This allows non-hardware domain guests (domUs) to initiate system suspend operations via PSCI calls.

Re: [PATCH v5 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests

2025-06-28 Thread Julien Grall
Hi Mykola, On 27/06/2025 11:51, Mykola Kvach wrote: diff --git a/xen/arch/arm/include/asm/perfc_defn.h b/xen/arch/arm/include/asm/perfc_defn.h index effd25b69e..8dfcac7e3b 100644 --- a/xen/arch/arm/include/asm/perfc_defn.h +++ b/xen/arch/arm/include/asm/perfc_defn.h @@ -33,6 +33,7 @@ PERFCOUNTE

Re: [RFC PATCH 4/4] xen/arm: Implement standard PV time interface as per ARM DEN 0057A

2025-06-28 Thread Julien Grall
Hi, On 28/06/2025 14:58, Koichiro Den wrote: On Mon, Jun 23, 2025 at 09:41:47AM +0100, Julien Grall wrote: ---(snip)--- @@ -707,6 +723,7 @@ int arch_domain_create(struct domain *d, unsigned int flags) { unsigned int count = 0; +int order; int rc;

Re: [PATCH v3 2/2] xen/console: unify printout behavior for UART emulators

2025-06-28 Thread Julien Grall
On 28/06/2025 18:26, Julien Grall wrote: Hi Stefano, On 21/06/2025 01:52, Stefano Stabellini wrote: Widely used or not - _I_ use it all the time in debug configs where serial is available. Fair enough and your usage is really important for the project. At the same time you know exactly what'

Re: [PATCH v3 2/2] xen/console: unify printout behavior for UART emulators

2025-06-28 Thread Julien Grall
Hi Stefano, On 21/06/2025 01:52, Stefano Stabellini wrote: Widely used or not - _I_ use it all the time in debug configs where serial is available. Fair enough and your usage is really important for the project. At the same time you know exactly what's going on so you wouldn't be confused by t

Re: [RFC PATCH 3/4] xen/arm: Move make_resv_memory_node()

2025-06-28 Thread Koichiro Den
On Sun, Jun 22, 2025 at 04:12:15PM -0700, Stefano Stabellini wrote: > On Sun, 22 Jun 2025, Koichiro Den wrote: > > The /reserved-memory node is inherently not specific to static-shmem. In > > the next commit, child nodes will be added under /reserved-memory for > > the stolen time shared memory reg

Re: [RFC PATCH 2/4] xen/arm: Move make_hypervisor_node()

2025-06-28 Thread Koichiro Den
On Mon, Jun 23, 2025 at 03:40:24PM +0200, Orzel, Michal wrote: > > > On 21/06/2025 17:11, Koichiro Den wrote: > > Even though make_hypervisor_node() does not rely on the /reserved-memory > > instantiation when calling find_unused_regions() (the wrapper introduced > > in the previous commit), the

Re: [RFC PATCH 1/4] xen/arm: Add wrapper find_unused_regions

2025-06-28 Thread Koichiro Den
On Mon, Jun 23, 2025 at 03:33:55PM +0200, Orzel, Michal wrote: > Thank you for the review + apologies for my delayed response. > > On 21/06/2025 17:11, Koichiro Den wrote: > > This is preparatory work for the upcoming commits that implement the > > standard PV time interface (ARM DEN 0057A). >

Re: [RFC PATCH 4/4] xen/arm: Implement standard PV time interface as per ARM DEN 0057A

2025-06-28 Thread Koichiro Den
On Mon, Jun 23, 2025 at 09:41:47AM +0100, Julien Grall wrote: > Hi Koichiro, > > I haven't checked all the details. I will mainly comment on the Xen > internals. Hi Julien, Thank you for the review, and apologies for my late response. > ---(snip)--- > > @@ -707,6 +723,7 @@ int arch_domain_crea