Re: [PATCH v2 1/3] vpci: allow queueing of mapping operations

2025-08-01 Thread Stewart Hildebrand
On 7/25/25 03:58, Roger Pau Monné wrote: > On Thu, Jul 24, 2025 at 06:44:32PM +0200, Roger Pau Monné wrote: >> On Wed, Jul 23, 2025 at 12:37:41PM -0400, Stewart Hildebrand wrote: >>> @@ -283,7 +297,48 @@ static int __init apply_map(struct domain *d, const >>> struct pci_dev *pdev, >>> return

[PATCH v2] xen: rework error handling in vcpu_create

2025-08-01 Thread Stewart Hildebrand
In vcpu_create after scheduler data is allocated, if vmtrace_alloc_buffer fails, it will jump to the wrong cleanup label resulting in a memory leak. Move sched_destroy_vcpu and destroy_waitqueue_vcpu to vcpu_teardown. Make vcpu_teardown idempotent: deal with NULL unit. Fix vcpu_runstate_get (call

Re: [PATCH v1 12/16] xen/domain: introduce domain-emu.h

2025-08-01 Thread dmkhn
On Fri, Aug 01, 2025 at 08:02:56AM +0200, Jan Beulich wrote: > On 31.07.2025 22:55, dm...@proton.me wrote: > > On Wed, Jul 09, 2025 at 04:57:44PM +0200, Jan Beulich wrote: > >> On 24.06.2025 05:56, dm...@proton.me wrote: > >>> @@ -458,16 +459,16 @@ struct arch_domain > >>> } __cacheline_aligned; >

Re: [XEN][PATCH 0/3] xen/arch: irq: drop unreachable pirq callbacks

2025-08-01 Thread dmkhn
On Fri, Aug 01, 2025 at 10:08:54AM +, Grygorii Strashko wrote: > From: Grygorii Strashko > > Hence prerequisite patch was merged [1] arch specific pIRQ callback can now > be dropped for arches without pIRQ support as those callback become > unreachable. > > [1] commit 341f271cf86f ("xen/evt

Re: [XEN][PATCH] xen/dom0less: arm: fix hwdom 1:1 low memory allocation

2025-08-01 Thread dmkhn
On Fri, Aug 01, 2025 at 03:54:30PM +, Grygorii Strashko wrote: > From: Grygorii Strashko > > Call stack for dom0less hwdom case (1:1) memory: > create_domUs > |-construct_domU > |-construct_hwdom() > |-allocate_memory_11() > > And allocate_memory_11() uses "dom0_mem" as: > min_low_orde

Re: [PATCH] console: make printk_ratelimit_{burst,ms} const

2025-08-01 Thread dmkhn
On Fri, Aug 01, 2025 at 09:30:34AM +0200, Jan Beulich wrote: > Them not being altered by any means, their __read_mostly attribute is > actually counter-productive: It causes the compiler to instantiate the > variables, when already with just the attributes dropped the compiler > can constant-propag

Re: Console vs serial

2025-08-01 Thread dmkhn
On Fri, Aug 01, 2025 at 12:44:57PM +0100, Frediano Ziglio wrote: > On Fri, Aug 1, 2025 at 12:25 PM Andrew Cooper > wrote: > > > > Hello, > > > > There's a long-standing irritation in Xen, whereby printk()'s which > > occur prior to console_init_preirq() get half-lost. > > > > They end up in the c

[XEN][PATCH] xen/dom0less: arm: fix hwdom 1:1 low memory allocation

2025-08-01 Thread Grygorii Strashko
From: Grygorii Strashko Call stack for dom0less hwdom case (1:1) memory: create_domUs |-construct_domU |-construct_hwdom() |-allocate_memory_11() And allocate_memory_11() uses "dom0_mem" as: min_low_order = get_order_from_bytes(min_t(paddr_t, dom0_mem, MB(128))); In case of dom0less boo

Re: [RESEND PATCH v3 1/1] kern/xen: Add Xen command line parsing

2025-08-01 Thread Daniel Kiper
On Fri, Jul 25, 2025 at 03:31:12PM -0500, Aaron Rainbolt wrote: > Xen traditionally allows customizing guest behavior by passing arguments > to the VM kernel via the kernel command line. This is no longer possible > when using GRUB with Xen, as the kernel command line is decided by the > GRUB confi

Re: Console vs serial

2025-08-01 Thread Frediano Ziglio
On Fri, Aug 1, 2025 at 12:25 PM Andrew Cooper wrote: > > Hello, > > There's a long-standing irritation in Xen, whereby printk()'s which > occur prior to console_init_preirq() get half-lost. > > They end up in the console ring, and hence are available via `xl dmesg`, > but they're missing from seri

Console vs serial

2025-08-01 Thread Andrew Cooper
Hello, There's a long-standing irritation in Xen, whereby printk()'s which occur prior to console_init_preirq() get half-lost. They end up in the console ring, and hence are available via `xl dmesg`, but they're missing from serial console. e.g. these 4 lines don't escape     (XEN) Enabling loc

Re: [PATCH v4] misra: allow discarding 'noreturn' during conversions

2025-08-01 Thread Dmytro Prokopchuk1
On 8/1/25 13:53, Jan Beulich wrote: > On 01.08.2025 12:48, Dmytro Prokopchuk1 wrote: >> The conversion from a function pointer with the 'noreturn' attribute >> ('void noreturn (*)(...)') to a function pointer type ('void (*)(...)' >> causes type incompatibility according to MISRA C Rule 11.1, whi

Re: [PATCH v4] misra: allow discarding 'noreturn' during conversions

2025-08-01 Thread Nicola Vetrini
On 2025-08-01 12:53, Jan Beulich wrote: On 01.08.2025 12:48, Dmytro Prokopchuk1 wrote: The conversion from a function pointer with the 'noreturn' attribute ('void noreturn (*)(...)') to a function pointer type ('void (*)(...)' causes type incompatibility according to MISRA C Rule 11.1, which for

Re: [PATCH v4] misra: allow discarding 'noreturn' during conversions

2025-08-01 Thread Jan Beulich
On 01.08.2025 12:48, Dmytro Prokopchuk1 wrote: > The conversion from a function pointer with the 'noreturn' attribute > ('void noreturn (*)(...)') to a function pointer type ('void (*)(...)' > causes type incompatibility according to MISRA C Rule 11.1, which > forbids conversions between incompatib

[PATCH v4] misra: allow discarding 'noreturn' during conversions

2025-08-01 Thread Dmytro Prokopchuk1
The conversion from a function pointer with the 'noreturn' attribute ('void noreturn (*)(...)') to a function pointer type ('void (*)(...)' causes type incompatibility according to MISRA C Rule 11.1, which forbids conversions between incompatible function pointer types. The violation occurs at the

Re: [XEN][PATCH 0/3] xen/arch: irq: drop unreachable pirq callbacks

2025-08-01 Thread Andrew Cooper
On 01/08/2025 11:08 am, Grygorii Strashko wrote: > From: Grygorii Strashko > > Hence prerequisite patch was merged [1] arch specific pIRQ callback can now > be dropped for arches without pIRQ support as those callback become > unreachable. > > [1] commit 341f271cf86f ("xen/evtchn: fully restrict

[XEN][PATCH 0/3] xen/arch: irq: drop unreachable pirq callbacks

2025-08-01 Thread Grygorii Strashko
From: Grygorii Strashko Hence prerequisite patch was merged [1] arch specific pIRQ callback can now be dropped for arches without pIRQ support as those callback become unreachable. [1] commit 341f271cf86f ("xen/evtchn: fully restrict concept of pIRQ for arches with pIRQ support only") Grygorii

[XEN][PATCH 2/3] xen/ppc: irq: drop unreachable pirq callbacks

2025-08-01 Thread Grygorii Strashko
From: Grygorii Strashko Hence all common pIRQ code is under CONFIG_HAS_PIRQ idefs corresponding PPC arch pIRQ callbacks become unreachable, so drop them. Signed-off-by: Grygorii Strashko --- xen/arch/ppc/stubs.c | 20 1 file changed, 20 deletions(-) diff --git a/xen/arch/

[XEN][PATCH 3/3] xen/riscv: irq: drop unreachable pirq callbacks

2025-08-01 Thread Grygorii Strashko
From: Grygorii Strashko Hence all common pIRQ code is under CONFIG_HAS_PIRQ idefs corresponding RISCV arch pIRQ callbacks become unreachable, so drop them. Signed-off-by: Grygorii Strashko --- xen/arch/riscv/stubs.c | 20 1 file changed, 20 deletions(-) diff --git a/xen/a

[XEN][PATCH 1/3] xen/arm: irq: drop unreachable pirq callbacks

2025-08-01 Thread Grygorii Strashko
From: Grygorii Strashko Hence all common pIRQ code is under CONFIG_HAS_PIRQ idefs corresponding Arm arch pIRQ callbacks become unreachable, so drop them. Signed-off-by: Grygorii Strashko --- xen/arch/arm/irq.c | 29 - 1 file changed, 29 deletions(-) diff --git a/xe

Re: [RFC PATCH v1 06/10] arch-x86/pmu.h: convert ascii art diagram to Unicode

2025-08-01 Thread Edwin Torok
On Thu, Jul 31, 2025 at 4:35 PM Jan Beulich wrote: > > On 25.07.2025 17:06, Edwin Török wrote: > > Using `aa2u` tool. > > > > Signed-off-by: Edwin Török > > How come the use of that tool made ... > > > --- a/xen/include/public/arch-x86/pmu.h > > +++ b/xen/include/public/arch-x86/pmu.h > > @@ -75,

[PATCH v1 2/3] xen/pci: modify pci_add_device to handle device add by Xen

2025-08-01 Thread Mykyta Poturai
From: Luca Fancellu Currently pci_add_device is called from hypercalls requested by Dom0 to add pci devices and when the device has no domain associated with it, it is assumed that hardware_domain is the owner. On the dom0less scenario, the enumeration is performed by the firmware and Xen at boo

[PATCH v1 0/3] dom0less pci passthrough support on Arm part 1

2025-08-01 Thread Mykyta Poturai
This series adds basic PCI device enumeration in Xen. This will allow us to not rely on Dom0 enumeration for supported controllers, which will enable PCI passthrough for dom0less setups. Enumeration is disabled by default and can be enabled with "pci-scan" cmdline option. Discovered devices are ad

[PATCH v1 3/3] xen/pci: add discovered PCI device at boot

2025-08-01 Thread Mykyta Poturai
From: Luca Fancellu Create add_discovered_pci_devices function that calls pci_device_add on every PCI device discovered. The devices will be added to dom_io so that they can be assigned later to other domains. Signed-off-by: Luca Fancellu Signed-off-by: Mykyta Poturai --- (cherry picked from c

[PATCH v1 1/3] arm/pci: Add pci-scan boot argument

2025-08-01 Thread Mykyta Poturai
From: Edward Pickup This patch adds a Xen boot arguments that, if enabled, causes a call to existing code to scan pci devices enumerated by the firmware. This patch also makes an existing debug function viewable outside its translation unit, and uses this to dump the PCI devices found. The debug

Re: [PATCH] ns16550: ensure polling timer is disarmed

2025-08-01 Thread Jan Beulich
On 31.07.2025 23:42, dm...@proton.me wrote: > On Thu, Jul 31, 2025 at 08:54:10AM +0200, Jan Beulich wrote: >> On 30.07.2025 20:31, dm...@proton.me wrote: >>> On Wed, Jul 30, 2025 at 10:12:54AM +0200, Jan Beulich wrote: On 30.07.2025 05:13, dm...@proton.me wrote: > From: Denis Mukhin >

Re: [PATCH v1] xen/console: remove __printk_ratelimit()

2025-08-01 Thread Jan Beulich
On 31.07.2025 23:28, dm...@proton.me wrote: > On Thu, Jul 31, 2025 at 08:23:16AM +0200, Jan Beulich wrote: >> On 30.07.2025 20:06, dm...@proton.me wrote: >>> On Wed, Jul 30, 2025 at 07:35:04AM +0200, Jan Beulich wrote: On 30.07.2025 00:18, dm...@proton.me wrote: > On Mon, Jul 28, 2025 at 1

[PATCH] console: make printk_ratelimit_{burst,ms} const

2025-08-01 Thread Jan Beulich
Them not being altered by any means, their __read_mostly attribute is actually counter-productive: It causes the compiler to instantiate the variables, when already with just the attributes dropped the compiler can constant-propagate the values into the sole use site. Make the situation yet more ex

Re: [PATCH v7 5/6] xen/arm: ffa: Add indirect message between VM

2025-08-01 Thread Bertrand Marquis
Hi, A gentle ping for someone to review this :-) Thanks Bertrand > On 17 Jul 2025, at 14:11, Bertrand Marquis wrote: > > Add support for indirect messages between VMs. > This is only enabled if CONFIG_FFA_VM_TO_VM is selected. > > Signed-off-by: Bertrand Marquis > Reviewed-by: Jens Wiklander

Re: [PATCH v7 6/6] xen/arm: ffa: Enable VM to VM without firmware

2025-08-01 Thread Bertrand Marquis
Hi, A gentle ping for someone to review this :-) Thanks Bertrand > On 17 Jul 2025, at 14:11, Bertrand Marquis wrote: > > When VM to VM support is activated and there is no suitable FF-A support > in the firmware, enable FF-A support for VMs to allow using it for VM to > VM communications. > If

Re: [PATCH v7 3/6] xen/arm: ffa: Introduce VM to VM support

2025-08-01 Thread Bertrand Marquis
Hi, A gentle ping for someone to review this :-) Thanks Bertrand > On 17 Jul 2025, at 14:11, Bertrand Marquis wrote: > > Create a CONFIG_FFA_VM_TO_VM parameter to activate FFA communication > between VMs. > When activated list VMs in the system with FF-A support in part_info_get. > > When VM