Re: [PATCH] xen/domctl: Fix double domid_free in XEN_DOMCTL_createdomain error path

2025-09-13 Thread Demi Marie Obenour
On 9/13/25 07:56, Andrew Cooper wrote: > On 13/09/2025 11:44 am, Oleksii Moisieiev wrote: >> Remove redundant domid_free() call in the XEN_DOMCTL_createdomain error >> handling path to prevent a double-free condition. >> >> When domain_create() fails, it internally calls _domain_destroy() during >>

Re: [PATCH v9 1/4] xen/arm: add generic SCI subsystem

2025-09-13 Thread Oleksii Kurochko
On 9/12/25 11:38 PM, Julien Grall wrote: (+ Release manager) On 10/09/2025 15:49, Oleksii Moisieiev wrote: Hi Julien, Thank you for your observations. You're absolutely right about this. Currently, the sci_relinquish_resources call doesn't perform any operations because the single-agent do

Re: [PATCH v4 1/8] CI: Use the Debian Trixie container for RISC-V test jobs

2025-09-13 Thread Oleksii Kurochko
On 9/12/25 4:44 PM, Andrew Cooper wrote: This was missed when introducing Trixie. Fixes: aad6ebf0596f ("CI: Update riscv64 to use Debian Trixie") Signed-off-by: Andrew Cooper Reviewed-by: Denis Mukhin Reviewed-by: Oleksii Kurochko ~ Oleksii --- CC: Anthony PERARD CC: Michal Orzel CC: Jan

Re: [PATCH][for-4.21] xen/arm: Reorder SCI resource cleanup in domain destruction

2025-09-13 Thread Oleksii Kurochko
On 9/13/25 12:30 PM, Oleksii Moisieiev wrote: Move the SCI (System Control and Management Interface) resource cleanup earlier in the domain_relinquish_resources() sequence to ensure proper cleanup ordering during domain destruction. The SCI cleanup is now performed before TEE (Trusted Execution

Re: [PATCH v4 1/2] efi: Add a function to check if Secure Boot mode is enabled

2025-09-13 Thread Gerald Elder-Vass
>> + size == 1 && data == 0) ) > >... any reason it's literal 1 here? The size variable is also used as output from GetVariable and we should verify that the size of the returned data is as expected, it is simply one byte so probably not worth defining any macros to make it clearer *Ger

[PATCH v4 6/8] CI: Use pipefail in scripts/build

2025-09-13 Thread Andrew Cooper
Marek noticed that some builds were failing with: + cd dist/install + find + cpio -R 0:0 -o -H newc ./automation/scripts/build: line 111: cpio: command not found + gzip but succeeding overall, and producing a zero length xen-tools.cpio.gz as an artefact. In fact, it's all of: archli

Re: [PATCH v2 04/26] xen: consolidate CONFIG_VM_EVENT

2025-09-13 Thread Tamas K Lengyel
> > @@ -99,10 +98,40 @@ long p2m_set_mem_access_multi(struct domain *d, > > int p2m_get_mem_access(struct domain *d, gfn_t gfn, xenmem_access_t > > *access, > > unsigned int altp2m_idx); > > > > -#ifdef CONFIG_VM_EVENT > > int mem_access_memop(unsigned long cmd, > >

Re: [PATCH] xen/vm_event: introduce vm_event_is_enabled()

2025-09-13 Thread Tamas K Lengyel
> > +static inline bool vm_event_is_enabled(struct vcpu *v) > > +{ > > +#ifdef CONFIG_VM_EVENT > > +return v->arch.vm_event != NULL; > > Is "enabled" (in the function name) a good description of this condition, > Tamas? Sure, sounds fine to me. Tamas

Re: [PATCH v7 01/16] emul/vuart: introduce framework for UART emulators

2025-09-13 Thread dmukhin
On Wed, Sep 10, 2025 at 10:57:14AM +0300, Mykola Kvach wrote: > > +int vuart_init(struct domain *d, const struct vuart_info *info) > > +{ > > +const struct vuart_emulator *emulator; > > +struct vuart *vuart; > > +int rc; > > + > > +if ( d->console.vuart ) > > +return -EBUSY;

Re: [PATCH v2 2/7] mm: introduce local state for lazy_mmu sections

2025-09-13 Thread Kevin Brodsky
On 09/09/2025 16:38, Alexander Gordeev wrote: > Would that integrate well with LAZY_MMU_DEFAULT etc? Hmm... I though the idea is to use LAZY_MMU_* by architectures that want to use it - at least that is how I read the description above. It is only kasan_populate|depopulate_v

Re: [PATCH v7 02/16] xen/8250-uart: update definitions

2025-09-13 Thread dmukhin
On Wed, Sep 10, 2025 at 11:39:07AM +0300, Mykola Kvach wrote: > > > +#define UART_IER_MASK \ > > > +(UART_IER_ERDAI | UART_IER_ETHREI | UART_IER_ELSI | UART_IER_EMSI) > > > > Here, aiui, ..._MASK covers all known bits. No #define-s for reserved > > ones. > > I think we can follow the Linux ker

Re: [PATCH v7 03/16] emul/ns16x50: implement emulator stub

2025-09-13 Thread dmukhin
On Wed, Sep 10, 2025 at 01:05:13PM +0300, Mykola Kvach wrote: [..] > > > > +/* Enable NS16550 emulator for certain domain only. */ > > +static int __read_mostly opt_vuart_domid = -1; > > Should opt_vuart_domid be initialized to DOMID_INVALID instead of -1? > Using the standard DOMID_INVALID consta

Re: [PATCH] xen/domctl: Fix double domid_free in XEN_DOMCTL_createdomain error path

2025-09-13 Thread dmukhin
On Sat, Sep 13, 2025 at 10:44:39AM +, Oleksii Moisieiev wrote: > Remove redundant domid_free() call in the XEN_DOMCTL_createdomain error > handling path to prevent a double-free condition. > > When domain_create() fails, it internally calls _domain_destroy() during > its cleanup routine, which

Re: [PATCH][for-4.21] xen/arm: Reorder SCI resource cleanup in domain destruction

2025-09-13 Thread Oleksandr Tyshchenko
On Sat, Sep 13, 2025 at 1:31 PM Oleksii Moisieiev < oleksii_moisie...@epam.com> wrote: Hello Oleksii Move the SCI (System Control and Management Interface) resource cleanup > earlier in the domain_relinquish_resources() sequence to ensure proper > cleanup ordering during domain destruction. > > T

Re: [PATCH][for-4.21] xen/arm: Reorder SCI resource cleanup in domain destruction

2025-09-13 Thread Andrew Cooper
On 13/09/2025 3:07 pm, Oleksandr Tyshchenko wrote: > > > On Sat, Sep 13, 2025 at 1:31 PM Oleksii Moisieiev > wrote: > > Hello Oleksii > > Move the SCI (System Control and Management Interface) resource > cleanup > earlier in the domain_relinquish_resources() sequence to ensure proper >

[PATCH][for-4.21] xen/arm: Reorder SCI resource cleanup in domain destruction

2025-09-13 Thread Oleksii Moisieiev
Move the SCI (System Control and Management Interface) resource cleanup earlier in the domain_relinquish_resources() sequence to ensure proper cleanup ordering during domain destruction. The SCI cleanup is now performed before TEE (Trusted Execution Environment) cleanup rather than after P2M mappi

Re: [PATCH] xen/domctl: Fix double domid_free in XEN_DOMCTL_createdomain error path

2025-09-13 Thread Andrew Cooper
On 13/09/2025 11:44 am, Oleksii Moisieiev wrote: > Remove redundant domid_free() call in the XEN_DOMCTL_createdomain error > handling path to prevent a double-free condition. > > When domain_create() fails, it internally calls _domain_destroy() during > its cleanup routine, which already invokes do

[PATCH] xen/domctl: Fix double domid_free in XEN_DOMCTL_createdomain error path

2025-09-13 Thread Oleksii Moisieiev
Remove redundant domid_free() call in the XEN_DOMCTL_createdomain error handling path to prevent a double-free condition. When domain_create() fails, it internally calls _domain_destroy() during its cleanup routine, which already invokes domid_free() to release the allocated domain ID. The additio

[PATCH v2 16/26] xen/domctl: wrap arch-specific domain_set_time_offset() with CONFIG_MGMT_HYPERCALLS

2025-09-13 Thread Penny Zheng
Arch-specific domain_set_time_offset() is responisble for XEN_DOMCTL_settimeoffset domctl-op, and shall be wrapped with CONFIG_MGMT_HYPERCALLS Wrap XEN_DOMCTL_settimeoffset-case transiently with CONFIG_MGMT_HYPERCALLS, and it will be removed when introducing CONFIG_MGMT_HYPERCALLS on the common/dom

[PATCH v2 12/26] xen/domctl: wrap vcpu_affinity_domctl() with CONFIG_MGMT_HYPERCALLS

2025-09-13 Thread Penny Zheng
Function vcpu_affinity_domctl() is responsible for XEN_DOMCTL_{getvcpuaffinity,setvcpuaffinity} domctl-op, and shall be wrapped with CONFIG_MGMT_HYPERCALLS. Tracking its calling chain, the following function shall be wrapped with CONFIG_MGMT_HYPERCALLS too: - vcpu_set_soft_affinity Wrap XEN_DOMCTL_

Re: [PATCH v2 2/7] mm: introduce local state for lazy_mmu sections

2025-09-13 Thread Kevin Brodsky
On 12/09/2025 16:25, David Hildenbrand wrote: > >> >> But I do not really expect it ever, since arch_enter_lazy_mmu_mode_pte() >> is only to be called in PTE walkers that never span more than one page >> table and follow the pattern: > > Well, the cover letter here states: > > "Unfortunately, a cor

Re: [PATCH v9 1/4] xen/arm: add generic SCI subsystem

2025-09-13 Thread Julien Grall
(+ Release manager) On 10/09/2025 15:49, Oleksii Moisieiev wrote: Hi Julien, Thank you for your observations. You're absolutely right about this. Currently, the sci_relinquish_resources call doesn't perform any operations because the single-agent doesn't implement a callback. I'll move the sc

Re: [PATCH v3 8/9] SUPPORT.md: add xenstorepvh-stubdom live update

2025-09-13 Thread Jürgen Groß
On 12.09.25 23:09, Julien Grall wrote: Hi Juergen, Sorry for the late answer. On 30/07/2025 13:23, Juergen Gross wrote: Live update is now working with the PVH variant of xenstore-stubdom. > > Signed-off-by: Juergen Gross --- V2: - new patch ---   SUPPORT.md | 2 +-   1 file changed, 1 inse