Re: [Xen-devel] [PATCH v8 01/10] error: auto propagated local_err

2020-03-06 Thread Alberto Garcia
On Fri 06 Mar 2020 06:15:27 AM CET, Vladimir Sementsov-Ogievskiy wrote: Sorry I just gave a quick look at these patches and noticed this: > + * Function may use error system to return errors. In this case function > + * defines Error **errp parameter, which should be the last one (except for > +

Re: [Xen-devel] [PATCH] chardev: Convert IOReadHandler to read an unsigned number of bytes

2018-10-11 Thread Alberto Garcia
return ch->rx_enabled ? available_bytes : 0; > } > > -static void hostdev_receive(void *opaque, const uint8_t *buf, int size) > +static void hostdev_receive(void *opaque, const uint8_t *buf, size_t size) > { > SCC2698Channel *ch = opaque; >