Re: [Xen-devel] [PATCH 2/5] tools/firmware: #define IPXE_PATH

2018-03-26 Thread Anoob Soman
On 21/03/18 15:18, Wei Liu wrote: On Thu, Mar 15, 2018 at 05:31:50PM +, Anoob Soman wrote: --with-system-ipxe allows the user to specify ipxe rom. If this option is given, use system supplied ipxe instead of building and installing our own version Plumbing for using iPXE roms, specified

Re: [Xen-devel] [PATCH 4/5] libxl: Load iPXE ROM from a file

2018-03-26 Thread Anoob Soman
On 21/03/18 15:25, Wei Liu wrote: +LOGE(ERROR, "xc_dom_kernel_file failed"); +goto out; +} +if ((ipxe_filename = libxl__ipxe_path())) { +rc = xc_dom_module_file(dom, ipxe_filename, "ipxe"); +if (rc) { +LOGE(ERROR, "

Re: [Xen-devel] [PATCH 3/5] libxc: Allow loading of firmware modules for HVM guest

2018-03-26 Thread Anoob Soman
On 21/03/18 15:17, Wei Liu wrote: On Thu, Mar 15, 2018 at 05:31:51PM +, Anoob Soman wrote: modlist, start_info); +for ( i = 0; i < dom->num_modules; i++ ) +{ +struct xc_hvm_firmware_module mod; + +DOMPRINTF("Ad

Re: [Xen-devel] [PATCH 3/5] libxc: Allow loading of firmware modules for HVM guest

2018-03-19 Thread Anoob Soman
On 18/03/18 01:32, Doug Goldstein wrote: On 3/15/18 12:31 PM, Anoob Soman wrote: This allows to load iPXE rom as a firmware module, instead of requiring it to be embedded into hvmloader. Signed-off-by: Anoob Soman --- tools/libxc/xc_dom_x86.c | 13 + 1 file changed, 13

Re: [Xen-devel] [PATCH 5/5] hvmloader: Use iPXE ROM loaded from a standalone file

2018-03-19 Thread Anoob Soman
On 16/03/18 11:26, Jan Beulich wrote: +/* Physical address of iPXE ROM, loaded by domain builder + * when using ROMBIOS + */ +unsigned int *ipxe_rom_addresss; Comment style. And can the pointer be to const? I will fixup the comment style and but making ipxe_rom_address a point

[Xen-devel] [PATCH 3/5] libxc: Allow loading of firmware modules for HVM guest

2018-03-15 Thread Anoob Soman
This allows to load iPXE rom as a firmware module, instead of requiring it to be embedded into hvmloader. Signed-off-by: Anoob Soman --- tools/libxc/xc_dom_x86.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c index 0b65dab

[Xen-devel] [PATCH 4/5] libxl: Load iPXE ROM from a file

2018-03-15 Thread Anoob Soman
Load iPXE ROM from a file pointed to by IPXE_PATH. If --with-system-ipxe is not specified default Xen firmware directory is picked up as IPXE_PATH Signed-off-by: Anoob Soman --- tools/libxl/libxl_dom.c | 12 tools/libxl/libxl_internal.h | 1 + tools/libxl/libxl_paths.c

[Xen-devel] [PATCH 1/5] tools/firmware: Build ipxe as a standalone ROM

2018-03-15 Thread Anoob Soman
This patches doesn't get rid of etherboot[] from roms.inc. Instead, makes a standalone iPXE rom, which will later be used by hvmloader (when all the plubming to use standalone iPXE rom are in place) Signed-off-by: Anoob Soman --- tools/firmware/Makefile | 3 +++ tools/fir

[Xen-devel] Make iPXE a standalone ROM

2018-03-15 Thread Anoob Soman
, and allows us to edit/modify/upgrade iPXE independently of Xen. Anoob Soman (5): tools/firmware: Build ipxe as a standalone ROM tools/firmware: #define IPXE_PATH libxc: Allow loading of firmware modules for HVM guest libxl: Load iPXE ROM from a file hvmloader: Use iPXE ROM loaded from a

[Xen-devel] [PATCH 2/5] tools/firmware: #define IPXE_PATH

2018-03-15 Thread Anoob Soman
nf is needed. Signed-off-by: Anoob Soman --- config/Tools.mk.in| 2 ++ tools/configure.ac| 18 ++ tools/firmware/Makefile | 4 ++-- tools/firmware/hvmloader/Makefile | 3 +++ 4 files changed, 25 insertions(+), 2 deletions(-) diff --

[Xen-devel] [PATCH 5/5] hvmloader: Use iPXE ROM loaded from a standalone file

2018-03-15 Thread Anoob Soman
splatering of mkhex-ed etherboot inside hvmloader/rombios is removed, instead hvmloader/rombios now relies on iPXE ROM to be added,loaded as a module. Signed-off-by: Anoob Soman --- tools/firmware/hvmloader/Makefile| 7 +-- tools/firmware/hvmloader/config.h| 5 + tools