Re: [PATCH v4 0/29] block: Make blkdev_get_by_*() return handle

2023-09-27 Thread Christian Brauner
On Wed, 27 Sep 2023 11:34:07 +0200, Jan Kara wrote: > Create struct bdev_handle that contains all parameters that need to be > passed to blkdev_put() and provide bdev_open_* functions that return > this structure instead of plain bdev pointer. This will eventually allow > us to pass one more argume

Re: [PATCH v3 0/29] block: Make blkdev_get_by_*() return handle

2023-08-29 Thread Christian Brauner
> replacement) I think we can go ahead with the series as is. As you said > there will be some conflicts in btrfs and I've learned about f2fs conflicts > as well so I can rebase & repost the series on top of rc1 to make life > easier for you. That is be much appreciated. Thank you!

Re: [PATCH v2 0/29] block: Make blkdev_get_by_*() return handle

2023-08-28 Thread Christian Brauner
> So besides my last fput() worry about I think this could work and would be > probably a bit nicer than what I have. But before going and redoing the whole > series let me gather some more feedback so that we don't go back and forth. > Christoph, Christian, Jens, any opinion? I'll be a bit under

Re: [PATCH v3 0/29] block: Make blkdev_get_by_*() return handle

2023-08-25 Thread Christian Brauner
On Wed, Aug 23, 2023 at 12:48:11PM +0200, Jan Kara wrote: > Hello, > > this is a v3 of the patch series which implements the idea of > blkdev_get_by_*() > calls returning bdev_handle which is then passed to blkdev_put() [1]. This > makes the get and put calls for bdevs more obviously matching and

Re: [PATCH 07/29] xen/blkback: Convert to bdev_open_by_dev()

2023-08-25 Thread Christian Brauner
On Wed, Aug 23, 2023 at 12:48:18PM +0200, Jan Kara wrote: > Convert xen/blkback to use bdev_open_by_dev() and pass the > handle around. > > CC: xen-devel@lists.xenproject.org > Acked-by: Christoph Hellwig > Signed-off-by: Jan Kara > --- Looks good to me, Acked-by: Christian Brauner