Re: [PATCH v5 2/2] xen/x86: Livepatch: support patching CET-enhanced functions

2022-03-17 Thread Doebel, Bjoern
On 17.03.22 11:00, Jiamei Xie wrote: -Original Message- From: Xen-devel On Behalf Of Jiamei Xie Sent: 2022年3月17日 17:17 To: Ross Lagerwall ; Bjoern Doebel ; xen-devel@lists.xenproject.org Cc: Michael Kurth ; Martin Pohlack ; Roger Pau Monne ; Andrew Cooper ; Konrad Rzeszutek Wilk

Re: [PATCH 0/2] livepatch: fix handling of (some) relocations

2022-03-17 Thread Doebel, Bjoern
On 17.03.22, 12:10, "Xen-devel on behalf of Roger Pau Monne" wrote: Hello, Relocations that reference symbols that belong to sections with a size of 0 are not properly resolved, as the address of those symbols won't be resolved in the first place. Fix this by not

Re: alternatives+livepatch testing

2022-03-10 Thread Doebel, Bjoern
Hi, Hello, The recent hiccup with CET-IBT, and discovery that livepatch-build-tools have been broken for several releases, demonstrates that we do not have remotely adequate testing in place. We need to address, and ensure we don't end up in the same position again. Alternatives and

Re: [PATCH 3/3] livepatch: correctly handle altinstruction sections

2022-03-10 Thread Doebel, Bjoern
On 10.03.22 16:08, Roger Pau Monne wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. The current handling of altinstructions sections by the livepatch tools is

Re: [PATCH 2/3] livepatch: add extra efi/ objects to be ignored

2022-03-10 Thread Doebel, Bjoern
On 10.03.22 16:08, Roger Pau Monne wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. The contents of this objects is init only, and cannot be patched.

Re: [PATCH 1/3] livepatch: use basename to perform object file matching

2022-03-10 Thread Doebel, Bjoern
On 10.03.22 16:08, Roger Pau Monne wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. The changes in the Xen build logic has resulted in the compiler and objcopy

Re: [PATCH] x86/cet: Use dedicated NOP4 for cf_clobber

2022-03-09 Thread Doebel, Bjoern
On 08.03.22 15:01, Andrew Cooper wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. For livepatching, we need to look at a potentially clobbered function and

Re: [PATCH v3 2/2] xen/x86: Livepatch: support patching CET-enhanced functions

2022-03-08 Thread Doebel, Bjoern
On 08.03.22 17:01, Ross Lagerwall wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. From: Doebel, Bjoern Sent: Tuesday, March 8, 2022 3:41 PM To: Ross Lagerwall

Re: [PATCH v3 2/2] xen/x86: Livepatch: support patching CET-enhanced functions

2022-03-08 Thread Doebel, Bjoern
On 08.03.22 16:25, Ross Lagerwall wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. From: Bjoern Doebel Sent: Tuesday, March 8, 2022 10:29 AM To:

Re: [PATCH v3 2/2] xen/x86: Livepatch: support patching CET-enhanced functions

2022-03-08 Thread Doebel, Bjoern
On 08.03.22 14:06, Konrad Rzeszutek Wilk wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Tue, Mar 08, 2022 at 12:44:54PM +, Andrew Cooper wrote: On

Re: [PATCH v3 2/2] xen/x86: Livepatch: support patching CET-enhanced functions

2022-03-08 Thread Doebel, Bjoern
On 08.03.22 13:44, Andrew Cooper wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On 08/03/2022 10:29, Bjoern Doebel wrote: @@ -104,18 +122,34 @@ void noinline

Re: [PATCH v2 2/2] xen/x86: Livepatch: support patching CET-enhanced functions

2022-03-08 Thread Doebel, Bjoern
On 08.03.22 09:07, Jan Beulich wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On 07.03.2022 22:13, Bjoern Doebel wrote: @@ -159,7 +200,11 @@ void noinline

Re: [PATCH 1/1] xen/x86: Livepatch: support patching CET-enhanced functions

2022-03-07 Thread Doebel, Bjoern
Please discard this accidental copy of patch 2/2. On 07.03.22 12:53, Bjoern Doebel wrote: Xen enabled CET for supporting architectures. The control flow aspect of CET expects functions that can be called indirectly (i.e., via function pointers) to start with an ENDBR64 instruction. Otherwise a

Re: [PATCH] xen/x86: Livepatch: support patching CET-enhanced functions

2022-03-07 Thread Doebel, Bjoern
On 07.03.22 10:37, Jan Beulich wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On 07.03.2022 10:17, Bjoern Doebel wrote: Xen enabled CET for supporting

Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-02 Thread Doebel, Bjoern
On 02.03.22 15:27, Roger Pau Monne wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. Do not attempt to modify the build system if CFLAGS are not set in Rules.mk,

Re: [PATCH 3/4] livepatch: do the initial build using CROSS_COMPILE

2022-03-02 Thread Doebel, Bjoern
On 02.03.22 15:27, Roger Pau Monne wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. Setting it afterwards for further builds will cause the build logic to detect a

Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-02 Thread Doebel, Bjoern
On 02.03.22 15:27, Roger Pau Monne wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. Do not attempt to modify the build system if CFLAGS are not set in Rules.mk, and

Re: [PATCH 2/4] livepatch: improve rune for fetching of Build ID

2022-03-02 Thread Doebel, Bjoern
The current one is broken with my version of readelf and returns 'NT_GNU_BUILD_ID'. Signed-off-by: Roger Pau Monné --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b48a3df..948a7de 100644 ---

Re: [PATCH 1/4] livepatch: update readme to mention --xen-depends

2022-03-02 Thread Doebel, Bjoern
Fixes: b19df7b2c05e ('livepatch-build: Embed hypervisor build id into every hotpatch') Signed-off-by: Roger Pau Monné --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 653c624..b48a3df 100644 ---