[PATCH v2] x86/xen/time: Reduce Xen timer tick

2024-06-19 Thread Frediano Ziglio
of VCPU_SSHOTTMR_future in Linux kernel was removed by: c06b6d70feb3 xen/x86: don't lose event interrupts Signed-off-by: Frediano Ziglio --- arch/x86/xen/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Changes since v1: - Update commit message; - reduce delay. diff --git a/arch/x86/xen/time.c

Re: [PATCH] x86/xen/time: Reduce Xen timer tick

2024-06-18 Thread Frediano Ziglio
On Mon, Jun 17, 2024 at 3:37 PM Roger Pau Monné wrote: > > On Mon, Jun 17, 2024 at 04:22:21PM +0200, Jan Beulich wrote: > > On 17.06.2024 16:13, Frediano Ziglio wrote: > > > Current timer tick is causing some deadline to fail. > > > The current high value const

[PATCH] x86/xen/time: Reduce Xen timer tick

2024-06-17 Thread Frediano Ziglio
-by: Frediano Ziglio --- arch/x86/xen/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 52fa5609b7f6..ce30b8d3efe7 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -30,7 +30,7 @@ #include "xen-ops.h"

Re: [PATCH] tools/xentop: Add VBD3 support to xentop

2024-02-26 Thread Frediano Ziglio
On Mon, Feb 26, 2024 at 2:12 PM Fouad Hilly wrote: > > From: Pritha Srivastava > > xl now knows how to drive tapdisk, so modified libxenstat to > understand vbd3 statistics. > > Signed-off-by: Jorge Martin > Signed-off-by: Pritha Srivastava > Signed-off-by: Fouad Hilly > --- > CC: Wei Liu >

[PATCH v4] Reduce assembly code size of entry points

2024-02-19 Thread Frediano Ziglio
. Swapping between movl and movb will make no difference at all on performance. Similar code is already used in autogen_stubs. Signed-off-by: Frediano Ziglio Reviewed-by: Jan Beulich -- v4: - minor space adjustments; - quoted possible error message; - update commit subject removing "exception"

[PATCH v3] Reduce assembly code size of exception entry points

2024-02-16 Thread Frediano Ziglio
. Swapping between movl and movb will make no difference at all on performance. Similar code is already used in autogen_stubs. Signed-off-by: Frediano Ziglio -- v3: - add other missing entries; - reduce code when TRAP_syscall is used; - improved commit message. v2: - added missing entry points; - add

[PATCH v2] Reduce assembly code size of exception entry points

2024-02-14 Thread Frediano Ziglio
We just pushed a 8-bytes zero and exception constants are small so we can just write a single byte saving 3 bytes for instruction. With ENDBR64 this reduces the size of many entry points from 32 to 16 bytes (due to alignment). Similar code is already used in autogen_stubs. Signed-off-by: Frediano

[PATCH v2] Constify some parameters

2024-02-14 Thread Frediano Ziglio
Make clear they are not changed in the functions. Signed-off-by: Frediano Ziglio Reviewed-by: Jan Beulich -- v2: - fixed typo in commit message. --- xen/arch/x86/pv/callback.c | 4 ++-- xen/common/sched/compat.c | 2 +- xen/common/sched/core.c| 2 +- xen/xsm/flask/flask_op.c | 8

[PATCH 5/5] Reduce assembly instruction size

2024-02-05 Thread Frediano Ziglio
Use 32 bit versions in all cases, not only for registers till 8th. This reduces the encoding from (example with r14): 49 c7 c6 ff 7f 00 00mov$0x7fff,%r14 to 41 be ff 7f 00 00 mov$0x7fff,%r14d Signed-off-by: Frediano Ziglio --- xen/arch/x86/include/asm/asm_defns.h

[PATCH 4/5] Reduce assembly code size of exception entry points

2024-02-05 Thread Frediano Ziglio
We just pushed a 8-bytes zero and exception constants are small so we can just write a single byte saving 3 bytes for instruction. With ENDBR64 this reduces the size of the entry point from 32 to 16 bytes (due to alignment). Signed-off-by: Frediano Ziglio --- xen/arch/x86/x86_64/entry.S | 16

[PATCH 3/5] Use more specific constant

2024-02-05 Thread Frediano Ziglio
__HYPERVISOR_arch_1 and __HYPERVISOR_paging_domctl_cont for x86 have the same value but this function is handling "paging_domctl_cont" hypercall so using the latter mnemonic in the code is more clear. Signed-off-by: Frediano Ziglio --- xen/arch/x86/mm/paging.c | 2 +- 1 file

[PATCH 2/5] Remove useless assignment

2024-02-05 Thread Frediano Ziglio
The variable is assigned later, that value is never used. Signed-off-by: Frediano Ziglio --- xen/common/event_channel.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index a7a004a084..15aec5dcbb 100644 --- a/xen/common

[PATCH 1/5] Constify some parameters

2024-02-05 Thread Frediano Ziglio
Make clean they are not changed in the functions. Signed-off-by: Frediano Ziglio --- xen/arch/x86/pv/callback.c | 4 ++-- xen/common/sched/compat.c | 2 +- xen/common/sched/core.c| 2 +- xen/xsm/flask/flask_op.c | 8 4 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH] Fix some typos in comments

2024-02-01 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- arch/x86/include/arch/processor.h | 2 +- include/xen/hvm/params.h | 2 +- include/xtf/console.h | 2 +- include/xtf/extable.h | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/x86/include/arch

[PATCH] x86/ACPI: constify acpi_enter_sleep argument

2023-11-22 Thread Frediano Ziglio
Minor style change, structure is not changed. No functional change. Signed-off-by: Frediano Ziglio --- xen/arch/x86/acpi/power.c | 2 +- xen/arch/x86/include/asm/acpi.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi

[PATCH] x86/mem_sharing: Release domain if we are not able to enable memory sharing

2023-11-22 Thread Frediano Ziglio
In case it's not possible to enable memory sharing (mem_sharing_control fails) we just return the error code without releasing the domain acquired some lines above by rcu_lock_live_remote_domain_by_id. Signed-off-by: Frediano Ziglio -- I didn't manage to check the change, I was just looking

[PATCH] x86/mem_sharing: Fix typo in comment

2023-11-22 Thread Frediano Ziglio
ambigious -> ambiguous Signed-off-by: Frediano Ziglio --- xen/arch/x86/mm/mem_sharing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c index 142258f16a..9647e651f9 100644 --- a/xen/arch/x86/mm/mem_sharing.c ++

Re: [QEMU][PATCH v4 07/10] hw/xen/xen-hvm-common: Use g_new and error_setg_errno

2023-01-25 Thread Frediano Ziglio
Il giorno mer 25 gen 2023 alle ore 22:07 Stefano Stabellini ha scritto: > > On Wed, 25 Jan 2023, Vikram Garhwal wrote: > > Replace g_malloc with g_new and perror with error_setg_errno. > > error_setg_errno -> error_report ? Also in the title > > Signed-off-by: Vikram Garhwal Frediano