`%s --help' for more
information.\n",
@@ -493,7 +506,7 @@ int main(int argc, char **argv)
close(start_notify_fd);
}
- console_loop(spty, xs, path, interactive);
+ console_loop(spty, xs, path, interactive, escape_character);
free(path);
free(dom_path);
Nice work~
Reviewed-by: Hongda Deng
(intr) (1U << ((2 * ((intr) % 16)) + 1))
/* The function should be called with the rank lock taken */
static inline unsigned int vgic_get_virq_type(struct vcpu *v, int n, int
index)
--
2.25.1
Reviewed-by: Hongda Deng
ill access the wrong target vCPU index in the rank
when updating the irouter.
Fixes: 5d495f4349b5 ("xen/arm: vgic: Optimize the way to store the target vCPU
in the rank")
Signed-off-by: Hongda Deng
---
xen/arch/arm/vgic-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
ic will get offset=0 when vgic stores the irouter for this virq,
and finally vgic will access wrong target vcpu index in the rank when
it updates the irouter.
Fixes: 5d495f4349b5 ("xen/arm: vgic: Optimize the way to store the target vCPU
in the rank")
Signed-off-by: Hongda Deng
---
xen/
)
> > +break;
> >
> > -left -= (1U << order);
> > +vfn += 1U << order;
> > +if ( !mfn_eq(mfn, INVALID_MFN) )
> > +mfn = mfn_add(mfn, 1U << order);
> > +
> > +left -= (1U << order);
> > +}
>
> I forgot to add:
>
> if ( rc )
>break;
>
> Without it, the outer loop will never exit in case of an error.
>
> Cheers,
>
> --
> Julien Grall
Yep, I am happy with that.
Reviewed-by: Hongda Deng
Cheers,
---
Hongda
Hi Julien,
> -Original Message-
> From: Xen-devel On Behalf Of Julien
> Grall
> Sent: 2022年2月21日 18:22
> To: xen-devel@lists.xenproject.org
> Cc: jul...@xen.org; Julien Grall ; Stefano Stabellini
> ; Bertrand Marquis ;
> Volodymyr Babchuk
> Subject: [PATCH v3 09/19] xen/arm32: mm: Check
The mapping can also be marked read-only has Xen as no business to
In my opinion I think it may should be:
... read-only as Xen has no business ...
instead of:
... read-only has Xen as no business ...
For this and other patches before this:
Reviewed-by: Hongda Deng
> modi
Fix typo in the commit message
> - Remove the TODO regarding contiguous bit
>
> Changes in v2:
> - New patch
For the all 19 patches:
Tested-by: Hongda Deng
> ---
> xen/arch/arm/mm.c | 63 ---
> 1 file
Hi,
> -Original Message-
> From: Julien Grall
> Sent: 2021年10月22日 1:16
> To: Hongda Deng ; xen-devel@lists.xenproject.org;
> sstabell...@kernel.org
> Cc: Bertrand Marquis ; Wei Chen
> ; Ian Jackson
> Subject: Re: [for-4.16] Re: [PATCH v4] xen/arm: vgic: Ignore w
].
[1] https://github.com/zephyrproject-rtos/zephyr/blob/eaf6cf745df3807e6e
cc941c3a30de6c179ae359/drivers/interrupt_controller/intc_gicv3.c#L274
Signed-off-by: Hongda Deng
---
Changes since v3:
* Commit message modification
* Change "goto write_ignore_32" to "goto write_ignore&q
> -Original Message-
> From: Julien Grall
> Sent: 2021年10月21日 1:45
> To: Hongda Deng ; xen-
> de...@lists.xenproject.org; sstabell...@kernel.org
> Cc: Bertrand Marquis ; Wei Chen
>
> Subject: Re: [PATCH v3] xen/arm: vgic to ignore GICD ICPENDRn registers
].
[1] https://github.com/zephyrproject-rtos/zephyr/blob/eaf6cf745df3807e6e
cc941c3a30de6c179ae359/drivers/interrupt_controller/intc_gicv3.c#L274
Signed-off-by: Hongda Deng
---
Changes since v2:
* Avoid to print messages when there is no pending interrupt
* Add helper
Hi,
> -Original Message-
> From: Julien Grall
> Sent: 2021年10月14日 17:30
> To: Hongda Deng ; xen-
> de...@lists.xenproject.org; sstabell...@kernel.org
> Cc: Bertrand Marquis ; Wei Chen
>
> Subject: Re: [PATCH v2] xen/arm: vgic to ignore GICD ICPENRn registers
>
Hi,
> -Original Message-
> From: Julien Grall
> Sent: 2021年10月13日 5:58
> To: Hongda Deng ; xen-devel@lists.xenproject.org;
> sstabell...@kernel.org
> Cc: Bertrand Marquis ; Wei Chen
>
> Subject: Re: [PATCH v2] xen/arm: vgic to ignore GICD ICPENRn registers acces
].
[1] https://lists.xenproject.org/archives/html/xen-devel/2021-09/
msg00744.html
Signed-off-by: Hongda Deng
---
xen/arch/arm/vgic-v2.c | 26 +-
xen/arch/arm/vgic-v3.c | 40 +++-
2 files changed, 56 insertions(+), 10 deletions(-)
diff
Hi,
Thanks for your great and detailed advice, I did some investigations about vgic
especially inflight_irqs in the last few days.
> -Original Message-
> From: Stefano Stabellini
> Sent: 2021年9月24日 4:54
> To: Julien Grall
> Cc: Hongda Deng ; xen-devel@lists.xenproject.
].
[1] https://lists.xenproject.org/archives/html/xen-devel/2021-09/
msg00744.html
Signed-off-by: Hongda Deng
---
xen/arch/arm/vgic-v2.c | 10 +++---
xen/arch/arm/vgic-v3.c | 29 +
xen/arch/arm/vgic.c| 37 +
xen
Hi Julien,
> On 06/09/2021 10:04, Hongda Deng wrote:
> > Hi Julien,
>
> Hi Hongda,
>
> > Xen provides vGIC to support Xen guests, and currently xen will return IO
> > unhandled when guests access GICD ICPENRn registers. This works fine with
> Linux
> &g
Hi Julien,
Xen provides vGIC to support Xen guests, and currently xen will return IO
unhandled when guests access GICD ICPENRn registers. This works fine with Linux
guests, for Linux won't access these registers. But for Zephyr, this mechanism
will cause IO dataabort on Zephyr's initialization
19 matches
Mail list logo
