Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs

2023-05-16 Thread John Snow
On Fri, May 12, 2023 at 5:14 PM Stefano Stabellini wrote: > > On Wed, 10 May 2023, Olaf Hering wrote: > > Wed, 10 May 2023 00:58:27 +0200 Olaf Hering : > > > > > In my debugging (with v8.0.0) it turned out the three pci_set_word > > > causes the domU to hang. In fact, it is just the last one: > >

Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs

2021-03-22 Thread John Snow
On 3/17/21 3:00 AM, Olaf Hering wrote: Commit ee358e919e385fdc79d59d0d47b4a81e349cd5c9 causes a regression in Xen HVM domUs which run xenlinux based kernels. If the domU has an USB device assigned, for example with "usbdevice=['tablet']" in domU.cfg, the late unplug of devices will kill the

Re: [PATCH-for-5.1 3/3] hw: Remove unnecessary DEVICE() cast

2020-04-17 Thread John Snow
blk_unref(blk); > } > } > -qdev_reset_all(DEVICE(dev)); > +qdev_reset_all(dev); > return 0; > } > Acked-by: John Snow

Re: [PATCH-for-5.1 2/3] various: Remove unnecessary OBJECT() cast

2020-04-17 Thread John Snow
On 4/12/20 5:09 PM, Philippe Mathieu-Daudé wrote: > -memory_region_init_io(>mmio, OBJECT(obj), _ahci_mem_ops, a, > +memory_region_init_io(>mmio, obj, _ahci_mem_ops, a, Acked-by: John Snow

Re: [Xen-devel] [PATCH v3 11/20] hw/ide/internal: Remove unused DMARestartFunc typedef

2020-03-04 Thread John Snow
_t len); > typedef void DMAu32Func(IDEDMA *, uint32_t); > typedef void DMAStopFunc(IDEDMA *, bool); > -typedef void DMARestartFunc(void *, int, RunState); > > struct unreported_events { > bool eject_request; > Acked-by: John Snow

Re: [Xen-devel] [PATCH v3 12/20] hw/ide: Let the DMAIntFunc prototype use a boolean 'is_write' argument

2020-03-04 Thread John Snow
| 2 +- > hw/ide/core.c | 2 +- > hw/ide/macio.c| 2 +- > hw/ide/pci.c | 2 +- > 6 files changed, 8 insertions(+), 8 deletions(-) Acked-by: John Snow ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH v2 0/2] misc: Replace zero-length arrays with flexible array member

2020-03-04 Thread John Snow
rget/s390x/ioinst.c | 2 +- > 34 files changed, 53 insertions(+), 52 deletions(-) > I'll admit I did not manually verify ALL of this, but instead trust that: 1. The conversion is correct, and this is a desirable change to make. 2. Sample conversions I looked at appear correct. 3. It builds. 4. It passes tests. So: Acked-by: John Snow ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 00/20] hw: Clean up hw/i386 headers (and few alpha/hppa)

2019-10-14 Thread John Snow
hw/pci-host/piix.c| 1 + > hw/pci-host/q35.c | 1 + > hw/timer/hpet.c | 2 +- > hw/timer/twl92230.c | 1 - > hw/usb/dev-storage.c | 1 - > hw/xen/xen_pt_load_rom.c | 4 > include/hw/i38

Re: [Xen-devel] [PATCH 02/20] hw/southbridge/ich9: Removed unused headers

2019-10-14 Thread John Snow
On 10/14/19 10:22 AM, Philippe Mathieu-Daudé wrote: > The ICH9 chipset is not X86/PC specific. > > These files don't use anything declared by the "hw/i386/pc.h" > or "hw/i386/ioapic.h" headers. Remove them. > > Signed-off-by: Philippe Mathieu-Daudé Rev

Re: [Xen-devel] [Qemu-block] [PATCH] xen-block: treat XenbusStateUnknown the same as XenbusStateClosed

2019-09-23 Thread John Snow
On 9/23/19 5:38 AM, Paul Durrant wrote: >> -Original Message- >> From: John Snow >> Sent: 20 September 2019 22:11 >> To: Paul Durrant ; xen-devel@lists.xenproject.org; >> qemu-de...@nongnu.org; >> qemu-bl...@nongnu.org >> Cc: Kevin Wolf ; Stefa

Re: [Xen-devel] [Qemu-block] [PATCH] xen-block: treat XenbusStateUnknown the same as XenbusStateClosed

2019-09-20 Thread John Snow
On 9/18/19 7:57 AM, Paul Durrant wrote: > When a frontend gracefully disconnects from an offline backend, it will > set its own state to XenbusStateClosed. The code in xen-block.c correctly > deals with this and sets the backend into XenbusStateClosed. Unfortunately > it is possible for

Re: [Xen-devel] [Qemu-devel] [PATCH] compiler: add a sizeof_field() macro

2018-06-14 Thread John Snow
updated to use the macro. > > Signed-off-by: Stefan Hajnoczi How'd you find all the existing instances? Reviewed-by: John Snow > --- > include/hw/xen/io/ring.h | 2 +- > include/qemu/compiler.h | 2 ++ > accel/tcg/translate-all.c | 2 +- > hw/display/xenfb.c