: Philippe Mathieu-Daudé
>
Reviewed-by: Li Qiang
> ---
> hw/mips/mips_malta.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
> index 528c34a1c3..774bb810f6 100644
> --- a/hw/mips/mips_malta.c
> +/* DMA */
> +i8257_dma_init(isa_bus, 0);
> +
> piix4_dev = dev;
> }
>
>
Could you please explain why this is better calling 'i8257_dma_init' in
piix4 realize function
instead of calling it in mips_malta_init.
I'm still a little of which things should be done
Poussineau
> Message-Id: <20171216090228.28505-15-hpous...@reactos.org>
> Reviewed-by: Aleksandar Markovic
> [PMD: rebased]
> Signed-off-by: Philippe Mathieu-Daudé
>
Reviewed-by: Li Qiang
> ---
> hw/isa/piix4.c | 1 -
> hw/mips/mips_malta.c | 2 +-
> inc
Philippe Mathieu-Daudé 于2019年10月18日周五 下午9:50写道：
> From: Philippe Mathieu-Daudé
>
> This function isn't used anymore.
>
> This reverts commit 22ec3283efba9ba0792790da786d6776d83f2a92.
>
> Reviewed-by: Thomas Huth
> Signed-off-by: Philippe Mathieu-Daudé
>
Reviewed-
r
> - * The 8259 is attached to the MIPS CPU INT0 pin, ie interrupt 2
> - */
> -s->i8259 = i8259_init(isa_bus, i8259_irq);
> +/* Interrupt controller */
> +qdev_connect_gpio_out_named(dev, "intr", 0, i8259_irq);
> +for (int i = 0; i < ISA_NUM_I
r Markovic
> Signed-off-by: Philippe Mathieu-Daudé
>
Reviewed-by: Li Qiang
> ---
> MAINTAINERS | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fe4dc51b08..c9f625fc2e 100644
> --- a/MAINTAINERS
> ++
PIIX4_PCI_DEVICE(dev);
> +PIIX4State *s = PIIX4_PCI_DEVICE(dev);
>
> -if (!isa_bus_new(DEVICE(d), pci_address_space(dev),
> +if (!isa_bus_new(DEVICE(dev), pci_address_space(dev),
> pci_address_space_io(dev), errp)) {
> return;
> }
>
