Re: [Xen-devel] [PATCH v2] xen-blkfront: fix kernel panic with blkfront_remove()

2018-11-09 Thread Manjunath Patil
oops! sorry for not noticing this. -Manjunath On 11/8/2018 10:16 PM, Juergen Gross wrote: On 09/11/2018 02:10, Manjunath Patil wrote: When we try to detach the device, blkfront_remove() tries to access blkfront_info leading to kernel panic. Typical call stack involving panic - #10

[Xen-devel] [PATCH] xen-blkfront: use old rinfo after enomem during migration

2018-11-28 Thread Manjunath Patil
failure during migration will lead the processes accessing the device into hung state. This patch aims to reuse old rinfo in case of memory allocation failure. Signed-off-by: Manjunath Patil --- drivers/block/xen-blkfront.c | 46 +++-- 1 files changed, 39

Re: [Xen-devel] [PATCH] xen-blkfront: use old rinfo after enomem during migration

2018-11-30 Thread Manjunath Patil
Thank you Boris for your comments. I removed faulty email of mine. replies inline. On 11/30/2018 12:42 PM, Boris Ostrovsky wrote: On 11/29/18 12:17 AM, Manjunath Patil wrote: Hi, Feel free to suggest/comment on this. I am trying to do the following at dst during the migration now. 1. Dont

Re: [Xen-devel] [PATCH] xen-blkfront: use old rinfo after enomem during migration

2018-12-02 Thread Manjunath Patil
On 11/30/2018 2:33 PM, Boris Ostrovsky wrote: On 11/30/18 4:49 PM, Manjunath Patil wrote: Thank you Boris for your comments. I removed faulty email of mine. replies inline. On 11/30/2018 12:42 PM, Boris Ostrovsky wrote: On 11/29/18 12:17 AM, Manjunath Patil wrote: Hi, Feel free to suggest

Re: [Xen-devel] [PATCH] xen-blkfront: use old rinfo after enomem during migration

2018-12-03 Thread Manjunath Patil
On 12/3/2018 6:16 PM, Boris Ostrovsky wrote: On 12/3/18 8:14 PM, Dongli Zhang wrote: Hi Boris, On 12/04/2018 12:07 AM, Boris Ostrovsky wrote: On 12/2/18 3:31 PM, Manjunath Patil wrote: On 11/30/2018 2:33 PM, Boris Ostrovsky wrote: On 11/30/18 4:49 PM, Manjunath Patil wrote: Thank you

[Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-29 Thread Manjunath Patil
81422f29 #15 kthread at 810abe6a #16 ret_from_fork at 81754078 Though either of my changes avoid the panic, I included both the changes. This issue got introduced with "7ed8ce1 xen-blkfront: move negotiate_mq to cover all cases of new VBDs" Signed-off-by: Manjunath Patil

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Manjunath Patil
Thank you Juergen for your comments. I will soon send v2 patch. -Thanks, Manjunath On 10/30/2018 12:04 AM, Juergen Gross wrote: On 29/10/2018 19:31, Manjunath Patil wrote: info->nr_rings isn't adjusted in case of ENOMEM error from negotiate_mq(). This leads to kernel panic in er

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Manjunath Patil
On 10/30/2018 3:39 AM, Roger Pau Monné wrote: On Mon, Oct 29, 2018 at 11:31:56AM -0700, Manjunath Patil wrote: info->nr_rings isn't adjusted in case of ENOMEM error from negotiate_mq(). This leads to kernel panic in error path. Typical call stack involving panic - #8 page_

[Xen-devel] [PATCH v2] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Manjunath Patil
81422f29 #15 kthread at 810abe6a #16 ret_from_fork at 81754078 Cc: sta...@vger.kernel.org Fixes: 7ed8ce1c5fc7 ("xen-blkfront: move negotiate_mq to cover all cases of new VBDs") Signed-off-by: Manjunath Patil --- drivers/block/xen-blkfront.c |1 + 1 files changed,

[Xen-devel] [PATCH] xen-blkfront: fix kernel panic with blkfront_remove()

2018-11-08 Thread Manjunath Patil
...@vger.kernel.org Signed-off-by: Manjunath Patil --- drivers/block/xen-blkfront.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index dc8fe25..144cda8 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen

[Xen-devel] [PATCH v2] xen-blkfront: fix kernel panic with blkfront_remove()

2018-11-08 Thread Manjunath Patil
frontend_changed at 813fca19 #20 xenwatch_thread at 813f88f9 #21 kthread at 810a486b #22 ret_from_fork at 816ed2a8 Cc: sta...@vger.kernel.org Signed-off-by: Manjunath Patil --- v2: style change. added the missing space b/w if and ( --- drivers/block/xen-blkfront.c |3