Re: Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
On Wed, Oct 18, 2023 at 04:18:26PM +0200, Michal Orzel wrote: > Hi, > > On 18/10/2023 15:29, Jan Beulich wrote: > > > > > > On 18.10.2023 12:38, Manuel Bouyer wrote: > >> Hello, > >> With Xen 4.18, a PV domain running under pvshim doesn't get cons

Re: Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
On Wed, Oct 18, 2023 at 03:51:54PM +0200, Jan Beulich wrote: > On 18.10.2023 15:36, Manuel Bouyer wrote: > > On Wed, Oct 18, 2023 at 03:24:22PM +0200, Jan Beulich wrote: > >> On 18.10.2023 13:20, Manuel Bouyer wrote: > >>> On Wed, Oct 18, 2023 at 11:44:22AM +0100, And

Re: Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
On Wed, Oct 18, 2023 at 03:29:08PM +0200, Jan Beulich wrote: > On 18.10.2023 12:38, Manuel Bouyer wrote: > > Hello, > > With Xen 4.18, a PV domain running under pvshim doesn't get console input. > > This is because the domain id in pvshim isn't 0 (and on x86 max_init_domid

Re: Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
On Wed, Oct 18, 2023 at 03:24:22PM +0200, Jan Beulich wrote: > On 18.10.2023 13:20, Manuel Bouyer wrote: > > On Wed, Oct 18, 2023 at 11:44:22AM +0100, Andrew Cooper wrote: > >> On 18/10/2023 11:38 am, Manuel Bouyer wrote: > >>> Hello, > >>> With Xen 4.18

Re: Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
On Wed, Oct 18, 2023 at 11:44:22AM +0100, Andrew Cooper wrote: > On 18/10/2023 11:38 am, Manuel Bouyer wrote: > > Hello, > > With Xen 4.18, a PV domain running under pvshim doesn't get console input. > > This is because the domain id in pvshim isn't 0 (and

Re: Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
On Wed, Oct 18, 2023 at 12:38:57PM +0200, Manuel Bouyer wrote: > Hello, > With Xen 4.18, a PV domain running under pvshim doesn't get console input. > This is because the domain id in pvshim isn't 0 (and on x86 max_init_domid is > hardwired to 0), so console_input_domain() will

Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
to the real domain id for pvshim, but there may be a better way to do this. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference -- --- drivers/char/console.c.orig 2023-10-18 12:24:57.221891748 +0200 +++ drivers/char/console.c 2023-10-18 12:30:26.072844802 +0200 @@ -478,14

Re: [PATCH] public: add RING_NR_UNCONSUMED_*() macros to ring.h

2021-11-26 Thread Manuel Bouyer
the new > RING_NR_UNCONSUMED_*() macros when using this version of ring.h. AFAIK NetBSD is using RING_HAS_UNCONSUMED as a booleanm so it should be fine with this change -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH 4/6] CHANGELOG.md: NetBSD lib/gnttab support

2021-03-25 Thread Manuel Bouyer
On Thu, Mar 25, 2021 at 10:13:11AM +0100, Roger Pau Monné wrote: > On Wed, Mar 24, 2021 at 04:44:05PM +, George Dunlap wrote: > > Signed-off-by: George Dunlap > > LGTM, maybe Manuel has something else to add. no, it's OK for me too -- Manuel Bouyer NetBSD: 26 ans d'ex

Re: [PATCH] xenstored: close socket connections on error

2021-02-04 Thread Manuel Bouyer
On Thu, Feb 04, 2021 at 12:11:02PM +0100, Jürgen Groß wrote: > On 03.02.21 17:54, Manuel Bouyer wrote: > > On error, don't keep socket connection in ignored state but close them. > > When the remote end of a socket is closed, xenstored will flag it as an > > error and

Re: [PATCH] xenstored: close socket connections on error

2021-02-03 Thread Manuel Bouyer
ave a pointer or two, but everyone has their own pet methods > and tooling so the result would perhaps be more confusing than > helpful. a howto is alwaus helpfull. Even if it's not the one and only way to do, at last it gives a start point. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

[PATCH v3] NetBSD: use system-provided headers

2021-02-03 Thread Manuel Bouyer
-by: Manuel Bouyer --- tools/debugger/gdbsx/xg/xg_main.c | 4 + tools/include/Makefile | 2 + tools/include/xen-sys/NetBSD/evtchn.h | 86 tools/include/xen-sys/NetBSD/privcmd.h | 106 - tools/libs/call/private.h | 4

[PATCH v3] Document qemu-ifup on NetBSD

2021-02-03 Thread Manuel Bouyer
Document that on NetBSD, the tap interface will be configured by the qemu-ifup script. Signed-off-by: Manuel Bouyer Release-Acked-by: Ian Jackson --- docs/man/xl-network-configuration.5.pod | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/man/xl-network-configuration.5.pod b/docs

[PATCH] add a qemu-ifup script on NetBSD

2021-02-03 Thread Manuel Bouyer
On NetBSD, qemu-xen will use a qemu-ifup script to setup the tap interfaces (as qemu-xen-traditional used to). Copy the script from qemu-xen-traditional, and install it on NetBSD. While there document parameters and environnement variables. Signed-off-by: Manuel Bouyer --- tools/hotplug/NetBSD

[PATCH] xenstored: close socket connections on error

2021-02-03 Thread Manuel Bouyer
will stay open forever in xenstored (and it will loop with CPU 100% busy). Signed-off-by: Manuel Bouyer Fixes: d2fa370d3ef9cbe22d7256c608671cdcdf6e0083 --- tools/xenstore/xenstored_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
y. thanks. When I started, I looked at the wiki for instructions about patches, but didn't find any ... -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
On Wed, Feb 03, 2021 at 01:58:19PM +0100, Jürgen Groß wrote: > On 03.02.21 13:47, Manuel Bouyer wrote: > > On Wed, Feb 03, 2021 at 01:42:12PM +0100, Jürgen Groß wrote: > > > Uh, this is no regular patch. > > > > I though by regular patch, you meants a plain diff -u

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
hrough sevreral iterations with this protocol. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
red will flag it as an error and switch the connection to ignored. But on some OSes (e.g. NetBSD), poll(2) will return only POLLIN in this case, so sockets in ignored state will stay open forever in xenstored (and it will loop with CPU 100% busy). -- Manuel Bouyer Net

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
On Wed, Feb 03, 2021 at 01:13:53PM +0100, Jürgen Groß wrote: > On 03.02.21 13:03, Manuel Bouyer wrote: > > On Wed, Feb 03, 2021 at 12:54:23PM +0100, Jürgen Groß wrote: > > > On 03.02.21 12:48, Manuel Bouyer wrote: > > > > On Wed, Feb 03, 2021 at 09:21

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
On Wed, Feb 03, 2021 at 12:54:23PM +0100, Jürgen Groß wrote: > On 03.02.21 12:48, Manuel Bouyer wrote: > > On Wed, Feb 03, 2021 at 09:21:32AM +0100, Jürgen Groß wrote: > > > [...] > > > This shouldn't happen in case we are closing the socket actively. > > >

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
tical modification of the XSA-115 fixes for sockets while > keeping the desired effect for domain connections. Hello here's an updated patch which works for me. Does anyone see a problem with it ? If not I will submit it for commit. -- Manuel Bouyer NetBSD: 26 ans d'experience feront t

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
the domain > > > in question to be known to xenstored. > > > > > > For socket connections this should be okay, though. > > > > What are "non-socket connections" BTW ? I don't think I've seen one > > in my test. > > Every connection to a

Re: xenstored file descriptor leak

2021-02-02 Thread Manuel Bouyer
On Wed, Feb 03, 2021 at 07:18:51AM +0100, Jürgen Groß wrote: > On 02.02.21 19:37, Manuel Bouyer wrote: > > Hello, > > on NetBSD I'm tracking down an issue where xenstored never closes its > > file descriptor to /var/run/xenstored/socket and instead loops at 100% > &g

xenstored file descriptor leak

2021-02-02 Thread Manuel Bouyer
ndle_output(struct connection *conn) what do you think ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH v2] libs/light: pass some infos to qemu

2021-02-01 Thread Manuel Bouyer
t; I would remove it from qemu-trad and then only install from > hotplug/NetBSD if it's not already there? Or maybe just force-install > it from hotplug/NetBSD even if it's already present? OK will try that -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH v2] libs/light: pass some infos to qemu

2021-02-01 Thread Manuel Bouyer
On Mon, Feb 01, 2021 at 09:06:13AM +0100, Roger Pau Monné wrote: > On Sat, Jan 30, 2021 at 12:50:13PM +0100, Manuel Bouyer wrote: > > On Thu, Jan 28, 2021 at 12:08:02PM +0100, Roger Pau Monné wrote: > > > [...] > > > Also, the qemu-ifup script doesn't seem to be part

Re: [PATCH v3 2/2] Document qemu-ifup on NetBSD

2021-02-01 Thread Manuel Bouyer
On Mon, Feb 01, 2021 at 09:21:58AM +0100, Roger Pau Monné wrote: > On Sun, Jan 31, 2021 at 12:03:00AM +0100, Manuel Bouyer wrote: > > Document that on NetBSD, the tap interface will be configured by the > > qemu-ifup script. Document the arguments, and XEN_DOMAIN_ID environneme

Re: [PATCH v2] libs/light: pass some infos to qemu

2021-01-30 Thread Manuel Bouyer
network-configuration.5.pod -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

[PATCH v3 2/2] Document qemu-ifup on NetBSD

2021-01-30 Thread Manuel Bouyer
Document that on NetBSD, the tap interface will be configured by the qemu-ifup script. Document the arguments, and XEN_DOMAIN_ID environnement variable. --- docs/man/xl-network-configuration.5.pod | 4 1 file changed, 4 insertions(+) diff --git a/docs/man/xl-network-configuration.5.pod

[PATCH v3 1/2] libs/light: pass some infos to qemu

2021-01-30 Thread Manuel Bouyer
to rename network interfaces implemented, and thus cannot rename the interface from tapX to vifX.Y-emu. Only qemu knowns the tap interface name, so we need to use the qemu script from qemu itself. Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné --- tools/libs/light/libxl_dm.c | 6 ++ 1

Re: [PATCH v2] libs/light: make it build without setresuid()

2021-01-30 Thread Manuel Bouyer
On Fri, Jan 29, 2021 at 11:05:24PM +, Andrew Cooper wrote: > On 29/01/2021 23:01, Manuel Bouyer wrote: > > On Fri, Jan 29, 2021 at 10:51:14PM +, Andrew Cooper wrote: > >> Given the freeze, and discussions on IRC, I have committed most of this >

[PATCH v3 1/2] xenpmd.c: use dynamic allocation

2021-01-30 Thread Manuel Bouyer
On NetBSD, d_name is larger than 256, so file_name[284] may not be large enough (and gcc emits a format-truncation error). Use asprintf() instead of snprintf() on a static on-stack buffer. Signed-off-by: Manuel Bouyer Reviewed-by: Ian Jackson --- tools/xenpmd/xenpmd.c | 8 1 file

[PATCH v3 2/2] define GNU_SOURCE for asprintf()

2021-01-30 Thread Manuel Bouyer
#define _GNU_SOURCE to get for asprintf() prototype on Linux. Harmless on NetBSD. Signed-off-by: Manuel Bouyer --- tools/xenpmd/xenpmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/xenpmd/xenpmd.c b/tools/xenpmd/xenpmd.c index e432aad856..8e783181e1 100644 --- a/tools/xenpmd

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-30 Thread Manuel Bouyer
l commits and then have git format-patch output something sensible. I nerver understood how git branches and merge were supposed to work (for example syncing a local repo with upstream, while keeping local changes). -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH v2] libs/light: pass some infos to qemu

2021-01-30 Thread Manuel Bouyer
emu-xen call the script with the same parameters, and add the XEN_DOMAIN_ID environnement variable. Is it OK to keep the script from qemu-xen-traditional (and installed as part of qemu-xen-traditional) for now ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH v2] libs/light: make it build without setresuid()

2021-01-29 Thread Manuel Bouyer
On Fri, Jan 29, 2021 at 11:05:24PM +, Andrew Cooper wrote: > On 29/01/2021 23:01, Manuel Bouyer wrote: > > On Fri, Jan 29, 2021 at 10:51:14PM +, Andrew Cooper wrote: > >> Given the freeze, and discussions on IRC, I have committed most of this >

Re: [PATCH v2] NetBSD: use system-provided headers

2021-01-29 Thread Manuel Bouyer
Sorry I forgot to change the Subject. It should have been [PATCH v3] -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH v2] libs/light: make it build without setresuid()

2021-01-29 Thread Manuel Bouyer
people/andyhhp/xen/-/jobs/996140268 It looks like I don't have access to this page, could you share the content ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

[PATCH v2] NetBSD: use system-provided headers

2021-01-29 Thread Manuel Bouyer
-by: Manuel Bouyer --- tools/debugger/gdbsx/xg/xg_main.c | 4 + tools/include/Makefile | 2 + tools/include/xen-sys/NetBSD/evtchn.h | 86 tools/include/xen-sys/NetBSD/privcmd.h | 106 - tools/libs/call/private.h | 4

Re: [PATCH v4] tools/foreignmem: Support querying the size of a resource

2021-01-29 Thread Manuel Bouyer
On Fri, Jan 29, 2021 at 03:09:30PM +, Andrew Cooper wrote: > On 29/01/2021 14:59, Roger Pau Monné wrote: > > On Fri, Jan 29, 2021 at 11:38:43AM +0100, Manuel Bouyer wrote: > >> On Thu, Jan 28, 2021 at 12:01:52PM +, Andrew Cooper wrote: > >>> With the Xe

Re: [PATCH v2] NetBSD hotplug: fix block unconfigure on destroy

2021-01-29 Thread Manuel Bouyer
On Thu, Jan 28, 2021 at 12:45:09PM +0100, Roger Pau Monné wrote: > On Tue, Jan 26, 2021 at 11:47:49PM +0100, Manuel Bouyer wrote: > > When a domain is destroyed, xparams may not be available any more when > > the block script is called to unconfigure the vnd. > > Check xpa

Re: [PATCH v2] NetBSD: use system-provided headers

2021-01-29 Thread Manuel Bouyer
On Thu, Jan 28, 2021 at 12:21:33PM +0100, Roger Pau Monné wrote: > On Tue, Jan 26, 2021 at 11:47:50PM +0100, Manuel Bouyer wrote: > > On NetBSD use the system-provided headers for ioctl and related definitions, > > they are up to date and have more chances to match th

Re: [PATCH v2] libs/foreignmemory: Implement on NetBSD

2021-01-29 Thread Manuel Bouyer
On Thu, Jan 28, 2021 at 11:42:45AM +, Andrew Cooper wrote: > FAOD I've committed a fixed up version of this patch as discussed. thanks ! -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH v2] libs/light: pass some infos to qemu

2021-01-29 Thread Manuel Bouyer
On Thu, Jan 28, 2021 at 12:08:02PM +0100, Roger Pau Monné wrote: > On Tue, Jan 26, 2021 at 11:47:58PM +0100, Manuel Bouyer wrote: > > Pass bridge name to qemu as command line option > > When starting qemu, set an environnement variable XEN_DOMAIN_ID, > > to be used b

Re: [PATCH v2] libs/store: make build without PTHREAD_STACK_MIN

2021-01-29 Thread Manuel Bouyer
On Thu, Jan 28, 2021 at 11:08:08AM +, Andrew Cooper wrote: > On 28/01/2021 10:57, Roger Pau Monné wrote: > > On Tue, Jan 26, 2021 at 11:47:59PM +0100, Manuel Bouyer wrote: > >> On NetBSD, PTHREAD_STACK_MIN is not available. > >> If PTHREAD_STACK_MIN is not defined

Re: [PATCH v4] tools/foreignmem: Support querying the size of a resource

2021-01-29 Thread Manuel Bouyer
mmap(fres->addr, fres->nr_frames << PAGE_SHIFT, >fres->prot, fres->flags | MAP_ANON | MAP_SHARED, -1, > 0); What happens if fres->addr is not NULL and nr_frames is 0 ? Is it supposed to happen ? Should we assert that fres->addr is NULL when

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-27 Thread Manuel Bouyer
On Wed, Jan 27, 2021 at 04:03:04PM +, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH] libs/light: make it build without > setresuid()"): > > Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without > > setresuid()"): > > >

Re: [PATCH] NetBSD hotplug: Introduce locking functions

2021-01-27 Thread Manuel Bouyer
On Wed, Jan 27, 2021 at 03:57:06PM +, Ian Jackson wrote: > Manuel Bouyer writes ("[PATCH] NetBSD hotplug: Introduce locking functions"): > > From: Manuel Bouyer > > > > On NetBSD, some block device configuration requires serialisation. > > Intr

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-27 Thread Manuel Bouyer
On Wed, Jan 27, 2021 at 10:06:43AM +0100, Roger Pau Monné wrote: > On Tue, Jan 26, 2021 at 11:42:23PM +0100, Manuel Bouyer wrote: > > On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote: > > > [...] > > > > > > Note also that there are networki

Re: [PATCH] NetBSD hotplug: fix block unconfigure on destroy

2021-01-27 Thread Manuel Bouyer
> As said I think fetching vnd on detach is fine because there's no need > to fetch the other nodes, but this seems to be masking some kind of > error elsewhere. My priority is to get the patches in at this point. Each round takes me hours to get them in shape. -- Manuel Bouyer

[PATCH v2] libs/light: pass some infos to qemu

2021-01-26 Thread Manuel Bouyer
to rename network interfaces implemented, and thus cannot rename the interface from tapX to vifX.Y-emu. Only qemu knowns the tap interface name, so we need to use the qemu script from qemu itself. Signed-off-by: Manuel Bouyer --- tools/libs/light/libxl_dm.c | 6 ++ 1 file changed, 6 insertions

[PATCH v2] libs/light: Switch NetBSD to QEMU_XEN

2021-01-26 Thread Manuel Bouyer
Switch NetBSD to QEMU_XEN. All 3 versions of libxl__default_device_model() now return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN, so remove it and just set b_info->device_model_version to LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN in libxl__domain_build_info_setdefault(). Signed-off-by: Manuel Bouyer Revie

[PATCH v2] libs/call: fix build on NetBSD

2021-01-26 Thread Manuel Bouyer
Define PAGE_* if not already defined Catch up with osdep interface change. Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné --- tools/libs/call/netbsd.c | 19 +++ tools/libs/call/private.h | 4 +++- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git

[PATCH v2] NetBSD hotplug: fix block unconfigure on destroy

2021-01-26 Thread Manuel Bouyer
When a domain is destroyed, xparams may not be available any more when the block script is called to unconfigure the vnd. Check xparam only at configure time, and just unconfigure any vnd present in the xenstore. Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné --- tools/hotplug

[PATCH v2] libs/light: make it build without setresuid()

2021-01-26 Thread Manuel Bouyer
NetBSD doesn't have setresuid(). introcuce libxl__setresuid(), which on NetBSD assert() that it's never called (it should not be called when dm restriction is off, and NetBSD doesn't support dm restriction at this time). On linux and FreeBSD it just calls setresuid(). Signed-off-by: Manuel Bouyer

[PATCH v2] libs/light: fix tv_sec printf format

2021-01-26 Thread Manuel Bouyer
Don't assume tv_sec is a unsigned long, it is 64 bits on NetBSD 32 bits. Use %jd and cast to (intmax_t) instead Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné --- tools/libs/light/libxl_create.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libs

[PATCH v2] libs/light: fix uuid on NetBSD

2021-01-26 Thread Manuel Bouyer
NetBSD uses the same uuid library as FreeBSD. As this is in a __FreeBSD__ || __NetBSD__ block, just drop the #ifdef __FreeBSD__ and dead code. Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné --- tools/libs/light/libxl_uuid.c | 21 - 1 file changed, 21 deletions

[PATCH v2] libs/gnttab: implement on NetBSD

2021-01-26 Thread Manuel Bouyer
Implement gnttab interface on NetBSD. The kernel interface is different from FreeBSD so we can't use the FreeBSD version Signed-off-by: Manuel Bouyer --- tools/libs/gnttab/Makefile | 2 +- tools/libs/gnttab/netbsd.c | 267 + 2 files changed, 268 insertions

[PATCH v2] libs/store: make build without PTHREAD_STACK_MIN

2021-01-26 Thread Manuel Bouyer
On NetBSD, PTHREAD_STACK_MIN is not available. If PTHREAD_STACK_MIN is not defined, define it to 0 so that we fallback to DEFAULT_THREAD_STACKSIZE Signed-off-by: Manuel Bouyer --- tools/libs/store/xs.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/libs/store/xs.c b/tools/libs

[PATCH v2] NetBSD: use system-provided headers

2021-01-26 Thread Manuel Bouyer
-by: Manuel Bouyer --- tools/debugger/gdbsx/xg/xg_main.c | 4 + tools/include/Makefile | 2 + tools/include/xen-sys/NetBSD/evtchn.h | 86 tools/include/xen-sys/NetBSD/privcmd.h | 106 - tools/libs/call/private.h | 4

[PATCH v2] xenpmd.c: use dynamic allocation

2021-01-26 Thread Manuel Bouyer
On NetBSD, d_name is larger than 256, so file_name[284] may not be large enough (and gcc emits a format-truncation error). Use asprintf() instead of snprintf() on a static on-stack buffer. Signed-off-by: Manuel Bouyer --- tools/xenpmd/xenpmd.c | 8 1 file changed, 4 insertions(+), 4

[PATCH v2] libs/foreignmemory: Implement on NetBSD

2021-01-26 Thread Manuel Bouyer
Implement foreignmemory interface on NetBSD. The compat interface is now used only on __sun__ Signed-off-by: Manuel Bouyer --- tools/libs/foreignmemory/Makefile | 2 +- tools/libs/foreignmemory/netbsd.c | 66 +- tools/libs/foreignmemory/private.h | 6 +-- 3 files

[PATCH v2] NetBSD hotplug: Introduce locking functions

2021-01-26 Thread Manuel Bouyer
On NetBSD, some block device configuration requires serialisation. Introcuce locking functions (derived from the Linux version), and use them in the block script where appropriate. Signed-off-by: Manuel Bouyer --- tools/hotplug/NetBSD/Makefile | 1 + tools/hotplug/NetBSD/block | 5

[PATCH v2] Fix error: array subscript has type 'char'

2021-01-26 Thread Manuel Bouyer
Use unsigned char variable, or cast to (unsigned char), for tolower()/islower() and friends. Fix compiler error array subscript has type 'char' [-Werror=char-subscripts] Signed-off-by: Manuel Bouyer Reviewed-by: Ian Jackson Release-Acked-by: Ian Jackson --- tools/libs/light/libxl_qmp.c | 2

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-26 Thread Manuel Bouyer
g file, qemu-ifup is called with xenbr0 as bridge name. I tried this: vif = [ 'mac=00:16:3e:00:10:54, gatewaydev=wm0 type=ioemu, model=e1000' ] -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH] Fix error: array subscript has type 'char'

2021-01-26 Thread Manuel Bouyer
On Thu, Jan 14, 2021 at 03:16:15PM +0100, Manuel Bouyer wrote: > On Thu, Jan 14, 2021 at 02:25:05PM +0100, Jan Beulich wrote: > > On 14.01.2021 13:29, Manuel Bouyer wrote: > > > On Thu, Jan 14, 2021 at 11:53:20AM +0100, Jan Beulich wrote: > > >> On 12.01.2

Re: [PATCH] libs/gnttab: implement on NetBSD

2021-01-26 Thread Manuel Bouyer
On Mon, Jan 18, 2021 at 06:54:11PM +0100, Roger Pau Monné wrote: > On Tue, Jan 12, 2021 at 07:12:32PM +0100, Manuel Bouyer wrote: > > From: Manuel Bouyer > > > > Implement gnttab interface on NetBSD. > > The kernel interface is different from FreeBSD so we can't

Re: [PATCH] NetBSD hotplug: handle case where vifname is not present

2021-01-26 Thread Manuel Bouyer
On Fri, Jan 15, 2021 at 05:06:59PM +0100, Roger Pau Monné wrote: > On Tue, Jan 12, 2021 at 07:12:25PM +0100, Manuel Bouyer wrote: > > From: Manuel Bouyer > > > > Some Xen version didn't set the vifname in xenstore; just build one if > > not present. > > I think

Re: [PATCH] NetBSD hotplug: fix block unconfigure on destroy

2021-01-26 Thread Manuel Bouyer
On Fri, Jan 15, 2021 at 04:27:12PM +0100, Roger Pau Monné wrote: > On Tue, Jan 12, 2021 at 07:12:24PM +0100, Manuel Bouyer wrote: > > From: Manuel Bouyer > > > > When a domain is destroyed, xparams may not be available any more when > > the block script is ca

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-20 Thread Manuel Bouyer
On Wed, Jan 20, 2021 at 05:10:36PM +, Ian Jackson wrote: > Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without > setresuid()"): > > On Wed, Jan 20, 2021 at 03:32:29PM +, Ian Jackson wrote: > > > Yes, the dm is qemu. If qemu restricti

Re: [PATCH 05/24] Introduce locking functions for block device setup on NetBSD

2021-01-20 Thread Manuel Bouyer
On Wed, Jan 20, 2021 at 04:12:29PM +, Ian Jackson wrote: > Manuel Bouyer writes ("Re: [PATCH 05/24] Introduce locking functions for > block device setup on NetBSD"): > > Yes, at last the stat call will need to be patched. > > But it seems to rely on a li

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-20 Thread Manuel Bouyer
On Wed, Jan 20, 2021 at 03:32:29PM +, Ian Jackson wrote: > Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without > setresuid()"): > > On Wed, Jan 20, 2021 at 02:52:06PM +, Ian Jackson wrote: > > > I don't think setuid is safe - at leas

Re: [PATCH 05/24] Introduce locking functions for block device setup on NetBSD

2021-01-20 Thread Manuel Bouyer
On Wed, Jan 20, 2021 at 03:13:22PM +, Ian Jackson wrote: > Manuel Bouyer writes ("Re: [PATCH 05/24] Introduce locking functions for > block device setup on NetBSD"): > > On Tue, Dec 29, 2020 at 12:29:09PM +0100, Roger Pau Monné wrote: > > > I think you want t

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-20 Thread Manuel Bouyer
On Wed, Jan 20, 2021 at 02:52:06PM +, Ian Jackson wrote: > Roger Pau Monné writes ("Re: [PATCH] libs/light: make it build without > setresuid()"): > > On Tue, Jan 12, 2021 at 07:12:36PM +0100, Manuel Bouyer wrote: > > > From: Manuel Bouyer > > > &g

Re: NetBSD patches

2021-01-18 Thread Manuel Bouyer
he questions later this week. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH] libs/store: make build without PTHREAD_STACK_MIN

2021-01-18 Thread Manuel Bouyer
On Mon, Jan 18, 2021 at 06:56:46PM +, Andrew Cooper wrote: > On 12/01/2021 18:12, Manuel Bouyer wrote: > > From: Manuel Bouyer > > > > On NetBSD, PTHREAD_STACK_MIN is not available. > > Just use DEFAULT_THREAD_STACKSIZE if PTHREAD_STACK_MIN is not available. &g

Re: [PATCH] gdbsx: use right path for privcmd

2021-01-18 Thread Manuel Bouyer
On Mon, Jan 18, 2021 at 06:45:42PM +, Andrew Cooper wrote: > On 18/01/2021 18:03, Roger Pau Monné wrote: > > On Tue, Jan 12, 2021 at 07:12:28PM +0100, Manuel Bouyer wrote: > >> From: Manuel Bouyer > >> > >> On NetBSD the privcmd interface node is /k

Re: [PATCH] NetBSD: remove xenbackendd

2021-01-18 Thread Manuel Bouyer
On Mon, Jan 18, 2021 at 06:31:45PM +, Andrew Cooper wrote: > On 15/01/2021 15:31, Roger Pau Monné wrote: > > On Tue, Jan 12, 2021 at 07:12:26PM +0100, Manuel Bouyer wrote: > >> From: Manuel Bouyer > >> > >> NetBSD doens't need xenbackendd with xl toolstac

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-18 Thread Manuel Bouyer
On Mon, Jan 18, 2021 at 10:07:22AM +0100, Roger Pau Monné wrote: > On Mon, Jan 18, 2021 at 09:52:14AM +0100, Manuel Bouyer wrote: > > On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote: > > > I also wonder why NetBSD needs to add the tap interface to the bridge

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-18 Thread Manuel Bouyer
On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote: > On Sat, Jan 16, 2021 at 12:25:02PM +0100, Manuel Bouyer wrote: > > On Sat, Jan 16, 2021 at 11:16:06AM +0100, Roger Pau Monné wrote: > > > On Tue, Jan 12, 2021 at 07:12:37PM +0100, Manuel Bouyer wrote: > >

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-16 Thread Manuel Bouyer
On Sat, Jan 16, 2021 at 11:16:06AM +0100, Roger Pau Monné wrote: > On Tue, Jan 12, 2021 at 07:12:37PM +0100, Manuel Bouyer wrote: > > From: Manuel Bouyer > > > > Pass bridge name to qemu as command line option > > When starting qemu, set an environnement variable XE

Re: [PATCH] NetBSD: Fix lock directory path

2021-01-15 Thread Manuel Bouyer
On Fri, Jan 15, 2021 at 04:09:19PM +0100, Roger Pau Monné wrote: > On Tue, Jan 12, 2021 at 07:12:22PM +0100, Manuel Bouyer wrote: > > From: Manuel Bouyer > > > > On NetBSD the lock directory is in /var/run/ > > > > Signed-off-by: Manuel Bouyer > >

Re: [PATCH] Fix error: array subscript has type 'char'

2021-01-14 Thread Manuel Bouyer
On Thu, Jan 14, 2021 at 02:25:05PM +0100, Jan Beulich wrote: > On 14.01.2021 13:29, Manuel Bouyer wrote: > > On Thu, Jan 14, 2021 at 11:53:20AM +0100, Jan Beulich wrote: > >> On 12.01.2021 19:12, Manuel Bouyer wrote: > >>> From: Manuel Bouyer > >>>

Re: [PATCH] Fix error: array subscript has type 'char'

2021-01-14 Thread Manuel Bouyer
On Thu, Jan 14, 2021 at 11:53:20AM +0100, Jan Beulich wrote: > On 12.01.2021 19:12, Manuel Bouyer wrote: > > From: Manuel Bouyer > > > > Use unsigned char variable, or cast to (unsigned char), for > > tolower()/islower() and friends. Fix compiler error > &g

Re: [PATCH] ocaml/libs/eventchn: drop unneeded evtchn.h

2021-01-13 Thread Manuel Bouyer
On Wed, Jan 13, 2021 at 09:22:38AM +, Christian Lindig wrote: > Acked-by: Christian Lindig thanks. What should I do now, submit a new patch with this tag, or just wait for it to be commited ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

[PATCH] libs/store: make build without PTHREAD_STACK_MIN

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer On NetBSD, PTHREAD_STACK_MIN is not available. Just use DEFAULT_THREAD_STACKSIZE if PTHREAD_STACK_MIN is not available. Signed-off-by: Manuel Bouyer --- tools/libs/store/xs.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/libs/store/xs.c b/tools/libs/store

[PATCH] libs/light: fix tv_sec printf format

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Don't assume tv_sec is a unsigned long, it is 64 bits on NetBSD 32 bits. Use %jd and cast to (intmax_t) instead Signed-off-by: Manuel Bouyer --- tools/libs/light/libxl_create.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libs/light

[PATCH] xenpmd.c: use dynamic allocation

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer On NetBSD, d_name is larger than 256, so file_name[284] may not be large enough (and gcc emits a format-truncation error). Use asprintf() instead of snprintf() on a static on-stack buffer. Signed-off-by: Manuel Bouyer --- tools/xenpmd/xenpmd.c | 8 1 file changed

[PATCH] libs/light: make it build without setresuid()

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer NetBSD doesn't have setresuid(). Add a configure check for it, and use plain setuid() if !HAVE_SETRESUID Signed-off-by: Manuel Bouyer --- tools/configure | 13 + tools/configure.ac | 3 +++ tools/libs/light/libxl_dm.c | 10 ++ 3

[PATCH] xenstat_netbsd: remove usused code

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer remove PROCNETDEV_HEADER[] and read_attributes_vbd(), gcc complains that they are unused Signed-off-by: Manuel Bouyer --- tools/libs/stat/xenstat_netbsd.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/tools/libs/stat/xenstat_netbsd.c b/tools/libs/stat

[PATCH] libs/evtchn: fix build on NetBSD.

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer use xenio3.h for ioctl definitions read_exact/write_exact seems to not be available here, which cause a gcc error. Use plain read/write, the xenevtchn interface won't do partial read/write on NetBSD anyway so it should be safe. Signed-off-by: Manuel Bouyer Fixes

[PATCH] gdbsx: use right path for privcmd

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer On NetBSD the privcmd interface node is /kern/xen/privcmd Signed-off-by: Manuel Bouyer --- tools/debugger/gdbsx/xg/xg_main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/debugger/gdbsx/xg/xg_main.c b/tools/debugger/gdbsx/xg

[PATCH] libs/call: fix build on NetBSD

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Define PAGE_* if not already defined Catch up with osdep interface change. Signed-off-by: Manuel Bouyer --- tools/libs/call/netbsd.c | 19 +++ tools/libs/call/private.h | 6 -- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/tools

[PATCH] ocaml/libs/eventchn: drop unneeded evtchn.h

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer On NetBSD xen/sys/evtchn.h is not available any more. Just remove it as it's not needed. Signed-off-by: Manuel Bouyer --- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c b

[PATCH] libs/foreignmemory: Implement on NetBSD

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Implement foreignmemory interface on NetBSD. The compat interface is now used only on __sun__ Signed-off-by: Manuel Bouyer --- tools/libs/foreignmemory/Makefile | 2 +- tools/libs/foreignmemory/netbsd.c | 75 ++ tools/libs/foreignmemory

[PATCH] libs/gnttab: implement on NetBSD

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Implement gnttab interface on NetBSD. The kernel interface is different from FreeBSD so we can't use the FreeBSD version Signed-off-by: Manuel Bouyer --- tools/libs/gnttab/Makefile | 2 +- tools/libs/gnttab/netbsd.c | 267 + 2 files

[PATCH] libs/light: Switch NetBSD to QEMU_XEN

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Switch NetBSD to QEMU_XEN. All 3 versions of libxl__default_device_model() now return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN, so remove it and just set b_info->device_model_version to LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN in libxl__domain_build_info_setdefault(). Signed-

[PATCH] libs/light: fix uuid on NetBSD

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer NetBSD uses the same uuid library as FreeBSD. As this is in a __FreeBSD__ || __NetBSD__ block, just drop the #ifdef __FreeBSD__ and dead code. Signed-off-by: Manuel Bouyer --- tools/libs/light/libxl_uuid.c | 21 - 1 file changed, 21 deletions(-) diff

[PATCH] libs/light: pass some infos to qemu

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Pass bridge name to qemu as command line option When starting qemu, set an environnement variable XEN_DOMAIN_ID, to be used by qemu helper scripts Signed-off-by: Manuel Bouyer --- tools/libs/light/libxl_dm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools

  1   2   3   >