/O completion handlers can't
> take sleeping locks or freeze the queue. Keep the existing clearing of
> the relevant field to zero, but replace the old blk_queue_max_* APIs
> with new disable APIs that force the value to 0.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Remove all APIs that are unused now that sd and sr have been converted
> to the atomic queue limits API.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
d limits.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
d-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Split the logic to pick the right discard mode into a little helper
> to prepare for further changes.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Fall through to the main call to blk_queue_max_discard_sectors given
> that max_blocks has been initialized to zero above instead of
> duplicating the call.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
limits
> API.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
e limits API.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
has probably been
> around for far too long to change this now.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
bilities (sd).
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
he readahead size despite it's
> name actually limits the size of any buffered read) and to prepare for
> using io_opt in the max_sectors calculation and getting drivers out of
> the business of overriding the max_user_sectors value.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
at actually failed.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Instead of a separate handler function that leaves no work in the
> interrupt hanler itself, split out a per-request end I/O helper and
^^ handler
> clean up the coding style and variable naming while we're at it.
Reviewed-by: Martin K. Petersen
cile your
changes with mine...
--
Martin K. Petersen Oracle Linux Engineering
t; [...]
Applied to 6.6/scsi-queue, thanks!
[1/1] xen/scsifront: shost_priv() can never return NULL
https://git.kernel.org/mkp/scsi/c/73c7881b5066
--
Martin K. Petersen Oracle Linux Engineering
Juergen,
> There is no need to check whether shost_priv() returns a non-NULL
> value, as the pointer returned is just an offset to the passed in
> parameter.
>
> While at it replace an open coded shost_priv() instance.
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Peter
nded up with "discard_alignment" when I called the
corresponding I/O parameter "alignment_offset".
Anyway. All this looks good to me.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Secure erase is a very different operation from discard in that it is
> a data integrity operation vs hint. Fully split the limits and helper
> infrastructure to make the separation more clear.
Great!
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Ora
for
> write zeroes as well.
Nicer!
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
Very happy to finally see this flag removed!
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Abstract away implementation details from file systems by providing a
> block_device based helper to retreive the discard granularity.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Move all the logic to limit the discard bio size into a common helper
> so that it is better documented.
Looks OK.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
misaligned
flag.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Use the bdev based alignment helper instead of open coding it.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Just use bdev_alignment_offset in disk_discard_alignment_show instead.
> That helpers is the same except for an always false branch that
> doesn't matter in this slow path.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> No need to inline these fairly larger helpers.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> This does the same as the open coded variant except for an extra
> branch, and allows to remove queue_alignment_offset entirely.
Also fine.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Add a helper to check the nonrot flag based on the block_device
> instead of having to poke into the block layer internal request_queue.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Use the proper bdev_discard_alignment helper that accounts for partition
> offsets.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Add a helper to check the stable writes flag based on the block_device
> instead of having to poke into the block layer internal request_queue.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Add a helper to check the FUA flag based on the block_device instead
> of having to poke into the block layer internal request_queue.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Add a helper to check the write cache flag based on the block_device
> instead of having to poke into the block layer internal request_queue.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Add a helper to check the max supported sectors for zone append based
> on the block_device instead of having to poke into the block layer
> internal request_queue.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> The target code is a consumer of the block layer and should generally
> work on struct block_device.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
iewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
> Fixes: 2237498f0b5c ("target/iblock: Convert WRITE_SAME to
> blkdev_issue_zeroout")
> Signed-off-by: Christoph Hellwig
--
Martin K. Petersen Oracle Linux Engineering
ups of
> patches now:
>
> [...]
Applied to 5.16/scsi-queue, thanks!
[1/9] scsi/sd: add error handling support for add_disk()
https://git.kernel.org/mkp/scsi/c/2a7a891f4c40
[2/9] scsi/sr: add error handling support for add_disk()
https://git.kernel.org/mkp/scsi/c/e9d658c
Luis,
> Thanks, would you like Jens to pick this up and the other scsi/sr patch
> or are you taking it through your tree?
Didn't think I had the relevant add_disk() patch in my baseline tree but
it turns out I do. So I queued them up.
Thanks!
--
Martin K. Petersen O
Luis,
> We never checked for errors on add_disk() as this function returned
> void. Now that this is fixed, use the shiny new error handling.
>
> Just put the cdrom kref and have the unwinding be done by
> sr_kref_release().
Acked-by: Martin K. Petersen
--
Martin K. Peter
scsi_disk_release().
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
eak/goto/return/fallthrough statements instead of just
> letting the code fall through to the next case.
>
> [...]
Applied to 5.11/scsi-queue, thanks!
[054/141] target: Fix fall-through warnings for Clang
https://git.kernel.org/mkp/scsi/c/492096ecfa39
--
Martin K. Petersen Oracle Linux Engineering
Gustavo,
> This series aims to fix almost all remaining fall-through warnings in
> order to enable -Wimplicit-fallthrough for Clang.
Applied 20-22,54,120-124 to 5.11/scsi-staging, thanks.
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> This avoids the extra call to revalidate_disk_size in sd_rescan and
> is otherwise a no-op because the size did not change, or we are in
> the probe path.
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
FT" too and rename SECTOR_MASK to PAGE_SECTORS_MASK.
Looks OK to me.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prefer adding a check ?
I checked your call sites and they look fine. Also, I don't think
returning a capacity of 0 on error is going to help us much.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Hi Chaitanya,
> +static inline sector_t bdev_nr_sects(struct block_device *bdev)
> +{
> + return part_nr_sects_read(bdev->bd_part);
> +}
Can bdev end up being NULL in any of the call sites?
Otherwise no objections.
--
Martin K. Petersen Oracle Li
Hi Gustavo,
> Only 8 out the 41 patches in this series have been applied so far.
I applied the patches that got acked or reviewed by their respective
driver maintainers.
If you haven't received feedback on a patch you should poke the relevant
driver maintainer.
--
Martin K.
h - Missed the backend's Closing state", which
> contains the "fall through" annotation at the beginnig of
> the code comment, which is what GCC is expecting to find.
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
50 matches
Mail list logo
