Re: [PATCH] xen/events: close evtchn after mapping cleanup

On Wed, Jan 24, 2024 at 04:31:28PM +, Maximilian Heyne wrote: > shutdown_pirq and startup_pirq are not taking the > irq_mapping_update_lock because they can't due to lock inversion. Both > are called with the irq_desc->lock being taking. The lock order, &g

[PATCH] xen/events: close evtchn after mapping cleanup

rnel.org Co-debugged-by: Andrew Panyakin Signed-off-by: Maximilian Heyne --- drivers/xen/events/events_base.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index b8cfea7812d6..3b9f080109d7 100644 --- a/dr

Re: [PATCH] x86/pci/xen: populate MSI sysfs entries

On Wed, May 03, 2023 at 01:16:53PM +, Maximilian Heyne wrote: > Commit bf5e758f02fc ("genirq/msi: Simplify sysfs handling") reworked the > creation of sysfs entries for MSI IRQs. The creation used to be in > msi_domain_alloc_irqs_descs_locked after calling ops->domain

[PATCH] x86/pci/xen: populate MSI sysfs entries

domain_info but that doesn't actually have an effect because Xen uses it's own domain_alloc_irqs implementation. Fix this by making use of the fallback functions for sysfs population. Fixes: bf5e758f02fc ("genirq/msi: Simplify sysfs handling") Signed-off-by: Maximilian Heyne ---

Re: [PATCH v2 1/3] xen-blkback: Advertise feature-persistent as user requested

On Fri, Sep 02, 2022 at 09:53:22AM +, Pratyush Yadav wrote: > On 31/08/22 04:58PM, SeongJae Park wrote: > > The advertisement of the persistent grants feature (writing > > 'feature-persistent' to xenbus) should mean not the decision for using > > the feature but only the availability of the fea

Re: [PATCH v2 0/3] xen-blk{front, back}: Fix the broken semantic and flow of feature-persistent

ways: * Only applied the blkback patch but not the blkfront patches * Only applied the blkfront patches but not the blkback patch * Applied both All scenarios worked, so Tested-by: Maximilian Heyne Actually I also wanted to test changing feature_persistent and try reconnecting but I don't k

Re: [PATCH 2/2] xen-blkfront: Advertise feature-persistent as user requested

On Thu, Aug 25, 2022 at 04:15:11PM +, SeongJae Park wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > Commit e94c6101e151 ("xen-blkback: Apply 'feature

Re: [PATCH v4 0/3] xen-blk{back, front}: Fix two bugs in 'feature_persistent'

to follow the changed behavior > - Update documents for the changed behavior > > Changes from v1 > (https://lore.kernel.org/xen-devel/20220106091013.126076-1-mhe...@amazon.de/) > - Avoid the behavioral change > (https://lore.kernel.org/xen-devel/20220121102309.27802-1...@kernel.org/) >

[PATCH] x86: xen: remove STACK_FRAME_NON_STANDARD from xen_cpuid

commit is basically a revert of commit 983bb6d254c7 ("x86/xen: Mark xen_cpuid() stack frame as non-standard"). Signed-off-by: Maximilian Heyne CC: Josh Poimboeuf cr: https://code.amazon.com/reviews/CR-69645080 --- arch/x86/xen/enlighten_pv.c | 2 -- 1 file changed, 2 deletions(-) d

[PATCH 4/4] x86: kprobes: Prohibit probing on instruction which has emulate prefix

f Link: https://lkml.kernel.org/r/156777566048.25081.6296162369492175325.stgit@devnote2 Signed-off-by: Maximilian Heyne Cc: sta...@vger.kernel.org # 5.4.x --- arch/x86/kernel/kprobes/core.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprob

[PATCH 3/4] x86: xen: insn: Decode Xen and KVM emulate-prefix signature

.org Cc: Randy Dunlap Link: https://lkml.kernel.org/r/156777564986.25081.4964537658500952557.stgit@devnote2 [mheyne: resolved contextual conflict in tools/objtools/sync-check.sh] Signed-off-by: Maximilian Heyne Cc: sta...@vger.kernel.org # 5.4.x --- arch/x86/include/asm/insn.h

[PATCH 2/4] x86: xen: kvm: Gather the definition of emulate prefixes

@devnote2 Signed-off-by: Maximilian Heyne Cc: sta...@vger.kernel.org # 5.4.x --- arch/x86/include/asm/emulate_prefix.h | 14 ++ arch/x86/include/asm/xen/interface.h | 11 --- arch/x86/kvm/x86.c| 4 +++- 3 files changed, 21 insertions(+), 8 deletions(-) create

[PATCH 0/4] x86: decode Xen/KVM emulate prefixes

This is a backport of a patch series for 5.4.x. The patch series allows the x86 decoder to decode the Xen and KVM emulate prefixes. In particular this solves the following issue that appeared when commit db6c6a0df840 ("objtool: Fix noreturn detection for ignored functions") was backported to 5.4.

[PATCH 1/4] x86/asm: Allow to pass macros to __ASM_FORM()

: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777562873.25081.2288083344657460959.stgit@devnote2 Signed-off-by: Maximilian Heyne Cc: sta

[PATCH 4/4] x86: kprobes: Prohibit probing on instruction which has emulate prefix

f Link: https://lkml.kernel.org/r/156777566048.25081.6296162369492175325.stgit@devnote2 Signed-off-by: Maximilian Heyne Cc: sta...@vger.kernel.org # 5.4.x --- arch/x86/kernel/kprobes/core.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprob

[PATCH 2/4] x86: xen: kvm: Gather the definition of emulate prefixes

@devnote2 Signed-off-by: Maximilian Heyne Cc: sta...@vger.kernel.org # 5.4.x --- arch/x86/include/asm/emulate_prefix.h | 14 ++ arch/x86/include/asm/xen/interface.h | 11 --- arch/x86/kvm/x86.c| 4 +++- 3 files changed, 21 insertions(+), 8 deletions(-) create

[PATCH 0/4] x86: decode Xen/KVM emulate prefixes

This is a backport of a patch series for 5.4.x. The patch series allows the x86 decoder to decode the Xen and KVM emulate prefixes. In particular this solves the following issue that appeared when commit db6c6a0df840 ("objtool: Fix noreturn detection for ignored functions") was backported to 5.4.

[PATCH 1/4] x86/asm: Allow to pass macros to __ASM_FORM()

: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777562873.25081.2288083344657460959.stgit@devnote2 Signed-off-by: Maximilian Heyne Cc: sta

[PATCH 3/4] x86: xen: insn: Decode Xen and KVM emulate-prefix signature

.org Cc: Randy Dunlap Link: https://lkml.kernel.org/r/156777564986.25081.4964537658500952557.stgit@devnote2 [mheyne: resolved contextual conflict in tools/objtools/sync-check.sh] Signed-off-by: Maximilian Heyne Cc: sta...@vger.kernel.org # 5.4.x --- arch/x86/include/asm/insn.h

[PATCH] xen, blkback: fix persistent grants negotiation

this. Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") Signed-off-by: Maximilian Heyne --- drivers/block/xen-blkback/xenbus.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/blo

[PATCH v2] xen/events: Fix race in set_evtchn_to_irq

d-off-by: Maximilian Heyne Fixes: d0b075ffeede ("xen/events: Refactor evtchn_to_irq array to be dynamically allocated") --- drivers/xen/events/events_base.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/xen/events/events_base.c b/

[PATCH] xen/events: Fix race in set_evtchn_to_irq

-by: Maximilian Heyne Fixes: d0b075ffeede ("xen/events: Refactor evtchn_to_irq array to be dynamically allocated") --- drivers/xen/events/events_base.c | 35 ++-- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/drivers/xen/events/events_base.c b/drive

Re: [PATCH 0/3] Cleanup IOREQ server on exit

Could someone please have a look at this patch? It solves an actual issue: Try soft-reset with qemu-xen-traditional and it will fail. On 3/13/20 1:33 PM, Maximilian Heyne wrote: Following up on commit 9c0eed61 ("qemu-trad: stop using the default IOREQ server"), clean up the IOREQ serv

[Xen-devel] [PATCH 1/3] Add support for generic notifier lists

o memory allocations by placing list nodes in notifier [cherry-picked from d1e70c5e6d1472856c52969301247fe8c3c8389d conflicts: used the sys-qeue interface and added required LIST_REMOVE_SAFE function to that] Signed-off-by: Maximilian Heyne --- Makefile| 1 + notify.c

[Xen-devel] [PATCH 3/3] xen: cleanup IOREQ server on exit

an be seen as a backport of ba7fdd64 ("xen: cleanup IOREQ server on exit"). Signed-off-by: Maximilian Heyne --- hw/xen_machine_fv.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/xen_machine_fv.c b/hw/xen_machine_fv.c index f0989fad4..66eb4a1eb 100644 --- a/hw/

[Xen-devel] [PATCH 0/3] Cleanup IOREQ server on exit

27;t be bound again. For this I used the exit notifiers from QEMU that I backported together with the required generic notifier lists. Anthony Liguori (1): Add support for generic notifier lists Gerd Hoffmann (1): Add exit notifiers. Maximilian Heyne (1): xen: cleanup IOREQ server on exit

[Xen-devel] [PATCH 2/3] Add exit notifiers.

, say when un-plugging a device. [ v2: move code out of #ifndef _WIN32 ] Signed-off-by: Anthony Liguori (cherry picked from commit fd42deeb4cb42f90084046e3ebdb4383953195e3) Signed-off-by: Maximilian Heyne --- sysemu.h | 5 + vl.c | 20 2 files changed, 25 insertions