Re: [PATCH] drm: Explicitly include correct DT includes

2023-07-17 Thread Rob Herring
On Sun, Jul 16, 2023 at 3:26 AM Heiko Stuebner wrote: > > Am Freitag, 14. Juli 2023, 19:45:34 CEST schrieb Rob Herring: > > The DT of_device.h and of_platform.h date back to the separate > > of_platform_bus_type before it as merged into the regular platform bus. > > As par

[PATCH] drm: Explicitly include correct DT includes

2023-07-15 Thread Rob Herring
s a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring --- drivers/gpu/drm/arm/disp

Re: [PATCH V4 5/8] dt-bindings: Add xen,grant-dma IOMMU description for xen-grant DMA ops

2022-06-05 Thread Rob Herring
rant DMA > ops" > > Changes V3 -> V4: >- add Stefano's R-b >- remove underscore in iommu node name >- remove consumer example virtio@3000 >- update text for two descriptions > --- > .../devicetree/bindings/iommu/xen,grant-dma.yaml | 39 > ++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml > Reviewed-by: Rob Herring

Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops

2022-05-24 Thread Rob Herring
+Saravana On Mon, May 23, 2022 at 06:58:13PM -0700, Stefano Stabellini wrote: > On Mon, 23 May 2022, Oleksandr wrote: > > > > On Thu, 19 May 2022, Oleksandr wrote: > > > > > > On Wed, May 18, 2022 at 5:06 PM Oleksandr > > > > > > wrote: > > > > > > > On 18.05.22 17:32, Arnd Bergmann wrote: > >

Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops

2022-05-18 Thread Rob Herring
On Wed, May 18, 2022 at 03:32:27PM +0100, Arnd Bergmann wrote: > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko > wrote: > > > > diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml > > b/Documentation/devicetree/bindings/virtio/mmio.yaml > > index 10c22b5..29a0932 100644 > >

Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops

2022-05-16 Thread Rob Herring
On Sat, May 07, 2022 at 09:19:06PM +0300, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Introduce Xen specific binding for the virtualized device (e.g. virtio) > to be used by Xen grant DMA-mapping layer in the subsequent commit. > > This binding indicates that Xen grant mappings

Re: [PATCH V1 4/6] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops

2022-05-03 Thread Rob Herring
On Tue, May 03, 2022 at 08:09:32PM +0300, Oleksandr wrote: > > On 03.05.22 00:59, Rob Herring wrote: > > Hello Rob > > > > On Fri, Apr 22, 2022 at 07:51:01PM +0300, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > > > > >

Re: [PATCH V1 4/6] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops

2022-05-02 Thread Rob Herring
On Fri, Apr 22, 2022 at 07:51:01PM +0300, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Introduce Xen specific binding for the virtualized device (e.g. virtio) > to be used by Xen grant DMA-mapping layer in the subsequent commit. > > This binding indicates that Xen grant mappings

Re: [PATCH v2] of: of_property_read_string return -ENODATA when !length

2022-04-19 Thread Rob Herring
On Fri, 15 Apr 2022 17:30:28 -0700, Stefano Stabellini wrote: > From: Stefano Stabellini > > When the length of the string is zero of_property_read_string should > return -ENODATA according to the description of the function. > > However, of_property_read_string doesn't check prop->length. If >

Re: [PATCH] of: of_property_read_string return -ENODATA when !length

2022-04-04 Thread Rob Herring
On Fri, Apr 01, 2022 at 03:43:42PM -0700, Stefano Stabellini wrote: > On Fri, 1 Apr 2022, Rob Herring wrote: > > On Fri, Apr 1, 2022 at 3:49 PM Stefano Stabellini > > wrote: > > > > > > On Fri, 1 Apr 2022, Rob Herring wrote: > > > > On Th

Re: [PATCH] of: of_property_read_string return -ENODATA when !length

2022-04-01 Thread Rob Herring
On Fri, Apr 1, 2022 at 3:49 PM Stefano Stabellini wrote: > > On Fri, 1 Apr 2022, Rob Herring wrote: > > On Thu, Mar 31, 2022 at 7:46 PM Stefano Stabellini > > wrote: > > > > > > From: Stefano Stabellini > > > > > > When the lengt

Re: [PATCH] of: of_property_read_string return -ENODATA when !length

2022-04-01 Thread Rob Herring
On Thu, Mar 31, 2022 at 7:46 PM Stefano Stabellini wrote: > > From: Stefano Stabellini > > When the length of the string is zero of_property_read_string should > return -ENODATA according to the description of the function. Perhaps it is a difference of: prop; vs. prop = ""; Both are 0

Re: [PATCH v3 1/2] dt-bindings: arm: xen: document Xen iommu device

2022-02-04 Thread Rob Herring
On Wed, Jan 26, 2022 at 10:56:39AM -0800, Stefano Stabellini wrote: > On Wed, 26 Jan 2022, Robin Murphy wrote: > > On 2022-01-26 15:09, Sergiy Kibrik wrote: > > > Hi Robin, > > > > > > > > > > > This could break Linux guests, since depending on the deferred probe > > > > timeout setting it could

Re: [PATCH V4 6/6] dt-bindings: xen: Clarify "reg" purpose

2021-12-10 Thread Rob Herring
6c20-cdc7-23f3-9e4f8fd72...@xen.org/T/#t > so technically restore V3 state >- remove Stefano's R-b and Rob's A-b as I am not 100% sure they are > happy with that > --- > Documentation/devicetree/bindings/arm/xen.txt | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > Acked-by: Rob Herring

Re: [PATCH V3 6/6] dt-bindings: xen: Clarify "reg" purpose

2021-11-28 Thread Rob Herring
evice-tree/guest.txt;hb=refs/heads/master > > Changes V2 -> V3: >- new patch > --- > Documentation/devicetree/bindings/arm/xen.txt | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > Acked-by: Rob Herring

Re: [PATCH v4 13/14] dt-bindings: of: Add restricted DMA pool

2021-03-10 Thread Rob Herring
On Wed, Mar 10, 2021 at 9:08 AM Will Deacon wrote: > > Hi Claire, > > On Tue, Feb 09, 2021 at 02:21:30PM +0800, Claire Chang wrote: > > Introduce the new compatible string, restricted-dma-pool, for restricted > > DMA. One can specify the address and length of the restricted DMA memory > > region

Re: Question on PCIe Device Tree bindings, Was: [PATCH] xen/arm: domain_build: Ignore device nodes with invalid addresses

2021-02-05 Thread Rob Herring
On Thu, Feb 4, 2021 at 9:51 PM Elliott Mitchell wrote: > > On Thu, Feb 04, 2021 at 03:52:26PM -0600, Rob Herring wrote: > > On Thu, Feb 4, 2021 at 3:33 PM Stefano Stabellini > > wrote: > > > > > > On Thu, 4 Feb 2021, Rob Herring wrote: > > > > O

Re: Question on PCIe Device Tree bindings, Was: [PATCH] xen/arm: domain_build: Ignore device nodes with invalid addresses

2021-02-04 Thread Rob Herring
On Thu, Feb 4, 2021 at 3:33 PM Stefano Stabellini wrote: > > On Thu, 4 Feb 2021, Rob Herring wrote: > > On Thu, Feb 4, 2021 at 2:36 PM Stefano Stabellini > > wrote: > > > > > > On Thu, 4 Feb 2021, Rob Herring wrote: > > > > On Thu, Feb 4, 20

Re: Question on PCIe Device Tree bindings, Was: [PATCH] xen/arm: domain_build: Ignore device nodes with invalid addresses

2021-02-04 Thread Rob Herring
On Thu, Feb 4, 2021 at 2:36 PM Stefano Stabellini wrote: > > On Thu, 4 Feb 2021, Rob Herring wrote: > > On Thu, Feb 4, 2021 at 11:56 AM Stefano Stabellini > > wrote: > > > > > > Hi Rob, > > > > > > We have a question on the PCIe devic

Re: Question on PCIe Device Tree bindings, Was: [PATCH] xen/arm: domain_build: Ignore device nodes with invalid addresses

2021-02-04 Thread Rob Herring
On Thu, Feb 4, 2021 at 11:56 AM Stefano Stabellini wrote: > > Hi Rob, > > We have a question on the PCIe device tree bindings. In summary, we have > come across the Raspberry Pi 4 PCIe description below: > > > pcie0: pcie@7d50 { >compatible = "brcm,bcm2711-pcie"; >reg = <0x0

Re: [RFC PATCH v3 5/6] dt-bindings: of: Add restricted DMA pool

2021-01-21 Thread Rob Herring
On Wed, Jan 20, 2021 at 7:10 PM Robin Murphy wrote: > > On 2021-01-20 21:31, Rob Herring wrote: > > On Wed, Jan 20, 2021 at 11:30 AM Robin Murphy wrote: > >> > >> On 2021-01-20 16:53, Rob Herring wrote: > >>> On Wed, Jan 06, 2021 at 11:41:23AM +0800, Cl

Re: [RFC PATCH v3 5/6] dt-bindings: of: Add restricted DMA pool

2021-01-20 Thread Rob Herring
On Wed, Jan 20, 2021 at 11:30 AM Robin Murphy wrote: > > On 2021-01-20 16:53, Rob Herring wrote: > > On Wed, Jan 06, 2021 at 11:41:23AM +0800, Claire Chang wrote: > >> Introduce the new compatible string, restricted-dma-pool, for restricted > >> DMA. One can

Re: [RFC PATCH v3 5/6] dt-bindings: of: Add restricted DMA pool

2021-01-20 Thread Rob Herring
On Wed, Jan 06, 2021 at 11:41:23AM +0800, Claire Chang wrote: > Introduce the new compatible string, restricted-dma-pool, for restricted > DMA. One can specify the address and length of the restricted DMA memory > region by restricted-dma-pool in the device tree. If this goes into DT, I think we

Re: [patch 19/30] PCI: mobiveil: Use irq_data_get_irq_chip_data()

2020-12-10 Thread Rob Herring
r > Cc: Karthikeyan Mitran > Cc: Hou Zhiqiang > Cc: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Bjorn Helgaas > Cc: linux-...@vger.kernel.org > --- > drivers/pci/controller/mobiveil/pcie-mobiveil-host.c |8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Rob Herring

Re: [patch 18/30] PCI: xilinx-nwl: Use irq_data_get_irq_chip_data()

2020-12-10 Thread Rob Herring
er > Cc: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Bjorn Helgaas > Cc: Michal Simek > Cc: linux-...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > --- > drivers/pci/controller/pcie-xilinx-nwl.c |8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Rob Herring

Re: RFC: PCI devices passthrough on Arm design proposal

2020-07-20 Thread Rob Herring
On Mon, Jul 20, 2020 at 5:24 PM Stefano Stabellini wrote: > > + Rob Herring > > On Fri, 17 Jul 2020, Bertrand Marquis wrote: > > >> Regarding the DT entry, this is not coming from us and this is already > > >> defined this way in existing DT

Re: [Xen-devel] [PATCH v2] xen: Stop abusing DT of_dma_configure API

2019-10-10 Thread Rob Herring
On Thu, Oct 10, 2019 at 9:00 AM Boris Ostrovsky wrote: > > On 10/9/19 7:42 AM, Oleksandr Andrushchenko wrote: > > On 10/8/19 10:41 PM, Rob Herring wrote: > >> As the removed comments say, these aren't DT based devices. > >> of_dma_configure() is going to stop allow

[Xen-devel] [PATCH v2] xen: Stop abusing DT of_dma_configure API

2019-10-08 Thread Rob Herring
Oleksandr Andrushchenko Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Christoph Hellwig Cc: xen-devel@lists.xenproject.org Signed-off-by: Rob Herring --- v2: - Setup dma masks - Also fix xen_drm_front.c This can now be applied to the Xen tree independent of

Re: [Xen-devel] [RFC PATCH] xen/gntdev: Stop abusing DT of_dma_configure API

2019-09-26 Thread Rob Herring
On Thu, Sep 26, 2019 at 6:16 AM Oleksandr Andrushchenko wrote: > > On 9/26/19 1:46 PM, Robin Murphy wrote: > > On 2019-09-26 11:17 am, Oleksandr Andrushchenko wrote: > >> > >> On 9/26/19 12:49 PM, Julien Grall wrote: > >>> Hi Rob, > >>&

[Xen-devel] [RFC PATCH] xen/gntdev: Stop abusing DT of_dma_configure API

2019-09-25 Thread Rob Herring
Andrushchenko Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-devel@lists.xenproject.org Signed-off-by: Rob Herring --- drivers/xen/gntdev.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index a446a7221e13..59906f9a40e4

Re: [Xen-devel] [PATCH 00/11] of: Fix DMA configuration for non-DT masters

2019-09-25 Thread Rob Herring
On Wed, Sep 25, 2019 at 11:52 AM Robin Murphy wrote: > > On 25/09/2019 17:16, Rob Herring wrote: > > On Wed, Sep 25, 2019 at 10:30 AM Nicolas Saenz Julienne > > wrote: > >> > >> On Wed, 2019-09-25 at 16:09 +0100, Robin Murphy wrote: > >>> O

Re: [Xen-devel] [PATCH 00/11] of: Fix DMA configuration for non-DT masters

2019-09-25 Thread Rob Herring
On Wed, Sep 25, 2019 at 10:30 AM Nicolas Saenz Julienne wrote: > > On Wed, 2019-09-25 at 16:09 +0100, Robin Murphy wrote: > > On 25/09/2019 15:52, Nicolas Saenz Julienne wrote: > > > On Tue, 2019-09-24 at 16:59 -0500, Rob Herring wrote: > > > > On Tue, Sep

Re: [Xen-devel] [PATCH 00/11] of: Fix DMA configuration for non-DT masters

2019-09-25 Thread Rob Herring
On Wed, Sep 25, 2019 at 9:53 AM Nicolas Saenz Julienne wrote: > > On Tue, 2019-09-24 at 16:59 -0500, Rob Herring wrote: > > On Tue, Sep 24, 2019 at 1:12 PM Nicolas Saenz Julienne > > wrote: > > > Hi All, > > > this series tries to address one of the issue

Re: [Xen-devel] [PATCH 00/11] of: Fix DMA configuration for non-DT masters

2019-09-24 Thread Rob Herring
On Tue, Sep 24, 2019 at 1:12 PM Nicolas Saenz Julienne wrote: > > Hi All, > this series tries to address one of the issues blocking us from > upstreaming Broadcom's STB PCIe controller[1]. Namely, the fact that > devices not represented in DT which sit behind a PCI bus fail to get the > bus' DMA

Re: [Xen-devel] [PATCH v2 19/21] treewide: add checks for the return value of memblock_alloc*()

2019-01-21 Thread Rob Herring
3 +++ > arch/x86/platform/olpc/olpc_dt.c | 3 +++ > arch/x86/xen/p2m.c| 11 +-- > arch/xtensa/mm/kasan_init.c | 4 > arch/xtensa/mm/mmu.c | 3 +++ > drivers/clk/ti/clk.c | 3 +++ > driv

Re: [Xen-devel] [PATCH 19/21] treewide: add checks for the return value of memblock_alloc*()

2019-01-16 Thread Rob Herring
/xtensa/mm/kasan_init.c | 4 > arch/xtensa/mm/mmu.c | 3 +++ > drivers/clk/ti/clk.c | 3 +++ > drivers/macintosh/smu.c | 3 +++ > drivers/of/fdt.c | 8 ++

Re: [Xen-devel] [PATCH 08/21] memblock: drop __memblock_alloc_base()

2019-01-16 Thread Rob Herring
de/linux/memblock.h | 2 -- > mm/memblock.c | 9 ++--- > 6 files changed, 11 insertions(+), 24 deletions(-) Acked-by: Rob Herring ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v5] devicetree, xen: add xen, shared-memory binding

2018-12-07 Thread Rob Herring
On Mon, Dec 03, 2018 at 02:26:09PM -0800, Stefano Stabellini wrote: > From: Stefano Stabellini > > Introduce a device tree binding for Xen reserved-memory regions. They > are used to share memory across VMs from the VM config files. (See > static_shm config option.) > > Signed-off-by: Stefano

Re: [Xen-devel] [PATCH v4] devicetree, xen: add xen, shared-memory binding

2018-12-03 Thread Rob Herring
Missing the DT list... On Mon, Dec 3, 2018 at 3:43 PM Stefano Stabellini wrote: > > From: Stefano Stabellini > > Introduce a device tree binding for Xen reserved-memory regions. They > are used to share memory across VMs from the VM config files. (See > static_shm config option.) > >

Re: [Xen-devel] [PATCH v2] devicetree, xen: add xen, shared-memory binding

2018-10-22 Thread Rob Herring
On Mon, Oct 22, 2018 at 11:27:23AM +0100, Julien Grall wrote: > Hi Stefano, > > On 18/10/2018 23:10, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > Introduce a device tree binding for Xen reserved-memory regions. They > > are used to share memory across VMs from the VM config

Re: [Xen-devel] [PATCH] devicetree, xen: add xen, shared-memory binding

2018-10-17 Thread Rob Herring
On Mon, Oct 08, 2018 at 04:03:54PM -0700, Stefano Stabellini wrote: > Introduce a device tree binding for Xen reserved-memory regions. They > are used to share memory across VMs from the VM config files. (See > static_shm config option.) > > Signed-off-by: Stefano Stabellini checkpatch.pl