Re: [Xen-devel] [PATCH] xen/pirq: fix error path cleanup when binding MSIs

2018-03-15 Thread Shah, Amit
On Mi, 2018-02-28 at 09:19 +, Roger Pau Monne wrote: > Current cleanup in the error path of xen_bind_pirq_msi_to_irq is > wrong. First of all there's an off-by-one in the cleanup loop, which > can lead to unbinding wrong IRQs. > > Secondly IRQs not bound won't be freed, thus leaking IRQ

Re: [Xen-devel] [PATCH] xen/pirq: fix error path cleanup when binding MSIs

2018-02-28 Thread Shah, Amit
On Mi, 2018-02-28 at 09:19 +, Roger Pau Monne wrote: > Current cleanup in the error path of xen_bind_pirq_msi_to_irq is > wrong. First of all there's an off-by-one in the cleanup loop, which > can lead to unbinding wrong IRQs. > > Secondly IRQs not bound won't be freed, thus leaking IRQ

Re: [Xen-devel] [PATCH v2 2/2] xen: events: free irqs in error condition

2018-02-28 Thread Shah, Amit
On Mi, 2018-02-28 at 08:16 +, Roger Pau Monné wrote: > On Tue, Feb 27, 2018 at 05:32:53PM +0000, Shah, Amit wrote: > > > > > > On Di, 2018-02-27 at 17:07 +, Roger Pau Monné wrote: > > > > > > On Tue, Feb 27, 2018 at 03:55:58PM +, Amit Shah w

Re: [Xen-devel] [PATCH v2 2/2] xen: events: free irqs in error condition

2018-02-27 Thread Shah, Amit
On Di, 2018-02-27 at 17:07 +, Roger Pau Monné wrote: > On Tue, Feb 27, 2018 at 03:55:58PM +, Amit Shah wrote: > > > > In case of errors in irq setup for MSI, free up the allocated irqs. > > > > Fixes: 4892c9b4ada9f9 ("xen: add support for MSI message groups") > > Reported-by: Hooman

Re: [Xen-devel] [PATCH 2/2] xen: events: free irqs in error condition

2018-02-27 Thread Shah, Amit
On Di, 2018-02-27 at 08:14 +, Roger Pau Monné wrote: > On Mon, Feb 26, 2018 at 06:57:03PM +0000, Shah, Amit wrote: > > > > > > On Mo, 2018-02-26 at 18:14 +, Roger Pau Monné wrote: > > > > > > On Mon, Feb 26, 2018 at 05:36:35PM +, Amit Shah w

Re: [Xen-devel] [PATCH 2/2] xen: events: free irqs in error condition

2018-02-26 Thread Shah, Amit
On Mo, 2018-02-26 at 18:14 +, Roger Pau Monné wrote: > On Mon, Feb 26, 2018 at 05:36:35PM +, Amit Shah wrote: > > > > In case of errors in irq setup for MSI, free up the allocated irqs. > > > > Fixes: 4892c9b4ada9f9 ("xen: add support for MSI message groups") > > Reported-by: Hooman

Re: [Xen-devel] [PATCH] Propagate microcode update errors

2018-02-16 Thread Shah, Amit
On Fr, 2018-02-16 at 13:19 +, Peter Lawthers wrote: > From: Uwe Dannowski > > Errors on updating the microcode in the processor were silently > dropped when invoked via the microcode_update hypercall. Also, the > log > message was misleading. > > Signed-off-by: Uwe