Re: [PATCH 13/15] raid: Remove now superfluous sentinel element from ctl_table array

2023-09-28 Thread Song Liu
= sizeof(int), > .mode = S_IRUGO|S_IWUSR, > .proc_handler = proc_dointvec, > - }, > - { } > + } > }; Please keep "}," as Greg suggested. Otherwise, Acked-by: Song Liu Thanks, Song

Re: [PATCH 4/7] md: simplify sysctl registration

2023-03-03 Thread Song Liu
On Thu, Mar 2, 2023 at 12:46 PM Luis Chamberlain wrote: > > register_sysctl_table() is a deprecated compatibility wrapper. > register_sysctl() can do the directory creation for you so just use > that. > > Signed-off-by: Luis Chamberlain Acked-by: Song Liu Thanks!

Re: [PATCH 06/11] raid5: don't set the discard_alignment queue limit

2022-04-25 Thread Song Liu
ut also useless. > > Signed-off-by: Christoph Hellwig Acked-by: Song Liu > --- > drivers/md/raid5.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c > index 59f91e392a2ae..39b0afdf40d0a 100644 > --- a/drivers/md/raid5

Re: [PATCH 28/78] md: implement ->set_read_only to hook into BLKROSET processing

2020-11-16 Thread Song Liu
On Mon, Nov 16, 2020 at 6:58 AM Christoph Hellwig wrote: > > Implement the ->set_read_only method instead of parsing the actual > ioctl command. > > Signed-off-by: Christoph Hellwig Acked-by: Song Liu [...]

Re: [PATCH 22/24] md: remove a spurious call to revalidate_disk_size in update_size

2020-11-06 Thread Song Liu
On Fri, Nov 6, 2020 at 11:04 AM Christoph Hellwig wrote: > > None of the ->resize methods updates the disk size, so calling > revalidate_disk_size here won't do anything. > > Signed-off-by: Christoph Hellwig Acked-by: Song Liu > --- > drivers/md/md-cluster.

Re: [PATCH 21/24] md: use set_capacity_and_notify

2020-11-06 Thread Song Liu
On Fri, Nov 6, 2020 at 11:04 AM Christoph Hellwig wrote: > > Use set_capacity_and_notify to set the size of both the disk and block > device. This also gets the uevent notifications for the resize for free. > > Signed-off-by: Christoph Hellwig Acked-by: Song Liu

Re: [Xen-devel] [PATCH] block: refactor duplicated macros

2020-03-10 Thread Song Liu
scsi/xen-scsifront.c | 4 ++-- > fs/iomap/buffered-io.c | 2 +- > fs/nfs/blocklayout/blocklayout.h | 2 -- > include/linux/blkdev.h | 4 > include/linux/device-mapper.h| 1 - > 17 files changed, 26 insertions(+), 35 deletions(-) For md: Ack