Re: [PATCH io_uring-next/net-next v2 0/4] implement io_uring notification (ubuf_info) stacking

2024-04-22 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 19 Apr 2024 12:08:38 +0100 you wrote: > Please, don't take directly, conflicts with io_uring. > > To have per request buffer notifications each zerocopy io_uring send > request allocates a new ubuf_info.

Re: [PATCH net] xen-netfront: Add missing skb_mark_for_recycle

2024-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 27 Mar 2024 13:14:56 +0100 you wrote: > Notice that skb_mark_for_recycle() is introduced later than fixes tag in > 6a5bcd84e886 ("page_pool: Allow drivers to hint on SKB recycling"). > > It is believed that fixes

Re: [PATCH v4 bpf-next 0/2] mm: Enforce ioremap address space and introduce sparse vm_area

2024-03-06 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (master) by Andrii Nakryiko : On Mon, 4 Mar 2024 19:05:14 -0800 you wrote: > From: Alexei Starovoitov > > v3 -> v4 > - dropped VM_XEN patch for now. It will be in the follow up. > - fixed constant as pointed out by Mike > > v2 -> v3 > -

Re: [PATCH net] xen-netback: properly sync TX responses

2024-02-01 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 29 Jan 2024 14:03:08 +0100 you wrote: > Invoking the make_tx_response() / push_tx_responses() pair with no lock > held would be acceptable only if all such invocations happened from the > same context (NAPI

Re: [PATCH 0/1] Add software timestamp capabilities to xen-netback device

2023-10-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Tue, 10 Oct 2023 15:26:29 +0100 you wrote: > Hi all, > > during some experiment using PTP (ptp4l) between a Dom0 domain and a DomU > guest, > I noticed that the virtual interface brought up by the toolstack was

Re: [PATCH] xen-netback: use default TX queue size for vifs

2023-10-08 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Thu, 5 Oct 2023 16:08:31 +0200 you wrote: > Do not set netback interfaces (vifs) default TX queue size to the ring size. > The TX queue size is not related to the ring size, and using the ring size > (32) > as the

Re: [PATCH v3] xen/netback: use same error messages for same errors

2023-03-30 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Wed, 29 Mar 2023 10:02:59 +0200 you wrote: > Issue the same error message in case an illegal page boundary crossing > has been detected in both cases where this is tested. > > Suggested-by: Jan Beulich > Signed-off-by:

Re: [PATCH 0/2] xen/netback: fix issue introduced recently

2023-03-28 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (main) by Paolo Abeni : On Mon, 27 Mar 2023 10:36:44 +0200 you wrote: > The fix for XSA-423 introduced a bug which resulted in loss of network > connection in some configurations. > > The first patch is fixing the issue, while the second one is

Re: [PATCH v2 0/3] xen/netback: fix issue introduced recently

2023-03-28 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (main) by Paolo Abeni : On Tue, 28 Mar 2023 15:10:44 +0200 you wrote: > The fix for XSA-423 introduced a bug which resulted in loss of network > connection in some configurations. > > The first patch is fixing the issue, while the second one is

Re: [PATCH] xen-netback: remove unused variables pending_idx and index

2023-02-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Sun, 26 Feb 2023 11:34:29 -0500 you wrote: > building with gcc and W=1 reports > drivers/net/xen-netback/netback.c:886:21: error: variable > ‘pending_idx’ set but not used [-Werror=unused-but-set-variable] >

Re: [PATCH net] xen/netback: don't call kfree_skb() under spin_lock_irqsave()

2022-12-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni : On Mon, 5 Dec 2022 22:13:33 +0800 you wrote: > It is not allowed to call kfree_skb() from hardware interrupt > context or with interrupts being disabled. So replace kfree_skb() > with dev_kfree_skb_irq() under

Re: [PATCH net] xen-netfront: Fix NULL sring after live migration

2022-12-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 2 Dec 2022 08:52:48 + you wrote: > A NAPI is setup for each network sring to poll data to kernel > The sring with source host is destroyed before live migration and > new sring with target host is setup

Re: [PATCH net-next 0/4] shrink struct ubuf_info

2022-09-28 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski : On Fri, 23 Sep 2022 17:39:00 +0100 you wrote: > struct ubuf_info is large but not all fields are needed for all > cases. We have limited space in io_uring for it and large ubuf_info > prevents some struct

Re: [PATCH] xen-netback: use kstrdup instead of open-coding it

2022-09-23 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Wed, 21 Sep 2022 02:16:17 + you wrote: > From: Minghao Chi > > use kstrdup instead of open-coding it. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > > [...] Here is the summary with

Re: [PATCH -next] xen-netfront: make bounce_skb static

2022-09-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Wed, 14 Sep 2022 14:43:39 +0800 you wrote: > The symbol is not used outside of the file, so mark it static. > > Fixes the following warning: > > ./drivers/net/xen-netfront.c:676:16: warning: symbol

Re: [PATCH net] xen-netback: only remove 'hotplug-status' when the vif is actually destroyed

2022-09-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Thu, 1 Sep 2022 12:55:54 +0100 you wrote: > Removing 'hotplug-status' in backend_disconnected() means that it will be > removed even in the case that the frontend unilaterally disconnects (which > it is free to do

Re: [PATCH v2] xen/netback: avoid entering xenvif_rx_next_skb() with an empty rx queue

2022-07-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Wed, 13 Jul 2022 15:53:22 +0200 you wrote: > xenvif_rx_next_skb() is expecting the rx queue not being empty, but > in case the loop in xenvif_rx_action() is doing multiple iterations, > the availability of another

Re: [PATCH net-next 0/2] xen-netfront: XSA-403 follow-on

2022-07-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (master) by Paolo Abeni : On Wed, 13 Jul 2022 11:18:03 +0200 you wrote: > While investigating the XSA, I did notice a few more things. The two > patches aren't really dependent on one another. > > 1: remove leftover call to

Re: [PATCH Resend] xen/netback: do some code cleanup

2022-06-08 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Wed, 8 Jun 2022 06:37:26 +0200 you wrote: > Remove some unused macros and functions, make local functions static. > > Signed-off-by: Juergen Gross > Acked-by: Wei Liu > --- >

Re: [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS()

2022-05-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni : On Mon, 30 May 2022 13:34:59 +0200 you wrote: > Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case > of RING_HAS_UNCONSUMED_REQUESTS(). > > Reported-by: Jan Beulich > Fixes: 6fac592cca60 ("xen: update

Re: [PATCH v2] xen/netfront: destroy queues before real_num_tx_queues is zeroed

2022-02-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Wed, 23 Feb 2022 22:19:54 +0100 you wrote: > xennet_destroy_queues() relies on info->netdev->real_num_tx_queues to > delete queues. Since d7dac083414eb5bb99a6d2ed53dc2c1b405224e5 > ("net-sysfs: update the queue

Re: [PATCH v2 1/2] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose"

2022-02-24 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (master) by Jakub Kicinski : On Tue, 22 Feb 2022 01:18:16 +0100 you wrote: > This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2. > > The 'hotplug-status' node should not be removed as long as the vif > device remains configured.

Re: [PATCH 1/1] xen/netfront: stop tx queues during live migration

2021-10-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 22 Oct 2021 16:31:39 -0700 you wrote: > The tx queues are not stopped during the live migration. As a result, the > ndo_start_xmit() may access netfront_info->queues which is freed by >

Re: [PATCH] xen-netback: Remove redundant initialization of variable err

2021-10-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Wed, 13 Oct 2021 17:51:42 +0100 you wrote: > From: Colin Ian King > > The variable err is being initialized with a value that is never read, it > is being updated immediately afterwards. The assignment is

Re: [PATCH net][RESEND] xen-netback: correct success/error reporting for the SKB-with-fraglist case

2021-09-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 17 Sep 2021 08:27:10 +0200 you wrote: > When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the > special considerations for the head of the SKB no longer apply. Don't > mistakenly report ERROR to the

Re: [PATCH v2 0/4] xen: harden netfront against malicious backends

2021-08-25 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 24 Aug 2021 12:28:05 +0200 you wrote: > Xen backends of para-virtualized devices can live in dom0 kernel, dom0 > user land, or in a driver domain. This means that a backend might > reside in a less trusted

Re: [PATCH] xen-netback: Check for hotplug-status existence before watching

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 13 Apr 2021 16:25:12 +0100 you wrote: > The logic in connect() is currently written with the assumption that > xenbus_watch_pathfmt() will return an error for a node that does not > exist. This assumption is incorrect:

Re: [PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating

2021-03-01 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 25 Feb 2021 16:39:01 +0100 you wrote: > shinfo already holds the result of skb_shinfo(skb) at this point - no > need to re-invoke the construct even twice. > > Signed-off-by: Jan Beulich Here is the summary with

Re: [PATCH] drivers: net: xen-netfront: Simplify the calculation of variables

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 2 Feb 2021 18:17:49 +0800 you wrote: > Fix the following coccicheck warnings: > > ./drivers/net/xen-netfront.c:1816:52-54: WARNING !A || A && B is > equivalent to !A || B. > > Reported-by: Abaci Robot >

Re: [RESEND v2 0/7] Rid W=1 warnings in Ethernet

2021-01-16 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 15 Jan 2021 20:08:58 + you wrote: > Resending the stragglers again. > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly