On 05/09/2024 11:41, Andrew Cooper wrote:
STDVGA caching is primarily (exclusively?) an optimisation for Windows XP.
I think it was originally for Win2K (white splash screen).
Paul
dings it appears that the only thing that will work
globally is to define 'sector-size' is strictly 512 and deprecate any
large sector size support of any kind.
Paul
On 02/09/2024 16:23, Roger Pau Monné wrote:
On Mon, Sep 02, 2024 at 03:19:56PM +0100, Paul Durrant wrote:
On 02/09/2024 09:55, Roger Pau Monné wrote:
[snip]
Thanks for your input. I would also like to hear from the blktap and
Windows PV drivers maintainers, as the change that I'm prop
to a frontend that sets
feature-large-sector-size if sector-size != 512? Is that right?
Paul
t val)
d->shutdown_code = SHUTDOWN_crash;
spin_unlock(&d->shutdown_lock);
-gprintk(XENLOG_WARNING, "VIRIDIAN CRASH: %lx %lx %lx %lx %lx\n",
+gprintk(XENLOG_WARNING,
+"VIRIDIAN GUEST_CRASH: %#lx %#lx %#lx %#lx %#l
| 2 +-
xen/arch/x86/hvm/viridian/viridian.c| 4 ++--
xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 17 +++--
xen/arch/x86/traps.c| 5 +++--
4 files changed, 17 insertions(+), 11 deletions(-)
Viridian changes...
Acked-by: Paul Durrant
: Gerd Hoffmann
---
include/ui/surface.h| 4 ++--
hw/display/qxl-render.c | 2 +-
hw/display/vga.c| 20 ++--
hw/display/xenfb.c | 5 +++--
ui/console.c| 3 ++-
5 files changed, 18 insertions(+), 16 deletions(-)
Reviewed-by: Paul Durrant
alized
the vga_interface_type variable.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/xen/xen-legacy-backend.h | 3 ---
hw/display/xenfb.c | 9 +++--
hw/xenpv/xen_machine_pv.c | 2 --
3 files changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Paul Durrant
kend.c | 16
6 files changed, 20 insertions(+), 38 deletions(-)
Reviewed-by: Paul Durrant
(+), 7 deletions(-)
Reviewed-by: Paul Durrant
| 4 ++--
4 files changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Paul Durrant
(-)
Reviewed-by: Paul Durrant
On 10/05/2024 11:49, Philippe Mathieu-Daudé wrote:
XenDevOps @ops is not updated, mark it const.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/xen/xen_pvdev.h | 2 +-
hw/xen/xen-legacy-backend.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Paul Durrant
;xen_console_ops' in commit 9b77374690 ("hw/xen: update Xen
console to XenDevice model"). Remove them.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/xen/xen-legacy-backend.h | 3 ---
1 file changed, 3 deletions(-)
Reviewed-by: Paul Durrant
continue processing them. This lets
QEMU go back to the main loop and catch up.
Signed-off-by: Ross Lagerwall
---
hw/xen/xen-hvm-common.c | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
Reviewed-by: Paul Durrant
On 08/04/2024 14:00, Ross Lagerwall wrote:
On Sat, Apr 6, 2024 at 11:58 AM Durrant, Paul wrote:
On 04/04/2024 15:08, Ross Lagerwall wrote:
A malicious or buggy guest may generated buffered ioreqs faster than
QEMU can process them in handle_buffered_iopage(). The result is a
livelock - QEMU
(+), 9 deletions(-)
Reviewed-by: Paul Durrant
On 25/03/2024 12:21, Jesper Dangaard Brouer wrote:
Hi Arthur,
(Answer inlined below, which is custom on this mailing list)
On 23/03/2024 14.23, Arthur Borsboom wrote:
Hi Jesper,
After a recent kernel upgrade 6.7.6 > 6.8.1 all my Xen guests on Arch
Linux are dumping kernel traces.
It seems to
From: Paul Durrant
I am not as actively involved with the Xen project as I once was so I need
to relinquish some of my maintainer responsibilities: IOMMU and I/O
emulation.
NOTE: Since I am sole maintainer for I/O EMULATION (IOREQ) and
X86 I/O EMULATION, these sections are removed
Hi Julien
Am 04.03.2024 um 23:15 schrieb Julien Grall:
Hi Paul,
On 01/03/2024 19:37, Paul Leiber wrote:
Stopping xen-watchdog prevents the reboot. However, when triggering
traffic on the VLAN, Dom0 and DomU become completely unresponsive. No
error or kernel message is printed in the serial
Hi,
Am 18.02.2024 um 18:49 schrieb Julien Grall:
Hi,
On 17/02/2024 21:46, Paul Leiber wrote:
Am 22.01.2024 um 11:46 schrieb George Dunlap:
On Fri, Jan 19, 2024 at 8:32 PM Elliott Mitchell
wrote:
On Sun, Jan 14, 2024 at 10:54:24PM +0100, Paul Leiber wrote:
Am 22.10.2023 um 07:42 schrieb
Am 22.01.2024 um 11:46 schrieb George Dunlap:
On Fri, Jan 19, 2024 at 8:32 PM Elliott Mitchell wrote:
On Sun, Jan 14, 2024 at 10:54:24PM +0100, Paul Leiber wrote:
Am 22.10.2023 um 07:42 schrieb Paul Leiber:
Am 13.10.2023 um 20:56 schrieb Paul Leiber:
Hi Xen developers list,
TL;DR
Am 25.01.2024 um 09:12 schrieb Bertrand Marquis:
Hi Paul,
Please keep me in CC so that i can more easily find out that you answered me :-)
On 25 Jan 2024, at 00:05, Paul Leiber wrote:
Elliot, Bertrand, George: Thanks for your replies.
Am 23.01.2024 um 09:29 schrieb Bertrand Marquis:
Hi
On 13/02/2024 11:21, Breno Leitao wrote:
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Xen backend network module.
Signed-off-by: Breno Leitao
---
drivers/net/xen-netback/netback.c | 1 +
1 file changed, 1 insertion(+)
Acked-by: Paul
el Andreas
Signed-off-by: Jan Beulich
Just noticed that I forgot to Cc Paul.
Jan
---
While probably I could be convinced to omit the #ifndef, I'm really
considering to extend the one in hvmemul_unmap_linear_addr(), to
eliminate the zapping from release builds: Leaving MFN 0 in place is
k (or otherwise)?
Thanks, Jan
Yes, no objections.
Acked-by: Paul Durrant
--- a/xen/arch/x86/guest/hyperv/hyperv.c
+++ b/xen/arch/x86/guest/hyperv/hyperv.c
@@ -207,7 +207,7 @@ static int cf_check flush_tlb(
return hyperv_flush_tlb(mask, va, flags);
}
-static const struct hypervisor_ops
y xenvif_tx_build_gops() works
precludes an ADD and a DEL coming together in a single dummy request
(the DEL would be ignored).
It appears the Solaris backend never coped with multiple extra_info so
what the 'correct' semantic would be is unclear.
Anyway...
Reviewed-by: Paul Durrant
- constify the txp parameters,
- correct xenvif_idx_release()'s status parameter's type,
- rename {,_}make_tx_response()'s status parameters for consistency with
xenvif_idx_release()'s.
Hi Paul, is this one on your TODO list to review or should
we do our best? :)
Sorry for the delay. I'll take a look at this now.
Paul
| 53 ++-
xen/arch/x86/tboot.c | 2 +-
5 files changed, 3 insertions(+), 61 deletions(-)
Reviewed-by: Paul Durrant
ase.
x86/iommu: add CHANGELOG entry for hwdom setup time improvements
Signed-off-by: Roger Pau Monné
Reviewed-by: Paul Durrant
/x86/include/asm/hvm/io.h | 3 ++
xen/arch/x86/include/asm/setup.h| 1 +
xen/arch/x86/setup.c| 48 +++
xen/drivers/passthrough/x86/iommu.c | 61 +
5 files changed, 129 insertions(+)
Reviewed-by: Paul Durrant
Fri, Jan 19, 2024 at 8:32 PM Elliott Mitchell wrote:
On Sun, Jan 14, 2024 at 10:54:24PM +0100, Paul Leiber wrote:
Am 22.10.2023 um 07:42 schrieb Paul Leiber:
Am 13.10.2023 um 20:56 schrieb Paul Leiber:
Hi Xen developers list,
TL;DR:
--
Causing certain web server traffic on a secondary
Am 22.10.2023 um 07:42 schrieb Paul Leiber:
Am 13.10.2023 um 20:56 schrieb Paul Leiber:
Hi Xen developers list,
TL;DR:
--
Causing certain web server traffic on a secondary VLAN on Raspberry Pi
under vanilla Debian/UEFI in combination with Xen leads to complete
system reboot (watchdog
+-
1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Paul Durrant
: add option to disable legacy
backends"
- Do not move xenstore global variable from xen-legacy-backend.c,
instead use a local variable.
---
accel/xen/xen-all.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
Reviewed-by: Paul Durrant
/test-replication.c | 11 --
util/async.c | 4 -
util/vhost-user-server.c | 3 -
scripts/block-coroutine-wrapper.py | 3 -
tests/tsan/suppressions.tsan | 1 -
41 files changed, 102 insertions(+), 1202 deletions(-)
Reviewed-by: Paul Durrant
ons(+), 25 deletions(-)
Reviewed-by: Paul Durrant
les changed, 502 insertions(+), 502 deletions(-)
Reviewed-by: Paul Durrant
PV
mouse and keyboard to Windows instances so it's be nice if we can avoid
the backend withering away.
Paul
On 22/11/2023 23:04, David Woodhouse wrote:
On Wed, 2023-11-22 at 22:56 +, Volodymyr Babchuk wrote:
Paul Durrant writes:
On 21/11/2023 22:10, Volodymyr Babchuk wrote:
From: David Woodhouse
This allows a XenDevice implementation to know whether it was
created
by QEMU, or merely
at 14:29 -0800, Stefano Stabellini wrote:
On Wed, 22 Nov 2023, Paul Durrant wrote:
On 21/11/2023 22:10, Volodymyr Babchuk wrote:
From: Oleksandr Tyshchenko
Instead of forcing the owner to domid 0, use XS_PRESERVE_OWNER to
inherit the owner of the directory.
Ah... so that's why the pre
On 21/11/2023 22:10, Volodymyr Babchuk wrote:
From: Oleksandr Tyshchenko
Instead of forcing the owner to domid 0, use XS_PRESERVE_OWNER to
inherit the owner of the directory.
Ah... so that's why the previous patch is there.
This is not the right way to fix it. The QEMU Xen support is *assumi
On 21/11/2023 22:10, Volodymyr Babchuk wrote:
Add option to preserve owner when creating an entry in Xen Store. This
may be needed in cases when Qemu is working as device model in a
*may* be needed?
I don't undertstand why this patch is necessary and the commit comment
isn't really helping me
ently uses
xen_backend_list_find() to check whether the specified XenDevice has an
associated XenBackendInstance.
Paul
On 21/11/2023 22:10, Volodymyr Babchuk wrote:
was created by QEMU
Xen PV devices in QEMU can be created in two ways: either by QEMU
itself, if they were passed via command line, or by Xen toolstack. In
the latter case, QEMU scans XenStore entries and configures devices
accordingly.
In the secon
/xen_nic.c | 2 +-
hw/xen/xen-bus.c | 4
include/hw/xen/xen-backend.h | 2 --
include/hw/xen/xen-bus.h | 2 ++
6 files changed, 9 insertions(+), 6 deletions(-)
Reviewed-by: Paul Durrant
On 15/11/2023 17:24, David Woodhouse wrote:
From: David Woodhouse
If a Xen console is configured on the command line, do not add a default
serial port.
Signed-off-by: David Woodhouse
---
system/vl.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Paul Durrant
de to hopefully make it clearer to Coverity and human reviewers
alike.
Signed-off-by: David Woodhouse
---
hw/block/xen-block.c | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
Reviewed-by: Paul Durrant
oded
to 0 at the moment but surely a backend domid (which defaults to 0)
could be passed on the command line?
Paul
Signed-off-by: Volodymyr Babchuk
---
hw/i386/kvm/xen_xenstore.c | 18 ++
hw/xen/xen-operations.c | 12
include/hw/xen/xen_backend_
art (e.g. for a driver update)? I'm guessing the backend will be
destroyed... which is not very friendly.
Paul
toolstack were discovered.
In the latter case there should be a XenBackendInstance that corresponds
to the XenDevice whereas in the former case there should not be. For
example, see xen_backend_try_device_destroy()
Paul
Signed-off-by: Oleksandr Tyshchenko
Signed-off-by: Volodymyr Babchuk
de to hopefully make it clearer to Coverity and human reviewers
alike.
Signed-off-by: David Woodhouse
---
hw/block/xen-block.c | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
Reviewed-by: Paul Durrant
.rst | 107 +--
qemu-options.hx | 14 +++--
3 files changed, 91 insertions(+), 32 deletions(-)
Reviewed-by: Paul Durrant
fs
option is set.
Signed-off-by: David Woodhouse
---
docs/sphinx/hxtool.py | 18 +-
docs/system/invocation.rst | 1 +
2 files changed, 18 insertions(+), 1 deletion(-)
Reviewed-by: Paul Durrant
2 +-
hw/i386/pc_q35.c | 2 +-
hw/xen/xen-bus.c | 4 +++-
include/hw/i386/pc.h | 4 +++-
include/hw/xen/xen-bus.h | 2 +-
6 files changed, 17 insertions(+), 8 deletions(-)
Reviewed-by: Paul Durrant
ed, 125 insertions(+), 46 deletions(-)
Reviewed-by: Paul Durrant
using QAPI).
This allows making passthrough devices appear as functions in a Xen
guest.
Signed-off-by: Ross Lagerwall
Reviewed-by: Paul Durrant
On 27/10/2023 11:25, David Woodhouse wrote:
On Fri, 2023-10-27 at 10:01 +0100, Durrant, Paul wrote:
This code is allocating a name automatically so I think the onus is on
it not create a needless clash which is likely to have unpredictable
results depending on what the guest is. Just avoid any
_devconfig.c | 25 -
hw/xenpv/xen_machine_pv.c | 9 -
include/hw/xen/xen-legacy-backend.h | 1 -
4 files changed, 4 insertions(+), 35 deletions(-)
Yay! I've been wanting this for years but ETIME.
Reviewed-by: Paul Durrant
rtions(+), 12 deletions(-)
Reviewed-by: Paul Durrant
pci_init_nic_in_slot() for that
purpose.
Signed-off-by: David Woodhouse
---
hw/pci/pci.c | 45
include/hw/pci/pci.h | 4 +++-
2 files changed, 48 insertions(+), 1 deletion(-)
Reviewed-by: Paul Durrant
e
actually want more).
Signed-off-by: David Woodhouse
---
include/net/net.h | 3 +++
net/net.c | 53 +++
2 files changed, 56 insertions(+)
Reviewed-by: Paul Durrant
Woodhouse
---
net/net.c | 94 +++
1 file changed, 94 insertions(+)
Reviewed-by: Paul Durrant
nged, 57 insertions(+), 1 deletion(-)
Reviewed-by: Paul Durrant
+++-
1 file changed, 45 insertions(+), 23 deletions(-)
Reviewed-by: Paul Durrant
On 27/10/2023 09:45, David Woodhouse wrote:
On Fri, 2023-10-27 at 08:30 +0100, Durrant, Paul wrote:
+ if (blockdev->props.vdev.type == XEN_BLOCK_VDEV_TYPE_INVALID) {
+ XenBus *xenbus = XEN_BUS(qdev_get_parent_bus(DEVICE(xendev)));
+ char fe_path[XENSTORE_ABS_PATH_MAX
#x27; pointer. But
we can store the *previous* entry, since nics are safe.
Signed-off-by: David Woodhouse
---
net/net.c | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
Reviewed-by: Paul Durrant
"vif%u: FIXME: more data flag\n",
+ netdev->dev);
net_tx_error(netdev, &txreq, rc);
continue;
}
#endif
I know that this is just translation but the fact the above code is
there indicates that you're likely to see problems here. Not supporting
extra_info is likely ok as long as RSS, TSO or multicast filtering is
not advertized (as the comment says). But lack of support for more_data
basically means your frontend needs to send all packets in a single frag
(e.g. no header split) so that might bite pretty quickly. I guess it
goes to show that no-one has used this code in many many years.
The translation looks ok to me though so...
Reviewed-by: Paul Durrant
ed, 7 insertions(+), 2 deletions(-)
Reviewed-by: Paul Durrant
11 files changed, 328 insertions(+), 23 deletions(-)
create mode 100644 hw/i386/kvm/xen_primary_console.c
create mode 100644 hw/i386/kvm/xen_primary_console.h
Reviewed-by: Paul Durrant
--
hw/xen/xen-bus.c | 11 ++-
include/hw/xen/xen-bus.h | 2 ++
2 files changed, 12 insertions(+), 1 deletion(-)
Reviewed-by: Paul Durrant
enbus = XEN_BUS(qdev_get_parent_bus(DEVICE(xendev)));
+char fe_path[XENSTORE_ABS_PATH_MAX + 1];
+char *value;
+int disk = 0;
+unsigned long idx;
+
+/* Find an unoccupied device name */
Not sure this is going to work is it? What happens if 'hda' or
On 25/10/2023 15:50, David Woodhouse wrote:
From: David Woodhouse
Upstream Xen now ignores this flag¹, since the only guest kernel ever to
use it was buggy.
¹ https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=19c6cbd909
Signed-off-by: David Woodhouse
Reviewed-by: Paul Durrant
d-off-by: David Woodhouse
---
hw/block/xen-block.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Paul Durrant
Signed-off-by: David Woodhouse
---
hw/i386/kvm/xen_evtchn.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Paul Durrant
ork,
so the emu implementation follows suit.
This fixes Xen device hot-unplug.
Fixes: 0254c4d19df ("hw/xen: Add xenstore wire implementation and implementation
stubs")
Signed-off-by: David Woodhouse
---
hw/i386/kvm/xen_xenstore.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Paul Durrant
On 25/10/2023 10:00, David Woodhouse wrote:
On Wed, 2023-10-25 at 09:31 +0100, Paul Durrant wrote:
On 24/10/2023 17:34, David Woodhouse wrote:
On Tue, 2023-10-24 at 17:25 +0100, Paul Durrant wrote:
On 24/10/2023 16:49, David Woodhouse wrote:
On Tue, 2023-10-24 at 16:39 +0100, Paul Durrant
On 24/10/2023 17:34, David Woodhouse wrote:
On Tue, 2023-10-24 at 17:25 +0100, Paul Durrant wrote:
On 24/10/2023 16:49, David Woodhouse wrote:
On Tue, 2023-10-24 at 16:39 +0100, Paul Durrant wrote:
On 24/10/2023 16:37, David Woodhouse wrote:
On Tue, 2023-10-24 at 15:20 +0100, Paul Durrant
On 24/10/2023 16:49, David Woodhouse wrote:
On Tue, 2023-10-24 at 16:39 +0100, Paul Durrant wrote:
On 24/10/2023 16:37, David Woodhouse wrote:
On Tue, 2023-10-24 at 15:20 +0100, Paul Durrant wrote:
On 16/10/2023 16:19, David Woodhouse wrote:
From: David Woodhouse
The primary console is
On 24/10/2023 16:48, David Woodhouse wrote:
On Tue, 2023-10-24 at 16:44 +0100, Paul Durrant wrote:
On 19/10/2023 16:40, David Woodhouse wrote:
From: David Woodhouse
On soft reset, the prinary console event channel needs to be rebound to
the backend port (in the xen-console driver). We could
sidered to be the canonical implementation.
Paul
e KVM/Xen code, by stashing the backend port# on event channel reset
and then rebinding in the primary console reset when it has to recreate
the guest port anyway.
Does Xen re-bind the primary console on EVTCHNOP_reset? That's news to
me. I go check.
Paul
Signed-off-by: David Woodhouse
On 24/10/2023 16:37, David Woodhouse wrote:
On Tue, 2023-10-24 at 15:20 +0100, Paul Durrant wrote:
On 16/10/2023 16:19, David Woodhouse wrote:
From: David Woodhouse
The primary console is special because the toolstack maps a page at a
fixed GFN and also allocates the guest-side event channel
ts to *rebind* to the event channel port after a reset.
Signed-off-by: David Woodhouse
---
hw/i386/kvm/xen_xenstore.c | 11 +++
1 file changed, 11 insertions(+)
Reviewed-by: Paul Durrant
e
guest has specified an oversize token then deliver_watch() will not set
rsp_pending... then put_rsp() will fail its assertion that the flag is true.
Paul
}
}
: de26b2619789 ("hw/xen: Implement soft reset for emulated gnttab")
Signed-off-by: David Woodhouse
---
hw/i386/kvm/xen_gnttab.c | 2 --
1 file changed, 2 deletions(-)
Reviewed-by: Paul Durrant
+++
3 files changed, 14 insertions(+)
Reviewed-by: Paul Durrant
(xendev, netdev->event_channel,
+errp);
+netdev->event_channel = NULL;
+}
if (netdev->txs) {
-xen_be_unmap_grant_ref(&netdev->xendev, netdev->txs,
- netdev->tx_ring_ref);
+
at we're about to delete */
+if (!klass || !object_class_dynamic_cast(klass, TYPE_PCI_DEVICE)) {
Would it not be better to test for object_class_dynamic_cast(klass,
TYPE_XEN_DEVICE)?
Paul
+return;
+}
-nc = qemu_get_queue(nic);
a more complete implementation if/when
we ever do need one.
Why can't you map the console page via the grant table like the xenstore
page?
Paul
gt;xendev = xendev;
+backend->name = g_strdup(xendev->name);
+backend->impl = impl;
+
+xen_backend_list_add(backend);
+return true;
+}
Not sure I'm getting my head around this. How does this play with the
legacy backend code? The point about having
On 24/10/2023 14:29, David Woodhouse wrote:
On Tue, 2023-10-24 at 13:59 +0100, Paul Durrant wrote:
On 24/10/2023 13:56, David Woodhouse wrote:
On Tue, 2023-10-24 at 13:42 +0100, Paul Durrant wrote:
--- a/hw/xen/xen-bus.c
+++ b/hw/xen/xen-bus.c
@@ -711,8 +711,16 @@ static void
/xen-backend.h | 1 +
3 files changed, 24 insertions(+), 7 deletions(-)
Reviewed-by: Paul Durrant
|= xencons_send(con);
}
+return done_something;
+}
-path = g_string_new(dom_path);
-free(dom_path);
+/* */
-if (con->xendev.dev) {
-g_string_append_printf(path, "/device/console/%d", con->xendev.dev);
-} else {
-g_string_append(path, "/console");
+static void xen_console_disconnect(XenDevice *xendev, Error **errp)
+{
+XenConsole *con = XEN_CONSOLE_DEVICE(xendev);
+
+qemu_chr_fe_set_handlers(&con->chr, NULL, NULL, NULL, NULL,
+ con, NULL, true);
+
nit: extraneous blank line by the looks of it.
With that fixed...
Reviewed-by: Paul Durrant
On 24/10/2023 13:56, David Woodhouse wrote:
On Tue, 2023-10-24 at 13:42 +0100, Paul Durrant wrote:
--- a/hw/xen/xen-bus.c
+++ b/hw/xen/xen-bus.c
@@ -711,8 +711,16 @@ static void xen_device_frontend_create(XenDevice *xendev,
Error **errp)
{
ERRP_GUARD();
XenBus *xenbus
if (xendev_class->get_frontend_path) {
+xendev->frontend_path = xendev_class->get_frontend_path(xendev, errp);
+if (!xendev->frontend_path) {
+return;
I think you need to update errp here to note that you are failing to
create the frontend.
Paul
allow guests to *rebind* to the event channel port after a reset.
... although this can also be done by querying the remote end of the
port before reset.
Signed-off-by: David Woodhouse
---
hw/i386/kvm/xen_xenstore.c | 10 ++
1 file changed, 10 insertions(+)
Reviewed-by: Paul Durrant
(+)
Reviewed-by: Paul Durrant
/interface/vcpu.h | 19 +--
include/hw/xen/interface/version.h| 19 +--
include/hw/xen/interface/xen-compat.h | 19 +--
include/hw/xen/interface/xen.h| 19 +--
29 files changed, 124 insertions(+), 523 deletions(-)
Acked-by: Paul
happens if the guest then disables the upcall vector (by
setting it to zero)? Xen checks 'v->arch.hvm.evtchn_upcall_vector != 0'
for every event delivery.
Paul
1 - 100 of 3989 matches
Mail list logo
