Re: [PATCH] Arm32: MSR to SPSR needs qualification

2021-06-11 Thread Julien Grall
On Fri, 11 Jun 2021, 15:02 Jan Beulich, wrote: > On 11.06.2021 12:41, Julien Grall wrote: > > On Fri, 11 Jun 2021, 11:16 Jan Beulich, wrote: > > > >> On 11.06.2021 10:00, Julien Grall wrote: > >>> On Fri, 11 Jun 2021, 08:55 Jan Beulich, wrote: > >>> > The Arm ARM's description of MSR doesn

Re: [PATCH] Arm32: MSR to SPSR needs qualification

2021-06-11 Thread Jan Beulich
On 11.06.2021 12:41, Julien Grall wrote: > On Fri, 11 Jun 2021, 11:16 Jan Beulich, wrote: > >> On 11.06.2021 10:00, Julien Grall wrote: >>> On Fri, 11 Jun 2021, 08:55 Jan Beulich, wrote: >>> The Arm ARM's description of MSR doesn't even allow for plain "SPSR" here, and while gas accept

Re: [PATCH] Arm32: MSR to SPSR needs qualification

2021-06-11 Thread Julien Grall
On Fri, 11 Jun 2021, 11:16 Jan Beulich, wrote: > On 11.06.2021 10:00, Julien Grall wrote: > > On Fri, 11 Jun 2021, 08:55 Jan Beulich, wrote: > > > >> The Arm ARM's description of MSR doesn't even allow for plain "SPSR" > >> here, and while gas accepts this, it takes it to mean SPSR_cf. Yet > >>

Re: [PATCH] Arm32: MSR to SPSR needs qualification

2021-06-11 Thread Jan Beulich
On 11.06.2021 10:00, Julien Grall wrote: > On Fri, 11 Jun 2021, 08:55 Jan Beulich, wrote: > >> The Arm ARM's description of MSR doesn't even allow for plain "SPSR" >> here, and while gas accepts this, it takes it to mean SPSR_cf. Yet >> surely all of SPSR wants updating on this path, not just the

Re: [PATCH] Arm32: MSR to SPSR needs qualification

2021-06-11 Thread Julien Grall
On Fri, 11 Jun 2021, 08:55 Jan Beulich, wrote: > The Arm ARM's description of MSR doesn't even allow for plain "SPSR" > here, and while gas accepts this, it takes it to mean SPSR_cf. Yet > surely all of SPSR wants updating on this path, not just the lowest and > highest 8 bits. > Can you provide

[PATCH] Arm32: MSR to SPSR needs qualification

2021-06-11 Thread Jan Beulich
The Arm ARM's description of MSR doesn't even allow for plain "SPSR" here, and while gas accepts this, it takes it to mean SPSR_cf. Yet surely all of SPSR wants updating on this path, not just the lowest and highest 8 bits. Fixes: dfcffb128be4 ("xen/arm32: SPSR_hyp/SPSR") Signed-off-by: Jan Beulic