Re: [PATCH] Arm32: avoid .rodata to be marked as executable

2021-06-14 Thread Julien Grall
On 14/06/2021 15:09, Julien Grall wrote: I'm fine with the new commit message, but I'd prefer the title to remain as is, as that aspect is what did trigger me making this > change. Sure. I will keep your commit title and update the commit message. Commited with: Acked-by: Julien Grall C

Re: [PATCH] Arm32: avoid .rodata to be marked as executable

2021-06-14 Thread Julien Grall
Hi Jan, On 14/06/2021 14:02, Jan Beulich wrote: On 14.06.2021 12:54, Julien Grall wrote: On 14/06/2021 12:40, Jan Beulich wrote: On 14.06.2021 11:57, Julien Grall wrote: On 11/06/2021 11:19, Jan Beulich wrote: This confuses disassemblers, at the very least. When this data still lived in .ini

Re: [PATCH] Arm32: avoid .rodata to be marked as executable

2021-06-14 Thread Jan Beulich
On 14.06.2021 12:54, Julien Grall wrote: > On 14/06/2021 12:40, Jan Beulich wrote: >> On 14.06.2021 11:57, Julien Grall wrote: >>> On 11/06/2021 11:19, Jan Beulich wrote: This confuses disassemblers, at the very least. When this data still lived in .init.*, this probably didn't matter muc

Re: [PATCH] Arm32: avoid .rodata to be marked as executable

2021-06-14 Thread Julien Grall
Hi Jan, On 14/06/2021 12:40, Jan Beulich wrote: On 14.06.2021 11:57, Julien Grall wrote: On 11/06/2021 11:19, Jan Beulich wrote: This confuses disassemblers, at the very least. When this data still lived in .init.*, this probably didn't matter much, albeit the "#execinstr" would have been susp

Re: [PATCH] Arm32: avoid .rodata to be marked as executable

2021-06-14 Thread Jan Beulich
On 14.06.2021 11:57, Julien Grall wrote: > On 11/06/2021 11:19, Jan Beulich wrote: >> This confuses disassemblers, at the very least. When this data still >> lived in .init.*, this probably didn't matter much, albeit the >> "#execinstr" would have been suspicious to me already then. But the >> late

Re: [PATCH] Arm32: avoid .rodata to be marked as executable

2021-06-14 Thread Julien Grall
Hi, On 11/06/2021 11:19, Jan Beulich wrote: This confuses disassemblers, at the very least. When this data still lived in .init.*, this probably didn't matter much, albeit the "#execinstr" would have been suspicious to me already then. But the latest with their movement to .rodata these attribut

[PATCH] Arm32: avoid .rodata to be marked as executable

2021-06-11 Thread Jan Beulich
This confuses disassemblers, at the very least. When this data still lived in .init.*, this probably didn't matter much, albeit the "#execinstr" would have been suspicious to me already then. But the latest with their movement to .rodata these attributes should have been dropped. Fixes: 9cbe093b7b