Re: [PATCH] PCI/MSI: msix_setup_msi_descs: Restore logic for msi_attrib.can_mask

2022-02-11 Thread Bjorn Helgaas
On Fri, Feb 11, 2022 at 01:10:22AM +0100, Josef Johansson wrote: > On 2/11/22 00:55, Bjorn Helgaas wrote: > > On Sat, Jan 22, 2022 at 02:10:01AM +0100, Josef Johansson wrote: > >> From: Josef Johansson > >> > >> PCI/MSI: msix_setup_msi_descs: Restore logic for msi_attrib.can_mask > > Please match

Re: [PATCH] PCI/MSI: msix_setup_msi_descs: Restore logic for msi_attrib.can_mask

2022-02-10 Thread Jason Gunthorpe
On Thu, Feb 10, 2022 at 05:55:32PM -0600, Bjorn Helgaas wrote: > > Commit 71020a3c0dff4 ("PCI/MSI: Use msi_add_msi_desc()") modifies > > the logic of checking msi_attrib.can_mask, without any reason. > > > > This commits restores that logic. > > I agree, this looks like a typo in

Re: [PATCH] PCI/MSI: msix_setup_msi_descs: Restore logic for msi_attrib.can_mask

2022-02-10 Thread Bjorn Helgaas
[+cc Jason, since you reviewed the original commit] On Sat, Jan 22, 2022 at 02:10:01AM +0100, Josef Johansson wrote: > From: Josef Johansson > > PCI/MSI: msix_setup_msi_descs: Restore logic for msi_attrib.can_mask Please match the form and style of previous subject lines (in particular, omit